Commit Graph

1806 Commits

Author SHA1 Message Date
Sergey Biryukov
0d8921de03 Add braces around conditionals. props TobiasBg. fixes #25704.
git-svn-id: https://develop.svn.wordpress.org/trunk@27082 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 20:16:08 +00:00
Scott Taylor
28bab15d16 Properly invalidate the cache for wp_count_posts() on insert, trash, or when transitioning post_status inside of _transition_post_status(). Introduces _count_posts_cache_key(). Adds unit tests.
Props mark8barnes, for bringing this to our attention in an initial patch.
Fixes #21879.



git-svn-id: https://develop.svn.wordpress.org/trunk@27081 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 19:41:40 +00:00
Andrew Ozz
9fd8c54ef9 Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854.
git-svn-id: https://develop.svn.wordpress.org/trunk@27080 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 05:30:12 +00:00
Andrew Ozz
33b079b036 Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233.
git-svn-id: https://develop.svn.wordpress.org/trunk@27079 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 23:49:05 +00:00
Andrew Ozz
90662a17f4 Editor: add :focus style for the Quicktags buttons, fixes #26932
git-svn-id: https://develop.svn.wordpress.org/trunk@27078 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:37:37 +00:00
Andrew Nacin
8c3ad4e860 Consistently trim and unslash search queries for the users list tables.
props aubreypwd.
fixes #26115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27077 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:09:19 +00:00
Andrew Nacin
ed1ece6e3b Remove an unnecessary variable passed to wpdb::prepare() during multisite load.
props jeremyfelt.
fixes #26941.


git-svn-id: https://develop.svn.wordpress.org/trunk@27076 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:08:14 +00:00
Andrew Nacin
194d6a94b7 When the MySQL server has "gone away," attempt to reconnect and retry the query.
props pento.
see #5932.


git-svn-id: https://develop.svn.wordpress.org/trunk@27075 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:06:42 +00:00
Andrew Nacin
e993ef0249 Add a comment for [27073] as someone will inevitably complain it is tricked by % in a string. see #25604.
git-svn-id: https://develop.svn.wordpress.org/trunk@27074 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 21:47:58 +00:00
Andrew Nacin
435df55864 Throw an incorrect usage notice when the query argument of wpdb::prepare() does not include a placeholder.
props ounziw.
fixes #25604.


git-svn-id: https://develop.svn.wordpress.org/trunk@27073 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 21:46:07 +00:00
Andrew Nacin
0558df56ce Ensure compatibility with MySQL 5.6 which has stricter SQL modes by default.
Disables NO_ZERO_DATE, ONLY_FULL_GROUP_BY, STRICT_TRANS_TABLES, STRICT_ALL_TABLES, TRADITIONAL. Introduces wpdb::set_sql_mode() with an incompatible_sql_modes filter so a plugin can alter the set mode after the fact.

props pento.
fixes #26847.


git-svn-id: https://develop.svn.wordpress.org/trunk@27072 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 21:38:34 +00:00
Andrew Ozz
bb49691c63 WP_Link: convert < > and " to HTML entities when setting link title for the Text editor. Fixes #25704.
git-svn-id: https://develop.svn.wordpress.org/trunk@27071 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 21:11:24 +00:00
Dominik Schilling (ocean90)
d58d7e8158 Update @return statement of wp_nonce_url(): The URL is escaped.
props c3mdigital.
see #4221.

git-svn-id: https://develop.svn.wordpress.org/trunk@27070 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 10:52:33 +00:00
Andrew Nacin
8650155a8b Use get_current_user_id() instead of $user_ID in user-edit.php.
props kovshenin.
fixes #26274.


git-svn-id: https://develop.svn.wordpress.org/trunk@27069 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 10:03:12 +00:00
Andrew Nacin
509cd20ae4 New resetpass_form hook in wp-login.php.
props romaimperator.
fixes #21044.


git-svn-id: https://develop.svn.wordpress.org/trunk@27068 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 07:51:03 +00:00
Scott Taylor
b8e7bbb0f2 Fix an error in SQL generation when perm is set and an array is passed for post_status. Adds unit test.
Props oso96_2000.
Fixes #25523.



git-svn-id: https://develop.svn.wordpress.org/trunk@27067 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 07:35:54 +00:00
Andrew Nacin
d1cc542e1f Ensure the last separator is removed from the user and network admin menus.
props johnjamesjacoby.
fixes #25425.


git-svn-id: https://develop.svn.wordpress.org/trunk@27066 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 06:18:44 +00:00
Andrew Nacin
71f951f71e Add arguments to the wp_dropdown_cats filter, and docs.
props olivM.
fixes #24103.


git-svn-id: https://develop.svn.wordpress.org/trunk@27065 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 05:32:17 +00:00
Scott Taylor
a1ffaec8b4 Remove $force argument from WP_Object_Cache::delete(). From @nacin: "This was for internal-use-only, I don't think _deprecated_argument() is needed, but let's put a comment somewhere just so we know we'd have to be careful if we ever want to add a third argument here later."
`$force` argument has been removed, and docs were updated.

Fixes #22478.



git-svn-id: https://develop.svn.wordpress.org/trunk@27064 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-01 22:24:30 +00:00
Scott Taylor
684091ac57 Let the video shortcode accept a YouTube URL as the value of its src attribute, as MediaElement.js supports Chromeless YouTube videos by using a pseudo-mime-type video/youtube.
HTTP and HTTPS www, non-www, and short url fronts are supported:
http://www.youtube.com/watch 
https://www.youtube.com/watch
http://youtube.com/watch
https://youtube.com/watch
http://youtu.be
https://youtu.be

Fixes #24764.



git-svn-id: https://develop.svn.wordpress.org/trunk@27063 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-31 18:58:25 +00:00
Andrew Ozz
01da73ac78 TinyMCE: update to 4.0.16, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27062 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-31 18:57:45 +00:00
Andrew Nacin
ec20c47e12 Update Dashicons to latest. Adds line break, paragraph, code, and bbPress.
props empireoflight, melchoyce.
see #26936.


git-svn-id: https://develop.svn.wordpress.org/trunk@27061 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-31 00:40:05 +00:00
Andrew Ozz
ced0079d88 TinyMCE: update to 4.0.14. Remove the fix for using init.setup in old plugins, now fixed upstream. See #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27060 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-31 00:05:17 +00:00
Scott Taylor
6989d828bb Upgrade MediaElement to 2.13.2 from 2.13.0. For a full list of changes: https://github.com/johndyer/mediaelement/compare/2.13.0...2.13.2
Fixes #26954.



git-svn-id: https://develop.svn.wordpress.org/trunk@27059 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 18:23:59 +00:00
Andrew Ozz
bd395b5d3e TinyMCE: add outline when a button is focused. Fixes #26931, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27058 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 18:13:32 +00:00
Scott Taylor
13c1dd0004 get_comment(), wp_get_post_revision(), and get_term() all used to return by reference. Because of this, $null was set to null so the return value would be a variable where applicable. This has not been necessary since [21792], so the $nulls have been removed.
Props toszcze.
Fixes #24768.



git-svn-id: https://develop.svn.wordpress.org/trunk@27057 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 06:45:54 +00:00
Scott Taylor
62b57d8899 In wpdb::db_connect(), allow the loading of a custom database error template - this is already allowed in dead_db().
In `dead_db()`, move the call to `wp_load_translations_early()` before the inclusion of the `db-error.php` file to allow translation in both locations before the template is loaded.

Props sbruner, kovshenin.
Fixes #25703.



git-svn-id: https://develop.svn.wordpress.org/trunk@27056 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 05:27:24 +00:00
Scott Taylor
99ef83d7aa Add Unit Tests for get_comment_pages_count(). Fix a notice caused when $wp_query->comments is not set in that function.
Props mdbitz, markjaquith.
Fixes #20633.



git-svn-id: https://develop.svn.wordpress.org/trunk@27055 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 05:16:58 +00:00
Andrew Ozz
5bb6b2ecec TinyMCE: fix Ctrl + s shortcut (trigger autosave), see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27052 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 23:28:36 +00:00
Scott Taylor
031414171e For starters, [27050] is rad. This just cleans up some extra new lines that were littered about, updates *some* of the inline docs (needs more), moves wp.media.controller.ImageDetails closer to its parent class, and de-dupes some code in media-template.php.
See #24409.



git-svn-id: https://develop.svn.wordpress.org/trunk@27051 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 23:20:04 +00:00
Andrew Ozz
20f89d7c4b Introduce Edit Image (single mode) in the media modal and use it to edit images inserted in the editor. Adds new feature: replace an image in the editor. Props gcorne, see #24409.
git-svn-id: https://develop.svn.wordpress.org/trunk@27050 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 21:16:42 +00:00
Drew Jaynes
c712a321ad Inline documentation for hooks in wp-includes/class-http.php.
Props kraftbj for the initial patches. Props kpdesign, DrewAPicture.
Fixes #26049.


git-svn-id: https://develop.svn.wordpress.org/trunk@27049 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 08:25:00 +00:00
Drew Jaynes
9224a141f3 Inline documentation for hooks in wp-admin/includes/export.php.
Props cmmarslender, kpdesign.
Fixes #26894.


git-svn-id: https://develop.svn.wordpress.org/trunk@27048 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 08:09:13 +00:00
Drew Jaynes
bbc58ef016 Inline documentation for hooks in wp-admin/includes/update-core.php.
Props JoshuaAbenazer, kpdesign.
Fixes #25998.


git-svn-id: https://develop.svn.wordpress.org/trunk@27047 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-28 08:01:36 +00:00
Helen Hou-Sandi
91b0e15ef8 Autocomplete for the new site admin email. Better than trying to remember which email address you used.
fixes #25348.


git-svn-id: https://develop.svn.wordpress.org/trunk@27046 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 23:09:08 +00:00
Andrew Nacin
bd9729c22d Add wp_install and wp_upgrade hooks to the respective functions.
props Denis-de-Bernardy.
fixes #25762.


git-svn-id: https://develop.svn.wordpress.org/trunk@27045 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 16:31:54 +00:00
Andrew Ozz
ad9f1f3258 TinyMCE: add dashicon for the "wp_page" button, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27044 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 15:05:27 +00:00
Dominik Schilling (ocean90)
ddd5e7a57f Update help content for Dashboard. props kpdesign. fixes #26632.
git-svn-id: https://develop.svn.wordpress.org/trunk@27043 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 14:46:36 +00:00
Andrew Nacin
0406e11513 Basic unit tests and additional documentation for wp_strip_all_tags().
props joehoyle.
fixes #25507.


git-svn-id: https://develop.svn.wordpress.org/trunk@27042 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 03:15:29 +00:00
Andrew Ozz
141aaa04c5 DFW: remove unused #wp-fullscreen-title-prompt-text selectors. See #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27039 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 00:38:19 +00:00
Andrew Ozz
70ca581b67 Autosave:
- Move the 'Saving post' and 'Draft saved at...' strings from autosaveL10n to postL10n as they are used only there.
- Use the custom jQuery events 'before-autosave' and 'after-autosave' to show these messages.
- Separate autosave.suspend() for local and server so local autosaves can continue while server autosaves are suspended.
- Remove the recently added autosave.server.disable() and use autosave.server.suspend() instead.
- Bring back .button.disabled, button-primary.disabled and use .disabled to prevent multiple form submissions.
See #25272.


git-svn-id: https://develop.svn.wordpress.org/trunk@27038 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-27 00:27:42 +00:00
Andrew Ozz
fbd895949f Remove one more valign, props neoxx, fixes #22712.
git-svn-id: https://develop.svn.wordpress.org/trunk@27037 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 20:37:33 +00:00
Andrew Ozz
88fecbeff9 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086.
git-svn-id: https://develop.svn.wordpress.org/trunk@27036 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 20:27:21 +00:00
Andrew Ozz
01faa993ac Fix tabbing order when opening/closing post status and visibility in the Publish postbox and cache some of the jQuery selectors. Part-props atimmer, fixes #25460.
git-svn-id: https://develop.svn.wordpress.org/trunk@27035 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 03:06:52 +00:00
Andrew Ozz
2b80ac1778 TinyMCE: do not run preventDefault() on the tab key when Ctrl, Alt or Command key is also pressed. Ctrl + Tab is used to switch between browser tabs. See #24067, fixes #17261.
git-svn-id: https://develop.svn.wordpress.org/trunk@27034 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 00:28:49 +00:00
Dominik Schilling (ocean90)
88277b4dba Remove unused code. props nofearinc. fixes #26205.
git-svn-id: https://develop.svn.wordpress.org/trunk@27033 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 00:11:18 +00:00
Scott Taylor
a103600054 Add some inline docs to methods in media-models.js - particularly around @param and @returns.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27032 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-25 08:55:47 +00:00
Scott Taylor
a386be33d5 Add some JSDoc annotations to media-models.js to disambiguate instance properties and static class properties/methods in the base media Models.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27031 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-25 07:38:12 +00:00
Andrew Ozz
be31ef4b65 TinyMCE: fix the compat3x plugin appending 'en.' to button titles. Set charset to UTF-8 in html_entity_decode() for translated strings. See #24067, see #26875.
git-svn-id: https://develop.svn.wordpress.org/trunk@27030 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-25 01:20:04 +00:00
Andrew Ozz
48d24f6bf5 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.
git-svn-id: https://develop.svn.wordpress.org/trunk@27029 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 19:05:15 +00:00