sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,737 Commits 2 Branches 473 Tags 137 MiB
106f0b7b7b
Commit Graph

1633 Commits

Author SHA1 Message Date
Andrew Nacin
d3a873840e Remove two new strings from post_preview(). 
see #25272, #27453.


git-svn-id: https://develop.svn.wordpress.org/trunk@27612 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-19 05:48:28 +00:00
nacin
877e12ee33 Improve the autosave error message on nonce failure. 
see #27453, #25272.


git-svn-id: https://develop.svn.wordpress.org/trunk@27611 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-19 05:46:02 +00:00
John Blackbourn
f850186eff Introduce permission checks for post queries and edit links in the At a Glance dashboard widget. Fixes #27132. Props mattheu. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27596 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-18 22:43:41 +00:00
John Blackbourn
d91dd88edc Remove the "See more" toggle from the At a Glance dashboard widget. Fixes #26614. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27583 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-18 12:55:42 +00:00
Andrew Nacin
c914491693 Heartbeat: Hooks should always receive unslashed data. 
This affects the privileged hooks; the unprivileged hooks already received unslashed data.

props johnbillion, TobiasBg.
fixes #27260.


git-svn-id: https://develop.svn.wordpress.org/trunk@27576 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-18 00:14:48 +00:00
Andrew Nacin
c35a53f8bc Filesystem: Fix getchmod() for direct and ssh2 transports, for directories. 
props DavidAnderson.
fixes #26598.


git-svn-id: https://develop.svn.wordpress.org/trunk@27566 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-17 20:16:40 +00:00
Andrew Nacin
a641b9fb55 Cap and theme support checks for the welcome panel. 
props MikeHansenMe.
fixes #26276.


git-svn-id: https://develop.svn.wordpress.org/trunk@27563 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-17 19:46:15 +00:00
Sergey Biryukov
d4986f1b61 Avoid PHP notices in Media Library if an attachment parent post type no longer exists. 
props wpsmith.
fixes #27439.

git-svn-id: https://develop.svn.wordpress.org/trunk@27560 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-17 15:32:32 +00:00
Andrew Ozz
6d13e3e1ff Restyle the plugin install details modal to match the rest of the admin. Props avryl and paulwilde for initial mockup, see #26952 
git-svn-id: https://develop.svn.wordpress.org/trunk@27559 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-16 18:27:38 +00:00
Sergey Biryukov
1f8285b2e1 Fix .comment-grey-bubble markup and remove a stray </h5> tag. 
props avryl.
fixes #27408.

git-svn-id: https://develop.svn.wordpress.org/trunk@27548 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-15 04:31:58 +00:00
Dion Hulse
526bf7d352 WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265 
git-svn-id: https://develop.svn.wordpress.org/trunk@27546 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-15 03:08:47 +00:00
Dominik Schilling (ocean90)
91fbdbbcc4 Widget Customizer: Use ?wp_customize=on. 
Let _wp_customize_include() handle customizer initialisation.
Sets also the priority for the Add Widget and Reorder buttons and removes debug cruft.

props westonruter.
fixes #27291.

git-svn-id: https://develop.svn.wordpress.org/trunk@27524 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-13 18:37:24 +00:00
Scott Taylor
543bc6404a The Image Editor should apply changes to custom image sizes by checking $_wp_additional_image_sizes for $size in wp_save_image() before arbitrarily going to the options table. 
Props Otto42, SergeyBiryukov.
Fixes #19889.



git-svn-id: https://develop.svn.wordpress.org/trunk@27522 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-13 04:17:36 +00:00
John Blackbourn
f3629139a5 Correct the "View Post" button link when changing a post slug. Fixes #16477. Props aubreypwd. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27508 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 22:59:03 +00:00
John Blackbourn
f45c06c09c Avoid searching HTML tags when searching plugins and themes. Fixes #27136. Props enej. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27507 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 22:23:51 +00:00
Sergey Biryukov
1a769c0e11 Remove duplicate description of WP_List_Table class. 
props bravokeyl.
fixes #27346.

git-svn-id: https://develop.svn.wordpress.org/trunk@27502 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 16:22:44 +00:00
Andrew Nacin
6aa60cf530 Assign correct variable. 
props nendeb55.
fixes #27351. see #14424, [27373].


git-svn-id: https://develop.svn.wordpress.org/trunk@27501 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 13:23:14 +00:00
Andrew Nacin
96176b269d Bring the theme browsing experience from 3.8 to the theme installer. First pass. 
props matveb with assists from me and gcorne.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@27499 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 07:46:27 +00:00
Drew Jaynes (DrewAPicture)
6308a3c93d Fix docs for the deactivate_$plugin and deactivated_plugin hooks. 
Props wpsmith for the original patch.
Fixes #27189


git-svn-id: https://develop.svn.wordpress.org/trunk@27491 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-10 21:33:54 +00:00
Andrew Nacin
e4bb7b0e8c Editor: Show 'View Post' for any post the author can read. 
This expands it to private posts and matches the logic in the toolbar.

props mordauk, SergeyBiryukov.
fixes #27059.


git-svn-id: https://develop.svn.wordpress.org/trunk@27483 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-09 13:52:08 +00:00
Dominik Schilling (ocean90)
292f70aba3 Admin Menu: Set default value of $icon_url in add_menu_page() to dashicons-admin-generic, fixes #26630. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27482 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-09 11:12:35 +00:00
Andrew Nacin
f225973b62 Allow $crop in add_image_size() to receive crop anchors (top, left, right, bottom, center). 
This also applies to set_post_thumbnail_size() and image_resize_dimensions().

props bradt, wonderboymusic, DH-Shredder.
fixes #19393.


git-svn-id: https://develop.svn.wordpress.org/trunk@27472 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 06:13:27 +00:00
Andrew Nacin
928a972fb5 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context. 
see #13265.


git-svn-id: https://develop.svn.wordpress.org/trunk@27470 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 04:18:30 +00:00
Andrew Nacin
5d48091e5d Remove lame debugging. see #23057. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27467 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 03:15:49 +00:00
Andrew Nacin
750fe42507 Normalize $reassign in wp_delete_user() to ensure the hooks receive consistent values. 
fixes #23057.


git-svn-id: https://develop.svn.wordpress.org/trunk@27466 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 03:15:06 +00:00
Sergey Biryukov
28b34b3811 Fix docblock formatting in [27462]. see #23057. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27463 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 01:25:28 +00:00
Sergey Biryukov
e925502c25 Pass $reassign parameter to 'delete_user' and 'deleted_user' actions. 
props genkisan.
fixes #23057.

git-svn-id: https://develop.svn.wordpress.org/trunk@27462 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-08 01:22:51 +00:00
Andrew Nacin
4bbd5ef1d6 maybe_regenerate_attachment_metadata() is now wp_maybe_generate_attachment_metadata(). 
props kovshenin.
fixes #26825.


git-svn-id: https://develop.svn.wordpress.org/trunk@27441 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-06 19:33:32 +00:00
Drew Jaynes
d9c9ea73ec Inline documentation for hooks in wp-admin/includes/class-wp-theme-install-list-table.php. 
Props kpdesign for the cleanup.
Fixes #27293.


git-svn-id: https://develop.svn.wordpress.org/trunk@27430 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-06 13:43:59 +00:00
Andrew Nacin
f12d7bb35c Add widget management to the customizer. 
This brings in the Widget Customizer plugin: https://wordpress.org/plugins/widget-customizer/.

props westonruter, shaunandrews, michael-arestad, johnregan3, akeda, topher1kenobe, topquarky, bobbravo2, ricardocorreia. And for good measure, props westonruter.
see #27112.


git-svn-id: https://develop.svn.wordpress.org/trunk@27419 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-05 20:40:36 +00:00
Andrew Nacin
a14b999605 Always convert auto-drafts to drafts in edit_draft() and _wp_translate_postdata(). 
This regressed due to refactoring in [26995]. This commit fixes Quick Draft.

see #25272.


git-svn-id: https://develop.svn.wordpress.org/trunk@27405 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-05 06:25:31 +00:00
Andrew Ozz
6beddbe7de Restyles the modal for attaching media to posts, take II (also some autoprefixer and imagemin). Props avryl, see #26952. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27403 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-05 03:53:19 +00:00
Andrew Ozz
ce69c629ff Restyles the modal for attaching media to posts, props avryl, see #26952 
git-svn-id: https://develop.svn.wordpress.org/trunk@27401 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-04 23:10:35 +00:00
Andrew Nacin
28a29842c6 Convert the post lock icon to a dashicon. 
props melchoyce, DH-Shredder.
fixes #26796.


git-svn-id: https://develop.svn.wordpress.org/trunk@27392 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-04 06:52:14 +00:00
Dominik Schilling (ocean90)
ff567294f6 "At a Glance" widget: Move get_avatar() line out of if-block. 
This allows you to show avatars for custom comment types via the `get_avatar_comment_types` filter.

props zodiac1978.
fixes #26944.

git-svn-id: https://develop.svn.wordpress.org/trunk@27384 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 20:13:29 +00:00
Drew Jaynes
1b41eea7c7 Generalize the hook documentation for the set-screen-option filter. 
The filter covers more than [items]_per_page screen options.

Fixes #26186.


git-svn-id: https://develop.svn.wordpress.org/trunk@27379 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 17:50:33 +00:00
Drew Jaynes
f65484cabf Inline documentation for hooks in wp-admin/includes/misc.php. 
Props JoshuaAbenazer.
Fixes #26186


git-svn-id: https://develop.svn.wordpress.org/trunk@27375 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 17:19:31 +00:00
Andrew Nacin
0aae0ca1e6 Slight renaming in our callback in [27373]. see #14424. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27374 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 17:08:26 +00:00
Mark Jaquith
7937358328 Eliminate some of our last remaining create_function() instances 
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore

props obenland, markjaquith, nacin. fixes #14424

git-svn-id: https://develop.svn.wordpress.org/trunk@27373 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 16:20:12 +00:00
Andrew Nacin
f3a23fb43f Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc. 
props Ipstenu, markjaquith.
see #27115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27369 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 02:33:24 +00:00
Andrew Nacin
6869d203d0 Introduce get_site_by_path() and further rewrite the site detection process for multisite. 
This is the first big step to supporting arbitrary domains and paths. In this new approach, sites are detected first where possible, then the network is inferred. Allows filtering for arbitrary path segments, smooths out some weirdness, and removes various restrictions. A sunrise plugin could do much of its work by adding filters, if those are even needed.

see #27003.


git-svn-id: https://develop.svn.wordpress.org/trunk@27359 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-02 22:24:50 +00:00
Drew Jaynes
94c6c6a213 Inline documentation for hooks in wp-admin/includes/image-edit.php. 
Props theorboman. Props kpdesign for the cleanup.
Fixes #26149.


git-svn-id: https://develop.svn.wordpress.org/trunk@27357 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-02 20:55:10 +00:00
Drew Jaynes
4346d63207 Inline documentation for hooks in wp-admin/includes/class-wp-plugins-list-table.php. 
Props nicolealleyinteractivecom, kpdesign.
Fixes #26957.


git-svn-id: https://develop.svn.wordpress.org/trunk@27356 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-02 20:47:31 +00:00
Drew Jaynes
90033f46bc Tweak inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props kpdesign.
Fixes #26203.


git-svn-id: https://develop.svn.wordpress.org/trunk@27355 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-02 20:31:15 +00:00
Drew Jaynes
34cdf7f7e1 Inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props leewillis77.
Fixes #26203.


git-svn-id: https://develop.svn.wordpress.org/trunk@27342 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 14:59:53 +00:00
Dion Hulse
db9eb328e3 Upgrader: Remove more debug from r27336. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27339 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:05:02 +00:00
Dion Hulse
e98848a3c6 Upgrader: Remove some debug from r27336. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27338 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:03:55 +00:00
Dion Hulse
18364c9625 Upgrader: Remove two stray spaces. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27337 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:01:28 +00:00
Dion Hulse
14b4579d98 Upgrader: Copy wp-includes/version.php over last, to avoid an installation failing with the new version.php in place. Fixes #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27336 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:00:47 +00:00
Scott Taylor
07f14d6434 * Videos should always render at the same aspect ratio. 
* Don't force a pseudo-mime-type for `.m4v` files
* Uniformly adapt to `$content_width` when setting video dimensions on the front end
* Add the `height` attribute to the initial `<video>` in the video playlist JS template
* Add some defensive/responsive CSS for a/v on the Edit Media page

See #27243.



git-svn-id: https://develop.svn.wordpress.org/trunk@27328 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 21:27:40 +00:00
John Blackbourn
6950f1bcd6 Don't filter out network-only plugins from the Plugins screen if they're individually active on the current site. Add some code comments for clarity. Props mordauk 
git-svn-id: https://develop.svn.wordpress.org/trunk@27326 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 20:21:52 +00:00
Sergey Biryukov
ecbe4f0909 Use a consistent format for translator comments. 
props GaryJ.
fixes #27228.

git-svn-id: https://develop.svn.wordpress.org/trunk@27325 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 08:08:50 +00:00
Sergey Biryukov
ef8de539b9 Remove temporary hooks added in [26865]. 
fixes #26661.

git-svn-id: https://develop.svn.wordpress.org/trunk@27324 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 00:44:38 +00:00
Sergey Biryukov
612b605c80 Avoid an undefined index notice in wp_doc_link_parse(). 
props pross for initial patch.
fixes #27214.

git-svn-id: https://develop.svn.wordpress.org/trunk@27323 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-27 23:15:29 +00:00
Sergey Biryukov
a53fab8750 Avoid an undefined index notice in wp_handle_upload(). 
props tivnet.
fixes #27225.

git-svn-id: https://develop.svn.wordpress.org/trunk@27319 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-27 21:15:31 +00:00
Andrew Ozz
11586e8ebe Upgrade Plupload to 2.1.1, props kovshenin, see #25663 
git-svn-id: https://develop.svn.wordpress.org/trunk@27316 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-27 20:00:55 +00:00
Andrew Nacin
3d8a61bc79 Unslash in the time-format and date-format ajax endpoints. 
props GregLone.
fixes #27216.


git-svn-id: https://develop.svn.wordpress.org/trunk@27305 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-27 00:04:45 +00:00
Drew Jaynes
6dee77ab95 Improve inline documentation for WP_Users_List_Table. 
Props leewillis77 for the initial patch.
Fixes #26564.


git-svn-id: https://develop.svn.wordpress.org/trunk@27301 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-26 22:19:10 +00:00
Andrew Nacin
9ddf03c0bb Decrement update count bubbles as plugins/themes are updated, live. 
props gcorne, mitchoyoshitaka.
fixes #17703.


git-svn-id: https://develop.svn.wordpress.org/trunk@27280 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-26 06:54:26 +00:00
Andrew Nacin
449e436ca1 Clarify return values for get_preferred_from_update_core() and get_core_updates(). 
props SergeyBiryukov.
fixes #20251.


git-svn-id: https://develop.svn.wordpress.org/trunk@27264 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 17:19:22 +00:00
Drew Jaynes
647f80595d Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core. 
See #27200.


git-svn-id: https://develop.svn.wordpress.org/trunk@27262 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 17:13:08 +00:00
Andrew Nacin
9bdaa48e3e Remove _relocate_children(), which has had no purpose for some time. 
props SergeyBiryukov, scribu.
fixes #19367.


git-svn-id: https://develop.svn.wordpress.org/trunk@27261 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 17:09:09 +00:00
Andrew Nacin
7d18f3b34c Make the user arguments for get_edit_profile_url() and get_dashboard_url() optional, defaulting to the current user. 
props garyc40.
fixes #16686.


git-svn-id: https://develop.svn.wordpress.org/trunk@27260 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 17:07:22 +00:00
Drew Jaynes
2aa5387801 Inline documentation for hooks in wp-admin/includes/screen.php. 
Props enej, kpdesign.
Fixes #26821.


git-svn-id: https://develop.svn.wordpress.org/trunk@27256 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 10:04:46 +00:00
Drew Jaynes
f36f14899d Inline documentation for hooks in wp-admin/includes/class-wp-posts-list-table.php. 
Props nicolealleyinteractivecom, kpdesign.
Fixes #26397.


git-svn-id: https://develop.svn.wordpress.org/trunk@27255 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 06:11:32 +00:00
Sergey Biryukov
fc2230e12a Fix theme preview URL for themes loaded via AJAX on Install Themes screen. 
props ocean90.
fixes #27128.

git-svn-id: https://develop.svn.wordpress.org/trunk@27247 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-25 00:00:48 +00:00
Drew Jaynes
dd35bb5d7b Inline documentation for hooks in wp-admin/includes/template.php. 
Props shelob9 for the initial patch. Props kpdesign.
Fixes #26089.


git-svn-id: https://develop.svn.wordpress.org/trunk@27237 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-23 22:43:44 +00:00
Sergey Biryukov
9d94ec0cad Use filtered per_page value in WP_Plugin_Install_List_Table and WP_Theme_Install_List_Table. 
props brasofilo.
fixes #25675.

git-svn-id: https://develop.svn.wordpress.org/trunk@27221 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-21 18:29:41 +00:00
Andrew Nacin
4cfcdabdd8 Simplify error in validate_file_to_edit(). 
props MattyRob for initial patch.
fixes #25924.


git-svn-id: https://develop.svn.wordpress.org/trunk@27219 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-21 14:45:06 +00:00
Drew Jaynes
d3aa609740 Inline documentation for hooks in wp-admin/includes/image.php. 
Props theorboman, kpdesign.
Fixes #25832.


git-svn-id: https://develop.svn.wordpress.org/trunk@27202 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-20 06:26:51 +00:00
John Blackbourn
a0536406a1 Add screen-reader friendly variations of some short text links in the Publish meta box. Fixes #25459. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27196 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-19 22:43:55 +00:00
Helen Hou-Sandi
c4848bbac4 Once upon a time not long ago, 
The admin CSS was merged in #18314.
After a couple years as it stood,
The mess it had become just was no good.
One day we realized Grunt is pretty cool,
And said "we should use this as our build tool!"
Now we can maintain separate files with ease,
Using @import and cssmin meets all our needs.
Welcome to the future of the WordPress stylesheets,
And thanks to Slick Rick for the beats.

props jorbin for the initial patch.
fixes #26669.


git-svn-id: https://develop.svn.wordpress.org/trunk@27195 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-19 21:42:36 +00:00
Sergey Biryukov
073d970d1f Use correct variable. props avryl. fixes #27153. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27194 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-19 15:28:17 +00:00
Scott Taylor
1b8da3d0d6 Use selected() where appropriate in touch_time(), page_template_dropdown(), and parent_dropdown(). Also, add proper docs. 
Props meloniq, DrewAPicture.
Fixes #25889.



git-svn-id: https://develop.svn.wordpress.org/trunk@27188 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-17 22:26:14 +00:00
Andrew Nacin
b7be4e98fe Detect and handle symlinking of plugins in plugin_basename(). 
props rmccue, MikeSchinkel, jdgrimes.
see #16953.


git-svn-id: https://develop.svn.wordpress.org/trunk@27158 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-10 22:59:40 +00:00
Drew Jaynes
aa502ff35a Fix docs spacing missed in [27136]. 
See #27070.


git-svn-id: https://develop.svn.wordpress.org/trunk@27137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-08 22:18:09 +00:00
Drew Jaynes
4993a00e05 Improve inline documentation for submit_button(). 
See #27070.


git-svn-id: https://develop.svn.wordpress.org/trunk@27136 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-08 22:13:18 +00:00
Drew Jaynes
622d3e1338 Clarify submit_button() $type parameter docs to mention that the value doubles as the CSS class attribute. 
See #27070


git-svn-id: https://develop.svn.wordpress.org/trunk@27135 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-08 22:10:19 +00:00
Andrew Nacin
3266997d99 Improve parameter documentation of add_meta_box(). 
props philiparthurmoore, DrewAPicture.
fixes #26698.


git-svn-id: https://develop.svn.wordpress.org/trunk@27132 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-08 00:54:19 +00:00
Scott Taylor
d6cb8c399e Introduce maybe_regenerate_attachment_metadata( $attachment ). On the Edit Media screen, call it for Audio and Video files. 
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.

This is the minimum viable product for #26825, but leaving the ticket open unless this function needs to be called in other places.

See #26825.



git-svn-id: https://develop.svn.wordpress.org/trunk@27127 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 22:40:32 +00:00
Helen Hou-Sandi
802baab31a Merge colors.css into wp-admin.css. Non-default color schemes became overloads rather than swaps in the 3.8 redesign. Benefits include: 
* No more border-width, border-style, border-color insanity.
* Point releases are much less likely to require extra finagling to avoid rebuilding the color schemes.
* Yours truly has a better overall vision of ~14,000 lines of admin CSS and where we go from here.

1,065 net lines of red, y'all.
props helen, jorbin. fixes #18380.


git-svn-id: https://develop.svn.wordpress.org/trunk@27106 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 06:24:36 +00:00
Drew Jaynes
d88b191c9a Inline documentation for hooks in wp-admin/includes/class-wp-ms-themes-list-table.php. 
Also marks two hooks in wp-admin/includes/class-wp-themes-list-table.php as duplicates.

Props ShinichiN, kpdesign, DrewAPicture.
Fixes #25608.


git-svn-id: https://develop.svn.wordpress.org/trunk@27090 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-04 08:24:13 +00:00
Drew Jaynes
75d5d14049 Inline documentation for hooks in wp-admin/includes/class-wp-terms-list-table.php. 
Props Ajay, kpdesign.
Fixes #26209.


git-svn-id: https://develop.svn.wordpress.org/trunk@27089 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-04 07:55:48 +00:00
Andrew Ozz
33b079b036 Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27079 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-02 23:49:05 +00:00
Andrew Nacin
8c3ad4e860 Consistently trim and unslash search queries for the users list tables. 
props aubreypwd.
fixes #26115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27077 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-02 22:09:19 +00:00
Drew Jaynes
9224a141f3 Inline documentation for hooks in wp-admin/includes/export.php. 
Props cmmarslender, kpdesign.
Fixes #26894.


git-svn-id: https://develop.svn.wordpress.org/trunk@27048 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-28 08:09:13 +00:00
Drew Jaynes
bbc58ef016 Inline documentation for hooks in wp-admin/includes/update-core.php. 
Props JoshuaAbenazer, kpdesign.
Fixes #25998.


git-svn-id: https://develop.svn.wordpress.org/trunk@27047 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-28 08:01:36 +00:00
Helen Hou-Sandi
91b0e15ef8 Autocomplete for the new site admin email. Better than trying to remember which email address you used. 
fixes #25348.


git-svn-id: https://develop.svn.wordpress.org/trunk@27046 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-27 23:09:08 +00:00
Andrew Nacin
bd9729c22d Add wp_install and wp_upgrade hooks to the respective functions. 
props Denis-de-Bernardy.
fixes #25762.


git-svn-id: https://develop.svn.wordpress.org/trunk@27045 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-27 16:31:54 +00:00
Andrew Ozz
fbd895949f Remove one more valign, props neoxx, fixes #22712. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27037 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-26 20:37:33 +00:00
Andrew Ozz
88fecbeff9 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27036 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-26 20:27:21 +00:00
Dominik Schilling (ocean90)
88277b4dba Remove unused code. props nofearinc. fixes #26205. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27033 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-26 00:11:18 +00:00
Andrew Ozz
48d24f6bf5 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27029 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-24 19:05:15 +00:00
nacin
ce00f36ab7 Dashboard widgets: Don't link to Pages or Posts for Authors or Contributors respectively. 
props mattheu.
see #26574 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@26999 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-22 16:51:07 +00:00
Andrew Ozz
9aba880b53 Autosave: refactor autosave.js, use heartbeat for transport and move all "Add/Edit Post" related functionality to post.js. See #25272. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26995 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-22 04:55:37 +00:00
Drew Jaynes
f2d4a6aa36 Hook docs spacing and standards fixes for wp-admin/includes/ajax-actions.php. 
See #25374.


git-svn-id: https://develop.svn.wordpress.org/trunk@26981 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-18 17:05:38 +00:00
Matt Thomas
fc4c73feab The comment screen hides the author column at narrow screen sizes; this adds back the author info above the comment content. Fixes #26618, props SergeyBiryukov, nacin. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26961 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-16 20:33:45 +00:00
Sergey Biryukov
3a1b1ba755 Remove unnecessary sprintf(). props jdgrimes. fixes #25489. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26943 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-14 11:17:10 +00:00
Helen Hou-Sandi
7fc9941d2a Pass the $user_id to the admin_color_scheme_picker hook for context. props nacin. see #26607 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26924 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-08 21:48:32 +00:00
Drew Jaynes
3086f189cc Inline documentation for hooks in wp-admin/includes/meta-boxes.php. 
Props SpencerFinnell for the initial patch.
Fixes #26092.


git-svn-id: https://develop.svn.wordpress.org/trunk@26918 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-08 04:06:01 +00:00
Drew Jaynes
95f756e4fc Inline documentation for hooks in wp-admin/includes/class-wp-media-list-table.php. 
Props theorboman for the initial patch. Props kpdesign.
Fixes #25839.


git-svn-id: https://develop.svn.wordpress.org/trunk@26916 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-08 03:52:47 +00:00
Drew Jaynes
00f318650d Inline documentation for hooks in wp-admin/includes/media.php. 
Props kpdesign, DrewAPicture.
Fixes #25375.


git-svn-id: https://develop.svn.wordpress.org/trunk@26908 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-06 05:47:51 +00:00
Sergey Biryukov
18c545905b Change 'Width' to 'Layout' to match the hard-coded list of translatable theme features in get_theme_feature_list(). 
props janrenn.
fixes #26777 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26905 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-05 17:15:14 +00:00
Sergey Biryukov
0b3022708b Use correct example of a Dashicons helper class in add_menu_page() and register_post_type() docs. 
props Rarst.
fixes #26617 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26884 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-31 10:32:18 +00:00
Sergey Biryukov
9dae1af97c Make sure "UPDATE LOG" in debug emails matches the underlining when translated. 
fixes #26621.

git-svn-id: https://develop.svn.wordpress.org/trunk@26883 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-31 10:26:37 +00:00
Andrew Ozz
14ace125ee TinyMCE 4.0.12, first run. 
- Removes wp-tinymce-schema.js and mark-loaded.js, no longer needed.
- Removes the inlinepopups and most of the wpdialogs plugins; wpdialog.js is moved to wp-includes/js.
- Adds charmap, compat3x, image, link and textcolor plugins, previously contained in /themes/advanced.
- Updates the wordpress, wpeditimage, wpfullscreen, wpgallery and wplink plugins.
- Updates DFW, wp-admin/js/wp-fullscreen.js.
See #24067.

git-svn-id: https://develop.svn.wordpress.org/trunk@26876 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-28 23:52:04 +00:00
Sergey Biryukov
329672c70d Being consistent is the gist, no single @since should have been missed. 
see #26713.

git-svn-id: https://develop.svn.wordpress.org/trunk@26869 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-25 01:59:22 +00:00
Drew Jaynes
bd39e26032 First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.


git-svn-id: https://develop.svn.wordpress.org/trunk@26868 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-24 18:56:05 +00:00
Sergey Biryukov
ef8e214888 Add comments for temporary hooks. see #26661. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26866 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-23 00:47:59 +00:00
Sergey Biryukov
27352b4e86 Add temporary hooks for the widgets feature team to wp_widget_control(). 
props westonruter.
see #26661.

git-svn-id: https://develop.svn.wordpress.org/trunk@26865 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-23 00:44:33 +00:00
Ryan Boren
cfd5c395bb The Pinking Shears stir from their slumber, awakened by what may seem, to those 
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.


git-svn-id: https://develop.svn.wordpress.org/trunk@26851 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-11 19:48:29 +00:00
Andrew Nacin
9b0a9b9cee On update, delete files removed in 3.8. 
props JPry.
fixes #26535.


git-svn-id: https://develop.svn.wordpress.org/trunk@26846 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-11 17:37:35 +00:00
Matt Thomas
fc676240c9 Style the Add Comment button as a button. Fixes #26500, props SergeyBiryukov. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26834 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-09 19:13:56 +00:00
Andrew Nacin
6c96d3e787 Introduce dashboard_glance_items filter which replaces 3.7 right_now_* hooks that were tied to table markup. 
fixes #26495.


git-svn-id: https://develop.svn.wordpress.org/trunk@26832 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-09 19:11:23 +00:00
Helen Hou-Sandi
5b05610ade Remove many of the now-unused images in core. Some images have been left for now, notably our previous style icons, action indicators, and images that see a higher frequency of use in plugins to allow them more time to adapt to the new design. props ocean90, Ipstenu, coffee2code. fixes #26036. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26821 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-09 03:20:46 +00:00
Andrew Nacin
098d6a8504 Avoid notices when default and light are not registered color schemes. see #26468. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26814 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-09 00:48:15 +00:00
Matt Thomas
9439bb7b4f Expand the Quick Draft section by default. Fixes #26463, props bassgang. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26813 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-09 00:42:56 +00:00
Andrew Nacin
4ac6742af9 Nonces are already per-user. see #22862. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26793 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-08 07:05:01 +00:00
Andrew Nacin
e41692153c Core updates for the new color schemes. 
* Update about page, there's now 8.
 * Display them four wide, not three, and ensure adequate spacing.
 * Use a dedicated nonce.
 * Push Light to the front in addition to Default.
 * Use user-profile.js on about.php. A few extra things are initialized but they are harmless.

see #26468, #26387.


git-svn-id: https://develop.svn.wordpress.org/trunk@26776 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-07 07:45:57 +00:00
Andrew Nacin
9f6f615dd6 Use wp_specialchars_decode() in the upgrade debugging email subject, same as the production email. 
props markoheijnen.
fixes #26471.


git-svn-id: https://develop.svn.wordpress.org/trunk@26762 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-07 01:14:43 +00:00
Andrew Nacin
2c16db49b1 Translator's comment for a date_i18n() string. 
props netweb.
fixes #26470.


git-svn-id: https://develop.svn.wordpress.org/trunk@26758 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-07 00:37:13 +00:00
Andrew Nacin
292391081a Dashboard: Restore a line that vanished from my editor to print recently published posts. Also fix an off-by-one error. 
see [26704]. see #26066.


git-svn-id: https://develop.svn.wordpress.org/trunk@26741 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 20:12:10 +00:00
Drew Jaynes
439c61a1ba Inline documentation fixes for hooks and functions introduced in 3.8.0. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26736 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 19:17:35 +00:00
Andrew Nacin
bb59e40a22 Core updates: Explicitly call wp_cache_delete() after a DB upgrade, as not all cache backends allow the entire backend to be flushed. 
props dd32.
fixes #26173.


git-svn-id: https://develop.svn.wordpress.org/trunk@26734 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 18:59:29 +00:00
Drew Jaynes
86282508aa Inline documentation fixes for wp_heartbeat_set_suspension(). 
See #25073.


git-svn-id: https://develop.svn.wordpress.org/trunk@26732 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 18:42:50 +00:00
Andrew Nacin
b9cb349dc0 No-JavaScript and no-Customizer support for the new Themes screen. 
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.


git-svn-id: https://develop.svn.wordpress.org/trunk@26726 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 16:10:25 +00:00
Matt Mullenweg
2dab52c306 Add and display new tags to highlight the ever-growing number of responsive themes available. Fixes #21442. 
Props Otto42 and lancewillett.


git-svn-id: https://develop.svn.wordpress.org/trunk@26711 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-06 01:06:04 +00:00
Andrew Nacin
a7ee089f6f Fix various i18n issues on the dashboard. Limits it to posts and pages only for 3.8. 
props SergeyBiryukov, dimadin.
fixes #26066.


git-svn-id: https://develop.svn.wordpress.org/trunk@26704 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 23:33:48 +00:00
Andrew Nacin
b7de614f71 Restore "Search Engines Discouraged" to the dashboard. 
props JustinSainton.
fixes #26431.


git-svn-id: https://develop.svn.wordpress.org/trunk@26700 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 23:04:46 +00:00
Andrew Nacin
fa6cb8145f Dashboard: Rename the Site Content widget (née Right Now) to At a Glance. 
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26697 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 22:37:33 +00:00
Andrew Nacin
74d3e9103e Deactivate MP6 on update to 3.8. 
If left on, it introduces a lot of weird issues not easily diagnosed. MP6 will be updated before release to prevent itself from functioning 3.8+, but this will cut down on support requests by people who update core but not MP6, which was a fairly popular plugin.

fixes #26334.


git-svn-id: https://develop.svn.wordpress.org/trunk@26692 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 21:29:37 +00:00
Andrew Nacin
56b0a18ac2 Dashboard backwards compatibility updates. 
* Restore missing wp_dashboard_rss_control() helper.
 * Restore all original 3.7 functions, deprecating many, reusing others. 
 * Rename and remove functions so as not to clash with the original dash plugin.
 * Filter cleanup/restoration.

see #25824, #26334.


git-svn-id: https://develop.svn.wordpress.org/trunk@26690 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 21:22:20 +00:00
Andrew Nacin
74ea276315 Theme: When showing an author in the grid (during a search), don't include the author's link. 
fixes #26433.


git-svn-id: https://develop.svn.wordpress.org/trunk@26684 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 19:08:01 +00:00
Andrew Nacin
006045395c Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons. 
Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.

To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.

props helen.
fixes #25147.


git-svn-id: https://develop.svn.wordpress.org/trunk@26664 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 06:37:20 +00:00
Matt Mullenweg
cdbcccf498 Create a new tag for themes that have passed the theme check guidelines for accessibility. Fixes #26157 
Props lancewillett.



git-svn-id: https://develop.svn.wordpress.org/trunk@26658 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-05 03:48:36 +00:00
Drew Jaynes
ba4187de33 Hook docs fixes following [26645]. 
See #25721.


git-svn-id: https://develop.svn.wordpress.org/trunk@26648 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 23:31:21 +00:00
Drew Jaynes
98fe4a5aed Hook docs pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26631 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 20:02:53 +00:00
Andrew Nacin
9194c6593e Add wp_prepare_themes_for_js filter to wp_prepare_themes_for_js(). 
props kovshenin.
fixes #25948.


git-svn-id: https://develop.svn.wordpress.org/trunk@26625 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 19:20:10 +00:00
Andrew Nacin
6cad5246df Include columns-# CSS class in wp_dashboard() for when the screen supports it. 
props westi.
fixes #26354.


git-svn-id: https://develop.svn.wordpress.org/trunk@26617 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 17:27:34 +00:00
Andrew Nacin
3dcc14f58c Restore original properties of the right now (activity) and primary (news) dashboard widgets. 
This avoids issues with those trying to remove/disable core meta boxes.

fixes #26392.


git-svn-id: https://develop.svn.wordpress.org/trunk@26611 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 16:55:58 +00:00
Matt Thomas
71588c2933 Revert r26593 so Available and Inactive widgets are once again collapsible. Make the arrows only appear on hover when uncollapsed. Fixes #26327, props nacin. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26608 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 16:30:05 +00:00
Andrew Ozz
93a5bff7a7 Svg-painter: 
- Clean up the JS, better names, etc.
- Convert the base64 encode/decode code from jQuery plugin to local use.
- Add missing icon colors for the default theme.
- Make it more error-proof.
Fixes #26333.

git-svn-id: https://develop.svn.wordpress.org/trunk@26601 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 04:12:41 +00:00
Matt Thomas
933a5f252f Set Available and Inactive Widget areas to not collapse, since they don't look like collapsing elements. Fixes #26327, props MikeHansenMe. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26593 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-03 21:31:37 +00:00
Andrew Nacin
57bede1005 Use current_user_can('manage_network_plugins') in validate_active_plugins() instead of is_super_admin(). 
props jdgrimes.
fixes #26068.


git-svn-id: https://develop.svn.wordpress.org/trunk@26590 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-03 21:11:21 +00:00
Andrew Nacin
f627d23555 In dbDelta(), ensure we are not running CREATE TABLE queries for global tables we wish to not upgrade. 
props fliespl.
fixes #22134.


git-svn-id: https://develop.svn.wordpress.org/trunk@26566 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-03 17:43:52 +00:00
Helen Hou-Sandi
6e77a372e2 Better Dashboard treatment when in no-JS, especially Quick Draft. props georgestephanis, helen. fixes #26376. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26563 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-03 17:31:33 +00:00
Andrew Ozz
75ac2cf131 Heartbeat: 
- Bring back heartbeat.interval().
- Rename wp_disable_heartbeat_suspend() to wp_heartbeat_set_suspension().
- Rename the option for disabling suspension from options.suspend to options.suspension.
Fixes #25073.

git-svn-id: https://develop.svn.wordpress.org/trunk@26549 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-03 00:44:22 +00:00
Andrew Nacin
ea5963f944 Remove @uses from get_screen_icon() / screen_icon(). see #26119. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26541 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 21:58:57 +00:00
Drew Jaynes
4f78450a25 Inline documentation for hooks in wp-admin/includes/update.php. 
Props stevenkword for the initial patches.
Fixes #26252.


git-svn-id: https://develop.svn.wordpress.org/trunk@26540 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 21:54:24 +00:00
Andrew Nacin
85be737cae Only informally deprecate get_screen_icon() and screen_icon(). fixes #26119. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26537 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 19:59:40 +00:00
Andrew Nacin
16b6b6b8e4 Simplify the color scheme profile saving JS. see #25858. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26535 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 19:44:50 +00:00
Andrew Nacin
616eb91d95 Themes: Always include the current theme in the list, even if it is not allowed. 
see #25948.


git-svn-id: https://develop.svn.wordpress.org/trunk@26529 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 18:45:28 +00:00
Andrew Ozz
b33d0da84c Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119 
git-svn-id: https://develop.svn.wordpress.org/trunk@26518 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 03:52:23 +00:00
Dion Hulse
71bc2a38fa Add braces around a conditional hook. This wasn't causing an issue as if ( conditional ) /* multiline comment */ command(); is perfectly OK, but left open doubt and potential future bugs. See #25229 
git-svn-id: https://develop.svn.wordpress.org/trunk@26509 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-01 23:12:38 +00:00
Andrew Ozz
e5304e8470 Improve the admin color scheme picker: 
- Easier to extend.
- Remove the "drop-down" look, show all choices inline.
- Some PHP and JS cleanup.
Props ryelle, fixes #26336.

git-svn-id: https://develop.svn.wordpress.org/trunk@26506 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-01 19:49:55 +00:00
Drew Jaynes
720930f356 Inline documentation for hooks in wp-admin/includes/user.php. 
Props aaronholbrook for the initial patch.
Fixes #26099.


git-svn-id: https://develop.svn.wordpress.org/trunk@26503 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-01 17:53:18 +00:00
Dion Hulse
66fb039ffe Themes: Do extra Cap checks before outputting links, and use full URI's. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26470 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-29 09:00:23 +00:00
Dion Hulse
13ba79ef36 Themes: When the user doesn't have switch_themes capabilities, and we've passed the current theme, detect the theme slug/stylesheet correctly so that the flags are set properly. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26469 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-29 08:37:17 +00:00
Helen Hou-Sandi
eaa7c65263 Add remove_option(), remove_options(), and get_options() methods to WP_Screen, along with unit tests. props ocean90, DrewAPicture. fixes #25799. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26456 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-28 05:09:06 +00:00
Dion Hulse
f4e65810bd Core Updates: Fix a case where options (db_version specifically) can end up with stale values in the cache after a update is performed. Fixes #26173 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26448 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-28 02:15:55 +00:00
Andrew Ozz
3b2dc8f443 Heartbeat: introduce "suspend" functionality and enable it after 20 min. of inactivity, see #25073. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26428 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-27 01:55:59 +00:00
Andrew Ozz
f4264f9446 Widgets: drop onto closed sidebars. 
- Make dropping a widget easier by preventing the source sidebar from resizing while the widget is being dragged.
- Move widgets dropped on closed sidebars to the top. UI Sortable places them randomly near the bottom.
- Fix possible regression in wp_list_widget_controls(), add an optional argument to output the sidebar name inside the sortable container.
- Updated styles for sidebar description and widget-hover class.
Part props shaunandrews, fixes #25952.

git-svn-id: https://develop.svn.wordpress.org/trunk@26426 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-27 01:29:49 +00:00
Sergey Biryukov
42da7f3053 Rename mp6_color_scheme JS global to wp_color_scheme. 
props kovshenin.
see #26263.

git-svn-id: https://develop.svn.wordpress.org/trunk@26406 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-26 13:57:58 +00:00
Drew Jaynes
7c6dfbf0f8 Inline documentation for hooks in wp-admin/includes/class-wp-list-table.php. 
Props miyauchi, kpdesign.
Fixes 25848.


git-svn-id: https://develop.svn.wordpress.org/trunk@26401 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-26 08:11:33 +00:00
Helen Hou-Sandi
3d89ca8f6b Add some deleted images to the $_old_files array. see [26391], [26395], #26232, #26178. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26397 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-26 05:41:10 +00:00
Helen Hou-Sandi
2fbde17aba Don't show the Activity widget on the Network Admin Dashboard. props ocean90. fixes #26184. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26394 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-26 05:28:46 +00:00
Helen Hou-Sandi
88bd8b4d87 Dashboard columns: 
* Improve responsive breakpoints for.
* Remove obsolete network admin option.
* Remove unnecessary JS.

props SergeyBiryukov, kraftbj, lessbloat. fixes #26074.


git-svn-id: https://develop.svn.wordpress.org/trunk@26392 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-26 05:08:37 +00:00
Matt Thomas
1668b4ab1b Remove button-secondary class from Collapse link in theme installer; unify Collapse button styles in theme installer and Customize screen; add a border around the Collapse icon so it remains visible on dark backgrounds; move the color styles to colors-fresh. Fixes #26230. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26389 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-26 04:13:10 +00:00
Dion Hulse
696014fff5 Replace the Star ratings in the dashboard with dashicons ratings. 
This also moves the ratings to only displaying full, half, or empty stars (ie. 3.0, 3.5, 4.0, no 3.7 ratings - which are rounded).
Fixes #26170


git-svn-id: https://develop.svn.wordpress.org/trunk@26380 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-26 02:24:25 +00:00
Sergey Biryukov
eb4d56b3f8 Remove redundant translation function calls. 
props markoheijnen.
see #26187.

git-svn-id: https://develop.svn.wordpress.org/trunk@26349 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-24 12:41:17 +00:00
Dominik Schilling (ocean90)
8c915b97ae Don't use esc_attr_e() function for a non-translatable context. 
props yoavf, mattheu.
fixes #26187.

git-svn-id: https://develop.svn.wordpress.org/trunk@26347 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-24 12:03:25 +00:00
Dion Hulse
72e4fe6420 Use numbered string replacements in 2 new strings. Props dimadin. Fixes #25667 
git-svn-id: https://develop.svn.wordpress.org/trunk@26346 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-24 06:09:43 +00:00
Drew Jaynes
91fb5e641a Inline documentation for hooks in wp-admin/includes/class-wp-ms-users-list-table.php. 
Props ShinichiN, kpdesign.
Fixes #25612.


git-svn-id: https://develop.svn.wordpress.org/trunk@26342 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-23 22:24:25 +00:00
Drew Jaynes
b8ac8fac34 Inline documentation for hooks in wp-admin/includes/class-wp-ms-sites-list-table.php. 
Props ShinichiN, kpdesign.
Fixes #25607.


git-svn-id: https://develop.svn.wordpress.org/trunk@26341 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-23 21:57:24 +00:00
Drew Jaynes
30600cefa0 Inline documentation for hooks in wp-admin/includes/class-wp-links-list-table.php. 
Props JoshuaAbenazer, kpdesign.
Fixes #26052.


git-svn-id: https://develop.svn.wordpress.org/trunk@26340 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-23 21:27:05 +00:00
Dominik Schilling (ocean90)
6a5c878714 Dashboard: Use _draft_or_post_title() to display (no title) if no post title is set. see #25824. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26337 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-23 14:12:05 +00:00
Dion Hulse
2388095150 Theme Installer: Fix the Theme Preview function, and bring the button handling/styling inline with the Customizer. Fixes #26129 
git-svn-id: https://develop.svn.wordpress.org/trunk@26317 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-22 04:02:37 +00:00
Dion Hulse
f2ce159ded Themes: Move the escaping of content from JS back to PHP. This allows us to take advantage of the display() WP_Theme method to translate the text properly, and to strip out any HTML tags we don't wish to display. Fixes #26100. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26316 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-22 02:33:19 +00:00
Dion Hulse
90fda37ed4 Use static strings instead of a impossible-to-translate string in the Automatic updates debug email. Props SergeyBiryukov. Fixes #25667 
git-svn-id: https://develop.svn.wordpress.org/trunk@26313 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-22 01:59:43 +00:00
Dion Hulse
c49f6bbb5a Themes: Add a get_theme_update_available() function to retrieve an update link and use it on the Themes page. See #26078 
git-svn-id: https://develop.svn.wordpress.org/trunk@26282 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-20 02:56:52 +00:00
Dion Hulse
4818ef5335 Translate the debug update email for development installs. Props Nao for initial patch. See #25667 
git-svn-id: https://develop.svn.wordpress.org/trunk@26279 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-20 02:03:30 +00:00
Dion Hulse
56d0e4ae40 Appearance: Fix a PHP Notice when the update transient isn't available (for example, due to a timeout or being used offline). See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26278 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-20 01:39:40 +00:00
Andrew Nacin
d8617e0fe9 Remove whitespace from the inside of a <textarea> element, added in [26138] with inline documentation. 
see #25662.


git-svn-id: https://develop.svn.wordpress.org/trunk@26273 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-19 19:34:08 +00:00
Dion Hulse
520840e84c Plugin Deletion: Properly clear the cache when multiple plugins are deleted. Props jdgrimes. Fixes #26065 
git-svn-id: https://develop.svn.wordpress.org/trunk@26262 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-19 04:07:47 +00:00
Scott Taylor
ff4f1bb170 For unit tests that call wpmu_create_blog(), Blog factory, or installation code that attempts to clear transients: suppress database errors on setUp and restore on tearDown. 
There are a few places in core that were preventing this from working by explicity setting `$wpdb->suppress_errors` to `false`. Instead, they should inherit the value that existed before errors were suppressed.

This allows Multisite unit tests to run without explosive database errors, and allows `$wpdb->suppress_errors` to be overridden all the way down the chain.

Fixes #26102.


git-svn-id: https://develop.svn.wordpress.org/trunk@26252 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-18 20:44:34 +00:00
Sergey Biryukov
d42e8eee3d Remove unused global reference. props jeremyfelt. fixes #26103. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26251 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-18 20:18:57 +00:00
Matt Thomas
c85c7ec8df Style and positioning fixes to form elements in the Publish box: 
- Make select element text #555 to match others
- Make Cancel links vertically align with buttons
- Make sure the spacing between buttons and cancel links is always consistent
- Override active button styles for responsive states so button size doesn't change when active
- Reduce font size of date select element to match date text inputs

Fixes #26082, props aubreypwd.



git-svn-id: https://develop.svn.wordpress.org/trunk@26247 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-18 18:52:06 +00:00
Sergey Biryukov
cf445be887 Remove debug cruft. props nbachiyski. see #25791. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26245 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-18 13:17:13 +00:00
Andrew Nacin
42e0245712 Add level-X classes to the posts list table rows. 
props jhned.
fixes #25791.


git-svn-id: https://develop.svn.wordpress.org/trunk@26244 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-17 20:39:48 +00:00
Sergey Biryukov
b95580d5ed Fix date comparison in dashboard_relative_date(). fixes #26033. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26242 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-17 03:29:11 +00:00
Sergey Biryukov
dfd8f30724 PHPDoc and i18n fixes for dashboard widgets. 
props dimadin for initial patch.
see #25824.

git-svn-id: https://develop.svn.wordpress.org/trunk@26241 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-17 03:20:38 +00:00
Andrew Nacin
1ce61ffda7 Merge wp_dashboard_recent_quickdrafts() into wp_dashboard_quick_press(). see #25824. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26221 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-15 20:39:37 +00:00
Andrew Nacin
9a936eb7d0 Dash cleanup. 
* Use wp_add_dashboard_widget() rather than add_meta_box().
 * Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
 * Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
 * Remove some debug cruft that was preventing caching and invalidation.
 * Simplify lots of things where possible.
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26220 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-15 20:14:44 +00:00
Andrew Nacin
33cce1d7d7 Sort themes by name on the new themes.php page. see #25948. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26216 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-15 16:41:39 +00:00
Andrew Nacin
f135b9b540 Remove debug cruft. props dimadin. see #25948. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26215 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-15 16:39:16 +00:00
Dion Hulse
8c01596a75 Updates: When a failed Background Update occurs, only show the failed update nag if the user hasn't yet updated if it was an early abort. Props SergeyBiryukov. Fixes #25887 for trunk 
git-svn-id: https://develop.svn.wordpress.org/trunk@26186 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-15 02:30:30 +00:00
Andrew Ozz
8dc91f3646 Heartbeat: clean up code style, better naming, better code structure. Props carldanley, props evansolomon. 
Changes:
- Add connectNow() public method to trigger a connection immediately.
- Remove the "skipping" when no data to send.
- Change the default interval to 60 sec.
- Fix resetting the next connection time when changing the interval.
See #25073.

git-svn-id: https://develop.svn.wordpress.org/trunk@26169 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-14 18:40:03 +00:00
Dion Hulse
53748cebe1 Bacground Updates: Move the 'automatic_updates_complete' hook to only fire when some updates have actually been completed. Props nacin. Fixes #25841 
git-svn-id: https://develop.svn.wordpress.org/trunk@26164 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-14 06:28:42 +00:00
Dion Hulse
707082fd12 Background Updates: Add a 'automatic_updates_complete' hook that fires after any updates have run. Props pento. Fixes #25841 
git-svn-id: https://develop.svn.wordpress.org/trunk@26155 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-14 05:07:19 +00:00
Dion Hulse
6d70a797be Background Updates: Spread them over the hour. Props Pento. Fixes #25833 for trunk 
git-svn-id: https://develop.svn.wordpress.org/trunk@26149 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-14 04:03:27 +00:00
Dion Hulse
a23ead1467 Background Updates: Fix a PHP Fatal error which could be encountered on some systems when using FTP. Fixes #25817 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26148 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-14 02:01:30 +00:00
Andrew Nacin
3b82749eba Merge the new dashboard design into core. 
Merges https://github.com/growthdesigner/wp-dash.

props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824.


git-svn-id: https://develop.svn.wordpress.org/trunk@26144 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-13 22:08:47 +00:00
Andrew Nacin
12ccb6d136 Update the Themes screen, merging THX into core. 
* Name: THX38
 * Description: Update the Themes screen with a new design and experience.
 * Tags: visually-focused, bigger-screenshots, fast, mobile-friendly, backbone-driven
 * Author: matveb, shaunandrews, melchoyce, designsimply, shelob9
 * URI: http://wordpress.org/plugins/thx38/

fixes #25948



git-svn-id: https://develop.svn.wordpress.org/trunk@26141 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-13 20:57:29 +00:00
Matt Thomas
e00060118b Bring in the widgets component of MP6. See #25858. 
* A cleaner UI, with a simpler design for available and inactive widgets, and more emphasis on your sidebars.
* Available widgets and sidebars expand to two columns at larger screen sizes making it easier to manage sites with lots of sidebars.
* New dropzone indicator for empty sidebars.

Props shaunandrews, joen, iammattthomas.



git-svn-id: https://develop.svn.wordpress.org/trunk@26140 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-13 20:05:51 +00:00
Sergey Biryukov
87b1101b49 Inline documentation for hooks in wp-admin/includes/class-wp-comments-list-table.php. 
props siobhyb, kpdesign.
fixes #25662.

git-svn-id: https://develop.svn.wordpress.org/trunk@26138 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-13 19:46:20 +00:00
Helen Hou-Sandi
e84e1e8791 Merge the color schemes component from MP6. Introduces Light, Blue, and Midnight. 
Color scheme selection on your own profile page gives you a preview and autosaves the selection.

Also introduces the usage of a preprocessor for core files, namely Sass. For 3.8, we will not expand its implementation past the color schemes. This does require Ruby as well as Sass 3.3.0+ due to the usage of the sourcemap option.

Note that only the default color scheme is available when running out of src. Use build to test the rest as well as the color picker.

props ryelle, melchoyce, tillkruess, drw158, littlethingsstudio, helen. see #25858, #22862.


git-svn-id: https://develop.svn.wordpress.org/trunk@26137 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-13 19:37:10 +00:00
Sergey Biryukov
39d55fddb8 Use get_current_site() instead of the $current_site global when possible. 
props jeremyfelt.
fixes #25158.

git-svn-id: https://develop.svn.wordpress.org/trunk@26120 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-13 03:22:48 +00:00
Sergey Biryukov
7cd8d225a3 Use case-insensitive comparison for email addresses. fixes #25779. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26115 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-13 02:40:28 +00:00
Andrew Ozz
88138fbf3a Fix the X-UA-Compatible header for IE8, fixes #25575 
git-svn-id: https://develop.svn.wordpress.org/trunk@26089 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-11 18:01:40 +00:00
Sergey Biryukov
a2aed7b119 Fix docblock formatting. fixes #25893. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26081 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-11 13:31:19 +00:00
Sergey Biryukov
c815622e87 Pass correct 'type' parameter to 'upgrader_process_complete' action in Theme_Upgrader. 
props bamadesigner.
fixes #25882 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26049 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-08 17:03:19 +00:00
Andrew Ozz
859516cd19 Add X-UA-Compatible meta tag in the admin, locking the compatibility mode in IE to the highest supported document mode. Fixes #25575. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26029 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-06 23:48:02 +00:00
Sergey Biryukov
2564c74a57 Fix inverted logic for displaying the 'Broken Theme' string. props pavelevap. fixes #25465. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26027 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-06 22:39:35 +00:00
Sergey Biryukov
cd7deb0e7b Make Twenty Fourteen the default theme. props markmcwilliams. fixes #25702. 
git-svn-id: https://develop.svn.wordpress.org/trunk@26024 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-06 20:01:54 +00:00
Dion Hulse
34fa8af8bb Core Upgrader: Include an unmodified $wp_version in Core_Upgrader::upgrade(). This protects against cases where the global $wp_version has been modified. See #25772 
git-svn-id: https://develop.svn.wordpress.org/trunk@26017 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 06:22:23 +00:00
Dion Hulse
18e173ae80 Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to. Props nacin. See #25772 for trunk 
git-svn-id: https://develop.svn.wordpress.org/trunk@26016 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 06:19:05 +00:00
Dion Hulse
83754e1636 Remove dead code from the Plugin Upgrader class. Props jdgrimes. Fixes #25470 
git-svn-id: https://develop.svn.wordpress.org/trunk@26015 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 05:47:41 +00:00
Dion Hulse
58e4a21f07 When checking filesystem permissions for core updates, only check the permissions of the files which we need to alter. Props nacin for initial patch. Fixes #25771 for trunk 
git-svn-id: https://develop.svn.wordpress.org/trunk@26014 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 05:42:23 +00:00
Dion Hulse
43d50e9c9e Add a filter to the Background Updates debug email, matches the filter used on the non-debug post-update emails. Props pento. Fixes #25756 
git-svn-id: https://develop.svn.wordpress.org/trunk@26013 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 02:14:34 +00:00
Scott Taylor
5643e3ca17 Pass $args to the export_wp action in export_wp(), which is currently passed no arguments. 
Props nickdaugherty.
Fixes #25574.



git-svn-id: https://develop.svn.wordpress.org/trunk@26011 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-05 01:26:49 +00:00
Sergey Biryukov
6fa1c89458 Pass comment ID and comment post ID to get_comment_class() in WP_Comments_List_Table::single_row(). 
props drozdz.
fixes #25814.

git-svn-id: https://develop.svn.wordpress.org/trunk@26001 602fd350-edb4-49c9-b593-d223f7449a82
 2013-11-04 10:59:58 +00:00
Sergey Biryukov
bc6c0c9b0f Correct @since values for various hooks. fixes #25766. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25991 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-30 03:19:16 +00:00
Andrew Nacin
78f8c980da Use correct variable in WP_Automatic_Updater::send_email(). 
props pento.
see #25757 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25977 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-29 13:45:17 +00:00
Sergey Biryukov
2e50c871ab Avoid a PHP warning in wp_generate_attachment_metadata() if $metadata is not an array. props asakurayoh. fixes #25649. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25968 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-28 16:42:36 +00:00
Sergey Biryukov
267b476885 Fix a copy/paste error in wp_update_theme() description. props Caspie. fixes #25742. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25964 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-28 10:55:50 +00:00
Drew Jaynes
3a26e383ae Inline documentation for hooks in wp-admin/includes/theme.php. 
Props l10n for the initial patch.
Fixes #25732.


git-svn-id: https://develop.svn.wordpress.org/trunk@25961 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-27 22:45:32 +00:00
Andrew Nacin
1694272bff When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning. 
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.

see #25716 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25956 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-27 21:08:25 +00:00
Drew Jaynes
acb441a519 Inline documentation for hooks in wp-admin/includes/schema.php. 
Props johnafish, kpdesign.
Fixes #25498.


git-svn-id: https://develop.svn.wordpress.org/trunk@25938 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-26 20:28:34 +00:00
Drew Jaynes
eef2e83b13 Inline documentation for hooks in wp-admin/includes/nav-menu.php. 
Props Faison.
Fixes #25474.


git-svn-id: https://develop.svn.wordpress.org/trunk@25935 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-26 17:47:33 +00:00
Andrew Nacin
9a2bf56fc3 Avoid a notice for an undefined $checksums variable when updating from pre-3.7 to post-3.7. 
props GaryJ.
fixes #25689 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25915 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-25 20:14:23 +00:00
Andrew Nacin
7508e7c03b Add editimage.min.js to $_old_files. see #24999. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25897 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-24 19:26:11 +00:00
Andrew Nacin
391b22a4de Confirm delete_site_option() exists before calling it during an update. 
This function won't yet exist when updating from 2.7 [sic].

fixes #25682 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25893 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-24 18:17:41 +00:00
Andrew Nacin
9c5420d74d Remove debug code from WP_Automatic_Updater::send_email(). 
props markmcwilliams for initial patch.
see #25678.


git-svn-id: https://develop.svn.wordpress.org/trunk@25891 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-24 01:50:09 +00:00
Andrew Nacin
3d2776d023 Introduce a send_core_update_notification_email filter to control whether to send update notifications. 
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.

This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.

see #25603.


git-svn-id: https://develop.svn.wordpress.org/trunk@25882 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-23 19:46:33 +00:00
Ryan Boren
30f822b8ee Pinking shears 
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-23 14:37:54 +00:00
Andrew Nacin
ff69fb4b8f Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version. 
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.

This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.

fixes #25654.


git-svn-id: https://develop.svn.wordpress.org/trunk@25873 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 21:18:09 +00:00
Andrew Nacin
aab4ffb29d Show the nag we show for a stuck .maintenance file when an auto update failed. 
see #25654.


git-svn-id: https://develop.svn.wordpress.org/trunk@25872 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 21:14:06 +00:00
Andrew Nacin
ddbc271329 "some files" instead of "certain files". Less stuffy. 
props markjaquith.
see #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25871 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 18:40:20 +00:00
Andrew Nacin
f36fbb550c New, better error message when we realize we won't be able to copy a file and continue with the update. 
fixes #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25870 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 18:20:51 +00:00
Andrew Nacin
1a7bfffd0b Only enforce disk free space checks when doing background updates. 
see #25652.


git-svn-id: https://develop.svn.wordpress.org/trunk@25869 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 18:17:13 +00:00
Andrew Nacin
c87ad6023d Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 17:21:32 +00:00
Andrew Nacin
ea7d0de723 Updates: Disable maintenance mode once we've finished copying files, to minimize disruption. 
props dd32.
fixes #25655.


git-svn-id: https://develop.svn.wordpress.org/trunk@25866 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 17:19:48 +00:00
Andrew Nacin
d0d07cf614 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative. 
props dd32 for initial patch.
fixes #25657.


git-svn-id: https://develop.svn.wordpress.org/trunk@25863 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 09:48:36 +00:00
Andrew Nacin
bce2656e6d Move upgrader_process_complete for core to its proper place in Core_Upgrader. 
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.


git-svn-id: https://develop.svn.wordpress.org/trunk@25861 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-22 04:36:54 +00:00
Andrew Nacin
597e82e94c Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.) 
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.


git-svn-id: https://develop.svn.wordpress.org/trunk@25859 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-21 22:28:07 +00:00
Andrew Nacin
d96b64c116 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED. 
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25851 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 21:23:43 +00:00
Andrew Nacin
fda5b39db2 Use correct variable. fixes #10787. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25843 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 17:15:36 +00:00
Andrew Nacin
0b22aae62d Notify administrators of successful, failed, and pending core updates. 
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25841 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 16:29:16 +00:00
Andrew Nacin
142d8c3d30 Delete expired transients on database upgrades. 
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.


git-svn-id: https://develop.svn.wordpress.org/trunk@25838 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 07:47:44 +00:00
Andrew Nacin
92c2bc7797 Introduce email templates for automatic background updates. 
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.


git-svn-id: https://develop.svn.wordpress.org/trunk@25837 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-18 06:32:27 +00:00
Andrew Nacin
aa4635548d set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin. 
fixes #25622.


git-svn-id: https://develop.svn.wordpress.org/trunk@25836 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 23:23:42 +00:00
Andrew Nacin
8cb344e237 In automatic background updates, standardize on 'update'. 
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25835 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 23:20:56 +00:00
Dion Hulse
3ce626a96b Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check). 
See #25576, #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25831 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 18:39:04 +00:00
Dion Hulse
d2d9b963a2 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock. 
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25828 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 05:23:35 +00:00
Andrew Nacin
4644bb87f6 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25825 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 04:01:06 +00:00
Andrew Nacin
c39143fd2e Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods. 
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25823 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 00:54:15 +00:00
Dion Hulse
d0bd68cf5f Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25822 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-17 00:11:25 +00:00
Dion Hulse
d5aba84213 Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25818 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 22:26:47 +00:00
Dion Hulse
853c9a50bd When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25817 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 19:47:21 +00:00
Andrew Nacin
977ca48a58 Merge the should_auto_update() and can_auto_update() methods. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25815 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 19:34:05 +00:00
Dion Hulse
aa5c907e40 Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200 
git-svn-id: https://develop.svn.wordpress.org/trunk@25812 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 17:06:58 +00:00
Dion Hulse
549029393f Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath. 
See #18201


git-svn-id: https://develop.svn.wordpress.org/trunk@25811 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 15:19:59 +00:00
Andrew Nacin
e192eb396e Include translations in the update bubbles (as +1 if there are any). see #18200. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25810 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 14:33:21 +00:00
Dion Hulse
96aa66a924 Remove the no longer used Headerless_Upgrader_Skin class, it's been replaced by Language_Pack_Upgrader_Skin. 
See #18200, [25806]


git-svn-id: https://develop.svn.wordpress.org/trunk@25807 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:18:12 +00:00
Dion Hulse
ddaaa6d88a Language Packs: Many many fixes such as: 
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200, #22704



git-svn-id: https://develop.svn.wordpress.org/trunk@25806 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:14:29 +00:00
Andrew Nacin
4f7112000f Avoid numerous potential PHP warnings when dealing with the pre-r25801 get_core_checksums() return value. 
Warnings included current(), filestat(), and md5_file().

see #18201. see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25805 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-16 04:01:12 +00:00
Andrew Nacin
867f084ca0 Significantly simplify get_core_checksums(), as the caching and chunking was causing too much grief. 
Make sure we only do our pre-flight is_writable check when the file exists.

see #18201. see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25801 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 23:02:28 +00:00
Andrew Nacin
14b83f44f1 Use correct variable. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25800 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 22:06:08 +00:00
Andrew Nacin
3b724d5082 Remove accidental debug cruft in [25780]. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25799 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 21:24:01 +00:00
Andrew Nacin
1e8729b5c1 Avoid our pre-flight writable checks if get_core_checksums() doesn't exist yet. 
Thus, it will not work for 3.6 => 3.7, only 3.7+.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25798 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 20:34:02 +00:00
Andrew Nacin
0a284a4d5c Only add error data to the files_not_writable WP_Error if the install already has [25775] and [25796] applied. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25797 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 20:00:01 +00:00
Andrew Nacin
55d176020b In show_message(), only print error data if it is a string. 
see #25576, [25775].


git-svn-id: https://develop.svn.wordpress.org/trunk@25796 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:50:48 +00:00
Andrew Nacin
204ca72a66 Core Updates: Verify that all files we're about to copy are actually writable, when using the direct transport. 
Once we begin to copy core files, all bets are off. This allows us to fail early when we'll otherwise need to stop midway through due to permissions issues, which is a particularly bad problem when only some files have permissions issues.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25794 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:17:56 +00:00
Andrew Nacin
c72ba036cf Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir(). 
This occurs when we can't copy a file. We chmod it and try again.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25793 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 19:13:33 +00:00
Dion Hulse
fa79184a7d Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/. 
My bad. See #22704, [25781].


git-svn-id: https://develop.svn.wordpress.org/trunk@25787 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 14:54:29 +00:00
Andrew Nacin
2eebc47254 Hide auto updates from update-core.php directly in get_core_updates(). see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25783 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 05:06:35 +00:00
Andrew Nacin
85d32ce873 Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback. 
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25782 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-15 02:58:07 +00:00
Andrew Nacin
1918e828da Automatic updates: Include error data in the follow-up API request. 
props dd32.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25781 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 23:32:47 +00:00
Andrew Nacin
3eac3d0380 Parse absolute paths out of error data. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25780 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 22:24:28 +00:00
Dion Hulse
b492ae85f8 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return. 
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25779 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:54:33 +00:00
Andrew Nacin
67c80dae13 Account for the possible failure of disk_free_space() in update_core(). 
see #22704, #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25778 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:14:39 +00:00
Andrew Nacin
d6a1b681d3 Auto updates: Only attempt a roll back when we've hit a critical error code. 
Specifically, this means when we've failed in copying files.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25777 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 21:02:46 +00:00
Andrew Nacin
b8efab15d8 Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files. 
see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25776 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:57:28 +00:00
Andrew Nacin
47e85a9b54 In the upgrader, only print additional error data if it is a string. 
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25775 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:19:52 +00:00
Andrew Nacin
5db3863d12 In unzip_file(), confirm we have enough available disk space before extracting. 
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25774 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 20:14:13 +00:00
Andrew Nacin
bd26f54af2 More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25772 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-14 19:37:53 +00:00
Andrew Nacin
7bf44580a9 Add explicit link to the installation being updated in debugging emails. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25770 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-12 20:17:20 +00:00
Andrew Nacin
9eff9eaebe Silence possible warnings from is_dir(). fixes #25572. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25764 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-11 17:10:18 +00:00
Andrew Nacin
2e605e76c6 Refine error codes throughout the upgrader so we can better detect at what stage updates fail. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25763 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-11 16:05:13 +00:00
Andrew Nacin
627b25bf50 Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25755 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 14:45:55 +00:00
Dion Hulse
f0571c02b7 After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25752 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 01:56:44 +00:00
Dion Hulse
e03279e8b0 In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful. 
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25750 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-10 01:31:22 +00:00
Andrew Nacin
12cb3a353e Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height. 
props plocha.
fixes #25038.


git-svn-id: https://develop.svn.wordpress.org/trunk@25744 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 19:06:56 +00:00
Helen Hou-Sandi
99df61b666 Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25741 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 18:46:34 +00:00
Dion Hulse
28736216f3 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069 
git-svn-id: https://develop.svn.wordpress.org/trunk@25739 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-09 16:46:31 +00:00
Scott Taylor
4aa0066736 Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video in attachment_submitbox_metadata(). 
Props kovshenin.
See #23926.



git-svn-id: https://develop.svn.wordpress.org/trunk@25727 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-08 15:31:32 +00:00
Andrew Nacin
04f053ce0c Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping. 
props SergeyBiryukov.
see #25023.
for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25719 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-07 18:34:35 +00:00
Drew Jaynes
2a2587c6dc Inline documentation for hooks in wp-admin/includes/bookmark.php. 
Props johnafish, kpdesign.
Fixes #25494.


git-svn-id: https://develop.svn.wordpress.org/trunk@25706 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-07 02:18:20 +00:00
Andrew Nacin
40ea01d759 Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates. 
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25700 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 15:45:09 +00:00
Andrew Nacin
0286d7030d Don't modify post_author during a quick edit when the post type doesn't support authors. 
props ocean90.
fixes #16645.


git-svn-id: https://develop.svn.wordpress.org/trunk@25698 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 13:14:06 +00:00
Andrew Nacin
9f23f85ae2 Run _fix_attachment_links() when post_status is future or private in addition to publish. 
Fixes regression caused by [20308].

props jond3r.
fixes #25268.


git-svn-id: https://develop.svn.wordpress.org/trunk@25697 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 12:55:38 +00:00
Andrew Nacin
352ff49768 Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid. 
props garyc40, wonderboymusic.
fixes #14578.


git-svn-id: https://develop.svn.wordpress.org/trunk@25695 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 10:55:42 +00:00
Andrew Nacin
c0fb231f92 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override. 
props azaozz.
fixes #24930.


git-svn-id: https://develop.svn.wordpress.org/trunk@25694 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-06 10:45:25 +00:00
Andrew Nacin
1b37564f35 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25691 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-05 10:58:20 +00:00
Andrew Nacin
a2c2641419 Avoid counting auto-drafts in sticky. 
props nofearinc.
fixes #25127.


git-svn-id: https://develop.svn.wordpress.org/trunk@25678 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-03 01:15:30 +00:00
Andrew Nacin
635a1249f5 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses. 
props creativeinfusion.
fixes #24818.


git-svn-id: https://develop.svn.wordpress.org/trunk@25676 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-03 00:59:12 +00:00
Andrew Nacin
df647346b1 Don't use a double negative. 
props TobiasBg.
fixes #18201.


git-svn-id: https://develop.svn.wordpress.org/trunk@25674 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:49:34 +00:00
Andrew Nacin
69a17e3469 Links manager: Restrict field length based on DB schema. 
props solarissmoke, vinod-dalvi.
fixes #17296, #12264.


git-svn-id: https://develop.svn.wordpress.org/trunk@25670 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:10:24 +00:00
Dominik Schilling (ocean90)
6311fbbfdb Replace use of global $user_ID in favor of get_current_user_id(). fixes #25372. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25669 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 21:09:52 +00:00
Andrew Nacin
212dba1113 Show a proper error message on the dashboard when the current theme is broken. 
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.

Clean up broken/ugly "alt" row styling when we are displaying broken themes.

props johnbillion for initial patch.
fixes #21670.


git-svn-id: https://develop.svn.wordpress.org/trunk@25666 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 20:49:59 +00:00
Scott Taylor
a27234c898 Rather than adding a taxonomy arg to get_category(), convert all uses of get_category() in core to get_term(). By doing so, we negate the need to call _make_cat_compat() in a few places that are only looking for a single property. 
Fixes #8722.



git-svn-id: https://develop.svn.wordpress.org/trunk@25662 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 19:58:50 +00:00
Andrew Nacin
64d3d53838 More string cleanups. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25658 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 18:50:45 +00:00
Andrew Nacin
fc97814a23 This error message should have a period. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25656 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 17:44:09 +00:00
Andrew Nacin
49e7cf1a30 Rollback is not a verb. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25655 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-02 17:43:15 +00:00
Dion Hulse
6d29f14560 Automatic Updates: Remove some debug from [25649] See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25651 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:29:19 +00:00
Dion Hulse
3fa23828e3 Automatic Updates: Disable Automatic updates for Mercurial(HG) and Bazaar(bzr) version control systems in addition to Git and SVN. Props jamescollins. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25650 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:24:06 +00:00
Dion Hulse
05a01e5964 Automatic Updates: Add a rollback functionality upon installation failure, the rollback package will be available for partial-updates for automatic updates and be similar to our existing partial builds (but in reverse). 
A further iteration of this is to also detect whitescreens (fatals) after a auto update, and trigger the rollback for that too.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25649 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-30 00:20:35 +00:00
Dion Hulse
f1928e42bf MD5 file verification: Prevent md5_file() warnings when files don't exist, additionally, don't verify wp-content files as they can be updated separately, as well as WP_CONTENT_DIR being set elsewhere. See #22704 See #18201 
git-svn-id: https://develop.svn.wordpress.org/trunk@25648 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-29 23:07:59 +00:00
Dion Hulse
fefaa807e9 Automatic Updates: Skip doing the sanity checking MD5 before deciding if we should use a partial build or not, This change means we always use a partial build for automatic updates. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25647 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-29 22:59:46 +00:00
Drew Jaynes
78d93bfac3 Improve inline documentation for Walker_Nav_Menu, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist. 
Includes previously undocumented parameters.

See #23406.


git-svn-id: https://develop.svn.wordpress.org/trunk@25643 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 21:01:54 +00:00
Drew Jaynes
346d71fdbd Inline documentation for Walker_Category_Checklist. 
See #23406.


git-svn-id: https://develop.svn.wordpress.org/trunk@25642 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 18:07:02 +00:00
Andrew Nacin
c3a6047584 Fix strict notice. see #22704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25635 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-28 06:32:14 +00:00
Andrew Nacin
ed31cbfab1 Changes to automatic background updates in preparation for Beta 1. 
* Show a notice for beta testers on update-core.php explaining the status of their install. Three possibilities: auto updates are enabled, auto updates are disabled because the install doesn't support SSL HTTP requests, and auto updates are disabled because it is a VCS checkout.
 * Improve the output of the email, for maximum debugging potential. Failures are clearly labeled and the email leads testers to the support forums and Trac.
 * Try to create wp-content/languages in the upgrader if it doesn't exist. Our mkdir isn't recursive, so trying to create wp-content/languages/plugins could fail.
 * Abstract out version control checkout determination into a public method. The filter is now auto_upgrade_is_vcs_checkout, still subject to change.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25633 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-27 23:20:08 +00:00
Drew Jaynes
8a3df7d4b4 Inline documentation for hooks in wp-admin/includes/class-wp-plugin-install-list-table.php. 
Props naomicbush.
Fixes #25357.


git-svn-id: https://develop.svn.wordpress.org/trunk@25630 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-26 02:47:44 +00:00
Helen Hou-Sandi
ab117ae99c Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25608 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 20:22:24 +00:00
Andrew Nacin
34e9dc9f06 Introduce wp_get_user_contact_methods() as a public version of _wp_get_user_contactmethods. 
props johnnyb.
fixes #24273.


git-svn-id: https://develop.svn.wordpress.org/trunk@25606 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 18:13:18 +00:00
Dion Hulse
e4a523977f Automatic Updates: Correct a typo of a constant, s/DISABLE_FILE_MODS/DISALLOW_FILE_MODS/. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25599 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 07:15:58 +00:00
Dion Hulse
c8251ec989 Automatic Core Updates: Enable Core Automatic Updates for Security releases, Development nightly releases, and, Language packs. See #22704 
For more information on Automatic Core Updates, See #22704 and http://wp.me/p2AvED-1Lo



git-svn-id: https://develop.svn.wordpress.org/trunk@25598 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 03:35:53 +00:00
Helen Hou-Sandi
9ac7b0ce32 Saner CSS for row actions - now we can just target .row-actions instead of both .row-actions and .row-actions-visible. CSS for .row-actions-visible remains for now due to usage in plugins. Visibility is controlled by toggling a .visible class. fixes #25403. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25592 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 01:53:08 +00:00
Andrew Nacin
d420b71d52 Ignore unauthorized meta keys in meta_form(). fixes #18786. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25591 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 01:30:31 +00:00
Drew Jaynes
164b32b566 Inline documentation for hooks in wp-admin/includes/revision.php. 
Fixes #25283.


git-svn-id: https://develop.svn.wordpress.org/trunk@25587 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 22:44:26 +00:00
Dion Hulse
aa9a8de56b Language Packs: Integrate Language Packs into the Auto-upgrader. See #18200 See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25568 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 09:37:25 +00:00
Andrew Nacin
330a8daccd Add a language pack upgrader class. 
At the conclusion of any upgrade, after the transients are refreshed from the API, pending translations are downloaded and installed to wp-content/languages.

props dd32.
see #18200.


git-svn-id: https://develop.svn.wordpress.org/trunk@25566 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-23 02:07:51 +00:00
Dion Hulse
455b8d47a9 First pass at documenting the WP_Filesystem methods. This also introduces stubs of the methods into the base class which are documented, which subclasses can override, some methods were cleaned up at the same time. 
See #18476 See #23122. Props kurtpayne, bananastalktome, and, DrewAPicture 


git-svn-id: https://develop.svn.wordpress.org/trunk@25560 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-22 04:43:29 +00:00
Drew Jaynes
05ae44eaca Inline documentation for hooks in wp-admin/includes/ajax-actions.php. 
Fixes #25374.


git-svn-id: https://develop.svn.wordpress.org/trunk@25558 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 20:46:15 +00:00
Drew Jaynes
8c8a0b990c Make the WP_List_Table::months_dropdown() query results filterable. 
Introduces the `months_dropdown_results` filter.

Fixes #17022.


git-svn-id: https://develop.svn.wordpress.org/trunk@25556 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 18:34:26 +00:00
Dion Hulse
f0fa5f821e Add a missing . in the Hook documentation from r25542 See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25543 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 07:01:23 +00:00
Dion Hulse
6048f75b93 WordPress Core Automatic Updates: Add a filter as to whether or not to send the site administrator a summary of executed updates. Props JustinSainton. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25542 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:59:25 +00:00
Dion Hulse
f377693931 When using download_url(), if the resource supplies a Content-MD5 header, verify the downloaded file against it. Fixes #20074 
git-svn-id: https://develop.svn.wordpress.org/trunk@25541 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:53:50 +00:00
Dion Hulse
eb3bee3ba5 Upgrader: Perform a MD5 file verification check on the files during upgrade. This ensures that both a Partial upgrade build can be used, and that all the files were copied into place correctly. 
Props pento for initial patch. Fixes #18201


git-svn-id: https://develop.svn.wordpress.org/trunk@25540 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-21 06:48:20 +00:00
Helen Hou-Sandi
76cb40634b Make it possible to filter comment screen by post type; no UI. props johnbillion, c3mdigital. fixes #18596. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25526 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-20 20:15:51 +00:00
Drew Jaynes
ebf3305722 Inline documentation for hooks in wp-admin/includes/plugin-install.php. 
Props naomicbush.
See #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25511 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-20 02:21:44 +00:00
Helen Hou-Sandi
68f34a5d80 Add a class to the bulk actions wrapper div. props nofearinc. fixes #25197. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25509 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 21:00:02 +00:00
Helen Hou-Sandi
c23defe7c3 Restore post formats to bulk editing. props azaozz, SergeyBiryukov, DrewAPicture. fixes #24096. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25505 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 17:46:25 +00:00
Sergey Biryukov
24db2253b3 Some more tweaks for the documentation in wp-admin/includes/ms.php. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25497 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 16:05:21 +00:00
Dion Hulse
f52d0a96af WordPress Core Automatic Updates: Add a post-upgrade summary email to the WordPress install's admin email address. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25496 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 08:45:06 +00:00
Dion Hulse
fb0b86a078 Upgrader: Fix the order of arguements passed to wp_parse_args() in the Upgrader, introduced with [25272]. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25495 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 08:39:51 +00:00
Sergey Biryukov
a4f3fc3489 Update inline documentation for hooks in wp-admin/includes/ms.php. 
props jamescollins.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25486 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-19 00:04:16 +00:00
Sergey Biryukov
801f56dec2 Clean up the documentation for hooks in wp-admin/includes/plugin.php. 
props DrewAPicture.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25482 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 19:35:10 +00:00
Sergey Biryukov
8834a52e40 Inline documentation for hooks in wp-admin/includes/ms.php. 
props enej, DrewAPicture.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25481 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 18:21:46 +00:00
Sergey Biryukov
7069b5c47c Correct @since for hooks in wp-admin/includes/plugin.php. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25477 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 11:57:18 +00:00
Peter Westwood
e71b7b15cf Inline documentation for hooks in wp-admin/includes/plugin.php 
See #25229 props dllh


git-svn-id: https://develop.svn.wordpress.org/trunk@25474 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-18 07:37:39 +00:00
Sergey Biryukov
89c1b75ada Deprecate the_attachment_links(), unused since [6910]. props vinod dalvi. fixes #25340. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25472 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 09:07:12 +00:00
Dion Hulse
ea24e2ce0d WordPress Upgrades: When defining the default filesystem permissions for files/directories, base the value on the existing ABSPATH & index.php file permissions - so as to respect the executable bit (if set) and not set global read if not required. 
This sets a minimum permission set to 750 and 640 for directories and files, so any systems requring less permission than that will still need to define the constants themselves. Fixes #20069 


git-svn-id: https://develop.svn.wordpress.org/trunk@25469 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 08:05:23 +00:00
Dion Hulse
ed8f918e4e WordPress Core Automatic Updates: Remove some debug. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25468 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 04:07:35 +00:00
Dion Hulse
d1dcc8cca3 WordPress Core Automatic Updates: Switch from using a transient for locking the upgrade process, to using a site option. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25467 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-17 02:27:21 +00:00
Andrew Nacin
c89f2e38a8 Add nginx detection to the Permalink Settings screen. 
Introduces got_url_rewrite() and a corresponding filter, which should now be used in lieu of the got_rewrite filter in got_mod_rewrite().

This does not write or even suggest nginx configuration; rather, it prevents nginx from being considered as either Apache or as an unrecognized server.

props johnbillion.
fixes #25098.


git-svn-id: https://develop.svn.wordpress.org/trunk@25456 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 20:06:27 +00:00
Andrew Nacin
fdc9bc6130 Allow callback args to be passed from wp_add_dashboard_widget() to add_meta_box(). 
props jdgrimes.
fixes #25152.


git-svn-id: https://develop.svn.wordpress.org/trunk@25454 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 18:06:05 +00:00
Andrew Nacin
e24a1ac0dc Use get_terms() in the ajax tag search. 
props Chouby.
fixes #25231.


git-svn-id: https://develop.svn.wordpress.org/trunk@25452 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-16 17:50:16 +00:00
Andrew Nacin
1d80307d5d Multisite blogs table: Convert the archived field from enum to tinyint to match the other status fields. fixes #12832. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25448 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-15 23:11:30 +00:00
Dion Hulse
3ec962dd56 WordPress Core Automatic Updates: Remove an accidental closure which isn't supported in PHP 5.2. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25447 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-15 01:25:56 +00:00
Andrew Nacin
e539910e1a Move to JSON for three api.wordpress.org endpoints. see #25311. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25441 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 19:30:44 +00:00
Scott Taylor
535ae26afd Fix several esoteric errors related to AJAX unit tests for comments: 
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 18:35:43 +00:00
Sergey Biryukov
27d3a78193 Inline documentation for hooks in wp-admin/includes/comment.php. 
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25434 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 01:00:44 +00:00
Scott Taylor
402e61f269 Fix some undefined index notices related to Comment unit tests: 
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25433 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 22:17:51 +00:00
Scott Taylor
ac23d53402 * Avoid notices in tests/ajax/Autosave by bailing early when get_post() returns nothing. 
* Check for the existence of `$_POST['catslist']` before using it in `wp_ajax_autosave()`.

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25430 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 21:21:16 +00:00
Dion Hulse
9c1b30860c Upgrader: Allow plugins to short-circuit the package download. Props rmccue and DrewAPicture. Fixes #22378 
git-svn-id: https://develop.svn.wordpress.org/trunk@25427 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 12:52:28 +00:00
Sergey Biryukov
a57529c720 Avoid a PHP warning in network admin if a constant corresponding to a drop-in is not defined. fixes #25301. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25425 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 09:36:08 +00:00
Dion Hulse
5959a7011b WordPress Core Automatic Updates: Pass the Filesystem path as $context to request_filesystem_credentials(). See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25422 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 06:52:11 +00:00
Dion Hulse
63956aa479 WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25421 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 06:18:16 +00:00
Sergey Biryukov
96d12ddd9d Better alignment for wp_prepare_revisions_for_js() inline docs. see #25283. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25420 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 23:14:55 +00:00
Sergey Biryukov
529c973323 Inline documentation fixes and additions for wp-admin/revision.php and wp-admin/includes/revision.php. 
props adamsilverstein.
see #25283.

git-svn-id: https://develop.svn.wordpress.org/trunk@25419 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 22:58:45 +00:00
Andrew Nacin
bb2908d613 Clear all transients (regardless of expiration) on all database upgrades. see #20316. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25416 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 21:13:18 +00:00
Andrew Nacin
8917f2b3bd Add populate_network_meta filter to populate_network(). 
props jeremyfelt.
fixes #25020.


git-svn-id: https://develop.svn.wordpress.org/trunk@25414 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 20:48:20 +00:00
Andrew Nacin
3631b81545 Fix comma placement in [25179]. 
props gradyetc.
see #15004, fixes #25298.


git-svn-id: https://develop.svn.wordpress.org/trunk@25413 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 20:15:30 +00:00
Helen Hou-Sandi
435c2b5686 Add file size to attachment publish meta box. props desrosj. fixes #25170. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25403 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 15:09:35 +00:00
Sergey Biryukov
a56e83373d Consistently call skin methods in WP_Upgrader. fixes #25254. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25370 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 02:42:10 +00:00
Sergey Biryukov
c05412b16c Fix invalid markup when searching for installed themes. fixes #25288. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25369 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 00:03:01 +00:00
Dion Hulse
ea6da7d5dc Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237 
git-svn-id: https://develop.svn.wordpress.org/trunk@25349 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-11 08:26:57 +00:00
Dion Hulse
47c25b41af Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259 
git-svn-id: https://develop.svn.wordpress.org/trunk@25347 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-11 08:08:35 +00:00
Andrew Nacin
2c0b23557a Ignore user ID post data. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25316 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 17:57:14 +00:00
Scott Taylor
d141191598 Consistently wrap author and excerpt nodes with CDATA in feeds. 
Fixes #18056.



git-svn-id: https://develop.svn.wordpress.org/trunk@25315 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 16:54:16 +00:00
Dion Hulse
4a56e07c75 Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577 
git-svn-id: https://develop.svn.wordpress.org/trunk@25308 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 07:53:15 +00:00
Dion Hulse
30827b47c1 Upgrader: Deprecate a few mostly unused functions, wp_update_plugin(), wp_update_theme(), and, wp_update_core(). 
wp_update_core() was still used, as it was never updated to make use of the newer Skins. Fixes #21874


git-svn-id: https://develop.svn.wordpress.org/trunk@25307 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 06:44:25 +00:00
Dion Hulse
fb20ed8b5b WP_Filesyste: SSH2 PHP Extension support: Fix a case where defining a custom FS_CHMOD_FILE / FS_CHMOD_DIR constant wouldn't take effect due to chmod() failing with a invalid path. Fixes #23589 
git-svn-id: https://develop.svn.wordpress.org/trunk@25306 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 03:05:01 +00:00
Dion Hulse
beaf91c019 WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25305 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 02:54:50 +00:00
Dion Hulse
2f40784d97 WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237 
git-svn-id: https://develop.svn.wordpress.org/trunk@25304 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 02:42:52 +00:00
Helen Hou-Sandi
bde3435a63 Alignment standards for [25296]. props DrewAPicture. see #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25300 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 22:06:21 +00:00
Sergey Biryukov
8e4a6b31cd Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25298 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 18:16:09 +00:00
Helen Hou-Sandi
ed6316d44b Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25297 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 16:19:39 +00:00
Helen Hou-Sandi
e9173ef83b Add media_submitbox_misc_sections and audio_submitbox_misc_sections filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25296 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 16:18:26 +00:00
Scott Taylor
2661cd53fc Use get_the_title() when dealing with post_type-like items in the admin. 
Props nacin, DrewAPicture.
Fixes #14975.



git-svn-id: https://develop.svn.wordpress.org/trunk@25285 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 17:08:00 +00:00
Andrew Nacin
69a949d160 Add new ajax_query_attachments_args filter. 
props alex-ye.
fixes #24285.


git-svn-id: https://develop.svn.wordpress.org/trunk@25279 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 15:17:35 +00:00
Sergey Biryukov
e8daea7de7 Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross. 
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.

git-svn-id: https://develop.svn.wordpress.org/trunk@25277 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 14:09:07 +00:00
Dion Hulse
d9c5265303 WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049 
git-svn-id: https://develop.svn.wordpress.org/trunk@25274 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 08:28:59 +00:00
Dion Hulse
9095e4b866 Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25272 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 01:32:09 +00:00
Scott Taylor
4286692d7d Remove redundant checks in some update functions. Adds some readability/coding standards cleanup. 
Props miqrogroove, azaozz.
Fixes #22828.


git-svn-id: https://develop.svn.wordpress.org/trunk@25256 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 17:04:03 +00:00
Scott Taylor
16ef2c2e36 Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this. 
Props jdgrimes.
See #25160.



git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 16:33:50 +00:00
Scott Taylor
d10b9d32a0 Remove unnecessary checks before setting $wp_settings_* arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional array. 
Props scribu.
Fixes #17884.



git-svn-id: https://develop.svn.wordpress.org/trunk@25240 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 19:06:13 +00:00
Dion Hulse
7c8107734f Core Auto Updates: Add a initial skin to allow capturing the output from the upgrader without displaying it (such as we need during cron calls). 
This has been copied almost verbatim from the automatic-updater plugin with a few style tweaks and additional upgrade-possible check. See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25228 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 07:16:16 +00:00
Dion Hulse
ea02f466c9 Upgrader: Split the UI "skins" out from the main Upgrader file into a seperate file to reduce the length of the files. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25227 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 06:34:38 +00:00
Sergey Biryukov
56731f831d Avoid 'Only variables should be passed by reference' notice on plugin search. props daankortenbach. fixes #25217. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25210 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 13:53:57 +00:00
Sergey Biryukov
8b16c9bba8 Deprecate wp_nav_menu_locations_meta_box(), unused since [23441]. props DrewAPicture. fixes #24942. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25209 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 11:25:16 +00:00
Sergey Biryukov
a82593e4e4 Move get_real_file_to_edit() upper in the file for consistency with the existing order of functions. Some phpdoc fixes and additions. see #23680. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25208 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 11:18:35 +00:00
Sergey Biryukov
6bef163456 Update phpdoc for get_user_to_edit(), get_userdata(), and get_user_by(). props tivnet. fixes #24992. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25204 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 03:24:33 +00:00
Sergey Biryukov
4e75fe1bf1 Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25201 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-01 12:36:45 +00:00
Dion Hulse
b518606d42 Plugin Upgrader: Plugin_Upgrader::upgrade() returns nothing in event of success, every other install(), upgrade() and bulk_upgrade() method returns true, so return true; 
git-svn-id: https://develop.svn.wordpress.org/trunk@25181 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 07:37:32 +00:00
Dion Hulse
e320a48146 Theme Upgrader: Be super-careful and check the contents of the $wp_theme_directories variable before merging it, if someone has changed it directly, or worse, unset it, this could've resulted in the $protected_directories being empty. See [25082] See #22501 
git-svn-id: https://develop.svn.wordpress.org/trunk@25180 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 07:34:24 +00:00
Andrew Nacin
21b61a9e6f Add signup_id primary key to $wpdb->signups, and add better indexes. 
props josephscott, pento, barry.
see #15004.


git-svn-id: https://develop.svn.wordpress.org/trunk@25179 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 04:29:06 +00:00
Andrew Nacin
fba8c3dabe Avoid validating wildcard hostnames in populate_network() when multisite is already activated. 
props jeremyfelt.
fixes #25182.


git-svn-id: https://develop.svn.wordpress.org/trunk@25171 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-29 19:30:46 +00:00
Andrew Nacin
65465e9c88 Don't create an edit link to a non-UI post type in the media list table. 
props johnbillion.
fixes #20453.


git-svn-id: https://develop.svn.wordpress.org/trunk@25140 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 20:48:40 +00:00
Andrew Nacin
d41c30be7a Network Admin: Hide the bulk actions checkbox for the main site. 
props ericlewis.
fixes #24463.


git-svn-id: https://develop.svn.wordpress.org/trunk@25125 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 18:45:30 +00:00
Sergey Biryukov
6edecc378d Avoid displaying multiple instances of the same feature pointers on a single screen. props nacin. fixes #25022 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25117 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-24 22:33:51 +00:00
Sergey Biryukov
107d2b8716 Remove unused variable. props jeremyfelt. fixes #25121. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25098 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-23 00:18:48 +00:00
Andrew Nacin
f57bd31f2d Fix various typos in inline documentation. props nofearinc, fixes #25119. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25094 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 22:00:41 +00:00
Andrew Nacin
0c24a916d4 In the admin, do not use auto-generated Gravatar images for comment authors. 
This makes it easier to recognize Gravatars (or lack thereof) when moderating comments.

props solarissmoke.
fixes #7054.



git-svn-id: https://develop.svn.wordpress.org/trunk@25091 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 20:07:51 +00:00
Helen Hou-Sandi
5ea9e40fed Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25083 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 15:23:41 +00:00
Dion Hulse
2ceaba8b30 Theme Installer/Updater: Handle custom Theme directories when updating themes, and installing new themes. Fixes #22501 
git-svn-id: https://develop.svn.wordpress.org/trunk@25082 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 04:49:06 +00:00
Dion Hulse
ddad24c82c Sanitize the plugin path in _get_plugin_data_markup_translate() to a WP_PLUGIN_DIR-relative path. The function is designed in mind for receiving relative paths, but may be used with a absolute path. 
This change makes the function path-agnostic, and can accept either relative or absolute (converting to relative internally). Fixes #20813


git-svn-id: https://develop.svn.wordpress.org/trunk@25081 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 04:02:13 +00:00
Dion Hulse
ead4efa78a Add a note that the FTP Password will not be stored on the server to the FTP credentials page. Fixes #16492 
git-svn-id: https://develop.svn.wordpress.org/trunk@25071 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-21 07:06:12 +00:00
Dion Hulse
b4f0fbd985 Add a filter on the Plugin and Theme installers table listing API args, this allows for plugins to hook in and add custom args to plugins_api() and themes_api() for the Plugin/Theme listing tabls. Fixes #18169 
git-svn-id: https://develop.svn.wordpress.org/trunk@25070 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-21 06:51:51 +00:00
Dion Hulse
318a1c9c52 WP_Filesystem: Use the FTP_* path override constants during upgrades for prefixed paths, ie. use FTP_BASE for ABSPATH/sub-dir as well as just for ABSPATH/. Props vericgar for initial patch. See #14401 
git-svn-id: https://develop.svn.wordpress.org/trunk@25057 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-20 06:46:37 +00:00
Dion Hulse
e4361d8f96 Check to see if mbstring.func_overload is configured to affect string functions before switching charsets. Props SergeyBiryukov. Fixes #25063 
git-svn-id: https://develop.svn.wordpress.org/trunk@25056 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-20 06:23:48 +00:00
Dion Hulse
c6e43f5327 WP_Upgrader: Don't activate maintenance mode in bulk_upgrade() when no Themes or Plugins are specified. This doesn't affect Core, but rather, plugins who use the upgrade routines and do not do precautionary tests. Props jamescollins. Fixes #24496 
git-svn-id: https://develop.svn.wordpress.org/trunk@25048 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-17 05:35:17 +00:00
Andrew Nacin
81248f6568 In populate_network(), insert the first site as blog_id 1, overriding any auto-increment DB seed. props wpmuguru, fixes #16568. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25038 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 20:07:05 +00:00
Andrew Nacin
ea7196081f Add a maxlength attribute to the post password input, reflecting the current DB field length.\ 
props RayBernard, DrewAPicture.
see #24792.



git-svn-id: https://develop.svn.wordpress.org/trunk@25035 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 19:55:19 +00:00
Ryan Boren
5125650b72 Be consistent with the arguments passed to the theme_action_links filter. Stop passing stylesheet from class-wp-ms-themes-list-table.php. 
Props georgestephanis
fixes #24478


git-svn-id: https://develop.svn.wordpress.org/trunk@25032 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 15:46:08 +00:00
Sergey Biryukov
6c3b030245 Avoid PHP notices in get_sample_permalink() and get_sample_permalink_html(). Remove unused global reference. props ocean90. fixes #25005. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25028 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 16:24:08 +00:00
Dion Hulse
b971127bac Remove the usage of @$_GET and @$_POST and just check to see if the indicies are set. Fixes #22429 
git-svn-id: https://develop.svn.wordpress.org/trunk@25025 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 06:05:54 +00:00
Dion Hulse
51c3faba5d WP_Filesystem: Make WP_Filesystem_Base::search_for_folder() a bit more usable on the command-line when the $verbose mode is used, additionally, bail early from the function rather than repeating itself if the CWD is the root directory already. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25024 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 05:59:36 +00:00
Dominik Schilling (ocean90)
bf8e3cab1e Remove unused cat JavaScript file. props carldanley. fixes #24989. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25020 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-14 15:43:03 +00:00
Jon Cave
38345135a1 Add javascript files deleted in [25013] to $_old_files. See #23486. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25019 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-14 15:18:04 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository. 
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-07 05:25:25 +00:00