Commit Graph

39676 Commits

Author SHA1 Message Date
Jonathan Desrosiers 94b6167a04 Site Health: Add missing actions to tests.
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.

Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.

Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734.

git-svn-id: https://develop.svn.wordpress.org/trunk@45170 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:39:37 +00:00
Jonathan Desrosiers 3bba7f2f31 Site Health: Improve the test badge implementation.
Label badges for each Site Health test currently display in either red, orange, or green, regardless of if the test passed or failed. This is confusing, as seeing red labels in the “Passed Test” section could alarm users (when really everything is OK and no action is required), and seeing green labels in the “Failed Tests” section would not appropriately encourage the user to take appropriate action.

This change makes several improvements to the label badges:

- Always right align the badges for consistent display.
- Remove background fill for badges. Instead, use a border.
- Use a consistent styling for all tests (passed and failed).
- The text color no longer uses true black (#000000).
- The `.badge.pink` CSS definition has been switched to `.badge.purple`, and the definitions for blue, gray, and green have also been updated to more closely follow the official WordPress color palette.

Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce, mdwolinski, alexdenning.
Fixes #46623.

git-svn-id: https://develop.svn.wordpress.org/trunk@45169 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:03:24 +00:00
Jonathan Desrosiers ee18178416 Site Health: Ensure Site Health pages are correctly displayed for RTL locales.
Props: ebrahimzadeh, afercia, mohadeseghasemi.
Fixes #46868.

git-svn-id: https://develop.svn.wordpress.org/trunk@45168 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 16:38:57 +00:00
Jonathan Desrosiers f36d2fbbdc Administration: Remove unnecessary numbered placeholders.
Props: tobifjellner, thrijith.
Fixes #46824.

git-svn-id: https://develop.svn.wordpress.org/trunk@45167 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 16:31:37 +00:00
Jonathan Desrosiers 4740573142 Site Health: Include both site and user locales in debug information.
Previously, only the site’s locale was displayed in the Site Health debug information. Moving forward, both the site’s default locale and the user’s locale will be specified.

This change also removes the `@param` tag for `WP_Debug_Data::debug_data()`. This parameter was previously removed in [45156].

Props: mukesh27, ianbelanger, Clorith, desrosj.
Fixes #46803.

git-svn-id: https://develop.svn.wordpress.org/trunk@45166 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 15:48:13 +00:00
desrosj 26869439ff Upgrade/Install: Prevent plugin auto updates if PHP version requirements are not satisfied.
In [44937] and [44939], changes were made to prevent a user from updating any plugin that requires a higher version of PHP than the site is running. This compliments those changes to also prevent plugins from being auto updated when the same requirements are not met.

Props: TimothyBlynJacobs, davidbaumwald.
Fixes #46613.

git-svn-id: https://develop.svn.wordpress.org/trunk@45165 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 14:01:02 +00:00
Mike Schroder 635adfbe68 Site Health: Clarify `WP_DEBUG` warning and translation contexts.
Clarifies that `WP_DEBUG` can cause `WP_DEBUG_DISPLAY` to be enabled,
and uses the constants themselves in related translation contexts.

Props mukesh27, ocean90, clorith, SergeyBiryukov, mikeschroder.
Fixes #46877.

git-svn-id: https://develop.svn.wordpress.org/trunk@45164 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 02:26:44 +00:00
Sergey Biryukov dc3783a450 Docs: Add missing `@since` tags for `wp_targeted_link_rel()` and `wp_targeted_link_rel_callback()`.
See #43187, #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45163 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 21:15:29 +00:00
Sergey Biryukov 4de03a542e Networks and Sites: Use numbered placeholder in a `mailto:` link in `ms_site_check()`.
Props diddledan.
Fixes #46849.

git-svn-id: https://develop.svn.wordpress.org/trunk@45162 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 20:14:22 +00:00
Sergey Biryukov 428f9362eb Docs: Correct type for `WP_Object_Cache::$blog_prefix`.
Props diddledan.
Fixes #46851.

git-svn-id: https://develop.svn.wordpress.org/trunk@45161 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 20:09:09 +00:00
John Blackbourn dde307d4c9 Build/Test tools: Add some docs to the test functions.
Props andizer

Fixes #46501


git-svn-id: https://develop.svn.wordpress.org/trunk@45160 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 17:29:20 +00:00
John Blackbourn 98e942e10c General: Fix a typo in the docs for `_restore_wpautop_hook()`.
Props manzoorwani.jk

Fixes #46864


git-svn-id: https://develop.svn.wordpress.org/trunk@45159 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-11 17:26:03 +00:00
Andrea Fercia af0242a37b Accessibility: Improve the image "Alternative Text" field in the Edit Media screen.
Brings parity with the changes for the Media Views introduced in [44900].
- moves the alt text field to the top as first field
- adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
- adds `aria-describedby` to target the explanatory text
- adjusts the CSS and indentation

Props chetan200891.
Fixes #46875.


git-svn-id: https://develop.svn.wordpress.org/trunk@45158 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-10 19:59:16 +00:00
Andrea Fercia 36787a2716 Login and Registration: improve the CSS padding on the login input fields.
The right padding added in [44895] needs to be set only on the input fields in the Reset Password screen and exclude other login screens.

Amends [44895].
Fixes #42853.


git-svn-id: https://develop.svn.wordpress.org/trunk@45157 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-10 16:11:56 +00:00
Andrew Ozz d09af1698f Site health: Fix gathering the site data twice on non-English locales. Introduces two sets of data:
- More verbose set used to generate the admin page.
- More concise set that is copied when clicking the "Copy the site info" button intended mostly for support and developers.

Props xkon, azaozz.
Fixes #46726.

git-svn-id: https://develop.svn.wordpress.org/trunk@45156 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-10 05:06:54 +00:00
Jonathan Desrosiers 4428086e4c Site Health: Add missing i18n for “Copied!” string.
Props: Soean, mukesh27, davidbaumwald.
Fixes #46847.

git-svn-id: https://develop.svn.wordpress.org/trunk@45155 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 15:23:20 +00:00
Jonathan Desrosiers 7215374431 Privacy: Pass admin URLs for data export and erase forms through `esc_url()`.
Introduced in [45149].

Props: birgire.
Fixes #44047.

git-svn-id: https://develop.svn.wordpress.org/trunk@45154 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 14:06:29 +00:00
Gary Pendergast 632ad28223 Media: Remove an extra verb context missed in [45147].
Props garrett-eclipse.
See #44675.



git-svn-id: https://develop.svn.wordpress.org/trunk@45153 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 03:58:09 +00:00
Gary Pendergast 607bc079c3 Post WordPress 5.2 Beta version bump
git-svn-id: https://develop.svn.wordpress.org/trunk@45152 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 01:22:51 +00:00
Gary Pendergast 124cd857e9 WordPress 5.2 Beta 2
git-svn-id: https://develop.svn.wordpress.org/trunk@45151 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 01:12:00 +00:00
Gary Pendergast 8d7c644a7d UI: Remove vertical alignment from active primary buttons.
This caused the post-plugin installation actions to jump around when the "Activate Plugin" primary button became active.

Props seedsca, pratikthink, ianbelanger, mukesh27.
Fixes #44836.



git-svn-id: https://develop.svn.wordpress.org/trunk@45150 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 00:15:51 +00:00
Gary Pendergast 9802c065a4 Privacy: Add a missing `<form>` action on the Export/Erasure screens.
This lack of action could cause an expired nonce to end up in the URL.

Props garrett-eclipse, saimonh, xkon.
Fixes #44047.



git-svn-id: https://develop.svn.wordpress.org/trunk@45149 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 00:07:39 +00:00
Gary Pendergast 6dddce67fc Privacy: Only mark a personal data export as complete when the user downloads it.
An admin may download an export to check that it's all correct, but this action shouldn't mark the request as complete.

Props garrett-eclipse, JoshuaWold, birgire.
Fixes #44644.



git-svn-id: https://develop.svn.wordpress.org/trunk@45148 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-09 00:03:07 +00:00
Gary Pendergast 677c2a447b Media: Update the media bulk action labels for consistency.
Props ianbelanger, garrett-eclipse, afercia, Presskopp.
Fixes #44675.



git-svn-id: https://develop.svn.wordpress.org/trunk@45147 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:53:02 +00:00
Gary Pendergast 30679d4c83 Twenty Seventeeen: Fix MediaElement control hover colours in the customiser.
When selecting custom colour schemes in the customiser, the hover colour is incorrectly applied to MediaElement controls.

Props xkon, ianbelanger.
Fixes #40843.



git-svn-id: https://develop.svn.wordpress.org/trunk@45146 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:37:42 +00:00
Gary Pendergast 8eca6fd949 Site Health: Remove animated ellipsis from the status loading indicator.
This animation wasn't particularly reliable across browsers.

Props Clorith, afercia.
Fixes #46684.



git-svn-id: https://develop.svn.wordpress.org/trunk@45145 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:28:27 +00:00
Gary Pendergast cfebdd3752 Widgets: Add `rel="noopener noreferrer"` to links with `target="_blank"` in the Image widget.
Props audrasjb, welcher, afercia.
Fixes #43280.



git-svn-id: https://develop.svn.wordpress.org/trunk@45144 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:22:14 +00:00
Gary Pendergast 5dfdc9b9c4 Widgets: Add `rel="noopener noreferrer"` to links with `target="_blank"` in the Text and HTML widgets.
Props audrasjb, birgire, mukesh27.
Fixes #46421.



git-svn-id: https://develop.svn.wordpress.org/trunk@45143 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:17:35 +00:00
Gary Pendergast 0f75356246 Privacy: Remove the privacy changes bubble.
This notification was a little too intrustive, and suffered from being difficult to dismiss.

Props garrett-eclipse, xkon, ianbelanger.
Fixes #46819.



git-svn-id: https://develop.svn.wordpress.org/trunk@45142 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:11:36 +00:00
Gary Pendergast 466a7443a6 Menus: Add `rel="noopener"` to `target="_blank"` links by default in menus.
This expands upon `rel="noopener"` being previously added to links in the content.

Props audrasjb, welcher.
Fixes #43290.



git-svn-id: https://develop.svn.wordpress.org/trunk@45141 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 23:05:22 +00:00
Gary Pendergast 8efcc32fde Help: Update support forum links.
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790.



git-svn-id: https://develop.svn.wordpress.org/trunk@45140 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 22:58:49 +00:00
Gary Pendergast edd6a1f129 Blocks: Allow for nested `the_content` calls within `do_blocks()`.
When `do_blocks()` is run, it sets up some special handling of the `wpautop` filter, as we don't want `wpautop` to run on block content, but we do want it to be available for subsequent runs of `the_content`, which may be happening on non-block content.

As we set this up before rendering dynamic blocks, however, a dynamic block choosing to run `the_content` will cause unintentially structural deficiences in this particular recursive block tower.

Moving this handling to after dynamic blocks are rendered makes our tower lean a little less.

Props aldavigdis, pento.
Fixes #45495.



git-svn-id: https://develop.svn.wordpress.org/trunk@45139 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:53:14 +00:00
Gary Pendergast c9bb62507f Block Editor: Update packages to bring a selection of bugfixes in.
Props iseulde, kjellr, aduth, 0mirka00, mcsf, nosolosw, gziolo, jasmussen, talldanwp, notnownikki, swissspidy, jorgefilipecosta, noisysocks.
See https://github.com/WordPress/gutenberg/pull/14796.
Fixes #46801.



git-svn-id: https://develop.svn.wordpress.org/trunk@45138 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:36:33 +00:00
Gary Pendergast f1bef8668b Text Changes: Tweak the wording of email notification subjects.
This change brings more coherence between the subject lines of the various emails WordPress will send.

Props ramiy, pento.
Fixes #37940.


git-svn-id: https://develop.svn.wordpress.org/trunk@45137 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:16:41 +00:00
Gary Pendergast 95948eeed4 Post Formats: Remove the post format icons from the post list table.
Props mukesh27, melchoyce, karmatosed, afercia, mapk.
Fixes #46591.


git-svn-id: https://develop.svn.wordpress.org/trunk@45136 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 06:03:58 +00:00
Gary Pendergast 3652d05fcf HTTP: Add support for the `host-only` flag to `Wp_Http_Cookie`.
Props soulseekah.
Fixes #43231.


git-svn-id: https://develop.svn.wordpress.org/trunk@45135 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 05:31:35 +00:00
Gary Pendergast 11e97aae1e Emoji: Update Twemoji to version 12.0.0.
Props pento, superpoincare.
Fixes #46404, #46805.


git-svn-id: https://develop.svn.wordpress.org/trunk@45134 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 05:21:49 +00:00
Gary Pendergast 65e057daa2 Canonical: Ensure redirect query keys are URL encoded.
This prevents an infinite redirect loop when a request containing URL-encoded characters triggers `is_404()`.

Props soulseekah, wrwrwr0.
Fixes #43745.


git-svn-id: https://develop.svn.wordpress.org/trunk@45133 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-08 01:09:01 +00:00
Sergey Biryukov 639f038dae Twenty Nineteen: Fix inconsistent tab/space indentation in style files.
Props iamdmitrymayorov, mukesh27.
Fixes #46821.

git-svn-id: https://develop.svn.wordpress.org/trunk@45132 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 06:17:26 +00:00
Sergey Biryukov 965e7fa46e CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/color-picker.css`.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46492. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45131 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:53:37 +00:00
Sergey Biryukov 6ba1388522 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/about.css`.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45130 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:50:18 +00:00
Sergey Biryukov 1b69643969 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/customize-nav-menus.css`.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45129 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:48:05 +00:00
Sergey Biryukov 8c6239c27b CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/site-health.css`.
Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45128 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:43:12 +00:00
Sergey Biryukov 66e0c55818 Docs: Fix typo in a comment in `editor/dfw.js`.
Props garrett-eclipse, mattnyeus.
Fixes #46485.

git-svn-id: https://develop.svn.wordpress.org/trunk@45127 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:39:00 +00:00
Sergey Biryukov 60e5087b36 Bundled Themes: Link to an updated documentation on post thumbnails on developer.wordpress.org, instead of Codex.
Props samanehmirrajabi.
Fixes #46823.

git-svn-id: https://develop.svn.wordpress.org/trunk@45126 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-07 05:22:17 +00:00
John Blackbourn 8cd187c23a Bootstrap/Load: Ignore `wp-content/fatal-error-handler.php` and `wp-content/php-error.php` from version control.
See #44458


git-svn-id: https://develop.svn.wordpress.org/trunk@45125 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 18:42:26 +00:00
Sergey Biryukov 028e4098c7 Twenty Twelve: Correct `linear-gradient` direction argument syntax.
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, joyously, man4toman.
Fixes #46786.

git-svn-id: https://develop.svn.wordpress.org/trunk@45124 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:16:50 +00:00
Sergey Biryukov bd25bc4473 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/nav-menus.css`.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45123 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:09:42 +00:00
Sergey Biryukov 0f534cfe11 PHPCS: Fix WPCS violation in [45119].
See #46809.

git-svn-id: https://develop.svn.wordpress.org/trunk@45122 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 16:01:36 +00:00
Sergey Biryukov c8a29d2789 Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL.
Props Clorith, earnjam.
Fixes #46789.

git-svn-id: https://develop.svn.wordpress.org/trunk@45121 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-06 15:59:29 +00:00