Commit Graph

25642 Commits

Author SHA1 Message Date
Scott Taylor 8dad11bfe2 In `get_terms()`, don't set automatically `hierarchical` to `false` when `parent => 0` is passed. The default value for `parent` is `''`.
In `_get_term_children()`, don't skip a top-level term without first including its children in the returned term list. Ironically, the call to `_get_term_children()` in `get_terms()` has a comment stating `"Make sure we show empty categories that have children."`, but it didn't work if you were retrieving top-level categories only.

All unit tests pass. Added a unit test based on the use case described in this ticket.

Fixes #26903.



git-svn-id: https://develop.svn.wordpress.org/trunk@27108 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 17:44:50 +00:00
Helen Hou-Sandi c2e018dd0d Some tweaks to [27106]:
* Add more @todo markings and remove one that's been resolved.
* Restore a missing comma in a `.wp-badge` background rule, and add a comment reminding us why it's there.

see #18380.


git-svn-id: https://develop.svn.wordpress.org/trunk@27107 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 07:07:42 +00:00
Helen Hou-Sandi 802baab31a Merge colors.css into wp-admin.css. Non-default color schemes became overloads rather than swaps in the 3.8 redesign. Benefits include:
* No more border-width, border-style, border-color insanity.
* Point releases are much less likely to require extra finagling to avoid rebuilding the color schemes.
* Yours truly has a better overall vision of ~14,000 lines of admin CSS and where we go from here.

1,065 net lines of red, y'all.
props helen, jorbin. fixes #18380.


git-svn-id: https://develop.svn.wordpress.org/trunk@27106 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 06:24:36 +00:00
Andrew Nacin 7ff0442a07 JSHint fixes for media-views and Gruntfile.
props gcorne.
fixes #27032, #27033.


git-svn-id: https://develop.svn.wordpress.org/trunk@27105 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 05:31:22 +00:00
Scott Taylor 2127c9322d Move some cache related tests to the new `term/cache.php` from [27103].
git-svn-id: https://develop.svn.wordpress.org/trunk@27104 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 05:19:05 +00:00
Scott Taylor 324b2799b3 Add the unit test from #25711. The patch was unnecessary due to [27102], but the test is useful.
Props dd32.
See #25711.



git-svn-id: https://develop.svn.wordpress.org/trunk@27103 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 03:39:22 +00:00
Scott Taylor 50a96f165e Regenerate the term hierarchy cache (`{taxonomy}_children`) when it is out of sync with the passed taxonomy's `last_changed` value.
Introduces `taxonomy_hierarchy_is_fresh()`, which is only called in `_get_term_hierarchy()`. The taxonomy's `last_changed` value is checked against the value of `wp_cache_get( 'hierarchy_last_changed', $taxonomy )`.

Adds a unit test - `Tests_Term:test_hierachy_invalidation()`.

See [27101], which makes this type of cache invalidation possible.
Fixes #14485.



git-svn-id: https://develop.svn.wordpress.org/trunk@27102 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 01:58:01 +00:00
Scott Taylor e33ef0c6ac Add cache invalidation when updating a term, example: create a category, assign it to a post, edit the category. Currently, the post's term cache is not updated. When updating terms in a given taxonomy, invalidate the object term caches linked to that taxonomy.
Introduce `get_taxonomy_last_changed()`, `set_taxonomy_last_changed()`, and `post_taxonomy_is_fresh()`.

`post_taxonomy_is_fresh()` is only called in `get_object_term_cache()` - at which point the taxonomy's `last_changed` value is checked against the post's `{$taxonomy}_last_changed` value.

`set_taxonomy_last_changed()` is called whenever directory database queries are made that insert new terms or affect existing terms.

Fixes #22526.



git-svn-id: https://develop.svn.wordpress.org/trunk@27101 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 01:40:05 +00:00
Scott Taylor 9b85472ac9 The unit test for the video shortcode needs to mimic the default params for width and post ID.
See #26628.



git-svn-id: https://develop.svn.wordpress.org/trunk@27100 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 05:16:22 +00:00
Scott Taylor 22fef7cf4b Add a unit test demonstrating the failure to invalidate a post's term cache when the term is updated.
See #22526.



git-svn-id: https://develop.svn.wordpress.org/trunk@27099 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 03:49:48 +00:00
Andrew Ozz 5a3fb502cb TinyMCE: set the proper caption width when clicking image resize handle on image with caption. Props gcorne, fixes #27009, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27098 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 02:06:10 +00:00
wonderboymusic 71947f18d3 When a video shortcode has content in its body, append it as inner HTML in the resulting `<video>`.
Reverts [27096].
Fixes #26628.
See #27016.



git-svn-id: https://develop.svn.wordpress.org/trunk@27097 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 01:42:02 +00:00
Scott Taylor 3ccf9e9d29 The video shortcode unit test shouldn't be expected to maintain HTML comments.
See #26864.



git-svn-id: https://develop.svn.wordpress.org/trunk@27096 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 01:24:58 +00:00
Andrew Ozz 89b8edf8f1 TinyMCE: don't scroll the main window when scrolling the editor content with a mouse wheel or trackpad and reaching the end. Fixes #27013.
git-svn-id: https://develop.svn.wordpress.org/trunk@27095 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 01:09:42 +00:00
Andrew Ozz 6a0251847b Consolidate handling of <object>, <audio> and <video> in wpautop() and add unit tests for them. Part props wonderboymusic, see #26864
git-svn-id: https://develop.svn.wordpress.org/trunk@27094 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 00:45:53 +00:00
Andrew Ozz b33135c08d When using wp_editor(), make it easier to specify which editor is shown first, fixes #20822
git-svn-id: https://develop.svn.wordpress.org/trunk@27093 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-05 00:33:49 +00:00
Andrew Nacin 6aaad4785a Autosave: Fix typo in event namespace. props avryl, see #25272.
git-svn-id: https://develop.svn.wordpress.org/trunk@27092 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 16:06:13 +00:00
Andrew Nacin 2f013a3706 Default themes: Use the 'display' filter for get_bloginfo( 'name' ) attached to the wp_title filter.
props michelwppi.
fixes #26811.


git-svn-id: https://develop.svn.wordpress.org/trunk@27091 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 13:56:49 +00:00
Drew Jaynes d88b191c9a Inline documentation for hooks in wp-admin/includes/class-wp-ms-themes-list-table.php.
Also marks two hooks in wp-admin/includes/class-wp-themes-list-table.php as duplicates.

Props ShinichiN, kpdesign, DrewAPicture.
Fixes #25608.


git-svn-id: https://develop.svn.wordpress.org/trunk@27090 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 08:24:13 +00:00
Drew Jaynes 75d5d14049 Inline documentation for hooks in wp-admin/includes/class-wp-terms-list-table.php.
Props Ajay, kpdesign.
Fixes #26209.


git-svn-id: https://develop.svn.wordpress.org/trunk@27089 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 07:55:48 +00:00
DrewAPicture ac4774ddbd Inline documentation for hooks in wp-admin/network/sites.php.
Props NikV, kpdesign.
Fixes #26124.


git-svn-id: https://develop.svn.wordpress.org/trunk@27088 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 07:48:03 +00:00
Scott Taylor 050e4f26e9 Invalidate the post cache for posts associated with a user who has been removed from a blog in `remove_user_from_blog()`. Adds a unit test.
Props nprasath002 for the initial patch.
Fixes #25545.



git-svn-id: https://develop.svn.wordpress.org/trunk@27087 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-04 04:12:52 +00:00
Andrew Nacin e07424147c Test suite: Trim queries before deciding whether to create temporary tables.
props jdgrimes.
fixes #24800.


git-svn-id: https://develop.svn.wordpress.org/trunk@27086 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 22:39:47 +00:00
Andrew Ozz 840423ea10 Minor cleanup (jshint) of wp-fullscreen.js and /wordpress/plugin.js, see #24067
git-svn-id: https://develop.svn.wordpress.org/trunk@27085 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 21:30:25 +00:00
Andrew Ozz 5ff41a8635 Add back missing var definition in wplink.js, props TobiasBg, see #24067
git-svn-id: https://develop.svn.wordpress.org/trunk@27084 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 21:26:39 +00:00
Andrew Ozz c24e451ae3 TinyMCE: don't replace <i> with <em> and <b> with <strong> and don't remove them when empty, see #24067, see #23037.
git-svn-id: https://develop.svn.wordpress.org/trunk@27083 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 20:25:08 +00:00
Sergey Biryukov 0d8921de03 Add braces around conditionals. props TobiasBg. fixes #25704.
git-svn-id: https://develop.svn.wordpress.org/trunk@27082 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 20:16:08 +00:00
Scott Taylor 28bab15d16 Properly invalidate the cache for `wp_count_posts()` on insert, trash, or when transitioning `post_status` inside of `_transition_post_status()`. Introduces `_count_posts_cache_key()`. Adds unit tests.
Props mark8barnes, for bringing this to our attention in an initial patch.
Fixes #21879.



git-svn-id: https://develop.svn.wordpress.org/trunk@27081 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 19:41:40 +00:00
Andrew Ozz 9fd8c54ef9 Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854.
git-svn-id: https://develop.svn.wordpress.org/trunk@27080 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 05:30:12 +00:00
Andrew Ozz 33b079b036 Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233.
git-svn-id: https://develop.svn.wordpress.org/trunk@27079 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 23:49:05 +00:00
Andrew Ozz 90662a17f4 Editor: add :focus style for the Quicktags buttons, fixes #26932
git-svn-id: https://develop.svn.wordpress.org/trunk@27078 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:37:37 +00:00
Andrew Nacin 8c3ad4e860 Consistently trim and unslash search queries for the users list tables.
props aubreypwd.
fixes #26115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27077 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:09:19 +00:00
Andrew Nacin ed1ece6e3b Remove an unnecessary variable passed to wpdb::prepare() during multisite load.
props jeremyfelt.
fixes #26941.


git-svn-id: https://develop.svn.wordpress.org/trunk@27076 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:08:14 +00:00
Andrew Nacin 194d6a94b7 When the MySQL server has "gone away," attempt to reconnect and retry the query.
props pento.
see #5932.


git-svn-id: https://develop.svn.wordpress.org/trunk@27075 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 22:06:42 +00:00
Andrew Nacin e993ef0249 Add a comment for [27073] as someone will inevitably complain it is tricked by % in a string. see #25604.
git-svn-id: https://develop.svn.wordpress.org/trunk@27074 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 21:47:58 +00:00
Andrew Nacin 435df55864 Throw an incorrect usage notice when the query argument of wpdb::prepare() does not include a placeholder.
props ounziw.
fixes #25604.


git-svn-id: https://develop.svn.wordpress.org/trunk@27073 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 21:46:07 +00:00
Andrew Nacin 0558df56ce Ensure compatibility with MySQL 5.6 which has stricter SQL modes by default.
Disables NO_ZERO_DATE, ONLY_FULL_GROUP_BY, STRICT_TRANS_TABLES, STRICT_ALL_TABLES, TRADITIONAL. Introduces wpdb::set_sql_mode() with an incompatible_sql_modes filter so a plugin can alter the set mode after the fact.

props pento.
fixes #26847.


git-svn-id: https://develop.svn.wordpress.org/trunk@27072 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 21:38:34 +00:00
Andrew Ozz bb49691c63 WP_Link: convert < > and " to HTML entities when setting link title for the Text editor. Fixes #25704.
git-svn-id: https://develop.svn.wordpress.org/trunk@27071 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 21:11:24 +00:00
Dominik Schilling (ocean90) d58d7e8158 Update @return statement of wp_nonce_url(): The URL is escaped.
props c3mdigital.
see #4221.

git-svn-id: https://develop.svn.wordpress.org/trunk@27070 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 10:52:33 +00:00
Andrew Nacin 8650155a8b Use get_current_user_id() instead of $user_ID in user-edit.php.
props kovshenin.
fixes #26274.


git-svn-id: https://develop.svn.wordpress.org/trunk@27069 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 10:03:12 +00:00
Andrew Nacin 509cd20ae4 New resetpass_form hook in wp-login.php.
props romaimperator.
fixes #21044.


git-svn-id: https://develop.svn.wordpress.org/trunk@27068 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 07:51:03 +00:00
Scott Taylor b8e7bbb0f2 Fix an error in SQL generation when `perm` is set and an array is passed for `post_status`. Adds unit test.
Props oso96_2000.
Fixes #25523.



git-svn-id: https://develop.svn.wordpress.org/trunk@27067 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 07:35:54 +00:00
Andrew Nacin d1cc542e1f Ensure the last separator is removed from the user and network admin menus.
props johnjamesjacoby.
fixes #25425.


git-svn-id: https://develop.svn.wordpress.org/trunk@27066 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 06:18:44 +00:00
Andrew Nacin 71f951f71e Add arguments to the wp_dropdown_cats filter, and docs.
props olivM.
fixes #24103.


git-svn-id: https://develop.svn.wordpress.org/trunk@27065 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-02 05:32:17 +00:00
Scott Taylor a1ffaec8b4 Remove `$force` argument from `WP_Object_Cache::delete()`. From @nacin: "This was for internal-use-only, I don't think _deprecated_argument() is needed, but let's put a comment somewhere just so we know we'd have to be careful if we ever want to add a third argument here later."
`$force` argument has been removed, and docs were updated.

Fixes #22478.



git-svn-id: https://develop.svn.wordpress.org/trunk@27064 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-01 22:24:30 +00:00
Scott Taylor 684091ac57 Let the video shortcode accept a YouTube URL as the value of its `src` attribute, as MediaElement.js supports Chromeless YouTube videos by using a pseudo-mime-type `video/youtube`.
HTTP and HTTPS www, non-www, and short url fronts are supported:
http://www.youtube.com/watch 
https://www.youtube.com/watch
http://youtube.com/watch
https://youtube.com/watch
http://youtu.be
https://youtu.be

Fixes #24764.



git-svn-id: https://develop.svn.wordpress.org/trunk@27063 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-31 18:58:25 +00:00
Andrew Ozz 01da73ac78 TinyMCE: update to 4.0.16, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27062 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-31 18:57:45 +00:00
Andrew Nacin ec20c47e12 Update Dashicons to latest. Adds line break, paragraph, code, and bbPress.
props empireoflight, melchoyce.
see #26936.


git-svn-id: https://develop.svn.wordpress.org/trunk@27061 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-31 00:40:05 +00:00
Andrew Ozz ced0079d88 TinyMCE: update to 4.0.14. Remove the fix for using init.setup in old plugins, now fixed upstream. See #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27060 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-31 00:05:17 +00:00
Scott Taylor 6989d828bb Upgrade MediaElement to 2.13.2 from 2.13.0. For a full list of changes: https://github.com/johndyer/mediaelement/compare/2.13.0...2.13.2
Fixes #26954.



git-svn-id: https://develop.svn.wordpress.org/trunk@27059 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-29 18:23:59 +00:00