Commit Graph

30688 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
e430245d00 Customizer: Accessibility enhancements.
* Move tabindex/focus code into `onChangeExpanded` so that it works for cases where `expand()` is called directly.
* Use `visibility: hidden` to hide hidden elements from keyboard focus and screen readers.

props celloexpressions.
fixes #31336.

git-svn-id: https://develop.svn.wordpress.org/trunk@33069 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:18:17 +00:00
Konstantin Obenland
1757c3f4d4 Don't let wp-pointers cover the theme detail modal.
Fixes #31544.


git-svn-id: https://develop.svn.wordpress.org/trunk@33068 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 17:04:33 +00:00
Konstantin Obenland
8d40cdcb1b Use a less element-specific class name for links within page titles.
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@33067 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 16:41:18 +00:00
Konstantin Obenland
04a01d7354 Check if commentReply exists before trying to work with it.
Fixes a bug that caused the save/publish flow to be interrupted by an AYS.

Introduced in [33024].
See #29457.



git-svn-id: https://develop.svn.wordpress.org/trunk@33066 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 15:31:38 +00:00
Aaron Jorbin
3baf370b28 Remove accidental change to embed
Reverts about.php change from [33064]




git-svn-id: https://develop.svn.wordpress.org/trunk@33065 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 14:29:37 +00:00
Aaron Jorbin
a547d6fed1 Don't strip newline in esc_url() when protocol is mailto:
The mailto protocol is a bit different than the other protocols in that new lines are something you might realistically want to include. Includes tests to make sure that http protocol urls that contain mailto: aren't affected. Tests for stripping newlines in general already exist.

Fixes #31632
Props danielbachhuber



git-svn-id: https://develop.svn.wordpress.org/trunk@33064 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 14:27:11 +00:00
Dion Hulse
12168b78d5 Press This: Rewrite WP_Press_This::fetch_source_html() to utilise the HTTP API better without the need for a local temporary file.
This reverts [33061] but keeps it's custom UA string.

See #32864


git-svn-id: https://develop.svn.wordpress.org/trunk@33062 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 12:00:10 +00:00
Sergey Biryukov
9cfb72615c Press This: Set explicit user agent.
props kraftbj.
fixes #32864.

git-svn-id: https://develop.svn.wordpress.org/trunk@33061 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 11:16:08 +00:00
Ella Iseulde Van Dorpe
220121249a Editor: refresh word count quicker
2 seconds is a bit slow. Debouncing with 1 second means it can only run maximum once per second. In reality it won't run us much. Even people who type slow will usually type faster than 1 character per second.

See #30966.



git-svn-id: https://develop.svn.wordpress.org/trunk@33060 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 09:14:08 +00:00
Dion Hulse
2fbb13be21 Don't upgrade global tables to utf8mb4 when wp_should_upgrade_global_tables() says not to.
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.

See #32154


git-svn-id: https://develop.svn.wordpress.org/trunk@33058 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 05:43:28 +00:00
Dion Hulse
947825f326 Introduce wp_should_upgrade_global_tables() to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines.
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33057 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 04:33:14 +00:00
Helen Hou-Sandi
e7a184a832 Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.


git-svn-id: https://develop.svn.wordpress.org/trunk@33056 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 03:28:15 +00:00
Dion Hulse
e709e91218 Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally.
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33055 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 03:25:07 +00:00
Konstantin Obenland
bfbdb6f0b2 Use get_default_comment_status() globally.
Also makes the filter name static and passes the post type for context.

Props valendesigns.
Fixes #31168.



git-svn-id: https://develop.svn.wordpress.org/trunk@33054 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 22:31:58 +00:00
Konstantin Obenland
9532df3c9f Site Icon: Improve responsiveness for small screen devices.
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.

Props tyxla for initial patch.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@33053 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 21:15:52 +00:00
Sergey Biryukov
07ee7f1ef7 Replace @returns with @return in PHP docblocks.
props kraftbj.
fixes #32865.

git-svn-id: https://develop.svn.wordpress.org/trunk@33052 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 21:04:57 +00:00
Konstantin Obenland
3d71278f58 Site Icon: Skip cropping if image has the correct size.
Props jipmoors for initial patch.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@33051 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 20:39:23 +00:00
Konstantin Obenland
40b504fffc Add missing prefixed attributes, introduced in [33023].
See ##32589.


git-svn-id: https://develop.svn.wordpress.org/trunk@33050 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 17:39:31 +00:00
Konstantin Obenland
8f4774104b Site Icon: Show correct background preview for transparent images.
iOS will show transparent parts as black, where as the icon itself stays
transparent when used as a favicon.

See #16434.


git-svn-id: https://develop.svn.wordpress.org/trunk@33049 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 17:15:47 +00:00
Sergey Biryukov
f8cbb8fde8 Make "Preformatted" string in TinyMCE translatable.
props iseulde.
fixes #32862.

git-svn-id: https://develop.svn.wordpress.org/trunk@33048 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 12:01:00 +00:00
Sergey Biryukov
dcc6fb838f Restore rel='nofollow' for comment reply links to reduce extra crawling by search engines.
This reverts [16230], which didn't have enough review at the time of commit.

props joostdevalk.
see #22889, #18547, #16881.

git-svn-id: https://develop.svn.wordpress.org/trunk@33047 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 11:08:42 +00:00
Konstantin Obenland
5c531b9969 4.3-beta1-33046
git-svn-id: https://develop.svn.wordpress.org/trunk@33046 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:35:01 +00:00
Helen Hou-Sandi
b896a4e31b Customizer: Build flips the panel arrow for RTL on our behalf.
see #31336.


git-svn-id: https://develop.svn.wordpress.org/trunk@33045 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:28:43 +00:00
Konstantin Obenland
83f8f62739 4.3-beta1
git-svn-id: https://develop.svn.wordpress.org/trunk@33044 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:21:05 +00:00
Sergey Biryukov
8a8fc13bd0 Update test_filter_wp_nav_menu_args() after [33035].
see #32781.

git-svn-id: https://develop.svn.wordpress.org/trunk@33043 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:17:58 +00:00
Mark Jaquith
fcd4f3ea0f Revert [33038] because of objections raised on #22889 and #31590
git-svn-id: https://develop.svn.wordpress.org/trunk@33042 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 00:46:28 +00:00
Konstantin Obenland
efdce1da51 Turn of comments for pages by default.
Pages are static content, for which comments are not expected out of the box.

Props valendesigns, rachelbaker.
Fixes #31168.



git-svn-id: https://develop.svn.wordpress.org/trunk@33041 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 00:21:28 +00:00
Konstantin Obenland
dd28f15179 Prevent link to customizer from wrpping on small screens.
Fixes #32808.


git-svn-id: https://develop.svn.wordpress.org/trunk@33040 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 23:35:57 +00:00
Mark Jaquith
165b3fccaa Restore $noreplytext default value in comment_form_title()
props ocean90
see #22889

git-svn-id: https://develop.svn.wordpress.org/trunk@33039 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 21:50:13 +00:00
Mark Jaquith
bac0e68b48 Say goodbye to ?replytocom=123 links and their URL pollution.
* Comment reply links continue to use JS as before.
* ?replytocom=123 links are deprecated.

props joostdevalk
fixes #22889

git-svn-id: https://develop.svn.wordpress.org/trunk@33038 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 21:41:17 +00:00
Dominik Schilling (ocean90)
d0728bf768 Site icon: Remove option name from $whitelist_options for the general options screen.
The option gets saved in `WP_Site_Icon->set_site_icon()`.

fixes #32859.

git-svn-id: https://develop.svn.wordpress.org/trunk@33037 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 21:40:40 +00:00
Weston Ruter
552879c842 Customizer: Add link to Widgets panel from Menus panel description.
Props celloexpressions.
Fixes #32742.



git-svn-id: https://develop.svn.wordpress.org/trunk@33036 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 19:34:17 +00:00
Sergey Biryukov
2ef2ac5e93 Customizer: Avoid PHP notices after [32806].
props adamsilverstein, westonruter.
fixes #32781.

git-svn-id: https://develop.svn.wordpress.org/trunk@33035 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 19:07:20 +00:00
Mark Jaquith
ef9f9c1a24 Fix small typo from [33019].
see #32429

git-svn-id: https://develop.svn.wordpress.org/trunk@33034 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 18:15:42 +00:00
Mark Jaquith
a288fe93f3 Slow down on calling zxcvbn if it isn't loaded.
see #32589

git-svn-id: https://develop.svn.wordpress.org/trunk@33033 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 18:12:04 +00:00
Konstantin Obenland
3bda728420 Add additional escaping to credits page.
Props Viper007Bond, gtuk for initial patch.
Fixes #21523.



git-svn-id: https://develop.svn.wordpress.org/trunk@33032 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 17:21:55 +00:00
Mark Jaquith
82150c08f2 Add a missing "var". see #32589
git-svn-id: https://develop.svn.wordpress.org/trunk@33031 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 17:15:43 +00:00
Dominik Schilling (ocean90)
d1bedc6769 Customizer: Make reordering menu items via drag and drop easier.
Introduce `wpNavMenu.options.targetTolerance` to define a tolerance when dragging items where no margins between the sortable items exists.

props adamsilverstein.
fixes #32821.

git-svn-id: https://develop.svn.wordpress.org/trunk@33030 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 16:43:02 +00:00
Jeremy Felt
568721eef1 Trim trailing space from string in site delete confirmation
Props yoavf.
Fixes #32853.


git-svn-id: https://develop.svn.wordpress.org/trunk@33029 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 16:30:34 +00:00
Dominik Schilling (ocean90)
54cd46c1d0 Customizer: Fix height calculation of placeholders when dragging menu items.
props adamsilverstein.
fixes #32857.

git-svn-id: https://develop.svn.wordpress.org/trunk@33028 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 16:19:51 +00:00
Dominik Schilling (ocean90)
caab22e5b2 l10n: Update wp_get_installed_translations() to support variants of a language.
* A variant of a language has its own locale, for example the locale of the formal variant of German is `de_DE_formal`.
* Update `remove_accents()` and some CSS rules to support `de_DE_formal`.
* Add tests for `get_bloginfo( 'language' )`.
* API changes will be deployed over the next few days.

see #28303.

git-svn-id: https://develop.svn.wordpress.org/trunk@33027 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 15:42:32 +00:00
Konstantin Obenland
b32cf591c2 Improve the tone of key/salts recommendation message.
Also adds some inline comments to make it easier to understand how it
is determined whether to show the message or not.

Props helen.
Fixes #20779.



git-svn-id: https://develop.svn.wordpress.org/trunk@33026 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 15:38:09 +00:00
Scott Taylor
f8841653ef wp_audio|video_shortcode() doesn't allow you to pass id, the docs shall reflect that.
Props thorbrink.
See #32855.


git-svn-id: https://develop.svn.wordpress.org/trunk@33025 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 15:00:54 +00:00
Konstantin Obenland
238d5a78a6 Close comment quick edit before updating a post.
Fixes a bug where the user gets redirected to the All Posts screen, after
updating a post while quick editing a comment.

Props polevaultweb.
Fixes #29457.



git-svn-id: https://develop.svn.wordpress.org/trunk@33024 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 14:53:48 +00:00
Mark Jaquith
cc23659078 New password change/set UI.
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords

see #32589

props MikeHansenMe, adamsilverstein, binarykitten

git-svn-id: https://develop.svn.wordpress.org/trunk@33023 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 14:47:24 +00:00
Boone Gorges
f7b8ff5a2e Don't allow $field param to be passed to get_term_link().
The new parameter creates inconsistencies in the signatures of the various
functions for fetching term links (`get_term_feed_link()`,
`get_edit_term_link()`, etc.).

Reverts [32553].

See #14156.

git-svn-id: https://develop.svn.wordpress.org/trunk@33022 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 12:53:05 +00:00
Boone Gorges
e8a16ec322 Allow 'comment_agent' and 'comment_author_IP' to be set via wp_new_comment().
Props mrutz, wonderboymusic, rachelbaker.
Fixes #14601.

git-svn-id: https://develop.svn.wordpress.org/trunk@33021 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 12:07:28 +00:00
Dion Hulse
1cccb02930 Split upgrade_430() into two so that split_all_shared_terms() runs when upgrade_430_fix_comments() bails early.
See [32814], #30261, [32364], #32165


git-svn-id: https://develop.svn.wordpress.org/trunk@33020 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 07:34:26 +00:00
Dion Hulse
5b58664439 Expire password reset links after 24 hours (by default). This causes existing password reset links to become invalid.
Props markjaquith, voldemortensen, johnbillion, MikeHansenMe, dd32
See #32429


git-svn-id: https://develop.svn.wordpress.org/trunk@33019 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 06:32:07 +00:00
Konstantin Obenland
b04ea26df1 After [32866], change filter name.
While filter names generally don't have to be tied to the function in which they 
are applied, the API for media display generally seems to use the
`wp_get_attachment_*` pattern.

Props DrewAPicture.
Fixes #32363.



git-svn-id: https://develop.svn.wordpress.org/trunk@33018 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 03:46:23 +00:00