183 Commits

Author SHA1 Message Date
Sergey Biryukov
00bfc5bc34 Avoid PHP notices in media modal caused by orphaned attachments.
fixes #29566 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29724 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 10:02:36 +00:00
Sergey Biryukov
7ce9d697c6 Don't display Edit links for attachments user cannot edit.
props skaeser.
fixes #29596 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29723 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 09:49:55 +00:00
Sergey Biryukov
8cfdbf1167 Use https for apps.wordpress.org links.
props pento.
fixes #29595 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29721 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-09 06:28:33 +00:00
Andrew Nacin
f3b999f9c4 Media grid details: Load large images instead of originals, if available.
fixes #29498.


git-svn-id: https://develop.svn.wordpress.org/trunk@29704 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-04 14:37:05 +00:00
Andrew Nacin
84681ddd39 Link to apps.wordpress.org instead of wordpress.org/mobile.
props pento.
fixes #29496.


git-svn-id: https://develop.svn.wordpress.org/trunk@29703 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-04 14:21:13 +00:00
Andrew Nacin
0fdd75b585 Only media grid (not modal) should show "Uploaded by" and "Uploaded to".
props wonderboymusic.
fixes #29482.


git-svn-id: https://develop.svn.wordpress.org/trunk@29683 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-03 02:16:32 +00:00
Andrew Ozz
f1fe507032 Media modal: fix the progress bar in the attachment thumbnail. Props gcorne, fixes #29367
git-svn-id: https://develop.svn.wordpress.org/trunk@29609 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-25 22:44:32 +00:00
Sergey Biryukov
1422cab58c Don't display an empty "Uploaded To" link in the media modal after [29436].
see #28844.

git-svn-id: https://develop.svn.wordpress.org/trunk@29537 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-19 07:23:46 +00:00
Dominik Schilling (ocean90)
7cbb35a84e Media Modal: Restore to the previous filter and search error message.
fixes #28963.

git-svn-id: https://develop.svn.wordpress.org/trunk@29532 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 16:27:33 +00:00
Scott Taylor
8691d31bdc Media Modal: don't show the "Edit Image" button for attachments that don't have data.sizes set.
Fixes #28038.


git-svn-id: https://develop.svn.wordpress.org/trunk@29529 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 02:41:46 +00:00
Scott Taylor
e67f53149d Media Grid: don't try to display images that don't have data.sizes set. Also, don't show the "Edit Image" button.
Props ocean90.
Fixes #29245.


git-svn-id: https://develop.svn.wordpress.org/trunk@29528 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 02:34:03 +00:00
Helen Hou-Sandi
ce45b90525 Small screen responsive for attachment details modal. see #28844.
git-svn-id: https://develop.svn.wordpress.org/trunk@29496 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 04:09:58 +00:00
Scott Taylor
7308949ea3 Media Grid, support MEDIA_TRASH:
* Only use the special `trashAttachment` logic when in `edit-metadata` mode.
* Don't support the `trash` filter in the Add Media modal for now.
* Properly toggle trash/untrash logic in the Attachment Details sidebar

See #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29491 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 18:50:04 +00:00
Scott Taylor
8661fcf0d9 Media Grid, support MEDIA_TRASH:
* Add a setting to `_wpMediaViewsL10n.settings`: `mediaTrash`
* In the attachment edit modal, properly toggle between Trash/Untrash
* In `media.view.Attachment`, add a method for `untrashAttachment`
* When creating the grid toolbar, switch the setting order of subviews so that `media.view.DeleteSelectedButton` can listen to the instance of `media.view.AttachmentFilters.All` to update the text in its UI.
* Add a new filter to `media.view.AttachmentFilters.All`, `trash`, when `settings.mediaTrash` is true
* Allow the cached queries in `Query.get()` to be flushed when race conditions exist and collections need to be refreshed. This is currently only being used when `MEDIA_TRASH` is set, to refresh the filtered/mirrored collections related to `all`, `trash`, and any already queried filter.
* Cleanup the bootstrapping of `media.view.MediaFrame.Manage`
* Allow `wp_ajax_query_attachments()` to return items from the trash when `MEDIA_TRASH` is `true`
* Allow `wp_ajax_save_attachment()` to set `post_status` when `MEDIA_TRASH` is `true`. It allows `wp_delete_post()` to be called, which will trash the attachment instead of deleting when the flag is set.

Props koop for the knowledge sharing and thought partnership.
See #29145.


git-svn-id: https://develop.svn.wordpress.org/trunk@29490 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-14 18:30:49 +00:00
Scott Taylor
e23c1ae3ff Upgrade MediaElement to 2.15.0:
* It is required to set `height` on the parent `.wp-video` wrapper for video
* Fixes the play button hover problem in Chrome
* Includes my pull request: https://github.com/johndyer/mediaelement/pull/1273

All changes:
https://github.com/johndyer/mediaelement/compare/2.14.2...master

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29457 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 20:43:25 +00:00
Scott Taylor
45368dbfaa Video:
* Don't set height on responsive `<div>` when generating markup
* Move some CSS rules from the style tag to `.wp-video`
* Use Video Details view event delegation instead of click events delegated from `<body>`
* Fix some CSS rule collision in the grid modal

See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29456 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:38:40 +00:00
Helen Hou-Sandi
3d4ebded2f Revert styling changes to the Attachment Details modal from [29289]. fixes #28844.
git-svn-id: https://develop.svn.wordpress.org/trunk@29436 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 20:31:21 +00:00
Scott Taylor
7f000f2fdd Video: use auto instead of actual height for the responsive wrapper in generated markup.
See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29430 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 06:19:29 +00:00
wonderboymusic
0b7342e906 MediaElement upgrade: cleanup for generated markup for videos.
See #29110.


git-svn-id: https://develop.svn.wordpress.org/trunk@29429 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 05:52:03 +00:00
Scott Taylor
e25dc36c2b Media Grid: after [28996], use the same cover size for audio/video files that images use for thumbnails.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29416 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 19:32:51 +00:00
Andrew Ozz
e5836da88d Media modal/grid: remove thumbnail resizing from JS, only keep setting number of columns. Props avryl, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29376 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 05:19:09 +00:00
Andrew Ozz
98c3058d32 Media modal: use the same classes to hide the "or" that is above the "Select files" button when no drag-drop support. See #28851.
git-svn-id: https://develop.svn.wordpress.org/trunk@29373 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 21:16:37 +00:00
Dominik Schilling (ocean90)
c53e3036ad Media Modal: Restore uploader view, when no items are found.
see #28963.

git-svn-id: https://develop.svn.wordpress.org/trunk@29364 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:46:36 +00:00
Sergey Biryukov
e2d9939e57 Avoid PHP notices in Media Library if an attachment parent post type no longer exists.
Synchronize the 'edit_post' capability check between the list table and the media grid.

fixes #27446.

git-svn-id: https://develop.svn.wordpress.org/trunk@29320 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 01:40:24 +00:00
Dominik Schilling (ocean90)
0480144f86 Media Grid: Add context for "or" in [29296].
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29303 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 14:36:56 +00:00
Scott Taylor
3fef7648f6 Media Grid: improve uploader styles.
Props michalzuber, ericlewis.
See #28851.


git-svn-id: https://develop.svn.wordpress.org/trunk@29296 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:30:28 +00:00
Scott Taylor
276496aa29 Media Grid: change text to "Close Media Panel" to provide context for screen readers.
Props joedolson.
Fixes #28976.


git-svn-id: https://develop.svn.wordpress.org/trunk@29295 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:25:16 +00:00
Scott Taylor
cdf2c8132c Media Grid: UI improvements to Attachment modal.
Props ryelle.
See #28844.


git-svn-id: https://develop.svn.wordpress.org/trunk@29289 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:54:22 +00:00
Scott Taylor
dd76aeea5b Media Grid: remove pencil icon from attachment hover and a bunch of unused CSS.
Fixes #28945.


git-svn-id: https://develop.svn.wordpress.org/trunk@29288 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:17:32 +00:00
Scott Taylor
530328ef59 The Underscore templates for Gallery settings should respect defaults when marking an <option> as selected.
See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@29283 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 19:34:53 +00:00
Helen Hou-Sandi
2fd45b514b Set default values for attachment meta and ID3 data when preparing for JS to avoid errors in rendering templates. props ericmann for the initial patch. fixes #29013.
git-svn-id: https://develop.svn.wordpress.org/trunk@29281 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 18:03:58 +00:00
Helen Hou-Sandi
5698a9dc7e Media Grid: Remove fields from showing in the grid itself.
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29280 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 05:25:28 +00:00
Helen Hou-Sandi
3d3b141b30 Add support for attachment_fields_to_edit in the attachment details modal. props ericlewis. fixes #28991, see #24716.
git-svn-id: https://develop.svn.wordpress.org/trunk@29278 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 22:08:17 +00:00
Scott Taylor
80c4d6a96c Media Grid: general JS cleanup.
Props ericlewis.
See #28965.



git-svn-id: https://develop.svn.wordpress.org/trunk@29266 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 16:20:59 +00:00
Helen Hou-Sandi
25b733cea2 Move the "view" link for attachment details to the sidebar and use more specific language. Removes an unnecessary JS handler. fixes #28977.
git-svn-id: https://develop.svn.wordpress.org/trunk@29263 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 02:19:21 +00:00
Sergey Biryukov
f171b362a9 Media Grid: Add a View button to Attachment Details modal.
props adamsilverstein.
fixes #28977.

git-svn-id: https://develop.svn.wordpress.org/trunk@29262 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 01:29:17 +00:00
Helen Hou-Sandi
e391aa228a Media Grid:
Instead of a separate bulk selection mode, persistently show a checkbox for each item. Restores the more familiar bulk actions dropdown + action button.

props ericlewis. see #28842.



git-svn-id: https://develop.svn.wordpress.org/trunk@29212 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 20:41:40 +00:00
Scott Taylor
5e1556a4ce After [29106], check for data.meta before attempting to render data.meta.bitrate.
See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29208 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 17:41:06 +00:00
Helen Hou-Sandi
fdabfafa0f Media Grid Attachment Details modal UI improvements:
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.

Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.

props ericlewis, helen, melchoyce. see #28844. fixes #28915.


git-svn-id: https://develop.svn.wordpress.org/trunk@29204 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 03:54:44 +00:00
Scott Taylor
cba1ae06af Simplify creation of audio, video, and playlist MCE views by placing them in iframe sandboxes.
Wins:
* Eliminates duplication of code between PHP and JS
* Views can load JS without messing with TinyMCE and scope
* MEjs doesn't break when it loads a file plugin-mode. This allows any file type the MEjs supports to play in MCE views.
* YouTube now works as the source for video.
* Users can still style the views, editor stylesheets are included in these sandboxes.
* Audio and Video URLs and `[embed]`s are no longer broken.
* Remove the crazy compat code necessary to determine what file types play in what browser.
* Remove unneeded Underscore templates.
* Remove the compat code for playlists.

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29179 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:17:58 +00:00
Dominik Schilling (ocean90)
33db0d4ff2 Lists View Switcher: Replace blank image with screen reader text.
props davidakennedy.
fixes #28871.

git-svn-id: https://develop.svn.wordpress.org/trunk@29133 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 11:04:21 +00:00
Scott Taylor
8dddb7334f Media Grid, for audio files: show Bitrate in the Edit Attachments modal a la the Edit Post screen.
See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29106 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 21:55:24 +00:00
Scott Taylor
16a70197ed In the Post/Select frames, for audio files:
* Show `artist` and `album` fields in the Attachment Details sidebar
* Sync their values on `change`

See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29105 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 21:01:08 +00:00
Scott Taylor
d1f4b3a800 Media Grid, for audio files:
* Show `artist` and `album` fields in the Edit Attachment modal
* Sync their values on `change`

See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29104 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 20:54:13 +00:00
Scott Taylor
0f50df6cbd Media Grid, in the Edit Attachment modal:
* Label the fields under the attachment a la the Edit Media page
* Move the audio and video previews above the info
* Remove the audio / video icon display. Unnecessary.
* Ensure that `width` and `max-width` are set for `.mejs-container`

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29088 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 06:14:31 +00:00
Scott Taylor
e52c72c366 Media Grid:
* The "Edit Image" link in the attachment modal details is redundant.
* After an attachment is deleted in the modal, automatically move to the next attachment in the library. If there are no attachments left, close the modal.

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29085 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 05:21:04 +00:00
Scott Taylor
ba7b26d37e Media Grid: make the Uploader closable.
Props ericlewis.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29082 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 23:05:05 +00:00
Scott Taylor
d5cbf00457 Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29078 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 21:25:49 +00:00
Scott Taylor
3ebde0c4d6 Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29077 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 20:59:12 +00:00
Scott Taylor
868d88800c Media Grid: make the edit attachment icon clickable.
Props ericlewis.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29065 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 15:55:21 +00:00