Commit Graph

3738 Commits

Author SHA1 Message Date
Sergey Biryukov 359fe16c9c Fix alignment of Advanced Options close toggle arrow in Edit Media dialog.
props paulwilde.
fixes #28752.

git-svn-id: https://develop.svn.wordpress.org/trunk@29001 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 23:37:48 +00:00
Sergey Biryukov c10391dcbe Fix a regression of positioning in Attachment Display Settings.
props paulwilde.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@29000 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 23:28:40 +00:00
Sergey Biryukov fbda6f7c0a Add is_customize_preview(), a conditional function to check if the site is being previewed in the Customizer.
props sammybeats, mattwiebe.
fixes #23509.

git-svn-id: https://develop.svn.wordpress.org/trunk@28999 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 16:16:46 +00:00
Scott Taylor d075028201 Media Grid: JSHint fixes.
See #24716. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28998 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 05:13:46 +00:00
Scott Taylor 7438b91f6f Media Grid: Use the proper attachment value for `uploadedToTitle`.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28997 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 05:03:06 +00:00
wonderboymusic 9ba94b5c58 Media Grid: for audio and video files with covers, show that instead of the icon. The filename is still present with the extension to identify the type.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28996 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 04:59:01 +00:00
Scott Taylor ee29246036 Make media grid text fields (data) toggle-able. Checking/unchecking is saved in user settings cookie.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28995 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 04:47:40 +00:00
Andrew Ozz fdb58455f6 TinyMCE: improve the way wpViews work. Add two paragraphs and capture the caret in them on clicking before/after/left/right of a view or moving the caret with the arrow keys, then show a "fake" caret.
This makes it much more "natural" to move the caret with the arrow keys and to add paragraphs before a view when it is the first element or after a view when it's last.

Props avryl, see #28595.

git-svn-id: https://develop.svn.wordpress.org/trunk@28994 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 03:58:20 +00:00
Helen Hou-Sandi e14d866665 Media grid, round 2. Expect much more to come.
* Instead of a sidebar for details, utilize a modal. The modal experience allows for a larger preview, editing images, audio/video previews, and previous/next navigation, like the theme browser. Think of it as an attachment browser.
* Show some details in the grid view to more easily distinguish items.

props ericlewis, wonderboymusic, JerrySarcastic. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28993 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 03:38:33 +00:00
Scott Taylor 9c314d1d00 Make a new file: `media-grid.js`. This will be way more useful in later commits and help reduce churn and bloat in `media-views.js`.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28992 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 02:17:22 +00:00
Scott Taylor b67b45aaa2 The MCE view for galleries needs to read `wp.media.galleryDefaults.columns` after [28990].
See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@28991 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 02:05:22 +00:00
Scott Taylor 038dc75b66 Allow users to override default gallery settings in JS via `wp_localize_script()`. This is already possible in PHP by filtering `shortcode_atts_gallery`.
Fixes #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@28990 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 02:02:16 +00:00
Scott Taylor f262fef790 Add more docs for `media.view.MediaFrame.Select` methods.
Props ericlewis.
See #28459.


git-svn-id: https://develop.svn.wordpress.org/trunk@28989 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:42:27 +00:00
Scott Taylor f8b878f8da `WP_Query::parse_tax_query()` has always been documented as `protected`. Plugins should never have used it. However, it did not have a `protected` access modifier, so its visibility was `public` by default. If the access modifier had been present, accessing the method in a plugin would have produced a fatal error. The access modifier was added in [28523], along with magic methods to allow it to be accessed for BC. This one method is problematic because it expects to be passed a reference. The `WP_Query::__call()` logic does not go out of its way to fix this signature discrepancy, and so a warning is thrown: `Parameter 1 to WP_Query::parse_tax_query() expected to be a reference, value given`.
Remove the `protected` access modifier from `WP_Query::parse_tax_query()`.

Fixes #28739.


git-svn-id: https://develop.svn.wordpress.org/trunk@28987 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:28:02 +00:00
Scott Taylor 4e8afc6caa Optimize regexp usage in `wptexturize()` for a "3x Performance Boost."
Props miqrogroove.
See #28724.


git-svn-id: https://develop.svn.wordpress.org/trunk@28986 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:14:08 +00:00
Scott Taylor 4b58f47a5c Add IE11 to the browser whitelist for MediaElement-based MCE views.
Props azaozz.
Fixes #28742.


git-svn-id: https://develop.svn.wordpress.org/trunk@28985 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-04 01:09:25 +00:00
John Blackbourn 4e3b729b09 If we already have a value for WPLANG when installing, insert this language at the top of the language selector and pre-select it. See #28577
git-svn-id: https://develop.svn.wordpress.org/trunk@28984 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 22:55:57 +00:00
John Blackbourn db8b7380b2 First pass at switching to radio inputs for the install screen language selector. Needs some more work. See #28577. Props jorbin
git-svn-id: https://develop.svn.wordpress.org/trunk@28983 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 22:53:01 +00:00
John Blackbourn 35578f8f9a Avoid a warning if the translations API call fails on step 1. Remove assignment inside an if statement. See #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@28982 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 22:30:27 +00:00
Helen Hou-Sandi 71704c1156 Remove a toolbar CSS hack for a Chrome bug that no longer appears to exist. props avryl. fixes #28606. see #18868.
git-svn-id: https://develop.svn.wordpress.org/trunk@28981 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:19:08 +00:00
Helen Hou-Sandi 6d8c6d8728 Don't escape customizer control descriptions, just as section descriptions are not escaped. These are set programmatically, not via user input. props tollmanz. fixes #27981.
git-svn-id: https://develop.svn.wordpress.org/trunk@28980 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:10:29 +00:00
Drew Jaynes (DrewAPicture) 79dd39c19c Note in the hook docs for `preview_post_link` that the `$post` parameter was added.
See #28729.


git-svn-id: https://develop.svn.wordpress.org/trunk@28979 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:04:56 +00:00
Andrew Nacin a7c3b23f1c Simplify the setup-config.php UI flow and load process.
When no configuration file is detected, we now redirect to setup-config.php. This process now uses the WordPress bootstrap, rather than a set of fragile hacks.

fixes #28740.


git-svn-id: https://develop.svn.wordpress.org/trunk@28978 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:56:37 +00:00
Drew Jaynes (DrewAPicture) 26e262f93d Clarify the inline documentation for `plugins_url()` to reflect that it also works with mu-plugins.
Props ericlewis.
See #28499.


git-svn-id: https://develop.svn.wordpress.org/trunk@28977 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:41:23 +00:00
Drew Jaynes (DrewAPicture) b1b454c7a0 Remove backticks on `$post` variables in some short parameter descriptions.
See [28653], [28654].
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28976 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:27:54 +00:00
Drew Jaynes (DrewAPicture) 7ffc91fdd6 Fix an incomplete docblock for `wp_create_categories()` as part of `$post/$post_id` cleanup.
See #28388.


git-svn-id: https://develop.svn.wordpress.org/trunk@28975 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 19:21:34 +00:00
John Blackbourn c18a28f792 Use the admin scheme for theme preview URLs when installing new themes. See #21919.
git-svn-id: https://develop.svn.wordpress.org/trunk@28974 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 18:47:33 +00:00
John Blackbourn 14bfade4ec Correct typo in `sanitize_html_class()` docblock.
git-svn-id: https://develop.svn.wordpress.org/trunk@28973 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:57:17 +00:00
Helen Hou-Sandi 3adcda996b Improve oEmbed caching. Introduces the concept of a TTL for oEmbed caches and a filter for `oembed_ttl`.
We will no longer replace previously valid oEmbed responses with an `{{unknown}}` cache value. When this happens due to reaching a rate limit or a service going down, it is data loss, and is not acceptable. This means that oEmbed caches for a post are no longer deleted indiscriminately every time that post is saved.

oEmbed continues to be cached in post meta, with the addition of a separate meta key containing the timestamp of the last retrieval, which is used to avoid re-requesting a recently cached oEmbed response. By default, we consider a valued cached in the past day to be fresh. This can greatly reduce the number of outbound requests, especially in cases where a post containing multiple embeds is saved frequently.

The TTL used to determine whether or not to request a response can be filtered using `oembed_ttl`, thus allowing for the possibility of respecting the optional oEmbed response parameter `cache_age` or altering the period of time a cached value is considered to be fresh.

Now that oEmbeds are previewed in the visual editor as well as the media modal, oEmbed caches are often populated before a post is saved or published. By pre-populating and avoiding having to re-request that response, we also greatly reduce the chances of a stampede happening when a published post is visible before oEmbed caching is complete.

As it previously stood, a stampede was extremely likely to happen, as the AJAX caching was only triggered when `$_GET['message']` was 1. The published message is 6. We now trigger the caching every time `$_GET['message']` is present on the edit screen, as we are able to avoid triggering so many HTTP requests overall.

props markjaquith. fixes #14759. see #17210.


git-svn-id: https://develop.svn.wordpress.org/trunk@28972 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:44:15 +00:00
Sergey Biryukov ff3644a220 Fix texturization of quotes when enclosed by angle brackets.
props miqrogroove.
fixes #28718.

git-svn-id: https://develop.svn.wordpress.org/trunk@28971 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:21:18 +00:00
Sergey Biryukov 09efb2dab9 Prevent sending a 404 status when returning the response for the customize preview, since it causes the jQuery Ajax to fail. Send 200 instead.
props westonruter.
fixes #27992.

git-svn-id: https://develop.svn.wordpress.org/trunk@28970 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 16:10:01 +00:00
Sergey Biryukov 8bf7ed77f3 Pass $post object to 'preview_post_link' filter.
props danielbachhuber.
fixes #28729.

git-svn-id: https://develop.svn.wordpress.org/trunk@28969 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 14:41:06 +00:00
John Blackbourn 53f98b80b7 Prepend "Draft:" to draft post titles when previewing on the front end, and add a "single-status-$status" class to the body classes for all post statuses. Fixes #28006. Props hlashbrooke
git-svn-id: https://develop.svn.wordpress.org/trunk@28963 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 22:52:31 +00:00
Sergey Biryukov 4a480146c0 Avoing a PHP warning in media modal if the attached file does not exist.
props kovshenin.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@28959 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 14:36:29 +00:00
Sergey Biryukov ec0e2beebb Canonical redirects should only be applied for GET requests.
props c.axelsson.
fixes #27498.

git-svn-id: https://develop.svn.wordpress.org/trunk@28958 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 14:10:07 +00:00
SergeyBiryukov 57029ef3fb Make default 'template' argument of the_taxonomies() and get_the_taxonomies() translatable.
props juliobox.
fixes #28714.

git-svn-id: https://develop.svn.wordpress.org/trunk@28957 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 13:20:02 +00:00
Sergey Biryukov 8ee9631bb4 Remove non-breaking spaces from auto update email text.
props trepmal.
fixes #28715.

git-svn-id: https://develop.svn.wordpress.org/trunk@28956 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 12:45:31 +00:00
Drew Jaynes (DrewAPicture) 2d9bba0a5c Specify the `$single` parameter default for `get_post_meta()`. Docs spacing.
See #28708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28955 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:29:33 +00:00
Sergey Biryukov 65106eff1f Mark $single parameter of get_post_meta() as optional.
props netweb.
fixes #28708.

git-svn-id: https://develop.svn.wordpress.org/trunk@28954 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 03:25:28 +00:00
Drew Jaynes (DrewAPicture) 8e2098d706 Fix parameter description for `$append` in `wp_set_object_terms()` inline docs.
See #26570.


git-svn-id: https://develop.svn.wordpress.org/trunk@28952 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 01:38:22 +00:00
Sergey Biryukov 2ce93f915d Clarify the docs and add more unit tests for wp_set_object_terms().
props DrewAPicture.
fixes #26570.

git-svn-id: https://develop.svn.wordpress.org/trunk@28951 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 01:27:07 +00:00
Drew Jaynes (DrewAPicture) c6b8bae1e8 Remove duplicate of the 'oembed_providers' filter accidentally introduced in [28949].
Move annoted table of oEmbed providers into the existing filter docs.

See #28507.
Fixes #28372. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28950 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:33:11 +00:00
Drew Jaynes (DrewAPicture) 0f20132801 Introduce an annotated list of oEmbed providers, their flavors, whether they support SSL, and when they were added to the `oembed_providers` filter docs.
See #28507.
Fixes #28372.


git-svn-id: https://develop.svn.wordpress.org/trunk@28949 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:18:12 +00:00
Sergey Biryukov 0d2817bf9e Simplify a condition in get_sample_permalink_html().
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28948 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:10:13 +00:00
Sergey Biryukov 3fe0336a63 Simplify logic in get_sample_permalink_html(), remove duplicated code.
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28947 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-02 00:03:53 +00:00
Sergey Biryukov 7a8bedaf2a Display a correct preview link for drafts when permalinks are disabled.
see #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28946 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 23:55:58 +00:00
Sergey Biryukov 339a0e87b7 Use correct variable.
props azaozz.
see #24472.

git-svn-id: https://develop.svn.wordpress.org/trunk@28945 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 23:29:03 +00:00
Sergey Biryukov 44f1a76a85 Add a filter for wp_editor() settings.
props DH-Shredder, JPry, DrewAPicture.
fixes #24472.

git-svn-id: https://develop.svn.wordpress.org/trunk@28944 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 23:02:58 +00:00
Sergey Biryukov 99d75b6acb Make wp_kses_no_null() remove any invalid control characters in a string.
props mauteri, miqrogroove.
fixes #28506.

git-svn-id: https://develop.svn.wordpress.org/trunk@28942 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 18:00:50 +00:00
Sergey Biryukov d6b9a469fe Twenty Fourteen: Fix display of center-aligned images with captions in TinyMCE.
props RDall.
fixes #28048.

git-svn-id: https://develop.svn.wordpress.org/trunk@28941 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 16:40:30 +00:00
Helen Hou-Sandi c6c89eed8a Only apply metabox handle styles and JS events to `.postbox .hndle`, as opposed to all `h3`s in a `.postbox`.
Developers previously relying on the `h3` behavior may be affected. You may want to investigate `do_meta_boxes()` rather than recreating markup.

props SergeyBiryukov, nabil_kadimi.
fixes #28485.


git-svn-id: https://develop.svn.wordpress.org/trunk@28940 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 16:22:32 +00:00
Sergey Biryukov 92a7523362 Asterisk is an allowed character in a URI and should not be stripped out by wp_sanitize_redirect().
fixes #28362.

git-svn-id: https://develop.svn.wordpress.org/trunk@28939 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 15:55:04 +00:00
Sergey Biryukov ef5e962cfb Add @since for get_translations_for_domain().
props DrewAPicture.
see #28690.

git-svn-id: https://develop.svn.wordpress.org/trunk@28938 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 15:28:55 +00:00
Sergey Biryukov fd4ad167b2 Some fixes for get_weekstartend() docs.
see #26185.

git-svn-id: https://develop.svn.wordpress.org/trunk@28937 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 14:58:37 +00:00
Drew Jaynes (DrewAPicture) ecb39eaccb General inline documentation improvements in wp-includes/functions.php.
Second run. See #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28936 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 01:43:48 +00:00
Sergey Biryukov 8b0ef058f3 WP_Date_Query: The inclusive logic should include all times within the date range.
props mboynes, oso96_2000, DrewAPicture.
fixes #26653.

git-svn-id: https://develop.svn.wordpress.org/trunk@28935 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-01 01:17:39 +00:00
Sergey Biryukov 416e5bcb96 Move ms-load.php and ms-default-constants.php inclusion back to ms-settings.php to avoid breaking WP-CLI.
Use require_once() to allow for ms-settings.php to be included multiple times while testing.

props jeremyfelt.
see #27884.

git-svn-id: https://develop.svn.wordpress.org/trunk@28934 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 23:49:34 +00:00
Sergey Biryukov 4114ff052f Remove free-spacing modifier and extra spaces from wp_extract_urls() pattern.
fixes #28222.

git-svn-id: https://develop.svn.wordpress.org/trunk@28933 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 23:08:48 +00:00
Andrew Ozz df6434b9a7 TinyMCE:
- Update the 'paste' plugin including cb36a78e54
- Better filtering of WebKit inserted &nbsp.
- Remove empty paragraphs and all inline styles on pasting but preserve styles added in the editor. This brings back the WP 3.8 behavior and makes pasting in all browsers work the same.
See #28016

git-svn-id: https://develop.svn.wordpress.org/trunk@28932 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 21:54:20 +00:00
Dominik Schilling (ocean90) 5aeaa14d9a Customizer: Reverse arrows in RTL. See #27406.
props yoavf.
fixes #28669.

git-svn-id: https://develop.svn.wordpress.org/trunk@28931 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 19:59:51 +00:00
Dominik Schilling (ocean90) 6f51a5f972 Customizer: Support `textarea` and commonly-used input types as control type in `WP_Customize_Control`.
Add `input_attrs` property to support custom input attributes.

(Demo plugin attached to ticket.)

props celloexpressions.
fixes #28477.

git-svn-id: https://develop.svn.wordpress.org/trunk@28930 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 19:47:56 +00:00
Scott Taylor 01441b8c05 Remove obsolete comment in `wptexturize()`.
http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-06-30&sort=asc#m879104

See [28831].


git-svn-id: https://develop.svn.wordpress.org/trunk@28929 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 17:58:14 +00:00
Sergey Biryukov 4e56aa8da0 Replace a redundant ! is_preview() check with a more appropriate one.
fixes #20496.

git-svn-id: https://develop.svn.wordpress.org/trunk@28928 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 17:18:23 +00:00
Helen Hou-Sandi 4f7bc0410f Support descriptions for individual customizer controls.
* Control title (label) markup will also only be output if specified.
* Control section descriptions are no longer italicized for visual hierarchy / differentiation.

props celloexpressions. fixes #27981.


git-svn-id: https://develop.svn.wordpress.org/trunk@28927 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 15:54:04 +00:00
Sergey Biryukov 5235448195 Avoid overwriting $error global with an interim variable.
props MikeLittle.
fixes #28691.

git-svn-id: https://develop.svn.wordpress.org/trunk@28925 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 14:38:21 +00:00
Sergey Biryukov 04429059b0 Document @return value for load_plugin_textdomain(). props jdgrimes.
Document $path parameter for load_child_theme_textdomain().

fixes #28690.

git-svn-id: https://develop.svn.wordpress.org/trunk@28924 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 13:51:11 +00:00
Sergey Biryukov 4176aa347e Pass $url parameter to wp_embed_defaults() and 'embed_defaults' filter.
props wpsmith, sabreuse, jacobdubail.
fixes #20151.

git-svn-id: https://develop.svn.wordpress.org/trunk@28923 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 11:15:33 +00:00
Sergey Biryukov 0b9fb4f148 Avoid a PHP notice in wp_new_comment() if user ID is not passed.
see #23231.

git-svn-id: https://develop.svn.wordpress.org/trunk@28922 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 11:02:10 +00:00
Sergey Biryukov 1d38109297 Force a separator in get_wp_title_rss() if it was inadvertently filtered out by the theme.
fixes #22362.

git-svn-id: https://develop.svn.wordpress.org/trunk@28921 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 10:10:57 +00:00
Sergey Biryukov 913392b9a9 Display consistent preview links for drafts.
props mordauk.
fixes #28350.

git-svn-id: https://develop.svn.wordpress.org/trunk@28920 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 10:02:01 +00:00
Andrew Ozz df6eb733eb Secure embeds in the editor (first run):
- When the user pastes an embeddable http URL, try to get the https embed.
- If an embed provider doesn't support ssl embeds, show a placeholder/error message.
- Revise the way we return error messages.
See #28195, #28507.

git-svn-id: https://develop.svn.wordpress.org/trunk@28919 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 05:48:16 +00:00
Drew Jaynes (DrewAPicture) 99faddd819 General inline documentation improvements in wp-includes/functions.php.
First run. See #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28918 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 03:55:03 +00:00
Drew Jaynes (DrewAPicture) 0c8b5722d2 Improve inline documentation for `date_i18n()`, `_http_build_query()`, `wp_checkdate()`, and `wp_auth_check()`.
Props morganestes.
See #26185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28917 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 03:46:22 +00:00
Sergey Biryukov 29aabd08a9 Prevent bulk actions from being performed when Filter button is clicked.
props jesin.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28916 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 01:09:25 +00:00
Sergey Biryukov 7584b25252 Normalize 'user_id' and 'user_ID' values in wp_new_comment() before passing the comment data to 'preprocess_comment' filter.
props dkotter.
fixes #23231.

git-svn-id: https://develop.svn.wordpress.org/trunk@28915 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 00:40:51 +00:00
Scott Taylor 923becb506 Revert [28911] for performance concerns.
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28914 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 23:42:45 +00:00
Scott Taylor 11da6abc57 Allow comments in the trash to marked as spam.
Props mordauk.
Fixes #19256.


git-svn-id: https://develop.svn.wordpress.org/trunk@28913 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 23:18:24 +00:00
Scott Taylor be32c3485a Add a function, `get_comments_number_text()`, that returns instead of echoing. `comments_number()` wraps it.
Props kapeels, nbachiyski.
Fixes #10177.


git-svn-id: https://develop.svn.wordpress.org/trunk@28912 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 23:12:34 +00:00
Scott Taylor 9cc39e7f46 Use `includes_url( ..., 'relative' )` in `script-loader.php` in lieu of hard-coding `/wp-includes/....` everywhere.
Fixes #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28911 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:55:39 +00:00
Andrew Nacin 9e24832a0e Add initial unit tests for multisite's bootstrap.
props jeremyfelt.
fixes #27884.


git-svn-id: https://develop.svn.wordpress.org/trunk@28910 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:50:44 +00:00
Drew Jaynes (DrewAPicture) 75ff222c93 Convert documentation of default arguments in `wp_list_authors()` to the hash-notation style.
Props Viper007Bond.
Fixes #28684.


git-svn-id: https://develop.svn.wordpress.org/trunk@28909 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:33:46 +00:00
Scott Taylor 0b1a0b39fd Use `includes_url()` in `wlwmanifest_link()`.
Props nacin.
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28908 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:26:59 +00:00
Scott Taylor 0a3e448168 `WP_Scripts->in_default_dir()` should use the `WPINC` constant
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28907 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:22:16 +00:00
Scott Taylor d204e4dea0 Admin screens should use the `WPINC` constant
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28906 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:20:26 +00:00
Scott Taylor acd2a45cc2 `wlwmanifest_link()` should use the `WPINC` constant
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28905 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:16:52 +00:00
Scott Taylor 48c145ee78 `WP_Filesystem_Base->abspath()` should use the `WPINC` constant
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28904 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:15:10 +00:00
Scott Taylor dcd7ff837d Use the `WPINC` constant when loading `class-phpass.php`
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28903 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:11:44 +00:00
Sergey Biryukov 00678ab0df Notify developers when register_post_type() or register_taxonomy() fails because of post type or taxonomy key length.
props mattheweppelsheimer.
fixes #28683.

git-svn-id: https://develop.svn.wordpress.org/trunk@28902 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 21:53:35 +00:00
Drew Jaynes (DrewAPicture) 978f3df40f Add documentation for the default playlist shortcode attributes in `wp_playlist_shortcode()`.
Props taylorde.
Fixes #28678.


git-svn-id: https://develop.svn.wordpress.org/trunk@28901 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 21:28:54 +00:00
Andrew Nacin 02094174f9 Add index key support for wp_list_pluck(), à la array_column().
props trepmal.
fixes #28666.


git-svn-id: https://develop.svn.wordpress.org/trunk@28900 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 21:25:21 +00:00
Drew Jaynes (DrewAPicture) 1388b15b67 Re-document default arguments in `wp_link_pages()` using the hash-notation style.
Props taylorde.
Fixes #28680.


git-svn-id: https://develop.svn.wordpress.org/trunk@28899 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 18:55:45 +00:00
Sergey Biryukov 1e7b12978c Set date format before going into the loop to avoid a PHP notice if 'lastupdated' column is filtered out.
props jeremyfelt.
fixes #27614.

git-svn-id: https://develop.svn.wordpress.org/trunk@28898 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 18:10:52 +00:00
Sergey Biryukov 107001213b Fix feature pointer positioning issues for both LTR and RTL.
fixes #28062.

git-svn-id: https://develop.svn.wordpress.org/trunk@28897 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 16:05:53 +00:00
John Blackbourn db4da6e488 Remove the WordPress logo from the focusable elements on the install/update screens. Fixes #28674. Props stompweb
git-svn-id: https://develop.svn.wordpress.org/trunk@28896 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 14:09:39 +00:00
John Blackbourn 15e019d99e Conditionally set the the `secure` flag on the test cookie, post password cookie, settings cookies, and comment author cookies depending on whether the front end and/or admin area are served over `https`. Fixes #28427
git-svn-id: https://develop.svn.wordpress.org/trunk@28895 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 13:24:55 +00:00
John Blackbourn 3c77cf1140 Introduce `is_https_url()` for testing whether the scheme for a given URL is `https`. See #28487.
git-svn-id: https://develop.svn.wordpress.org/trunk@28894 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 11:31:25 +00:00
John Blackbourn 3426416dac Normalise the schemes used in `get_home_path()` so it returns the correct path for sites using SSL in the admin area but not the front end. Fixes #25767. Props GregLone for the initial patch.
git-svn-id: https://develop.svn.wordpress.org/trunk@28893 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 10:28:52 +00:00
John Blackbourn 075be3e54b Introduce a filter to control the minimum characters required for an AJAX term search. Fixes #13580. Props iamfriendly, brianlayman
git-svn-id: https://develop.svn.wordpress.org/trunk@28892 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 10:04:05 +00:00
Drew Jaynes (DrewAPicture) 416f6d01b2 General phpDoc fixes in wp-includes/plugin.php.
See #28516.


git-svn-id: https://develop.svn.wordpress.org/trunk@28891 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 09:18:41 +00:00
Sergey Biryukov 08969ece9e Show a "No themes found" message if the search for an installed theme doesn't produce any results.
props gauravmittal1995 for initial patch.
fixes #28587.

git-svn-id: https://develop.svn.wordpress.org/trunk@28890 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 09:15:08 +00:00
Sergey Biryukov 665e2c3ce0 List the expected @param type first.
see #28516.

git-svn-id: https://develop.svn.wordpress.org/trunk@28889 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 08:46:33 +00:00
Sergey Biryukov fd6ece2e93 More tweaks to @param docs in wp-includes/plugin.php.
see #28516.

git-svn-id: https://develop.svn.wordpress.org/trunk@28888 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 08:41:38 +00:00
Drew Jaynes (DrewAPicture) 6e7e9f07ab First-run documention of `WP_Query` argument defaults.
Props siobhan for some language tweaks. Props DrewAPicture.
See #25367.


git-svn-id: https://develop.svn.wordpress.org/trunk@28887 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 23:02:05 +00:00
Scott Taylor faedd0d5fe Update `@param` docs in `plugin.php`
Props dkotter.
Fixes #28516.


git-svn-id: https://develop.svn.wordpress.org/trunk@28886 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:49:39 +00:00
Scott Taylor 2d56abdd2e Add new action 'delete_user_form' in `wp-admin/users.php` and `wp-admin/network/users.php`.
Props SergeyBiryukov, usermrpapa.
Fixes #27230.


git-svn-id: https://develop.svn.wordpress.org/trunk@28885 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:42:24 +00:00
Scott Taylor 79b2bb391c After [28883], `remove_filter()` should set `$GLOBALS['wp_filter'][ $tag ]` to `array()` when empty.
Props wonderboymusic, sphoid.
Fixes #28142.


git-svn-id: https://develop.svn.wordpress.org/trunk@28884 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:37:47 +00:00
Scott Taylor d88a14ee67 `remove_all_filters()` should set to `array()`, not call `unset()`.
Props nacin, c3mdigital.
Fixes #19306.


git-svn-id: https://develop.svn.wordpress.org/trunk@28883 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:26:49 +00:00
Scott Taylor 56e66c79b4 `wp_extract_urls()` should not match dates.
Updates unit tests.

Props hinnerk, sergej.mueller.
Fixes #28222.


git-svn-id: https://develop.svn.wordpress.org/trunk@28882 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:15:30 +00:00
Scott Taylor dca6040b0b In multisite, on the `updated_option` action, if the option name is one of: 'blogname', 'siteurl', 'post_count' - refresh the blog details cache for the current blog id.
Adds unit test.

Props kovshenin.
Fixes #26410.


git-svn-id: https://develop.svn.wordpress.org/trunk@28881 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:06:12 +00:00
Scott Taylor 54d4f34ad2 If the `get_the_excerpt()` is called out of bounds of a global `$post`, return ''.
Fixes #22413.


git-svn-id: https://develop.svn.wordpress.org/trunk@28880 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 04:00:27 +00:00
Scott Taylor c2b7f8022c Add `->get_quality()` method to `WP_Image_Editor` class.
Adds unit tests.

Props markoheijnen.
Fixes #28154.


git-svn-id: https://develop.svn.wordpress.org/trunk@28879 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 03:49:55 +00:00
Sergey Biryukov 34ed4c44f5 Fix typo in a comment.
props JustinSainton.
see #20496.

git-svn-id: https://develop.svn.wordpress.org/trunk@28878 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 03:29:10 +00:00
Scott Taylor 7debe46f3e Fix the spacing between the wp-pointer arrow and bubble in LTR and RTL.
Fixes #28062.



git-svn-id: https://develop.svn.wordpress.org/trunk@28877 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:25:40 +00:00
Helen Hou-Sandi 9becde117d Make the posts list table mode a sticky user setting. props garyc40, azaozz, ericmann. fixes #16774, #20335.
git-svn-id: https://develop.svn.wordpress.org/trunk@28876 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:16:59 +00:00
Scott Taylor cf67d53408 Remove obsolete `wp_cache_delete('get_pages', 'posts')` from `clean_post_cache()`.
Fixes #27459.


git-svn-id: https://develop.svn.wordpress.org/trunk@28875 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:15:45 +00:00
Scott Taylor e8f2862421 Perform a canonical redirect for posts that are published but are visited at a `?p=123&preview=true` URL.
Props amit, joostdevalk.
Fixes #20496.


git-svn-id: https://develop.svn.wordpress.org/trunk@28874 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:12:19 +00:00
Scott Taylor 572e27c682 Remove remaining Heartbeat API experimental notices
Props DH-Shredder.
Fixes #28626.


git-svn-id: https://develop.svn.wordpress.org/trunk@28872 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-28 02:05:54 +00:00
Scott Taylor 2371f75688 In deprecated media iframe code, `attachment_fields_to_save` filter should not be called twice after initial image upload in post.
Props SergeyBiryukov.
Fixes #20720.


git-svn-id: https://develop.svn.wordpress.org/trunk@28871 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 21:31:28 +00:00
Scott Taylor 119add95d9 Remove title attributes in `wp_authenticate_username_password()`.
Props joedolson.
Fixes #26547.


git-svn-id: https://develop.svn.wordpress.org/trunk@28870 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 20:04:52 +00:00
Helen Hou-Sandi c27492cf26 Don't switch contextual help tabs when tabbing around. props neil_pie. see #28209.
git-svn-id: https://develop.svn.wordpress.org/trunk@28869 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 19:09:17 +00:00
Sergey Biryukov d2d985ffeb Avoid duplication of callbacks in theme browser sidebar each time the Next or Previous button is clicked.
This makes the collapse/expand button work as expected.

fixes #28581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28868 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 16:05:07 +00:00
Sergey Biryukov 0ff197f471 Correct filter documentation in wp_nav_menu().
props dlh.
fixes #28657.

git-svn-id: https://develop.svn.wordpress.org/trunk@28867 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 03:36:05 +00:00
Andrew Ozz 9dfcd4030c TinyMCE: force 'font-weight: bold` for <strong> and <b> inside the editor or Chrome and Safari may replace them with spans on pasting. Fixes #28656.
git-svn-id: https://develop.svn.wordpress.org/trunk@28866 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 02:59:13 +00:00
Sergey Biryukov b864d0955e Avoid a PHP notice and warning on language selection screen.
props meekyhwang.
fixes #28648.

git-svn-id: https://develop.svn.wordpress.org/trunk@28865 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 00:24:36 +00:00
Sergey Biryukov f68d096c31 Make sure the first number in LIMIT clause in WP_Query::get_posts() is always an integer.
fixes #23383.

git-svn-id: https://develop.svn.wordpress.org/trunk@28864 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-27 00:03:05 +00:00
Scott Taylor ce8a35edd1 Make sure the audio player's time tooltip is visible in the media modal for Audio Details.
Fixes #28453.



git-svn-id: https://develop.svn.wordpress.org/trunk@28863 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 20:28:12 +00:00
Dominik Schilling (ocean90) 7edd9edde4 Customizer: Introduce a "panel" API to organize multiple sections into a one section.
Create a panel via `$GLOBALS['wp_customize']->add_panel( $panel_id, $args )` and use `$panel_id` for the `panel` argument in `$GLOBALS['wp_customize']->add_section( $section_id, $args )`. That's it.
As an example all widget area sections are now summarized into one panel. Feedback appreciated.

props celloexpressions.
see #27406.

git-svn-id: https://develop.svn.wordpress.org/trunk@28861 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 20:16:21 +00:00
Scott Taylor 782bd3ee67 Do not touch `absint()`. Reverts [28855].
git-svn-id: https://develop.svn.wordpress.org/trunk@28858 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 18:44:45 +00:00
Scott Taylor 8ec1723e03 Revert [28856] at nacin's behest. See #23383.
git-svn-id: https://develop.svn.wordpress.org/trunk@28857 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 18:33:50 +00:00
Scott Taylor ce6de601e3 `absint()` should always return `PHP_INT_MAX` if the resulting value exceeds it.
See [28855].
Fixes #23383.


git-svn-id: https://develop.svn.wordpress.org/trunk@28856 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 18:23:51 +00:00
Scott Taylor df04529010 Add a second optional parameter to `absint()` to limit the result to `PHP_INT_MAX`.
See #23383.


git-svn-id: https://develop.svn.wordpress.org/trunk@28855 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 17:51:52 +00:00
Sergey Biryukov 146bcaa937 XML-RPC: Make sure wp.newPost does not produce a fatal error when a post_date field is included in the data.
props dllh.
fixes #28601.

git-svn-id: https://develop.svn.wordpress.org/trunk@28854 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 17:42:17 +00:00
Scott Taylor 8103dc5ade Use less greedy regex in `wptexturize()`. Adds unit tests.
Props miqrogroove.
See #28564.


git-svn-id: https://develop.svn.wordpress.org/trunk@28852 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 17:14:47 +00:00
Sergey Biryukov 3513f37623 Fix unexpected replacement of a previous tag when selecting a tag from autosuggest results.
props camdensegal.
fixes #28471.

git-svn-id: https://develop.svn.wordpress.org/trunk@28851 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 16:07:36 +00:00
Helen Hou-Sandi 2187cc6f98 Slightly bump up the login logo size to avoid getting chopped off by Firefox's rounding problems. props SergeyBiryukov for the initial patch. fixes #28393.
git-svn-id: https://develop.svn.wordpress.org/trunk@28850 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 15:35:19 +00:00
Sergey Biryukov 772903e5e9 XML-RPC: Add wp.deleteMediaItem as an alias to wp_deletePost.
props fahmiadib.
fixes #5310.

git-svn-id: https://develop.svn.wordpress.org/trunk@28849 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 15:20:07 +00:00
Sergey Biryukov 7fa39e6839 Replace Y/m/d date format in general settings with a more popular one, Y-m-d.
props gauravmittal1995.
fixes #28447.

git-svn-id: https://develop.svn.wordpress.org/trunk@28848 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 14:28:04 +00:00
Andrew Ozz 38debafe60 Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640.
git-svn-id: https://develop.svn.wordpress.org/trunk@28847 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 04:14:59 +00:00
Scott Taylor 7139817d2e When `wp_oembed_add_provider()` or `wp_oembed_remove_provider()` is called before the `plugins_loaded` hook has, store the values statically on the `WP_oEmbed` object and add them just-in-time when the object is instantiated.
This ensures that all plugins have an accurate provider list when `apply_filters( 'oembed_providers', $providers )` is called. 

Props kovshenin.
Fixes #28284.


git-svn-id: https://develop.svn.wordpress.org/trunk@28846 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 02:29:20 +00:00
Scott Taylor 4d1313bffc In `kses.php`, ensure that `$allowedposttags`, `$allowedtags`, and `$allowedentitynames` are added to the global namespace.
Props Jaza613.
Fixes #28582.



git-svn-id: https://develop.svn.wordpress.org/trunk@28845 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 02:13:16 +00:00
Scott Taylor b4c75b8ab1 Check for the existence of `$post` before using it in `get_the_ID()`. Return `false` if it doesn't exist.
Props UmeshSingla.
Fixes #17034.


git-svn-id: https://develop.svn.wordpress.org/trunk@28844 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 02:04:38 +00:00
Scott Taylor cf15c523d3 Only apply a subtle semi-transparent border to attachments that are images in the media list table.
See [28842], #15860.



git-svn-id: https://develop.svn.wordpress.org/trunk@28843 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:57:37 +00:00
Scott Taylor f92d73310a Apply a subtle semi-transparent border to images in the media list table to avoid the "white on white (like a polar bear in Antarctica)" problem.
Props ericlewis.
Fixes #15860.


git-svn-id: https://develop.svn.wordpress.org/trunk@28842 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:51:20 +00:00
Scott Taylor 6d924f9d53 Add mime support for 3gp, 3g2 and 3gpp video formats. These are not supported by MediaElement or the WP media shortcodes, just an FYI.
Props azaozz, m_uysl.
Fixes #23380.


git-svn-id: https://develop.svn.wordpress.org/trunk@28841 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:42:54 +00:00
Scott Taylor f106f80768 In `wp_localize_script()`, instantiate the `$wp_scripts` global instead of bailing when it is called before `wp_enqueue_scripts`. This allows `wp_enqueue_media()` to be called on the front end with no JS errors.
Props ericlewis.
Fixes #24724.


git-svn-id: https://develop.svn.wordpress.org/trunk@28840 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:37:13 +00:00
Scott Taylor 0105f41c77 Dynamically prepend screen reader text to the attachment filters dropdown and the search box in the media modal.
Props SergeyBiryukov.
Fixes #25102.


git-svn-id: https://develop.svn.wordpress.org/trunk@28839 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:27:37 +00:00
Scott Taylor 3ace2eba1d Race conditions can cause `.uploader-window` to be visible with opacity of `0`. It will cause the user to have to refresh the page or inspect the element to hide it. Add a delay in `wp.media.view.UploaderWindow.hide()` to ensure that the uploader window is indeed hidden.
Props kovshenin.
Fixes #27341.


git-svn-id: https://develop.svn.wordpress.org/trunk@28838 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:19:18 +00:00
Scott Taylor 95f3506532 In `media_buttons()`, add a static var `$instance` to increment the `id` attribute of `insert-media-button-%d` on each call.
Props ericlewis.
Fixes #28090.


git-svn-id: https://develop.svn.wordpress.org/trunk@28837 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:04:32 +00:00
Scott Taylor 7e9cf1d2c0 `return false` in `has_nav_menu()` if the `$location` does not exist in the `$_wp_registered_nav_menus` global.
Props SergeyBiryukov.
Fixes #27735.


git-svn-id: https://develop.svn.wordpress.org/trunk@28836 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 00:56:07 +00:00
Scott Taylor b917e7998d `get_blog_details()->post_count` should update on more actions than just `publish_post`.
Adds unit test.

Props 5um17, midxcat, strangerstudios.
Fixes #27952.


git-svn-id: https://develop.svn.wordpress.org/trunk@28835 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 00:52:25 +00:00
John Blackbourn 8621b2c92c Switch to SSL for the Flickr and Slideshare oEmbed endpoints. Add support for SSL embeds on flic.kr. See #28507.
git-svn-id: https://develop.svn.wordpress.org/trunk@28834 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-25 23:35:02 +00:00
Drew Jaynes (DrewAPicture) 8130335b9d Add braces missed while adding docs for the `option_page_capability_{$option_page}` hook.
See [25372]. See #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@28833 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-25 21:47:14 +00:00
Scott Taylor 1c947d9ef1 Bring the list of `upload_filetypes` for multisite into modernity based on .com upgrades and supported extensions for audio and video.
Fixes #24434.


git-svn-id: https://develop.svn.wordpress.org/trunk@28832 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-25 17:59:54 +00:00
Scott Taylor 96484fd3f9 Optimize the `wptexturize()` loop:
* Take the ampersand pattern out of the loop for speed.
* Fix old bugs in the ampersand pattern.
* Refactor `_wptexturize_pushpop_element()` without PCRE for speed.
* Update unit tests.

Props miqrogroove.
Fixes #28623.


git-svn-id: https://develop.svn.wordpress.org/trunk@28831 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-25 17:48:20 +00:00
Scott Taylor 69101fe0f3 The "old iframe media modal" has some pretty busted styles. Although this is a "deprecated" feature, clean up some of the broken styles.
Props erayalakese for the JS patch.
Fixes #28220.



git-svn-id: https://develop.svn.wordpress.org/trunk@28830 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-25 17:38:28 +00:00
Scott Taylor 6f220c7fc7 Make the list of gallery attachments in the "old iframe media modal" break less. The "columns" are not aligned with the headers, but this would require a markup rewrite of a deprecated feature.
Fixes #28098.



git-svn-id: https://develop.svn.wordpress.org/trunk@28829 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-25 17:11:36 +00:00
Andrew Ozz 7a2d51e539 wpLink: support whole URLs including query/fragment when pre-filling the URL field. Fixes #19992
git-svn-id: https://develop.svn.wordpress.org/trunk@28828 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-25 00:36:24 +00:00
Sergey Biryukov ccdfdb2c8e Allow for easier adding of custom class variables when extending WP_Customize_Section or WP_Customize_Setting.
props rhurling.
fixes #27315.

git-svn-id: https://develop.svn.wordpress.org/trunk@28827 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 22:55:56 +00:00
Scott Taylor 6385135983 When selecting a fallback menu in `wp_nav_menu()`, the "first" menu is retrieved from an unsorted query. When retrieving a fallback menu, pass `array( 'orderby' => 'name' )` to `wp_get_nav_menus()` to return a menu consistently.
Props lukecarbis.
Fixes #28126.


git-svn-id: https://develop.svn.wordpress.org/trunk@28826 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 17:24:23 +00:00
wonderboymusic 77cf8a1184 Simplify the setting of `$args['include']` in `wp_get_nav_menu_items()`.
Props UmeshSingla.
Fixes #28515.


git-svn-id: https://develop.svn.wordpress.org/trunk@28825 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 17:16:02 +00:00
Scott Taylor 73fe9d548b Ensure that a `has_children` parameter is given to `Walker::start_el()`.
Adds unit tests.

Props scribu, obenland.
Fixes #14041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28824 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 17:05:56 +00:00
Sergey Biryukov 94be170877 Use direct typecasting instead of intval() for better performance.
props kovshenin.
see #25788.

git-svn-id: https://develop.svn.wordpress.org/trunk@28823 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 16:05:54 +00:00
Sergey Biryukov a10aa6c53c Merge two Animoto oEmbed patterns.
props kovshenin.
see #28265.

git-svn-id: https://develop.svn.wordpress.org/trunk@28822 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 15:55:37 +00:00
Sergey Biryukov b1fd1dbbcf Add ISO date standard YYYY-MM-DD format to general settings.
props mattheweppelsheimer.
fixes #28447.

git-svn-id: https://develop.svn.wordpress.org/trunk@28820 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 09:49:37 +00:00
Scott Taylor 832bbb2821 Remove `noscript` from `wpautop()`'s list of block elements.
Props mdawaffe.
Fixes #27268.


git-svn-id: https://develop.svn.wordpress.org/trunk@28817 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:53:41 +00:00
Scott Taylor f6050ce8eb `wp.mce.embedView.fetch()` and `wp.media.view.EmbedLink.fetch()` need to pass the same parameters.
Fixes #28532.


git-svn-id: https://develop.svn.wordpress.org/trunk@28816 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:39:29 +00:00
Scott Taylor f5bda24b70 Add a filter/docs: 'oembed_remote_get_args' to `WP_oEmbed->discover()` and `->_fetch_with_format()`.
Props leewillis77, DrewAPicture.
Fixes #23442.


git-svn-id: https://develop.svn.wordpress.org/trunk@28815 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:27:55 +00:00
Scott Taylor 220fda0095 In `$wpdb->update()`, prevent explosions when `$where` is empty.
Adds unit tests.

Props UmeshSingla, wonderboymusic.
Fixes #26106


git-svn-id: https://develop.svn.wordpress.org/trunk@28814 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:23:09 +00:00
Scott Taylor 76bd35fa79 In `comment_form()`, allow `name_submit` to be passed to change the `name` attribute of the submit button.
Props obenland.
Fixes #22792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28813 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:09:51 +00:00
Scott Taylor 723927ca74 Adjust CSS for "Moved to the trash" message for a pingback in the dashboard.
Props zoerooney, codenameEli.
Fixes #28286.


git-svn-id: https://develop.svn.wordpress.org/trunk@28811 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:02:17 +00:00
Scott Taylor 848034a190 Use unobtrusive JS for Comment list table row actions.
Props aubreypwd.
Fixes #27533.


git-svn-id: https://develop.svn.wordpress.org/trunk@28810 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 23:54:28 +00:00
Sergey Biryukov 2120ede170 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly.
fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28808 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 22:20:23 +00:00
Scott Taylor 0adec3db8a Use the proper height property when calculating video size in `wp_underscore_video_template()`.
Props Fab1en.
See #28190.


git-svn-id: https://develop.svn.wordpress.org/trunk@28807 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 20:34:14 +00:00
Sergey Biryukov 4fd715c937 Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata().
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28806 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 14:47:08 +00:00
Sergey Biryukov b11b6f2f2b Simplify the code for calculating plugin API check timeout.
props leewillis77.
fixes #28600.

git-svn-id: https://develop.svn.wordpress.org/trunk@28805 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 14:30:14 +00:00
Sergey Biryukov 21cf4d1ab4 Don't kill an empty search query.
see #11330.

git-svn-id: https://develop.svn.wordpress.org/trunk@28804 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 13:33:39 +00:00
Sergey Biryukov f7d7ecd0a6 Prevent multiple hierarchical posts with the same slug from being displayed in single post template.
fixes #28611.

git-svn-id: https://develop.svn.wordpress.org/trunk@28803 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 13:14:39 +00:00
Sergey Biryukov 1c7bfc7ed1 Revert [28776] and use a correct variable instead.
props miqrogroove.
fixes #28575.

git-svn-id: https://develop.svn.wordpress.org/trunk@28802 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-22 22:12:47 +00:00
Sergey Biryukov 256de085ec Fix MediaElement i18n.
props Namibia, eherman24.
fixes #28366 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28801 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-22 14:15:55 +00:00
Andrew Ozz 31da18f841 TinyMCE: revert 158b742410 and 576fa77aa2 as they may cause selection restore problems in old IE. See #28391.
git-svn-id: https://develop.svn.wordpress.org/trunk@28795 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-21 01:14:43 +00:00
Andrew Nacin c45a47efdd Stop denying wp-includes/* in our default robots.txt.
props joostdevalk.
fixes #28604.


git-svn-id: https://develop.svn.wordpress.org/trunk@28794 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 21:01:29 +00:00
Andrew Nacin 18d069703b Fix documentation for wp_create_nonce() which wrongly suggests these tokens are actually numbers used once.
git-svn-id: https://develop.svn.wordpress.org/trunk@28793 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 20:46:13 +00:00
Scott Taylor 84fb91f383 Don't annotate `$wp_error` twice in `login_header()` docs. `$wp_error` is always expected to be of type `WP_Error`.
Props SergeyBiryukov.
Fixes #28518.


git-svn-id: https://develop.svn.wordpress.org/trunk@28792 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 19:18:25 +00:00
Scott Taylor 304f4f5ba9 Posts in the Trash should not drag attachment pages down with them.
Props ericlewis.
Fixes #14639.


git-svn-id: https://develop.svn.wordpress.org/trunk@28791 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 19:13:39 +00:00
Scott Taylor e447c8f823 Add Animoto to the list of oEmbed providers. Example video: http://animoto.com/play/MlRRgXHhoT8gOZyHanM6TA.
Props lritter.
Fixes #28265.



git-svn-id: https://develop.svn.wordpress.org/trunk@28790 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:56:11 +00:00
Scott Taylor 4540455f95 Whitespace in `navMenuL10n` after [28707].
Fixes #23076.



git-svn-id: https://develop.svn.wordpress.org/trunk@28789 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:29:44 +00:00
Scott Taylor a7c1728f2e Reinstate the changes from [28579] with some adjustments:
* Check `! empty( $postarr['file'] )` before calling `update_attached_file()`
* Add a unit test: `test_update_attachment_fields()`
* Run the same logic for empty `guid` for attachments that always ran in `wp_insert_post()`, as per #18310. This fixes a unit test that would have broken when this ticket was marked closed.
* Updated the unit test in `Tests_Media::test_wp_prepare_attachment_for_js()` to account for `url` no longer being empty

Props kovshenin, wonderboymusic.
See #21963.


git-svn-id: https://develop.svn.wordpress.org/trunk@28788 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:26:17 +00:00
Scott Taylor 05abd7e56f Cleanup `wp_widget_rss_form()` after [28734]. "$$input used sanitized variables which contained actual values, unlike $inputs[$input] which in that context contains data about which input fields are hidden."
Props kovshenin.
Fixes #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28787 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:28:12 +00:00
Scott Taylor 76ccf2a956 Remove unused globals from `link-parse-opml.php` after [28743].
Props SergeyBiryukov.
Fixes #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28786 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:25:47 +00:00
Scott Taylor 33275a0826 Cleanup after [28671]:
* Set better defaults in `paginate_links()`, so that themes don't have to calculate them on their own, like Twenty Fourteen does now.
* Don't set page 1 to `?page=1` or `/page/1/` - that will force a canonical redirect.
* Add and cleanup unit tests

Props obenland, SergeyBiryukov, wonderboymusic.
Fixes #24606.


git-svn-id: https://develop.svn.wordpress.org/trunk@28785 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:11:14 +00:00
Scott Taylor eb289835f7 Further adjustments after [8364], listen to an editor instance event instead of delegating a body click when attempting to pause all players belonging to a particular MCE view.
Props avryl.
Fixes #27971.


git-svn-id: https://develop.svn.wordpress.org/trunk@28784 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 16:29:47 +00:00
Scott Taylor 5ec545d5ab Revert [28613] and [28664]. A good idea, but too much BC baggage.
See #28099.



git-svn-id: https://develop.svn.wordpress.org/trunk@28783 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 16:20:35 +00:00
John Blackbourn dbc30e94b3 Increase the timeout for plugin and theme update checks based on how many are being checked. Props dd32. Fixes #25788
git-svn-id: https://develop.svn.wordpress.org/trunk@28782 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 23:20:15 +00:00
John Blackbourn 036c2b5fca Remove SSL verification by default for requests to wp-cron.php. Props sivel, rhurling. Fixes #12609.
git-svn-id: https://develop.svn.wordpress.org/trunk@28781 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 22:52:35 +00:00
Andrew Nacin e27b672b22 Narrower screen when choosing a language. see #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@28780 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 04:46:40 +00:00
Andrew Nacin aa6ef01298 Fix variable usage in new language install choices. see #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@28779 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 04:36:29 +00:00
Helen Hou-Sandi ae2cce3f64 Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583.
git-svn-id: https://develop.svn.wordpress.org/trunk@28778 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 02:17:08 +00:00
Sergey Biryukov 4bee2a9c4a Fix copy/paste error in a comment.
see #28581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28777 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 01:35:28 +00:00
Sergey Biryukov 4306de30e3 Move preg_match() that should only run once out of the loop.
props dllh.
fixes #28575.

git-svn-id: https://develop.svn.wordpress.org/trunk@28776 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 00:00:27 +00:00
Scott Taylor 9642d17ff8 Diambiguate `type` and `shortcode` in TinyMCE view classes and their attached `view.View` class. Has the added feature of not causing JS errors.
See #28532.


git-svn-id: https://develop.svn.wordpress.org/trunk@28775 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 23:02:10 +00:00
Andrew Nacin 39cf46851b Allow a language to be chosen before installing WordPress. First pass.
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28774 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 19:57:21 +00:00
Scott Taylor 0688f9eb49 In `wptexturize()` + tests:
* Allow well-formed HTML inside of shortcode attributes
* Restrict recursion. HTML is allowed but ignored.
* Do not allow exotic HTML comments in shortcode attributes.
* Continue to ignore the [ and ] chars if they appear in any HTML attribute.
* Update related regex patterns.
* Update unit tests.

Props miqrogroove.
Fixes #28564.


git-svn-id: https://develop.svn.wordpress.org/trunk@28773 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 19:48:46 +00:00
Sergey Biryukov 6719d08d2d Revert [28766].
see #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28772 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 02:22:45 +00:00
Sergey Biryukov 9561db4dee Don't add # to URL when clicking 'OK' without changing the permalink.
props avryl.
fixes #27594.

git-svn-id: https://develop.svn.wordpress.org/trunk@28771 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 00:28:35 +00:00
Sergey Biryukov 550d0f0aea Don't generate adjacent links in wp_head() for attachments.
props kovshenin.
fixes #21658.

git-svn-id: https://develop.svn.wordpress.org/trunk@28770 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 00:04:14 +00:00
Sergey Biryukov 566fd5da8d Pass WP_Customize_Setting instance to 'customize_save_*' action.
props danielbachhuber.
fixes #27979.

git-svn-id: https://develop.svn.wordpress.org/trunk@28769 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:57:19 +00:00
Andrew Ozz b8fd9d997e TinyMCE: update to 4.0.28+. Includes all changes until 09-06-2014: 32cb108d41. Changelog: 32cb108d41/changelog.txt.
See #28391.

git-svn-id: https://develop.svn.wordpress.org/trunk@28768 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:49:00 +00:00
Sergey Biryukov f1172ba195 Pass WP_Customize_Setting instance to 'customize_preview_*' and 'customize_update_*' actions.
props dustyn, DrewAPicture.
fixes #27979.

git-svn-id: https://develop.svn.wordpress.org/trunk@28767 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:34:31 +00:00
Sergey Biryukov 63596d6868 Prevent bulk actions from being performed when Filter button is clicked.
props layotte.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28766 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 22:16:11 +00:00
Scott Taylor b11edb94d9 Fix abbreviations mixed with quotes, example: `'99% of people'`.
Add/alter unit tests.

Props miqrogroove.
Fixes #26850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28765 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 20:18:38 +00:00
Scott Taylor 1f4d925102 In `wptexturize()`, adjust for the treatment of abbreviated years at the end of quotations.
Silence some unit tests that have never passed and may no longer be applicable.

Props miqrogroove.
Fixes #18549.


git-svn-id: https://develop.svn.wordpress.org/trunk@28764 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 20:13:54 +00:00
Scott Taylor 6f658551d6 Add unit tests to confirm that `---` is properly converted to `&#8212;` by `wptexturize()` where appropriate.
Props miqrogroove.
Fixes #28483.


git-svn-id: https://develop.svn.wordpress.org/trunk@28763 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 18:06:12 +00:00
Scott Taylor 14f3b15d69 Add Unit Tests for i18n and `wptexturize()`. Don't confuse closing single quotes and apostrophes.
See #27426.


git-svn-id: https://develop.svn.wordpress.org/trunk@28762 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 17:56:08 +00:00
Scott Taylor 03a6e5f1fb `wptexturize()` adjustments:
* Only place an apostrophe before a number when it has exactly two digits.
* Never match '99' with the single prime pattern.
* Always assume '99' is an abbreviated year at the end of a quotation.
* Add unit tests.
* Resolves the unit test broken in [28721] for #8775.

See #26850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28761 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 17:40:07 +00:00
Sergey Biryukov abddfc4b99 Prevent get_post_class() and get_body_class() from returning duplicate classes.
props Compute.
fixes #28541.

git-svn-id: https://develop.svn.wordpress.org/trunk@28760 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 15:17:36 +00:00
Sergey Biryukov 177d39a15b Fix labels on installation screen.
props avryl.
fixes #28548.

git-svn-id: https://develop.svn.wordpress.org/trunk@28759 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 14:36:22 +00:00
Lance Willett f738d86233 Twenty Fourteen: fix masthead behavior in IE when a custom header image is present. Props Kau-Boy, lancewillett. Fixes #27220.
git-svn-id: https://develop.svn.wordpress.org/trunk@28758 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-16 18:21:01 +00:00
Dominik Schilling (ocean90) 87f306aa81 Twenty Fourteen: Adjust spacing for menu toggle button to avoid overflowing accented characters.
Broken in [28698].

props schoenwaldnils.
fixes #27456.

git-svn-id: https://develop.svn.wordpress.org/trunk@28756 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-16 14:00:15 +00:00
Andrew Ozz ed4a159498 TinyMCE wpView: fix selecting all of view's "text" in Safari, props avryl, fixes #28088
git-svn-id: https://develop.svn.wordpress.org/trunk@28755 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-16 00:11:45 +00:00
Andrew Ozz ed07c215dc wpView: improve handling of embed errors/error messages, see #28195
git-svn-id: https://develop.svn.wordpress.org/trunk@28754 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-15 22:52:45 +00:00
Sergey Biryukov 084cc046ac Correct @return value for term_exists().
props simonwheatley.
fixes #28538.

git-svn-id: https://develop.svn.wordpress.org/trunk@28753 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-14 14:56:21 +00:00
Scott Taylor 69ecca0b6a Add "edit" mode for `[embed]` and URL media previews.
See #28532.


git-svn-id: https://develop.svn.wordpress.org/trunk@28752 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:41:20 +00:00
Sergey Biryukov a67759c545 wpLink: use simpler expressions to detect email address or URL. We are not validating user input here, just suggesting.
see #19992.

git-svn-id: https://develop.svn.wordpress.org/trunk@28751 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:25:16 +00:00
Andrew Ozz 8ed6fd2d50 wpLink: use the proper instance of the editor when looking at the selection. Move the email and URL regexp to variables. See #19992
git-svn-id: https://develop.svn.wordpress.org/trunk@28750 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-13 21:13:15 +00:00
Andrew Nacin 65803684f4 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This.
fixes #28513.


git-svn-id: https://develop.svn.wordpress.org/trunk@28749 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-12 18:08:56 +00:00
Andrew Ozz 09d4b541fb wpView:
- Don't wrap single-line URLs in [embed]. Use them directly in generating a view.
- If the embedding HTML contains a script, "sandbox" it in an iframe to prevent it from changing the editor DOM.
- Automatically add toolbar and overlay when needed.
- Try to embed single-line URLs only if they are pasted in an empty paragraph.
Props avryl, see #28195

git-svn-id: https://develop.svn.wordpress.org/trunk@28748 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-12 02:48:17 +00:00
Scott Taylor e0a089d9d8 Don't use variable variables in `touch_time()`.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28747 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 21:04:56 +00:00
Scott Taylor 61c1da236c Don't use variable variables in `wp_reset_vars()`. Test by searching in list tables, etc.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28746 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 19:59:18 +00:00
Scott Taylor eb23569835 Don't use variable variables in `user-new.php`. Test by causing errors when creating a new user.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28745 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 19:53:25 +00:00
Scott Taylor 6e159bb671 Don't use variable variables in `setup-config.php` (Step 2).
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28744 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 19:40:27 +00:00
Scott Taylor 98f3cd0548 OPML:
* Learn how OPML works, cry.
* Remove unused globals in `startElement()`
* Stop using variable variables in `startElement()`

Tested with the OPML importer plugin

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28743 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 19:30:26 +00:00
Scott Taylor 4ccb011960 Don't use variable variables in `wp_dashboard_plugins_output()`. Variable variables aren't the worst thing about this function.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28742 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:55:00 +00:00
Scott Taylor 0675902ec8 Don't use variable variables in `wp_salt()`.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28741 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:35:42 +00:00
Scott Taylor 0d0cdfe1c7 Don't use variable variables in `wp_insert_user()`.
Add a local array, `$meta`, to provide substantial disambiguation among variables. 

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28740 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:20:57 +00:00
Scott Taylor 35af75077b Don't use variable variables in `plugins_url()`.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28739 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:17:52 +00:00
Scott Taylor ce8cff84aa Don't use variable variables in `WP_Comment_Query::query()`.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28738 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:57:39 +00:00
Scott Taylor f2b3e0c4e4 Don't use variable variables in `WP_Query::get_posts()`.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28737 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:49:07 +00:00
Scott Taylor 5fe5f8f3ad Don't use variable variables in `get_terms()`.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28736 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:40:11 +00:00
Drew Jaynes (DrewAPicture) e535d7fe6e Improve inline documention for `set_transient()` and `set_site_transient()` to specify the 45- and 40-character limits for their respective transient name values.
Props edwin-at-studiojoyo.com for the original patch.
See #15058, #13310. Fixes #28467.


git-svn-id: https://develop.svn.wordpress.org/trunk@28735 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 16:32:06 +00:00
Scott Taylor fa03901cd8 Don't use a variable variable in `wp_widget_rss_form()`. Sidenote: the logic to show hidden fields is bizarre - would result in duplicate fields.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28734 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 16:17:56 +00:00
Scott Taylor eadc17c4f9 In `wp_insert_term()`, when no slug is provided, check for an existing term by name. If it exists, use that slug instead of calling `sanitize_title( $name )`.
Prevents creating an endless number of terms like `A+` or `$$$$` in any given taxonomy.

Props wonderboymusic, SergeyBiryukov, aaroncampbell.
Fixes #17689.


git-svn-id: https://develop.svn.wordpress.org/trunk@28733 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 02:27:36 +00:00
Andrew Ozz 1b07af046f Fix the layout of the Image Details modal, props gcorne, see #24716 [28682]
git-svn-id: https://develop.svn.wordpress.org/trunk@28732 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 00:22:53 +00:00
John Blackbourn f02e878bb0 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt.
git-svn-id: https://develop.svn.wordpress.org/trunk@28731 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 19:14:26 +00:00
John Blackbourn 827cf97b00 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein.
git-svn-id: https://develop.svn.wordpress.org/trunk@28730 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 18:49:26 +00:00
Scott Taylor 121726df31 `edit.php?post_type=attachment` should redirect to `upload.php`. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants.
Props knutsp.
Fixes #27951.


git-svn-id: https://develop.svn.wordpress.org/trunk@28729 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 18:47:57 +00:00
John Blackbourn f54bb586c8 A little more abstraction in the `WP_oEmbed` class. Fixes #24381.
git-svn-id: https://develop.svn.wordpress.org/trunk@28728 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 18:13:43 +00:00
Scott Taylor 821c052473 In `wptexturize()`, ensure that texturization does not corrupt contents of HTML elements, HTML comments, and smartcode attributes.
Adds a variety of unit tests/assertions.

Props miqrogroove.
Fixes #12690, #8912, #27602.


git-svn-id: https://develop.svn.wordpress.org/trunk@28727 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:33:16 +00:00
Scott Taylor 9e347a40c2 In `wptexturize()`, allow dashes before and after curly quotes. Example: This is what she said---"Wow that is cool."
Adds unit tests.

Props adamsilverstein, miqrogroove.
Fixes #20342.


git-svn-id: https://develop.svn.wordpress.org/trunk@28726 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:21:36 +00:00
Scott Taylor 66b539bdab `wptexturize()` should handle apostrophes before primes.
Props nacin, miqrogroove.
Fixes #22823.


git-svn-id: https://develop.svn.wordpress.org/trunk@28725 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:13:52 +00:00
Drew Jaynes (DrewAPicture) da0b2f9769 Improve inline documentation for the `wp_spaces_regexp` filter.
Fixes #27588.


git-svn-id: https://develop.svn.wordpress.org/trunk@28724 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 06:45:38 +00:00