Commit Graph

39863 Commits

Author SHA1 Message Date
Sergey Biryukov
a3fbc75237 Accessibility: Make sure layout tables across the admin are correctly linearized.
Adds `role="presentation"` to the `<table>` elements used for layout purposes.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props greatislander, afercia.
Fixes #46899.

git-svn-id: https://develop.svn.wordpress.org/trunk@45403 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 21:55:21 +00:00
John Blackbourn
a4d9f02eef I18N: Add a language icon next to language selectors.
This change means that users who can't read the site's current language can more easily identify controls that allow them to change either the site language or their own admin area language.

Props janak007, atlasmahesh, afercia, birgire, JoshuaWold

Fixes #43144


git-svn-id: https://develop.svn.wordpress.org/trunk@45402 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 20:42:06 +00:00
John Blackbourn
971b5daa74 Administration: Replace references to "articles" with "posts" for greater consistency of terminology.
Props angelagibson

Fixes #38517


git-svn-id: https://develop.svn.wordpress.org/trunk@45401 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 19:17:50 +00:00
Sergey Biryukov
a850022635 Bootstrap/Load: In wp_get_server_protocol(), check if $_SERVER['SERVER_PROTOCOL'] is defined, to avoid a notice in CLI context.
Props thakkarhardik, malthert.
Fixes #47005.

git-svn-id: https://develop.svn.wordpress.org/trunk@45400 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:46:16 +00:00
Sergey Biryukov
630f4bc1ea I18N: Remove PHP function name from translatable string in WP_Debug_Data.
Props ramiy.
Fixes #47254.

git-svn-id: https://develop.svn.wordpress.org/trunk@45399 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:40:35 +00:00
Sergey Biryukov
7afa6c2057 Login and Registration: Pass the action to site_url() in wp_logout_url() and wp_lostpassword_url():
* Make `site_url` filter in `wp_logout_url()` aware of the `logout` action.
* Make `network_site_url` filter in `wp_lostpassword_url()` aware of the `lostpassword` action.

Props jfarthing84.
Fixes #43407.

git-svn-id: https://develop.svn.wordpress.org/trunk@45398 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:32:19 +00:00
Sergey Biryukov
d1be6e34c9 Twenty Nineteen: Add missing icon to Edit link for pages.
Props mukesh27, ianbelanger, ounziw.
Fixes #47332.

git-svn-id: https://develop.svn.wordpress.org/trunk@45397 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:21:09 +00:00
Sergey Biryukov
36d7479dc5 I18N: Merge two similar "you may need to press the Esc key twice" strings.
Props ramiy, tmatsuur, hareesh-pillai.
Fixes #47036.

git-svn-id: https://develop.svn.wordpress.org/trunk@45396 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:17:31 +00:00
Sergey Biryukov
069ecb0292 I18N: Merge two similar "An unexpected error occurred" strings.
Props ramiy.
Fixes #47035.

git-svn-id: https://develop.svn.wordpress.org/trunk@45395 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:13:44 +00:00
Sergey Biryukov
c725e9f0d8 Docs: Fix typos in DocBlocks and comments in wp-admin/includes/file.php.
Props mukesh27.
Fixes #47026.

git-svn-id: https://develop.svn.wordpress.org/trunk@45394 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:07:52 +00:00
Sergey Biryukov
22d530e2bb Docs: Remove unused @global reference in do_blocks() DocBlock.
Props avinapatel.
Fixes #47055.

git-svn-id: https://develop.svn.wordpress.org/trunk@45393 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:04:19 +00:00
Sergey Biryukov
ee3324653a Docs: Fix incorrect @see notation in wp_localize_script() DocBlock.
Props coffee2code, shamim51.
Fixes #47104.

git-svn-id: https://develop.svn.wordpress.org/trunk@45392 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-24 01:01:05 +00:00
Sergey Biryukov
60df42d187 Networks and Sites: Readjust tabs in wp-admin/includes/network.php for (more or less) consistent alignment.
See #47062.

git-svn-id: https://develop.svn.wordpress.org/trunk@45391 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 23:34:40 +00:00
Sergey Biryukov
4f51d3679c Networks and Sites: Remove extra whitespace in .htaccess rules on Network Setup page.
Props riddhiehta02 for initial patch, sebastienserre, masterforwordpress.
Fixes #47062.

git-svn-id: https://develop.svn.wordpress.org/trunk@45390 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 23:27:57 +00:00
John Blackbourn
2756e6a27f Administration: Don't apply italic formatting to code blocks in setting descriptions.
Props chetan200891

Fixes #42651


git-svn-id: https://develop.svn.wordpress.org/trunk@45389 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 23:13:51 +00:00
John Blackbourn
bcf74af357 Docs: Remove incorrect information about usage of the "from" filters in wp_mail(), tidy up formatting.
See #47110


git-svn-id: https://develop.svn.wordpress.org/trunk@45388 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 22:41:12 +00:00
John Blackbourn
9b248694ac I18N: Use a complete translatable string for the "Delete My Site" email subject.
Props thrijith

Fixes #46855


git-svn-id: https://develop.svn.wordpress.org/trunk@45387 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 22:14:28 +00:00
John Blackbourn
9ca74cade9 Embeds: Remove the "Supports HTTPS" column from the whitelisted oEmbed provider list now that all supported providers use HTTPS.
See #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@45386 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 21:22:23 +00:00
John Blackbourn
3a08a2ca34 Embeds: Use HTTPS for the Hulu oEmbed endpoint, as it redirects to HTTPS now.
Fixes #28507


git-svn-id: https://develop.svn.wordpress.org/trunk@45385 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 21:19:50 +00:00
Sergey Biryukov
70f0b32079 I18N: Capitalize "Privacy Policy Page" heading to merge two similar strings.
Props ramiy, garrett-eclipse.
Fixes #47250.

git-svn-id: https://develop.svn.wordpress.org/trunk@45384 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 21:10:56 +00:00
Sergey Biryukov
df9caed81b Twenty Nineteen: Correct function name in a function_exists() check for twentynineteen_get_user_avatar_markup().
Props mukesh27, diego-la-monica.
Fixes #46410.

git-svn-id: https://develop.svn.wordpress.org/trunk@45383 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 01:30:21 +00:00
Sergey Biryukov
e23ea906e2 I18N: Make punctuation in some wp-admin strings more consistent.
Props pedromendonca.
Fixes #47358.

git-svn-id: https://develop.svn.wordpress.org/trunk@45382 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 01:11:04 +00:00
Sergey Biryukov
16f60dfc73 Media: Correct closing </label> tags in #tmpl-audio-details and #tmpl-video-details after [42444].
Props TravisSeitler.
Fixes #47355.

git-svn-id: https://develop.svn.wordpress.org/trunk@45381 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 00:48:14 +00:00
Sergey Biryukov
a6579d4715 Docs: Adjust get_post_modified_time filter DocBlock for consistency with get_post_time.
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@45380 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 00:40:08 +00:00
Sergey Biryukov
2a163fa733 Date/Time: Return early from the_weekday() and the_weekday_date() if we're not in the loop.
Restore `$previousweekday` global usage in `the_weekday_date()`, so it could still be used simultaneously with `the_date()`.

Partially reverts [45378].
See #47354.

git-svn-id: https://develop.svn.wordpress.org/trunk@45379 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 00:37:56 +00:00
Sergey Biryukov
48fb69f013 Date/Time: Bring some consistency to the_date() and the_weekday_date():
* Make `the_date()` always apply the the filter and return a value.
* Use `is_new_day()` in `the_weekday_date()`.
* Add a unit test for `the_weekday_date()`.

Fixes #47354.

git-svn-id: https://develop.svn.wordpress.org/trunk@45378 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-22 21:57:29 +00:00
Sergey Biryukov
36df800c3c Docs: Improve documentation for the_date() and the_weekday_date().
Correct type for `$currentday` and `$previousday` globals.

See #47354, #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@45377 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-22 21:47:49 +00:00
Andrea Fercia
1a1031b466 Accessibility: Improve the media views upload Dismiss Errors button.
- makes the Dismiss Errors button visible in the media views inline uploader
- avoids a focus loss when activating the Dismiss Errors button

See the related GitHub issue from the WPCampus accessibility audit https://github.com/WordPress/gutenberg/issues/15354

Fixes #47113.


git-svn-id: https://develop.svn.wordpress.org/trunk@45376 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-22 19:32:22 +00:00
Sergey Biryukov
6491746559 Date/Time: Use strict comparison in is_new_day(), add a unit test.
Props pbearne.
Fixes #46627.

git-svn-id: https://develop.svn.wordpress.org/trunk@45375 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-22 17:52:22 +00:00
Jonathan Desrosiers
f9e4f60577 General: Add missing unit tests for wp_array_slice_assoc().
Props pbearne, desrosj.
Fixes #46638.

git-svn-id: https://develop.svn.wordpress.org/trunk@45371 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-21 14:47:58 +00:00
Jonathan Desrosiers
05da62cca7 Feeds: Ensure a feed’s <lastBuildDate> has the correct date.
The maximum modified time for a is currently being determined after an arbitrary date format is applied. Because the string sort in `max()` is being used to return the highest (most recent) modified value, the incorrect date is sometimes returned. This was introduced in [45247].

Props onlanka, Rarsr, mukesh27.
Fixes #47304.

git-svn-id: https://develop.svn.wordpress.org/trunk@45367 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-20 14:41:59 +00:00
Sergey Biryukov
ff131f5e29 Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if wp_get_update_php_url() and wp_get_update_php_annotation() exist.
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.

Reviewed by desrosj, earnjam, SergeyBiryukov.

Props dd32, imath.
Fixes #47323.

git-svn-id: https://develop.svn.wordpress.org/trunk@45365 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-20 14:28:03 +00:00
Peter Wilson
b9e6f18350 KSES: Add flex and related long form properties to safe CSS.
Allow `flex`, `flex-grow`, `flex-shrink` and `flex-basis` to be used in inline CSS. As of WordPress 5.3 the block editor is expected to use `flex-basis` inline to set the width in the column block.

Props aduth.
Fixes #47281.
See #37248.



git-svn-id: https://develop.svn.wordpress.org/trunk@45363 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-18 04:33:27 +00:00
Sergey Biryukov
e353c2841a Taxonomy: In wp_insert_term(), handle an error if writing to the term_taxonomy table fails.
This complements the check for successful writing to the `terms` table, added in [7430].

Props mbabker.
Fixes #47313.

git-svn-id: https://develop.svn.wordpress.org/trunk@45362 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 22:27:55 +00:00
Sergey Biryukov
0205cf09f0 Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.

Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Fixes #46937.

git-svn-id: https://develop.svn.wordpress.org/trunk@45357 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 18:10:55 +00:00
Sergey Biryukov
76755c0e68 Media: Fix deletion of files on Windows.
`wp_delete_file_from_directory()` should always normalize file paths before comparing.

Props tonybogdanov, SergeyBiryukov.
Fixes #47185.

git-svn-id: https://develop.svn.wordpress.org/trunk@45352 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 13:28:15 +00:00
Sergey Biryukov
3f641505fe Build/Test Tools: Use a non-zero exit code in wp_check_php_mysql_versions() when minimum PHP or MySQL requirements are not met.
This allows automated scripts and test suites to interpret the result correctly.

Props jrf, spacedmonkey.
Fixes #47169.

git-svn-id: https://develop.svn.wordpress.org/trunk@45350 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 12:33:50 +00:00
Sergey Biryukov
a36aa1b078 Formatting: Adjust wp_targeted_link_rel() to ensure JSON format is preserved and correct quotes are used when adding the missing rel attribute.
Props birgire, TobiasBg, fierevere, audrasjb, SergeyBiryukov.
Fixes #46316, #47244.

git-svn-id: https://develop.svn.wordpress.org/trunk@45348 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 12:08:50 +00:00
Sergey Biryukov
ee8771923a Site Health: In PHP modules test description, move the space before the screen reader text out from the translatable string.
Props ocean90, tobifjellner.
Fixes #47161.

git-svn-id: https://develop.svn.wordpress.org/trunk@45346 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 11:49:52 +00:00
Alex Shiels
85a90cb244 Upgrade/Install: Don't run signature verify on slow 32-bit systems.
The sodium_compat library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.

Props dd32, paragoninitiativeenterprises.
See #47186.


git-svn-id: https://develop.svn.wordpress.org/trunk@45345 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 11:05:45 +00:00
Alex Shiels
3360d50bc2 Upgrade/Install: Update sodium_compat to v1.10.0.
This adds a runtime_speed_test() method for estimating if the 32-bit implementation is fast enough for expensive computations.

Props paragoninitiativeenterprises.
See #47186.


git-svn-id: https://develop.svn.wordpress.org/trunk@45344 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 10:57:19 +00:00
Andrew Ozz
14066540c0 jQuery: bring jquery.js back into the WordPress SVN repo and backport the patch from 3.4.0.
Props MikeNGarrett, peterwilsoncc, azaozz.
Fixes #47020 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@45342 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 04:24:44 +00:00
Sergey Biryukov
dc2e521269 Accessibility: In back-compat code added for get_search_form() in [44956], when checking the (previously boolean) $args value, account for non-strict comparison.
Props dkarfa, sachyya-sachet.
Fixes #47177. See #42057.

git-svn-id: https://develop.svn.wordpress.org/trunk@45340 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 02:21:20 +00:00
Sergey Biryukov
dc8c8dd878 Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.
Props desrosj, mukesh27.
Fixes #46408.

git-svn-id: https://develop.svn.wordpress.org/trunk@45338 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 01:07:12 +00:00
Sergey Biryukov
040a58ff57 Site Health: Use correct singular string for plugin and theme version tests.
Props edocev, Presskopp.
Fixes #47264.

git-svn-id: https://develop.svn.wordpress.org/trunk@45336 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:59:20 +00:00
Sergey Biryukov
448234f966 I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].
Use an established pattern of moving additional link attributes out of the translatable string.

Props dimadin.
Fixes #47159.

git-svn-id: https://develop.svn.wordpress.org/trunk@45334 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:52:32 +00:00
Sergey Biryukov
e6dcab7803 Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.
Props dimadin, SergeyBiryukov.
Fixes #47161.

git-svn-id: https://develop.svn.wordpress.org/trunk@45331 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:06:49 +00:00
Sergey Biryukov
0126a4bd2a Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.
Props chesio.
Fixes #47297.

git-svn-id: https://develop.svn.wordpress.org/trunk@45328 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 22:07:35 +00:00
Jonathan Desrosiers
c18460698f Privacy: Prevent email field for personal data requests from overflowing.
Props anischarolia, ianbelanger, afercia.
Fixes #46961.

git-svn-id: https://develop.svn.wordpress.org/trunk@45326 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 20:44:41 +00:00
Jonathan Desrosiers
cd511054a0 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.

git-svn-id: https://develop.svn.wordpress.org/trunk@45324 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 19:04:42 +00:00