Commit Graph

27316 Commits

Author SHA1 Message Date
Andrew Nacin
3bd777fba5 Plugin Install screens: Pass locale and installed plugins to the API, for context.
props tellyworth.
see #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29227 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 20:49:14 +00:00
Andrew Nacin
b00097b758 Add 'Details' links to installed plugins.
Installed plugins that are up to date are now returned in the update-check API response.

props tellyworth.
see #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29226 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 20:48:28 +00:00
Helen Hou-Sandi
446f78396a Plugin install: display cards in groups if the API returns them with the appropriate information. props tellyworth. fixes #28673.
git-svn-id: https://develop.svn.wordpress.org/trunk@29225 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 19:34:47 +00:00
Andrew Nacin
fdacabaa7e WP_Session_Tokens: Can't abstract a static method.
Implementations can choose to implement the drop_sessions() method on their own.

see #20276.


git-svn-id: https://develop.svn.wordpress.org/trunk@29224 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 19:15:13 +00:00
John Blackbourn
bda49ba928 Update some inline docs for the WP_Http class. Fixes #28943.
git-svn-id: https://develop.svn.wordpress.org/trunk@29223 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 18:14:09 +00:00
Sergey Biryukov
6fdf1c5d36 Fix parse error in PHP 5.2.
props georgestephanis.
see #20276.

git-svn-id: https://develop.svn.wordpress.org/trunk@29222 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 17:33:50 +00:00
Andrew Nacin
97fcbef707 Tie cookies and nonces to user sessions so they may be invalidated upon logout.
Sessions are stored in usermeta via WP_User_Meta_Session_Tokens, which extends the abstract WP_Session_Tokens class. Extending WP_Session_Tokens can allow for alternative storage, such as a separate table or Redis.

Introduces some simple APIs for session listing and destruction, such as wp_get_active_sessions() and wp_destroy_all_sessions().

This invalidates all existing authentication cookies, as a new segment (the session token) has been added to them.

props duck_, nacin, mdawaffe.
see #20276.


git-svn-id: https://develop.svn.wordpress.org/trunk@29221 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 09:12:05 +00:00
Helen Hou-Sandi
a14ea26577 Keyboard accessibility for the media modal:
* Arrow keys navigate between items in the grid.
* Transfer focus into the panel when selecting a tab along the side.
* Transfer focus into the details sidebar when selecting an item and vice versa.
* Set initial focus on the close button so that it is visible.

props celloexpressions, lessbloat, ericlewis. fixes #25100, #25101, #28704. see #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29220 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 07:56:25 +00:00
Helen Hou-Sandi
1803c4c1e8 Plugin install cards:
* Move author attribution to its own line.
* Use `esc_url()` where appropriate.
* Better i18n.
* min-height for cards for a more even appearance.
* Show more cards on wide screens.
* Tighten up spacing below the filter bar.

props ocean90, helen. see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29219 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 06:07:21 +00:00
Helen Hou-Sandi
b0b9655b12 Install Plugins screen:
* Utilize the (currently-named) filter bar from the Add Themes screen.
* Move the upload link to the h2, also like the Add Themes screen.

see #28673.


git-svn-id: https://develop.svn.wordpress.org/trunk@29218 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 04:49:19 +00:00
Helen Hou-Sandi
021750b4f4 Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794.
git-svn-id: https://develop.svn.wordpress.org/trunk@29217 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 03:39:04 +00:00
Sergey Biryukov
168ed4764e Don't 404 for empty feeds.
fixes #18505.

git-svn-id: https://develop.svn.wordpress.org/trunk@29216 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 22:21:37 +00:00
Sergey Biryukov
332a618271 Declare the variable before using it.
props danielbachhuber.
fixes #28932.

git-svn-id: https://develop.svn.wordpress.org/trunk@29215 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 22:00:14 +00:00
Andrew Ozz
9730c679f1 TinyMCE: add the 'colorpicker' and 'lists' plugins, fixes #28939, #27359.
git-svn-id: https://develop.svn.wordpress.org/trunk@29214 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 21:53:28 +00:00
Helen Hou-Sandi
cb2ea6501a Fix jshint errors introduced in [29212]. see #28842.
git-svn-id: https://develop.svn.wordpress.org/trunk@29213 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 20:45:09 +00:00
Helen Hou-Sandi
e391aa228a Media Grid:
Instead of a separate bulk selection mode, persistently show a checkbox for each item. Restores the more familiar bulk actions dropdown + action button.

props ericlewis. see #28842.



git-svn-id: https://develop.svn.wordpress.org/trunk@29212 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 20:41:40 +00:00
Andrew Ozz
e4762df523 TinyMCE: include 709266e308 that fixes the UI state updates for the "link" button. See #28576.
git-svn-id: https://develop.svn.wordpress.org/trunk@29211 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 19:30:41 +00:00
Sergey Biryukov
750c310565 Twenty Fourteen: Remove unused variable after [27120].
props michalzuber.
fixes #28928.

git-svn-id: https://develop.svn.wordpress.org/trunk@29210 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 19:08:05 +00:00
Scott Taylor
f59a307e10 Merge wp_handle_upload() and wp_handle_sideload() by making them each wrap a new function: _wp_handle_upload().
Props DrewAPicture for docs.
Fixes #23686.


git-svn-id: https://develop.svn.wordpress.org/trunk@29209 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 18:57:26 +00:00
Scott Taylor
5e1556a4ce After [29106], check for data.meta before attempting to render data.meta.bitrate.
See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29208 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 17:41:06 +00:00
Scott Taylor
753a60c709 After [29197], use ! empty() instead of isset(). Don't call has_shortcode() internally twice if it's true.
Props kovshenin.
Fixes #26343.


git-svn-id: https://develop.svn.wordpress.org/trunk@29207 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 17:37:51 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Drew Jaynes (DrewAPicture)
161266c17d Fix syntax for single- and multi-line comments in root-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29205 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:11:46 +00:00
Helen Hou-Sandi
fdabfafa0f Media Grid Attachment Details modal UI improvements:
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.

Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.

props ericlewis, helen, melchoyce. see #28844. fixes #28915.


git-svn-id: https://develop.svn.wordpress.org/trunk@29204 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 03:54:44 +00:00
Andrew Ozz
db9a148b34 TinyMCE:
- Update to 4.1.2, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt
- Update the tests to 4.1.2.
Fixes #28576.

git-svn-id: https://develop.svn.wordpress.org/trunk@29203 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 00:58:41 +00:00
Andrew Ozz
50f7313fdd TinyMCE wpView: prevent fatal (security) errors when trying to access iframe.contentWindow in pausePlayers() and unsetPlayers(). See #28905.
git-svn-id: https://develop.svn.wordpress.org/trunk@29202 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 00:49:11 +00:00
Scott Taylor
283fa473e6 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
Props joedolson.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29201 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:49:53 +00:00
Scott Taylor
bda6f0cffe Properly set $subdomain_error to false when applicable in ms_subdomain_constants(). This was previously untestable because it used static vars: use globals instead.
Adds unit test.
Fixes #28697.


git-svn-id: https://develop.svn.wordpress.org/trunk@29200 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:34:18 +00:00
Drew Jaynes (DrewAPicture)
8a5d825fac Fix a typo in the @access tag for WP_List_Table::__get().
Props joehoyle.
Fixes #28925. See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29199 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:12:11 +00:00
Scott Taylor
e7e0aa5a42 Make sure that the ready event only fires once for relevant MCE views that are sandbox'd in iframes. Move some editor callbacks to initialize.
Props avryl.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29198 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:09:13 +00:00
Scott Taylor
17d67d93e7 Make has_shortcode() recursive/work for nested shortcodes.
Adds unit test.

Props katzwebdesign.
Fixes #26343.


git-svn-id: https://develop.svn.wordpress.org/trunk@29197 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:04:08 +00:00
Scott Taylor
722930611c Avoid a race condition when multiple windows are open so that orphaned terms cannot be created by accident.
Adds a unit test.

Props dlh.
Fixes #19205.


git-svn-id: https://develop.svn.wordpress.org/trunk@29196 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 21:51:40 +00:00
Andrew Ozz
0e3aac5016 TinyMCE: fix aligncenter for html5-captions, props obenland, fixes #28681.
git-svn-id: https://develop.svn.wordpress.org/trunk@29195 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 21:27:54 +00:00
Scott Taylor
977b4a7c26 Cleanup after [29179]:
* Remove `wp.media.mixin.pauseAllPlayers()` - was only ever intended to be used in MCE views, reaches too far into global scope. Rendered irrelevant since [28364].
* Remove `wp.media.mixin.pausePlayers()` - added in [28364]. MCE views no longer keep track of player instances and call mixin methods, they refer to their child iframes and call MEjs methods on the iframe's `window.mejs.players`. 

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29194 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 19:35:55 +00:00
Scott Taylor
aa10b9f67b Cleanup after [29179]:
Don't attach nodes to the view instance and check if the iframe still exists before resizing.

Props avryl.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29193 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 19:31:30 +00:00
Andrew Ozz
67c5474701 Autosave: always expose the wp.autosave.local methods, fixes #28924.
git-svn-id: https://develop.svn.wordpress.org/trunk@29192 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 18:33:03 +00:00
Scott Taylor
72c8cf3233 Cleanup after [29179]:
* Pause players when media is edited via modal
* Remove players on unind
* Account for failure when an empty node is passed to an `mce.view.View`

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29191 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 18:18:18 +00:00
Andrew Ozz
fa4ed6e062 TinyMCE wpView: add noop() when returning early, fixes #28921
git-svn-id: https://develop.svn.wordpress.org/trunk@29190 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 17:55:00 +00:00
Scott Taylor
f071e710c2 Cleanup after [29179]:
* Cleanup players when the editor is hidden - window scope is unique to each frame
* Add the editor body class to each iframe sandbox
* Remove unneeded code from `wp-mediaelement.js`

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29189 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 16:13:47 +00:00
Andrew Nacin
9452f31220 DB schema change: Add comment_author_email(10) index.
props tellyworth, pento.
fixes #21435.


git-svn-id: https://develop.svn.wordpress.org/trunk@29188 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 15:53:14 +00:00
Scott Taylor
7e05c69ce2 Cleanup after [29179]:
* `_WP_Editors::editor_settings()` no longer needs to load MEjs styles
* Make sure each identical shortcode with multiple instances also has an iframe sandbox for each instance
* For the time being, make audio and video shortcodes bypass the loading placeholder to avoid whiplash visually

Props avryl, wonderboymusic.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29187 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 15:39:05 +00:00
Andrew Ozz
09f5183276 Editor scrolling: better "scroll into view" in the visual editor. Don't override MCE path focus style. Props avryl, see #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29186 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 04:05:13 +00:00
Andrew Ozz
850d8eb69e Editor scrolling: on setcontent, resize the editor after some delay to allow the browser to render the content. Props avryl, see #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29185 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 02:29:53 +00:00
Andrew Ozz
a90e8c6ff2 TinyMCE wpView: handle execCommand when the "fake caret" P is selected, props avryl, see #28595
git-svn-id: https://develop.svn.wordpress.org/trunk@29184 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 02:18:18 +00:00
Andrew Ozz
76c3055aec TinyMCE wpView:
- Cast off commands targeted to a view except undo, redo, RemoveFormat and mceToggleFormat (bold, italic, etc.).
- Disable the link and unlink buttons when a view is selected.
Props avryl, see #28595

git-svn-id: https://develop.svn.wordpress.org/trunk@29183 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 00:09:58 +00:00
Andrew Ozz
e7b7e3fa44 TinyMCE wpView: remove unused code, props avryl, see #28595
git-svn-id: https://develop.svn.wordpress.org/trunk@29182 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 23:38:33 +00:00
Lance Willett
aa163fdee3 Twenty Thirteen: make small-screen menu accessible to keyboard commands and voice-driven software by using a focusable button element rather than h3 for the toggle element. Fixes #28293, props rclations and obenland.
git-svn-id: https://develop.svn.wordpress.org/trunk@29181 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 23:09:41 +00:00
azaozz
12ebd89657 Editor scrolling: also disable in IE < 9. See #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29180 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:36:02 +00:00
Scott Taylor
cba1ae06af Simplify creation of audio, video, and playlist MCE views by placing them in iframe sandboxes.
Wins:
* Eliminates duplication of code between PHP and JS
* Views can load JS without messing with TinyMCE and scope
* MEjs doesn't break when it loads a file plugin-mode. This allows any file type the MEjs supports to play in MCE views.
* YouTube now works as the source for video.
* Users can still style the views, editor stylesheets are included in these sandboxes.
* Audio and Video URLs and `[embed]`s are no longer broken.
* Remove the crazy compat code necessary to determine what file types play in what browser.
* Remove unneeded Underscore templates.
* Remove the compat code for playlists.

See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29179 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:17:58 +00:00
Scott Taylor
9e573243cf Add a new AJAX action: parse-media-shortcode. This async call will replace JS rendering of audio/video/playlist shortcodes.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29178 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:07:16 +00:00