Commit Graph

4812 Commits

Author SHA1 Message Date
Scott Taylor
884d27ea00 Fill in the @param types for the args for functions missing them in wp-admin/includes/plugin.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30199 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:58:14 +00:00
Scott Taylor
8ddca875b5 Fill in the @param types for the args for functions missing them in wp-admin/includes/post.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30198 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:54:04 +00:00
Scott Taylor
53df5b1a61 Fill in the @param types for the args for functions missing them in wp-admin/includes/taxonomy.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30197 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:49:57 +00:00
Scott Taylor
43d027f2af Fill in the @param types for the args for functions missing them in wp-admin/includes/template.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30196 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:44:33 +00:00
Scott Taylor
aff2817015 Fill in the @param types for the args for make_site_theme_from_default().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30195 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:42:06 +00:00
Scott Taylor
00d5b388c3 Fill in the @param types for the args for make_site_theme_from_oldschool(), which is actually the name of a function?
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30194 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:40:30 +00:00
Scott Taylor
fa5b45c42a Fill in the @param types for the args for dbDelta().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30193 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:39:08 +00:00
Scott Taylor
d3d38505ea Fill in the @param types for the args in WP_Text_Diff_Renderer_Table->interleave_changed_lines().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30192 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:38:34 +00:00
Scott Taylor
2443090c23 Correct the @param type for the $query arg for remove_query_arg().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30191 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:28:47 +00:00
Scott Taylor
7ea8e0cb6a Fill in types for the @params for wp_comment_reply().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30190 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:20:43 +00:00
Scott Taylor
30e637cd93 Correct type in the doc block for get_theme_support().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30189 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:17:05 +00:00
Scott Taylor
cd8f6b881c Correct the return value doc block for get_theme_support().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30188 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:16:33 +00:00
Scott Taylor
c502804272 In Custom_Image_Header:
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403]. 
* Declare `$updated` as a property.

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30187 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:14:11 +00:00
Scott Taylor
19eb835aee In Custom_Background, declare $updated as a property.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30186 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:07:49 +00:00
Scott Taylor
3663a276f1 In wp_audio|video_shortcode(), make sure that autoplay and loop are booleans. Passing 'false' to them will force them to be active, which is bad.
Fixes #29825.


git-svn-id: https://develop.svn.wordpress.org/trunk@30185 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:02:18 +00:00
Scott Taylor
152e977a6b In WP_Tax_Query, declare $primary_table and $primary_id_column as properties.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30184 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:44:54 +00:00
Scott Taylor
4c74c4a298 In WP_Locale, declare $number_format as a property.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30183 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:39:01 +00:00
Scott Taylor
bfa6702145 In WP_Comment_Query, declare $query_vars and $comments as properties.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30182 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:07:42 +00:00
Scott Taylor
43d5210cfa Almost every method in wp_xmlrpc_server can also return IXR_Error and should be labeled as such. Rehabilitate some return syntax.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30181 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 03:03:30 +00:00
Scott Taylor
345a63f498 WP_Image_Editor_GD and WP_Image_Editor_Imagick should specify type in a doc block for the $image property, instead of inferring bool and null.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30180 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 02:37:55 +00:00
Scott Taylor
204bab92c2 In WP_HTTP_IXR_Client:
* declare `$scheme` as a property, it doesn't exist on the parent class
* declare `$error` as a property of type `IXR_Error`, instead of it being inferred as `boolean` from the parent class

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30179 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 02:31:39 +00:00
Scott Taylor
31df6204d0 Fix the return docs for WP_Embed->maybe_make_link().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30178 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 02:26:34 +00:00
Jeremy Felt
90aa65e0f7 Use common core syntax for checking DOING_AJAX
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891


git-svn-id: https://develop.svn.wordpress.org/trunk@30177 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-02 02:23:28 +00:00
Jeremy Felt
47e01357aa Delete admin_created_user_subject() rather than deprecate
As it was never used as anything more than a callback to a filter before the MU merge, and is only available in user-new.php in multisite, it is safe to remove this function entirely.

Fixes #29915


git-svn-id: https://develop.svn.wordpress.org/trunk@30176 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-02 02:06:20 +00:00
Scott Taylor
105cd50bdf In _WP_Editors::editor_settings(), $str1 and $str2 don't need to be initialized empty.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30173 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:21:07 +00:00
Scott Taylor
b808e1af70 Declare the $uploaded_headers and $default_headers properties for WP_Customize_Header_Image_Control.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30172 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:17:48 +00:00
Scott Taylor
7acb2c8eb1 Declare the $update_count and $update_current properties for WP_Upgrader.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30171 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:06:38 +00:00
Scott Taylor
729bd580ab Declare the $options property for WP_Upgrader_Skin.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30170 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:02:52 +00:00
Scott Taylor
bb9f04baa8 Fix the return value doc for WP_List_Table->get_pagination_arg().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30169 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:59:48 +00:00
Scott Taylor
c50eaf3b0d In wp_ajax_get_tagcloud(), bail immediately if $_POST['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30168 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:53:35 +00:00
Scott Taylor
ce6a31c5fe In wp_ajax_ajax_tag_search(), bail immediately if $_GET['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30167 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:47:27 +00:00
Scott Taylor
e5ad640c52 In get_the_pagination(), don't pass $links to _navigation_markup() if it is not a string - paginate_links() can return an array.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30166 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:40:17 +00:00
Scott Taylor
4e68f104f6 Make the docs type for return in wpmu_create_user() more specific.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30165 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:33:00 +00:00
Scott Taylor
b4d0961718 In customize.php, check that $autofocus is an array after running wp_unslash() instead of before. This is admittedly to skip a traversable hint in Scrutinizer.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30164 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:16:19 +00:00
Scott Taylor
64f773e4da In WP_Meta_Query->get_sql_for_clause(), the empty initialization of $where is dead code and can be removed.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30163 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:02:48 +00:00
Scott Taylor
5f09d235f0 In _wp_json_convert_string(), when $use_mb is false, perhaps pass a variable that actually exists to wp_check_invalid_utf8().
Introduced in [30055].
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30162 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 21:59:58 +00:00
Scott Taylor
143d248292 In gallery_shortcode(), when the link attribute is equal to file, make sure to pass $attr as the 6th (!) argument, not 5th, to wp_get_attachment_link().
Props bradyvercher.
Fixes #27402.


git-svn-id: https://develop.svn.wordpress.org/trunk@30161 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 21:46:51 +00:00
Scott Taylor
4315c9c5c3 Allow get_pages(), with child_of passed to it, to work with interrupted hierarchies.
Adds unit test.
Fixes #18962.


git-svn-id: https://develop.svn.wordpress.org/trunk@30159 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:43:55 +00:00
Scott Taylor
59658c6547 All duplicate slugs across different post types.
Adds unit test.

Props mboynes, nacin.
Fixes #18962.


git-svn-id: https://develop.svn.wordpress.org/trunk@30158 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:36:23 +00:00
Scott Taylor
03b49d8f88 Check $_current_page before using it in Walker_Page->start_el().
Props jeremyfelt.
Fixes #26901.


git-svn-id: https://develop.svn.wordpress.org/trunk@30157 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:28:40 +00:00
Scott Taylor
bdf71f89ad Display error message when Media Library upload fails.
Props gcorne.
Fixes #29891.


git-svn-id: https://develop.svn.wordpress.org/trunk@30156 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:24:13 +00:00
Scott Taylor
c8acddfdc8 Improve some post_status-related documentation.
Props ericlewis.
See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30155 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:19:26 +00:00
Scott Taylor
c171bb4aae In WP_List_Table, add a property, $modes, to allow WP_Media_List_Table to inherit ->view_switcher().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30154 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 19:55:26 +00:00
Scott Taylor
f759c23d31 In wp_xmlrpc_server methods, for comprehensibility:
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30153 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 19:44:07 +00:00
Drew Jaynes (DrewAPicture)
ab0324a729 Fix a couple of spacing and wrapping indents in the WP_Date_Query::__construct() hash notation.
See [30142]. See #28063.


git-svn-id: https://develop.svn.wordpress.org/trunk@30150 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 04:31:00 +00:00
Drew Jaynes (DrewAPicture)
43b3515501 Relocate hook docs so they directly precede the hook lines moved into foreach statements in [30140].
It's necessary for hook docs to directly precede hook lines so the parser can correctly match them up. This change relocates hook docs for `update_{$meta_type}_meta`, `update_postmeta`, `updated_{$meta_type}_meta`, and `updated_postmeta`.

Fixes #11683.


git-svn-id: https://develop.svn.wordpress.org/trunk@30149 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 04:17:28 +00:00
Lance Willett
2ade0b964a Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names.
Props slobodanmanic, fixes #28703.


git-svn-id: https://develop.svn.wordpress.org/trunk@30147 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:46:08 +00:00
Lance Willett
7f5058ac80 Twenty Fourteen: fix keyboard focus on Appearance > Header view.
Props florianziegler, fixes #29787.


git-svn-id: https://develop.svn.wordpress.org/trunk@30146 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:43:25 +00:00
Lance Willett
9eb6f6f7fe Twenty Ten and Eleven: don't display modified excerpt link in wp-admin.
Props kraftbj, fixes #30026.


git-svn-id: https://develop.svn.wordpress.org/trunk@30145 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:39:04 +00:00
Boone Gorges
09a1a6f5e6 Improve default argument formatting in WP_Date_Query::__construct().
git-svn-id: https://develop.svn.wordpress.org/trunk@30144 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:28:11 +00:00
Lance Willett
cbe8e288d4 Twenty Fourteen: Make featured content in Customizer contextual to the front page.
Props celloexpressions, fixes #29578.


git-svn-id: https://develop.svn.wordpress.org/trunk@30143 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:25:43 +00:00
Boone Gorges
7c64b3b3dd Introduced dayofweek_iso time param for WP_Date_Query.
The initial `dayofweek` param sets day 1 to Sunday. This is out of step with
ISO standards, which calls Monday day 1. To maintain backward compatibility
with the existing parameter, we introduce the new `dayofweek_iso` for the
new, more compliant param.

Props mboynes.
Fixes #28063.

git-svn-id: https://develop.svn.wordpress.org/trunk@30142 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 03:23:15 +00:00
Boone Gorges
d6b7b7aa41 Allow resource_type to be specified in get_ancestors().
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.

Props filosofo.
Fixes #15029.

git-svn-id: https://develop.svn.wordpress.org/trunk@30141 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 02:57:31 +00:00
Boone Gorges
8dbaaf9927 Pass all updated meta IDs to filters in update_metadata().
Props wonderboymusic.
Fixes #11683.

git-svn-id: https://develop.svn.wordpress.org/trunk@30140 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 02:38:19 +00:00
Scott Taylor
17e9c6f403 In wp_xmlrpc_server->pingback_ping(), remove the internal variable $way each time it is set and not used.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30139 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:49:26 +00:00
Scott Taylor
eb05767743 In wp_xmlrpc_server methods, don't set $blog_id internally if it is never used, which is almost always. Updates the docs.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30138 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:43:41 +00:00
Scott Taylor
842d9bc5cf In wp_xmlrpc_server->_prepare_comment(), $comment_date is set internally but never used.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30137 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:28:18 +00:00
Scott Taylor
334fc5b9f2 In Custom_Image_Header->step_2(), $type is set internally but never used.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30136 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:23:50 +00:00
Boone Gorges
086f2b9dbd Fix database schema update introduced in [30121].
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30134 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:10:04 +00:00
Scott Taylor
ff4f545fc9 [28785] introduced a bug, where encoded query arguments were decoded by parse_str() inside of wp_parse_str() but never re-encoded later on.
This encodes them, adds unit test.

Props obenland.
Fixes #29636.


git-svn-id: https://develop.svn.wordpress.org/trunk@30133 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:53:26 +00:00
Scott Taylor
0ae3ac0c05 Revisions modules should not rely on global settings:
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax

Props ericlewis, wonderboymusic.
Fixes #30219.


git-svn-id: https://develop.svn.wordpress.org/trunk@30131 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:38:21 +00:00
Scott Taylor
8d2595d7ff Set revision.settings via short-circuit check for window property: window._wpRevisionsSettings || {}
Props ericlewis.
Fixes #30218.


git-svn-id: https://develop.svn.wordpress.org/trunk@30130 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:19:17 +00:00
Scott Taylor
ee56980498 Add a single responsibility function for outputting Revisions JS templates: wp_print_revision_templates().
Use it in `wp-admin/revision.php`.

Props ericlewis.
Fixes #30220.


git-svn-id: https://develop.svn.wordpress.org/trunk@30129 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:14:45 +00:00
Scott Taylor
c684779022 Allow revision Backbone classes to be used on pages other than revision.php.
Props ericlewis.
Fixes #30221.


git-svn-id: https://develop.svn.wordpress.org/trunk@30128 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:07:34 +00:00
Scott Taylor
55613648fd Add some JSDoc blocks to revisions.js.
Props ericlewis.
See #30222.



git-svn-id: https://develop.svn.wordpress.org/trunk@30127 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 23:54:50 +00:00
Dominik Schilling (ocean90)
40adc7ae16 Customizer: Improve ColorControl's wpColorPicker to update UI based on setting changes.
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.

props westonruter.
fixes #30031.

git-svn-id: https://develop.svn.wordpress.org/trunk@30126 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:44:19 +00:00
Scott Taylor
3aa5dc35f1 JSHint after [30124].
git-svn-id: https://develop.svn.wordpress.org/trunk@30125 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:37:50 +00:00
Scott Taylor
04c3ee3045 JSHint after [30120].
git-svn-id: https://develop.svn.wordpress.org/trunk@30124 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:34:39 +00:00
Dominik Schilling (ocean90)
e871e28c5c Fix JSHint errors introduced in [30120].
see #30193.

git-svn-id: https://develop.svn.wordpress.org/trunk@30123 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 20:27:41 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd Correct references of @uses $wpdb in core documentation to use @global.
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Boone Gorges
5073448de6 Bump db_version and add upgrade routine for schema change in [30056].
Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30121 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 16:02:08 +00:00
Scott Taylor
7f5e8bd7e8 Add verbose docs to media-views.js.
Props ericlewis.
See #30193.


git-svn-id: https://develop.svn.wordpress.org/trunk@30120 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 15:19:58 +00:00
Drew Jaynes (DrewAPicture)
c614b0f91a Correct two parameter types in the wp_save_post_revision_check_for_changes hook documentation.
Props johnbillion.
Fixes #30185.


git-svn-id: https://develop.svn.wordpress.org/trunk@30119 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 23:49:43 +00:00
Sergey Biryukov
f9dc501655 Use correct file name in a hook comment.
props wedi.
fixes #30200.

git-svn-id: https://develop.svn.wordpress.org/trunk@30117 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 18:34:03 +00:00
Sergey Biryukov
b2672f5772 Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development.
fixes #30137.

git-svn-id: https://develop.svn.wordpress.org/trunk@30116 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 11:56:03 +00:00
Boone Gorges
9a84da90c3 Unserialize get_metadata() results when 'key' is omitted.
Props mattkeys, nacin.
Fixes #15030.

git-svn-id: https://develop.svn.wordpress.org/trunk@30115 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 10:24:22 +00:00
Drew Jaynes (DrewAPicture)
325c0622c9 Update the changelogs for the comment hook parameters added in [30092].
Parameters were added to the `get_comment_author`, `comment_author`, `get_comment_author_email`, `author_email`, `comment_email`, `get_comment_author_link`, `get_comment_author_IP`, `get_comment_author_url`, `comment_url`, `get_comment_excerpt`, `comment_excerpt`, `get_comment_ID`, and `get_comment_type` filters.

Fixes #22380.


git-svn-id: https://develop.svn.wordpress.org/trunk@30111 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 03:51:28 +00:00
Drew Jaynes (DrewAPicture)
dfe2224b5c Update the changelog for WP_Comment_Query::query() to reflect two more new arguments added in [30096].
[30096] introduced the `type__in` and `type__not_in` arguments. See #30111 for documentation on those new arguments.

Fixes #12668.


git-svn-id: https://develop.svn.wordpress.org/trunk@30110 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 03:05:29 +00:00
Drew Jaynes (DrewAPicture)
b2ec3c4303 Update the changelog for get_approved_comments() to reflect that the function was refactored to leverage WP_Comment_Query in [30098].
Also updates the `$args` parameter description with a reference to see `WP_Comment_Query` for argument information.

See #12668.


git-svn-id: https://develop.svn.wordpress.org/trunk@30109 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 02:50:16 +00:00
Boone Gorges
6a7443671b Clean up get_term_by() caching.
* Fix cache key/group modification that was missed in [30073].
* Update unit tests to reflect new key/group format.

Props tollmanz.
Fixes #21760.

git-svn-id: https://develop.svn.wordpress.org/trunk@30108 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 02:49:51 +00:00
Boone Gorges
cf1d77c101 In get_terms(), do not override 'hierarchical' and 'pad_counts' when 'parent' is present.
The previous behavior resulted in descendant terms being improperly excluded
from the results when passing a 'parent', even when 'hierarchical' had been
set to true.

The patch also adds unit tests that demonstrate the various interactions
between the 'child_of', 'parent', and 'hierarchical' parameters of `get_terms()`.

Props landakram.
Fixes #29815.

git-svn-id: https://develop.svn.wordpress.org/trunk@30107 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 02:11:56 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
Dominik Schilling (ocean90)
e999d15f44 Customizer: Fix missing newly added widgets in the preview after [29905].
props westonruter.
fixes #29983.

git-svn-id: https://develop.svn.wordpress.org/trunk@30104 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:56:53 +00:00
Ian Stewart
3f36fb3a30 Twenty Fifteen: back compat checks in Twenty Fifteen are breaking the customizer, leaving them in for now, but commented out.
See #30137.


git-svn-id: https://develop.svn.wordpress.org/trunk@30103 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:51:11 +00:00
Dominik Schilling (ocean90)
90182015e7 Improve/introduce Customizer JavaScript models for Controls, Sections, and Panels.
* Introduce models for panels and sections.
* Introduce API to expand and focus a control, section or panel.
* Allow deep-linking to panels, sections, and controls inside of the Customizer.
* Clean up `accordion.js`, removing all Customizer-specific logic.
* Add initial unit tests for `wp.customize.Class` in `customize-base.js`.

https://make.wordpress.org/core/2014/10/27/toward-a-complete-javascript-api-for-the-customizer/ provides an overview of how to use the JavaScript API.

props westonruter, celloexpressions, ryankienstra.
see #28032, #28579, #28580, #28650, #28709, #29758.
fixes #29529.



git-svn-id: https://develop.svn.wordpress.org/trunk@30102 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:50:21 +00:00
Mark Jaquith
037e00fb15 Fix weird HiDPI screen rendering issue with theme install preview toolbar
fixes #28898
props ocean90

git-svn-id: https://develop.svn.wordpress.org/trunk@30101 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:35:27 +00:00
Dominik Schilling (ocean90)
15af3fdaa8 Improve body class for page templates.
* Convert slash to dash too.
* Add sub-folder name as a separate body class.
* New classes are additional classes, old syntax will persists for BC.

With this `/page-templates/full-width.php` will produce `page-template`, `page-template-page-templates`, `page-template-full-width` and `page-template-page-templatesfull-width-php`.

props obenland, Caspie, donutz.
fixes #23470.

git-svn-id: https://develop.svn.wordpress.org/trunk@30100 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:19:08 +00:00
Ian Stewart
f6544f237a Twenty Fifteen: avoid errors by preventing Twenty Fifteen from being activated in old versions of WordPress
Props iamtakashi, fixes #30137.



git-svn-id: https://develop.svn.wordpress.org/trunk@30099 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 22:13:14 +00:00
Boone Gorges
f9e32aef2d Use WP_Comment_Query to query comments in get_approved_comments().
Props dancameron.
See #12668.

git-svn-id: https://develop.svn.wordpress.org/trunk@30098 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 21:57:07 +00:00
Ian Stewart
192e1aac62 Twenty Fifteen: leading the way with support for title-tag
Props obenland, fixes #30146.



git-svn-id: https://develop.svn.wordpress.org/trunk@30097 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 21:55:24 +00:00
Boone Gorges
bd795a3d16 Better flexibility for 'type' in WP_Comment_Query.
* Add support for an array of values in 'type'.
* Introduce `type__in` parameter. This duplicates 'type' but is added for better consistency with other query classes.
* Introduce `type__not_in`.

Among other things, these changes will make it easier for plugin authors to
manage the appearance of custom comment types in various WP interfaces.

Props dancameron, mordauk.
See #12668.

git-svn-id: https://develop.svn.wordpress.org/trunk@30096 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 21:49:08 +00:00
John Blackbourn
6fcb1bf817 Add a hidden submit button to the Appearance -> Header screen so keyboard users can submit the form correctly when a default image provided by the theme is in use.
Fixes #20880.
Props kovshenin, joedolson.


git-svn-id: https://develop.svn.wordpress.org/trunk@30095 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 21:40:58 +00:00
Konstantin Kovshenin
6debe759a6 Use a nested meta query when querying by role in WP_User_Query.
If a user query includes a meta query together with a role argument,
nest the original meta query and append the role meta query with an
AND relationship.

fixes #23849, #27026.


git-svn-id: https://develop.svn.wordpress.org/trunk@30094 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 21:40:04 +00:00
Boone Gorges
555d7347f9 Support an empty string passed as a status in WP_Comment_Query.
The changes in [30084] broke backward compatibility with interfaces that
manually passed an empty string for the value of 'status', such as on
wp-admin/edit-comments.php.

Fixes #29612.

git-svn-id: https://develop.svn.wordpress.org/trunk@30093 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 19:50:31 +00:00
Peter Westwood
ed19e5a1f3 Comment Template Tags: Improve the availability of context information in comment template tag filters.
Fixes #22380 props momo360modena, tareq1988.


git-svn-id: https://develop.svn.wordpress.org/trunk@30092 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 19:07:00 +00:00
John Blackbourn
32d38fc080 Introduce some actions and filters which aid plugins in revisioning post meta.
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
 * `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
 * `wp_creating_autosave` action which is fired just before an autosave is created.

See #20564.
Props mattheu, adamsilverstein.


git-svn-id: https://develop.svn.wordpress.org/trunk@30091 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 19:01:15 +00:00
John Blackbourn
1767706fc2 Revert [28610] in order to avoid infinite redirect loops on reverse proxies which proxy from HTTPS to HTTP. This will be revisited at some point, possibly as an option via a filter.
Fixes #28610.


git-svn-id: https://develop.svn.wordpress.org/trunk@30090 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 18:36:41 +00:00
Mark Jaquith
7f0f887357 Increase both mystery and humanism
git-svn-id: https://develop.svn.wordpress.org/trunk@30089 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 03:19:45 +00:00
Boone Gorges
c3a3fc5a79 Introduce 'pre_delete_term' hook.
Props cmmarslender.
Fixes #30127.

git-svn-id: https://develop.svn.wordpress.org/trunk@30088 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 02:43:33 +00:00
John Blackbourn
d62320bff5 Correct some logic to populate the defaultValue variable when data.defaultValue begins with a hash symbol.
Props antpb
Fixes #30125


git-svn-id: https://develop.svn.wordpress.org/trunk@30087 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 02:42:35 +00:00
Boone Gorges
e36f06a87f Be more specific in documentation of 'slug' param for get_terms().
Props jfarthing84.
Fixes #23636.

git-svn-id: https://develop.svn.wordpress.org/trunk@30086 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 02:34:56 +00:00
Boone Gorges
114c1f32ba Improve global variable setting in setup_postdata().
`setup_postdata()` is responsible for setting a number of global variables
that are used for post pagination (`$pages`, `$page`, `$nextpage`) and the
generation of post excerpts (`$more`). These variables should be sensitive to
the currently running instance of `WP_Query` - rather than the main query -
so that these features work properly inside of secondary `WP_Query` loops.

This changeset moves the logic of `setup_postdata()` into a method on `WP_Query`,
and converts `setup_postdata()` to a wrapper.

Props boonebgorges, wonderboymusic.
See #25349.
Fixes #9256, #20904.

git-svn-id: https://develop.svn.wordpress.org/trunk@30085 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 02:31:37 +00:00
Boone Gorges
7c4aada4a6 Support multiple 'status' values in WP_Comment_Query.
This change required turning the SQL concatenation into the generation of an
array, for greater flexibility.

Props karpstrucking, ebinnion.
Fixes #29612.

git-svn-id: https://develop.svn.wordpress.org/trunk@30084 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 02:21:10 +00:00
Scott Taylor
5569f01459 Allow developers to override the settings.success callback for MediaElement players.
Props nofearinc.
Fixes #30029.


git-svn-id: https://develop.svn.wordpress.org/trunk@30083 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 01:20:03 +00:00
Scott Taylor
e6bbbb3db9 Don't hardcode height for videos - this was a workaround for MediaElement internals causing problems. Responsive videos now work properly and don't cause extra whitespace.
Fixes MediaElement by hand in the interim: https://github.com/johndyer/mediaelement/pull/1337
Video playlists were completely broken by this.

Fixes #30078.



git-svn-id: https://develop.svn.wordpress.org/trunk@30082 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 00:46:15 +00:00
Lance Willett
acbf0229cf Twenty Fifteen: only escape HTML attribute output with esc_attr(). See #30133, props ocean90.
git-svn-id: https://develop.svn.wordpress.org/trunk@30081 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 23:07:32 +00:00
Aaron Jorbin
233946b852 Update images based on grunt imagemin
The new version of imagemin that was added in r30059 condenses some images more.

see #30141



git-svn-id: https://develop.svn.wordpress.org/trunk@30079 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 22:01:12 +00:00
Mark Jaquith
42456d35fd Docs and code standards cleanup for [30055] (wp_json_encode() & friends)
fixes #28786
props TobiasBg

git-svn-id: https://develop.svn.wordpress.org/trunk@30078 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:28:34 +00:00
Boone Gorges
0cbc8098d2 Update inline docs for [30052].
Fixes #23261.

git-svn-id: https://develop.svn.wordpress.org/trunk@30077 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:25:30 +00:00
Scott Taylor
45a635d8c2 In _wp_handle_upload(), if test_upload is set to false in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage.
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.

`$test_upload` override is now a noop.

Fixes #28208.


git-svn-id: https://develop.svn.wordpress.org/trunk@30076 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:16:06 +00:00
Mark Jaquith
52151956ea Define JSON_PRETTY_PRINT so it can be used with wp_json_encode()
* `JSON_PRETTY_PRINT` was introduced in PHP 5.4
* Now you can use it with lower PHP versions, without a notice

fixes #30139
see #28786

git-svn-id: https://develop.svn.wordpress.org/trunk@30075 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:12:10 +00:00
John Blackbourn
efb9cd0cc5 Introduce a new means of outputting a <title> tag in the theme head. Requires a theme to add support by calling add_theme_support( 'title-tag' ). This is the first step in adding a more robust means of generating and outputting the title tag.
See #18548.
Props obenland, chrisbliss18, joostdevalk.



git-svn-id: https://develop.svn.wordpress.org/trunk@30074 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:11:11 +00:00
Scott Taylor
1e8635fcea Adjust caching for get_term_by() calls:
* Remove md5 hashes for term name cache keys
* Remove the namespace for the keys for `names` and `slugs` and add them to the group names
* Remove `wp_get_last_changed()`, which @nacin hated
 
Props tollmanz.
Fixes #21760.


git-svn-id: https://develop.svn.wordpress.org/trunk@30073 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:04:52 +00:00
iandstewart
e5275dcedb Twenty Fifteen: Use a heading heirarchy to provide a better navigation experience when using screenreading software.
Props davidakennedy, rianrietveld, iamtakashi, afercia, davidakennedy, fixes #30065.


git-svn-id: https://develop.svn.wordpress.org/trunk@30072 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:02:02 +00:00
Jeremy Felt
d80d1c2ffe Introduce wp_is_trusted_network()
A first step to establish concepts around trusted and untrusted networks.

* Will always return false as default.
* Will one day have a filter.

Fixes #30145


git-svn-id: https://develop.svn.wordpress.org/trunk@30071 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 20:55:39 +00:00
Aaron Jorbin
7ca2e674cd Autoprefix box sizing
Results are from running grunt autoprefix.  Needed for FF before 29 and Safari before 5.1.

fixes #27553



git-svn-id: https://develop.svn.wordpress.org/trunk@30070 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 20:47:30 +00:00
Scott Taylor
74ed2089b4 The gallery shortcode used to accept a SQL chunk for the value of the orderby attribute. The reason? get_posts() used to be called in the shortcode handler with a query-string blob of arguments passed to it. To mitigate breakage, sanitize_sql_orderby() was created in [7592].
`sanitize_sql_orderby()` expects a comma to be present when multiple `orderby` values were passed. The correct syntax for multiple fields is space-delimited. Since [29027], comma-separated values would never be parsed correctly when passed to `WP_Query->parse_orderby()`.

`sanitize_sql_orderby()` is used nowhere else in core, save for the `playlist` shortcode - I only added it there because I was mimic'ing the `gallery` logic. The function call can be removed from both shortcode handlers.
 
See #6476.
Fixes #23873.


git-svn-id: https://develop.svn.wordpress.org/trunk@30068 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 20:42:20 +00:00
John Blackbourn
f08525846a Introduce some new template functions for navigation:
* `get_the_post_navigation()` and `the_post_navigation()` for navigation to the next and previous post.
 * `get_the_posts_navigation() and `the_posts_navigation()` for navigation to the next and previous page of posts.
 * `get_the_pagination()` and `the_pagination()` for paginated navigation between pages of posts. Uses `paginate_links()`.

This reduces the need for themes to define their own sets of navigation functions.

Fixes #29808.
Props obenland.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@30065 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 19:38:41 +00:00
Scott Taylor
159423cef9 Add audio, video, and track to $allowedposttags (KSES).
Props jwenerd, wonderboymusic. 
Fixes #29826.


git-svn-id: https://develop.svn.wordpress.org/trunk@30064 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 19:35:17 +00:00
Gary Pendergast
d871bf86ca Fix a PHPDoc typo for wp_json_encode().
Props JustinSainton.

See #28786.


git-svn-id: https://develop.svn.wordpress.org/trunk@30058 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:53:10 +00:00
Boone Gorges
ad4aa0b7e0 Remove UNIQUE key from 'slug' column of terms table.
Each slug is a unique and beautiful snowflake, but let's enforce that
uniqueness elsewhere.

Props hotchkissconsulting.
Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30056 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:36:57 +00:00
Gary Pendergast
0e68ecc0b6 Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8.
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.



git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:34:16 +00:00
John Blackbourn
3d35d8bc5d Add a missing Oxford comma to the install screen. Fixes #30107. Props Ankit K Gupta.
git-svn-id: https://develop.svn.wordpress.org/trunk@30054 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:31:19 +00:00
John Blackbourn
105b60bd0b Make the Twenty Fifteen search form submit button screen reader accessible rather than hidden to all users. Fixes #30110. Props mattweibe, rianrietveld.
git-svn-id: https://develop.svn.wordpress.org/trunk@30053 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:13:19 +00:00
Boone Gorges
6df24465f4 Introduce orderby=include support for get_terms().
Props wpsmith.
Fixes #23261.

git-svn-id: https://develop.svn.wordpress.org/trunk@30052 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:12:30 +00:00
Lance Willett
8a1bb7bba9 Twenty Fifteen: minor CSS fixes. See #30133.
git-svn-id: https://develop.svn.wordpress.org/trunk@30051 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 17:17:10 +00:00
Lance Willett
aa5c470fa8 Twenty Fifteen: minor CSS spacing fix. See #30133.
git-svn-id: https://develop.svn.wordpress.org/trunk@30049 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 16:44:44 +00:00
Lance Willett
61fb72e3c5 Twenty Fifteen: minor code style for variable within array notation. See #30133.
git-svn-id: https://develop.svn.wordpress.org/trunk@30048 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 16:39:14 +00:00
Lance Willett
48a504cc50 Twenty Fifteen: pinking shears. See #30133.
git-svn-id: https://develop.svn.wordpress.org/trunk@30047 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 16:29:39 +00:00
Lance Willett
df9b834c39 Twenty Fifteen: consistent line endings and SVN properties on all files. See #30133.
git-svn-id: https://develop.svn.wordpress.org/trunk@30046 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 16:28:41 +00:00
Lance Willett
0ba2f26de9 Twenty Fifteen: spacing and code style cleanup. See #30133.
git-svn-id: https://develop.svn.wordpress.org/trunk@30045 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 16:26:16 +00:00
Lance Willett
01cd41c3af Twenty Fifteen: escape variable in HTML attribute output in customer header. See #30133.
git-svn-id: https://develop.svn.wordpress.org/trunk@30044 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 16:24:27 +00:00
Lance Willett
377400ef8f Twenty Fifteen: squeeze a few more bytes from screenshot PNG file. See #30133.
git-svn-id: https://develop.svn.wordpress.org/trunk@30043 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 16:22:57 +00:00
Boone Gorges
c6de5dfec5 Allow 'slug' param of get_terms() to accept an array.
Props jfarthing84, dlh.
Fixes #23636.

git-svn-id: https://develop.svn.wordpress.org/trunk@30042 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 14:56:33 +00:00
Sergey Biryukov
6cbc9e03e1 When using 'show_in_menu' as a default value for 'show_in_admin_bar' in register_post_type(), cast to boolean instead of requiring a strict match.
props ipm-frommen.
fixes #30092.

git-svn-id: https://develop.svn.wordpress.org/trunk@30041 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 13:07:38 +00:00
Sergey Biryukov
a32ed9e1ea Remove one-time loop and redundant isset() checks in do_meta_boxes().
See [30022] for do_accordion_sections().

props ipm-frommen.
fixes #30093.

git-svn-id: https://develop.svn.wordpress.org/trunk@30040 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 12:57:24 +00:00
Sergey Biryukov
2672e35d43 Add 'comment_reply_link_args' filter for get_comment_reply_link() arguments.
props joedolson, aaroncampbell, DrewAPicture.
fixes #10569.

git-svn-id: https://develop.svn.wordpress.org/trunk@30039 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 11:44:40 +00:00
Sergey Biryukov
bb5aedf3d9 Don't display Standard post format twice in the meta box if the theme unnecessarily mentions it in the add_theme_support() call.
props ptahdunbar, nacin, pushplaybang, obenland.
fixes #16555.

git-svn-id: https://develop.svn.wordpress.org/trunk@30038 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 11:25:31 +00:00
Sergey Biryukov
6c69eec02d Make sure the validator list on Credits screen floats correctly with longer names.
props kosvrouvas.
fixes #30066.

git-svn-id: https://develop.svn.wordpress.org/trunk@30037 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 02:32:23 +00:00
Sergey Biryukov
b1c3d5eccc Don't add 'sticky' class in get_post_class() if 'ignore_sticky_posts' query var is set.
props jakub.tyrcha, johneckman.
fixes #18035.

git-svn-id: https://develop.svn.wordpress.org/trunk@30036 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 02:15:35 +00:00
Drew Jaynes (DrewAPicture)
aae8ddf48f Add a missing asterisk in the DocBlock for write_post().
Also removes several `@uses` tags, which are no longer leveraged as part of the inline documentation standard.

Props tareq1988.
Fixes #30118.


git-svn-id: https://develop.svn.wordpress.org/trunk@30034 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:55:16 +00:00
John Blackbourn
bc1168e953 Rename _wp_password_hint() to _wp_get_password_hint() to bring it inline with core terminology. Fixes #21243.
git-svn-id: https://develop.svn.wordpress.org/trunk@30033 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:29:11 +00:00
Mark Jaquith
48325023e2 Cast class names to an array to avoid a potential warning.
props briandichiara
fixes #29743

git-svn-id: https://develop.svn.wordpress.org/trunk@30032 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:18:03 +00:00
Boone Gorges
ae0ae95be6 Improve WP_Tax_Query param sanitization for empty strings.
When an empty string is passed as one of the clauses in the `$tax_query`
parameter, it should be discarded rather than parsed as a first-order clause.

Props tmtrademark.
Fixes #30117.

git-svn-id: https://develop.svn.wordpress.org/trunk@30031 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 22:56:36 +00:00
John Blackbourn
b92307f58d In wp_link_pages(), only output link separators between actual pagination links. Fixes #24940. Props obenland.
git-svn-id: https://develop.svn.wordpress.org/trunk@30030 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 22:40:07 +00:00
Jeremy Felt
42773dc11b Optimize site query when performing network database upgrades
We only use `blog_id` from the query, so we don't need a wildcard.

props marcosf
Fixes #30097


git-svn-id: https://develop.svn.wordpress.org/trunk@30029 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 22:09:46 +00:00
John Blackbourn
5567318f63 Introduce an edit_form_before_permalink action which gets fired after the title field but before the permalink fields. Fixes #29691. Props captaintheme
git-svn-id: https://develop.svn.wordpress.org/trunk@30028 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 21:48:38 +00:00
John Blackbourn
e6483ffab5 Add labels to the Personal Options input fields on the user profile editing screen. Fixes #30101. Props Ankit K Gupta
git-svn-id: https://develop.svn.wordpress.org/trunk@30027 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 21:28:50 +00:00
Boone Gorges
4482d000ba Fix 'count' in WP_Comment_Query when using 'meta_query'.
Props heshiming, desaiuditd.
Fixes #23369.

git-svn-id: https://develop.svn.wordpress.org/trunk@30026 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 16:45:37 +00:00
Ian Stewart
c429ba1bdd Twenty Fifteen: If the sidebar is taller than the viewport scroll it with the content, if it's shorter keep it fixed.
Props mattwiebe, iamtakashi, avryl, fixes #29979.



git-svn-id: https://develop.svn.wordpress.org/trunk@30025 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 15:03:45 +00:00
Sergey Biryukov
79a5303f68 Fix JSHint errors introduced in [30014].
props adamsilverstein.
see #29572.

git-svn-id: https://develop.svn.wordpress.org/trunk@30024 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 12:05:58 +00:00
Sergey Biryukov
f1c05021aa Twenty Fifteen: Add Foursquare icon support to the social link menu.
props iamtakashi.
fixes #30100.

git-svn-id: https://develop.svn.wordpress.org/trunk@30023 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 10:44:28 +00:00
Sergey Biryukov
36ee6ba8be Remove one-time loop and redundant isset() checks.
props ipm-frommen.
fixes #30093.

git-svn-id: https://develop.svn.wordpress.org/trunk@30022 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 16:33:45 +00:00
Sergey Biryukov
8e3a90887e Fix a copy/paste issue in Custom_Image_Header::get_header_dimensions() introduced in [27497].
props ipm-frommen.
fixes #30095.

git-svn-id: https://develop.svn.wordpress.org/trunk@30021 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 15:55:37 +00:00
Sergey Biryukov
f9101c1de9 Users screen in network admin:
* Remove unused $key variables.
* Rename $val to $user_id for clarity.

props ipm-frommen.
fixes #30096.

git-svn-id: https://develop.svn.wordpress.org/trunk@30020 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:51:36 +00:00
Drew Jaynes (DrewAPicture)
3168f799c9 Fix the $location parameter type in the unregister_nav_menu() DocBlock.
`$location` is a string, not an array.

Props ipm-frommen.
Fixes #30098.


git-svn-id: https://develop.svn.wordpress.org/trunk@30019 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:42:57 +00:00
Drew Jaynes (DrewAPicture)
c61e074530 Fix an invalid type for the $section parameter in the do_settings_fields() DocBlock.
Props ipm-frommen.
See #30098.


git-svn-id: https://develop.svn.wordpress.org/trunk@30018 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:37:59 +00:00
Boone Gorges
1fe9707760 Accept 'orderby=include' in WP_User_Query.
This lets the results of a user query be sorted manually by the value of the
'include' param.

Props jipmoors.
Fixes #30064.

git-svn-id: https://develop.svn.wordpress.org/trunk@30016 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 19:50:53 +00:00
John Blackbourn
d033be1f9d Remove padding from the comment notification emails which is from a bygone fixed-width font era. Prevents alignment issues in email clients which use vairable width fonts for plain text emails. Fixes #16721. Props DrewAPicture.
git-svn-id: https://develop.svn.wordpress.org/trunk@30015 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 17:07:53 +00:00
John Blackbourn
37a3642183 Add the ability for a customizer control to render its controls via a JavaScript template. Switches the default color picker control to a JavaScript template. See #29572. Props celloexpressions
git-svn-id: https://develop.svn.wordpress.org/trunk@30014 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 16:31:54 +00:00
Ian Stewart
805f230e99 Twenty Fifteen: valid HTML for accessible child page menu expanding and collapsing -- now with even better accessiblity.
Props afercia, davidakennedy, iamtakashi, fixes #30083.



git-svn-id: https://develop.svn.wordpress.org/trunk@30013 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 15:14:02 +00:00
Ian Stewart
81639b9dd7 Twenty Fifteen: correct list indentation in older IE versions.
Props iamtakashi, fixes #30074.



git-svn-id: https://develop.svn.wordpress.org/trunk@30012 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 15:04:48 +00:00
Ian Stewart
342f782ea0 Twenty Fifteen: darken up the post navigation with thumbnail for better a11y.
Props davidakennedy, fixes #30069.


git-svn-id: https://develop.svn.wordpress.org/trunk@30011 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 14:58:40 +00:00
Ian Stewart
e67582c911 Twenty Fifteen: removing Skype from the list of social links is easier than adding skype to $allowed_protocols.
Props iamtakashi, fixes #30059.



git-svn-id: https://develop.svn.wordpress.org/trunk@30010 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 14:54:12 +00:00
Ian Stewart
c9f6dd15f1 Twenty Fifteen: Use a p for the site description for a better experience when using a screenreader.
Props rianrietveld, fixes #30057, see #30065.


git-svn-id: https://develop.svn.wordpress.org/trunk@30009 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 14:50:49 +00:00
Jeremy Felt
c7ad092b1d Deprecate admin_created_user_subject()
When `admin_created_user_subjec()` was merged from MU, the accompanying filter was left behind. As it has never been used by WordPress core, and is not an otherwise useful function, it can be deprecated.

Fixes #29915


git-svn-id: https://develop.svn.wordpress.org/trunk@30005 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 04:48:31 +00:00
Boone Gorges
382871ad9d Allow ORDER BY in WP_Comment_Query::query() to be disabled.
Disable ORDER BY by passing boolean false, an empty array, or the string
'none' to the 'orderby parameter. This mirrors the behavior of `WP_Query`.

Props psycleuk.
Fixes #29902.

git-svn-id: https://develop.svn.wordpress.org/trunk@30004 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 02:50:24 +00:00
Boone Gorges
ce810ba5b3 Add unit tests for WP_Comment_Query 'orderby' param.
For better testability, the SQL string generated in `WP_Comment_Query::get_posts()`
is now stored as a 'request' property on the object.

See #29902.

git-svn-id: https://develop.svn.wordpress.org/trunk@30003 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 02:33:46 +00:00
Andrew Ozz
1880bf988c Editor: use <button> instead of <a> for the Visual/Text buttons, make them focusable. Props afercia, fixes #27553
git-svn-id: https://develop.svn.wordpress.org/trunk@30002 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 01:20:42 +00:00
Andrew Nacin
9b3aabc7f9 4.1-alpha-30000 (!)
git-svn-id: https://develop.svn.wordpress.org/trunk@30000 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-23 23:31:19 +00:00
Andrew Nacin
8c555f2ed2 4.1-alpha-29999
git-svn-id: https://develop.svn.wordpress.org/trunk@29999 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-23 23:26:02 +00:00
Ian Stewart
8fdc680f66 Twenty Fifteen: documentation for the twentyfifteen_credits action
Props iamtakashi, fixes #30051



git-svn-id: https://develop.svn.wordpress.org/trunk@29998 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-23 18:36:20 +00:00
Sergey Biryukov
150f0cdfaf Twenty Fifteen: Isolate :not selectors from CSS2 selectors.
props peterwilsoncc, iamtakashi.
fixes #30014.

git-svn-id: https://develop.svn.wordpress.org/trunk@29996 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-23 11:43:04 +00:00
Sergey Biryukov
3816b779f0 Twenty Fifteen: Fix typo in a CSS comment.
props iamtakashi.
fixes #30081.

git-svn-id: https://develop.svn.wordpress.org/trunk@29995 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-23 11:36:27 +00:00
Andrew Ozz
a454872630 TinyMCE: update to 4.1.6+. Adds support for cache-busting when auto-loading JS and CSS. Change the tests to run in /build. Changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt.
Fixes #30079

git-svn-id: https://develop.svn.wordpress.org/trunk@29994 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-23 02:07:15 +00:00
Sergey Biryukov
082ad55827 Twenty Fifteen: Include post title in Continue Reading link in Link post format.
props davidakennedy.
fixes #30070.

git-svn-id: https://develop.svn.wordpress.org/trunk@29991 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-22 16:29:49 +00:00
Sergey Biryukov
efd52e2bd9 Twenty Fifteen: Remove a non-relevant part of a string in 404.php.
props davidakennedy.
fixes #30061.

git-svn-id: https://develop.svn.wordpress.org/trunk@29990 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-22 11:59:43 +00:00
Andrew Ozz
2ba822f6f1 Script-loader: remove 'heartbeat' dependency for post.js and inline-edit-post.js, fix dependencies for autosave.js. Fixes #30008
git-svn-id: https://develop.svn.wordpress.org/trunk@29989 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-22 03:40:13 +00:00
Sergey Biryukov
2c3e3238e2 Twenty Fifteen: Fix missing commas in the stylesheet.
props iamtakashi.
fixes #30068.

git-svn-id: https://develop.svn.wordpress.org/trunk@29988 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-22 02:42:38 +00:00
Andrew Ozz
880dcf7376 Twenty Fifteen: better editor-style.css: slightly smaller fonts, make the body margins relative, fix dependency on the mce-item-table class for tables. Props iamtakashi, fixes #29986
git-svn-id: https://develop.svn.wordpress.org/trunk@29987 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-22 02:39:39 +00:00
Andrew Ozz
37e553ec79 TinyMCE: update the default styles: make the font size larger and make it the same size in tables. Fixes #30038
git-svn-id: https://develop.svn.wordpress.org/trunk@29986 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 23:05:33 +00:00
John Blackbourn
58c5345d4b Update the docs for wp_remote_retrieve_response_code(). See #28887.
git-svn-id: https://develop.svn.wordpress.org/trunk@29985 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 21:12:30 +00:00
John Blackbourn
294cb1ec53 Avoid double path separators in load_theme_textdomain(). Fixes #29122. Props bradyvercher
git-svn-id: https://develop.svn.wordpress.org/trunk@29984 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 17:57:41 +00:00
John Blackbourn
368bc7b468 Add a focus outline to the widget control toggle arrows. Fixes #27953. Props TomHarrigan.
git-svn-id: https://develop.svn.wordpress.org/trunk@29983 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 17:39:02 +00:00
Andrew Ozz
8288e31417 Admin menu:
- Fix scrolling the pinned menu with a mouse wheel.
- Fix pinning when the menu is only slightly taller than the viewport.
- Disable pinning on IE8, updating CSS top makes it jump when scrolling with a mouse wheel.
See #29806

git-svn-id: https://develop.svn.wordpress.org/trunk@29978 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-21 06:11:07 +00:00
Sergey Biryukov
4ea9070f8a Fix copy/paste errors in [27769].
props Corphi.
fixes #30054.

git-svn-id: https://develop.svn.wordpress.org/trunk@29977 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 21:34:51 +00:00
Ian Stewart
74f1fad31d Twenty Fifteen: updated styles for skip link.
Props afercia and iamtakashi, fixes #30043.



git-svn-id: https://develop.svn.wordpress.org/trunk@29976 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 19:38:41 +00:00
Ian Stewart
e9be393270 Twenty Fifteen: Adding in the twentyfifteen credits action.
Props iamtakashi, fixes #30051.



git-svn-id: https://develop.svn.wordpress.org/trunk@29975 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 19:20:48 +00:00
Ian Stewart
dd417a184c Twenty Fifteen: correct comment meta alignment when avatar display is turned off.
Props iamtakashi, fixes #30046.



git-svn-id: https://develop.svn.wordpress.org/trunk@29974 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 19:18:36 +00:00
Ian Stewart
7ce8654a92 Twenty Fifteen: correct button sizes.
Props iamtakashi, fixes #30045.



git-svn-id: https://develop.svn.wordpress.org/trunk@29973 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 19:15:24 +00:00
Ian Stewart
5630db8da3 Twenty Fifteen: beautify the header in IE 8.
Props afercia, fixes #30042.



git-svn-id: https://develop.svn.wordpress.org/trunk@29972 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 19:13:13 +00:00
Ian Stewart
efc50ba421 Twenty Fifteen: correct styles for color schemes
Props iamtakashi, fixes #29976.



git-svn-id: https://develop.svn.wordpress.org/trunk@29971 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 18:56:19 +00:00
Dion Hulse
f2b727f333 Filesystem: Fix the move() method of the SSH2 transport, which was using the SSH2 link rather than the SFTP link.
Props nobleclem. Fixes #29405


git-svn-id: https://develop.svn.wordpress.org/trunk@29970 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 07:45:52 +00:00
Dion Hulse
98c438048d Avoid a PHP Notice in the PemFTP Library by adding a missing function parameter. This parameter is unused by WordPress.
Props hugodelgado. Fixes #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@29969 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 07:40:41 +00:00
Dion Hulse
5bcbdefd2e HTTP API: Support both the 'limit_response_size' and 'stream' parameters at the same time, allowing a partial file download.
Fixes #26726


git-svn-id: https://develop.svn.wordpress.org/trunk@29968 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-20 07:31:45 +00:00
Boone Gorges
5bc62ad1e4 Allow apostrophes in email addresses when adding users via the Dashboard.
Email addresses entered in a number of interfaces were not being stripslashed
properly, with the result that the emails were not being recognized as valid.

Fixes #18039.

git-svn-id: https://develop.svn.wordpress.org/trunk@29966 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 20:29:33 +00:00
Boone Gorges
348c8958da Use the comment API rather than direct SQL queries in comments_template().
`comments_template()` is used by most themes to display a post's comments. It
shows all comments that have been approved, and also shows all pending comments
by the current visitor (as determined by the comment cookies). However, the
comments API previously had no way of querying for "all comments that are
either approved, or are unapproved but written by foo@example.com". The
workaround was a direct SQL query: uncached, not subject to the same filters as
other comment queries, and just generally icky.

The new `include_unapproved` parameter for `WP_Comment_Query` accepts an array
of user IDs or email addresses. Pending comments associated with users in this
array will be included in query results, regardless of the value of the 'status'
parameter. In `comments_template()`, we leap from direct SQL queries to
`get_comments()` plus `include_unapproved', striving to put right what once
went wrong.

Props boonebgorges, simonwheatley, hardy101, jesin.
Fixes #19623.

git-svn-id: https://develop.svn.wordpress.org/trunk@29965 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 19:38:16 +00:00
Boone Gorges
91733ae919 Make orderby=meta_value compatible with meta_query when relation=OR.
Passing orderby=meta_value and meta_key=foo to WP_Query should require that
each matched post have a meta value with the key 'foo'. To make this
requirement compatible with meta_query params that have the relation OR, we
nest the meta_query param, and join it using AND to a meta_query clause
generated from the meta_key/meta_compare/meta_type query vars.

Fixes #25538.

git-svn-id: https://develop.svn.wordpress.org/trunk@29964 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 18:53:55 +00:00
Sergey Biryukov
512ea93ae4 Live-update site title in toolbar when changing the corresponding field in General Settings.
props celloexpressions, avryl.
fixes #28682.

git-svn-id: https://develop.svn.wordpress.org/trunk@29963 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-19 09:12:11 +00:00
Sergey Biryukov
5ab446aab7 Move password hint text to a function. Add 'password_hint' filter.
props convissor.
fixes #21243.

git-svn-id: https://develop.svn.wordpress.org/trunk@29962 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 20:20:56 +00:00
Sergey Biryukov
ac90567ef1 Use proper functions for escaped translations.
pros jcastaneda.
fixes #30012.

git-svn-id: https://develop.svn.wordpress.org/trunk@29961 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 20:10:47 +00:00
Sergey Biryukov
0caa0b1dbf In wp.updates.decrementCount(), only display the count if it's a valid non-negative integer.
props jdgrimes.
fixes #29527.

git-svn-id: https://develop.svn.wordpress.org/trunk@29960 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:54:40 +00:00
Sergey Biryukov
d7955317f3 Theme install:
* Move the "based on" string below the rating to avoid wrapping to a second line.
* Reduce the gap between the theme screenshot and description.
* Fix Install button height on mobile.

props obenland, ocean90.
fixes #28148. see #29556.

git-svn-id: https://develop.svn.wordpress.org/trunk@29959 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:42:12 +00:00
Sergey Biryukov
a1b5440d4b wp_add_inline_style():
* Change the `wp-inline-style-$handle` class added in [29956] to `$handle-inline-css` for consistency with existing patterns.
* Add the ID attribute when concatenation is enabled as well.

props georgestephanis.
see #30032.

git-svn-id: https://develop.svn.wordpress.org/trunk@29958 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 19:03:11 +00:00
Sergey Biryukov
97b07876cb Themes: Make "Live Preview" the primary action and "Activate" secondary.
props celloexpressions.
fixes #26899.

git-svn-id: https://develop.svn.wordpress.org/trunk@29957 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 18:16:23 +00:00
Sergey Biryukov
112c98f71e Add ID attribute to style element from wp_add_inline_style().
props westonruter.
fixes #30032.

git-svn-id: https://develop.svn.wordpress.org/trunk@29956 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 17:57:23 +00:00
Sergey Biryukov
326aeeba56 Customizer: Use correct panel-back icon in RTL.
props TomHarrigan.
fixes #29946.

git-svn-id: https://develop.svn.wordpress.org/trunk@29955 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 15:34:33 +00:00
Boone Gorges
17183e4e71 Remove redundant table alias check in WP_Meta_Query.
Also adds documentation for 'meta_query_find_compatible_table_alias' filter.

See #24093.

git-svn-id: https://develop.svn.wordpress.org/trunk@29953 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-18 02:21:33 +00:00
iandstewart
35c3756c2b Twenty Fifteen: Swap order of description and caption so the caption is underneath an image on image attachment pages.
Props iamtakashi, fixes #30020.



git-svn-id: https://develop.svn.wordpress.org/trunk@29951 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 21:35:01 +00:00
Dominik Schilling (ocean90)
061226df73 Customizer: Extract content markup for panels to its own method, WP_Customize_Panel::render_content().
This allows to override the behavior of a panel, or even to completely replace its contents with something other than controls or sections.

props celloexpressions.
fixes #29324.

git-svn-id: https://develop.svn.wordpress.org/trunk@29950 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 21:24:32 +00:00
Ian Stewart
3769ced570 Twenty Fifteen: centre gallery thumbnails
Props iamtakashi, fixes #30019



git-svn-id: https://develop.svn.wordpress.org/trunk@29949 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 21:22:25 +00:00
Dominik Schilling (ocean90)
12c39b7f4a Customizer: Introduce customize_preview_$setting->type action to handle multiple settings of the same type.
props celloexpressions.
fixes #29165.

git-svn-id: https://develop.svn.wordpress.org/trunk@29948 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 21:20:42 +00:00
Ian Stewart
c4a5809baf Twenty Fifteen: correct escaping to render HTML in no-content admin message.
Props dmchale, fixes #30011.


git-svn-id: https://develop.svn.wordpress.org/trunk@29947 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 21:15:39 +00:00
Boone Gorges
c2bea27bfd Invalidate cache for child terms when parent term is deleted.
Props socki03.
Fixes #29911.

git-svn-id: https://develop.svn.wordpress.org/trunk@29945 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 20:58:48 +00:00
Ian Stewart
297f2c78c5 Twenty Fifteen: Removing unused custom color controls.
Props cainm, fixes #29982 and #29959.



git-svn-id: https://develop.svn.wordpress.org/trunk@29944 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 20:51:46 +00:00
Ian Stewart
9902adca05 Twenty Fifteen: Fix hover and focus style for links in content with custom color schemes.
Props iamtakashi, fixes #29978.


git-svn-id: https://develop.svn.wordpress.org/trunk@29942 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 20:31:15 +00:00
Boone Gorges
4c544151b2 Bail from cleaning meta query clause when it's not an array.
Later isset() checks on string values were causing notices on PHP < 5.4.

Props jorbin.
See #29642.

git-svn-id: https://develop.svn.wordpress.org/trunk@29941 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 20:24:57 +00:00
Boone Gorges
1708a580fd Overhaul SQL generating logic in WP_Meta_Query to avoid unnecessary table joins.
The logic used to generate clause SQL in `WP_Meta_Query` is somewhat arcane,
stemming mostly from an ongoing effort to eliminate costly table joins when
they are not necessary. By systematizing the process of looking for shareable
joins - as was done in `WP_Tax_Query` [29902] - it becomes possible to simplify
the construction of SQL queries in `get_sql_for_clause()`. Moreover, the
simplified logic is actually considerably better at identifying shareable
joins, such that certain uses of `WP_Meta_Query` will see joins reduced by 50%
or more.

Includes integration tests for a representative cross-section of the query
clause combinations that result in shared table aliases.

Props boonebgorges, sc0ttkclark.
See #24093.

git-svn-id: https://develop.svn.wordpress.org/trunk@29940 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 20:20:04 +00:00
Scott Taylor
be59c5009e wp_schedule_single_event() should not prevent scheduling a future duplicate event. It should only reject an event as a duplicate if there is already a similar event scheduled within 10 minutes of the given timestamp.
Adds unit tests, fixes existing cron test.

Props tellyworth.

See [9181], #6966.
Fixes #28213.


git-svn-id: https://develop.svn.wordpress.org/trunk@29939 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 19:16:26 +00:00
Boone Gorges
68d92cf23e Add @since annotation for 'user_registered' support in 'date_query_valid_columns' documentation.
Props DrewAPicture.
Fixes #27283.

git-svn-id: https://develop.svn.wordpress.org/trunk@29938 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 03:50:29 +00:00
Boone Gorges
00f7ae376a Better "inclusive" support for string values in WP_Date_Query.
The 'inclusive' parameter for WP_Date_Query determines whether non-precise
dates for 'before' and 'after' will be rounded up or down. Previously, this was
supported only when 'before' and 'after' were arrays; string-formatted dates
were run through strtotime(), which rounded them all down (inclusive in the
case of after, non-inclusive in the case of before). Now, we attempt to parse
formats that look like MySQL-formatted date strings, and apply inclusive logic
to them if we recognize them successfully.

Fixes #29908.
string values. Array values support the 'inclusive

git-svn-id: https://develop.svn.wordpress.org/trunk@29936 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 02:27:44 +00:00
Boone Gorges
aee4647da0 Comment/post author in/not_in for WP_Comment_Query.
Props nofearinc, chriscct7.
Fixes #29885.

git-svn-id: https://develop.svn.wordpress.org/trunk@29935 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 01:57:18 +00:00
Boone Gorges
64bc8466db Support date_query by user_registered in WP_User_Query.
Props ChriCo, nacin.
Fixes #27283.

git-svn-id: https://develop.svn.wordpress.org/trunk@29934 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 01:36:36 +00:00
Boone Gorges
42646e67b3 Use table aliases for columns in SQL generated by WP_Date_Query.
The use of non-aliased column names (eg 'post_date' instead of 'wp_posts.post_date')
in WP_Date_Query causes SQL notices and other failures when queries involve
table joins, such as date_query combined with tax_query or meta_query. This
changeset modifies WP_Date_Query::validate_column() to add the table alias when
it can be detected from the column name (ie, in the case of core columns).

A side effect of this change is that it is now possible to use WP_Date_Query
to build WHERE clauses across multiple tables, though there is currently no
core support for the automatic generation of the necessary JOIN clauses. See

Props ew_holmes, wonderboymusic, neoxx, Viper007Bond, boonebgorges.
Fixes #25775.

git-svn-id: https://develop.svn.wordpress.org/trunk@29933 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-17 01:19:03 +00:00
Boone Gorges
44bb383371 Remove invalid continue calls from WP_Tax_Query::get_sql_for_clause().
This was leftover code from the previous implementation, which used a `foreach()`
loop. See [29901].

Props nofearinc.
See #29738, #29718.

git-svn-id: https://develop.svn.wordpress.org/trunk@29931 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 22:06:46 +00:00
Ian Stewart
136436e9f1 Twenty Fifteen: readable comment details in the dark colour scheme.
Props NikV, fixes #29970.



git-svn-id: https://develop.svn.wordpress.org/trunk@29930 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 22:00:23 +00:00
Andrew Ozz
8348a50194 Editor-expand:
- Better calculation for the caret position when auto-scrolling while typing.
- Fix auto-scrolling for non-WebKit browsers when the caret is above the top of the editor.
Fixes #29954

git-svn-id: https://develop.svn.wordpress.org/trunk@29929 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 21:31:00 +00:00
Ian Stewart
f3bcbc8ada Twenty Fifteen: document the site-branding class in header.php.
Props NikV, fixes #29961.



git-svn-id: https://develop.svn.wordpress.org/trunk@29928 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 20:51:11 +00:00
Ian Stewart
722005655c Twenty Fifteen: make sure we don't see borders through transparent linked images.
Props iamtakashi, fixes #29963.



git-svn-id: https://develop.svn.wordpress.org/trunk@29927 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 20:47:35 +00:00
Ian Stewart
019998e325 Twenty Fifteen: Removes flashing of background behind fixed position elements when scrolling in mobile and desktop Safari.
Props iamtakashi, fixes #29973 and #29987.


git-svn-id: https://develop.svn.wordpress.org/trunk@29926 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 20:34:10 +00:00
Boone Gorges
a3da10deb0 Throw notices when invalid date values are passed to WP_Date_Query.
`_doing_it_wrong()` notices are now generated when passing out-of-range values
(`month=13`) or invalid dates (`2014-02-29`).

Includes unit tests.

Props ChriCo.
Fixes #25834.

git-svn-id: https://develop.svn.wordpress.org/trunk@29925 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 20:11:13 +00:00
Dominik Schilling (ocean90)
3d6d32d9e6 Themes: Make it possible to delete broken themes.
props ideag, obenland.
fixes #28165.

git-svn-id: https://develop.svn.wordpress.org/trunk@29924 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 19:45:26 +00:00
Boone Gorges
a3e0c08f2f Introduce nested query support to WP_Date_Query.
This enhancement makes it possible to filter post, comment, and other queries
by date in ways that are arbitrarily complex, using mixed AND and OR relations.

Includes unit tests for the new syntax. In a few places, the existing unit
tests were slightly too strict (such as when checking the exact syntax of a SQL
string); these existing tests have been narrowed.

Props boonebgorges.
Fixes #29822.

git-svn-id: https://develop.svn.wordpress.org/trunk@29923 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 19:33:24 +00:00
Ian Stewart
c845692fb4 Twenty Fifteen: indented nested lists in comments.
Props pauldewouters, iamtakashi, fixes #29981.



git-svn-id: https://develop.svn.wordpress.org/trunk@29922 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 19:31:09 +00:00
Ian Stewart
ed5e22d2f7 Twenty Fifteen: correct margin for pagination.
Props kwight; fixes #29964.



git-svn-id: https://develop.svn.wordpress.org/trunk@29921 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 19:15:33 +00:00
Dominik Schilling (ocean90)
f3eb0eacc6 Update jQuery UI to 1.11.2.
Changelog: http://jqueryui.com/changelog/1.11.2/

see #29833.

git-svn-id: https://develop.svn.wordpress.org/trunk@29920 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 19:01:44 +00:00
Ian Stewart
935bc467b5 Twenty Fifteen: add print styles.
Props iamtakashi, closes #29967



git-svn-id: https://develop.svn.wordpress.org/trunk@29919 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 19:01:18 +00:00
Ian Stewart
4eb5c81721 Twenty Fifteen: correct font fallback for Noto Serif in editor styles; Props Manoz69; Fixes #29984
git-svn-id: https://develop.svn.wordpress.org/trunk@29918 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 18:39:06 +00:00
Scott Taylor
bd70f47d46 In wp.Uploader, when uploader:ready is triggered, set ready to true on the instance. This allows media workflows to check for an existing uploaded instance when opening.
Without this check, workflows might wait for `uploader:ready`, which could already have been fired. This would result in an unresponsive editor dropzone.

Fixes #29689.


git-svn-id: https://develop.svn.wordpress.org/trunk@29917 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 05:53:15 +00:00
Scott Taylor
0d58d32462 Cache get_term_by() calls:
* Add a helper function, `wp_get_last_changed()`, to retrieve a last-modified timestamp by cache group
* When caching a term, also make cache entries for slug and name via `slug:{$term_id}` and `name:{$term_id}` keys in the `$taxonomy:$last_changed` bucket that reference the term_id
* In `clean_term_cache()` and `update_term_cache()`, respect `$_wp_suspend_cache_invalidation`
* Original term cache entries maintain BC

Adds unit tests.

Props wonderboymusic, tollmanz, boonebgorges.
Fixes #21760.


git-svn-id: https://develop.svn.wordpress.org/trunk@29915 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 04:44:13 +00:00
Scott Taylor
076c7e8902 Add a 6th (!) attribute to wp_get_attachment_link() to allow aria-describedby to be added to gallery output.
Props joedolson, DrewAPicture, rianrietveld.
Fixes #27402.


git-svn-id: https://develop.svn.wordpress.org/trunk@29914 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 04:27:07 +00:00
Boone Gorges
e36cac6794 Check that search value is scalar before parsing.
Prevents PHP notices when non-scalar values are passed.

Includes unit tests.

Props tivnet.
Fixes #29736.

git-svn-id: https://develop.svn.wordpress.org/trunk@29912 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 03:31:27 +00:00
Andrew Ozz
136bba8cfd Twenty Fifteen, editor-style.css: revert the font-size back to 19px and margin back to 83px, merge the two body selectors (don't seem needed), remove redundant rtl rules and fix body.rtl selector. See #29799
git-svn-id: https://develop.svn.wordpress.org/trunk@29911 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-16 00:26:20 +00:00
Andrew Ozz
350439b05f Twenty Fifteen: no rem in editor-style.css for now, see #29799
git-svn-id: https://develop.svn.wordpress.org/trunk@29910 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 22:47:38 +00:00
Andrew Ozz
44e3ddfe7d Twenty Fifteen: make font-size/line-height in editor-style.css the same as in style.css. Remove margins from the editor body, interferes with autoresize in some browsers and is overriden in the default styles. See #29799
git-svn-id: https://develop.svn.wordpress.org/trunk@29909 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 22:36:27 +00:00
Dominik Schilling (ocean90)
5d7e30e7d9 Comments: Don't print an empty HTML markup when comment_reply_link() returns no link.
props obenland.
fixes #29895.

git-svn-id: https://develop.svn.wordpress.org/trunk@29908 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 21:55:31 +00:00
Dominik Schilling (ocean90)
e6d26285cc Customizer: Don't trigger a change event if two unchanged object values are equal, second pass.
Make Underscore.js a dependency for `customize-base` and use `_.isEqual()` to compare the values.
(Underscore.js was already enqueued via wp-util.js for Widgets.)

props westonruter.
fixes #26061.

git-svn-id: https://develop.svn.wordpress.org/trunk@29907 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 18:25:43 +00:00
Dominik Schilling (ocean90)
83b0f3f681 Customizer: Only POST dirty settings to preview to improve performance.
props westonruter.
fixes #29983.

git-svn-id: https://develop.svn.wordpress.org/trunk@29905 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 17:49:36 +00:00
Dominik Schilling (ocean90)
5829ccba9b Theme install: Remove unused strings.
fixes #29488.

git-svn-id: https://develop.svn.wordpress.org/trunk@29904 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 17:21:43 +00:00
Dominik Schilling (ocean90)
ab128698ad Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/.

props studionashvegas, tareq1988.
fixes #29947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29903 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-15 17:20:34 +00:00