sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
21,189 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

21189 Commits

Author SHA1 Message Date
Andrew Nacin 1cc12103f5 Restore the Description field to the media UI in 3.5. 
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: https://develop.svn.wordpress.org/trunk@23083 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-06 00:41:06 +00:00
Andrew Nacin 6c54baea98 Translate the 'First Steps with WordPress' Codex link. props SergeyBiryukov, fixes #22767. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23082 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 22:51:24 +00:00
Andrew Nacin a91ebc0abf Media list table: Fix the categories column, hidden thanks to a typo. props eddiemoya, fixes #22764. see #21240, #21391. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23081 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 22:49:51 +00:00
bumpbot bee0035c66 Compress scripts/styles: 3.5-RC3-23080. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23080 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 21:22:59 +00:00
Ryan Boren f549a8baa6 Fix uploads in IE9 
Props koopersmith
fixes #22762


git-svn-id: https://develop.svn.wordpress.org/trunk@23079 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 21:21:17 +00:00
bumpbot c936792bbb Compress scripts/styles: 3.5-RC3-23078. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23078 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 19:22:54 +00:00
Andrew Nacin 167db2d9da Media: Account for the most obvious and common style conflicts that may occur when the media modal is loaded on the frontend. Tested primarily with P2. props lessbloat, helenyhou. fixes #22752. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23077 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 19:15:40 +00:00
Andrew Nacin 0d7c64c9fd Media: Final names for the actions in the dialog sidebar: "Insert from URL" and "Set Featured Image" to go with "Insert Media" and "Create Gallery". 
Longer strings (such as a translation) looks excellent when it wraps to another line.

props markjaquith, fixes #22753.



git-svn-id: https://develop.svn.wordpress.org/trunk@23076 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 19:07:48 +00:00
Andrew Nacin bdba526d83 Media: Use '%d selected' for the selection string, and offer a comment to translators to help them find a workable solution with this would-be plural string. fixes #22749. see #22229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23075 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 19:03:38 +00:00
Andrew Nacin b2bafcca6a Script loader: Chunk the script names as passed to load-scripts.php into 128-character pieces. Avoids hitting a limit for the length of a single variable, such as suhosin.get.max_value_length which defaults to 512. fixes #22757. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23074 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 18:57:56 +00:00
bumpbot c3b88709fd Compress scripts/styles: 3.5-RC3-23073. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23073 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 10:58:32 +00:00
Mark Jaquith 92793b6ec2 Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613 
git-svn-id: https://develop.svn.wordpress.org/trunk@23072 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 10:29:24 +00:00
Mark Jaquith c2f15bc83b Better responsive breakpoints for the Gallery editing screen. props koopersmith. fixes #22741 
git-svn-id: https://develop.svn.wordpress.org/trunk@23071 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 10:15:42 +00:00
Mark Jaquith d767e74ae9 Implement tabbing between fields in the media modal. props lessbloat, koopersmith. fixes #22659 
git-svn-id: https://develop.svn.wordpress.org/trunk@23070 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 09:57:58 +00:00
Mark Jaquith 81bdf1b5d1 When setting the featured image from the dedicated meta box, only show the featured image section in the media chooser. props koopersmith. fixes #22731 
* Less distracting
* Some of these sections won't apply for CPTs without an editor

git-svn-id: https://develop.svn.wordpress.org/trunk@23069 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 09:43:10 +00:00
Mark Jaquith 189d4da5de Fix the "Uploaded to this post" filter in the "Add to gallery" state. fixes #22723 
Also, use "images" wording instead of generic "media items" when in a gallery (images-only) context. fixes #22722

Both are props koopersmith

git-svn-id: https://develop.svn.wordpress.org/trunk@23068 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 09:25:17 +00:00
Mark Jaquith aabaa0fb8e Use data on the ui.item to transport the original Sortable index for the update() function. This way extensions can set/access this info in their own custom Sortable functions. see #22696 
git-svn-id: https://develop.svn.wordpress.org/trunk@23067 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 09:04:19 +00:00
bumpbot fc3c9a8004 Compress scripts/styles: 3.5-RC3-23066. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23066 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 04:58:33 +00:00
Ryan Boren 86203fa6bf Clear the From URL view in the media modal after inserting an image. Improve button enable checks. 
Props koopersmith
fixes #22740


git-svn-id: https://develop.svn.wordpress.org/trunk@23065 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 04:43:51 +00:00
Mark Jaquith 4413c9514b Allow a sortable options hash to be passed in, so you can override the defaults. props koopersmith. see #22696 
git-svn-id: https://develop.svn.wordpress.org/trunk@23064 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 04:11:49 +00:00
Andrew Nacin 548e695750 Media: Sidebar labels should be display block. Prevents wonkiness like inputs disappearing because Chrome no like you. props helenyhou. fixes #22721. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23063 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 04:06:45 +00:00
bumpbot f0a90a66cb Compress scripts/styles: 3.5-RC3-23062. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23062 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 03:30:48 +00:00
Andrew Nacin f79847866e Media IE7 fixes. props azaozz, lessbloat. fixes #22732. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23061 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 03:15:53 +00:00
Lance Willett 38a29de5bc Twenty Eleven: remove buggy `word-break` property, use `word-wrap` instead, for better hyphenation and word breaking in nested comments. Fixes #22751. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23060 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 03:06:46 +00:00
bumpbot 6b81fd778d Compress scripts/styles: 3.5-RC3-23059. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23059 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 02:58:34 +00:00
Andrew Nacin 34f181654d Admin ajax: Roll back new-style error sending in set-post-thumbnail. The JS handlers know to parse an unrecognized response (like -1 or 0) as a failure. see #21776. see #22750. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23058 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 02:34:00 +00:00
Andrew Nacin bc8f994e7b Media models: Trac and ignore deleted attachments. 
Treat an admin-ajax response of 1 as successful for backwards compatibility with existing handlers.

props koopersmith. fixes #22750.



git-svn-id: https://develop.svn.wordpress.org/trunk@23057 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 02:31:41 +00:00
Andrew Nacin 01e7e10bf7 Media: Don't try to resize the bottom selection UI. props koopersmith. fixes #22748. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23056 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 01:38:44 +00:00
Andrew Nacin 426eb50936 Fix inserting of multiple attachments with captions when the first attachment does not have a caption. props azaozz. fixes #22720. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23055 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 00:59:25 +00:00
bumpbot 25337c050c Compress scripts/styles: 3.5-RC3-23054. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23054 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 00:58:31 +00:00
Daryl Koopersmith eae68af55c Toggle display of plupload overlays when the select files button is hidden. see #22732. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23053 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 00:45:21 +00:00
Andrew Nacin f824b1a921 Minimum heights for the media modal to prevent it from scrunching up on tiny devices. (Panning is better.) props helenyhou. fixes #22747. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23052 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 00:40:13 +00:00
Andrew Nacin 3fd91ed4cf Media: Return to the library when the editing a selection and all items get de-selected. props koopersmith. fixes #22715. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23051 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 00:22:11 +00:00
Andrew Nacin 4e94295826 Remove options-privacy.php, as intended by [21838]. see #16416. see #22349. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23050 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-05 00:16:54 +00:00
Andrew Nacin d2ed0a5401 Media views: Better checkbox positioning. props helenyhou. fixes #22724. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23049 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 23:56:37 +00:00
Ryan Boren e13e333569 When inserting an image From URL, show the fields only if it looks like we have a valid image. 
Props koopersmith
fixes #22740


git-svn-id: https://develop.svn.wordpress.org/trunk@23048 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 23:07:41 +00:00
bumpbot 2e35cea2fa Compress scripts/styles: 3.5-RC3-23047. TinyMCE updated. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23047 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 22:44:27 +00:00
Ryan Boren 52b234de11 When deleting an image in the editor with the delete or backspace keys, hide the edit and delete popup buttons. 
Props azaozz, lessbloat
fixes #22717


git-svn-id: https://develop.svn.wordpress.org/trunk@23046 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 22:42:26 +00:00
Ryan Boren b5fdf3753f In the media modal, clear attachment details when clearing the selection. 
Props koopersmith
fixes #22718


git-svn-id: https://develop.svn.wordpress.org/trunk@23045 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 22:19:08 +00:00
Andrew Nacin 71e16147bb Use correct button class hierarchy to ensure the 'Update' button is button-large. see #21598. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23044 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 22:02:25 +00:00
bumpbot db2e7dc099 Compress scripts/styles: 3.5-RC3-23043. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23043 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 20:58:33 +00:00
Andrew Nacin d1c428faed Media: When doing a multiple-insert into the editor, separate each inserted item with two line breaks. props tar.gz. see #22720. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23042 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 20:52:58 +00:00
Andrew Nacin 6d580e34db When adding images to a gallery, use "Images" as the filter name, rather than "All media items". props koopersmith. fixes #22722. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23041 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 20:51:37 +00:00
bumpbot 60b3adaa09 Compress scripts/styles: 3.5-RC3-23040. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23040 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 19:56:16 +00:00
Andrew Ozz 4f4e7e5cec RTL: properly align the demo image in the Edit Image popup, props nacin, fixes #22733 
git-svn-id: https://develop.svn.wordpress.org/trunk@23039 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 19:51:35 +00:00
Andrew Nacin a033ad1ab2 Image editor doc fixes. props DH-Shredder. see #6821. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23038 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 19:42:28 +00:00
Andrew Nacin 0fa07588c5 Media: Properly select the select element's option in the attachment display settings. props koopersmith. fixes #22693. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23037 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 19:38:16 +00:00
Andrew Nacin 39049254ae Move utils.js (cookie and user setting functions) to wp-includes to enable front-end use. 
Make it a dependency of media-views (and therefore media-editor). Move its userSettings JS object from admin-header to being paired with the script in script loader.

see #22730.



git-svn-id: https://develop.svn.wordpress.org/trunk@23036 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 19:29:56 +00:00
bumpbot fde1031744 Compress scripts/styles: 3.5-RC3-23035. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23035 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 18:58:30 +00:00
Andrew Nacin 34291d7f6c Media: Fix vertical and horizontal alignment of the gallery "Random" checkbox, and checkbox settings in general. Includes RTL. props koopersmith. fixes #22724. 
git-svn-id: https://develop.svn.wordpress.org/trunk@23034 602fd350-edb4-49c9-b593-d223f7449a82
 2012-12-04 18:51:27 +00:00