Commit Graph

28478 Commits

Author SHA1 Message Date
Scott Taylor
218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:46:53 +00:00
Scott Taylor
91dcf8796b In image_size_input_fields():
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30981 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:18:12 +00:00
Scott Taylor
a75c7977b9 In wp_import_handle_upload():
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30980 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 21:09:11 +00:00
Scott Taylor
f6f12912e2 Improve some docs for @param. Remove an unneeded $wpdb global import.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30979 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:55:21 +00:00
Scott Taylor
04ed6499cd Improve some wp-admin/includes/class-wp-filesystem-*.php docs for @param.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30978 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:39:41 +00:00
Andrew Ozz
6695ac3bab Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30977 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 19:33:01 +00:00
Boone Gorges
fd4231c2a1 Use correct notation for global functions in @covers test annotations.
Props sgrant.
Fixes #30769.

git-svn-id: https://develop.svn.wordpress.org/trunk@30976 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-19 15:20:41 +00:00
Andrew Nacin
26eeb623a6 About page: CDN images.
git-svn-id: https://develop.svn.wordpress.org/trunk@30971 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 17:54:43 +00:00
Andrew Nacin
657768ff9c Update theme POT files in trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30969 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 17:00:41 +00:00
Lance Willett
2f096d219f Bundled Themes: bump version numbers to coordinate with 4.1 release.
git-svn-id: https://develop.svn.wordpress.org/trunk@30967 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 16:18:14 +00:00
Andrew Nacin
e8e2db6e00 Update bundled theme POT files in trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30965 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 01:32:09 +00:00
Andrew Nacin
47d5cadf38 Add Slack notifications to Travis CI config. fixes #30755.
git-svn-id: https://develop.svn.wordpress.org/trunk@30963 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 23:50:37 +00:00
Lance Willett
439d540c20 Twenty Fifteen: use better, universal sans-serif fonts for RTL, similar to Twenty Ten which also had serif fonts throughout.
Props iamtakashi, see #30752.

git-svn-id: https://develop.svn.wordpress.org/trunk@30961 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 22:29:08 +00:00
Andrew Nacin
d268aaf37f Update version numbers in trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30960 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 17:37:16 +00:00
Lance Willett
6a312bdd21 Twenty Fifteen: ensure RTL editor font style is consistent with front-end font style.
Props iamtakashi and alex-ye, see #30746.

git-svn-id: https://develop.svn.wordpress.org/trunk@30956 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 17:21:29 +00:00
Lance Willett
340f6052fd Twenty Fifteen: ensure menu icon is properly centered for RTL views on small screens.
Props iamtakashi, fixes #30739.

git-svn-id: https://develop.svn.wordpress.org/trunk@30955 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:38:51 +00:00
Boone Gorges
b824d6f56c Update individual term caches in get_terms().
This was removed in [29915] as part of the attempt to add cache support to
`get_term_by()`. When that support was removed in [30900], it was not properly
restored.

This changeset includes a unit test to verify that the cache is properly primed
for terms found in `get_terms()`, as well as tests to verify the other cache
setting that was touched by [30900].

Fixes #30749. See #21760.

git-svn-id: https://develop.svn.wordpress.org/trunk@30954 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:38:44 +00:00
Lance Willett
c7d2f360cb Twenty Fifteen: fix styles for screen-reader-only search button in small screens.
Props iamtakashi, fixes #30744.

git-svn-id: https://develop.svn.wordpress.org/trunk@30953 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:37:05 +00:00
Helen Hou-Sandi
908a2e87c8 Ensure inline code examples stay LTR, punctuation and all.
props alex-ye.
see #30748.


git-svn-id: https://develop.svn.wordpress.org/trunk@30952 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:21:54 +00:00
Helen Hou-Sandi
d34709eaa5 About page: Don't allow tab text to wrap.
Some language, browser, and OS combinations (notably Arabic, Chrome, and Windows) were wrapping.

see #30743.


git-svn-id: https://develop.svn.wordpress.org/trunk@30951 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:01:42 +00:00
Dominik Schilling (ocean90)
fabd47a2ff About: Fix the WordPress badge.
`css-clean` (minifies our CSS) has an issue when using multiple backgrounds and background position together. Instead of relying on browser support for multiple backgrounds to display the WP logo as SVG, use the `.svg` CSS class.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30946 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:53:25 +00:00
Lance Willett
e2c36c3176 Twenty Fifteen: hide search input cancel button. See #30728.
git-svn-id: https://develop.svn.wordpress.org/trunk@30945 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:42:24 +00:00
Dominik Schilling (ocean90)
7560f4cf8c Pass locale to wordpress.org theme/plugin API.
In the future this will be used to return localized plugin/theme info.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30944 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:38:52 +00:00
Dominik Schilling (ocean90)
6873e08839 Twenty Fifteen: Use dynamic default color value instead of hardcoded color.
props iamtakashi.
see #30733.

git-svn-id: https://develop.svn.wordpress.org/trunk@30932 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 21:34:46 +00:00
Andrew Nacin
b4dc6629cd Last about page string. props celloexpressions. fixes #30435.
git-svn-id: https://develop.svn.wordpress.org/trunk@30929 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 21:26:34 +00:00
John Blackbourn
9189fbcff9 Make the DFW paragraph on the About page narrower to mitigate an orphan in Firefox.
See #30435
Props melchoyce


git-svn-id: https://develop.svn.wordpress.org/trunk@30921 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 20:01:56 +00:00
Dominik Schilling (ocean90)
e7f2ebf414 Customizer: Add more QUnit tests to improve coverage on the new models.
Includes tests for the broken `activate()`/`deactivate()` methods, which were fixed in [30871].

props westonruter.
see #30701.

git-svn-id: https://develop.svn.wordpress.org/trunk@30919 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 19:43:22 +00:00
Mark Jaquith
93ea9862a5 Revert [30036].
see #18035

git-svn-id: https://develop.svn.wordpress.org/trunk@30912 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 17:34:17 +00:00
Lance Willett
8d69099344 Twenty Fifteen: fallback hex color for no-comments text should come first.
Props iamtakashi, fixes #30730.

git-svn-id: https://develop.svn.wordpress.org/trunk@30910 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 16:18:40 +00:00
Scott Taylor
c9707a4a31 In response to regressions on .com, fix MEjs styles for screen reader text and overflow on the volume slider.
Props obenland.
See #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30907 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 15:12:35 +00:00
Dominik Schilling (ocean90)
b258a6c144 Twenty Fifteen: Remove unnecessary esc_html() from get_the_date() and get_the_modified_date().
see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30905 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 14:18:48 +00:00
John Blackbourn
2069d52fa1 Move a <code> tag out of a localised string on the About page.
Props pavelevap
See #30435


git-svn-id: https://develop.svn.wordpress.org/trunk@30903 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 14:03:53 +00:00
Dominik Schilling (ocean90)
1ca9749c93 Twenty Fifteen: Remove esc_html() from get_the_author().
The display name is sanitized through `sanitize_text_field`, `wp_filter_kses`, and `_wp_specialchars`.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30901 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 13:39:32 +00:00
Boone Gorges
bf62165353 Remove caching for get_term_by() calls.
The new cache group scheme causes term invalidation to be overly broad, so
that busting the cache for one term will bust the cache for all terms in the
taxonomy. We'll have another go at more focused use of the 'last_changed'
incrementor in a future release.

Reverts [29915], [30073], [30080], [30108], [30112].
See #21760.

git-svn-id: https://develop.svn.wordpress.org/trunk@30900 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 13:26:19 +00:00
Dominik Schilling (ocean90)
3a63ae0cb2 Twenty Fifteen: Don't escape translated strings.
Replace every unnecessary instance of `esc_html_x()` with just `_x()`.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30899 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 13:24:38 +00:00
Dominik Schilling (ocean90)
5447103756 Twenty Fifteen: Remove esc_html() from blog description.
The blog description gets esc_html()'d *into* the DB. It's also escaped because the filter for `get_bloginfo()` is set to 'display'.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30897 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 13:19:17 +00:00
Dominik Schilling (ocean90)
25ffd56152 Twenty Fifteen: Don't escape translated strings.
Replace every unnecessary instance of `esc_html__()` and `esc_html_e()` with just `__()` and `_e()`.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30896 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 12:59:59 +00:00
Dominik Schilling (ocean90)
754fc5f22d Twenty Fifteen: Don't save unfiltered CSS in a setting.
Introduce `twentyfifteen_get_color_scheme_css( $colors )` which will be used for Underscore/Backbone and the PHP side. Let `twentyfifteen_color_scheme_css()` handle the color calculation on PHP side.

see #30409.

git-svn-id: https://develop.svn.wordpress.org/trunk@30893 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 12:26:49 +00:00
Dominik Schilling (ocean90)
8f323ecf9a Customizer: Export Preview instance to wp.customize.preview.
see #30409, #30726.

git-svn-id: https://develop.svn.wordpress.org/trunk@30891 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 11:52:38 +00:00
Andrew Nacin
daf16cdb63 Call it 'Distraction-free writing mode' and update the help string. fixes #30657.
git-svn-id: https://develop.svn.wordpress.org/trunk@30890 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:06:17 +00:00
Andrew Nacin
855ff22a53 Update/add plugin recommendation strings.
Update [30887], add a translation function to the Vine string.

fixes #30337. see #30435.


git-svn-id: https://develop.svn.wordpress.org/trunk@30889 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:05:09 +00:00
Andrew Nacin
07e7f03373 Updates to the 'Log out everywhere' implementation.
* Include a message and a disabled button when you're only logged in at one location.
 * Avoid leaking the session token in HTML.
 * Simplify, simplify, simplify.

see #30264.


git-svn-id: https://develop.svn.wordpress.org/trunk@30888 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 09:15:01 +00:00
Andrew Nacin
82d0ba4b60 Finalize two more about page strings. see #30435.
git-svn-id: https://develop.svn.wordpress.org/trunk@30887 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 08:57:11 +00:00
Dion Hulse
1e721a144b Add braces around a Docblock in an if statement, although not required by PHP, this is required by our coding standards for readability.
Introduced in 3.9 with r27365
See #25905


git-svn-id: https://develop.svn.wordpress.org/trunk@30886 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 05:51:49 +00:00
Dominik Schilling (ocean90)
c959c4d4b3 Customizer: Add _wp_attachment_is_custom_background meta to uploaded background images.
Adds `$type` property to `WP_Customize_Background_Image_Control` (PHP) and introduces `wp.customize.BackgroundControl` (JS).

see #30707.

git-svn-id: https://develop.svn.wordpress.org/trunk@30885 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 23:27:17 +00:00
Dominik Schilling (ocean90)
d5299a9522 Autoprefixer for [30857].
see #30435.

git-svn-id: https://develop.svn.wordpress.org/trunk@30884 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 23:19:06 +00:00
John Blackbourn
0533e9bd8c Correct the height of the search type select element when searching the plugin directory.
See #30719
Props pavelevap, eliorivero


git-svn-id: https://develop.svn.wordpress.org/trunk@30879 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 22:31:35 +00:00
John Blackbourn
5918c5d365 Clarify the behaviour of the wp_editor_set_quality and jpeg_quality filters.
Props DH-Shredder
See #29856


git-svn-id: https://develop.svn.wordpress.org/trunk@30874 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 21:42:32 +00:00
John Blackbourn
4f35288dd1 Add tests which ensure the wp_editor_set_quality and jpeg_quality filters only apply if they are added before the corresponding WP_Image_Editor is instantiated.
Props DH-Shredder
See #29856


git-svn-id: https://develop.svn.wordpress.org/trunk@30873 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 21:24:21 +00:00
Dominik Schilling (ocean90)
663d12c8f8 Customizer: Remove date filter from the Header/Background Image upload frames.
Adds an option to `wp.media.view.AttachmentsBrowser` to hide the date filter added in [29813].

see #30689.

git-svn-id: https://develop.svn.wordpress.org/trunk@30872 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-15 20:26:54 +00:00