Commit Graph

41097 Commits

Author SHA1 Message Date
Sergey Biryukov
9b5ac0f6b6 I18N: Add missing placeholders to some translators comments in wp-admin.
Props ramiy.
Fixes #49248.

git-svn-id: https://develop.svn.wordpress.org/trunk@47093 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 15:41:50 +00:00
Sergey Biryukov
49402824a1 I18N: Correct translator comment in wp-admin/options-permalink.php.
Props ramiy.
Fixes #49247.

git-svn-id: https://develop.svn.wordpress.org/trunk@47092 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 15:08:45 +00:00
Sergey Biryukov
26f27a24d8 I18N: Merge duplicate %1$s is not of type %2$s strings in rest_validate_value_from_schema().
Props ramiy.
Fixes #49244.

git-svn-id: https://develop.svn.wordpress.org/trunk@47091 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 14:42:12 +00:00
Sergey Biryukov
8738b08b2e I18N: Remove unnecessary HTML from "Active:" strings in wp-admin/themes.php.
Follow-up to [45435].

Props ramiy.
Fixes #49243.

git-svn-id: https://develop.svn.wordpress.org/trunk@47090 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 14:25:13 +00:00
Sergey Biryukov
5f937b4c70 I18N: Correct translator comments in WP_Users_List_Table::get_views() to provide information about each placeholder.
Props ramiy.
Fixes #49242.

git-svn-id: https://develop.svn.wordpress.org/trunk@47089 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 14:06:57 +00:00
Sergey Biryukov
a8f4ed69de Docs: Update links to https://secure.php.net/, they now redirect to https://www.php.net/.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47088 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 03:12:12 +00:00
Sergey Biryukov
88836de35c Docs: Correct description for shortcode_atts_{$shortcode} filter.
Props glebkema.
Fixes #49225.

git-svn-id: https://develop.svn.wordpress.org/trunk@47087 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-19 13:39:21 +00:00
Sergey Biryukov
480b5c88c3 Mail: Remove angle brackets from password reset URL in emails sent by retrieve_password() and wp_new_user_notification().
The brackets were originally added in [16285] per W3C recommendation in https://www.w3.org/Addressing/URL/5.1_Wrappers.html to avoid wrapping the URL across multiple lines in plain text in older email clients.

This doesn't seem like a common issue in modern email clients, and the current implementation causes more issues than it solves. Since the URL is on a line by itself, it should not require any delimiters.

The URL in recovery mode email introduced in [44973] doesn't have angle brackets, so it's time to retire them in password reset email too if they're not used consistently.

Props donmhico, Otto42, sproutchris, iandunn, dd32, DaveWP196, sebastian.pisula, tommix, sablednah, julian.kimmig, Rahe, clayisland, arenddeboer, nicole2292, nagoke, squarecandy, eatingrules, SergeyBiryukov.
Fixes #21095, #23578, #44589.

git-svn-id: https://develop.svn.wordpress.org/trunk@47086 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 02:30:24 +00:00
Sergey Biryukov
5d8f784daa Networks and Sites: Clarify the recommendation to remove the www prefix from the site domain before creating a network.
The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL.

Props kharisblank, tobifjellner, ramiy.
Fixes #49214.

git-svn-id: https://develop.svn.wordpress.org/trunk@47085 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 01:13:12 +00:00
Sergey Biryukov
89dc54ee0c Docs: Improve comments in some wp-admin files per the documentation standards.
Props passoniate.
Fixes #49215, #49216.

git-svn-id: https://develop.svn.wordpress.org/trunk@47084 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 00:52:28 +00:00
Sergey Biryukov
bd59d22a81 Coding Standards: Remove unnecessary // phpcs:ignore instances in WP_Debug_Data.
`WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too.

Additionally, remove one short ternary instance, not allowed per the coding standards.

See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47083 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 00:24:57 +00:00
Sergey Biryukov
b02161c98e Widgets: Remove extra padding from number inputs in Recent Posts and Recent Comments widgets.
Props marcio-zebedeu, audrasjb, SergeyBiryukov.
Fixes #49195.

git-svn-id: https://develop.svn.wordpress.org/trunk@47082 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 13:55:22 +00:00
Sergey Biryukov
8660569e82 Date/Time: Add some basic tests for current_time().
Props pbearne, talldanwp, SergeyBiryukov.
Fixes #34378.

git-svn-id: https://develop.svn.wordpress.org/trunk@47081 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 02:50:39 +00:00
Sergey Biryukov
0ead760ec6 Tests: Replace date() with gmdate() in WP_Test_REST_Posts_Controller tests.
Follow-up to [45424], [46252].

See #46438, #44491, #39953.

git-svn-id: https://develop.svn.wordpress.org/trunk@47080 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 02:02:41 +00:00
Sergey Biryukov
a2978bac70 Tests: Update the wp_maybe_decline_date() tests for [47078].
See #48934.

git-svn-id: https://develop.svn.wordpress.org/trunk@47079 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 01:14:24 +00:00
Sergey Biryukov
5bef137806 Date/Time: Pass the date format to wp_maybe_decline_date().
This ensures that the function has enough context to determine the necessity of replacing the month name with the correct form in locales that require it.

Props SergeyBiryukov, Rarst.
Fixes #48934.

git-svn-id: https://develop.svn.wordpress.org/trunk@47078 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 01:10:57 +00:00
Sergey Biryukov
93b2d5ecc0 Tests: Revert [47076], this should have been committed with the related changes to the function.
git-svn-id: https://develop.svn.wordpress.org/trunk@47077 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 01:08:28 +00:00
SergeyBiryukov
abfca60342 Tests: Move wp_maybe_decline_date() tests to the date directory.
See #48934.

git-svn-id: https://develop.svn.wordpress.org/trunk@47076 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 00:54:02 +00:00
Sergey Biryukov
900b3fd6a8 Accessibility: Login and Registration: Add a role="main" landmark to the container div in wp-signup.php.
Props SteelWagstaff, audrasjb.
Fixes #48657.

git-svn-id: https://develop.svn.wordpress.org/trunk@47075 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-16 03:42:38 +00:00
Sergey Biryukov
6baa60ac68 Login and Registration: Remove duplicate <label> tag from show_blog_form() in wp-signup.php.
Props vaishalipanchal, audrasjb.
Fixes #49174.

git-svn-id: https://develop.svn.wordpress.org/trunk@47074 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-16 00:32:56 +00:00
Sergey Biryukov
cf0a453f08 Date/Time: Use wp_date() to display the correct time of the next DST transition in Timezone setting on General Settings screen.
Props Rarst, autotutorial.
Fixes #49038.

git-svn-id: https://develop.svn.wordpress.org/trunk@47073 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-16 00:26:08 +00:00
Sergey Biryukov
fd479f9537 Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor.
Props pratik-jain, justinahinon, audrasjb.
Fixes #49115.

git-svn-id: https://develop.svn.wordpress.org/trunk@47072 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-15 18:29:11 +00:00
Sergey Biryukov
fc944f9927 File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens.
Props passoniate.
Fixes #49197.

git-svn-id: https://develop.svn.wordpress.org/trunk@47071 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-15 00:21:26 +00:00
Sergey Biryukov
06775e4df0 Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process.
Props garrett-eclipse, audrasjb.
Fixes #49018.

git-svn-id: https://develop.svn.wordpress.org/trunk@47070 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-14 01:09:03 +00:00
Sergey Biryukov
92fc229ca0 Site Health: Avoid "Undefined property" PHP notices in wp_dashboard_site_health() when the status result transient does not exist yet.
Props dlh for initial patch.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47069 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-13 17:25:26 +00:00
Sergey Biryukov
5ee2e239dc Cron API: Use WEEK_IN_SECONDS constant for the weekly schedule added in [47062].
Props afercia.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47068 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-13 17:03:39 +00:00
Sergey Biryukov
d9501dd5d5 Networks and Sites: Use warning styles for 'Caution' and 'Warning' messages during Multisite installation.
Props dlh.
Fixes #49186.

git-svn-id: https://develop.svn.wordpress.org/trunk@47067 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-13 16:58:06 +00:00
Sergey Biryukov
14376be6e1 Docs: Correct description for show_in_admin_all_list and show_in_admin_status_list arguments of register_post_status().
Props audrasjb.
Fixes #49180.

git-svn-id: https://develop.svn.wordpress.org/trunk@47066 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-13 00:48:27 +00:00
Sergey Biryukov
9b38bca65f Docs: Improve documentation for wp_save_image_file() and related functions.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47065 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-12 16:54:56 +00:00
Sergey Biryukov
2daa4b6c82 Tests: In Tests_Site_Health, create a WP_Site_Health instance before clearing the cron array, as the constructor schedules its own task now.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47064 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-12 14:16:57 +00:00
Sergey Biryukov
396cc8205b Site Health: Introduce Site Health Status dashboard widget.
The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details.

Props Clorith, hedgefield, guddu1315.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47063 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-12 13:31:49 +00:00
Sergey Biryukov
5eaf1605e8 Cron API: Add a new cron schedule for weekly events.
Props Clorith.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47062 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-12 11:18:03 +00:00
Sergey Biryukov
eb7bf9ccd3 Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation.
With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.

Props casiepa, danieltj, tobifjellner, netweb.
Fixes #43242.

git-svn-id: https://develop.svn.wordpress.org/trunk@47061 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-12 02:22:17 +00:00
Sergey Biryukov
4c2ee4e9ff Docs: In various @return tags, list the expected type first, instead of false.
Follow-up to [46696].

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47060 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-11 18:30:58 +00:00
Sergey Biryukov
f9e52f8cd3 Docs: Synchronize @return descriptions for ::handle_row_actions() methods in list tables.
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.

See #49170, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47059 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-11 17:56:15 +00:00
Sergey Biryukov
1824604fc0 Docs: Correct @return description for WP_List_Table::handle_row_actions().
Props pbiron.
Fixes #49170.

git-svn-id: https://develop.svn.wordpress.org/trunk@47058 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-11 17:55:49 +00:00
Sergey Biryukov
5dbe5a8355 Docs: Correct @return type for Theme_Upgrader::check_parent_theme_filter().
Props diddledan.
Fixes #48570.

git-svn-id: https://develop.svn.wordpress.org/trunk@47057 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-11 02:44:17 +00:00
Sergey Biryukov
4a854cd44f Docs: Remove a reference to WordPress 2.7 from readme.html.
Props afercia, donmhico.
Fixes #47963.

git-svn-id: https://develop.svn.wordpress.org/trunk@47056 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-10 14:03:50 +00:00
Sergey Biryukov
32ccb24cb0 Docs: Remove @return void from widget DocBlocks.
Per the documentation standards, it should not be used outside of the default bundled themes.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47055 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-10 00:28:10 +00:00
Sergey Biryukov
f243dc38c0 Coding Standards: Use strict comparison and Yoda conditions in the root directory files.
Props pikamander2.
Fixes #48965.

git-svn-id: https://develop.svn.wordpress.org/trunk@47054 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-09 00:53:29 +00:00
Jonathan Desrosiers
424071a2b6 Bundled Themes: Remove duplicate font-size property in Twenty Twenty.
Props ankitmaru.
Fixes #49015.



git-svn-id: https://develop.svn.wordpress.org/trunk@47053 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-08 16:48:43 +00:00
Sergey Biryukov
90db6f5941 Docs: Correct alphabetic order of parameters in WP_Query::parse_query() DocBlock.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47052 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-08 12:08:49 +00:00
Jorge Costa
e02ebc183b Block Editor: Update WordPress Packages.
Updated packages:
@wordpress/annotations: 1.7.2 -> 1.9.0
@wordpress/api-fetch: 3.6.4 -> 3.8.0
@wordpress/block-directory: 1.0.5 -> 1.2.0
@wordpress/block-editor: 3.2.5 -> 3.4.0
@wordpress/block-library: 2.9.6 -> 2.11.0
@wordpress/blocks: 6.7.2 -> 6.9.0
@wordpress/components: 8.3.2 -> 8.5.0
@wordpress/compose: 3.7.2 -> 3.9.0
@wordpress/core-data: 2.7.5 -> 2.9.0
@wordpress/data: 4.9.2 -> 4.11.0
@wordpress/data-controls: 1.3.4 -> 1.5.0
@wordpress/date: 3.5.0 -> 3.7.0
@wordpress/dom: 2.5.2 -> 2.6.0
@wordpress/e2e-test-utils: 3.0.0 -> 4.0.0
@wordpress/edit-post: 3.8.6 -> 3.10.0
@wordpress/editor: 9.7.6 -> 9.9.0
@wordpress/element: 2.8.2 -> 2.10.0
@wordpress/escape-html: 1.5.1 -> 1.6.0
@wordpress/format-library: 1.9.5 -> 1.11.0
@wordpress/i18n: 3.6.1 -> 3.7.0
@wordpress/keycodes: 2.6.2 -> 2.7.0
@wordpress/list-reusable-blocks: 1.8.4 -> 1.10.0
@wordpress/media-utils: 1.2.4 -> 1.4.0
@wordpress/notices: 1.8.2 -> 1.10.0
@wordpress/nux: 3.7.2 -> 3.9.0
@wordpress/plugins: 2.7.2 -> 2.9.0
@wordpress/rich-text: 3.7.2 -> 3.9.0
@wordpress/scripts: 6.0.0 -> 6.1.1
@wordpress/server-side-render: 1.3.4 -> 1.5.0
@wordpress/shortcode: 2.4.1 -> 2.5.0
@wordpress/token-list: 1.6.1 -> 1.8.0
@wordpress/url: 2.8.2 -> 2.9.0
@wordpress/viewport: 2.8.2 -> 2.10.0

Props gziolo, youknowriad.
Fixes #49142.

git-svn-id: https://develop.svn.wordpress.org/trunk@47051 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-08 11:55:03 +00:00
Sergey Biryukov
7b0f5e5de8 Coding Standards: Use Yoda conditions in wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php.
Props jenilk.
Fixes #49150.

git-svn-id: https://develop.svn.wordpress.org/trunk@47050 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-08 11:30:37 +00:00
Sergey Biryukov
6bf5238ebb Docs: Indicate that load_script_textdomain_relative_path filter value can be false.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47049 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-08 00:25:04 +00:00
Grzegorz (Greg) Ziółkowski
01a3632b15 Build Tools: do not include assets for JS dependencies that do not exist.
This is a follow-up for #48154, where we started including *.asset.php files to declare package dependencies.
This works well but creates warnings in environments where the package does not exist because WordPress was not fully built.

Props jeherve, swissspidy.

Fixes #49144.



git-svn-id: https://develop.svn.wordpress.org/trunk@47048 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-07 15:26:44 +00:00
Sergey Biryukov
638a948719 Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button.
Props garrett-eclipse.
Fixes #49139.

git-svn-id: https://develop.svn.wordpress.org/trunk@47047 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-07 00:07:53 +00:00
Sergey Biryukov
f216d9c73a REST API: Display the actual conflicting value in addition to the taxonomy name in the _doing_it_wrong() message for a conflicting rest_base or name property.
Follow-up to [47037] and [47045].

Props TimothyBlynJacobs.
See #48401.

git-svn-id: https://develop.svn.wordpress.org/trunk@47046 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-06 17:07:52 +00:00
Sergey Biryukov
105375cce7 REST API: Display the taxonomy name in the _doing_it_wrong() message for a conflicting rest_base or name property, to match the translator comment.
Follow-up to [47037].

See #48401.

git-svn-id: https://develop.svn.wordpress.org/trunk@47045 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-06 16:45:58 +00:00
Sergey Biryukov
6cd0e35c6b I18N: Replace rest_authentication_errors filter name with a placeholder in a translatable string.
Follow-up to [38947] and [40038].

See #38446.

git-svn-id: https://develop.svn.wordpress.org/trunk@47044 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-06 16:19:51 +00:00