Scott Taylor
febd12c957
Clean up @global
doc blocks/imports for class-wp-customizer-*.php
and friends.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32542 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 05:05:19 +00:00
Scott Taylor
7a683940d7
Create a function, wp_roles()
, to DRY the inline instantiation of the $wp_roles
global.
...
Add missing doc blocks for `capabilities.php`.
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32541 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 04:46:36 +00:00
Scott Taylor
0864ba691a
Add missing doc blocks for canonical.php
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32540 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 04:25:27 +00:00
Scott Taylor
de7b6c76ab
Add/standardize missing doc blocks for cache.php
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32539 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 04:23:15 +00:00
Scott Taylor
339d3be328
Add missing doc blocks to author-template.php
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32538 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 04:13:35 +00:00
Scott Taylor
d723ecc5f5
Add missing doc blocks to admin-bar.php
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32537 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 03:59:13 +00:00
Scott Taylor
55ce3d19ea
Add missing doc blocks to class-wp-editor.php
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32536 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 03:51:50 +00:00
Scott Taylor
9333337992
In class-wp-customize-*
, clarify/add some @param
/@return
blocks. Disambiguate some functions that are trying to return the void
response of another function they call internally.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32535 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 22:04:29 +00:00
Scott Taylor
369903cd85
In class-wp-admin-bar.php
, clarify/add some doc blocks.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32534 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 21:38:41 +00:00
Scott Taylor
4a362fdb7c
In class-oembed.php
, clarify/add some return
docs.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32533 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 21:30:31 +00:00
Scott Taylor
5261e8022a
In category.php
:
...
* Clarify some `return` docs.
* In `_make_cat_compat()`, ensure that `WP_Error` is not decorated
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32532 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 21:17:42 +00:00
Scott Taylor
51717c41af
In category-template.php
:
...
* Clarify/add some `return` docs.
* In `walk_category_tree()` and `walk_category_dropdown_tree()`, make behavior consistent and don't pass `$walker` by-reference - it is no longer necessary to do that with object instances.
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32531 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 21:04:32 +00:00
Scott Taylor
5ae33c082f
In capabilities.php
, clarify/add some return
docs.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32530 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:46:25 +00:00
Scott Taylor
e501a4227c
In canonical.php
:
...
* Clarify some docs
* `redirect_canonical()` inconsistently returns `null` or `false` when bailing - can simply return.
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32529 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:29:19 +00:00
Scott Taylor
63ab0981fc
In cache.php
, clarify some return
docs. Some WP_Object_Cache
methods return void
, so those wrapper functions don't need to return at all.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32528 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:21:22 +00:00
Scott Taylor
4eb97de4cf
In bookmark.php
, clarify some return
docs.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32527 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:12:41 +00:00
Scott Taylor
ff1eabd7e1
In author-template.php
, clarify/add some return
docs.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32526 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:09:44 +00:00
Scott Taylor
cb145bd1c0
In admin-bar.php
, most functions simply return when a conditional is not met. wp_admin_bar_render()
shouldn't explicitly return false
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32525 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:09:00 +00:00
Boone Gorges
f0d6031d9b
Streamline support for multiple post types in get_posts_by_author_sql()
.
...
* Don't accept a comma-separated list, only a single post type or an array of post types. This is easier to document.
* Add changelog entries to all calling functions.
Props DrewAPicture.
Fixes #32243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32524 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 19:48:19 +00:00
Boone Gorges
e656053bce
Support multiple post types in count_user_posts()
and other functions that use get_posts_by_author_sql()
.
...
Props nikonratm.
Fixes #32243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32523 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:42:49 +00:00
Helen Hou-Sandi
6d1e0f0704
Updates: Use the warning color for the backup notice, as it's not a success message.
...
props paulwilde.
fixes #32241 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32522 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:09:46 +00:00
jorbin
8bb46554a8
In List Tables, ensure sorting indicator is visible on focus
...
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose.
Happy #GAAD
Props afercia
Fixes #32189
git-svn-id: https://develop.svn.wordpress.org/trunk@32521 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:04:03 +00:00
Boone Gorges
5de66efda6
In sanitize_option()
, pass the unsanitized $value
to the filter.
...
Props simonwheatley, MikeHansenMe.
Fixes #26199 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32520 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 17:59:58 +00:00
Boone Gorges
15a0c621ea
Add tests for check_comment()
.
...
Props CalEvans, rachelbaker.
Fixes #31108 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32519 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-20 19:08:07 +00:00
John Blackbourn
064bed9792
Use the available user and blog factories in the Tests_Multisite_Option::test_with_another_site()
test.
...
Fixes #32404
git-svn-id: https://develop.svn.wordpress.org/trunk@32518 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-20 19:02:42 +00:00
Scott Taylor
e088947cea
In WP_Media_List_Table::get_views()
, declare $num_posts
explicitly before looping.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32517 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:49:59 +00:00
Scott Taylor
17fff532cd
In WP_Comments_List_Table::column_comment()
, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32516 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:45:36 +00:00
Scott Taylor
6378cb5d60
In wpdb::load_col_info()
, don't fetch the number of fields in the result row on each iteration of the for
loop. It can be stored in a var and referenced.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32515 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:29:30 +00:00
Jeremy Felt
6f4e407208
Move network update submenu items to the Network Dashboard menu item
...
Provides parity with the placement of the "Updates" submenu item in single site.
props Ipstenu.
fixes #32431 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32514 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 16:59:40 +00:00
Jeremy Felt
365c82b0c9
s/anbled/enabled/ in global_terms_enabled
filter documentation.
...
Fixes #32436 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32513 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 06:34:18 +00:00
Jeremy Felt
6063b2c0f9
Use WP_TESTS_DOMAIN
in test_get_blogaddress_by_id_with_valid_id()
...
A hard coded `example.org` would break the test if a custom `WP_TESTS_DOMAIN` was specified. We should defer to the configured default.
Fixes #32026 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32512 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 05:45:31 +00:00
Sergey Biryukov
09bd58b4c9
In comment_form()
, ensure that filtered arguments contain all required default values.
...
props boonebgorges.
fixes #32312 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@32511 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 01:03:39 +00:00
Sergey Biryukov
03e04a0c1c
Allow wp_dropdown_languages()
to return the markup instead of displaying.
...
props leewillis77, juliobox.
fixes #32432 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32510 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 00:32:10 +00:00
Helen Hou-Sandi
d800ebdf96
Accessibility: Ensure screen reader text is read as words and not affected by word-wrap.
...
props afercia.
fixes #31962 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32509 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-18 18:36:46 +00:00
Helen Hou-Sandi
42eb2ec407
Autoprefixer for [32506]. see #31874 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32508 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 20:43:02 +00:00
Boone Gorges
0027615ed1
Improve unit tests for wp_unique_term_slug()
.
...
See #20783 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32507 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 20:37:51 +00:00
Helen Hou-Sandi
691656f2cf
Media: Visually align upload errors with other admin notices.
...
props sagarjadhav.
fixes #31874 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32506 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 16:18:50 +00:00
Andrew Ozz
12b3b1c100
Fix dragging to the bottom of the screen on the Dashboard.
...
Props eltobiano. See #32094 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32505 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-14 23:49:44 +00:00
Dion Hulse
047c2fdadd
Allow plugins to activate other plugins within their Activation hook. Fixes #32368
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32504 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-14 06:57:47 +00:00
Scott Taylor
11671ad73b
In tb_show()
in thickbox
, when loading content into #TB_ajaxContent
, make sure a URL with no ?
doesn't break when &random=
is appended to it.
...
Thickbox hasn't been updated since 2007, just FYI.
Fixes #31726 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32503 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 21:41:47 +00:00
Scott Taylor
23e40ef756
In views/button/select-mode-toggle
, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's toggleBulkEditHandler
method.
...
Props afercia.
Fixes #32324 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32502 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 21:26:22 +00:00
John Blackbourn
8bcd566ee0
Add a viewport meta tag to wp_die()
.
...
Props leogopal
Fixes #29336
git-svn-id: https://develop.svn.wordpress.org/trunk@32501 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 04:07:46 +00:00
Drew Jaynes
f927722bc0
Update the DocBlock for wp_new_comment()
to reference the wp_insert_comment()
documentation for argument information.
...
Fixes #31747 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32500 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 02:53:03 +00:00
Drew Jaynes
6855376930
Document the default arguments for wp_insert_comment()
as a hash notation.
...
Props lamosty, rachelbaker.
See #31747 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32499 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 02:50:56 +00:00
Boone Gorges
3a47da7943
Respect $_wp_suspend_cache_invalidation
in clean_term_cache()
.
...
Props tollmanz, rmccue.
Fixes #28743 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32498 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 20:13:53 +00:00
Lance Willett
3d4fb6ce50
Twenty Fifteen: add missing social link Genericons styles for Skype and Path.
...
Fixes #32332 , props philiparthurmoore.
git-svn-id: https://develop.svn.wordpress.org/trunk@32497 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 18:14:04 +00:00
John Blackbourn
d01281af10
Add a sanity check to theme-compat/header.php
to avoid outputting CSS which could reference a non-existant file.
...
Props Mte90
Fixes 32240
git-svn-id: https://develop.svn.wordpress.org/trunk@32496 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 10:46:50 +00:00
Andrew Ozz
59eb437a35
Fix comments postbox:
...
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32495 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 01:21:58 +00:00
Lance Willett
3b9407b660
Twenty Twelve: fix typo in readme.txt file.
...
See #31814 , props TomasM.
git-svn-id: https://develop.svn.wordpress.org/trunk@32494 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-11 23:31:31 +00:00
Lance Willett
181b6ca317
Twenty Fifteen: fix typo in readme file, props obenland. Format the release dates as per other bundled themes readme.txt file format.
...
See #31814 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32493 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-11 21:55:18 +00:00