4088ca8723
Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
...
see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23563 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:00:25 +00:00
c363aea627
Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
...
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
a6c8efadb9
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
330c10d1a9
Kill use of colons in class names, props SergeyBiryukov, fixes #21152
...
git-svn-id: https://develop.svn.wordpress.org/trunk@22396 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-06 01:01:52 +00:00
43e28ec704
Handle screen arg in WP_Comments_List_Table constructor. Avoids warning when calling WP_Screen::get() later. fixes #22039
...
git-svn-id: https://develop.svn.wordpress.org/trunk@22085 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-29 10:05:15 +00:00
7e3e82dd32
Map 'all' to no status for get_comments() in the list table. See #21101 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@22081 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-28 21:46:24 +00:00
774a12be83
Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@21996 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 05:26:19 +00:00
4f8de0690c
Add restrict_manage_comments hook. props hardy101. fixes #21344 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@21985 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-24 21:23:43 +00:00
1c58ef9f33
Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@21944 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-21 19:34:23 +00:00
7d6e53317c
New button styles.
...
Using the new buttons:
* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".
For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.
get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).
props lessbloat, helenyhou, trepmal, nacin. see #21598 .
git-svn-id: https://develop.svn.wordpress.org/trunk@21789 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-08 04:58:34 +00:00
dcb0d4fe80
Restore global references that broke the media and comment list tables. Todo, make list tables rely far less on global state. see #21309 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@21736 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-04 18:23:51 +00:00
31ec698423
Use get_post() instead of global $post.
...
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.
Props nacin
see #21309
git-svn-id: https://develop.svn.wordpress.org/trunk@21735 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-04 16:29:28 +00:00
dd15327790
More screen reader text for list table checkboxes and theme install search. Props MikeLittle, SergeyBiryukov. see #21325
...
git-svn-id: https://develop.svn.wordpress.org/trunk@21323 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-25 16:18:14 +00:00
c47eef91e0
Add screen reader text to checkboxes in list tables. Props MikeLittle, nacin. see #21325
...
git-svn-id: https://develop.svn.wordpress.org/trunk@21317 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-24 18:01:22 +00:00
42437fa97e
Remove "Approve" bulk action when viewing spam comments as it isn't shown in the row actions. Props russellwwest. Fixes #20123 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20533 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-19 14:00:44 +00:00
d90bb2403a
Make comment type filter persist across views (e.g. approved, spam) of the list of comments. Fixes #20281 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20350 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-04 17:36:23 +00:00
96c2ae4409
'No comments awaiting moderation.' props demetris. fixes #15689 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19723 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-09 19:53:51 +00:00
2b186b0c45
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
29a5a0e192
Don't show edit links for spam comments. Props DH-Shredder. fixes #18340
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19296 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-15 14:02:42 +00:00
7dd1ec898b
Use 'View Post' instead of '#' for view post links in comment rows. Props SergeyBiryukov. fixes #18846
...
git-svn-id: https://develop.svn.wordpress.org/trunk@18868 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-03 14:03:01 +00:00
ab660228ab
Fix the action links broken by [18594]. Fixes #18447 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@18599 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-25 08:05:15 +00:00
ade9233305
End each row with a new line to make the raw HTML easier to read.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@18595 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-24 11:13:33 +00:00
4dfdd2e9b2
Include all comment css classes when outputing the rows in the Comments admin page to allow for easy customisation by plugins. Fixes #18447 props josephscott.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@18594 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-24 11:12:07 +00:00
657155ed7c
Remove duplicate IDs before passing comment post IDs to get_pending_comments_num()
...
git-svn-id: https://develop.svn.wordpress.org/trunk@18041 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-25 17:36:26 +00:00
9730cb8d15
Constructor cleanup. Props ocean90. fixes #16768
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17771 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-29 20:05:12 +00:00
b625dbb1bb
Remove debug cruft. Props markmcwilliams. fixes #15530
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17383 602fd350-edb4-49c9-b593-d223f7449a82
2011-02-03 20:00:21 +00:00
bdd25aad05
Update counts and pagination when trashing and moderating comments. Props garyc40, koopersmith, mdawaffe, nacin. fixes #15530
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17354 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-22 18:47:42 +00:00
d59f1e165e
Global comment_type in WP_Comments_List_Table::prepare_items(). props jorbin, fixes #16344 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17350 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-22 18:27:04 +00:00
a399fa0529
Use only an ID, no name, on the 'Filter' buttons on list screens. see #16345 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17349 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-22 18:25:32 +00:00
4bca42b961
Fix the comments "river." issue 9. props garyc40. see #16262
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17344 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-21 21:17:12 +00:00
2b4674a3b4
Remove AJAX from list tables. first pass. see #16262 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17322 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-16 21:47:24 +00:00
6d0af32ea7
Add nonces to instances where the list table display() method is overridden. see #16188 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17262 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-11 22:42:22 +00:00
eba71eb7c0
Bring out the shears.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17228 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-06 04:11:14 +00:00
d554c850ac
Hard limit to 10 comments on edit post screen. Props greuben. fixes #15998
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17168 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-29 15:58:46 +00:00
9f9f401c42
Fix comment manipulation on edit post screen. Props garyc40. fixes #15876
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17113 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-22 19:03:43 +00:00
63ff32198f
Display placeholder when no comments found. props garyc40. fixes #15937
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17103 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-21 17:34:29 +00:00
96e692baed
Always display the table, with a placeholder row when there are no items. Fixes #15849
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17002 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 19:05:14 +00:00
266cd3f5df
Replace check_permissions() with ajax_user_can(). New method returns true/false to current_user_can(), which we then handle in admin ajax. see #15326 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16992 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 09:18:28 +00:00
1d3a1c1460
Fix error when trashing a comment on the last page. Props garyc40. Fixes #15500
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16911 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-14 11:53:31 +00:00
6dc2d07bc4
Pink trailing whites.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16900 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-13 21:21:50 +00:00
a3c3dc3273
Fix strange JS error when trashing a comment. Props greuben. Fixes #15746
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16836 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-09 14:16:35 +00:00
907353550e
Get rid of in favor of . Fixes #15607 . See #15580
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16617 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-29 20:15:04 +00:00
2116903ae6
Make comment content column unsortable. See #15580
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16588 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-25 18:45:28 +00:00
b1417100ce
Error suppression is lame!
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16565 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-24 11:19:23 +00:00
55e0256967
esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16431 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-17 17:12:01 +00:00
a6568c3de8
Make submitted-on a class instead of an id. Fixes #15426
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16375 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-14 20:28:55 +00:00
9f69a2211f
Fix post comments box and remove unused 'add-comment' ajax action. See #15338
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16371 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-14 18:19:45 +00:00
309b7e7ab3
Add back 'Submitted on ' text. Props zeo. See #14579
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16356 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-13 20:58:39 +00:00
beb9fea0c4
Fix 'response' column title. Props zeo. See #14579
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16355 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-13 20:53:21 +00:00
baaf0585dd
Use get_current_screen() in list table classes. Fixes #15338
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16235 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-08 15:43:44 +00:00
Ryan Boren
Andrew Ozz
Andrew Nacin
Daryl Koopersmith
Jon Cave
Peter Westwood
Mark Jaquith
scribu