Robert Anderson
251fd685dd
Comments: Fix title not updating when replying to a comment
...
When replying to an existing comment, the comment form is moved to below the
existing comment with JS, but the form heading was not being updated. This
fixes the issue by introducing a new data-attribute to the reply link with the
correct heading string, and applying that string to the heading when the form
is moved.
Props isabel_brison, azaozz, peterwilsoncc.
Fixes #38009 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47506 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-25 04:53:06 +00:00
Sergey Biryukov
36d112d1c8
Docs: Revert a type change for the $value
parameter of WP_Dependencies::add_data()
in [47170].
...
Although described as a string in several places, it's technically not limited to a particular type.
Props westonruter.
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47502 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-24 20:54:38 +00:00
Jorge Costa
afe1b96db2
Help/About: Fix a typo on the about page and fix a link.
...
The text "on your" appeared two times. This commit fixes the issue and removes the duplication. It also updates the field guide permalink.
Props garrett-eclipse, ixkaito, karmatosed, SergeyBiryukov.
git-svn-id: https://develop.svn.wordpress.org/trunk@47500 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-24 15:01:57 +00:00
Sergey Biryukov
8e3d204e04
Docs: Update inline comment in Tests_DB::test_locale_floats()
.
...
See #49572 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47498 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-24 01:05:31 +00:00
Andrew Ozz
41027e3f8e
Build/Test Tools: Introduce Install-changed. It keeps a hash of package.json
and compares it when run. If it has any changes, it runs npm install
.
...
This keeps `node_modules` always updated and is useful not only when the packages have been updated, but also when the working copy has been "reverted" to an earlier revision.
Fixes #49594 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47497 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-24 01:04:43 +00:00
Andrew Ozz
679fbbc422
Build/Test Tools: Fix PHPUnit bootstrap to install WP from /build
when tests are run with npm run test
, grunt test
, grunt
then phpunit
, etc.
...
Fixes #49663 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47496 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-24 00:18:29 +00:00
Jorge Costa
def0da1bbe
Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
...
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21083 .
Props itsjonq, mcsf, aduth.
Fixes : #49688 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47495 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-23 23:38:27 +00:00
Sergey Biryukov
ad8d01a7e9
Docs: Add missing @since
tags for WP_User_Request
properties.
...
Correct type for `$email`, `$confirmed_timestamp`, and `$completed_timestamp` properties.
Props pbiron, garrett-eclipse.
Fixes #49675 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47494 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-23 20:18:15 +00:00
Sergey Biryukov
630ba8979a
Administration: Add /
character to <img>
tag in WP_Plugin_Install_List_Table::display_rows()
.
...
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.
Props adnan.limdi, Soean.
Fixes #41904 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47493 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 18:35:46 +00:00
Sergey Biryukov
f44d456a4b
Upgrade/Install: Return a more appropriate HTTP response status code (409 Conflict
) if the wp-config.php
file already exists.
...
Props linyows, ocean90.
Fixes #42466 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47478 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-21 15:42:57 +00:00
Sergey Biryukov
7c15916c28
Coding Standards: Fix WPCS issue in [47475].
...
See #49295 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47476 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 17:31:13 +00:00
Sergey Biryukov
e45a2eb99d
Help/About: Add design for 5.4 About page.
...
Props melchoyce, marybaum, marktimemedia, elmastudio, ryelle, karmatosed, audrasjb, afercia, francina, sabernhardt.
See #49295 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47475 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 17:11:35 +00:00
Sergey Biryukov
827d77e341
Administration: Escape admin title on output after the admin_title
filter runs, not before.
...
Props lalitpendhare, adnan.limdi, subrataemfluence, andraganescu.
Fixes #41921 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47474 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 02:18:53 +00:00
Sergey Biryukov
7ede058b16
Privacy: Correct bottom padding for table of contents on Privacy Policy Guide on smaller screens.
...
Props jagirbahesh, birgire, garrett-eclipse.
Fixes #49570 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47473 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-19 20:43:13 +00:00
Sergey Biryukov
b0889a7639
Post Formats: Pass post type to the disable_formats_dropdown
filter in WP_Posts_List_Table::formats_dropdown()
.
...
Props MatheusFD, birgire.
Fixes #47959 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47472 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-18 19:11:33 +00:00
Andrew Ozz
baa9b2d1f0
Build Tools: Use the new combinedOutputFile
setting for the updated DependencyExtractionWebpackPlugin and output script-loader-packages.php
directly in wp-includes/assets/
.
...
Props gziolo, azaozz.
See: #48154 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47471 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-18 04:48:19 +00:00
Sergey Biryukov
e7022adab2
Docs: Correct the description of $hard
parameter in flush_rewrite_rules()
.
...
Props david.binda.
Fixes #49660 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47468 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-17 19:32:45 +00:00
Jorge Costa
f5c0507910
Block Editor: Update WordPress Packages WordPress 5.4 RC 3.
...
The following package versions were changed:
@wordpress/block-directory: 1.5.4 -> 1.5.5
@wordpress/block-editor: 3.7.4 -> 3.7.5
@wordpress/block-library: 2.14.4 -> 2.14.5
@wordpress/components: 9.2.3 -> 9.2.4
@wordpress/dependency-extraction-webpack-plugin: 2.3.0 -> 2.4.0
@wordpress/edit-post: 3.13.5 -> 3.13.6
@wordpress/editor: 9.12.4 -> 9.12.5
@wordpress/format-library: 1.14.4 -> 1.14.5
@wordpress/list-reusable-blocks: 1.13.3 -> 1.13.4
@wordpress/nux: 3.12.3 -> 3.12.4
@wordpress/server-side-render: 1.8.3 -> 1.8.4
Props aduth.
Fixes : #49657 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47462 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-16 22:05:14 +00:00
John Blackbourn
c8d918e476
Docs: Various docblock corrections and improvements.
...
See #49572
git-svn-id: https://develop.svn.wordpress.org/trunk@47461 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-16 18:38:03 +00:00
Sergey Biryukov
0bed3c251a
Tests: Use PUPPETEER_SKIP_CHROMIUM_DOWNLOAD
environment variable instead of config setting.
...
This is more consistent with the similar approach in Gutenberg Travis setup.
Follow-up to [47449].
See #49621 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47459 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-16 12:23:01 +00:00
Sergey Biryukov
5b88e2fa53
Menus: When adding a label for special pages in wp_setup_nav_menu_item()
strip all HTML tags, as the label is escaped on output.
...
Follow-up to [47211], [47213].
Props stiofansisland.
Fixes #49374 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47458 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-16 01:30:14 +00:00
Sergey Biryukov
812c92e1e9
Administration: When editing a plugin or theme file, close any active PHP session.
...
This prevents HTTP requests from timing out when attempting to connect back to the site.
Props bruandet, vjik, donmhico, SergeyBiryukov.
Fixes #43358 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47457 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-15 19:43:50 +00:00
Sergey Biryukov
a2861f1277
Site Health: Run the first scheduled site health check a day after the initial site setup.
...
This reduces the chance of displaying incorrect results due to running the check too early in first time setup scenarios.
Props Clorith, garrett-eclipse, roytanck, joostdevalk.
Fixes #49577 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47456 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-14 16:34:54 +00:00
Sergey Biryukov
c3156e6258
Toolbar: Move the logic for rendering the admin bar on wp_footer
to wp_admin_bar_render()
.
...
Clarify in the function documentation that it is now called on `wp_body_open` action first, with `wp_footer` as a fallback.
Follow-up to [47221].
Fixes #47053 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47455 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-14 15:59:22 +00:00
Sergey Biryukov
31dd2e70f0
General: Trim the input data in maybe_unserialize()
, for consistency with is_serialized()
.
...
Props pbearne, mikeschroder.
Fixes #36416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47454 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-13 21:12:01 +00:00
SergeyBiryukov
13c5098f74
General: Move maybe_serialize()
to a more appropriate place in the file, before maybe_unserialize()
.
...
Rename the `$original` parameter of `maybe_unserialize()` to `$data`, for consistency with other serialization functions.
See #36416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47453 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-13 21:05:02 +00:00
SergeyBiryukov
5ac6156507
Tests: Extract is_serialized()
test cases into data providers; reuse them for maybe_serialize()
and maybe_unserialize()
tests.
...
Props pbearne, mikeschroder, SergeyBiryukov.
See #36416 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47452 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-13 20:39:02 +00:00
Sergey Biryukov
ed9d5c383f
Database: Introduce wpdb::db_server_info()
to retrieve full MySQL server information string as supplied by mysqli_get_server_info()
.
...
This complements `wpdb::db_version()`, which only returns a numeric version string and strips any additional information, e.g. vendor name.
Props clarinetlord, birgire, webaware, pento.
Fixes #40037 . See #27703 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47451 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-12 15:53:01 +00:00
Timothy Jacobs
60edf36394
REST API: Introduce "hex-color" JSON Schema format.
...
Props spacedmonkey, chrisvanpatten.
Fixes #49270 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47450 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-12 02:40:29 +00:00
Sergey Biryukov
a44943546c
Tests: Download Chromium for e2e tests only.
...
This reduces the chance of random failures due to network timeouts and avoids the overhead of unnecessarily downloading ~120 MB for PHP or JS tests.
Fixes #49621 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47449 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-11 02:01:20 +00:00
Peter Wilson
eba126609f
Media: Introduce preflight filter to wp_delete_attachment()
.
...
Introduces the filter `pre_delete_attachment` to allow developers to prevent or modify the deletion of attachments. This improves consistency with `wp_delete_post()` and `wp_trash_post()`.
Props joemcgill, peterwilsoncc.
Fixes #49597 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47448 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 22:46:12 +00:00
Sergey Biryukov
01ad44e871
Bundled Themes: Update calendar widget styles for 5.4 markup to fix the alignment of a single month link.
...
Follow-up to [47405].
Props sabernhardt.
Reviewed by ianbelanger, SergeyBiryukov.
Fixes #49549 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47444 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 20:51:46 +00:00
Sergey Biryukov
6095b4467a
Help/About: Use consistent vertical whitespace between sections on Freedoms page.
...
Props chetan200891.
Fixes #49619 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47443 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 20:37:59 +00:00
Jorge Costa
94516bbb3f
Block Editor: Update WordPress Packages WordPress 5.4 RC 2.
...
The following package versions were changed:
@wordpress/block-directory: 1.5.3 -> 1.5.4
@wordpress/block-editor: 3.7.3 -> 3.7.4
@wordpress/block-library: 2.14.3 -> 2.14.4
@wordpress/edit-post: 3.13.4 -> 3.13.5
@wordpress/editor: 9.12.3 -> 9.12.4
@wordpress/format-library: 1.14.3 -> 1.14.4
Props aduth, gziolo, mapk.
Fixes : #49611 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47441 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 14:51:10 +00:00
Ian Belanger
150a49a0b1
Bundled Themes: Twenty Twenty content font CSS selector is too important - updated.
...
This adds more selectors for headings, tables, addresses, cite, figcaption, file and caption blocks to make the font-family match as before [47133].
Props alexandreb3, SergeyBiryukov.
Fixes #49318 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47439 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-09 19:46:27 +00:00
Sergey Biryukov
4f06d9a2bb
Help/About: Update and correct some strings for 5.4 About page.
...
Props garrett-eclipse, Ipstenu, ocean90, tobifjellner, la-geek.
Reviewed by ocean90, SergeyBiryukov.
See #49295 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47436 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-09 00:09:25 +00:00
Sergey Biryukov
77578e0869
Themes: Prevent tags in Theme Details modal from being partially hidden behind action buttons on smaller screens.
...
Props sagarjadhav, valentinbora.
Fixes #31783 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47435 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-08 01:50:37 +00:00
Sergey Biryukov
f6ff42bee4
Administration: Add missing description for "Page title" element of the admin menu array.
...
Props ajoah, valentinbora, kaitlin414.
Fixes #42911 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47434 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-08 00:16:36 +00:00
Sergey Biryukov
c227b20a0f
Customize: Ensure color picker's Clear button is aligned properly.
...
Props Cybr.
Fixes #49543 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47433 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-07 01:11:38 +00:00
Sergey Biryukov
72cb0ebff8
REST API: Fix typo in disable-custom-gradients
theme feature description.
...
Props Ipstenu, tobifjellner, pixelverbieger.
Reviewed by ocean90, johnbillion, SergeyBiryukov.
Fixes #49585 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47432 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-06 00:15:09 +00:00
Sergey Biryukov
b6ac7c4f87
Tests: Remove unnecessary use of wpdb_exposed_methods_for_testing
in test_utf8mb3_post_saves_with_emoji()
.
...
Props clarinetlord.
Fixes #39998 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47431 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-05 11:53:34 +00:00
Sergey Biryukov
48df8c3646
General: Ensure get_tag_regex()
always returns a string, to match the documented value.
...
Props subrataemfluence.
Fixes #45643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47430 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 12:03:32 +00:00
Sergey Biryukov
7a4f9cc9a6
General: Correct the default value of the $defaults
parameter in wp_parse_args()
to match the documented type.
...
Props subrataemfluence.
See #45643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47429 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 11:58:31 +00:00
Sergey Biryukov
047f6e4bef
Docs: Reorder @throws
tags in WP_Customize_Nav_Menu_Setting
and WP_Customize_Nav_Menu_Item_Setting
for consistency with WP_Customize_Custom_CSS_Setting
.
...
See #49572 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47428 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 11:33:14 +00:00
Sergey Biryukov
b52783bc4f
Docs: Add missing @throws
tag to _wp_json_sanity_check()
DocBlock.
...
Props subrataemfluence.
See #45643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47427 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 11:32:52 +00:00
Peter Wilson
55b3866749
Trunk is now 5.5 alpha
...
git-svn-id: https://develop.svn.wordpress.org/trunk@47426 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 01:18:56 +00:00
Jorge Costa
66f510bda0
Post WordPress 5.4 RC 1 version bump.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@47424 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 22:00:22 +00:00
Jorge Costa
d4f965278a
WordPress 5.4 RC 1.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@47423 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 21:41:29 +00:00
Sergey Biryukov
0ffce72ed0
Help/About: Add strings for 5.4 About page.
...
Props elmastudio, chanthaboune, francina, marybaum, audrasjb.
See #49295 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47422 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 21:20:45 +00:00
Jorge Costa
ae5596bf0a
Editor: Update WordPress packages to make editor full-screen by default.
...
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk https://github.com/WordPress/gutenberg/pull/20611 .
Props youknowriad, mcsf, mapk.
Fixes : #49574 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47421 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 20:43:49 +00:00