Commit Graph

27185 Commits

Author SHA1 Message Date
Scott Taylor 277d5a633e After [29201], use `aria-label` instead of `aria-labelledby` in `WP_Plugin_Install_List_Table::display_rows()`.
Props nvwd, DrewAPicture.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29424 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:55:18 +00:00
Scott Taylor 67ef6c5e18 `WP_List_Table::items` should be `public`, not `protected`. It is accessed in a subclass directly via `wp_ajax_get_comments()`.
See [28493].
Fixes #29072.


git-svn-id: https://develop.svn.wordpress.org/trunk@29423 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:50:40 +00:00
Scott Taylor 06eea1b33d After [28883], ensure that priorities have callbacks before returning `true` in `has_filter()`.
Adds unit tests.

Props boonebgorges.
Fixes #29070.


git-svn-id: https://develop.svn.wordpress.org/trunk@29422 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-07 02:29:15 +00:00
Scott Taylor e9ba499f23 After [29339] and [29341], add more unit tests and less ambiguous type-checking before bailing in meta-related functions that expect a numeric value for `$object_id`.
Props SergeyBiryukov.
Fixes #28315.


git-svn-id: https://develop.svn.wordpress.org/trunk@29421 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 22:07:42 +00:00
Scott Taylor 5f2fa44dee Media Grid: expose the `$.Deffered()` object in `media.view.AttachmentsBrowser.updateContent()` so the grid can call `Backbone.history.start()` when models actually exist.
This is a lot better then `_.delay( this.pray, 1000 )`, but needs continued study.

See #29052.


git-svn-id: https://develop.svn.wordpress.org/trunk@29420 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 21:43:26 +00:00
Scott Taylor e25dc36c2b Media Grid: after [28996], use the same cover size for audio/video files that images use for thumbnails.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29416 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 19:32:51 +00:00
Scott Taylor ccaf134b33 Media Grid: display upload errors in a dismissable sidebar.
See #29037.


git-svn-id: https://develop.svn.wordpress.org/trunk@29415 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 19:12:41 +00:00
Andrew Nacin 77e8616615 4.0-beta3
git-svn-id: https://develop.svn.wordpress.org/trunk@29414 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 18:27:59 +00:00
Andrew Nacin 996208160d Ignore entities in XML-RPC requests.
props mdawaffe, nacin.


git-svn-id: https://develop.svn.wordpress.org/trunk@29404 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:37:22 +00:00
Scott Taylor 1d1d95f4d5 In `media.view.BulkSelectionActionButton.click()`, do not assume that `delete` is the only possible bulk action.
Fixes #29101.


git-svn-id: https://develop.svn.wordpress.org/trunk@29403 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:23:49 +00:00
Scott Taylor 99a0a62442 Don't show the Featured Image metabox for users with the `contributor` role. Do enqueue media so that TinyMCE previews work for YouTube embeds, etc.
Props SergeyBiryukov.
Fixes #28327.


git-svn-id: https://develop.svn.wordpress.org/trunk@29402 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:16:45 +00:00
Scott Taylor 68a82b0932 Use proper non-capturing regex syntax for YouTube in `wp_video_shortcode()`.
Props Fab1en.
See [27063].
Fixes #29119.


git-svn-id: https://develop.svn.wordpress.org/trunk@29401 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:00:13 +00:00
Andrew Nacin 4984b04b81 Escape late in get_avatar().
git-svn-id: https://develop.svn.wordpress.org/trunk@29397 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 07:49:30 +00:00
Andrew Ozz d74b01a080 Media modal/grid: fix the position of attachment icons, restore the background, fix in ie8. See #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29393 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 06:28:54 +00:00
Andrew Nacin b2d8983dcc Constant time for wp_verify_nonce().
git-svn-id: https://develop.svn.wordpress.org/trunk@29382 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 05:25:03 +00:00
Sergey Biryukov 31105be6c7 Avoid PHP notices in wp-login.php if password reset cookie is not set.
props mdawaffe.
see #29060.

git-svn-id: https://develop.svn.wordpress.org/trunk@29381 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 02:16:51 +00:00
Andrew Ozz 0f01ebb037 TinyMCE: add support for `class` attribute on the caption shortcode. Part props knutsp, kadamwhite, fixes #28951.
git-svn-id: https://develop.svn.wordpress.org/trunk@29380 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 00:57:12 +00:00
Andrew Ozz 281bf20383 Media modal/grid: get the proper .attachment width in arrow navigation. Props avryl, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29379 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 19:36:41 +00:00
Andrew Nacin 5894507b95 Disable external entities in ID3.
git-svn-id: https://develop.svn.wordpress.org/trunk@29378 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 19:13:57 +00:00
Andrew Nacin a8e8ed6550 Verify the MAC earlier in WP_Customize_Widgets. props duck_.
git-svn-id: https://develop.svn.wordpress.org/trunk@29377 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 06:49:22 +00:00
Andrew Ozz e5836da88d Media modal/grid: remove thumbnail resizing from JS, only keep setting number of columns. Props avryl, see #27423.
git-svn-id: https://develop.svn.wordpress.org/trunk@29376 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 05:19:09 +00:00
Sergey Biryukov 508bdec5bd Use wp_normalize_path() in plugins_url().
props paulschreiber.
fixes #29058.

git-svn-id: https://develop.svn.wordpress.org/trunk@29375 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-05 01:30:03 +00:00
Andrew Nacin 587a0bc96d Language chooser: Adjust continue button alignment.
git-svn-id: https://develop.svn.wordpress.org/trunk@29374 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 21:22:57 +00:00
Andrew Ozz 98c3058d32 Media modal: use the same classes to hide the "or" that is above the "Select files" button when no drag-drop support. See #28851.
git-svn-id: https://develop.svn.wordpress.org/trunk@29373 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 21:16:37 +00:00
Andrew Nacin 42f2f27267 Language chooser imporvements.
* Use a translated 'Continue' string.
 * Go back to using a select element.
 * Only show a spinner when we're installing a language. 

see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29372 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 20:46:42 +00:00
Andrew Nacin be026764a3 Move plugin details link into the description area.
fixes #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29371 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 18:48:07 +00:00
Andrew Ozz 040ac15f50 TinyMCE: fix alignment buttons when used on image with caption. Remove old/unneeded code. Fixes #28705.
git-svn-id: https://develop.svn.wordpress.org/trunk@29370 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 00:51:19 +00:00
Andrew Ozz daf4baf3ed Mobile: hide the onscreen keyboard when the media modal opens, fixes #28549.
git-svn-id: https://develop.svn.wordpress.org/trunk@29369 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-03 22:33:05 +00:00
Scott Taylor 05bb106161 Media Grid: don't blow away the Attachment Details modal every time a new model is loaded.
Props ericlewis.
Fixes #29104.


git-svn-id: https://develop.svn.wordpress.org/trunk@29368 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-03 19:39:58 +00:00
Scott Taylor e7eca9d99b Media Grid: don't select `body` with jQuery when instantiating `media.view.UploaderWindow`.
Props ericlewis.
See #28965.


git-svn-id: https://develop.svn.wordpress.org/trunk@29367 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-03 19:36:41 +00:00
Andrew Ozz a1ce4931a1 Fix CSS for form elements for Firefox 30+, fixes #28500.
git-svn-id: https://develop.svn.wordpress.org/trunk@29366 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-03 00:33:31 +00:00
Dominik Schilling (ocean90) 2c320cc7f3 Standardize transition-animations on modal close/arrow buttons.
props celloexpressions.
fixes #29021.

git-svn-id: https://develop.svn.wordpress.org/trunk@29365 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 22:01:49 +00:00
Dominik Schilling (ocean90) c53e3036ad Media Modal: Restore uploader view, when no items are found.
see #28963.

git-svn-id: https://develop.svn.wordpress.org/trunk@29364 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:46:36 +00:00
Scott Taylor 6723459a79 Add an action, `pre_get_users`, in `WP_User_Query::prepare_query()`.
Props rmccue.
Fixes #29084.


git-svn-id: https://develop.svn.wordpress.org/trunk@29363 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:45:07 +00:00
Andrew Ozz 6bac38232c Add blog_id to the `wp-settings-*` cookie (used for storing user state) to prevent it being overloaded on sub-domain sites. Fixes #29095.
git-svn-id: https://develop.svn.wordpress.org/trunk@29362 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:08:52 +00:00
Dominik Schilling (ocean90) eedb382924 Remove some unused dashboard-widget-* CSS classes. Unused since [9103].
props michalzuber.
fixes #28930.

git-svn-id: https://develop.svn.wordpress.org/trunk@29361 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 20:02:00 +00:00
Dominik Schilling (ocean90) d12ec06021 Media: Don't stretch radio and checkbox inputs in compat fields. Adjust margin for radio inputs.
props kovshenin for initial patch.
fixes #28647.

git-svn-id: https://develop.svn.wordpress.org/trunk@29360 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 19:52:01 +00:00
Dominik Schilling (ocean90) a2a3e10f66 Plugin install: Improve styling of the no results message.
see #28753.

git-svn-id: https://develop.svn.wordpress.org/trunk@29359 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 15:23:17 +00:00
Dominik Schilling (ocean90) bcb49d44ab Language Upgrader: Don't print a footer when translations are updated async.
fixes #28947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29358 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 15:15:27 +00:00
Dominik Schilling (ocean90) c976db478f Upgrader: Use always `window.postMessage` for decrement of update count bubbles when `IFRAME_REQUEST` is defined.
Fixes decrement of translation update count bubbles when updated through the bulk upgrader.

fixes #29054.

git-svn-id: https://develop.svn.wordpress.org/trunk@29357 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 14:36:31 +00:00
Dominik Schilling (ocean90) ee91f3f94f Attach Media: Display the correct error message when search result is empty.
fixes #29093.

git-svn-id: https://develop.svn.wordpress.org/trunk@29356 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 14:23:42 +00:00
Dominik Schilling (ocean90) de7962c947 Media Upload: Improve styling of error messages.
props afercia, michalzuber.
fixes #29047.

git-svn-id: https://develop.svn.wordpress.org/trunk@29355 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-02 14:13:06 +00:00
Dominik Schilling (ocean90) 54faec35e4 To improve troubleshooting use `esc_html()` for a failed embed.
see #28195.

git-svn-id: https://develop.svn.wordpress.org/trunk@29354 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 22:33:55 +00:00
Dominik Schilling (ocean90) 6d656e7880 RTL: Fix media attach modal alignment.
props SergeyBiryukov.
fixes #28010.

git-svn-id: https://develop.svn.wordpress.org/trunk@29353 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:58:48 +00:00
Andrew Ozz 96daabb134 Editor scrolling: run one more adjust() 200ms after scroll or resize in case the browser is slow to re-calculate the element heights and pin/unpin the toolbars. See #28328, fixes #29059.
git-svn-id: https://develop.svn.wordpress.org/trunk@29352 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:42:03 +00:00
Sergey Biryukov 1cc1956a1f Consolidate some of the test functions added in [29344].
see #28310.

git-svn-id: https://develop.svn.wordpress.org/trunk@29351 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:06:49 +00:00
Dominik Schilling (ocean90) 6489b16efc Add some braces to [29225].
see #28673.

git-svn-id: https://develop.svn.wordpress.org/trunk@29350 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:03:48 +00:00
Sergey Biryukov 4b55c3d722 Avoid an undefined index notice in wp_reschedule_event().
props paulschreiber.
fixes #29077.

git-svn-id: https://develop.svn.wordpress.org/trunk@29349 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 20:56:11 +00:00
Dominik Schilling (ocean90) 4c0ae9bc47 Plugin install: Add missing closing HTML tags.
props jwenerd.
fixes #29090. see #28673.

git-svn-id: https://develop.svn.wordpress.org/trunk@29348 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 20:43:26 +00:00
Scott Taylor 7374913866 Add unit tests for `Walker` class.
Props willmot.
See #15667.


git-svn-id: https://develop.svn.wordpress.org/trunk@29347 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 20:35:25 +00:00