Commit Graph

27185 Commits

Author SHA1 Message Date
Andrew Ozz b53705fa7b TinyMCE wpView: better removal of views, replace a selected view when pasting. Props avryl, fixes #28913.
git-svn-id: https://develop.svn.wordpress.org/trunk@29246 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 07:29:34 +00:00
Andrew Ozz 8c67be305d TinyMCE wpVIew: use CSS3 `currentcolor` for the fake carets, see #28595.
git-svn-id: https://develop.svn.wordpress.org/trunk@29245 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 06:28:38 +00:00
Sergey Biryukov 50090763ba Remove redundant title attributes from get_calendar().
props joedolson.
fixes #26561.

git-svn-id: https://develop.svn.wordpress.org/trunk@29244 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 04:40:32 +00:00
Sergey Biryukov d83dbfca17 Customizer: Remove "Add a Widget" button from tab order when reordering widgets.
fixes #28890.

git-svn-id: https://develop.svn.wordpress.org/trunk@29243 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 03:31:49 +00:00
Sergey Biryukov 45ec949d58 Customizer: When widget reorder button is actioned, transfer focus to the first Move control within the section.
fixes #28891.

git-svn-id: https://develop.svn.wordpress.org/trunk@29242 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 03:23:51 +00:00
Sergey Biryukov c62cd97555 Add a class for get_comment_author_link() in Recent Comments widget.
props DrewAPicture, dannydehaan, 5um17.
fixes #27944.

git-svn-id: https://develop.svn.wordpress.org/trunk@29241 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 02:43:27 +00:00
Sergey Biryukov 0121e36154 Customizer: Add screen reader text to announce that panels and sections are expandable.
props joedolson, ocean90.
fixes #27591.

git-svn-id: https://develop.svn.wordpress.org/trunk@29240 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 02:36:07 +00:00
Sergey Biryukov 123702b484 Add screen reader text to announce that menu item accordion sections are expandable. Remove redundant title attribute.
props joedolson.
fixes #28866.

git-svn-id: https://develop.svn.wordpress.org/trunk@29239 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 02:20:58 +00:00
Sergey Biryukov a740868552 Customizer: Add widget title to Move/Up/Down controls to provide context for screen readers when reordering or moving widgets.
fixes #28889.

git-svn-id: https://develop.svn.wordpress.org/trunk@29238 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 01:57:05 +00:00
Sergey Biryukov 7a01c6af7b Customizer: Avoid losing focus when adding widgets via keyboard.
props sathishn.
fixes #28835.

git-svn-id: https://develop.svn.wordpress.org/trunk@29237 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 01:18:39 +00:00
Andrew Ozz bcff52c1b0 TinyMCE wpView:
- Typing something replaces a selected view.
- Pressing backspace deletes the selection.
- Pressing enter also deletes the selection.
- Pasting something replaces the selection.
- Also merge the different 'keydown' handlers.
Props avryl, fixes #28913.

git-svn-id: https://develop.svn.wordpress.org/trunk@29236 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 00:33:46 +00:00
Sergey Biryukov fad9723a42 Revert [28963].
see #28006.

git-svn-id: https://develop.svn.wordpress.org/trunk@29235 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 00:25:46 +00:00
Sergey Biryukov 9b1dbf7417 Use an existing string.
see #19205.

git-svn-id: https://develop.svn.wordpress.org/trunk@29234 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 23:55:47 +00:00
Sergey Biryukov 54f0c851d5 Reverse the order of roles in help text on Add New User screen to match [25695].
fixes #28914.

git-svn-id: https://develop.svn.wordpress.org/trunk@29233 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 23:47:54 +00:00
Sergey Biryukov 218cbba634 Add screen reader text for star ratings on Install Plugins screen.
props joedolson.
fixes #28852.

git-svn-id: https://develop.svn.wordpress.org/trunk@29232 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 23:40:43 +00:00
Andrew Ozz 72916a9751 TinyMCE: better "color preview" for the text color button, props avryl, fixes #28280.
git-svn-id: https://develop.svn.wordpress.org/trunk@29231 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 22:14:05 +00:00
Drew Jaynes (DrewAPicture) b4e97b5d5a Convert documentation for default arguments in `WP_Http::request()` to a hash notation.
Also update corresponding docs for functions that leverage its arguments.

See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29230 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 22:00:51 +00:00
Drew Jaynes (DrewAPicture) 9ea77904ba Fix syntax for single- and multi-line comments in wp-includes/class-http.php.
See #28943 and #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29229 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 21:46:24 +00:00
Andrew Nacin b26c85ff29 4.0-beta2.
git-svn-id: https://develop.svn.wordpress.org/trunk@29228 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 21:04:27 +00:00
Andrew Nacin 3bd777fba5 Plugin Install screens: Pass locale and installed plugins to the API, for context.
props tellyworth.
see #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29227 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 20:49:14 +00:00
Andrew Nacin b00097b758 Add 'Details' links to installed plugins.
Installed plugins that are up to date are now returned in the update-check API response.

props tellyworth.
see #17902.


git-svn-id: https://develop.svn.wordpress.org/trunk@29226 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 20:48:28 +00:00
Helen Hou-Sandi 446f78396a Plugin install: display cards in groups if the API returns them with the appropriate information. props tellyworth. fixes #28673.
git-svn-id: https://develop.svn.wordpress.org/trunk@29225 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 19:34:47 +00:00
Andrew Nacin fdacabaa7e WP_Session_Tokens: Can't abstract a static method.
Implementations can choose to implement the drop_sessions() method on their own.

see #20276.


git-svn-id: https://develop.svn.wordpress.org/trunk@29224 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 19:15:13 +00:00
John Blackbourn bda49ba928 Update some inline docs for the `WP_Http` class. Fixes #28943.
git-svn-id: https://develop.svn.wordpress.org/trunk@29223 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 18:14:09 +00:00
Sergey Biryukov 6fdf1c5d36 Fix parse error in PHP 5.2.
props georgestephanis.
see #20276.

git-svn-id: https://develop.svn.wordpress.org/trunk@29222 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 17:33:50 +00:00
Andrew Nacin 97fcbef707 Tie cookies and nonces to user sessions so they may be invalidated upon logout.
Sessions are stored in usermeta via WP_User_Meta_Session_Tokens, which extends the abstract WP_Session_Tokens class. Extending WP_Session_Tokens can allow for alternative storage, such as a separate table or Redis.

Introduces some simple APIs for session listing and destruction, such as wp_get_active_sessions() and wp_destroy_all_sessions().

This invalidates all existing authentication cookies, as a new segment (the session token) has been added to them.

props duck_, nacin, mdawaffe.
see #20276.


git-svn-id: https://develop.svn.wordpress.org/trunk@29221 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 09:12:05 +00:00
Helen Hou-Sandi a14ea26577 Keyboard accessibility for the media modal:
* Arrow keys navigate between items in the grid.
* Transfer focus into the panel when selecting a tab along the side.
* Transfer focus into the details sidebar when selecting an item and vice versa.
* Set initial focus on the close button so that it is visible.

props celloexpressions, lessbloat, ericlewis. fixes #25100, #25101, #28704. see #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29220 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 07:56:25 +00:00
Helen Hou-Sandi 1803c4c1e8 Plugin install cards:
* Move author attribution to its own line.
* Use `esc_url()` where appropriate.
* Better i18n.
* min-height for cards for a more even appearance.
* Show more cards on wide screens.
* Tighten up spacing below the filter bar.

props ocean90, helen. see #28785.


git-svn-id: https://develop.svn.wordpress.org/trunk@29219 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 06:07:21 +00:00
Helen Hou-Sandi b0b9655b12 Install Plugins screen:
* Utilize the (currently-named) filter bar from the Add Themes screen.
* Move the upload link to the h2, also like the Add Themes screen.

see #28673.


git-svn-id: https://develop.svn.wordpress.org/trunk@29218 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 04:49:19 +00:00
Helen Hou-Sandi 021750b4f4 Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794.
git-svn-id: https://develop.svn.wordpress.org/trunk@29217 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 03:39:04 +00:00
Sergey Biryukov 168ed4764e Don't 404 for empty feeds.
fixes #18505.

git-svn-id: https://develop.svn.wordpress.org/trunk@29216 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 22:21:37 +00:00
Sergey Biryukov 332a618271 Declare the variable before using it.
props danielbachhuber.
fixes #28932.

git-svn-id: https://develop.svn.wordpress.org/trunk@29215 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 22:00:14 +00:00
Andrew Ozz 9730c679f1 TinyMCE: add the 'colorpicker' and 'lists' plugins, fixes #28939, #27359.
git-svn-id: https://develop.svn.wordpress.org/trunk@29214 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 21:53:28 +00:00
Helen Hou-Sandi cb2ea6501a Fix jshint errors introduced in [29212]. see #28842.
git-svn-id: https://develop.svn.wordpress.org/trunk@29213 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 20:45:09 +00:00
Helen Hou-Sandi e391aa228a Media Grid:
Instead of a separate bulk selection mode, persistently show a checkbox for each item. Restores the more familiar bulk actions dropdown + action button.

props ericlewis. see #28842.



git-svn-id: https://develop.svn.wordpress.org/trunk@29212 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 20:41:40 +00:00
Andrew Ozz e4762df523 TinyMCE: include 709266e308 that fixes the UI state updates for the "link" button. See #28576.
git-svn-id: https://develop.svn.wordpress.org/trunk@29211 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 19:30:41 +00:00
Sergey Biryukov 750c310565 Twenty Fourteen: Remove unused variable after [27120].
props michalzuber.
fixes #28928.

git-svn-id: https://develop.svn.wordpress.org/trunk@29210 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 19:08:05 +00:00
Scott Taylor f59a307e10 Merge `wp_handle_upload()` and `wp_handle_sideload()` by making them each wrap a new function: `_wp_handle_upload()`.
Props DrewAPicture for docs.
Fixes #23686.


git-svn-id: https://develop.svn.wordpress.org/trunk@29209 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 18:57:26 +00:00
Scott Taylor 5e1556a4ce After [29106], check for `data.meta` before attempting to render `data.meta.bitrate`.
See #28839.


git-svn-id: https://develop.svn.wordpress.org/trunk@29208 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 17:41:06 +00:00
Scott Taylor 753a60c709 After [29197], use `! empty()` instead of `isset()`. Don't call `has_shortcode()` internally twice if it's true.
Props kovshenin.
Fixes #26343.


git-svn-id: https://develop.svn.wordpress.org/trunk@29207 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 17:37:51 +00:00
Drew Jaynes (DrewAPicture) 6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Drew Jaynes (DrewAPicture) 161266c17d Fix syntax for single- and multi-line comments in root-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29205 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:11:46 +00:00
Helen Hou-Sandi fdabfafa0f Media Grid Attachment Details modal UI improvements:
* Align better visually with the existing media modal and the post image edit modal.
* Add back a link to the full attachment edit screen (post.php).
* Add a title to the modal and move prev/next buttons next to the more-consistent close button.
* Remove mode tabs (metadata vs. image editing) in favor of the Edit Image button.

Still to come: responsive, IE8 testing and targeted CSS (calc() usage), general CSS cleanup.

props ericlewis, helen, melchoyce. see #28844. fixes #28915.


git-svn-id: https://develop.svn.wordpress.org/trunk@29204 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 03:54:44 +00:00
Andrew Ozz db9a148b34 TinyMCE:
- Update to 4.1.2, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt
- Update the tests to 4.1.2.
Fixes #28576.

git-svn-id: https://develop.svn.wordpress.org/trunk@29203 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 00:58:41 +00:00
Andrew Ozz 50f7313fdd TinyMCE wpView: prevent fatal (security) errors when trying to access iframe.contentWindow in pausePlayers() and unsetPlayers(). See #28905.
git-svn-id: https://develop.svn.wordpress.org/trunk@29202 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 00:49:11 +00:00
Scott Taylor 283fa473e6 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
Props joedolson.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29201 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:49:53 +00:00
Scott Taylor bda6f0cffe Properly set `$subdomain_error` to `false` when applicable in `ms_subdomain_constants()`. This was previously untestable because it used static vars: use globals instead.
Adds unit test.
Fixes #28697.


git-svn-id: https://develop.svn.wordpress.org/trunk@29200 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:34:18 +00:00
Drew Jaynes (DrewAPicture) 8a5d825fac Fix a typo in the `@access` tag for `WP_List_Table::__get()`.
Props joehoyle.
Fixes #28925. See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29199 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:12:11 +00:00
Scott Taylor e7e0aa5a42 Make sure that the `ready` event only fires once for relevant MCE views that are sandbox'd in iframes. Move some editor callbacks to `initialize`.
Props avryl.
See #28905.


git-svn-id: https://develop.svn.wordpress.org/trunk@29198 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:09:13 +00:00
Scott Taylor 17d67d93e7 Make `has_shortcode()` recursive/work for nested shortcodes.
Adds unit test.

Props katzwebdesign.
Fixes #26343.


git-svn-id: https://develop.svn.wordpress.org/trunk@29197 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:04:08 +00:00