Commit Graph

8234 Commits

Author SHA1 Message Date
Scott Taylor
641150a87a Comments List Table: after [34179], scope the <th>s and <td>s as direct descendants of their parent row.
Fixes #33943.


git-svn-id: https://develop.svn.wordpress.org/trunk@34527 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-25 02:20:11 +00:00
John Blackbourn
53c3cd897a Update the oEmbed endpoint URL for Photobucket.
Fixes #33783


git-svn-id: https://develop.svn.wordpress.org/trunk@34526 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 22:02:16 +00:00
Scott Taylor
2300740fa2 Comments: In comment_form(), move the comment textarea to the top for logged-out users when replying, improves keyboard/focus navigation.
Rehabilitate errant tabbing and extra unnecessary `<?php ?>` toggling.

Props afercia, adamsilverstein.
Fixes #29974.


git-svn-id: https://develop.svn.wordpress.org/trunk@34525 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:59:39 +00:00
Scott Taylor
3e46dd8b92 Comments: In get_comment_statuses(), also return trash.
XML-RPC: In `wp_xmlrpc_server::wp_editComment()`, allow comments to be trashed.

Introduce unit tests for `wp_editComment` in `xmlrpc/*` #NeverForget

Props tyxla, wonderboymusic.
Fixes #30965.


git-svn-id: https://develop.svn.wordpress.org/trunk@34524 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:47:51 +00:00
Scott Taylor
15935e0aed Comments: in comment_form(), add args for cancel_reply_before and cancel_reply_after to eradicate remaining hard-coded HTML bits.
Props MikeHansenMe.
Fixes #23797.



git-svn-id: https://develop.svn.wordpress.org/trunk@34523 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:32:03 +00:00
Scott Taylor
9b55d4fecb Comments: in check_comment_flood_db(), don't throttle moderators. If the commenter is logged in, check against their user_id instead of comment_author_IP.
Throwback: "If you can edit comments on the post, 'Slow down Cowboy' shouldn't kick in."

Props garyc40, wonderboymusic.
Fixes #16219.


git-svn-id: https://develop.svn.wordpress.org/trunk@34522 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:21:16 +00:00
Dominik Schilling (ocean90)
d1fbe56dfc Plugins: Don't use _n() for singular/plural strings which have no placeholder for a number.
Fixes #33239.
See #28502.

git-svn-id: https://develop.svn.wordpress.org/trunk@34521 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:06:50 +00:00
Scott Taylor
55bb8b8c0b Comments: add a 'comment_excerpt_length' filter to get_comment_excerpt().
Create the first ever unit tests for `get_comment_excerpt()`.

Props dannydehaan, wonderboymusic.
Fixes #27526.


git-svn-id: https://develop.svn.wordpress.org/trunk@34520 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 21:04:16 +00:00
Scott Taylor
5b5b714694 Comments List Table JS: move the dynamic count functions into closure scope so that setCommentsList AND commentReply can access them. Update counts when replying inline.
Fixes #33403.


git-svn-id: https://develop.svn.wordpress.org/trunk@34517 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 20:15:54 +00:00
John Blackbourn
1e42aeb3c4 Add a @since entry for the implementation of the $public argument in register_taxonomy().
See #21949


git-svn-id: https://develop.svn.wordpress.org/trunk@34516 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 20:15:29 +00:00
Scott Taylor
e1d433a233 Edit Post: in the logic determining whether to display the Comments meta box, check for the current post status in get_post_stati( array( 'public' => true ) ) instead of just checking publish and private. Ensure that private is checked in both instances.
Props Thaicloud, wonderboymusic.
Fixes #24486.


git-svn-id: https://develop.svn.wordpress.org/trunk@34515 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 20:01:55 +00:00
Scott Taylor
395fc15df3 Widgets: use input[type="number"] for the number prop in the Recent Posts and Recent Comments widget forms.
Props helen, obenland, mordauk.
Fixes #22965.


git-svn-id: https://develop.svn.wordpress.org/trunk@34514 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:52:06 +00:00
John Blackbourn
075245d894 Convert the $args passed to register_post_type() into an array before passing them to the new register_post_type_args filter.
Fixes #17447


git-svn-id: https://develop.svn.wordpress.org/trunk@34513 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:38:11 +00:00
Drew Jaynes
2703af7691 Docs: Clarify the summary and optional $query parameter description for remove_query_arg().
Props johnbillion.
Fixes #33912.


git-svn-id: https://develop.svn.wordpress.org/trunk@34512 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:33:07 +00:00
Drew Jaynes
c406171d12 Docs: Overhaul the DocBlock for add_query_arg() to attempt to better explain the various call signatures it accepts.
Also adds a couple of in-DocBlock examples illustrating single key and value, and associative array usage. Retains the note about the unescaped return value.

Props johnbillion.
See #33912.


git-svn-id: https://develop.svn.wordpress.org/trunk@34511 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:31:40 +00:00
Drew Jaynes
a099621012 Docs: Convert the $args parameter description in the register_taxonomy() DocBlock to a hash notation.
Also standardizes the DocBlock summary.

Props johnbillion.
Fixes #33991.


git-svn-id: https://develop.svn.wordpress.org/trunk@34510 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 19:11:53 +00:00
Drew Jaynes
45b8138b97 Docs: Improve the summary and description for the pre_http_request filter docs to better illustrate expected values.
The filter explicitly expects one of three passed value types:

*  An array containing 'headers', 'body', 'response', 'cookies', and 'filename' elements
*  A `WP_Error` instance
*  Boolean false (to avoid short-circuiting the response)

Props johnbillion.
Fixes #33995.


git-svn-id: https://develop.svn.wordpress.org/trunk@34509 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 18:51:13 +00:00
Andrea Fercia
5852971d3c Comments List Table: fix the translators comment for all count after [34506].
See #17275.

git-svn-id: https://develop.svn.wordpress.org/trunk@34508 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 18:39:04 +00:00
John Blackbourn
133993389e Add $depth as a parameter in the nav_menu_item_args filter.
Fixes #29417


git-svn-id: https://develop.svn.wordpress.org/trunk@34507 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 17:58:20 +00:00
Scott Taylor
d7a59c4661 Comments List Table: include count for "All". Dynamically update.
Fixes #17275.


git-svn-id: https://develop.svn.wordpress.org/trunk@34506 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 17:56:50 +00:00
John Blackbourn
3d97e9a53b Correctly present an error to the user if the nickname field is empty when updating a user profile. It's strange that this field is required, but it is, so be it.
Fixes #33310
Props prasad-nevase, metodiew


git-svn-id: https://develop.svn.wordpress.org/trunk@34505 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 17:48:10 +00:00
Scott Taylor
821821c8b5 Comments: add date column to WP_Comments_List_Table to allow sorting and to break out the date/time from the comment content column.
Props jshreve.
Fixes #15520.


git-svn-id: https://develop.svn.wordpress.org/trunk@34504 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 17:26:54 +00:00
Scott Taylor
ba2842f326 Comments: In comments_template(), set $wp_query->comments_by_type to empty array if not separating comments. The value becomes stale otherwise. Edge case.
Props jakub.tyrcha.
Fixes #14809.


git-svn-id: https://develop.svn.wordpress.org/trunk@34503 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 16:30:12 +00:00
Drew Jaynes
057ba76b2c Docs: Add more explicit optional parameter types and return descriptions in the DocBlocks for is_page(), is_single(), is_singular().
Also adds explicit types and return descriptions to the corresponding `WP_Query` methods: `WP_Query::is_page()`, `WP_Query::is_single()`, and `WP_Query::is_singular()`.

Props Shelob9 for the initial patch.
Fixes #33907.


git-svn-id: https://develop.svn.wordpress.org/trunk@34502 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 16:17:23 +00:00
Dominik Schilling (ocean90)
9d4d1a7572 Twenty Fifteen: Add a missing comma in rtl.css.
Props Toro_Unit.
Fixes #33985.

git-svn-id: https://develop.svn.wordpress.org/trunk@34501 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 16:02:19 +00:00
Scott Taylor
c0ebd3b5e2 Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget.
Fixes #10422.


git-svn-id: https://develop.svn.wordpress.org/trunk@34500 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 15:52:41 +00:00
Drew Jaynes
b408cd37fb Docs: Standardize and clarify class DocBlocks for all of the Upgrade API classes.
Standardizes summaries and tags for the following classes:

* `WP_Upgrader`
* `Plugin_Upgrader`
* `Theme_Upgrader`
* `Language_Pack_Upgrader`
* `Core_Upgrader`
* `File_Upload_Upgrader`
* `WP_Automatic_Updater`

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34499 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:53:46 +00:00
DrewAPicture
cccd9356fe Docs: Clarify the file header for wp-admin/includes/class-wp-upgrader.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34498 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:43:02 +00:00
Drew Jaynes
ad64ee866b Docs: Mark the optional $upgrader parameter as such and add a description in the DocBlock for Language_Pack_Upgrader::async_upgrade().
See [32655].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34497 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:34:15 +00:00
Scott Taylor
04bb8a07d7 Canonical/Rewrite: After [34492], fix rel="canonical" URLs for paginated posts.
Props wonderboymusic, joostdevalk.
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34496 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:30:00 +00:00
Drew Jaynes
02e1102a5b Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_ftpsockets::get_contents().
Also reverses the return types as `string` is expected, `false` is the outlier.

See [30978].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34495 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:21:50 +00:00
Scott Taylor
30554cccab After [34492], no need to import the global instance when we are, in fact, currently, that instance.
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34494 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:19:03 +00:00
Drew Jaynes
6ac2cb05e6 Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_FTPext::get_contents().
Also reverses the return types as `string` is expected, `false` is the outlier.

See [30978].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34493 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:10:47 +00:00
Scott Taylor
0111ecef55 Canonical/Rewrite: sanity check posts that are paged with <!--nextpage-->. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content.
Awesome rewrite bug: the `page` query var was being set to `'/4'` in `$wp`. When cast to `int`, it returns `0` (Bless you, PHP). `WP_Query` calls `trim( $page, '/' )` when setting its own query var. The few places that were checking `page`	before posts were queried now have sanity checks, so that these changes work without flushing rewrites.	

Adds/updates unit tests.

Props wonderboymusic, dd32.
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34492 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 14:03:05 +00:00
Drew Jaynes
c9093207df Docs: Add a summary, version, and @access tag to the property DocBlock for Custom_Image_Header->updated.
See [14907] for where the property was initially introduced.
See [30187] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34491 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 13:38:03 +00:00
Drew Jaynes
00eab11256 Docs: Add a summary, version, and @access tag to the property DocBlock for Custom_Background->updated.
See [13765] for where the property was initially introduced.
See [30186] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34490 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 13:33:18 +00:00
Drew Jaynes
72a968ca03 Docs: Add a summary, version, and @access tag to the property DocBlock for WP_Locale->number_format.
See [5308] for where the property was initially introduced.
See [31083] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34489 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 13:25:55 +00:00
Dominik Schilling (ocean90)
15ee0a44b2 Customizer: Use the plural label for available menu item types.
Fixes #33634.

git-svn-id: https://develop.svn.wordpress.org/trunk@34487 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 09:15:15 +00:00
Dominik Schilling (ocean90)
273bd1ed99 Edit Post: Add missing periods.
See #31858.

git-svn-id: https://develop.svn.wordpress.org/trunk@34486 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 08:53:21 +00:00
Drew Jaynes
8e61ab359c Docs: Link up a hook reference with an inline @see tag in the return description for get_locale().
Missed in [34484].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34485 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:50:49 +00:00
Drew Jaynes
b91804e0bf Docs: Fix the summary for get_locale().
Also update the description to properly link up hook references with inline `@see` tags.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34484 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:49:07 +00:00
Drew Jaynes
f85670cd36 Docs: Clarify the file header summary for wp-includes/l10n.php and add the version it was introduced.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34483 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:46:35 +00:00
Drew Jaynes
1810710798 Docs: Split the DocBlock summary for __() into a summary and description.
Also, notate the default value for the optional `$domain` parameter.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34482 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:42:35 +00:00
Drew Jaynes
4d94ef47de Docs: Add a summary to the hook doc for the nav_menu_item_args filter, introduced in [34471].
Fixes #29417.


git-svn-id: https://develop.svn.wordpress.org/trunk@34481 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 05:08:36 +00:00
Scott Taylor
3a8f42bfe0 Post Thumbnails: In get_the_post_thumbnail_url(), return false instead of empty string when no URL is available.
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34480 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 04:37:48 +00:00
Gary Pendergast
e1fafc56d5 WPDB: When attempting to fall back to ext/mysql in db_connect(), return the result of the fall back.
While it doesn't affect Core, we should also be passing the `$allow_bail` parameter, for anything that uses it differently.

Props markoheijnen, johnbillion.

Fixes #33105.



git-svn-id: https://develop.svn.wordpress.org/trunk@34478 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 04:29:40 +00:00
Scott Taylor
b9ad7136d7 WP: after [34443], calling get_queried_object() messes up unit tests. We can just clone the $post prop and call it a day.
Fixes #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34476 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 03:53:39 +00:00
Scott Taylor
6ad1c1c380 Plugins: on the plugins admin screen, the "has been deleted" string needs a plural.
Props jmayhak.
Fixes #33239.


git-svn-id: https://develop.svn.wordpress.org/trunk@34475 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 03:41:52 +00:00
Scott Taylor
bab2316129 Date/Time: Add unit tests for the_date().
Props jubstuff.
Fixes #33750.


git-svn-id: https://develop.svn.wordpress.org/trunk@34474 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 03:33:21 +00:00
Scott Taylor
9d71ae4122 Edit Post: After [33666], separate the translation string for pages, avoiding HTML usage.
Props ramiy.
Fixes #31858.


git-svn-id: https://develop.svn.wordpress.org/trunk@34473 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 03:27:26 +00:00
Scott Taylor
d98165d1c3 Media Modal: move the translation strings for insertIntoPost and uploadedToThisPost to the get_post_type_labels() array as insert_into_item and uploaded_to_this_item.
Props flixos90.
Fixes #33616.


git-svn-id: https://develop.svn.wordpress.org/trunk@34472 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 03:21:11 +00:00
Scott Taylor
0e81ac08de Nav Menus: Add a 'nav_menu_item_args' filter to Walker_Nav_Menu::start_el().
Props bjornjohansen.
Fixes #29417.


git-svn-id: https://develop.svn.wordpress.org/trunk@34471 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 03:16:44 +00:00
Scott Taylor
000b9e2fb3 Include fourth array parameter in return value doc block for wp_get_attachment_image_src().
Props kadamwhite.
Fixes #33905.


git-svn-id: https://develop.svn.wordpress.org/trunk@34470 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 03:13:08 +00:00
Scott Taylor
c9c9e19260 After [34341], add translation strings.
Props ramiy.
Fixes #31862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34469 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 03:08:34 +00:00
Scott Taylor
21dad99c1b List Tables: add JS code to dynamically toggle the disabled attribute of the Bulk Actions dropdown and Apply button.
Props wonderboymusic, pareshradadiya.
Fixes #31634.


git-svn-id: https://develop.svn.wordpress.org/trunk@34467 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 01:06:17 +00:00
Scott Taylor
d92723a33f Users: in WP_User::__unset(), don't reset the deprecated prop id to ID. Still throw the deprecated notice.
Update unit test.

Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34466 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 00:48:23 +00:00
Scott Taylor
c1c93f1e95 Widgets: when passing a string arg value to dynamic_sidebar(), don't reset $index when the arg's sanitized value matches the sanitized name of a sidebar.
Adds unit test.

Props tyxla, fjarrett.
Fixes #23423.


git-svn-id: https://develop.svn.wordpress.org/trunk@34465 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 00:29:54 +00:00
Scott Taylor
9209546292 Recent Posts Widget: remove HTML fragment caching. The cache currently doesn't work cross-scheme and causes mixed content issues for links. The widget was written pre-$split_the_query, after which post objects can be served from the cache.
Fixes #27565.


git-svn-id: https://develop.svn.wordpress.org/trunk@34464 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-24 00:16:16 +00:00
Scott Taylor
325a900519 Calendar Widget: remove the title attribute for days and replace with aria-label. Spruce up some of this nasty code. Delete unnecessary bits.
Props wonderboymusic, elusiveunit, 5um17. 
Fixes #30297.


git-svn-id: https://develop.svn.wordpress.org/trunk@34463 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 23:56:05 +00:00
John Blackbourn
1ce18f6e95 Send a 500 HTTP response code when the server's PHP or MySQL checks fail.
Fixes #33689
Props jeichorn


git-svn-id: https://develop.svn.wordpress.org/trunk@34462 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 21:56:32 +00:00
Scott Taylor
a87b30da21 Comments: allow meta boxes for Discussion and Comments in extenuating circumstances.
* Discussion: Post Type stops supporting comments, but comments and/or pings are open on a post. 
* Comments: Post is published or private, the post type has stopped supporting comments, but comments and/or pings are open on a post.

Currently, there is no way to toggle those settings off.

Props couturefreak, wonderboymusic, rachelbaker.
Fixes #28080.


git-svn-id: https://develop.svn.wordpress.org/trunk@34461 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 19:48:41 +00:00
Boone Gorges
daadd27ed4 Allow comment_exists() to match based on GMT date.
The `comment_date_gmt` field of the `wp_comments` table is indexed, which makes
`WHERE` matches against the field much faster than against the unindexed
`comment_date`. For bulk operations like data import, the speed difference can
be meaningful.

We continue to default to 'blog' for `$timezone`, to preserve compatibility
with existing uses.

Props apokalyptik.
Fixes #33871.

git-svn-id: https://develop.svn.wordpress.org/trunk@34460 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 18:15:39 +00:00
John Blackbourn
92748bb96e Add an entry for Cloudup to the list of oEmbed providers.
See #26278


git-svn-id: https://develop.svn.wordpress.org/trunk@34459 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 15:59:42 +00:00
John Blackbourn
d8a59791f0 Avoid a PHP notice if the last_updated property isn't present in a plugin's data from the Plugins API.
Fixes #33024
Props icetee


git-svn-id: https://develop.svn.wordpress.org/trunk@34458 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 15:09:42 +00:00
Boone Gorges
4cbd2fbc55 Multisite: Don't limit site titles to 50 chars.
This restriction dates from ye olden times, ie https://mu.trac.wordpress.org/changeset/1140.
It is no longer relevant.

Props chriscct7, theode.
Fixes #33973.

git-svn-id: https://develop.svn.wordpress.org/trunk@34455 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 14:23:13 +00:00
Boone Gorges
e6b7c6b2d4 Bail early when invalid ID is passed to get_comment_class().
This helps to avoid PHP notices later in the function.

Props walterebert, dipesh.kakadiya, DrewAPicture.
Fixes #33947.

git-svn-id: https://develop.svn.wordpress.org/trunk@34454 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 14:08:47 +00:00
Scott Taylor
fc3b7b20cd Links: the esc_html() additions in [34444] aren't very nice to screen reader <span>s. Revert those specific calls.
See #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34452 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-23 04:25:18 +00:00
Sergey Biryukov
6c63977ec2 Make the 'register_post_type_args' filter introduced in [34242] available for built-in post types too.
Props MikeSchinkel.
Fixes #17447.

git-svn-id: https://develop.svn.wordpress.org/trunk@34451 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 22:31:25 +00:00
Scott Taylor
d416922cbf Remove some unused globals and/or their docs.
See ##33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@34446 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 20:26:17 +00:00
Scott Taylor
e2ce2d90fd After [34444​], wp_get_shortlink() can call get_queried_object_id() instead of using the $wp_query global.
See #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34445 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 20:08:49 +00:00
Scott Taylor
e06ca91cd2 Links: use consistent late-escaping in some HTML link-generation functions:
* `post_comments_feed_link()`
* `edit_post_link()`
* `edit_comment_link()`
* `edit_bookmark_link()`
* `rel_canonical()`

Props niallkennedy, wonderboymusic.
Fixes #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34444 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 20:05:17 +00:00
Scott Taylor
23c82a270b PINGBACKS: After [34442], switch to is_singular() to check attachments and pages as well.
See #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34443 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 19:09:28 +00:00
Scott Taylor
e774c95266 PINGBACKS: rather than sending the X-Pingback HTTP header on every single request for fun, perhaps only send it on single posts with pings open.
See #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34442 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 18:46:43 +00:00
Drew Jaynes
44006ff6a2 Docs: Actually, the subpackage for Walker_Page should be Template.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34441 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 15:08:10 +00:00
Drew Jaynes
1ea9111541 Docs: Add a file header to wp-includes/widgets/class-wp-widget-text.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Text`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34440 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 15:03:03 +00:00
Drew Jaynes
fdc31fdf45 Docs: Add a file header to wp-includes/widgets/class-wp-widget-tag-cloud.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Tag_Cloud`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34439 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 15:01:24 +00:00
DrewAPicture
7aedd83be1 Docs: Add a file header to wp-includes/widgets/class-wp-widget-search.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Search`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34438 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 15:00:04 +00:00
Drew Jaynes
564fda0cf7 Docs: Add a file header to wp-includes/widgets/class-wp-widget-rss.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_RSS`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34437 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:56:14 +00:00
Drew Jaynes
6acc3944d3 Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-posts.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Posts`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34436 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:53:44 +00:00
Drew Jaynes
c668d2295d Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-comments.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Comments`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34435 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:50:31 +00:00
Drew Jaynes
645c11475d Docs: Add a file header to wp-includes/widgets/class-wp-widget-pages.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Pages`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34434 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:48:54 +00:00
Drew Jaynes
f78a3692d1 Docs: Add a file header to wp-includes/widgets/class-wp-widget-meta.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Meta`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34433 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:47:32 +00:00
Drew Jaynes
5697314993 Docs: Add a file header to wp-includes/widgets/class-wp-widget-links.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Links`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34432 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:46:07 +00:00
Drew Jaynes
cd24102b98 Docs: Clarify the class DocBlock summary for WP_Widget_Categories.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34431 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:44:43 +00:00
Drew Jaynes
55d0267122 Docs: Add a file header to wp-includes/widgets/class-wp-widget-calendar.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Calendar`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34430 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:43:32 +00:00
Drew Jaynes
eb53dd65c9 Docs: Add a missing file header to wp-includes/widgets/class-wp-widget-archives.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Widget_Archives`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34429 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:42:06 +00:00
Drew Jaynes
e6f5ac781e Docs: Clarify the file header summary for wp-includes/widgets/class-wp-nav-menu-widget.php, introduced in [33746].
Also clarifies the class DocBlock summary and tags for `WP_Nav_Menu_Widget`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34428 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:40:27 +00:00
Drew Jaynes
b63257accc Docs: Clarify the file header summary for wp-admin/includes/template-functions.php, introduced in [34241].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34427 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:36:43 +00:00
Drew Jaynes
015fb31933 Docs: Clarify the file header summary for wp-admin/includes/class-wp-internal-pointers.php, introduced in [34241].
Also adds a missing class DocBlock to `WP_Internal_Pointers`. See [19388].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34426 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:34:55 +00:00
Drew Jaynes
f05d86060b Docs: Clarify the file header summary for wp-admin/includes/class-walker-category-checklist.php, introduced in [34241].
Also clarifies the class DocBlock summary for `Walker_Category_Checklist`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34425 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:32:20 +00:00
Sergey Biryukov
b9199cbcf7 Remove extra HTML from translatable strings in WP_Comments_List_Table::get_views().
Add a context and translator comments.

Props Tmeister for initial patch.
Fixes #31859.

git-svn-id: https://develop.svn.wordpress.org/trunk@34424 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:32:08 +00:00
Drew Jaynes
1de376cd8b Docs: Clarify the file header summary for wp-admin/includes/class-wp-post-comments-list-table.php, introduced in [34223].
Also clarifies the class DocBlock summary and tags for `WP_Post_Comments_List_Table`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34423 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:30:07 +00:00
Drew Jaynes
b3b19607bd Docs: Clarify the class DocBlock summary for WP_Screen.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34422 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:27:38 +00:00
Drew Jaynes
6dfcbd07c2 Docs: Add a file header to wp-admin/includes/nav-menus.php.
See [34168]. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34421 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:26:23 +00:00
Drew Jaynes
fa11dc9c5b Docs: Clarify the file header summary and version for wp-includes/category-template.php.
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34420 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:22:48 +00:00
Drew Jaynes
a29f058e69 Docs: Clarify the file header summary and subpackage for wp-includes/category-functions.php, introduced in [34110].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34419 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:20:49 +00:00
Drew Jaynes
647fa83cc9 Docs: Clarify the file header for wp-includes/category.php.
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34418 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:19:13 +00:00
Drew Jaynes
a1595c5e85 Docs: Clarify the file header for wp-includes/class-walker-category-dropdown.php, introduced in [34110].
Also clarifies the class DocBlock and tags for `Walker_CategoryDropdown`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34417 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:02:32 +00:00
Drew Jaynes
df9d6e6bcc Docs: Clarify the file header summary for wp-includes/class-walker-category.php, introduced in [34110].
Also clarifies the class DocBlock and tags for `Walker_Category`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34416 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 14:00:54 +00:00
Drew Jaynes
44c55211ce Docs: Clarify the file header subpackage for wp-includes/class-walker-page-dropdown.php, introduced in [34109].
Also clarifies the class DocBlock summary and tags for `Walker_PageDropdown`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34415 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:57:23 +00:00
Drew Jaynes
ac613406d7 Docs: Clarify the file header summary for wp-includes/class-walker-page.php, introduced in [34109].
Also clarifies the class DocBlock summary for `Walker_Page`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34414 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:53:44 +00:00
Drew Jaynes
5d84cf9acc Docs: The Widgets subpackage is plural.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34413 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:47:09 +00:00
Drew Jaynes
a74e215ac4 Docs: The Users subpackage is plural.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34412 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:45:48 +00:00
Drew Jaynes
00fe089f24 Docs: The Comments subpackage is plural.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34411 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:44:35 +00:00
Drew Jaynes
4e0b71390f Docs: The Comment API is singular.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34410 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:43:55 +00:00
Drew Jaynes
10278a11d3 Docs: The Comment API is singular.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34409 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:42:15 +00:00
Drew Jaynes
c7dddad085 Docs: Clarify the file header summary for wp-includes/default-widgets.php, the top-level file for bringing in the core widget classes.
Also adds inline DocBlocks for the widget classes now brought in via `require_once()` as of [33843].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34408 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:35:41 +00:00
DrewAPicture
451534ad3b Docs: Clarify the file header summary for wp-includes/meta.php, the top-level file for the core Meta API.
Also adds inline DocBlocks for files broken out in #33413 and now brought in via `require_once()`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34407 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:29:02 +00:00
Drew Jaynes
36885e252e Docs: Clarify the file header summary for wp-includes/meta-functions.php, introduced in [33761].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34406 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:26:47 +00:00
Drew Jaynes
55cffaf8df Docs: Add a file header to wp-includes/class-wp-meta-query.php, introduced in [33761].
Also clarifies the class DocBlock summary for `WP_Meta_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34405 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:25:37 +00:00
Drew Jaynes
88b8113b8d Docs: Clarify the file header summary for wp-includes/taxonomy.php, the top-level file for the core Taxonomy API.
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34404 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:22:38 +00:00
Drew Jaynes
1651d2cdf6 Docs: Clarify the file header summary for wp-includes/taxonomy-functions.php, introduced in [33760].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34403 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:19:59 +00:00
Drew Jaynes
c8830724ce Docs: Add a file header to wp-includes/class-wp-tax-query.php, introduced in [33760].
Also clarifies the class DocBlock summary and description for `WP_Tax_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34402 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:15:45 +00:00
Drew Jaynes
6e6e5cef2d Docs: Clarify the file header summary for wp-includes/post.php, the top-level file for the Post API.
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34401 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:12:55 +00:00
Drew Jaynes
5318055735 Docs: Clarify the file header summary for wp-includes/post-functions.php, introduced in [33759].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34400 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:11:03 +00:00
Drew Jaynes
70d8db9520 Docs: Add a file header to wp-includes/class-wp-post.php, introduced in [33759].
Also clarifies the class DocBlock for `WP_Post`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34399 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:09:17 +00:00
Drew Jaynes
8d033c32d3 Docs: Clarify the file header summary for wp-includes/capabilities.php, which was broken up into multiple files in [33752].
Also adds inline DocBlocks for files now brought in via `require_once()` from this file.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34398 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:05:38 +00:00
Drew Jaynes
88a5649234 Docs: The User API is singular.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34397 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:02:25 +00:00
Drew Jaynes
7fbdd70bb0 Docs: Clarify the file header summary for wp-includes/capabilities-functions.php, introduced in [33752].
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34396 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 13:00:48 +00:00
Drew Jaynes
76efb299c8 Docs: Add a file header to wp-includes/class-wp-role.php, introduced in [33752].
Also adjusts the class DocBlock for `WP_Role`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34395 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 12:58:11 +00:00
Drew Jaynes
9745959dc8 Docs: Add a file header to wp-includes/class-wp-roles.php, introduced in [33752].
Also adjusts the class DocBlock for `WP_Roles`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34394 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 12:53:15 +00:00
Drew Jaynes
aabead83e6 Docs: The User API is singular.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34393 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 12:30:43 +00:00
Drew Jaynes
5e875e78f7 Docs: The Widget API is singular.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34392 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 12:27:33 +00:00
Drew Jaynes
7193d1987e Docs: Update the file path in the duplicate hook comment for the admin_xml_ns hook in wp-admin/includes/template-functions.php.
The hook was "moved" to the newly-created template-functions.php file via `svn cp` in [34241].

Props dimadin.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34391 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 10:31:24 +00:00
Drew Jaynes
16e2ecda05 Docs: Add a missing access modifier to the declaration for the WP_User::__unset() magic method, introduced in [34380].
Also adds missing documentation to the DocBlock.

Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34390 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 10:06:56 +00:00
Drew Jaynes
4c8a45fe8c Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the WP_User::__get() magic method.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34389 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 10:01:01 +00:00
Drew Jaynes
e0cef41f09 Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the WP_User::__isset() magic method.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34388 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 09:58:05 +00:00
Drew Jaynes
adc24d967b Docs: Add a file header to wp-includes/class-wp-user.php, created in [33752].
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34387 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 09:55:34 +00:00
Drew Jaynes
419bcab6d8 Docs: Add a changelog entry to WP_Widget_Categories for non-category support, added in [34376].
See #21165. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34386 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 09:49:39 +00:00
Drew Jaynes
7f2fe52e40 Docs: Add a file header to wp-includes/widgets/class-wp-widget-categories.php.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34385 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 09:47:37 +00:00
Drew Jaynes
3696ffda21 Docs: Include 'wp-json' in the 4.4.0 changelog entry for the subdirectory_reserved_names filter.
'wp-json' was appended to the reserved names list in [34375].

See #33789. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34384 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 09:43:40 +00:00
Scott Taylor
2ddc438111 List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.
Props wonderboymusic, Viper007Bond.
Fixes #21249.


git-svn-id: https://develop.svn.wordpress.org/trunk@34383 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 06:05:39 +00:00
Scott Taylor
f543c65320 Dashboard: 2 submit buttons don't need names.
Props garyc40, gizburdt.
Fixes #16345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34382 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 05:44:45 +00:00
Scott Taylor
3a00b7c5f0 Widgets: add a static property to WP_Widget_Calendar to ensure that the id attribute is only output once.
Props MikeHansenMe, wonderboymusic.
Fixes #24604.


git-svn-id: https://develop.svn.wordpress.org/trunk@34381 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 05:08:33 +00:00
Scott Taylor
0ad726ef4d Users: add __unset to WP_User.
Adds unit tests.

Props johnjamesjacoby, MikeHansenMe, wonderboymusic.
Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34380 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:59:35 +00:00
Scott Taylor
3f8f3ccff0 Users: clarify the docs for WP_User::__set to make it clear that it does save data in the database.
Props johnpbloch.
Fixes #24255.


git-svn-id: https://develop.svn.wordpress.org/trunk@34379 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:55:50 +00:00
Scott Taylor
40b5ade751 After [34374], ensure that $iptc is defined.
See #33772.


git-svn-id: https://develop.svn.wordpress.org/trunk@34378 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:48:25 +00:00
Scott Taylor
fc1980e369 Sanitization: when falling back to (wait for it...) $fallback in sanitize_html_class(), sanitize it as well.
Props MikeHansenMe, wonderboymusic.
Fixes #30967.


git-svn-id: https://develop.svn.wordpress.org/trunk@34377 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:30:11 +00:00
Scott Taylor
90fb9480d1 Widgets: Make the categories widget work with custom taxonomies.
Props fonglh, wonderboymusic, DrewAPicture, kucrut.
Fixes #21165.


git-svn-id: https://develop.svn.wordpress.org/trunk@34376 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:24:53 +00:00
Scott Taylor
5dd7bec848 Multisite: as a precaution, make wp-json a reserved subdirectory name.
Props austinginder.
Fixes #33789.


git-svn-id: https://develop.svn.wordpress.org/trunk@34375 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:20:41 +00:00
wonderboymusic
70b90490fd Media: In wp_read_image_metadata(), include IPTC Keywords when available in $meta.
Adds unit test.

Props swissspidy, dbru, SteveHoneyNZ.
Fixes #33772.


git-svn-id: https://develop.svn.wordpress.org/trunk@34374 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:18:02 +00:00
Scott Taylor
1352d3473a Media: Add new functions, get_the_post_thumbnail_url() and the_post_thumbnail_url().
Adds unit tests.

Props dipesh.kakadiya, swissspidy, atomicjack.
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34373 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:14:15 +00:00
Scott Taylor
3c0ecff16e Media: Add a new function, wp_get_attachment_image_url(), which is a shortcut for wp_get_attachment_image_src() - same function signature, but returns just the URL based on $size.
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.


git-svn-id: https://develop.svn.wordpress.org/trunk@34372 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 04:12:44 +00:00
Scott Taylor
8a33422bfc Passwords: fix the markup on the Reset Password Form for user-pass1 so the JavaScript operates properly.
Props ldinclaux.
See #33892.
Fixes #33908.


git-svn-id: https://develop.svn.wordpress.org/trunk@34371 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 03:56:25 +00:00
Scott Taylor
f9d1856805 Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added.
Fixes #33941.


git-svn-id: https://develop.svn.wordpress.org/trunk@34370 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 03:36:27 +00:00
Scott Taylor
e75c7651b2 HTTP: Add some new Cookie helper functions:
* `wp_remote_retrieve_cookies( $response )`
* `wp_remote_retrieve_cookie( $response, $name )`
* `wp_remote_retrieve_cookie_value( $response, $name )`

Adds unit tests.

Props johnbillion.
Fixes #33711.


git-svn-id: https://develop.svn.wordpress.org/trunk@34369 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-22 03:13:13 +00:00
Drew Jaynes
782b9085c9 Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765].
See #31443. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34368 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 23:12:35 +00:00
Konstantin Obenland
3cd12045d3 Introduce template functions for comment navigation:
* `get_the_comments_navigation()` and `the_comments_navigation()` for navigation to the next and previous page of comments.
* `get_the_comments_pagination()` and `the_comments_pagination()` for paginated navigation between pages of comments. Uses `paginate_comments_links()`.

This reduces the need for themes to define their own sets of comment navigation
functions, like Twenty Fifteen and others.
Completes the navigation template tag API started in #29808 for posts.

Fixes #30589.



git-svn-id: https://develop.svn.wordpress.org/trunk@34367 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 16:31:19 +00:00
Scott Taylor
c34e94b693 Docs: is_main_query()'s _doing_it_wrong() notice suggests using WP_Query statically (WP_Query::is_main_query()). Use an alternate syntax: WP_Query->is_main_query(), to not confuse.
Props DrewAPicture, micahwave.
Fixes #25680.


git-svn-id: https://develop.svn.wordpress.org/trunk@34366 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:30:49 +00:00
Helen Hou-Sandi
9aaa278e02 Notices: Add styles for use against white backgrounds.
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.


git-svn-id: https://develop.svn.wordpress.org/trunk@34365 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:25:37 +00:00
Scott Taylor
2b3347332e Meta Boxes: In post_categories_meta_box(), convert some spaces to tabs.
Props miyauchi.
Fixes #33945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34364 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:17:29 +00:00
Drew Jaynes
81e235444a Docs: The $post parameter has been passed to the preview_post_link since 4.0.0.
Fixes a version mixup introduced in [34170].

Props dimadin.
See #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34363 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 13:16:36 +00:00
Drew Jaynes
f9e45047c1 Docs: Add a more complete return description for the array of data (or false) returned by image_downsize().
If not short-circuited via the `image_downsize` boolean filter, `image_downsize()` returns an array of data including the image URL, width, height, and whether the image size is intermediate, in that order. Otherwise, it returns false.

Fixes #30636.


git-svn-id: https://develop.svn.wordpress.org/trunk@34362 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 10:21:48 +00:00
Drew Jaynes
71ce9e812c Docs: Update the docs for WP_User_Query->prepare_query() for ordering by the value of the include argument, allowed since 4.1.
Also adds a changelog entry for the additionally-accepted value.

Props danielbachhuber.
Fixes #33937.


git-svn-id: https://develop.svn.wordpress.org/trunk@34361 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 00:46:08 +00:00
John Blackbourn
f80add733c Implement a 'Mine' link on post listing screens in the admin area for all users who have authored posts. This feature was previously only available to users who cannot edit other users' posts (namely Authors and Contributors).
Props linuxologos, wonderboymusic
Fixes #19609


git-svn-id: https://develop.svn.wordpress.org/trunk@34360 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 17:27:35 +00:00
John Blackbourn
ce126c10c0 Remove the ability to view the term editing screen for taxonomies with show_ui set to false. It is unexpected and unintended behaviour that this is allowed.
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.

Fixes #33938


git-svn-id: https://develop.svn.wordpress.org/trunk@34359 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 17:10:55 +00:00
John Blackbourn
dc7d968b19 Implement some more uses of wp_login_url() in places where wp-login.php is hard-coded.
See #31495


git-svn-id: https://develop.svn.wordpress.org/trunk@34358 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 16:53:32 +00:00
John Blackbourn
2894423f19 Revisions are an exception when it comes to the editing UI. The revision post type cannot have its show_ui argument set to true because this allows access to the post type listing, creation, and editing UI, but get_edit_post_link() needs to return a URL for the editing UI for revisions as that's how the revisions UI works.
Fixes #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34357 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 16:37:41 +00:00
Konstantin Obenland
050def62a3 Multisite: Make site status classes available to other elements.
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.

Fixed during WordCamp Switzerland Contributor Day.

Props psoluch.
Fixes #33595.



git-svn-id: https://develop.svn.wordpress.org/trunk@34356 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 12:52:56 +00:00
Drew Jaynes
e3e91dbadc Docs: Add a description for the documented use of the $wpdb global in _prime_comment_caches().
See #8071. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34355 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 09:38:24 +00:00
Dominik Schilling (ocean90)
ce1832f49c Login: Move the "Lost your password?" link into a separate string to reduce HTML tags in translation strings.
Props ramiy.
Fixes #31870.

git-svn-id: https://develop.svn.wordpress.org/trunk@34354 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 09:10:59 +00:00
John Blackbourn
fe80bec9ee Add @since docs for the show_ui argument in register_post_type().
See #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34353 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 09:04:21 +00:00
Dominik Schilling (ocean90)
d3031d522e Upgrader: Avoid using an HTML tag in a translation string, add translator comments.
Props ramiy for initial patch. 
Fixes #31860.

git-svn-id: https://develop.svn.wordpress.org/trunk@34352 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 08:58:27 +00:00
Dominik Schilling (ocean90)
ed82c7fb75 Theme Compat: Remove two strings from comments-popup.php.
`theme-compat/comments-popup.php` is a deprecated file. Instead of improving the strings in [34342] remove both superfluous paragraphs.

See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34351 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 08:48:28 +00:00
Sergey Biryukov
857be1862b Pass the current post object to 'page_attributes_meta_box_template' action added in [34340].
Props DrewAPicture.
Fixes #33625.

git-svn-id: https://develop.svn.wordpress.org/trunk@34350 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 08:14:40 +00:00
Drew Jaynes
44c256e8d1 Docs: Use standardized vernacular in the hook doc summary for the page_attributes_meta_box_template filter, introduced in [34340].
See #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34349 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 06:37:18 +00:00
Scott Taylor
ed7d34cb13 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload().
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:51:55 +00:00
Scott Taylor
520a75f44e The 'get_sample_permalink_html' filter​'s second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with 'get_sample_permalink' filter added in [34309].
Props SergeyBiryukov.	
Fixes #33927.


git-svn-id: https://develop.svn.wordpress.org/trunk@34347 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:25:45 +00:00
Scott Taylor
0082a438c5 MediaElement, update wp-mediaelement.js:
* create a public `initialize` method on the `wp.mediaelement` namespace
* make it idempotent to prevent nasty side-effects caused by initializing media elements more than once

Props bradyvercher.	
Fixes #32423.


git-svn-id: https://develop.svn.wordpress.org/trunk@34346 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:16:23 +00:00
Scott Taylor
191233f2f9 WP Query: Avoid using HTML tags in translation strings, add translator strings.
Props ramiy.	
Fixes #31868.


git-svn-id: https://develop.svn.wordpress.org/trunk@34345 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:03:28 +00:00
Scott Taylor
df8f10ceff Plugins Admin: Avoid using HTML tags in translation strings, add translator strings.
Props swissspidy, voldemortensen.	
Fixes #32269.


git-svn-id: https://develop.svn.wordpress.org/trunk@34344 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 03:00:57 +00:00
Scott Taylor
2161a20a68 WP Mail: Avoid using HTML tags in translation strings, add translator strings.
Props ramiy.	
Fixes #31871.


git-svn-id: https://develop.svn.wordpress.org/trunk@34343 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:52:49 +00:00
Scott Taylor
067af6b9aa Theme Compat: Avoid using HTML tags in translation strings.
Props ramiy.	
Fixes #31867.


git-svn-id: https://develop.svn.wordpress.org/trunk@34342 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:46:42 +00:00
Scott Taylor
d624c118cb Plugin Editor: Avoid using HTML tags in translation strings and add context.
Props ramiy.	
Fixes #31862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34341 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:41:43 +00:00
Scott Taylor
2812cc9595 In page_attributes_meta_box(), add an action, 'page_attributes_meta_box_template' to allow callbacks to be performed and HTML to be inserted after the title of the Template section.
Props sgrant.	
Fixes #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34340 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:39:31 +00:00
Scott Taylor
a3cb19c52e MediaElement: apply monkey patch to include a PR which fixes a breaking change made upstream on a public interface:
ccba8d0b6a

Props bradyvercher.
Fixes #33798.


git-svn-id: https://develop.svn.wordpress.org/trunk@34339 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:30:06 +00:00
Scott Taylor
2ccbc51d1e Login: apply the same margin to the top and bottom of the Back to {Blog} link.
Props MikeHansenMe.
Fixes #29249.


git-svn-id: https://develop.svn.wordpress.org/trunk@34338 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 01:40:42 +00:00
Drew Jaynes
12ce04a95e Docs: Add descriptions for $wp_query global phpDoc references in wp-includes/query.php, partially documented in [32620].
Fixes #32139.


git-svn-id: https://develop.svn.wordpress.org/trunk@34337 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 00:04:48 +00:00
Scott Taylor
b55de4e5f8 Feeds/Links: fix feed links for unattached attachments.
Adds unit tests.

Props wonderboymusic, iworks.
Fixes #33693.


git-svn-id: https://develop.svn.wordpress.org/trunk@34336 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 20:09:05 +00:00
Scott Taylor
633b119fd3 Site Icon: for consistency, make all 4 HTML tags in wp_site_icon() self-closing.
Props Corphi.
Fixes #33930.


git-svn-id: https://develop.svn.wordpress.org/trunk@34334 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 19:06:03 +00:00
Scott Taylor
0fdbaecbc6 Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors.
Props westonruter.
Fixes #33732.


git-svn-id: https://develop.svn.wordpress.org/trunk@34333 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 18:52:27 +00:00
Scott Taylor
f9c67159d4 Updates: in Theme list table, set white-space to normal for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens.
Fixes #33831.


git-svn-id: https://develop.svn.wordpress.org/trunk@34332 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 18:42:45 +00:00
Scott Taylor
d075313f5b Post List Table: 'All' view should be selected when appropriate for paged responses.
Props kraftbj, wonderboymusic.
Fixes #33923.


git-svn-id: https://develop.svn.wordpress.org/trunk@34331 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 18:16:31 +00:00
Scott Taylor
f4445d75c4 Add a 'menu_id' argument to wp_page_menu() so that fallback menus have the same attributes as wp_nav_menu().
Props lancewillett, ocean90, wonderboymusic.
Fixes #31656.


git-svn-id: https://develop.svn.wordpress.org/trunk@34330 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 18:06:49 +00:00
Scott Taylor
1b550d9fb2 Reinstate [34327]. minus the unit test deletion.
git-svn-id: https://develop.svn.wordpress.org/trunk@34329 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 17:48:18 +00:00
Scott Taylor
1e7832cc3b Revert [34327] to fix the accidental deletion of some unit tests.
git-svn-id: https://develop.svn.wordpress.org/trunk@34328 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 17:45:46 +00:00
Scott Taylor
750c22abf8 Export: Add a filer, 'export_wp_filename' to change the filename of the file to download when exporting.
Props MikeHansenMe, wonderboymusic.
Fixes #29500.


git-svn-id: https://develop.svn.wordpress.org/trunk@34327 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 17:43:52 +00:00
Scott Taylor
3624366045 Export: allow Media to exported separately from other types.
Props PhilipLakin.
Fixes #32230.


git-svn-id: https://develop.svn.wordpress.org/trunk@34326 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:46:17 +00:00
Scott Taylor
d9b58bd4ac Admin: when toggling select/deselect "all" via JS - :visible needs to be bound to not toggle disabled inputs.
Props tywayne.
Fixes #32309.


git-svn-id: https://develop.svn.wordpress.org/trunk@34325 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:40:34 +00:00
Scott Taylor
6d51562d72 Edit Post: When a post is "Pending Review", the "View Post" link should behave like ot does for drafts and generate a preview link.
Props wpdev101.
Fixes #33541.


git-svn-id: https://develop.svn.wordpress.org/trunk@34324 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:31:38 +00:00
Scott Taylor
1ca6eee748 List Tables: Ensure that sorting indicators have layout when cell widths are being calculated.
See #27743.


git-svn-id: https://develop.svn.wordpress.org/trunk@34323 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:14:59 +00:00
Scott Taylor
3cf5d40b9d Update Core: In list_plugin_updates(), when listing plugin updates related to $core_update_version, don't skip the check for $info->tested.
Props MikeHansenMe.
Fixes #27883.


git-svn-id: https://develop.svn.wordpress.org/trunk@34322 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 16:09:40 +00:00
Konstantin Obenland
bfc9fc4040 Menus: Remove whitespace between nav menu items.
Avoids CSS hacks like floating menu items or setting the parent element's
font-size to 0 in order to display nav menus horizontally.

Props jjeaton.
Fixes #27762.



git-svn-id: https://develop.svn.wordpress.org/trunk@34321 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 11:39:39 +00:00
Weston Ruter
7bdfb4917f Customize: Flesh out phpdoc for WP_Customize_Manager.
* Add missing phpdoc for class member variables.
* Supply missing `@return` descriptions from [34269].
* Add missing `@since` tags.
* Remove unused `$customized` protected class member variable.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34320 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 06:39:09 +00:00
Scott Taylor
1c5f85e1a4 When applying the 'editable_slug' filter, add a second param that provides more context.
Props MikeSchinkel, jesin.
Fixes #31568.


git-svn-id: https://develop.svn.wordpress.org/trunk@34319 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 05:48:30 +00:00
Scott Taylor
09e3149b7a Add a 'clean_user_cache' action at the end of clean_user_cache(). This is mighty similar to clean_post_cache().
Props elliott-stocks, wonderboymusic.
Fixes #31918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34318 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 05:40:22 +00:00
Andrew Ozz
51078c32ec TinyMCE: remove word-break: break-word; from the default editor CSS to prevent irregular spaces when typing in RTL languages.
Props iehsanir, alireza1375, ankit-k-gupta.
Fixes #33868.

git-svn-id: https://develop.svn.wordpress.org/trunk@34317 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 23:57:56 +00:00
Dominik Schilling (ocean90)
9b546efc1b Theme Compat: Remove commented out code.
See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34316 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 21:37:09 +00:00
Dominik Schilling (ocean90)
7eb0317968 Don't use <code> in translation strings in wp-admin/options.php.
Props ramiy, wonderboymusic.
Fixes #31861.

git-svn-id: https://develop.svn.wordpress.org/trunk@34315 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:42:20 +00:00
Dominik Schilling (ocean90)
f5eacb71d6 Don't use <code> in translation strings in wp-admin/includes/plugin.php.
Props ramiy.
Fixes #31856.

git-svn-id: https://develop.svn.wordpress.org/trunk@34314 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-18 20:28:23 +00:00