151520ee02
Check that `$_POST` array index is set before comparing it in `post_preview()`.
...
This prevents PHP notices in cases where a user with 'edit_others_posts' but
without 'publish_posts' previews another user's posts.
Props tyxla.
Fixes #31760 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31896 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-26 01:44:03 +00:00
5d50b55c7e
When saving post, ensure that non-hierarchical taxonomy input is defined before attempting to parse it.
...
Taxonomy metaboxes that are disabled for the current user are included in the
post.php markup, but do not contain the 'newtag' field, and so should be
skipped when looping through the metaboxes to avoid invoking String methods
on a variable of type `undefined`.
Props MikeNGarrett, A5hleyRich.
Fixes #30859 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31895 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-26 01:22:01 +00:00
fed67453a1
Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed.
...
Props stephdau. Fixes #31763 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31894 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-26 01:16:58 +00:00
e1353e1fe8
Customizer: [31885] actually hasn't fixed the `SecurityError`s. This one does.
...
props mattwiebe.
fixes #31687 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31893 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 23:35:37 +00:00
f5ea31e389
Customizer Theme Switcher: Reset font size of theme names in overlay. Apply left position only to themes section.
...
see #31303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31892 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 22:57:03 +00:00
9cd90a9a10
Clarify the DocBlock summary for `wp_scheduled_delete()` to mention that it includes posts of any type where the 'trash' status is used.
...
Props dkotter for the initial patch.
Fixes #31757 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31891 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 22:44:26 +00:00
501aeeaaa6
Improve alignment of labels and inputs in Quick Edit.
...
props mattheu, valendesigns.
fixes #31408 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31890 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 22:24:37 +00:00
e7195da11a
Comments List: Don't let "Quick Edit" break on smaller screens.
...
Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action.
props kraftbj.
fixes #31482 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31889 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 22:14:24 +00:00
e12762a76c
TinyMCE: make sure the editor is not completely empty before checking if the user clicked above or below a wpView.
...
Fixes #31765 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31888 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 18:54:22 +00:00
135be2826d
Avoid a PHP notice in `wp_enqueue_script()` if $handle is an array.
...
Calling `wp_enqueue_script()` with an array as the first argument is a "hidden feature" and should be avoided. Use dependencies instead.
props sorich87 for initial patch.
fixes #31636 .
see #14488 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31887 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 17:54:50 +00:00
de328f1a88
Text Widget: Use `!empty()` for checking if the filter setting is set.
...
props westonruter.
fixes #31690 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31886 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 17:33:49 +00:00
7a5073020d
Customizer: Avoid `SecurityError`s when the Customizer is embedded in an origin other than wp-admin.
...
props mattwiebe.
fixes #31687 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31885 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 17:25:01 +00:00
bd2d4c8d14
Clean up DocBlock information and syntax for `get_filesystem_method()`.
...
Props ericlewis, HarishChaudhari, valendesigns.
Fixes #31267 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31884 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 16:31:15 +00:00
821ca1e93c
Ensure the `$wp_hasher` global has an entry in the `check_password_reset_key()` DocBlock.
...
Props lamosty.
Fixes #31756 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31883 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 16:23:15 +00:00
b179fe8e95
When altering the admin URL to reflect the canonical location, keep the existing hash (if present) in the URL.
...
Fixes #31758 . See #23367
git-svn-id: https://develop.svn.wordpress.org/trunk@31882 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 04:31:21 +00:00
76eee7be6a
Emoji: Add a comment to `print_emoji_detection_script()` explaining how the `include` statement works as part of the `grunt build` process.
...
See #31701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31881 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 04:08:07 +00:00
9ef45a7200
Do not output empty name and id HTML attributes in get_submit_button().
...
Props afercia. Fixes #31749 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31880 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 03:22:18 +00:00
87e372299d
Emoji: Revert [31877], and print the emoji shim and styles during `admin_print_scripts` and `admin_print_styles`, instead. This is a few milliseconds slower, but easier to reuse in Press This, and any other code that uses admin scripts and styles, without using `admin-header.php`.
...
See #31701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31879 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 01:42:25 +00:00
f6e1aeee60
TinyMCE: pad empty paragraphs with `<br>` in Chrome to stop it from inserting non-breaking spaces in them.
...
Props iseulde. Fixes #31255 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31878 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 01:17:04 +00:00
12070176d9
Emoji: Print the emoji support shim in wp-admin, too.
...
See #31701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31877 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 01:13:35 +00:00
38de4b8045
Set EOL style for wp-emoji-loader.js. See #31701 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31876 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-25 00:16:09 +00:00
5a0564bb8f
Emoji: Instead of loading the emoji JS files automatically, we now include a small JS shim in the header, to test if the user's browser needs Twemoji. It then loads the emoji JS files only if they're needed.
...
Props pento, azaozz.
Fixes #31701 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31875 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 23:32:23 +00:00
8bbb5869e9
TinyMCE: fix error and PHP warning when adding more than one instance in RTL mode.
...
Part props maimairel. Fixes #31578 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31874 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 20:32:23 +00:00
ecad13044d
Fix a typo in [31872].
...
see #31738 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31873 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 17:32:47 +00:00
0d35447647
Fill `$plugins['upgrade']` with extra info for use in list table
...
Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses `$plugin['upgrade']` rather than `$plugins['all']`, we need to fill that information in both places.
Fixes #31738 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31872 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 17:29:32 +00:00
d6b90486d1
Implement an `aria-describedby` attribute for login screen errors, and improve the "Forgot password?" anchor text.
...
Props aferica, rianrietveld
Fixes #31143
git-svn-id: https://develop.svn.wordpress.org/trunk@31871 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 16:28:56 +00:00
de44adee46
Remove obsolete `$wpdb` reference from `get_comments()` docs.
...
props lamosty.
fixes #31748 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31870 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 15:42:09 +00:00
22214ffdf9
Emoji: The regex for checking if the current glyph is a flag was checking the incorrect byte range, which was causing the South Korean flag to not be replaced in Firefox.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31869 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 09:57:44 +00:00
defa8b0f96
Press This:
...
- Fix the links on inserted images to point to the source site.
- Fix inserting of images above the blockquote when the editor has not been focused.
Fixes #31745 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31868 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 01:32:17 +00:00
fc1d327261
Introduce `attachment_url_to_postid` filter to let plugins manage the uploads location better.
...
Props mattwiebe. Fixes #31717 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31867 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 17:23:27 +00:00
074eba3a53
4.2-beta2-31866
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31866 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 12:27:08 +00:00
1676dd43b1
Taxonomy List Tables: On mobile devices, hide the slug column, to avoid cramping the action links into two rows.
...
Props MikeNGarrett.
Fixes #29992 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31865 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 12:20:11 +00:00
b3e3766233
Emoji: Gmail doesn't obey an `<img>`'s inline CSS `height` rule, transforming it to `min-height`. To avoid giant smiley faces everywhere, we're changing the `height` rule to `max-height`, which Gmail plays nicer with.
...
Props janhenckens.
Fixes #31719 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31864 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 12:07:47 +00:00
f0849242d3
Upgrader: When creating a temporary working directory, strip off `.tmp` as well as `.zip` incase we end up using that directory as the items main directory.
...
Fixes #30945
git-svn-id: https://develop.svn.wordpress.org/trunk@31863 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 04:39:56 +00:00
9eb9342a54
Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
...
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`
These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`
Props iseulde. Fixes #31121
git-svn-id: https://develop.svn.wordpress.org/trunk@31862 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:13:50 +00:00
4d8a13fe33
Emoji: Set the emoji image protocol with `set_url_scheme()`, instead of defaulting to HTTPS.
...
Props extendwings.
Fixes #31735 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31861 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:10:35 +00:00
48cb73bba1
Emoji: When we're replacing emoji with `<img>`s in email, we can only do that if the Content-Type is text/html - otherwise, they'll show up in the email as the HTML string.
...
Fixes #31720
git-svn-id: https://develop.svn.wordpress.org/trunk@31860 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-22 23:15:34 +00:00
c1b0b8e97e
Fix a typo in the description for the `_wp_filter_build_unique_id()` DocBlock.
...
Props lamosty.
Fixes #31732 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31859 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-22 22:55:21 +00:00
f6aa243908
TinyMCE: fix the icon for the `wp_code` button. Fixes #31733 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@31858 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-22 22:53:32 +00:00
9822d05f72
Media: Show filename instead of extension in the list table.
...
This helps differentiate between files with the same or similar image or icon. Extension shows as a part of the filename, and so is not separately needed anymore.
fixes #30943 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31857 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-22 11:02:00 +00:00
e0e4780c9d
TinyMCE: when pasting an URL, check if the node it is pasted at is empty and remove any empty inline child elements.
...
Fixes #31158 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31856 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 20:33:55 +00:00
601aee103a
Supplement hook documentation for the `get_terms_fields` filter to more clearly explain the expected consequences of using it to modify the fields to select in a terms query.
...
Props boonebgorges.
Fixes #31174 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31855 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 20:10:22 +00:00
d66fffa31b
Document default arguments for `paginate_links()` as a hash notation.
...
Props atimmer.
Fixes #31433 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31854 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 20:03:04 +00:00
e450904e35
Adjust DocBlocks for `get_|the_post_thumbnail()` to clarify the difference between the 'thumbnail' and 'post-thumbnail' image sizes.
...
Also fleshes out parameter documentation for the two functions.
Props magicroundabout for the initial patch.
Fixes #31351 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31853 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 19:56:16 +00:00
b939e06b06
Add more verbose inline documentation inside of `wpautop()` to more clearly explain what's going on.
...
Props ericlewis, johneckman, azaozz.
Fixes #31041 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31852 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 19:46:41 +00:00
34a7cdf926
Add hook documentation for the `get_media_embedded_in_content_allowed` filter, introduced in [31574].
...
Props valendesigns.
Fixes #26675 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31851 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 19:28:30 +00:00
490fb1bf52
Trigger `_doing_it_wrong()` if `register_sidebar()` is not passed an `id`
...
* If you don't pass an `id`, WP sets an auto-increment one for you.
* But this depends on order of sidebar definition.
* Change the order or remove a sidebar? They jumble.
fixes #31675
props tschutter, valendesigns
git-svn-id: https://develop.svn.wordpress.org/trunk@31850 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 18:29:13 +00:00
1e4238d6a8
Bundled themes: update editor styles to better display images and captions in small screens.
...
Props jacklenox, see #31250 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31849 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 16:34:15 +00:00
6d7c4f39f0
Use shared fixtures in RSS2 unit tests.
...
See #31705 , #30017 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31848 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 12:34:28 +00:00
e3b2637699
When converting emoji in email to static images, check that the message is defined, otherwise we could cause PHP warnings.
...
Props nerrad.
Fixes #31708 .
git-svn-id: https://develop.svn.wordpress.org/trunk@31847 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 12:31:30 +00:00
Boone Gorges
Andrew Ozz
Dominik Schilling (ocean90)
ocean90
Drew Jaynes
Dion Hulse
Gary Pendergast
Sergey Biryukov
Aaron Jorbin
John Blackbourn
Helen Hou-Sandi
Mark Jaquith
Lance Willett