Commit Graph

2755 Commits

Author SHA1 Message Date
Scott Taylor
296c559baf if is a statment, not a function.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:00:15 +00:00
Scott Taylor
9cf3adb204 Avoid using <code> in a translation string.
Props ramiy.
Fixes #31848.


git-svn-id: https://develop.svn.wordpress.org/trunk@32799 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:52:39 +00:00
Helen Hou-Sandi
d878ce73f5 Media list table: Restore row actions.
see #29881, #32657.


git-svn-id: https://develop.svn.wordpress.org/trunk@32798 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 19:46:27 +00:00
Helen Hou-Sandi
b9b36d1c57 Comments: Better markup for the edit screen.
Previously there were no labels, and since labels can't contain links and the links were of dubious value, we've removed those.

props afercia, DrewAPicture.
fixes #31326.


git-svn-id: https://develop.svn.wordpress.org/trunk@32796 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 18:53:16 +00:00
Boone Gorges
91512a9161 Tag/category conversion link on edit-tags.php should point to specific importer page when cat2tag plugin is active.
Props solarissmoke, c3mdigital.
Fixes #16369.

git-svn-id: https://develop.svn.wordpress.org/trunk@32792 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 04:29:04 +00:00
Dion Hulse
9f2ad2538e Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key.
Props mordauk. Fixes #31784


git-svn-id: https://develop.svn.wordpress.org/trunk@32784 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 06:25:58 +00:00
Dion Hulse
8455dd10da Updats: Add a filter for the options params for the update being performed.
Props nofearinc. Fixes #27754


git-svn-id: https://develop.svn.wordpress.org/trunk@32783 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:34:52 +00:00
Dion Hulse
5b607d7ff6 Updates: Allow the update row to include the active border styling post-ajax update.
Props TobiasBg. Fixes #32129


git-svn-id: https://develop.svn.wordpress.org/trunk@32782 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:12:41 +00:00
Dion Hulse
4f8b348c9b Updates: Remove redundant title tags from update outputs.
Props afercia. Fixes #32530


git-svn-id: https://develop.svn.wordpress.org/trunk@32781 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 05:08:48 +00:00
Dion Hulse
672f394b57 Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin.
Props magicroundabout. Fixes #32110 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@32780 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 04:27:37 +00:00
Dion Hulse
a5ed63c86f Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
Fixes #32435, #32473


git-svn-id: https://develop.svn.wordpress.org/trunk@32779 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:47:54 +00:00
Dion Hulse
5a33c20515 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32778 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:31:40 +00:00
Dion Hulse
7805a509f3 Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32777 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 03:19:30 +00:00
Dion Hulse
d72005f6d0 Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers.
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32776 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-15 02:47:19 +00:00
Helen Hou-Sandi
97e6967d63 Multisite: Use an email input for new user email address.
We also need to set novalidate on the form due to some browsers rejecting valid email addresses containing an IDN. We should holistically investigate whether this is still an issue in any major browsers at some point.

props earnjam.
fixes #32643.


git-svn-id: https://develop.svn.wordpress.org/trunk@32774 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 20:40:35 +00:00
Helen Hou-Sandi
32845bd9c6 Reduce form spacing on narrower screens.
props liljimmi.
fixes #32489, #32484.


git-svn-id: https://develop.svn.wordpress.org/trunk@32772 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 20:11:40 +00:00
Andrew Nacin
8b5b201fa1 Tweak the first post/page content to get with the times.
props chriscct7.
fixes #22474.


git-svn-id: https://develop.svn.wordpress.org/trunk@32768 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 18:55:52 +00:00
Jeremy Felt
2cdea6f446 Remove a now unused switch_to_blog() and restore_current_blog() in site-info.php
Now that we decide when to automatically update `home` and `siteurl`, we no longer need to switch to the site while displaying the form output.

See #32503.


git-svn-id: https://develop.svn.wordpress.org/trunk@32761 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 08:22:34 +00:00
Jeremy Felt
4b0eaacd84 Remove the "Update siteurl and home as well" checkbox when editing a site
Rather than provide a checkbox to update the `siteurl` and `home` options, we can make an educated decision based on the current state. If the home and/or siteurl domain and path match the existing domain and path of the site, then we update with the new information.

Also, while scheme is not stored in `wp_blogs` along with a site, the scheme of the `home` and `siteurl` options can now be modified via the Site URL setting in `site-info.php` when the `home` and/or `siteurl` options match the existing domain.

Props @hugobaeta, @earnjam, @jeremyfelt.
Fixes #32503, see #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@32760 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 07:51:30 +00:00
Jeremy Felt
250aaa16e8 Capture domain and path when editing sites on a subdomain network
When a network is configured as subdomain, allow for the input of arbitrary domain and path combinations when editing a site rather than just the domain.

This takes a step or two toward #32503.

Props @scribu, @ericlewis, @jeremyfelt.
See #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@32759 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 07:08:30 +00:00
Jeremy Felt
a0ef4e9ed6 Improve code readability in site-info.php
In advance of some other work here, clean up some braces and spaces.

See #22383.


git-svn-id: https://develop.svn.wordpress.org/trunk@32758 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-14 05:00:27 +00:00
Scott Taylor
857197f14d In WP_MS_Users_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32757 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 17:10:49 +00:00
Scott Taylor
dea07077fa In WP_MS_Themes_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32756 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 16:53:06 +00:00
Scott Taylor
ae8bd2bcd3 In WP_MS_Sites_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32755 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 16:23:01 +00:00
Scott Taylor
31d50764c3 In WP_Media_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32754 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:56:13 +00:00
Scott Taylor
c32f856cf3 In WP_Links_List_Table::display_rows():
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32753 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:32:57 +00:00
Scott Taylor
6c6638c163 In WP_Posts_List_Table, move the <th> markup out of ->column_cb().
See #29881, [32740].


git-svn-id: https://develop.svn.wordpress.org/trunk@32752 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 15:13:47 +00:00
Scott Taylor
0eb50f80b9 In wp_ajax_hidden_columns(), don't explode() on an empty string.
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.


git-svn-id: https://develop.svn.wordpress.org/trunk@32751 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:59:40 +00:00
Scott Taylor
9629b5413d In WP_Posts_List_Table::column_title(), use is_post_type_hierarchical() instead of $this->hierarchical_display in the logic to determine whether the_excerpt() should be called.
Fixes #32187.


git-svn-id: https://develop.svn.wordpress.org/trunk@32749 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:41:15 +00:00
Dominik Schilling (ocean90)
8502ee5f86 Nav menu: Allow the sortable items selector in wpNavMenu to be overridden.
props adamsilverstein.
fixes #32633.

git-svn-id: https://develop.svn.wordpress.org/trunk@32745 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-13 14:02:41 +00:00
Weston Ruter
4092c5a37e Fix regressions from [32649] wrt Customizer expanded and active state changes for sections.
The `args.completeCallback` was not always called when `onChangeExpanded()` was called. And when a section became inactive (`active` state goes to `false`) and it was currently `expanded`, the Customizer panel would then becomes blank as the section was hidden; it needed to `collapse()` the section first before hiding the element.

See #31336.



git-svn-id: https://develop.svn.wordpress.org/trunk@32743 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 22:27:51 +00:00
Scott Taylor
52cfab850f After [32740], in WP_Posts_List_Table::single_row() - $lock_holder is checked but unused, so the call to get_userdata() is unnecessary.
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32742 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 20:47:46 +00:00
Scott Taylor
7fbeffec20 After [32740], correct doc block typo.
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32741 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 20:28:22 +00:00
Scott Taylor
1de436b466 Override ->single_row_columns() in WP_Posts_List_Table.
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.

This list table class is now easier to subclass.

Props joehoyle, wonderboymusic.
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32740 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 20:17:59 +00:00
Scott Taylor
87f0a73bdc In WP_Terms_List_Table::display_rows_or_placeholder():
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32739 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:54:56 +00:00
Scott Taylor
8463ad6f29 In WP_Posts_List_Table::single_row():
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32738 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:49:18 +00:00
Scott Taylor
cae366cad0 In WP_Media_List_Table::display_rows(), get_the_terms() can return WP_Error, so its return value should be checked before traversing.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32737 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:44:50 +00:00
Scott Taylor
ca123a2054 In WP_Comments_List_Table::column_comment(), $post and $the_comment_status are unused, as is the $comment_status global.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32736 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:38:26 +00:00
Scott Taylor
9bb0d08c14 Fix some malformed doc blocks in Custom_Image_Header.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32735 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:34:49 +00:00
Scott Taylor
6b48cb1205 Fix some malformed doc blocks in Custom_Background.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32734 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 18:24:10 +00:00
Scott Taylor
3f29a2101d Don't loosely compare functions that return bool against a literal bool.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32730 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 17:18:38 +00:00
Dion Hulse
671218ac1d SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions.
See #32345


git-svn-id: https://develop.svn.wordpress.org/trunk@32726 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-12 06:30:58 +00:00
Konstantin Obenland
995753d1d0 Improve non-visual feedback for list table items without terms.
Props karpstrucking, afercia.
Fixes #32150.



git-svn-id: https://develop.svn.wordpress.org/trunk@32725 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-11 09:27:13 +00:00
Helen Hou-Sandi
c2ed5b170d List tables: Use a class instead of inline styles for hidden columns.
fixes #32608.


git-svn-id: https://develop.svn.wordpress.org/trunk@32724 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 19:46:39 +00:00
Helen Hou-Sandi
c296d882a8 List tables:
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32723 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 19:30:22 +00:00
Helen Hou-Sandi
1a0773a4b4 List tables: Better primary column back-compat.
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.

props kovshenin.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32722 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 14:58:42 +00:00
Helen Hou-Sandi
615ab22fea List tables: Consolidate <td> output for posts.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32721 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 14:00:55 +00:00
Konstantin Obenland
e66948cf50 More semantic markup for the post formats metabox.
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.



git-svn-id: https://develop.svn.wordpress.org/trunk@32720 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 09:08:10 +00:00
Jeremy Felt
fc2ba19214 Additional improvement to sites list table display
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.

See #32434.


git-svn-id: https://develop.svn.wordpress.org/trunk@32719 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 07:27:09 +00:00
Jeremy Felt
9170edb2b2 Improve information displayed in a network's sites list table
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.


git-svn-id: https://develop.svn.wordpress.org/trunk@32718 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 06:49:38 +00:00