Commit Graph

39639 Commits

Author SHA1 Message Date
Sergey Biryukov 2a163fa733 Date/Time: Return early from `the_weekday()` and `the_weekday_date()` if we're not in the loop.
Restore `$previousweekday` global usage in `the_weekday_date()`, so it could still be used simultaneously with `the_date()`.

Partially reverts [45378].
See #47354.

git-svn-id: https://develop.svn.wordpress.org/trunk@45379 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-23 00:37:56 +00:00
Sergey Biryukov 48fb69f013 Date/Time: Bring some consistency to `the_date()` and `the_weekday_date()`:
* Make `the_date()` always apply the the filter and return a value.
* Use `is_new_day()` in `the_weekday_date()`.
* Add a unit test for `the_weekday_date()`.

Fixes #47354.

git-svn-id: https://develop.svn.wordpress.org/trunk@45378 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-22 21:57:29 +00:00
Sergey Biryukov 36df800c3c Docs: Improve documentation for `the_date()` and `the_weekday_date()`.
Correct type for `$currentday` and `$previousday` globals.

See #47354, #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@45377 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-22 21:47:49 +00:00
Andrea Fercia 1a1031b466 Accessibility: Improve the media views upload Dismiss Errors button.
- makes the Dismiss Errors button visible in the media views inline uploader
- avoids a focus loss when activating the Dismiss Errors button

See the related GitHub issue from the WPCampus accessibility audit https://github.com/WordPress/gutenberg/issues/15354

Fixes #47113.


git-svn-id: https://develop.svn.wordpress.org/trunk@45376 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-22 19:32:22 +00:00
Sergey Biryukov 6491746559 Date/Time: Use strict comparison in `is_new_day()`, add a unit test.
Props pbearne.
Fixes #46627.

git-svn-id: https://develop.svn.wordpress.org/trunk@45375 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-22 17:52:22 +00:00
Jonathan Desrosiers f9e4f60577 General: Add missing unit tests for `wp_array_slice_assoc()`.
Props pbearne, desrosj.
Fixes #46638.

git-svn-id: https://develop.svn.wordpress.org/trunk@45371 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-21 14:47:58 +00:00
Jonathan Desrosiers 05da62cca7 Feeds: Ensure a feed’s `<lastBuildDate>` has the correct date.
The maximum modified time for a is currently being determined after an arbitrary date format is applied. Because the string sort in `max()` is being used to return the highest (most recent) modified value, the incorrect date is sometimes returned. This was introduced in [45247].

Props onlanka, Rarsr, mukesh27.
Fixes #47304.

git-svn-id: https://develop.svn.wordpress.org/trunk@45367 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-20 14:41:59 +00:00
Sergey Biryukov ff131f5e29 Upgrade/Install: As a follow-up to [45357], when linking to Update PHP support page in error messages, check if `wp_get_update_php_url()` and `wp_get_update_php_annotation()` exist.
`wp-admin/includes/update-core.php` runs in the context of the previous WordPress version. Any calls to newly introduced functions there need to be checked via `function_exists()`.

Reviewed by desrosj, earnjam, SergeyBiryukov.

Props dd32, imath.
Fixes #47323.

git-svn-id: https://develop.svn.wordpress.org/trunk@45365 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-20 14:28:03 +00:00
Peter Wilson b9e6f18350 KSES: Add `flex` and related long form properties to safe CSS.
Allow `flex`, `flex-grow`, `flex-shrink` and `flex-basis` to be used in inline CSS. As of WordPress 5.3 the block editor is expected to use `flex-basis` inline to set the width in the column block.

Props aduth.
Fixes #47281.
See #37248.



git-svn-id: https://develop.svn.wordpress.org/trunk@45363 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-18 04:33:27 +00:00
Sergey Biryukov e353c2841a Taxonomy: In `wp_insert_term()`, handle an error if writing to the `term_taxonomy` table fails.
This complements the check for successful writing to the `terms` table, added in [7430].

Props mbabker.
Fixes #47313.

git-svn-id: https://develop.svn.wordpress.org/trunk@45362 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 22:27:55 +00:00
Sergey Biryukov 0205cf09f0 Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.
Additionally, fix a regression in [44451] where the error message in `wp-admin/upgrade.php` was prepared, but never displayed.

Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Fixes #46937.

git-svn-id: https://develop.svn.wordpress.org/trunk@45357 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 18:10:55 +00:00
Sergey Biryukov 76755c0e68 Media: Fix deletion of files on Windows.
`wp_delete_file_from_directory()` should always normalize file paths before comparing.

Props tonybogdanov, SergeyBiryukov.
Fixes #47185.

git-svn-id: https://develop.svn.wordpress.org/trunk@45352 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 13:28:15 +00:00
Sergey Biryukov 3f641505fe Build/Test Tools: Use a non-zero exit code in `wp_check_php_mysql_versions()` when minimum PHP or MySQL requirements are not met.
This allows automated scripts and test suites to interpret the result correctly.

Props jrf, spacedmonkey.
Fixes #47169.

git-svn-id: https://develop.svn.wordpress.org/trunk@45350 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 12:33:50 +00:00
Sergey Biryukov a36aa1b078 Formatting: Adjust `wp_targeted_link_rel()` to ensure JSON format is preserved and correct quotes are used when adding the missing `rel` attribute.
Props birgire, TobiasBg, fierevere, audrasjb, SergeyBiryukov.
Fixes #46316, #47244.

git-svn-id: https://develop.svn.wordpress.org/trunk@45348 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 12:08:50 +00:00
Sergey Biryukov ee8771923a Site Health: In PHP modules test description, move the space before the screen reader text out from the translatable string.
Props ocean90, tobifjellner.
Fixes #47161.

git-svn-id: https://develop.svn.wordpress.org/trunk@45346 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 11:49:52 +00:00
Alex Shiels 85a90cb244 Upgrade/Install: Don't run signature verify on slow 32-bit systems.
The sodium_compat library can be very slow for certain operations on 32-bit architectures, which can lead to web server timeouts while attempting to verify an update. This adds a runtime speed check to skip signature verification on systems that would otherwise time out. Includes simple unit tests.

Props dd32, paragoninitiativeenterprises.
See #47186.


git-svn-id: https://develop.svn.wordpress.org/trunk@45345 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 11:05:45 +00:00
Alex Shiels 3360d50bc2 Upgrade/Install: Update sodium_compat to v1.10.0.
This adds a runtime_speed_test() method for estimating if the 32-bit implementation is fast enough for expensive computations.

Props paragoninitiativeenterprises.
See #47186.


git-svn-id: https://develop.svn.wordpress.org/trunk@45344 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 10:57:19 +00:00
Andrew Ozz 14066540c0 jQuery: bring jquery.js back into the WordPress SVN repo and backport the patch from 3.4.0.
Props MikeNGarrett, peterwilsoncc, azaozz.
Fixes #47020 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@45342 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 04:24:44 +00:00
Sergey Biryukov dc2e521269 Accessibility: In back-compat code added for `get_search_form()` in [44956], when checking the (previously boolean) `$args` value, account for non-strict comparison.
Props dkarfa, sachyya-sachet.
Fixes #47177. See #42057.

git-svn-id: https://develop.svn.wordpress.org/trunk@45340 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 02:21:20 +00:00
Sergey Biryukov dc8c8dd878 Help/About: Restore placeholder for WordPress version in tagline on About, Credits, and Freedoms pages to include minor versions.
Props desrosj, mukesh27.
Fixes #46408.

git-svn-id: https://develop.svn.wordpress.org/trunk@45338 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 01:07:12 +00:00
Sergey Biryukov 040a58ff57 Site Health: Use correct singular string for plugin and theme version tests.
Props edocev, Presskopp.
Fixes #47264.

git-svn-id: https://develop.svn.wordpress.org/trunk@45336 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:59:20 +00:00
Sergey Biryukov 448234f966 I18N: Avoid using placeholders for link start and end tags in alt text description strings added in [45158].
Use an established pattern of moving additional link attributes out of the translatable string.

Props dimadin.
Fixes #47159.

git-svn-id: https://develop.svn.wordpress.org/trunk@45334 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:52:32 +00:00
Sergey Biryukov e6dcab7803 Site Health: In PHP modules test, ensure the description is translated as a whole sentence, not as separate string parts.
Props dimadin, SergeyBiryukov.
Fixes #47161.

git-svn-id: https://develop.svn.wordpress.org/trunk@45331 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-17 00:06:49 +00:00
Sergey Biryukov 0126a4bd2a Site Health: In HTTP requests test, when checking whether the `WP_HTTP_BLOCK_EXTERNAL` constant is defined, check its value as well.
Props chesio.
Fixes #47297.

git-svn-id: https://develop.svn.wordpress.org/trunk@45328 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 22:07:35 +00:00
Jonathan Desrosiers c18460698f Privacy: Prevent email field for personal data requests from overflowing.
Props anischarolia, ianbelanger, afercia.
Fixes #46961.

git-svn-id: https://develop.svn.wordpress.org/trunk@45326 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 20:44:41 +00:00
Jonathan Desrosiers cd511054a0 Menus: Fix alignment of menu actions on mobile.
In [41197], changes were made to improve the responsive view for the Menu Name field and Save buttons. This caused the Delete Menu button to be misaligned.

Props ianbelanger, audrasjb, afercia, mukesh27.
Fixes #47173.

git-svn-id: https://develop.svn.wordpress.org/trunk@45324 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 19:04:42 +00:00
Jonathan Desrosiers b7a79cf126 Site Health: Improve alignment and spacing for section headers.
This changes the CSS for Site Health headers to use flexbox, which helps ensure the text is vertically aligned center and consistently spaced in both the Status and Info tabs. It also fixes an issue where the loading spinner GIF was cut off on smaller screens (originally reported in #47203.

Props Presskopp, odminstudios, kjellr, afercia, desrosj, hedgefield, ianbelanger, xavortm.
Fixes #47063.

git-svn-id: https://develop.svn.wordpress.org/trunk@45322 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 18:29:47 +00:00
Jonathan Desrosiers 7bd0450833 Build/Test Tools: Upgrade `node-sass` to 4.12.0.
`node-sass` 4.12 adds support for Node 12. This will prevent errors for anyone running Node 12 locally instead of the LTS version (currently 10.15.3).

Props desrosj, aduth, netweb.
Fixes #47257.

git-svn-id: https://develop.svn.wordpress.org/trunk@45321 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 18:14:37 +00:00
Andrew Duthie 9848fad564 Block Editor: Upgrade WordPress packages to the latest versions.
Updated packages:

 - @wordpress/annotations@1.2.3
 - @wordpress/block-editor@2.0.2
 - @wordpress/block-library@2.4.5
 - @wordpress/blocks@6.2.5
 - @wordpress/components@7.3.2
 - @wordpress/dom@2.2.5
 - @wordpress/e2e-tests@1.1.5
 - @wordpress/edit-post@3.3.5
 - @wordpress/editor@9.2.5
 - @wordpress/format-library@1.4.5
 - @wordpress/list-reusable-blocks@1.3.5
 - @wordpress/nux@3.2.5
 - @wordpress/rich-text@3.2.3

Props: youknowriad, gwwar, iseulde, tfrommen, gziolo.

Fixes #47284.


git-svn-id: https://develop.svn.wordpress.org/trunk@45319 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 18:06:27 +00:00
Andrew Ozz d2e3a1f1a0 Build tools: fix generating `*-rtl.css` files in `wp-includes/css` after `grunt --dev` was used.
Fixes #47078.

git-svn-id: https://develop.svn.wordpress.org/trunk@45317 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-16 02:24:58 +00:00
Andrew Ozz b202561a5f Update TinyMCE to 4.9.4. Changelog: https://github.com/tinymce/tinymce/blob/4.x/changelog.txt.
Fixes #47229 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@45316 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 23:44:37 +00:00
Jonathan Desrosiers ffc2d83dea Bootstrap/Load: Prevent PHP errors when a drop-in triggers fatal error protection.
When a drop-in (such as `advanced-cache.php`) contains a PHP error, additional PHP errors are caused when displaying the error protection screen because `load_default_textdomain()` and `WP_Error` are not yet available.

Though recovery mode is not supported for `mu-plugins` and drop-ins, fatal error protection is. This change ensures the error screen is displayed when a fatal error is encountered within a drop-in and not a white screen.

Props TimothyBlynJacobs, spacedmonkey, daxelrod.
Fixes #47265.

git-svn-id: https://develop.svn.wordpress.org/trunk@45311 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 18:18:02 +00:00
Jonathan Desrosiers cc12950d41 Administration: Remove duplicate `font-face` declaration in Dashicons CSS.
This was causing console warnings in some browsers.

Props aduth, joen, afercia, timph, ianbelanger.
Fixes #47183.

git-svn-id: https://develop.svn.wordpress.org/trunk@45310 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 16:07:57 +00:00
Jonathan Desrosiers 851cb8b8f2 Site Health: Improve vertical alignment of icons in test result descriptions.
This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

git-svn-id: https://develop.svn.wordpress.org/trunk@45309 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 14:24:15 +00:00
Jonathan Desrosiers f10ea0702a Site Health: Link to the correct plugin update screen in multisite installs.
Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189.

git-svn-id: https://develop.svn.wordpress.org/trunk@45308 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-15 14:11:50 +00:00
Sergey Biryukov f4ceb91c5a Docs: Add a `@see` reference to `WP_REST_Revisions_Controller` in `WP_REST_Autosaves_Controller` DocBlock.
Props chintan1896.
Fixes #47232.

git-svn-id: https://develop.svn.wordpress.org/trunk@45307 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-14 23:52:47 +00:00
Sergey Biryukov 8cacee3960 Docs: Add `@see` references to `WP_Widget_Media` in media widget DocBlocks.
Props iamjaydip.
Fixes #47231.

git-svn-id: https://develop.svn.wordpress.org/trunk@45306 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-14 20:21:28 +00:00
Sergey Biryukov 6146ba90ce Docs: Add missing `@see` tag to `WP_REST_Post_Search_Handler` DocBlock.
Props vishitshah.
Fixes #47230.

git-svn-id: https://develop.svn.wordpress.org/trunk@45305 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-14 14:58:09 +00:00
Sergey Biryukov e953dca4e7 Docs: Convert `@see` reference in `WP_REST_Request` DocBlock to `@link`, to avoid a broken link in Developer Reference.
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@45304 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-14 14:54:31 +00:00
Sergey Biryukov 4ee05756d2 Docs: Fix typo in `wp_mail()` description.
Props seedsca.
Fixes #47208.

git-svn-id: https://develop.svn.wordpress.org/trunk@45302 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-10 09:52:13 +00:00
Andrea Fercia cae0608a7f Accessibility: Improve the "skip links" position for medium and small screens.
Fixes #47065.


git-svn-id: https://develop.svn.wordpress.org/trunk@45301 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 21:10:20 +00:00
Andrea Fercia 2ee480e11c Accessibility: Add `aria-current` to the links in the `<nav>` elements introduced in [44905].
Also fixes a few translators comments and coding standards.

Props audrasjb.
Fixes #47106.


git-svn-id: https://develop.svn.wordpress.org/trunk@45300 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 20:57:06 +00:00
Jonathan Desrosiers 5b2fb1637c Twenty Nineteen: Fix Docblock spelling error.
Props mukesh27.
Fixes #47129.

git-svn-id: https://develop.svn.wordpress.org/trunk@45299 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 20:07:49 +00:00
Jonathan Desrosiers 3da0d67f80 I18N: Combine similar strings with minor differences.
Props dimadin.
Fixes #47158.

git-svn-id: https://develop.svn.wordpress.org/trunk@45298 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 19:47:28 +00:00
Jonathan Desrosiers d69d56abb1 Twenty Nineteen: Remove duplicate code block.
Introduced in [44305].

Props mukesh27, afercia.
Fixes #46455.

git-svn-id: https://develop.svn.wordpress.org/trunk@45297 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 18:03:15 +00:00
Jonathan Desrosiers a72dd388f5 Administration: Prevent cards on the Tools page from overflowing on small screens.
Props anischarolia, mukesh27.
Fixes #46972.

git-svn-id: https://develop.svn.wordpress.org/trunk@45296 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-09 14:55:18 +00:00
Jonathan Desrosiers 3607546bad Help/About: Update the 5.2 tagline on Freedoms and Credits.
Props ocean90.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45292 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-07 19:59:17 +00:00
laurelfulford 6b6671d94b Default Themes: Bump the version numbers and release dates.
Update the theme versions and release dates for the default themes, in time for WordPress 5.2.

The POT files for Twenty Eleven and Twenty Ten have also been updated.

Fixes #47172.



git-svn-id: https://develop.svn.wordpress.org/trunk@45289 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-07 18:48:28 +00:00
Jonathan Desrosiers 6289d9e304 Help/About: Final 5.2 about page updates.
Use final image URLs and fix a bug in IE11 where images were being cut off.

Props afercia, SergeyBiryukov, ianbelanger, desrosj, audrasjb.
See #46901.

git-svn-id: https://develop.svn.wordpress.org/trunk@45287 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-07 17:18:34 +00:00
Andrew Ozz 96649a5ad1 Fix `setup_postdata()` to set the (inside the loop) globals before `the_post` action is fired. Follow-up from #42814 and [44941].
Props david.binda, spacedmonkey, boonebgorges, birgire, jorbin, azaozz.
Fixes #47114 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@45285 602fd350-edb4-49c9-b593-d223f7449a82
2019-05-04 20:59:11 +00:00