Commit Graph

40752 Commits

Author SHA1 Message Date
Andrew Ozz
329e042060 Uploads: Retry to post-process images after HTTP 500 and HTTP 502 errors.
Props mikeschroder, azaozz.
Fixes #47872.

git-svn-id: https://develop.svn.wordpress.org/trunk@46506 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 19:54:36 +00:00
Andrea Fercia
d2da46a5c5 Accessibility: Media: Improve the text of the Media Modal actions toggle button displayed in the responsive view.
See #47149.


git-svn-id: https://develop.svn.wordpress.org/trunk@46489 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 18:01:53 +00:00
Andrea Fercia
ab8e92995b Accessibility: Media: Improve the new Media Modal headings text.
See #47610.


git-svn-id: https://develop.svn.wordpress.org/trunk@46488 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 17:56:41 +00:00
Jake Spurlock
778bf0c721 Administration: Ensure that admin referer nonce is valid.
Fix for a testing regression.

Props desrosj.


git-svn-id: https://develop.svn.wordpress.org/trunk@46485 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 17:13:35 +00:00
Jake Spurlock
4e2d91d186 REST API: Ensure that we don't generate warnings from sending extra headers after headers have been sent.
Fixes issues stemming from [46478].



git-svn-id: https://develop.svn.wordpress.org/trunk@46483 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 16:23:13 +00:00
Jake Spurlock
2a5c167b21 REST API: Send a Vary: Origin header on GET requests.
Add this header on all GET requests to prevent cached requests.

Props darthhexx, davidbinda, nickdaugherty, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46478 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:41:05 +00:00
Jake Spurlock
f53a78fda7 Administration: Ensure that admin referer nonce is valid.
Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Props vortfu, xknown, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46477 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:38:14 +00:00
Jake Spurlock
f06c6bb20c Filesystem API: Prevent directory travelersals when creating new folders.
Reject file paths that contain sub-directory paths.

Props iandunn, xknown, sstoqnov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46476 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:29:25 +00:00
Jake Spurlock
af8afb943e HTTP API: Protect against hex interpretation.
Return earlier from wp_http_validate_url().

Props: iandunn, xknown, voldemortensen, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@46475 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:25:38 +00:00
Jake Spurlock
ad6c214307 Query: Remove the static query property.
Prevent unauthenticated views of publicly queryables content types.

Props aaroncampbell, whyisjake, nickdaugherty, xknown.


git-svn-id: https://develop.svn.wordpress.org/trunk@46474 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 15:18:49 +00:00
Sergey Biryukov
0c75758333 Formatting: In wp_validate_redirect(), normalize the path when validating the location for relative URLs, to account for Windows paths.
Props peterwilsoncc, rconde, jmmathc, mat-lipe, Sixes, justinahinon, cmagrin, daxelrod, SergeyBiryukov.
Fixes #47980.

git-svn-id: https://develop.svn.wordpress.org/trunk@46472 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-14 10:50:41 +00:00
Sergey Biryukov
a9891c7109 Docs: Fix typo in a comment in WP_REST_Settings_Controller::prepare_value().
Convert the comment to a multi-line format per the documentation standards.

Props itowhid06.
See #48296.

git-svn-id: https://develop.svn.wordpress.org/trunk@46471 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-13 10:00:18 +00:00
Peter Wilson
8f7174fa1a Docs: Correct documentation typo in print_emoji_detection_script().
Props itowhid06.
Fixes #48298. See #47110.


git-svn-id: https://develop.svn.wordpress.org/trunk@46470 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-13 02:46:25 +00:00
Peter Wilson
438de1ff41 Docs: Correct comment typo in WP_REST_Terms_Controller::update_item().
Props manikmist09.
Fixes #48295. See #47110.


git-svn-id: https://develop.svn.wordpress.org/trunk@46469 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-13 02:40:05 +00:00
John Blackbourn
cda19de292 Docs: Fix and improve inline documentation for the HTTP API.
See #47110


git-svn-id: https://develop.svn.wordpress.org/trunk@46468 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 18:03:22 +00:00
Sergey Biryukov
a8259b8c5e Users: Make sure wp_logout() clears current user, so that a subsequent call to is_user_logged_in() works as expected.
Props sebastian.pisula, donmhico, roytanck, juliobox.
Fixes #35488.

git-svn-id: https://develop.svn.wordpress.org/trunk@46467 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 03:08:56 +00:00
Sergey Biryukov
572934992f Tests: Rename tests methods in tests/pluggable.php per the handbook's naming convention.
See #47632.

git-svn-id: https://develop.svn.wordpress.org/trunk@46466 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 03:00:32 +00:00
Sergey Biryukov
5e6d8f584d Docs: Adjust @since note in shortcode_parse_atts() for consistency with similar notes.
See #47863.

git-svn-id: https://develop.svn.wordpress.org/trunk@46465 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 02:48:26 +00:00
Sergey Biryukov
7cd21b7bd0 I18N: Don't capitalize "Extension" in update_core(), for consistency with other strings.
Follow-up to [46455].

See #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46464 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 02:40:43 +00:00
Sergey Biryukov
e21792cb37 Docs: Add requires_php to the list of fields returned by plugins_api().
Props ediamin.
Fixes #48291.

git-svn-id: https://develop.svn.wordpress.org/trunk@46463 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-12 02:33:13 +00:00
Sergey Biryukov
9a6bce9f5c Formatting: Make sure wp_sanitize_redirect() encodes spaces in URLs instead of stripping them out.
Props donmhico, hlashbrooke, dd32, azaozz.
Fixes #36998.

git-svn-id: https://develop.svn.wordpress.org/trunk@46462 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 23:52:11 +00:00
Anthony Burchell
dcb037fc3a Media: Adds Edit Image controller to Media Library select frame.
This adds the necessary state for `EditImage` views in the `select` frame and listeners for setting that view.

Props fblaser, w3rkjana, afercia, antpb.
See #48028.


git-svn-id: https://develop.svn.wordpress.org/trunk@46461 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 20:41:51 +00:00
Anthony Burchell
42493b7ed8 Administration: Prevents horizontal scroll jumping around while admin menu is open.
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.


git-svn-id: https://develop.svn.wordpress.org/trunk@46460 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 19:20:43 +00:00
Mike Schroder
68729adb57 Media: Update fallback previews to support _wp_make_subsizes()
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.

git-svn-id: https://develop.svn.wordpress.org/trunk@46459 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-11 07:52:12 +00:00
Aaron Jorbin
466937669a Cron: Prevent sending headers when using ALTERNATE_WP_CRON
ALTERNATE_WP_CRON echos things which causes a "Headers already sent" warning. This adds a check to ensure headers haven't already been sent.

Previously: [45560]

See: #45560. Fixes #48283.
Props dlh.



git-svn-id: https://develop.svn.wordpress.org/trunk@46458 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-10 22:50:05 +00:00
Dominik Schilling
7a682e690e Themes: Convert core-provided starter content to block content.
Props Clorith.
Fixes #48130.

git-svn-id: https://develop.svn.wordpress.org/trunk@46457 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-10 19:05:57 +00:00
K. Adam White
70b408c8fe REST API: Fix error in _fields filtering logic where only one of several requested sibling properties would be included.
Props kadamwhite, TimothyBlynJacobs.
Fixes #48266.


git-svn-id: https://develop.svn.wordpress.org/trunk@46456 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-10 17:16:44 +00:00
Jonathan Desrosiers
1bcd41b7c1 Upgrade/Install: Detect the presence of the native PHP JSON extension before updating.
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.

git-svn-id: https://develop.svn.wordpress.org/trunk@46455 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 22:20:37 +00:00
K. Adam White
22d50c492d REST API: Do not addslash when receiving meta arrays of non-string values.
Slashing non-string data caused PUT requests containing unmodified meta arrays of integers to fail the check against the existing stored meta value, causing a 500 when posting an unmodified response body back to the server.

Props TimothyBlynJacobs, augustuswm.
Fixes #48264.


git-svn-id: https://develop.svn.wordpress.org/trunk@46454 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 17:34:20 +00:00
Jake Spurlock
c608c85b67 Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201


git-svn-id: https://develop.svn.wordpress.org/trunk@46453 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 04:56:55 +00:00
Sergey Biryukov
176a3f0d7c Docs: Tweak the @since note in Walker::walk() and ::paged_walk() for better readability and consistency with other notes.
See #47678.

git-svn-id: https://develop.svn.wordpress.org/trunk@46452 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 04:33:34 +00:00
Sergey Biryukov
8ec0a21161 Docs: Add a @since note about new parameters with the spread operator added to function signatures.
Props jrf.
See #47678.

git-svn-id: https://develop.svn.wordpress.org/trunk@46451 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-09 04:26:22 +00:00
Jonathan Desrosiers
d4e9608dec Bundled Themes: Update/audit NPM dependencies for Twenty Nineteen.
Also, ignore the `node_modules` folder for Twenty Nineteen.

Fixes #48262.

git-svn-id: https://develop.svn.wordpress.org/trunk@46450 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 22:17:54 +00:00
Adam Silverstein
71aa81f2cd Post WordPress 5.3 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@46449 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 20:45:15 +00:00
Adam Silverstein
1e1ef432b4 WordPress 5.3 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@46448 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:57:09 +00:00
Dominik Schilling
e20a6135e4 Bundled Themes: Fix JSHint error in [46445]
Props ianbelanger.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46447 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:50:54 +00:00
Jonathan Desrosiers
2aad78b7d8 Bundled Themes: Change the eol-style property to native for Twenty Twenty files.
Props aazaozz, desrosj.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46446 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:19:30 +00:00
Jonathan Desrosiers
f95a75b783 Bundled Themes: Update Twenty Twenty.
This brings `trunk`'s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46357], see 7157870...7246fd6.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyusly, luminuu, itowhid06, cbravobernal, intimez, glauberglauber, ocean90, amolv, briceduclos, aristath, mukesh27, garrett-eclipse, audrasjb, afercia, dianeco, utsav72640, mahesh901122, tobifjellner.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46445 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:05:53 +00:00
Sergey Biryukov
af634cc62a Themes: Properly align Close/Previous/Next icons in theme preview overlay.
Props chetan200891.
Fixes #48248.

git-svn-id: https://develop.svn.wordpress.org/trunk@46444 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 19:05:13 +00:00
Sergey Biryukov
a15cc93479 Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu.
Props chetan200891.
Fixes #48250.

git-svn-id: https://develop.svn.wordpress.org/trunk@46443 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 18:47:18 +00:00
Sergey Biryukov
5f2352599f Code Modernisation: Introduce the spread operator in Walker::walk() and ::paged_walk().
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

This re-applies [45624] and reverts [45640], with a dev note upcoming for plugin authors to maintain backward compatibility with old versions of WordPress.

Props jrf.
See #47678.

git-svn-id: https://develop.svn.wordpress.org/trunk@46442 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 17:54:45 +00:00
John James Jacoby
0a818ec0fc Network Admin: Improve Site States in List Table rows.
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)

Fixes #37684. Props pbiron.

git-svn-id: https://develop.svn.wordpress.org/trunk@46441 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 17:44:42 +00:00
Andrea Fercia
3207d9a47e Accessibility: Script Loader: Add jQuery as dependency of admin-bar.
On the front end, themes that don't use jQuery make the admin bar fallback to the non-jQuery implementation. Some important features miss from the non-jQuery `admin-bar.js` part, for example `hoverintent` and, most importantly, the touch events for the mobile menu don't work at all.

Enqueueing jQuery is the simplest option for now. For the future, a complete rewriting of `admin-bar.js` in plain JavaScript is highly recommended.

See #47069.


git-svn-id: https://develop.svn.wordpress.org/trunk@46440 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 17:18:07 +00:00
Sergey Biryukov
357a18da2b Docs: Add missing @deprecated tags in the file docblock of some deprecated files.
Props jrf.
Fixes #48254.

git-svn-id: https://develop.svn.wordpress.org/trunk@46439 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 17:17:07 +00:00
Andrea Fercia
fb0d0e20ab Accessibility: Media: Improve the logic to render the ARIA tabs markup after [46363].
Additionally checks for the "menu" and "router" state attributes to better determine when the ARIA tabs pattern markup is appropriate.

See #47149.


git-svn-id: https://develop.svn.wordpress.org/trunk@46438 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 17:05:53 +00:00
Sergey Biryukov
1f6dbef069 I18N: Add context for the Archives string introduced in [45651] as a file type heading, to disambiguate from other types of archives.
Props alexclassroom.
Fixes #48259.

git-svn-id: https://develop.svn.wordpress.org/trunk@46437 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 17:02:23 +00:00
Adam Silverstein
4d44978e00 External Libraries: upgrade mediaelement to version 4.2.13.
Upgrade `mediaelement` to the latest version. Includes a variety of bug fixes made since the 4.2.6 release; see https://github.com/mediaelement/mediaelement/releases.

Props danieliser, Hareesh Pillai.
Fixes #46681.



git-svn-id: https://develop.svn.wordpress.org/trunk@46436 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 16:04:32 +00:00
K. Adam White
e2cf94fa04 REST API: Ensure rest_controller instantiates the post type's declared REST controller class.
Ensures that the ::get_rest_controller() method will always return an instanceof the expected controller class, or null.
Removes unused private static property $post_type_controllers.

Props dlh, TimothyBlynJacobs.
Fixes #45677.



git-svn-id: https://develop.svn.wordpress.org/trunk@46435 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 13:41:29 +00:00
K. Adam White
040304def7 REST API: Permit embedding of the 'self' link relation in the /search endpoint.
Removes a special-case prohibition against embedding 'self' which prevented ?_embed from being used with the /wp/v2/search endpoint.

Props TimothyBlynJacobs, chrisvanpatten, kadamwhite.
Fixes #47684.



git-svn-id: https://develop.svn.wordpress.org/trunk@46434 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 04:43:10 +00:00
K. Adam White
e17e5aab68 REST API: Ensure users with "moderate_comments" capability may edit comments.
Props meloniq.
Fixes #47024.



git-svn-id: https://develop.svn.wordpress.org/trunk@46433 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-08 04:00:25 +00:00