Scott Taylor
4eb97de4cf
In bookmark.php
, clarify some return
docs.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32527 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:12:41 +00:00
Scott Taylor
ff1eabd7e1
In author-template.php
, clarify/add some return
docs.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32526 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:09:44 +00:00
Scott Taylor
cb145bd1c0
In admin-bar.php
, most functions simply return when a conditional is not met. wp_admin_bar_render()
shouldn't explicitly return false
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32525 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 20:09:00 +00:00
Boone Gorges
f0d6031d9b
Streamline support for multiple post types in get_posts_by_author_sql()
.
...
* Don't accept a comma-separated list, only a single post type or an array of post types. This is easier to document.
* Add changelog entries to all calling functions.
Props DrewAPicture.
Fixes #32243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32524 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 19:48:19 +00:00
Boone Gorges
e656053bce
Support multiple post types in count_user_posts()
and other functions that use get_posts_by_author_sql()
.
...
Props nikonratm.
Fixes #32243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32523 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:42:49 +00:00
Boone Gorges
5de66efda6
In sanitize_option()
, pass the unsanitized $value
to the filter.
...
Props simonwheatley, MikeHansenMe.
Fixes #26199 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32520 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 17:59:58 +00:00
Scott Taylor
6378cb5d60
In wpdb::load_col_info()
, don't fetch the number of fields in the result row on each iteration of the for
loop. It can be stored in a var and referenced.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32515 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:29:30 +00:00
Jeremy Felt
365c82b0c9
s/anbled/enabled/ in global_terms_enabled
filter documentation.
...
Fixes #32436 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32513 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 06:34:18 +00:00
Sergey Biryukov
09bd58b4c9
In comment_form()
, ensure that filtered arguments contain all required default values.
...
props boonebgorges.
fixes #32312 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@32511 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 01:03:39 +00:00
Sergey Biryukov
03e04a0c1c
Allow wp_dropdown_languages()
to return the markup instead of displaying.
...
props leewillis77, juliobox.
fixes #32432 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32510 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 00:32:10 +00:00
Helen Hou-Sandi
42eb2ec407
Autoprefixer for [32506]. see #31874 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32508 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 20:43:02 +00:00
Helen Hou-Sandi
691656f2cf
Media: Visually align upload errors with other admin notices.
...
props sagarjadhav.
fixes #31874 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32506 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 16:18:50 +00:00
Scott Taylor
11671ad73b
In tb_show()
in thickbox
, when loading content into #TB_ajaxContent
, make sure a URL with no ?
doesn't break when &random=
is appended to it.
...
Thickbox hasn't been updated since 2007, just FYI.
Fixes #31726 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32503 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 21:41:47 +00:00
Scott Taylor
23e40ef756
In views/button/select-mode-toggle
, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's toggleBulkEditHandler
method.
...
Props afercia.
Fixes #32324 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32502 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 21:26:22 +00:00
John Blackbourn
8bcd566ee0
Add a viewport meta tag to wp_die()
.
...
Props leogopal
Fixes #29336
git-svn-id: https://develop.svn.wordpress.org/trunk@32501 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 04:07:46 +00:00
Drew Jaynes
f927722bc0
Update the DocBlock for wp_new_comment()
to reference the wp_insert_comment()
documentation for argument information.
...
Fixes #31747 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32500 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 02:53:03 +00:00
Drew Jaynes
6855376930
Document the default arguments for wp_insert_comment()
as a hash notation.
...
Props lamosty, rachelbaker.
See #31747 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32499 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-13 02:50:56 +00:00
Boone Gorges
3a47da7943
Respect $_wp_suspend_cache_invalidation
in clean_term_cache()
.
...
Props tollmanz, rmccue.
Fixes #28743 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32498 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 20:13:53 +00:00
John Blackbourn
d01281af10
Add a sanity check to theme-compat/header.php
to avoid outputting CSS which could reference a non-existant file.
...
Props Mte90
Fixes 32240
git-svn-id: https://develop.svn.wordpress.org/trunk@32496 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 10:46:50 +00:00
Boone Gorges
1a8bd3bf07
In category dropdown, 'selected' should match against 'value_field'.
...
Props tlexcellent.
Fixes #32330 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32484 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-11 13:10:19 +00:00
John Blackbourn
39639c79da
Add a return value to wp_register_script()
and wp_register_style()
which matches the return value of WP_Dependencies::add()
.
...
Props katzwebdesign, pareshradadiya, DrewAPicture.
Fixes #31126
git-svn-id: https://develop.svn.wordpress.org/trunk@32483 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-10 19:56:15 +00:00
Andrew Ozz
099c066e24
Check if running from /src or SCRIPT_DEBUG is defined in print_emoji_detection_script()
.
...
See #32118 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32482 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-10 18:23:21 +00:00
Drew Jaynes
d9b911e477
Update the DocBlock description for update_option()
to account for the ability to define the $autoload
parameter, added in 4.2.
...
Props Clorith for the initial patch.
Fixes #32331 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32481 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-10 16:58:00 +00:00
Andrew Ozz
cdd007cc62
Emoji: do not try to replace emoji chars inside dynamic SVGs.
...
Fixes #32305 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@32478 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 23:43:07 +00:00
Dominik Schilling (ocean90)
cfa32bc1d7
Merge similar error strings for invalid data.
...
props pavelevap.
fixes #32329 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32477 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 21:08:57 +00:00
Dominik Schilling (ocean90)
ff4f261101
Merge similar error strings.
...
props pavelevap.
fixes #32327 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32471 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 18:26:37 +00:00
Scott Taylor
e7d9eda799
In fetch_feed()
, call ->set_output_encoding()
on the SimplePie
instance to ensure the feed is served with encoding specified by the blog_charset
option.
...
Props chriscct7.
Fixes #10713 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32469 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 06:48:45 +00:00
Scott Taylor
6ce6180884
Serve RSS feeds with the proper mime-type: application/rss+xml
. The reason for hacking around browsers by using text/xml
appears to no longer be relevant.
...
Props @chriscct7.
Reverts [11334] and [11358]
Fixes #15110 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32468 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 06:38:38 +00:00
Scott Taylor
5d69ee66dd
In media-template.php
, change a few <a href="#" class="button">
s to <button type="button" class="button" ...>
.
...
See #26550 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32467 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 06:06:50 +00:00
Scott Taylor
f9fd563ec7
Media Grid: clean up our flawed Backbone.Router
implementation so that the browser forward/back buttons work the same way as the left/right keys when the Edit Attachment frame is open.
...
Fixes #31846 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32466 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 05:41:01 +00:00
John Blackbourn
1b76bd6246
Introduce a $token
argument to wp_set_auth_cookie()
so session tokens can be reused by custom authentication implementations.
...
Props rmccue
Fixes 30247
git-svn-id: https://develop.svn.wordpress.org/trunk@32465 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 00:27:11 +00:00
Scott Taylor
8303e8f314
wp.media.view.Button
should create <button>
s, not <a href="#">
s.
...
Props afercia.
See #32236 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32464 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:38:55 +00:00
Scott Taylor
3fd2730435
In EmbedLink
, a URL needs to be at least 11 chars to be useful.
...
Fixes #32059 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32463 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:29:55 +00:00
Scott Taylor
bbcddbbb72
When creating an EmbedLink
view, don't add a spinner - it already exists in Embed
.
...
Use the value of `wp.media.controller.Embed.sensitivity` as the sensitivity value for the debounced method in `EmbedLink` to ensure that the spinner toggles don't stutter or overlap.
Fixes #32036 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32462 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:09:58 +00:00
Boone Gorges
637bedeece
Use table prefix for comment__in
and comment__not_in
SQL clauses of WP_Comment_Query
.
...
The prefix prevents ambiguity when joining against other tables.
Props willgladstone.
Fixes #32081 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32461 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 19:44:06 +00:00
Scott Taylor
c8ca3c2304
When fetching in media/views/embed/link.js
, call abort()
on any existing XHRs.
...
Use `$.ajax` instead of `wp.ajax.send()` to allow this.
Pass `this` as `context` to the options to remove the need to bind callbacks.
Fixes #32035 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32460 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 19:15:34 +00:00
Scott Taylor
c6592462ef
In media/views/embed/link.js
, URLs should have a valid protocol before an attempt to fetch them is made.
...
Fixes #32037 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32459 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 18:33:34 +00:00
Andrew Nacin
df717e8294
Add a comment to maybe_serialize().
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32458 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 16:26:13 +00:00
Gary Pendergast
231c73751b
On the Writing Options screen, hide the Balance Tags and Convert Smilies options on new installs.
...
Fixes #5161 .
Fixes #32298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32454 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 06:51:52 +00:00
Drew Jaynes
8cb8a90b7e
Fix a wide variety of syntactical, spacing, wording, and other issues in wp-includes/taxonomy.php.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32453 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 06:13:27 +00:00
Drew Jaynes
3ff997b3b6
Ensure the optional parameter in get_object_taxonomies()
is documented as such.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32452 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 05:32:29 +00:00
Drew Jaynes
2b62df22b3
Add a description to the hook documentation for the created_$taxonomy
action to clarify the dynamic portion of the hook name.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32451 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 05:27:36 +00:00
Drew Jaynes
97ac7fffa1
Add missing parameter descriptions to the created_term
hook documentation.
...
Props dlh.
Fixes #32276 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32450 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 05:25:30 +00:00
Sergey Biryukov
5af9ac0ea2
Customizer: Use a semantic, accessible element for Remove Header Image button.
...
Make the button more noticeable on dark, light, and busy images.
props afercia, RDall, melchoyce.
fixes #32227 , #31325 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32382 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 10:53:07 +00:00
Sergey Biryukov
2b8e7270d5
Multisite: Add translator comments to default email messages with non-typical placeholders.
...
props yoavf.
fixes #32263 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32381 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 09:11:18 +00:00
Gary Pendergast
ca11cafb07
Upgrades: When converting to utf8mb4
, we were trying to change the wrong index on wp_signups
, causing the conversion to later fail.
...
Props kovshenin, pento.
See #32099 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32378 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:33:53 +00:00
Gary Pendergast
ba24459a63
The UTF-8 regex can occasionally fail on very low memory machines. Reduce the amount of memory it uses.
...
See #32204 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32375 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 06:57:44 +00:00
Gary Pendergast
ed53ad2c53
WPDB: When sanity checking query character sets, there's no need to check queries that don't return user data.
...
See #32104 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32374 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 06:04:50 +00:00
Gary Pendergast
923c6c981b
WPDB: Allow queries to reference tables in the dbname.tablename
format, and allow table names to contain any valid character, rather than just ASCII.
...
Props pento, willstedt for the initial patch.
See #32090 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32368 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 05:00:39 +00:00
Andrew Ozz
8737968ac2
TinyMCE: update to 4.1.10.
...
Fixes #32262 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32366 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 03:22:04 +00:00