Commit Graph

40007 Commits

Author SHA1 Message Date
Sergey Biryukov
ce00f0b0f4 Twenty Fifteen: Make twentyfifteen_author_bio_template() use author templates if exist, fall back to regular template hierarchy otherwise.
See #32096.

git-svn-id: https://develop.svn.wordpress.org/trunk@45720 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-02 03:07:58 +00:00
Sergey Biryukov
35e070ca34 Twenty Thirteen: Prevent author-bio.php partial template from interfering with rendering an author archive of a user with the bio username.
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
Fixes #32096.

git-svn-id: https://develop.svn.wordpress.org/trunk@45719 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-02 02:32:58 +00:00
Sergey Biryukov
f6f0ac59dc Twenty Fifteen: Prevent author-bio.php partial template from interfering with rendering an author archive of a user with the bio username.
Props rclations, ianbelanger, lordlod, SergeyBiryukov.
See #32096.

git-svn-id: https://develop.svn.wordpress.org/trunk@45718 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-02 02:32:35 +00:00
Sergey Biryukov
6c78848612 Users: Clean user cache in check_password_reset_key() tests.
Props davidbaumwald, spacedmonkey.
See #45845.

git-svn-id: https://develop.svn.wordpress.org/trunk@45717 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 19:53:45 +00:00
Sergey Biryukov
eedb1193fc Users: Replace raw SQL query in check_password_reset_key() with get_user_by().
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845.

git-svn-id: https://develop.svn.wordpress.org/trunk@45716 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 19:18:28 +00:00
Sergey Biryukov
750a5c4749 Users: Use clean_user_cache() in wp_insert_user(), wp_update_user(), wp_set_password(), add_user_to_blog().
Props spacedmonkey.
Fixes #47021.

git-svn-id: https://develop.svn.wordpress.org/trunk@45715 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 17:48:31 +00:00
Sergey Biryukov
f912470ac3 Users: Use wp_update_user() in get_password_reset_key().
Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov.
Fixes #45746.

git-svn-id: https://develop.svn.wordpress.org/trunk@45714 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 17:24:20 +00:00
Sergey Biryukov
65254fdc3e Users: Reorganize user_nicename, user_url, user_registered setting in wp_insert_user() for consistency with the order or fields in the database.
See #45746.

git-svn-id: https://develop.svn.wordpress.org/trunk@45713 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 17:12:42 +00:00
SergeyBiryukov
1e0309b6e3 Users: Use get_password_reset_key() in wp_new_user_notification().
Props mrasharirfan, spacedmonkey.
Fixes #45745.

git-svn-id: https://develop.svn.wordpress.org/trunk@45712 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 15:29:02 +00:00
Sergey Biryukov
69aa6b52ba Taxonomy: Correct some strict comparisons after [45710].
See #47573.

git-svn-id: https://develop.svn.wordpress.org/trunk@45711 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 15:03:33 +00:00
Sergey Biryukov
bdcc896e2c Coding Standards: Use strict comparison in wp-includes/taxonomy.php.
Props andizer, SergeyBiryukov.
Fixes #47573.

git-svn-id: https://develop.svn.wordpress.org/trunk@45710 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 13:44:04 +00:00
Sergey Biryukov
209a72c35a Coding Standards: Fix WPCS violations after [45708].
See #45747.

git-svn-id: https://develop.svn.wordpress.org/trunk@45709 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 12:02:30 +00:00
Sergey Biryukov
03122ef7e1 Users: Deprecate update_user_status() in favor of wp_update_user().
Props spacedmonkey, SergeyBiryukov.
Fixes #45747.

git-svn-id: https://develop.svn.wordpress.org/trunk@45708 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 11:27:28 +00:00
Sergey Biryukov
1878f25e54 Database: Use a strict comparison for has_filter() check in wpdb::placeholder_escape().
The filter is added with a priority of `0`, so a loose comparison had an unintended effect of adding the filter on every call.

Props withinboredom.
Fixes #47430.

git-svn-id: https://develop.svn.wordpress.org/trunk@45707 602fd350-edb4-49c9-b593-d223f7449a82
2019-08-01 02:24:08 +00:00
K. Adam White
a875f9dae7 REST API: Skip processing fields which are not present in the selected context.
In `WP_REST_Controller::get_fields_for_response()`, exclude fields which are not registered to appear in the request's context.

In conjunction with r45705 this prevents the unnecessary computation of the sample permalink when making a request that is not context=edit.

Props dlh.
Fixes #45605.


git-svn-id: https://develop.svn.wordpress.org/trunk@45706 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-31 20:20:02 +00:00
K. Adam White
7aae0cfe56 REST API: Generate sample permalink only when a dependent field is requested.
The sample permalink will now only be generated if the derivative `permalink_template` or `generated_slug` fields are to be included in the response, preventing an unnecessary database request for each post (via `wp_unique_post_slug()`) when those fields are not requested.

Props dlh.
See #45605.


git-svn-id: https://develop.svn.wordpress.org/trunk@45705 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-31 19:59:30 +00:00
Sergey Biryukov
57443a60da Docs: Correct parameter documentation for bulk_edit_custom_box and quick_edit_custom_box actions.
Props abrain.
Fixes #47810.

git-svn-id: https://develop.svn.wordpress.org/trunk@45704 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-31 15:09:55 +00:00
Sergey Biryukov
a8a4c09f33 Docs: Correct parameter type and description for is_email filter.
Props jenkoian.
Fixes #47793.

git-svn-id: https://develop.svn.wordpress.org/trunk@45703 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-31 01:25:43 +00:00
Sergey Biryukov
288681a0b1 Docs: Correct @return value description for get_term_link().
Props garrett-eclipse.
Fixes #47806.

git-svn-id: https://develop.svn.wordpress.org/trunk@45702 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-31 01:18:23 +00:00
Tammie Lister
c83f0b0d22 Media: Reduces the bulk media options to have one primary button
This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov
Fixes #46757, #46758


git-svn-id: https://develop.svn.wordpress.org/trunk@45701 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-30 23:19:18 +00:00
Tammie Lister
2f52d5a897 Admin: Improve Dashboard icon contrast.
The icons used across the dashboard had too low contrast to pass AA WCAG guidelines. They’re now slightly darker for better contrast.

Props @melchoyce, @SergeyBiryukov, @chetan200891 , @kjellr 
Fixes #46935


git-svn-id: https://develop.svn.wordpress.org/trunk@45700 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-30 22:53:19 +00:00
Sergey Biryukov
da0f9cd6fb Rewrite Rules: Check if $wp_rewrite->flush_rules() is callable before calling it in flush_rewrite_rules().
Props bsetiawan88, markjaquith.
Fixes #47087.

git-svn-id: https://develop.svn.wordpress.org/trunk@45699 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 17:51:34 +00:00
Sergey Biryukov
aee18a2e09 Users: Use case-insensitive email address comparison when checking whether "Grant this user super admin privileges" checkbox should be displayed on Edit User screen.
Props trepmal.
Fixes #47119.

git-svn-id: https://develop.svn.wordpress.org/trunk@45698 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 17:41:23 +00:00
Sergey Biryukov
4dbc842cac Coding Standards: Fix WPCS violations in wp-admin/includes/class-walker-nav-menu-edit.php.
Props sudhiryadav, audrasjb.
Fixes #46902.

git-svn-id: https://develop.svn.wordpress.org/trunk@45697 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 16:51:46 +00:00
Sergey Biryukov
4eabbd6949 Coding Standards: Fix WPCS violations in [45694].
See #47466.

git-svn-id: https://develop.svn.wordpress.org/trunk@45696 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 16:51:26 +00:00
Sergey Biryukov
f793983deb Docs: Improve the DocBlocks for got_mod_rewrite(), extract_from_markers(), insert_with_markers().
See #47110.

git-svn-id: https://develop.svn.wordpress.org/trunk@45695 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 16:34:58 +00:00
Sergey Biryukov
d7ec5b4ac0 Rewrite Rules: Add a comment to # BEGIN/END .htaccess markers to clarify that the directives are dynamically generated, and should only be modified via WordPress filters.
Introduce `insert_with_markers_inline_instructions` filter to modify the default instructions text.

Props bradleyt, SergeyBiryukov.
Fixes #47466.

git-svn-id: https://develop.svn.wordpress.org/trunk@45694 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 16:30:46 +00:00
Sergey Biryukov
806d151880 Permalinks: Improve appearance of URL examples on Permalink Settings screen.
Props luan-ramos, sarath.ar.
Fixes #41559.

git-svn-id: https://develop.svn.wordpress.org/trunk@45693 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 16:10:35 +00:00
Sergey Biryukov
5c6b35c81e Administration: Allow breaking long strings in <code> tags at any point, to avoid overflowing on mobile.
Props david.binda, mukesh27.
Fixes #47329.

git-svn-id: https://develop.svn.wordpress.org/trunk@45692 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 16:08:47 +00:00
Sergey Biryukov
df874c9858 Site Health: Consistently use wpdb::db_version() for checking the database server version, instead of partically replicating its functionality.
Props Clorith, wpfed.
Fixes #47738.

git-svn-id: https://develop.svn.wordpress.org/trunk@45691 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-28 14:54:06 +00:00
Dominik Schilling
3df5f2a3d7 I18N: Display the logged out message in the user's locale
git-svn-id: https://develop.svn.wordpress.org/trunk@45690 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-27 14:30:19 +00:00
Dominik Schilling
41dc7c7365 I18N: Following [45688], remove test for removed method.
See #44865.

git-svn-id: https://develop.svn.wordpress.org/trunk@45689 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-27 14:29:28 +00:00
Dominik Schilling
350332019e I18N: Use RTL stylesheets when running from /src.
To run WordPress from /src you have to use the `--dev` flag which also builds the RTL stylesheets thus the admin notice and force to LTR is no longer required.

See #44492.
Fixes #44865.

git-svn-id: https://develop.svn.wordpress.org/trunk@45688 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-27 14:16:59 +00:00
Dominik Schilling
3ea5731049 REST API: Pass current request object to rest_authentication_errors filter in WP_REST_Server::check_authentication().
Fixes #46907.

git-svn-id: https://develop.svn.wordpress.org/trunk@45687 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-27 13:43:41 +00:00
Dominik Schilling
2f1afbcf79 Tools: Remove internationalization tools (also known as makepot.php).
It has been a great pleasure to work with `makepot.php` over the past [https://i18n.trac.wordpress.org/changeset/4169/ 11 years] but now it's time to say goodbye.
The tools have been integrated into WP-CLI as [https://developer.wordpress.org/cli/commands/i18n/make-pot/ wp i18n make-pot] and [https://developer.wordpress.org/cli/commands/i18n/make-json/ wp i18n make-json]. The new commands were optimized to support current PHP versions and are more flexible and reliable when extracting strings for PHP, and JavaScript.

Access to the old tools continue to exist in previous branches or at https://i18n.svn.wordpress.org/tools/.

Fixes #45287.

git-svn-id: https://develop.svn.wordpress.org/trunk@45686 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-27 13:09:16 +00:00
Dominik Schilling
84b977945c I18N: Add support for custom WP_PLUGIN_URL in load_script_textdomain().
Plugins may not be on the same host/path as the rest of the content. To support loading translations for this setup check if the script source matches `plugins_url()`.
Also fixes an undefined index notice when a custom content URL has no path.

Props odminstudios, ocean90.
Fixes #46336, #46387.

git-svn-id: https://develop.svn.wordpress.org/trunk@45685 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-27 12:43:56 +00:00
Sergey Biryukov
160fc055da Accessibility: Toolbar: Make the min-width value for #wpadminbar at 782px breakpoint consistent with that of <body>.
This ensures that the "My Account" toolbar item stays visible at high zoom levels.

Props isabel_brison, chetan200891.
Fixes #47603.

git-svn-id: https://develop.svn.wordpress.org/trunk@45684 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-26 22:03:31 +00:00
Sergey Biryukov
5618dfc6d3 Accessibility: Taxonomy: When a new category or tag is being added, show a spinner and noop the button to avoid multiple requests.
Props andg, afercia, guddu1315, SergeyBiryukov.
Fixes #47607.

git-svn-id: https://develop.svn.wordpress.org/trunk@45683 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-26 17:45:21 +00:00
Sergey Biryukov
7493196625 Administration: Merge CSS rules for #adminmenu .wp-submenu a in one place.
Props ozmatflc, AkSDvP.
Fixes #47780.

git-svn-id: https://develop.svn.wordpress.org/trunk@45682 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-26 13:48:52 +00:00
Sergey Biryukov
455cc051fc REST API: Make "Could not update meta value in database" error messages more helpful.
Props apermo, AkSDvP.
Fixes #46252.

git-svn-id: https://develop.svn.wordpress.org/trunk@45681 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-26 13:19:44 +00:00
Sergey Biryukov
230960f8c0 Site Health: Show parent theme in its own accordion on Site Health Info screen; rename "Other Themes" to "Inactive Themes".
Props garrett-eclipse, mukesh27, Clorith, xkon, msaggiorato.
Fixes #46925.

git-svn-id: https://develop.svn.wordpress.org/trunk@45680 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-26 03:48:32 +00:00
Sergey Biryukov
d18b725f75 Coding Standards: Fix newlines in wp-includes/date.php.
See #47775.

git-svn-id: https://develop.svn.wordpress.org/trunk@45679 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-26 00:11:37 +00:00
Sergey Biryukov
0eaaf84419 Coding Standards: Move wp-includes/date.php to wp-includes/class-wp-date-query.php.
This renames the file containing the `WP_Date_Query` class to conform to the coding standards.

This commit also includes:

- A new `date.php` that includes the new file, for anyone that may've been including the file directly.
- Replaces references to the old filename with the new filename.

Fixes #47775. See #47632.

git-svn-id: https://develop.svn.wordpress.org/trunk@45678 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 23:30:21 +00:00
Sergey Biryukov
48120a1395 I18N: Update translator comment missed in [45676].
See #47771.

git-svn-id: https://develop.svn.wordpress.org/trunk@45677 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 22:55:36 +00:00
Sergey Biryukov
004ff0e1a7 I18N: Update translator comments after [45674].
See #47771.

git-svn-id: https://develop.svn.wordpress.org/trunk@45676 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 22:51:53 +00:00
Sergey Biryukov
5b86d712f4 Bundled Themes: Replace Codex URLs with a corresponding HelpHub or DevHub article.
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.

git-svn-id: https://develop.svn.wordpress.org/trunk@45675 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 22:45:48 +00:00
Sergey Biryukov
ae8a620efb General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article.
Props ianbelanger, tobifjellner, SergeyBiryukov.
See #47771.

git-svn-id: https://develop.svn.wordpress.org/trunk@45674 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 22:44:48 +00:00
Sergey Biryukov
77a1f39484 Upgrade/Install: Bring some consistency to installation screen styles.
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.

Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes #35776, #47757, #47758.

git-svn-id: https://develop.svn.wordpress.org/trunk@45673 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 19:10:33 +00:00
Sergey Biryukov
f00229ac0e Docs: Clarify that is_network_admin() does not check if the site is a Multisite network; is_multisite() should be used for that.
Props svovaf, dilipbheda, tazotodua.
Fixes #47415.

git-svn-id: https://develop.svn.wordpress.org/trunk@45672 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 15:18:05 +00:00
Sergey Biryukov
128597b69a Posts, Post Types: Introduce is_sticky filter in is_sticky() to provide more flexibility for custom sticky post implementations.
Props dehisok, greenshady.
Fixes #37629.

git-svn-id: https://develop.svn.wordpress.org/trunk@45671 602fd350-edb4-49c9-b593-d223f7449a82
2019-07-25 01:35:52 +00:00