Commit Graph

1867 Commits

Author SHA1 Message Date
Dion Hulse
10c377b9b9 Decrease the chances that wp_tempnam() will conflict with an existing file by suffixing a random ID to the generated filename.
This also switches from using `touch()` to using `fopen( $file, 'x')` to ensure that we're the process creating the file.

Fixes #34562


git-svn-id: https://develop.svn.wordpress.org/trunk@35644 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 05:32:32 +00:00
Dion Hulse
7be4ad61ca Upgrader: Pass the $args['hook_extra'] context to the upgrader_source_selection filter.
Props afragen
Fixes #34696


git-svn-id: https://develop.svn.wordpress.org/trunk@35642 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-16 02:46:43 +00:00
Dominik Schilling (ocean90)
0792eaf237 Schema: Increase length of user_pass and user_activation_key fields to 255.
Props grvrulz and Miglosh for testing.
Fixes #33904.

git-svn-id: https://develop.svn.wordpress.org/trunk@35638 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-15 14:18:51 +00:00
Helen Hou-Sandi
6f1bb2ab67 Buttons: Standardize on .button-link for link-like buttons.
This serves as both a reset and some basic styling. The class name also aligns with parallel components in other popular projects.

props paulwilde for the initial patch.
fixes #34242.


git-svn-id: https://develop.svn.wordpress.org/trunk@35636 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-13 15:46:12 +00:00
Sergey Biryukov
05df76ff7b Cast 'illegal_user_logins' filter result to array.
See #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35630 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-12 16:33:48 +00:00
Sergey Biryukov
0cff629050 Users: After [35189], make 'illegal_user_logins' check case-insensitive.
Props juliobox.
Fixes #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35629 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-12 16:29:45 +00:00
Scott Taylor
b1d93d6d6a List Tables: after [34271], account for searches when calculating pagination.
Fixes #29870.



git-svn-id: https://develop.svn.wordpress.org/trunk@35622 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-11 23:13:46 +00:00
Dominik Schilling (ocean90)
4f837ef5b6 Upgrade: Revert [34543] because of incomplete and incorrect functionality.
See #33932.
Fixes #34434.

git-svn-id: https://develop.svn.wordpress.org/trunk@35619 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-11 22:45:44 +00:00
Sergey Biryukov
de44d6b375 Remove non-translatable HTML code from the first post content in populate_network() and wp_install_defaults().
Add translator comment.

Props ramiy.
Fixes #34619.

git-svn-id: https://develop.svn.wordpress.org/trunk@35614 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-11 20:54:20 +00:00
Andrea Fercia
5310c447b8 Accessibility: Improve form labels and descriptions for the Tags meta box in the Edit Post screen.
Fixes #34627.

git-svn-id: https://develop.svn.wordpress.org/trunk@35609 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-11 15:23:10 +00:00
Andrea Fercia
80569cc816 Accessibility: improvements for the taxonomies Quick Edit form.
Changes the "Cancel" and "Update" controls in buttons for better semantics and
accessibility. On cancel and successful saving, moves focus back to the term title
to avoid a focus loss. Dispatches error and success messages to `wp.a11y.speak`
to give assistive technologies users an audible feedback.

Patch prepared at #wpcdit, first Italian WordPress Contributor Day.

Props garusky, chiara_09.
Fixes #34613.

git-svn-id: https://develop.svn.wordpress.org/trunk@35605 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-11 00:23:15 +00:00
Dion Hulse
13000b7036 Fix a typo in a docblock
git-svn-id: https://develop.svn.wordpress.org/trunk@35586 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-09 03:37:08 +00:00
Dion Hulse
94ed2c31ba Upgrade: Force disable the rest-api plugin on upgrade to 4.4 unless it's beta5+. Previous versions of the plugin were not configured correctly to gradefully degrade during update which would cause fatal errors.
Props wonderboymusic.
Fixes #34415


git-svn-id: https://develop.svn.wordpress.org/trunk@35582 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-09 01:21:29 +00:00
Dion Hulse
28ab6b9578 Media: Allow media_sideload_image() to work when the upload directory is a PHP Stream. Using copy() instead of rename() allows the function to work across different stream sources.
Props mattheu.
Fixes #29257


git-svn-id: https://develop.svn.wordpress.org/trunk@35579 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-09 00:44:01 +00:00
Jeremy Felt
21de649fd0 MS: Allow "Network Admin Email" to be a non-user during network setup.
The network admin email setting for a network is often used as a catch-all or notification email separate from the actual user ID set as the owner of the new network. If a non-user email address is set during network installation, we can defer to the current user as the actual network admin and apply the entered email as the address to which general notifications are sent and emails are sent from.

In the future, we'll want to update the messaging around "Network Admin Email" to reflect its reality. See #34293.

Props jjeaton.
Fixes #34065.


git-svn-id: https://develop.svn.wordpress.org/trunk@35575 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-08 03:15:07 +00:00
Scott Taylor
7301c115aa Accessibility: add missing alt attributes to a gaggle of <img>s.
Props afercia.
Fixes #34583.


git-svn-id: https://develop.svn.wordpress.org/trunk@35567 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-07 16:11:38 +00:00
Scott Taylor
de02c5d2cd List Tables: to ensure that get_primary_column_name() can match columns that were added via the "manage_{$screen->id}_columns" filer, call get_column_headers() instead of $this->get_columns().
List Table classes and `WP_Screen` are already tangled together. The parent list table constructor adds a filter that is called by a function that references the instance globally, even though we have access to it via composition directly in the class that is adding the filter. So the fact that functions here have to be called that reference a screen instance we already have access to is what one might call... less than elegant.

#OOP

Props SergeyBiryukov.
Fixes #34508.


git-svn-id: https://develop.svn.wordpress.org/trunk@35565 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-07 15:26:05 +00:00
Sergey Biryukov
5e614a08f8 Media: Avoid a PHP warning in wp_generate_attachment_metadata() if $metadata is not an array.
This was previously fixed in [25968], but accidentally reverted in [32545].

Props skithund.
Fixes #34599.

git-svn-id: https://develop.svn.wordpress.org/trunk@35554 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-06 09:24:36 +00:00
Sergey Biryukov
251915c11f Remove <code> tags from translatable strings in wp-admin/includes/network.php.
Add translator comments.

Props ramiy.
Fixes #34598.

git-svn-id: https://develop.svn.wordpress.org/trunk@35552 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-06 00:59:01 +00:00
Sergey Biryukov
f75a2b113e Remove <code> tags from translatable strings in wp-admin/includes/class-wp-upgrader.php.
Add translator comments.

Props ramiy.
Fixes #34580.

git-svn-id: https://develop.svn.wordpress.org/trunk@35551 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-06 00:40:09 +00:00
Sergey Biryukov
1631a99336 Themes: Add a Favorites tab to the Add Themes screen.
You can now browse and install your wordpress.org theme favorites from the theme installer, just like with plugins.

Props swissspidy.
Fixes #34206.

git-svn-id: https://develop.svn.wordpress.org/trunk@35527 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:48:43 +00:00
Dominik Schilling (ocean90)
5ee5029109 List Tables: Define the global $mode variable for Quick Edit savings.
Also remove two unused global imports for `$mode`.

Fixes #34577.

git-svn-id: https://develop.svn.wordpress.org/trunk@35518 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:28:55 +00:00
Scott Taylor
48501d6658 Roles: map add_users cap to promote_users and remove it.
"Never used, will be removed." - The Ghost of 3.5 Nacin

Props Craig Ralston, renoirb.
Fixes #16719.


git-svn-id: https://develop.svn.wordpress.org/trunk@35507 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 17:53:40 +00:00
SergeyBiryukov
059eb46ddd Menus: After [35450], use correct IDs in $initial_meta_boxes.
Props swissspidy.
Fixes #33925.

git-svn-id: https://develop.svn.wordpress.org/trunk@35502 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 10:55:01 +00:00
DrewAPicture
d49c379d18 Docs: Fix two notations for the $_wp_real_parent_file global, which is an array.
Props NExt-Season.
Fixes #34443.


git-svn-id: https://develop.svn.wordpress.org/trunk@35495 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 20:12:02 +00:00
Andrea Fercia
29f271da44 Media: Improve form fields labels association in the Edit Media screen.
Fixes #34548.

git-svn-id: https://develop.svn.wordpress.org/trunk@35493 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 16:01:11 +00:00
Drew Jaynes
d464e70d9c Docs: Document use of the $comment_status global in the DocBlock for WP_Comments_List_Table::handle_row_actions().
Props shimakyohsuke.
Fixes #34425.


git-svn-id: https://develop.svn.wordpress.org/trunk@35490 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-02 21:32:14 +00:00
Sergey Biryukov
ae68fbfcee Docs: After [32654], remove duplicate @param tag in WP_List_Table::set_pagination_args() DocBlock.
Add `@since` tag.

Props bobbingwide.
See #32444.

git-svn-id: https://develop.svn.wordpress.org/trunk@35489 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-02 21:02:29 +00:00
Gary Pendergast
c9f7e05f7b Upgrades: Add support for FULLTEXT indexes to dbDelta().
Props edirect24, mdawaffe, pento.

Fixes #14445.



git-svn-id: https://develop.svn.wordpress.org/trunk@35487 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 23:09:49 +00:00
Sergey Biryukov
bce985a5d7 Docs: Correct $post parameter description for display_post_states filter.
Props grapplerulrich.
Fixes #34541.

git-svn-id: https://develop.svn.wordpress.org/trunk@35484 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 14:05:42 +00:00
Weston Ruter
204bad4685 Customize: Return user to referring URL when leaving Customizer in absence of return query param.
When referring URL is not available, default returning user to frontend URL instead of admin URL. Themes page is updated to include the `return` path in Customizer links.

Props McGuive7, westonruter.
Fixes #32637.


git-svn-id: https://develop.svn.wordpress.org/trunk@35483 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 06:39:50 +00:00
Sergey Biryukov
ca898ccbdb Post List Table: Hierarchical post types should not default to sorting by date.
Regression introduced in [34728].

Props ellie.roepken.
Fixes #34473. See #25493.

git-svn-id: https://develop.svn.wordpress.org/trunk@35482 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 00:48:36 +00:00
Scott Taylor
bd7bf83886 Media: add a new image size, medium_large. Bumps db version to add new options.
Adds unit tests.

Props DH-Shredder, joemcgill, azaozz.
Fixes #34196.


git-svn-id: https://develop.svn.wordpress.org/trunk@35479 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:49:26 +00:00
Scott Taylor
aa616b1b45 Admin Menu: allow more than one menu item to be added at the same priority/position.
Props chriscct7.
Fixes #23316.


git-svn-id: https://develop.svn.wordpress.org/trunk@35477 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:30:06 +00:00
Scott Taylor
df134d1763 Filesystem: in WP_Filesystem_FTPext::parselisting(), check for the existence of $b['islink'] before using it.
Props jesin.
Fixes #27975.


git-svn-id: https://develop.svn.wordpress.org/trunk@35476 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:16:32 +00:00
Drew Jaynes
37145d5b88 Docs: Use 3-digit, x.x.x-style semantic versioning in the DocBlocks for post_form_autocomplete_off() and WP_Filesystem_SSH2::sftp_path().
Props aaronrutley.
Fixes #34518.


git-svn-id: https://develop.svn.wordpress.org/trunk@35468 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 13:15:01 +00:00
Helen Hou-Sandi
a701118676 View mode is only a screen option for posts lists.
see #22222.


git-svn-id: https://develop.svn.wordpress.org/trunk@35461 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 21:02:35 +00:00
Andrea Fercia
2b54d3143b Accessibility: Bump the Settings API sections heading one level up.
Also, fix a typo in the `do_settings_sections()` DocBlock.

Props neoxx.
Fixes #34492.

git-svn-id: https://develop.svn.wordpress.org/trunk@35459 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 15:29:31 +00:00
Drew Jaynes
a18f309761 Menus: Prevent display conflicts in the screen options for Menus when a post type and taxonomy share the same slug.
Prior to this change, both taxonomies and post types added meta boxes to the Menus UI (which in-turn registered screen options) using the same ID formula: `add-{$id}`. This caused a conflict between the two elements, resulting in the rendering of a screen option for only the taxonomy or post type but not both. Moving to a new meta box ID for post types, `add-post-type-{$id}`, removes that conflict.

Note: This change in meta box IDs for post types effectively resets current user settings for the visibility of post types in the Menus UI.

Fixes #33925.


git-svn-id: https://develop.svn.wordpress.org/trunk@35450 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 05:46:53 +00:00
Sergey Biryukov
bb045e4e3c Replace a second instance of <code> in translatable string left in [35440].
Props ramiy.
See #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35445 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:55:49 +00:00
Sergey Biryukov
dfd5f4c188 Don't use <strong> in translatable string in wp-admin/includes/nav-menu.php.
Add translator commment.

Props ramiy.
Fixes #34500.

git-svn-id: https://develop.svn.wordpress.org/trunk@35444 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:36:53 +00:00
Sergey Biryukov
4c7f6dfad3 Don't use <a> in translatable strings in `wp-admin/includes/dashboard.php'.
Add translator commments.

Props ramiy.
Fixes #34501.

git-svn-id: https://develop.svn.wordpress.org/trunk@35443 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:32:17 +00:00
Sergey Biryukov
aee4a4e278 Don't use <strong> in translatable string in wp-admin/includes/nav-menu.php.
Add translator commment.

Props ramiy.
Fixes #34500.

git-svn-id: https://develop.svn.wordpress.org/trunk@35442 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:16:39 +00:00
Sergey Biryukov
9e8e68f001 Add <code> tag missed in [35440].
See #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35441 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:11:53 +00:00
Sergey Biryukov
540e4b5edd Don't use <code> in translatable strings in wp-admin/includes/class-wp-plugins-list-table.php.
Add translator commments.

Props ramiy.
Fixes #34498.

git-svn-id: https://develop.svn.wordpress.org/trunk@35440 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 01:07:11 +00:00
Sergey Biryukov
d21d397d49 Don't use <code> in translatable string in wp-admin/includes/media.php.
Add translator commment.

Props ramiy.
Fixes #34499.

git-svn-id: https://develop.svn.wordpress.org/trunk@35439 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-30 00:57:22 +00:00
Andrea Fercia
347b0bf108 Media: Improve the headings hierarchy in the Media Views for better accessibility.
Fixes #34273.

git-svn-id: https://develop.svn.wordpress.org/trunk@35427 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 23:07:08 +00:00
Scott Taylor
ad471ac474 Admin Menu: after [34861], prevent adjacent separators.
Props johnjamesjacoby.
Fixes #24104.


git-svn-id: https://develop.svn.wordpress.org/trunk@35416 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 18:05:05 +00:00
Scott Taylor
83f90bf851 Dashboard: make tags used for headings more semantic.
Props Cheffheid, afercia.
Fixes #33558.


git-svn-id: https://develop.svn.wordpress.org/trunk@35414 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-28 17:56:22 +00:00
Drew Jaynes
1353016c4f Docs: Standardize the file header for wp-admin/includes/ms-deprecated.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35407 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-27 20:07:45 +00:00
Drew Jaynes
c1db6a9a56 Docs: Add a @subpackage tag to the file header for wp-admin/includes/ms-admin-filters.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35403 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-26 18:05:52 +00:00
Drew Jaynes
62b00c70cc Docs: Add a version to the file header for wp-admin/includes/revision.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35387 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 18:28:10 +00:00
Scott Taylor
a18feed6bd Nav Menus: show custom post type Archive item at the top of the View All tab for the post type on the legacy Nav Menu screen.
Props aaroncampbell, DrewAPicture, seanchayes, hlashbrooke, paulwilde, ericlewis, raulillana
See #16075.


git-svn-id: https://develop.svn.wordpress.org/trunk@35382 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-24 17:45:11 +00:00
Sergey Biryukov
d842c03e02 Docs: Correct the type and description of $post parameter passed to the attachment_fields_to_save filter.
Props swissspidy.
Fixes #34404.

git-svn-id: https://develop.svn.wordpress.org/trunk@35374 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 13:00:11 +00:00
Sergey Biryukov
bcb1e8eda2 Docs: Use consistent naming and capitalization of menu names in add_submenu_page() wrappers.
Props atomicjack, Mckilem.
Fixes #34360.

git-svn-id: https://develop.svn.wordpress.org/trunk@35373 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 12:01:11 +00:00
dd32
f935d4c26b Updates: Add a generic failure case to the ajax update endpoint for when the WP_Error value hasn't been found.
See #34403


git-svn-id: https://develop.svn.wordpress.org/trunk@35371 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 07:34:02 +00:00
Dion Hulse
743fe671f1 Comments: Use a full URL rather than a relative one for links which can contain IPv6 addresses to avoid an issue where the URL was being eaten by escaping functions.
See #34407, #34202
Fixes #34054


git-svn-id: https://develop.svn.wordpress.org/trunk@35368 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-23 05:13:27 +00:00
Scott Taylor
c6354d6bfd Plugins: after [35151], set default $restrict_network_* values to prevent notices.
Props johnjamesjacoby.
Fixes #20104.


git-svn-id: https://develop.svn.wordpress.org/trunk@35361 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:55:30 +00:00
Scott Taylor
9aba8ef2aa Options: remove old 'gzipcompression' and 'advanced_edit' options.
Props chriscct7, solarissmoke.
Fixes #12996.


git-svn-id: https://develop.svn.wordpress.org/trunk@35360 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:48:38 +00:00
Drew Jaynes
68c5efb7f3 Docs: Add a proper file header to wp-admin/includes/continents-cities.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35359 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:42:23 +00:00
Helen Hou-Sandi
7adf6e9125 List tables: Move the view mode switcher into screen options for posts.
Having a view mode switcher nestled within table navigation makes no sense, especially now that it's a sticky user option. While less convenient for frequent switching, there is no evidence as of yet that there is a large userbase of frequent view mode switchers.

Introduces a filter for `view_mode_post_types`, which by default is all hierarchical post types with edit UI on.

props Oxymoron.
fixes #22222.


git-svn-id: https://develop.svn.wordpress.org/trunk@35357 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-22 19:24:10 +00:00
Dominik Schilling (ocean90)
05356ff7dc Options: Hide the week starts on setting for installs that have the default setting already.
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].

Props swissspidy, ocean90.
Fixes #28344.

git-svn-id: https://develop.svn.wordpress.org/trunk@35337 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 17:38:44 +00:00
Boone Gorges
e4b72ad5ca Don't force comment pagination.
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@35331 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 16:25:31 +00:00
Dominik Schilling (ocean90)
9a1b5f93cd List Tables: Replace the hyphen separator for titles and post/media states with a &mdash;.
Props McGuive7.
Fixes #23230.

git-svn-id: https://develop.svn.wordpress.org/trunk@35326 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:32:02 +00:00
Drew Jaynes
a28e35e462 Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES constants in [35286], use them in various places in core.
Props sudar.
Fixes #22405.


git-svn-id: https://develop.svn.wordpress.org/trunk@35325 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 14:02:59 +00:00
Andrew Ozz
7ba408c93e Widgets: add a button to delete all inactive widgets simultaneously for better UX.
Props cdog.
Fixes #19159.

git-svn-id: https://develop.svn.wordpress.org/trunk@35317 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 05:22:52 +00:00
Scott Taylor
6f6c0ebb52 Plugins/Updates: in request_filesystem_credentials(), alter the heading HTML tag based on the current screen for improved semantics.
Props afercia.
Fixes #34267.


git-svn-id: https://develop.svn.wordpress.org/trunk@35315 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:50:19 +00:00
Scott Taylor
51637379a2 Formatting: move url_shorten() from wp-admin/includes/misc.php to wp-includes/formatting.php for more global access.
Adds unit tests.

Props mulvane, chriscct7.
Fixes #20166.


git-svn-id: https://develop.svn.wordpress.org/trunk@35314 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:47:23 +00:00
Scott Taylor
e4bcddecfb Site Icon: make the default value for the site_icon option 0 in schema.php.
Props swissspidy, sebastian.pisula.
Fixes #34339.


git-svn-id: https://develop.svn.wordpress.org/trunk@35312 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-21 03:27:54 +00:00
Konstantin Obenland
e9579b3ed5 Site Icon: Get site icon ID only when needed.
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].

Props ap.koponen, swissspidy.
Fixes #34368.



git-svn-id: https://develop.svn.wordpress.org/trunk@35299 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 18:22:41 +00:00
Scott Taylor
eb6bdb59cd Dashboard: use the create_posts cap on the post type object when determining if the Quick Press widget can be displayed.
Props jim912, ocean90, chriscct7.
Fixes #25681.


git-svn-id: https://develop.svn.wordpress.org/trunk@35282 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 05:48:11 +00:00
Scott Taylor
089276d5e8 List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns).
See #31634.


git-svn-id: https://develop.svn.wordpress.org/trunk@35277 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-20 04:28:05 +00:00
Drew Jaynes
900810e508 Docs: Add a missing file header for wp-admin/includes/class-wp-site-icon.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35271 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 20:08:34 +00:00
Dion Hulse
063d42a801 In insert_with_markers() restore the 4.3 behaviour of creating the file if it doesn't exist.
This change also makes it bail early (without writing) if the markers content is the same as the existing, and uses `ftell()` rather than `$bytes` for the location to truncate the file to - based on the file pointer being at the end of the written stream.

Props willmot tigertech kevinatelement
See #31767


git-svn-id: https://develop.svn.wordpress.org/trunk@35267 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-19 00:52:08 +00:00
Drew Jaynes
84d3e1f305 Administration: Introduce the manage_posts_extra_tablenav action, which fires inside the tablenav for the posts list table, and just outside the "actions" container.
Props hlashbrooke, wonderboymusic.
Fixes #30341.


git-svn-id: https://develop.svn.wordpress.org/trunk@35263 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 14:55:52 +00:00
Drew Jaynes
cb2bc30252 Docs: Add a version to the file header for wp-admin/includes/comment.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35262 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-18 14:33:31 +00:00
Drew Jaynes
5a0fd03f95 Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35241 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 15:12:48 +00:00
Drew Jaynes
cba5390270 Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35237 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 06:06:59 +00:00
Sergey Biryukov
5c19a7a704 Replace Quick Edit and Bulk Edit headings with <legend> elements.
Props afercia.
Fixes #34289.

git-svn-id: https://develop.svn.wordpress.org/trunk@35234 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:44:12 +00:00
Sergey Biryukov
fe72320f33 Merge two strings for expanding accordion and Customizer sections.
Props pavelevap.
Fixes #33939.

git-svn-id: https://develop.svn.wordpress.org/trunk@35232 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-17 00:27:44 +00:00
Sergey Biryukov
af36c261e3 Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
Props afercia.
Fixes #34255.

git-svn-id: https://develop.svn.wordpress.org/trunk@35229 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 23:01:58 +00:00
Sergey Biryukov
0d4a7ee029 In WP_Posts_List_Table, correct the type for $comment_pending_count.
See #11381.

git-svn-id: https://develop.svn.wordpress.org/trunk@35223 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 18:24:25 +00:00
Sergey Biryukov
e4c9f97fb3 In WP_Media_List_Table, rename $pending_count to $comment_pending_count and mark it as protected, for consistency with WP_Posts_List_Table.
See #11381.

git-svn-id: https://develop.svn.wordpress.org/trunk@35222 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 18:22:12 +00:00
Drew Jaynes
ea8e9f89cd Docs: Standardize the file header summary for wp-admin/includes/file.php.
Also adds an `@since` version and corrects the `@subpackage` value.

See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35221 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 16:55:24 +00:00
Andrea Fercia
e68dfb6c6b Bump H4 headings to H2 in the Updates screen for better accessibility.
Fixes #34265.

git-svn-id: https://develop.svn.wordpress.org/trunk@35219 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-16 15:44:49 +00:00
Drew Jaynes
ebd20119ec Docs: Walker_Nav_Menu_Checklist and Walker_Nav_Menu_Edit are part of the Navigation Menu API, but intended for use in the scope of administration.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35202 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 17:25:11 +00:00
Sergey Biryukov
3d7aa47df8 Remove a one-time variable from edit_user() added in [35189].
See #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35190 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:45:50 +00:00
Sergey Biryukov
e675e2ccf0 Users: Add 'illegal_user_logins' filter to allow certain usernames to be blacklisted.
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317.

git-svn-id: https://develop.svn.wordpress.org/trunk@35189 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 05:42:05 +00:00
Helen Hou-Sandi
61ef1ff96f Make some primary action buttons look primary.
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35182 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-15 03:07:48 +00:00
Drew Jaynes
0cb7c0bd9f Docs: Add missing descriptions for the $wpdb global in DocBlocks all the places.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35170 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 23:43:10 +00:00
Drew Jaynes
68a3c0cc73 Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php.
Also adds some missing parameter, return, and global descriptions, and one missing summary.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35169 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 23:24:46 +00:00
Drew Jaynes
c163beb1db Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php.
See #33701.

[ci skip]


git-svn-id: https://develop.svn.wordpress.org/trunk@35168 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:48:24 +00:00
Drew Jaynes
e8a1b5dcdb Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35167 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:34:55 +00:00
Drew Jaynes
a845610bc6 Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php.
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@35166 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 22:31:55 +00:00
Helen Hou-Sandi
c98ac461a9 Screen options: Improve the "Apply" button
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.

Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.

fixes #34295. see #22222, #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35161 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-14 18:57:16 +00:00
John Blackbourn
b5c3abcdfa Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite.
These plugins are only shown to users with the `manage_network_plugins` capability, which is Super Admins by default. This new feature lowers the blood pressure of Super Admins who may browse or search the Plugins listing screen of an individual site, having forgotten that a particular plugin is network-active. Showing inactive network-only plugins here also reduces friction when searching the Plugins listing screen on individual sites.

This change introduces a `show_network_active_plugins` filter which controls whether the network-active plugins and inactive network-only plugins are shown. This can be used to enable this functionality for regular site admininstrators, or, indeed, to disable this functionality for Super Admins.

Fixes #20104


git-svn-id: https://develop.svn.wordpress.org/trunk@35151 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 22:11:36 +00:00
Drew Jaynes
99ec80b140 Upgrader: Introduce a new action hook pre_auto_update, which fires immediately prior to an auto-update for core, themes, plugins, or translations.
Props DavidAnderson, welcher.
Fixes #30441.


git-svn-id: https://develop.svn.wordpress.org/trunk@35144 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 18:58:00 +00:00
Scott Taylor
d929461fd8 Taxonomy: get_terms_to_edit() can also return false or WP_Error. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations.
Props valendesigns.
Fixes #30472.


git-svn-id: https://develop.svn.wordpress.org/trunk@35139 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 16:39:47 +00:00
Sergey Biryukov
4240fe532c Acessibility: "Add New Category" links on Edit Post screen should not be a header.
Props afercia.
Fixes #33557.

git-svn-id: https://develop.svn.wordpress.org/trunk@35129 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 06:59:34 +00:00
Sergey Biryukov
70a4da6f04 Accessibility: bump headings one level up in post meta boxes for a better headings hierarchy.
Props afercia, joedolson, wonderboymusic.
See #33557.

git-svn-id: https://develop.svn.wordpress.org/trunk@35128 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 06:56:48 +00:00