sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
27,835 Commits 2 Branches 473 Tags 137 MiB
345a63f498
Commit Graph

27835 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Scott Taylor
345a63f498 WP_Image_Editor_GD and WP_Image_Editor_Imagick should specify type in a doc block for the $image property, instead of inferring bool and null. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30180 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 02:37:55 +00:00
Scott Taylor
204bab92c2 In WP_HTTP_IXR_Client: 
* declare `$scheme` as a property, it doesn't exist on the parent class
* declare `$error` as a property of type `IXR_Error`, instead of it being inferred as `boolean` from the parent class

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30179 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 02:31:39 +00:00
Scott Taylor
31df6204d0 Fix the return docs for WP_Embed->maybe_make_link(). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30178 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 02:26:34 +00:00
Jeremy Felt
90aa65e0f7 Use common core syntax for checking DOING_AJAX 
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891


git-svn-id: https://develop.svn.wordpress.org/trunk@30177 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-02 02:23:28 +00:00
Jeremy Felt
47e01357aa Delete admin_created_user_subject() rather than deprecate 
As it was never used as anything more than a callback to a filter before the MU merge, and is only available in user-new.php in multisite, it is safe to remove this function entirely.

Fixes #29915


git-svn-id: https://develop.svn.wordpress.org/trunk@30176 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-02 02:06:20 +00:00
Jeremy Felt
6f88946089 Improve layout of test for cached invalid, then valid site details 
* Rename method to `test_get_blog_details_when_site_does_not_exist()`.
* Always assume `MAX(blog_id)` is 1 and therefore always create a burner.
* Remove tests specific to `wpmu_delete_blog()` and cache, to be handled elsewhere.
* Remove extra asertions.

See #30080, #23405


git-svn-id: https://develop.svn.wordpress.org/trunk@30175 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-02 01:04:47 +00:00
Jeremy Felt
85aa2ef76e Split tests for wp_get_sites() 
Test various arguments for `wp_get_sites()` in a more intentful way rather than in one large test. Leave tests for limit and offset together for convenience.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30174 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 23:39:22 +00:00
Scott Taylor
105cd50bdf In _WP_Editors::editor_settings(), $str1 and $str2 don't need to be initialized empty. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30173 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 23:21:07 +00:00
Scott Taylor
b808e1af70 Declare the $uploaded_headers and $default_headers properties for WP_Customize_Header_Image_Control. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30172 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 23:17:48 +00:00
Scott Taylor
7acb2c8eb1 Declare the $update_count and $update_current properties for WP_Upgrader. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30171 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 23:06:38 +00:00
Scott Taylor
729bd580ab Declare the $options property for WP_Upgrader_Skin. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30170 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 23:02:52 +00:00
Scott Taylor
bb9f04baa8 Fix the return value doc for WP_List_Table->get_pagination_arg(). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30169 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:59:48 +00:00
Scott Taylor
c50eaf3b0d In wp_ajax_get_tagcloud(), bail immediately if $_POST['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30168 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:53:35 +00:00
Scott Taylor
ce6a31c5fe In wp_ajax_ajax_tag_search(), bail immediately if $_GET['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30167 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:47:27 +00:00
Scott Taylor
e5ad640c52 In get_the_pagination(), don't pass $links to _navigation_markup() if it is not a string - paginate_links() can return an array. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30166 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:40:17 +00:00
Scott Taylor
4e68f104f6 Make the docs type for return in wpmu_create_user() more specific. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30165 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:33:00 +00:00
Scott Taylor
b4d0961718 In customize.php, check that $autofocus is an array after running wp_unslash() instead of before. This is admittedly to skip a traversable hint in Scrutinizer. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30164 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:16:19 +00:00
Scott Taylor
64f773e4da In WP_Meta_Query->get_sql_for_clause(), the empty initialization of $where is dead code and can be removed. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30163 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 22:02:48 +00:00
Scott Taylor
5f09d235f0 In _wp_json_convert_string(), when $use_mb is false, perhaps pass a variable that actually exists to wp_check_invalid_utf8(). 
Introduced in [30055].
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30162 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 21:59:58 +00:00
Scott Taylor
143d248292 In gallery_shortcode(), when the link attribute is equal to file, make sure to pass $attr as the 6th (!) argument, not 5th, to wp_get_attachment_link(). 
Props bradyvercher.
Fixes #27402.


git-svn-id: https://develop.svn.wordpress.org/trunk@30161 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 21:46:51 +00:00
Scott Taylor
9817ecd92e Remove failing unit test after [30090]. 
Fixes #30194.


git-svn-id: https://develop.svn.wordpress.org/trunk@30160 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 21:10:23 +00:00
Scott Taylor
4315c9c5c3 Allow get_pages(), with child_of passed to it, to work with interrupted hierarchies. 
Adds unit test.
Fixes #18962.


git-svn-id: https://develop.svn.wordpress.org/trunk@30159 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 20:43:55 +00:00
Scott Taylor
59658c6547 All duplicate slugs across different post types. 
Adds unit test.

Props mboynes, nacin.
Fixes #18962.


git-svn-id: https://develop.svn.wordpress.org/trunk@30158 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 20:36:23 +00:00
Scott Taylor
03b49d8f88 Check $_current_page before using it in Walker_Page->start_el(). 
Props jeremyfelt.
Fixes #26901.


git-svn-id: https://develop.svn.wordpress.org/trunk@30157 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 20:28:40 +00:00
Scott Taylor
bdf71f89ad Display error message when Media Library upload fails. 
Props gcorne.
Fixes #29891.


git-svn-id: https://develop.svn.wordpress.org/trunk@30156 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 20:24:13 +00:00
Scott Taylor
c8acddfdc8 Improve some post_status-related documentation. 
Props ericlewis.
See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30155 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 20:19:26 +00:00
Scott Taylor
c171bb4aae In WP_List_Table, add a property, $modes, to allow WP_Media_List_Table to inherit ->view_switcher(). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30154 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 19:55:26 +00:00
Scott Taylor
f759c23d31 In wp_xmlrpc_server methods, for comprehensibility: 
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30153 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 19:44:07 +00:00
Jeremy Felt
db68b57c14 Split tests for is_main_site() 
Break multiple assertions from one method into multiple methods with one assertion each.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30152 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 05:17:17 +00:00
Jeremy Felt
d0fa387002 Expand and clarify tests for get_blog_post() 
Remove unnecessary user factory use. Be explicit about test scenarios.

See #30080


git-svn-id: https://develop.svn.wordpress.org/trunk@30151 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 04:47:00 +00:00
Drew Jaynes (DrewAPicture)
ab0324a729 Fix a couple of spacing and wrapping indents in the WP_Date_Query::__construct() hash notation. 
See [30142]. See #28063.


git-svn-id: https://develop.svn.wordpress.org/trunk@30150 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 04:31:00 +00:00
Drew Jaynes (DrewAPicture)
43b3515501 Relocate hook docs so they directly precede the hook lines moved into foreach statements in [30140]. 
It's necessary for hook docs to directly precede hook lines so the parser can correctly match them up. This change relocates hook docs for `update_{$meta_type}_meta`, `update_postmeta`, `updated_{$meta_type}_meta`, and `updated_postmeta`.

Fixes #11683.


git-svn-id: https://develop.svn.wordpress.org/trunk@30149 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 04:17:28 +00:00
Boone Gorges
262150a91e Clean up 'post-thumbnail' theme support unit tests. 
* Separate into smaller test methods.
* Remove incorrect tests. A number of assertions in the existing test have always incorrectly described the behavior of `current_theme_supports( 'post-thumbnails' )`, but no one ever noticed because the tests had been designed to bail when `_wp_render_title_tag()` did not exist. The failures finally became visible when that function was introduced in [30074].

See #18548.

git-svn-id: https://develop.svn.wordpress.org/trunk@30148 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 04:00:59 +00:00
Lance Willett
2ade0b964a Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names. 
Props slobodanmanic, fixes #28703.


git-svn-id: https://develop.svn.wordpress.org/trunk@30147 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 03:46:08 +00:00
Lance Willett
7f5058ac80 Twenty Fourteen: fix keyboard focus on Appearance > Header view. 
Props florianziegler, fixes #29787.


git-svn-id: https://develop.svn.wordpress.org/trunk@30146 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 03:43:25 +00:00
Lance Willett
9eb6f6f7fe Twenty Ten and Eleven: don't display modified excerpt link in wp-admin. 
Props kraftbj, fixes #30026.


git-svn-id: https://develop.svn.wordpress.org/trunk@30145 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 03:39:04 +00:00
Boone Gorges
09a1a6f5e6 Improve default argument formatting in WP_Date_Query::__construct(). 
git-svn-id: https://develop.svn.wordpress.org/trunk@30144 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 03:28:11 +00:00
Lance Willett
cbe8e288d4 Twenty Fourteen: Make featured content in Customizer contextual to the front page. 
Props celloexpressions, fixes #29578.


git-svn-id: https://develop.svn.wordpress.org/trunk@30143 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 03:25:43 +00:00
Boone Gorges
7c64b3b3dd Introduced dayofweek_iso time param for WP_Date_Query. 
The initial `dayofweek` param sets day 1 to Sunday. This is out of step with
ISO standards, which calls Monday day 1. To maintain backward compatibility
with the existing parameter, we introduce the new `dayofweek_iso` for the
new, more compliant param.

Props mboynes.
Fixes #28063.

git-svn-id: https://develop.svn.wordpress.org/trunk@30142 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 03:23:15 +00:00
Boone Gorges
d6b7b7aa41 Allow resource_type to be specified in get_ancestors(). 
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.

Props filosofo.
Fixes #15029.

git-svn-id: https://develop.svn.wordpress.org/trunk@30141 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 02:57:31 +00:00
Boone Gorges
8dbaaf9927 Pass all updated meta IDs to filters in update_metadata(). 
Props wonderboymusic.
Fixes #11683.

git-svn-id: https://develop.svn.wordpress.org/trunk@30140 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 02:38:19 +00:00
Scott Taylor
17e9c6f403 In wp_xmlrpc_server->pingback_ping(), remove the internal variable $way each time it is set and not used. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30139 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 01:49:26 +00:00
Scott Taylor
eb05767743 In wp_xmlrpc_server methods, don't set $blog_id internally if it is never used, which is almost always. Updates the docs. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30138 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 01:43:41 +00:00
Scott Taylor
842d9bc5cf In wp_xmlrpc_server->_prepare_comment(), $comment_date is set internally but never used. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 01:28:18 +00:00
Scott Taylor
334fc5b9f2 In Custom_Image_Header->step_2(), $type is set internally but never used. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30136 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 01:23:50 +00:00
Scott Taylor
bdf61ef6a0 Fix failing unit tests after [30096]: use assertEqualSets(). 
git-svn-id: https://develop.svn.wordpress.org/trunk@30135 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 01:10:39 +00:00
Boone Gorges
086f2b9dbd Fix database schema update introduced in [30121]. 
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30134 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 01:10:04 +00:00
Scott Taylor
ff4f545fc9 [28785] introduced a bug, where encoded query arguments were decoded by parse_str() inside of wp_parse_str() but never re-encoded later on. 
This encodes them, adds unit test.

Props obenland.
Fixes #29636.


git-svn-id: https://develop.svn.wordpress.org/trunk@30133 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 00:53:26 +00:00
Scott Taylor
ef23aee2a6 Fix unit test for video shortcode after [30082]. 
Fixes #30078.


git-svn-id: https://develop.svn.wordpress.org/trunk@30132 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 00:48:32 +00:00
Scott Taylor
0ae3ac0c05 Revisions modules should not rely on global settings: 
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax

Props ericlewis, wonderboymusic.
Fixes #30219.


git-svn-id: https://develop.svn.wordpress.org/trunk@30131 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-01 00:38:21 +00:00