sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
23,508 Commits 2 Branches 473 Tags 137 MiB
35a24943ea
Commit Graph

23508 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Scott Taylor
535ae26afd Fix several esoteric errors related to AJAX unit tests for comments: 
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 18:35:43 +00:00
Dominik Schilling (ocean90)
1de9497eef Add 'image' type/extensions to wp_ext2type() and make it case insensitive. props xparham. fixes #25176. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25437 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 14:33:19 +00:00
Dion Hulse
87e014a245 Account for Windows and CLI instances in wp_guess_url(). Props SergeyBiryukov. See #25317 
git-svn-id: https://develop.svn.wordpress.org/trunk@25436 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 03:42:38 +00:00
Sergey Biryukov
64eec20413 Inline documentation for hooks in wp-admin/export.php. 
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25435 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 01:01:49 +00:00
Sergey Biryukov
27d3a78193 Inline documentation for hooks in wp-admin/includes/comment.php. 
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25434 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 01:00:44 +00:00
Scott Taylor
402e61f269 Fix some undefined index notices related to Comment unit tests: 
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25433 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 22:17:51 +00:00
Scott Taylor
d85e040859 Remove the unnecessary call to ob_end_clean() directly after ob_get_clean() in WP_Ajax_UnitTestCase::dieHandler(). This fixes a large number of AJAX errors in debug mode. 
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25432 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 21:32:54 +00:00
Scott Taylor
f76f2a692a Fix an error in tests/ajax/Compression by removing the unnecessary call to ob_end_clean() immediately after ob_get_clean() in _gzdecode, which has aleady deleted the buffer. 
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25431 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 21:29:12 +00:00
Scott Taylor
ac23d53402 * Avoid notices in tests/ajax/Autosave by bailing early when get_post() returns nothing. 
* Check for the existence of `$_POST['catslist']` before using it in `wp_ajax_autosave()`.

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25430 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 21:21:16 +00:00
Sergey Biryukov
1a621e7615 Inline documentation for hooks in wp-includes/author-template.php. 
props Frank Klein.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25429 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 19:24:26 +00:00
Sergey Biryukov
631d5edf3a Inline documentation for get_comment_reply_link() and 'comment_reply_link' filter. 
props DrewAPicture.
fixes #25310.

git-svn-id: https://develop.svn.wordpress.org/trunk@25428 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 19:19:45 +00:00
Dion Hulse
9c1b30860c Upgrader: Allow plugins to short-circuit the package download. Props rmccue and DrewAPicture. Fixes #22378 
git-svn-id: https://develop.svn.wordpress.org/trunk@25427 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 12:52:28 +00:00
Dion Hulse
4da6ecff26 WP_HTTP: correct the SSL root certificates property, set svn:eol-style to native, and remove the svn:executable property. See #25007 
git-svn-id: https://develop.svn.wordpress.org/trunk@25426 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 12:29:27 +00:00
Sergey Biryukov
a57529c720 Avoid a PHP warning in network admin if a constant corresponding to a drop-in is not defined. fixes #25301. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25425 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 09:36:08 +00:00
Sergey Biryukov
f2c1db3663 Inline documentation for hooks in wp-admin/ms-delete-site.php. 
props NikV.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25424 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 09:10:18 +00:00
Sergey Biryukov
d60cbb399e Inline documentation for hooks in wp-includes/shortcodes.php. 
props natejacobs.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25423 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 09:01:20 +00:00
Dion Hulse
5959a7011b WordPress Core Automatic Updates: Pass the Filesystem path as $context to request_filesystem_credentials(). See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25422 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 06:52:11 +00:00
Dion Hulse
63956aa479 WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25421 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 06:18:16 +00:00
Sergey Biryukov
96d12ddd9d Better alignment for wp_prepare_revisions_for_js() inline docs. see #25283. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25420 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 23:14:55 +00:00
Sergey Biryukov
529c973323 Inline documentation fixes and additions for wp-admin/revision.php and wp-admin/includes/revision.php. 
props adamsilverstein.
see #25283.

git-svn-id: https://develop.svn.wordpress.org/trunk@25419 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 22:58:45 +00:00
Lance Willett
9e8bcc8bcd Twenty Fourteen: let authors customize the green "accent" color by changing to a different hex value in the Customizer. Props celloexpressions. 
Also add an ID attribute to all `style` elements.

See #25220.

git-svn-id: https://develop.svn.wordpress.org/trunk@25418 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 22:05:06 +00:00
Lance Willett
4585c81b37 Twenty Fourteen: prefix Genericons enqueue handle so that the theme uses the its own version of the font CSS. Fixes a few display issues when plugins like Jetpack enqueue a different version of Genericons. See #25085. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25417 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 21:44:49 +00:00
Andrew Nacin
bb2908d613 Clear all transients (regardless of expiration) on all database upgrades. see #20316. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25416 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 21:13:18 +00:00
Andrew Nacin
9d9a28b3e0 Test framework: Update path to multisite.xml. 
props jeremyfelt.
fixes #25242.


git-svn-id: https://develop.svn.wordpress.org/trunk@25415 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 21:04:16 +00:00
Andrew Nacin
8917f2b3bd Add populate_network_meta filter to populate_network(). 
props jeremyfelt.
fixes #25020.


git-svn-id: https://develop.svn.wordpress.org/trunk@25414 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 20:48:20 +00:00
Andrew Nacin
3631b81545 Fix comma placement in [25179]. 
props gradyetc.
see #15004, fixes #25298.


git-svn-id: https://develop.svn.wordpress.org/trunk@25413 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 20:15:30 +00:00
Helen Hou-Sandi
91d14be2e2 No space between // and duplicate_hook. see #25229 
git-svn-id: https://develop.svn.wordpress.org/trunk@25412 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 18:56:32 +00:00
Helen Hou-Sandi
67633ef09e Inline docs for hooks in wp-admin/options-writing.php. props siobhyb. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25411 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 18:52:38 +00:00
Helen Hou-Sandi
f72bc15544 Inline docs for hooks in wp-includes/nav-menu-template.php. props Faison. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25410 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 18:47:27 +00:00
Andrew Nacin
4c8f1e263a Use @expectedDeprecated. see #25282, [25408]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25409 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 18:37:32 +00:00
Andrew Nacin
d5d476974e Test framework: Introduce the annotation @expectedDeprecated, modeled after PHPUnit's @expectedException. 
It works for both functions and arguments (using the value of the first argument passed to _deprecated_function() or _deprecated_argument(), which is typically the function name). It asserts both ways:
 * If specified, those deprecated notices must be caught, or the test fails.
 * If not specified, any other deprecated notices cause the test to fail.

Works regardless of WP_DEBUG.
see #25282.


git-svn-id: https://develop.svn.wordpress.org/trunk@25408 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 18:37:00 +00:00
Andrew Nacin
9bfe9b7230 Revert [25405] and use a file that does exist. see #25282. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25407 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 17:47:40 +00:00
Lance Willett
e89c725696 Twenty Fourteen: fix comment for twentyfourteen_excerpt_length(), props SergeyBiryukov. Fixes #25297. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25406 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 17:43:23 +00:00
Scott Taylor
8a2c79d897 Fix the failing l10n assertions: 
* Check if the file exists before running `true` assertions
* If the file doesn't exist, run `false` assertions

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25405 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 17:36:45 +00:00
Scott Taylor
404fd85586 Fix the failing Tests_Link::test_wp_get_shortlink() assertion: 
* `wp_get_shortlink()` was firing a notice when reading `$post->ID` while `$post` was null in some cases
* Before the assertions that assume `$GLOBALS['post']` is not set, call `unset( $GLOBALS['post'] );` - there was global spillage from other tests

See #25282.




git-svn-id: https://develop.svn.wordpress.org/trunk@25404 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 17:30:01 +00:00
Helen Hou-Sandi
435c2b5686 Add file size to attachment publish meta box. props desrosj. fixes #25170. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25403 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 15:09:35 +00:00
Scott Taylor
654d07ebf9 There was way too much duplicated code in my notice cleanup, it built up over time, and there's definitely a need to standardize. 
* Remove duplicated code for deprecated function notice suppression
* Add support in `WP_UnitTestCase` setUp/tearDown methods for `$deprecated_functions` fixture if the extending class has added it
* Add a `$deprecated_functions` fixture to each extending class that needs it

To use this fixture, add something to your Test Case class like so:
`protected $deprecated_functions = array( 'get_theme', 'get_themes', 'get_theme_data', 'get_current_theme' );`

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25402 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 14:47:58 +00:00
Andrew Nacin
1851da1382 Return false from wp_get_original_referer() if it is called before wp_validate_redirect() is defined. 
see #25294.


git-svn-id: https://develop.svn.wordpress.org/trunk@25400 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 13:35:35 +00:00
Andrew Nacin
cc5477c7d9 Return false from wp_get_referer() if it is called before wp_validate_redirect() is defined. 
see #25294.


git-svn-id: https://develop.svn.wordpress.org/trunk@25399 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 13:32:41 +00:00
Scott Taylor
3ae18e68ff * Fill in undefined var in Tests_Option_BlogOption 
* Add `defined()` check for `BLOGSUPLOADDIR`
* Suppress deprecated function notices for `is_blog_user()` and `get_dashboard_blog()`
* Check existence of `$user` in `wpmu_log_new_registrations()` before arbitrarily making a database query

Fixes all notices in multisite unit tests.

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25397 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 07:16:30 +00:00
Dion Hulse
cccac649d5 Fix wp_guess_url() to work in every scenario I could find, allows us to use it to determine the correct path to the WordPress Site URL before installation for install.php and setup-config.php redirects. Fixes #24480 Fixes #16884 
git-svn-id: https://develop.svn.wordpress.org/trunk@25396 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 06:56:20 +00:00
Scott Taylor
285db00ed4 Suppress Non-static method PO::*() should not be called statically, assuming $this from incompatible context by using the @ silencer in tests/pomo/po.php 
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25395 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 06:46:35 +00:00
Scott Taylor
13381bfcdc * sort() returns a boolean, not a sorted set. Move the calls out of the assertions and fix the test methods. 
* Fix instances where `Only variables should be passed by reference` was being triggered by assigning `array_keys()` return value to a var

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25394 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 06:41:36 +00:00
Scott Taylor
d58aace6f7 Avoid undefined variable notice - wp_insert_user() expects user_pass to be passed to it. 
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25393 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 06:28:25 +00:00
Scott Taylor
d1d5bcf036 * Add isset() checks all over WP_User_Query::prepare_query() and WP_User_Query::query(). When a WP_User_Query instance is constructed without passing args, no query vars are filled in, thus $qv doesn't contain most of the expected indices. 
* Suppress an undefined index notice in `tests/user/query.php`

Fixes #25292.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25392 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 06:24:09 +00:00
Scott Taylor
c0c3359572 * Suppress deprecated function notice for set_current_user() 
* Add assertions for `wp_set_current_user()`

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25391 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 06:06:07 +00:00
Scott Taylor
b18d047edd * Avoid Only variables should be passed by reference notice by passing a var to array_pop() in tests/user.php 
* Suppress a notice by silencing the passing of a non-existent object prop

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25390 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 05:56:59 +00:00
Scott Taylor
6acb4cf24d Don't assume $GLOBALS['post'] is set in tests/url.php. 
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25389 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 05:52:53 +00:00
Scott Taylor
f4ac65db2d * Suppress deprecated function notices in tests/theme/themeDir.php 
* Set `$theme['Template Files']` and `$theme['Stylesheet Files']` to a variable before calling array methods upon them - avoids `Indirect modification of overloaded element has no effect` notice
* Clean up setUp/tearDown in `tests/theme.php`

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25388 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 05:48:58 +00:00
Scott Taylor
ee35baae6b Suppress the _doing_it_wrong notices when calling add_theme_support( 'html5' ) in tests/theme/support.php 
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25387 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 05:39:45 +00:00