90a115e4b4
Partially revert [20100]. The list_args JS variable cannot be extended due to its use as an argument in fetch-list. see #19815 .
...
We should reattempt extending the args created in WP_List_Table, but will need to deprecate the current list_args to do so.
Also, infinite scroll on themes pages is no longer broken. Go team.
git-svn-id: https://develop.svn.wordpress.org/trunk@20104 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-03 02:40:43 +00:00
ba75fc6e7d
Compress scripts/styles: 3.4-alpha-20103.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20103 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-03 00:30:21 +00:00
a7122f9269
Don't hide PHP warnings under the toolbar in the admin. fixes #19196 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20102 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-03 00:29:50 +00:00
b6b4d37fcb
Allow WP_List_Table::_js_vars() to take an array of additional args to add. Allows us to have a single variable printing data when child classes need more data. Also, fix compact() call in [20094]. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20100 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 23:06:31 +00:00
c56b5f3f59
Use sanitize_key(). sanitize_title_with_dashes() is more than we need. see #19815 . see [20096], [20097].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20098 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:32:29 +00:00
9f47e027ca
Revert [20096] which was an accidental partial revert of [20094]. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20097 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:31:15 +00:00
7dd527a421
Use sanitize_key() for theme search tags/features. sanitize_title_with_dashes() is overkill. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20096 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:26:58 +00:00
fd8c500bda
Compress scripts/styles: 3.4-alpha-20095.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20095 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:15:21 +00:00
43209998c6
Output themes and theme-install infinite scrolling args in JS, rather than parsing query strings. props DH-Shredder, helenyhou. Make WP_Theme_Install_List_Table extend WP_Themes_List_Table. Doesn't help much yet, but we should be able to dry things up further. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20094 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:09:26 +00:00
d996b72215
Use tabs for indentation.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20093 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:03:15 +00:00
c6d3eafb7e
Drop unnecessary if-statements which also have some strange logic. Fixes #20159 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20092 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:01:41 +00:00
2ebabb330c
Compress scripts/styles: 3.4-alpha-20090.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20090 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 21:15:21 +00:00
b80111d67c
Bail from AJAX success callback if wp_ajax_add_tag() returns errors. Props solarissmoke. Fixes #20086 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20086 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 21:01:51 +00:00
5b12ac7e80
Compress scripts/styles: 3.4-alpha-20084.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20084 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 20:30:19 +00:00
214ea7bfcb
Use blue arrows for blue admin's screen options and help tabs. Adjust baseline to be more compatible with Firefox. props helenyhou. fixes #16114 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20082 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 20:23:26 +00:00
129754ed3d
Don't autoload the uninstall_plugins option. fixes #16741 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20080 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 20:13:35 +00:00
58acedae74
Compress scripts/styles: 3.4-alpha-20079.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20079 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 20:00:21 +00:00
1bc62a722a
In miscellaneous publishing actions, use :last-child instead of a separate misc-pub-section-last class to control borders. Allows for sane use of the post_submitbox_misc_actions hook. (Actually uses :first-child for browser compat reasons.) fixes #19604 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20077 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 19:52:23 +00:00
b89570a1ef
Improve background, styling, and alignment of the Help and Screen Options tabs. props helenyhou. props johnjamesjacoby for initial patch. see #16114 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20076 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 19:47:08 +00:00
f4d36e96a5
Add the wp_edit_nav_menu_walker filter to the ajax request. props wonderslug, ocean90. fixes #14527 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20072 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 17:50:01 +00:00
1cbc983342
Fix a small typo.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20070 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 11:00:51 +00:00
31e6f087d7
Use correct name for feature filter REQUEST data to ensure that the search/filter form is present when a filter is active. see #20147 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20069 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 00:41:00 +00:00
eee4414129
Remove debug cruft.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20068 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 00:13:05 +00:00
514b909597
Remove inline styles for 'Apply Filters' feature filter button. Don't <small> the 'Close filters' text. see #20147 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20067 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 00:01:55 +00:00
5986e072fa
Compress scripts/styles: 3.4-alpha-20066.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20066 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 00:00:20 +00:00
12aa35e6aa
Remove theme tags from the themes.php UI. They just take up room and are redundant with the feature filter. The installer already does not show tags. props DH-Shredder, fixes #20147 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20065 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-01 23:58:10 +00:00
f2dfcad422
Line up elements on themes.php. Line up 'Available Themes' header and search/feature form. Switch to padding instead of margin for #current-theme to prevent margin-uncollapse jitters when animating the feature filter. Move 'Current Theme' inside #current-theme so it is hidden by the feature filter. see #20147 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20064 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-01 23:55:09 +00:00
7df5a5294d
Introduce jQuery Masonry. Use it to arrange header thumbnails on custom header screen. Props aaroncampbell. fixes #17242
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20060 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-01 18:57:28 +00:00
76a0adc5e2
Remove extra $. see #20103 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20052 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 22:54:50 +00:00
cc503e4315
In WP_Themes_List_Table, don't perform unnecessary sanitization on search terms or filter features. We only use these for case-insensitive comparison. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20048 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 22:19:18 +00:00
d7b7ac8c1b
'Network Activate' should be the bulk action on network/plugins.php, to match the action link. props ampt, fixes #19946 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20046 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 21:52:27 +00:00
47db4344b9
Have WP_Theme::get_screenshot() default to an absolute URI. Allow 'relative' to be requested. see #20103 , see #19816 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20043 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 20:31:56 +00:00
cdaee9042d
Translate page template names! Have WP_Theme::get_page_templates() return templates keyed by filename, not by template name, as it makes more sense. Flip this in get_page_templates() to be compatible. fixes #6007 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20041 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 20:18:53 +00:00
9cc63bb04f
Use proper object. see #20103 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20038 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 18:11:49 +00:00
c7855fb7bc
Use wp_get_theme() rather than get_theme_data() in the verify theme deletion (multisite network) screen. see #20103 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20037 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-29 07:50:56 +00:00
53a209a4ee
Introduce WP_Theme, wp_get_themes(), and wp_get_theme() to replace get_themes(), get_theme(), get_theme_data(), current_theme_info(), and others.
...
* Getters and Helpers: Introduces a series of methods to allow for easy generation of headers for display, and other theme metadata, including page templates.
* Screenshots: Handles support for multiple screenshots. (see # Additional screenshots must be PNG and start with screenshot-2.png, and be sequential to be counted. see #19816 .
* Error Handling: Broken themes have a WP_Error object attached to them.
* Caching: Introduces a wp_cache_themes_persistently filter (also in [20020]) to enable persistent caching of all filesystem and sanitization operations normally handled by WP_Theme (and formerly get_file_data() and get_themes()). Themes are cached individually and across five different cache keys for different data pieces.
* Compatibility: A WP_Theme object is backwards compatible with a theme's array formerly returned by get_themes() and get_theme(), and an stdClass object formerly returned by current_theme_info().
* i18n/L10n: Theme headers are now localizable with proper Text Domain and Domain Path headers, like plugins. (Language packs may remove the requirement for headers.) For page templates, see #6007 (not fixed yet, but will be easy now). For headers, fixes #15858 .
* PHP and CSS files: New methods that fetch a list of theme files (for the theme editor) only on demand, rather than only loading them into memory. fixes #11214 .
Functions deprecated:
* get_themes(), get_allowed_themes() and get_broken_themes() -- use wp_get_themes()
* get_theme() and current_theme_info() -- use wp_get_theme()
* get_site_allowed_themes() -- use WP_Theme::get_allowed_on_network()
* wpmu_get_blog_allowedthemes() -- use WP_theme::get_allowed_on_site()
see also [20016], [20018], [20019], [20020], [20021], [20022], [20025], [20026], [20027]. also fixes #19244 .
see #20103 .
git-svn-id: https://develop.svn.wordpress.org/trunk@20029 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 21:24:44 +00:00
f0c5c18d81
Faster theme searching. Only calculate what is necessary -- if the theme doesn't have all of the features, bail. If a word matches a tag or header, jump to the next word, we don't care how many times it matches. see #20103 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20027 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:51:19 +00:00
3924c4aab5
Don't sanitize theme tags while trying to search through them, as it is unnecessary. It is also very expensive -- 50% of the pageload for a search was spent sanitizing tags. see #20103 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20026 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:41:53 +00:00
11c4081aaf
Add argument to get_theme_feature_list() to allow the tags to be returned without hitting the WP.org API. We'll be using this to translate tags. Remove trailing space in the 'Light' string. see #20103 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20025 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:38:09 +00:00
cafa8dab24
Reduce references to the $wp_rewrite global because it's no longer used or a wrapper function can be used instead. Fixes #14546.#14546.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20023 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:29:33 +00:00
21630b2828
Do not save the last visited tab on the multisite Network Themes page and Site Themes tab. These are poor UX, see #18810 for plugins. Entering these screens will always default to 'all' themes view. see #20103 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20022 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:13:21 +00:00
4c99743d06
Drop image resizing code from wp_handle_upload(). Fixes #19800 .
...
This code stops wp_handle_upload() from reporting errors when the upload couldn't be moved to its final local and it was a non-JS fallback that is unused.
git-svn-id: https://develop.svn.wordpress.org/trunk@20019 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:02:43 +00:00
89e9bcc1d6
Pinking shears 6-20000
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20000 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-27 19:46:52 +00:00
5648306064
Pass post id to get_upload_iframe_src() instead of relying on a global. Props tott. fixes #20003
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19999 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-27 19:23:03 +00:00
682b2a4b6d
Remove out-of-place double quote. props niallkennedy. fixes #20113 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19987 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-24 20:49:54 +00:00
2a0b86ea08
Compress scripts/styles: 3.4-alpha-19983.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19983 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-24 02:00:58 +00:00
0fa723245a
HTML in image captions, first run, see #18311
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19982 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-24 01:58:18 +00:00
72ade0057d
Make sure to echo out the comment_post_ID when building the edit comment form otherwise the post comment counts will get out of sync. Fixes #20108 props dllh.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19981 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-23 18:16:46 +00:00
7327a30867
Preserve keys when splitting themes up for pagination. props Utkarsh. fixes #15306 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19980 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-23 14:42:01 +00:00
082f9f9739
Use version_compare() when checking installed themes in the theme installer. fixes #20097 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19979 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-22 14:03:59 +00:00
Daryl Koopersmith
bumpbot
Andrew Nacin
Jon Cave
Dion Hulse
Ryan Boren
Andrew Ozz
Peter Westwood