Commit Graph

176 Commits

Author SHA1 Message Date
Ryan Boren 436b32ef62 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: https://develop.svn.wordpress.org/trunk@23567 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:14:09 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin 34985fbc7a Revert page on front changes. Reverts [22127] [22129] [22135] [22136]. see #16379.
git-svn-id: https://develop.svn.wordpress.org/trunk@22653 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-19 01:28:32 +00:00
Andrew Nacin d3af38c768 Move the static front page saving routine to a single sanitize_option() callback for show_on_front. page_on_front and page_for_posts are now manually set by this callback, and not separately by options.php. see #16379.
git-svn-id: https://develop.svn.wordpress.org/trunk@22136 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-08 21:25:13 +00:00
Andrew Nacin ff88489bdc Remove the 'Size of the post box' (default_post_edit_rows) option. This will instead be handled by a user cookie tracking the resizing of both TinyMCE and the main textarea. see #21718.
git-svn-id: https://develop.svn.wordpress.org/trunk@22006 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-26 03:17:28 +00:00
Andrew Nacin 84ca011876 Always attempt to embed URLs in content, removing the Auto-embeds (autoembed_urls) option.
Remove the UI for setting the default width and height for embeds. Width was confusing as it
was blank by default (inheriting the content width from the theme, or 500px). The height is
now calculated as 1.5x the content width, or 1000px, whichever is smaller.

The [embed] shortcode can still receive manual height and width attributes. This just removes
the global settings.

props wonderboymusic. see #21719.



git-svn-id: https://develop.svn.wordpress.org/trunk@21998 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 07:10:09 +00:00
Andrew Nacin 93f6ea672e Hide upload_path and upload_url_path from the Media Settings screen, assuming they are both set to their default values.
These can be set on options.php, or the UPLOADS constant or the filters in wp_upload_dir() should be used. WordPress should aim to avoid UI options that require filesystem changes as well, not to mention requiring the user to convert between paths and URLs.

fixes #21720.



git-svn-id: https://develop.svn.wordpress.org/trunk@21852 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-14 21:00:39 +00:00
Andrew Nacin 537a6769e6 If an option was not sent to options.php, pass null to update_option(), rather than trimming the null and converting it to an empty string. This provides better context for sanitize_option() while still storing what ends up being an empty string either way. see #16416.
git-svn-id: https://develop.svn.wordpress.org/trunk@21849 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-14 19:12:35 +00:00
Andrew Nacin bd6d86d123 Avoid the need for a hidden input when suppressing the blog_charset option. fixes #21507.
git-svn-id: https://develop.svn.wordpress.org/trunk@21842 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-14 03:23:06 +00:00
Andrew Nacin f62839c45b Fold Privacy Settings into Reading Settings, moving blog_public (search engine/robots) to options-reading and removing options-privacy.
When blog_public only has two values (as judged by whether the blog_privacy_selector action is used), convert from radio buttons to a checkbox, and rename from 'Site Visibility' to a more specific 'Search Engine Visibility'.

The text and implementation may change a bit. see #16416.



git-svn-id: https://develop.svn.wordpress.org/trunk@21838 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-13 17:28:57 +00:00
Andrew Nacin dfac91464f Remove AtomPub from core.
* Will be replaced with http://wordpress.org/extend/plugins/atom-publishing-protocol/.
 * Introduces an action, xmlrpc_rsd_apis, to add APIs to xmlrpc.php?rsd.
 * Introduces support for 'error' being 403 and 50x in class-wp.php.
 * Removes 'Remote Publishing' from Writing Settings (see [21804]). Keeps the remote_publishing settings section.

DB version is bumped to generate the new wp-app rewrite rule and remove the old enable_app option.

props wonderboymusic.
fixes #21509.



git-svn-id: https://develop.svn.wordpress.org/trunk@21818 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-11 20:11:39 +00:00
Andrew Nacin 6df2aff40b Turn XML-RPC on and remove the option on the Writing Settings page.
props markoheijnen for the initial patch.

Introduces a new filter, xmlrpc_enabled.

Respects any current callbacks registered to the pre_option_enable_xmlrpc
and option_enable_xmlrpc filters, for anyone forcing it off via code.

fixes #21509.



git-svn-id: https://develop.svn.wordpress.org/trunk@21804 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-11 00:37:31 +00:00
Andrew Nacin 8cac9d023a Remove unused multisite option 'language'. props wonderboymusic. fixes #21545.
git-svn-id: https://develop.svn.wordpress.org/trunk@21551 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-20 16:43:44 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Ryan Boren 5e76729992 One newline is enough.
git-svn-id: https://develop.svn.wordpress.org/trunk@19684 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:10:39 +00:00
Ryan Boren 54067a5f20 Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: https://develop.svn.wordpress.org/trunk@19596 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-14 17:36:38 +00:00
Mark Jaquith a3bdf19206 Be more consistent with ERROR: messages. fixes #15887
git-svn-id: https://develop.svn.wordpress.org/trunk@18841 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-30 17:18:35 +00:00
Andrew Nacin b25c4e7cb3 Add option_page_capability_$option_page filter. see #14365.
git-svn-id: https://develop.svn.wordpress.org/trunk@17986 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-22 21:32:22 +00:00
Andrew Nacin f504e221e1 Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: https://develop.svn.wordpress.org/trunk@17748 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 15:24:49 +00:00
Andrew Nacin f660585656 Allow dfault post format selections. fixes #15882.
git-svn-id: https://develop.svn.wordpress.org/trunk@17056 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-19 05:36:11 +00:00
Mark Jaquith 2158fc7445 Backwards compat for plugin use of updated=1. fixes #15660
git-svn-id: https://develop.svn.wordpress.org/trunk@16706 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-03 10:59:20 +00:00
Mark Jaquith 55e0256967 esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454
git-svn-id: https://develop.svn.wordpress.org/trunk@16431 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-17 17:12:01 +00:00
Mark Jaquith d65cdf4ba8 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@16061 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-28 21:56:43 +00:00
scribu 0911aa3e1a Use submit_button() in more places. See #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@15830 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-17 18:24:34 +00:00
Andrew Nacin f92765c934 Remove default_comment_status_pages setting. Reverts [14451], [14448] for 3.0. see #12991.
git-svn-id: https://develop.svn.wordpress.org/trunk@14650 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-15 04:56:56 +00:00
Ron Rennick bdb89ac091 add default comment status setting for pages, props messenlehner, see #12991
git-svn-id: https://develop.svn.wordpress.org/trunk@14448 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-04 19:31:24 +00:00
Ryan Boren 7a9ddcfb70 Don't stomp upload options when saving media options for MS sites. fixes #13182
git-svn-id: https://develop.svn.wordpress.org/trunk@14316 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-30 14:31:18 +00:00
Ryan Boren 972900cf3e Allow regular admins to change the admin email. see #13126
git-svn-id: https://develop.svn.wordpress.org/trunk@14241 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-26 17:55:41 +00:00
Andrew Nacin ec4f5b83bf Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87.
git-svn-id: https://develop.svn.wordpress.org/trunk@14139 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-18 06:14:45 +00:00
Dion Hulse 491063c698 Tweak new strings for better typography. Props demetris. Fixes #12962
git-svn-id: https://develop.svn.wordpress.org/trunk@14070 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-11 10:41:54 +00:00
Andrew Nacin 752e02538a Move unregistered check to proper branch of code. prevents options.php panel from throwing errors. see #11730
git-svn-id: https://develop.svn.wordpress.org/trunk@13789 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-21 07:38:10 +00:00
Andrew Nacin ef46c26f1b Simplify the deprecated notice for unregistered settings. fixes #11730
git-svn-id: https://develop.svn.wordpress.org/trunk@13785 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-21 01:49:00 +00:00
Dion Hulse 74758b574f Remove reminents of 'misc' from whitelist options too. See [13745] See #12437
git-svn-id: https://develop.svn.wordpress.org/trunk@13746 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-18 07:58:53 +00:00
Dion Hulse 0b02d175c5 Remove the now defunct link update checker from core. Fixes #12437
git-svn-id: https://develop.svn.wordpress.org/trunk@13744 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-18 07:17:55 +00:00
Ryan Boren e61755c853 Trim trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@13733 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-17 16:27:25 +00:00
Andrew Nacin 3b60c95996 Fix branching, and correct deprecated version numbers. see #11730
git-svn-id: https://develop.svn.wordpress.org/trunk@13721 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-16 20:59:26 +00:00
Ron Rennick 8cbf25a155 more descriptive message on blocking unregistered setting, see #11644, related #11730
git-svn-id: https://develop.svn.wordpress.org/trunk@13711 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-15 22:00:48 +00:00
Ron Rennick feb6eacff1 block unregistered settings in multisite, see #11644, related #11730
git-svn-id: https://develop.svn.wordpress.org/trunk@13709 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-15 18:10:34 +00:00
Andrew Nacin a56fef6907 Only show multisite admin email notice if the email was changed. Add a "Cancel" link so the nag doesn't stay forever if the admin ends up not changing the email. see #12192
git-svn-id: https://develop.svn.wordpress.org/trunk@13705 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-15 17:18:00 +00:00
Andrew Nacin 8d0a3589c9 Use disabled() form helper. fixes #12581
git-svn-id: https://develop.svn.wordpress.org/trunk@13661 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-11 17:12:23 +00:00
Ron Rennick 8de3d20dc2 Display a warning when processing an unregistered setting, see #11730
git-svn-id: https://develop.svn.wordpress.org/trunk@13646 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-10 17:44:32 +00:00
Dion Hulse 528d441b24 Cleanup of options.php. Adds concise&early wp_die()'s, reformats some poorly chosen branching. See #12455
git-svn-id: https://develop.svn.wordpress.org/trunk@13627 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-09 10:57:49 +00:00
Dion Hulse 6045d8f79f Restore MultiSite checks on Upload settings, Add proper whitelisting. Props Denis-de-Bernardy. Fixes #11687
git-svn-id: https://develop.svn.wordpress.org/trunk@13545 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-02 10:31:06 +00:00
Dion Hulse 78c20f584a Move Upload folder settings to Options -> Media. Props nacin. Fixes #11687
git-svn-id: https://develop.svn.wordpress.org/trunk@13529 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-01 12:13:15 +00:00
Andrew Nacin 7bf76c1e79 Fix typo in [13471]. Props miqrogroove, see #12417
git-svn-id: https://develop.svn.wordpress.org/trunk@13472 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-27 22:54:40 +00:00
Andrew Nacin ae12391427 Make it more obvious we're escaping values in options.php. fixes #12417
git-svn-id: https://develop.svn.wordpress.org/trunk@13471 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-27 22:50:00 +00:00
Ryan Boren 0ac0e76299 Option validation error reporting. Props jeremyclarke. see #11474
git-svn-id: https://develop.svn.wordpress.org/trunk@13177 602fd350-edb4-49c9-b593-d223f7449a82
2010-02-17 17:50:42 +00:00
Ryan Boren 0d90882b71 Deprecate mu_options. Integrate directly into options.php. see #11644
git-svn-id: https://develop.svn.wordpress.org/trunk@12825 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-25 21:33:49 +00:00
Ryan Boren 2e46e81309 i18n fixes. Props nbachiyski. fixes #11954
git-svn-id: https://develop.svn.wordpress.org/trunk@12789 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-21 21:37:43 +00:00