Commit Graph

27461 Commits

Author SHA1 Message Date
Scott Taylor 3a11531451 In the `wp_new_blog_notification()` email template, include the login url.
Props obenland, georgestephanis.
Fixes #21089.


git-svn-id: https://develop.svn.wordpress.org/trunk@29806 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 01:27:57 +00:00
Boone Gorges 6dc662431a Improve unit tests for WP_Tax_Query.
* Exhaustive tests for publicly available functionality of WP_Tax_Query.
* For tests that are related to the tax_query argument as used in WP_Query, move to tests/post/query.php.
* Add some tax_query tests to cover single vs multiple queries using AND and OR; various values for 'field'; various values for 'operator'.
* Improve test names.
* Correct @group annotations.
* Improve performance of some WP_Query-related tests by declaring 'update_post_meta/term_cache' false.

Fixes #29718

git-svn-id: https://develop.svn.wordpress.org/trunk@29805 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 01:07:20 +00:00
Sergey Biryukov c4fcdf329e Add classes to form containers on Edit User screen.
props jarednova.
fixes #29348.

git-svn-id: https://develop.svn.wordpress.org/trunk@29804 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 00:55:40 +00:00
Sergey Biryukov d59e6696b3 Add classes to form containers on taxonomy screens.
props jarednova.
fixes #28196.

git-svn-id: https://develop.svn.wordpress.org/trunk@29803 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 00:28:45 +00:00
Scott Taylor 0cae966012 Add a namespace to the click handler registration for `.insert-media` in `media-editor.js`: `click.add-media-button`.
This is a stopgap to allow devs to override the default behavior.

Fixes #23096.


git-svn-id: https://develop.svn.wordpress.org/trunk@29802 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-01 19:07:14 +00:00
Scott Taylor 4daab443c0 Add a default filter to `title_save_pre`: `trim`, because extra whitespace.
Props nikolov.tmw, avryl.
Fixes #19904.


git-svn-id: https://develop.svn.wordpress.org/trunk@29801 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-01 18:57:08 +00:00
Sergey Biryukov c2d1b30e1c Version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@29800 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-01 14:58:21 +00:00
Boone Gorges 1f6fd2c926 Improve unit tests related to WP_Meta_Query.
* More complete test coverage for publicly available methods of WP_Meta_Query.
* Move tests that rely on WP_Query (via the meta_query parameter) to tests/post/query.php.
* Better coverage for basic use cases of 'meta_query', including all values of 'compare' and default values of 'key', 'value', and 'compare'.
* Improve performance for tests that run WP_Query, by retrieving only post IDs and not prefetching postmeta and post terms.
* Add 'public' visibility keywords to test methods.
* Whitespace cleanup.

Fixes #29560

git-svn-id: https://develop.svn.wordpress.org/trunk@29799 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-30 21:17:38 +00:00
Boone Gorges 0b80b40d59 Improve unit test coverage for duplicate term creation.
These include an exhaustive set of tests for term_exists(), as well as tests
for wp_insert_term() that demonstrate failure when attempting to create a
duplicate term.

Props simonwheatley for an initial patch.

See #22023.


git-svn-id: https://develop.svn.wordpress.org/trunk@29798 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-30 14:59:10 +00:00
Boone Gorges 780c6962e5 Improve parameter sanitization in WP_Date_Query::build_query().
* Don't run non-numeric values through intval() for sanitization; this transforms them into 1s and 0s, which can cause unintended results.
* Be more generous about numeric array keys (don't require 0 and 1) in BETWEEN and NOT BETWEEN clauses.

Fixes #29801.

git-svn-id: https://develop.svn.wordpress.org/trunk@29797 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-30 14:03:49 +00:00
Drew Jaynes (DrewAPicture) 4dc3c6bea2 Update documentation for `wp_get_nav_menus()` to reflect that the default value for the the 'orderby' argument was changed from 'none' to 'name' in 4.1.
Props curtjen.
Fixes #29460.


git-svn-id: https://develop.svn.wordpress.org/trunk@29796 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 23:34:33 +00:00
Aaron Jorbin 811166dc1a Watch Gruntfile.js so that changes to it reload the watch task
props netweb
fixes #29068



git-svn-id: https://develop.svn.wordpress.org/trunk@29795 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 17:20:58 +00:00
Boone Gorges 5a288bad58 Fix file location for WP_Date_Query tests introduced in r29793.
See #29781


git-svn-id: https://develop.svn.wordpress.org/trunk@29794 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 16:19:53 +00:00
Boone Gorges fd816091a5 Improved unit test coverage for WP_Date_Query
- Unit tests for all publicly available functionality in WP_Date_Query
- Improve performance of date_query tests that use WP_Query

Fixes #29781


git-svn-id: https://develop.svn.wordpress.org/trunk@29793 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 16:04:46 +00:00
Sergey Biryukov f6753a316a Change the default orderby value in wp_get_nav_menus() to 'name'.
props voldemortensen, igmoweb.
fixes #29460.

git-svn-id: https://develop.svn.wordpress.org/trunk@29792 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 15:44:26 +00:00
Sergey Biryukov 8cc322b073 Fix padding for parent theme link on Edit Themes screen.
props kraftner.
fixes #27825.

git-svn-id: https://develop.svn.wordpress.org/trunk@29791 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 14:09:38 +00:00
Sergey Biryukov dfc018ccf9 Account for longer translations of 'Customize Your Site' button label.
props shooper.
fixes #29451.

git-svn-id: https://develop.svn.wordpress.org/trunk@29790 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:56:34 +00:00
Mark Jaquith be8a0c6f89 Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org)
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29789 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:36:38 +00:00
Mark Jaquith 7063377539 Use HTTPS URLs for core.trac.wordpress.org
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29788 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:27:55 +00:00
Mark Jaquith 4c22a5003b Use HTTPS links for planet.wordpress.org
see #27115

git-svn-id: https://develop.svn.wordpress.org/trunk@29787 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:23:46 +00:00
Sergey Biryukov 029d1dbaa4 Use a more specific selector for the count displayed on Add Themes network admin screen.
props mantismamita, nikolov.tmw.
fixes #29421.

git-svn-id: https://develop.svn.wordpress.org/trunk@29786 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 13:06:17 +00:00
Mark Jaquith 7402030670 Show the number of approved comments instead of all comments on
the dashboard in the "At a glance" section.

fixes #26738. props benjmay

git-svn-id: https://develop.svn.wordpress.org/trunk@29785 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 12:41:49 +00:00
Sergey Biryukov 2a050d1e6f Remove unnecessary semicolon.
props ixkaito.
fixes #29784.

git-svn-id: https://develop.svn.wordpress.org/trunk@29784 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 10:29:16 +00:00
Andrew Nacin 8a956769a4 PHPMailer: Merge upstream commit (PR274).
props zodiac1978.
fixes #27946.


git-svn-id: https://develop.svn.wordpress.org/trunk@29783 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 10:27:58 +00:00
Scott Taylor 37da833fce In the form handler logic for `edit-tags.php`, don't redirect until `$_REQUEST['paged']` has been checked. All `switch` cases (except `edit`) now use `break` instead of `exit`.
Fixes #16162.


git-svn-id: https://develop.svn.wordpress.org/trunk@29782 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 04:53:07 +00:00
Scott Taylor 23f7f53be2 The joys of `wptexturize()`:
* Revert parts of [28773] and [28727] and [29748].
* Do not crash PHP. Make the shortcode quantifier possessive to avoid backtracks.
* Reduce backtracking in long HTML comments by 100x.
* Do not ignore unclosed HTML comments.
* Do not break unregistered shortcodes, e.g. `[hello attr="value"]`.
* Do not break HTML in shortcode attributes, e.g. `[hello attr="<"]`.
* Do not match for shortcodes when there is extra whitespace, e.g. `[ hello ]`.
* Add unit tests to show #12690 was not fully resolved.
* Tested PHP 5.2.4, 5.2.13, 5.4.32, and 5.5.8.

Adds/modifies unit tests.

Props miqrogroove.
See #29557.


git-svn-id: https://develop.svn.wordpress.org/trunk@29781 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 04:06:54 +00:00
Scott Taylor 18adbb6439 In `paginate_links()`, ensure that query string args are propagated to the resulting paginated links.
Adds unit tests that use `DOMDocument` since `assertTag` is being deprecated - see #29545, [29746].

Props obenland, wonderboymusic.
Fixes #29636.


git-svn-id: https://develop.svn.wordpress.org/trunk@29780 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 04:02:23 +00:00
Scott Taylor d19b2ded94 Add `size` to the UI for Gallery Settings in the media modal. Ensure that the TinyMCE view is refreshed when size changes.
Props richardmtl, noplanman, wonderboymusic.
Fixes #18143.


git-svn-id: https://develop.svn.wordpress.org/trunk@29779 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 03:44:25 +00:00
Scott Taylor 0fe756a461 Allow bookmarks to be ordered by `link_description` in `get_bookmarks()`.
Fixes #29763.


git-svn-id: https://develop.svn.wordpress.org/trunk@29778 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 03:11:55 +00:00
Scott Taylor d1fe8a8152 Media Grid: when the modal is open, don't respond to arrow keys when `<textarea>` has focus.
Props ryelle.
Fixes #29725.


git-svn-id: https://develop.svn.wordpress.org/trunk@29777 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 02:59:40 +00:00
Andrew Ozz 3b757232d0 Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29776 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 00:13:47 +00:00
Sergey Biryukov 2e58e91dcc Remove unnecessary CSS overriding on Add Plugins screen.
props pavelevap.
fixes #29753.

git-svn-id: https://develop.svn.wordpress.org/trunk@29775 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-28 20:25:33 +00:00
Sergey Biryukov 9e5beefd72 Don't display an empty comment author IP link on Comments screen.
props afercia.
fixes #29766.

git-svn-id: https://develop.svn.wordpress.org/trunk@29774 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-28 06:37:10 +00:00
Sergey Biryukov 5f0598234b Use Tahoma for RTL in general and Arial for Hebrew in editor styles.
fixes #29553.

git-svn-id: https://develop.svn.wordpress.org/trunk@29773 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-27 11:10:01 +00:00
Sergey Biryukov f5a904c46a Twenty Fourteen: Include Latin Extended font subset for Lato.
fixes #29690.

git-svn-id: https://develop.svn.wordpress.org/trunk@29772 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-27 10:15:25 +00:00
Sergey Biryukov e2eebecfc6 Bundled themes: Prevent the arrow in "Continue reading" links from wrapping to a second line.
props DustinHartzler, dominik.schwind.
fixes #27908.

git-svn-id: https://develop.svn.wordpress.org/trunk@29771 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-27 08:01:35 +00:00
Andrew Ozz d34a54f1e4 Fix tapping on the menu in iOS and Android, fixes #29365 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@29770 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 23:01:52 +00:00
Sergey Biryukov 1c8658f620 Use correct i18n function after [29768].
props TobiasBg.
fixes #29751.

git-svn-id: https://develop.svn.wordpress.org/trunk@29769 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 20:53:12 +00:00
Sergey Biryukov a86e98ba96 Merge two similar strings.
props pavelevap.
fixes #29751.

git-svn-id: https://develop.svn.wordpress.org/trunk@29768 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 19:29:59 +00:00
Sergey Biryukov c993055800 Remove extra space from a string.
props pavelevap.
fixes #29752.

git-svn-id: https://develop.svn.wordpress.org/trunk@29767 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 18:48:05 +00:00
Andrew Ozz 27806558a2 TinyMCE wpView: when pasting/inserting content before a view, add new paragraph above it and insert the content there. Props avryl, fixes #29380 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@29766 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-26 00:20:28 +00:00
Sergey Biryukov 3226d8b867 Create correct permalinks for child posts of hierarchical post types when default permalinks are used.
props loushou.
fixes #29615 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29765 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-24 21:29:15 +00:00
Sergey Biryukov fe6f5b3af3 Add context for 'Trash' string in media modal.
props pavelevap.
fixes #29739.

git-svn-id: https://develop.svn.wordpress.org/trunk@29764 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-24 13:48:27 +00:00
Drew Jaynes (DrewAPicture) 198db28c17 Improve and clarify inline commenting inside the `check_comment()` function.
Adds logical explanations of what some of the various comment checks are checking for, as well as some general cleanup and syntax fixes.

Fixes #29734.


git-svn-id: https://develop.svn.wordpress.org/trunk@29763 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 18:48:31 +00:00
Drew Jaynes (DrewAPicture) 0adb5f14aa Improve documentation in the `check_comments()` docblock.
* Removes two duplicate sentences from the long description
* Tightens up phrasing elsewhere in the long description for specific checks
* Clarifies the parameter and return descriptions, and adds periods

See #29734.


git-svn-id: https://develop.svn.wordpress.org/trunk@29762 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 18:46:52 +00:00
Scott Taylor 0b0eb4fb20 Ordering by `RAND()`:
The shortcode callbacks for `gallery` and `playlist` check for `'RAND' == $atts['order']`, which isn't a valid value for `order`. Remove those checks and update the docs.

In `WP_Query`, if the value of `orderby` is `rand`, `order` is irrelevant and should be unset.

Adds unit tests.

Fixes #29629.


git-svn-id: https://develop.svn.wordpress.org/trunk@29760 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:51:24 +00:00
Scott Taylor af71d22742 Add two properties to `media.model.Attachments.propmap`: `include` and `exclude`, which are aliases for `post__in` and `post__not_in`.
This allows you to instantiate a library that includes and/or excludes specific attachments by passing a single ID or an array of IDs.

Example usage:
{{{
wp.media({frame: 'post', library: {include: [414, 415]}}).open()
wp.media({frame: 'post', library: {include: 414}}).open()
wp.media({frame: 'post', library: {exclude: [414, 415]}}).open()
wp.media({frame: 'post', library: {exclude: 414}}).open()
}}}

Fixes #26587.


git-svn-id: https://develop.svn.wordpress.org/trunk@29759 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:37:06 +00:00
Scott Taylor 22db82dff1 In `wp_ajax_replyto_comment()`, if `$_POST['comment_type']` is set, use it for the value of `$comment_type`, which the `compact()` call has assumed is set since [8720]. It never was.
`wp_comment_reply()`'s output can be complete overridden by the `wp_comment_reply` filter, so this check is justified and makes the AJAX callback more flexible.

Props nerrad.
Fixes #29704.


git-svn-id: https://develop.svn.wordpress.org/trunk@29758 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 03:28:51 +00:00
Scott Taylor e97e5048c3 If the current user does not have the `delete_posts` cap on the current post type, don't list `delete` or `trash` as bulk actions for the relevant context of Post list table.
Props mvd7793.
Fixes #20175.


git-svn-id: https://develop.svn.wordpress.org/trunk@29757 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 02:57:43 +00:00
Scott Taylor f00f28cce0 `wp_extract_urls()` needs to also grab URLs with query strings and hashes.
Updates unit test.

Props hauvong, dlh.
Fixes #29314.


git-svn-id: https://develop.svn.wordpress.org/trunk@29756 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-23 02:49:22 +00:00