Commit Graph

33177 Commits

Author SHA1 Message Date
Boone Gorges
3a9bc32949 Ensure 'description' is a string in wp_insert_term().
Passing `'description' => null` when creating a term can cause MySQL notices,
as the description column in the terms table does not allow for null values.
We correct this by intepreting a `null` description as an empty string.

Props TimothyBlynJacobs.
Fixes #35321.

git-svn-id: https://develop.svn.wordpress.org/trunk@36214 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-07 03:31:48 +00:00
Konstantin Obenland
c67abd1c66 Plugins: Avoid ID attribute collisions in plugins list table.
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.

Props khag7.
Fixes #18974.



git-svn-id: https://develop.svn.wordpress.org/trunk@36205 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 22:39:23 +00:00
Konstantin Obenland
58b35571bb Themes: Avoid changing the count of themes with updates in network admin.
Makes the count bubble selector a little more specific to avoid interfering
with the admin menu, but not too specific for installed theme searches not to
update the bubble.

See [29786], [31495].
Fixes #35332.



git-svn-id: https://develop.svn.wordpress.org/trunk@36204 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 22:31:46 +00:00
Aaron Jorbin
9e91f753f8 Theme: Escape error messages
git-svn-id: https://develop.svn.wordpress.org/trunk@36185 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 17:22:08 +00:00
Dion Hulse
549c4fdd1d Unit Tests: Fix the unit test added in [36181] to include the index in the comparison.
See #35235


git-svn-id: https://develop.svn.wordpress.org/trunk@36183 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 08:09:51 +00:00
Dion Hulse
3e85247571 Updates: Don't perform an API call to WordPress.org for every plugin update displayed. The API has been updated to return this information with the update response.
See #35301


git-svn-id: https://develop.svn.wordpress.org/trunk@36182 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 07:52:53 +00:00
Pascal Birchler
e055e5b80e Rewrite: Add a remove_permastruct() helper function.
It can be used to remove permastructs that were added using `add_permastruct()`.

Fixes #35235.

git-svn-id: https://develop.svn.wordpress.org/trunk@36181 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 07:39:29 +00:00
Dion Hulse
ce4ef49b10 Background Updates: Remove the 7am/7pm background update check. This check was made redundant by [28129] as background updates are now run after a version check takes place.
See #27772, #35323.


git-svn-id: https://develop.svn.wordpress.org/trunk@36180 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-06 06:11:46 +00:00
Dominik Schilling (ocean90)
cd6cc5c7db Bundled Themes: Bump version number of Twenty Thirteen.
Props davidakennedy.
Fixes #35319.

git-svn-id: https://develop.svn.wordpress.org/trunk@36179 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 22:19:41 +00:00
Dominik Schilling (ocean90)
36cf8b2932 Install: Use new colors for error notices.
Props duaneblake, DBrumbaugh10Up.
Fixes #34704.

git-svn-id: https://develop.svn.wordpress.org/trunk@36178 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 21:46:29 +00:00
Pascal Birchler
e50296de48 Query: Add a WP::remove_query_var() helper function.
This makes cleaning up public query vars easier.

Fixes #35234.

git-svn-id: https://develop.svn.wordpress.org/trunk@36177 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 20:56:10 +00:00
Dominik Schilling (ocean90)
e306e801a9 Install: Only enqueue scripts when necessary.
Props flixos90 for initial patch.
Fixes #34700.

git-svn-id: https://develop.svn.wordpress.org/trunk@36176 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 16:41:43 +00:00
Dominik Schilling (ocean90)
9d45966095 Docs: Move the hook doc for the the_title filter in Walker_Page::start_el() to directly precede the apply_filters() line.
See #32246.

git-svn-id: https://develop.svn.wordpress.org/trunk@36175 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 16:34:25 +00:00
Dominik Schilling (ocean90)
3f5fab4a0e Nav Menus: Apply the the_title filter on original post titles in wp_setup_nav_menu_item().
The filter is already used in `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit`. This ensures that titles are consistent across the admin and front end.

Fixes #35317.

git-svn-id: https://develop.svn.wordpress.org/trunk@36174 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 16:26:53 +00:00
Rachel Baker
693a5b793f Comments: Remove orphaned closing td tag within cancel button of Moderate Comment screen.
Left behind in r31641. See #23988.

Props ash.matadeen.


git-svn-id: https://develop.svn.wordpress.org/trunk@36173 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 16:06:54 +00:00
Andrea Fercia
0eba218570 Accessibility: Remove title attributes from the Admin Dashboard.
Uses `aria-label` and `screen-reader-text` where appropriate. Also removes
the default title attribute output by `privacy_on_link_title`, preserving
the ability to use the filter.

Fixes #35049.

git-svn-id: https://develop.svn.wordpress.org/trunk@36172 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 14:18:57 +00:00
Andrea Fercia
3a9259a4c4 Introduce a new generic CSS clearfix utility class.
`.wp-clearfix` is now the recommended way to clear and contain floated elements.
Adds back compatibility for the `.nav-tab-wrapper` navigation tabs.

See #26396.

git-svn-id: https://develop.svn.wordpress.org/trunk@36171 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-05 13:37:56 +00:00
Konstantin Obenland
0d6514b28b Template: Always display the site title on the front page.
Limits using the page title to the blog page when the site has a static front page,
bringing it N’Sync with `wp_title()`.

Props peterwilsoncc.
Fixes #34962.



git-svn-id: https://develop.svn.wordpress.org/trunk@36168 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-04 17:15:31 +00:00
Andrew Ozz
f891bb32f2 Media: when inserting an attachment in the editor and it is not an image, ensure the link is set to something else than none.
Props eherman24, azaozz.
Fizes #35153 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36166 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-04 00:32:56 +00:00
Andrew Nacin
5699c64a56 XML-RPC: Revert [34681] as it broke date handling.
props dossy, hnle, redsweater.
see #35053, #30429 (original ticket).


git-svn-id: https://develop.svn.wordpress.org/trunk@36163 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 19:48:07 +00:00
Andrea Fercia
a12087bf0f Media: set the image editor spinner on the smallest possible area.
When using spinners as background images, the re-painted area should be the smallest
possible one. See similar performance issue in #31196, #33311, #33322, and #34951.

Fixes #35296.

git-svn-id: https://develop.svn.wordpress.org/trunk@36162 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 16:48:47 +00:00
Gary Pendergast
59d442f921 Emoji: Add a test to the emoji loader, to see if the browser supports emoji diversity. If it doesn't, fall back to twemoji.
See #33592.



git-svn-id: https://develop.svn.wordpress.org/trunk@36160 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 04:25:52 +00:00
Boone Gorges
23b10789d4 Fix incorrect @covers annotation in get_adjacent_post() tests.
Introduced in [36077].

Props netweb.
Fixes #35211.

git-svn-id: https://develop.svn.wordpress.org/trunk@36159 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 02:43:18 +00:00
Boone Gorges
1b8c0d611a Ensure that non-default pagination values work in wp_list_comments().
Prior to 4.4, it was possible to pass 'page' and 'per_page' values to
`wp_list_comments()` that do not match the corresponding global query vars.
This ability was lost in 4.4 with the refactor of how `comments_template()`
queries for comments; when the main comment query started fetching only the
comments that ought to appear on a page, instead of all of a post's comments,
it became impossible for the comment walker to select comments corresponding to
custom pagination parameters. See #8071.

We restore the previous behavior by (a) detecting when a 'page' or 'per_page'
parameter has been passed to `wp_list_comments()` that does not match the
corresponding query vars (so that the desired comments will not be found in
`$wp_query`), and if so, then (b) querying for all of the post's comments and
passing them to the comment walker for pagination, as was the case before 4.4.

Props boonebgorges, smerriman.
Fixes #35175.

git-svn-id: https://develop.svn.wordpress.org/trunk@36157 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 02:02:59 +00:00
Dominik Schilling (ocean90)
d47319710c Docs: Remove indentation from the hidden_columns changelog entry.
Added in [36154].

See #35057.

git-svn-id: https://develop.svn.wordpress.org/trunk@36156 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-02 15:15:53 +00:00
Dion Hulse
84cb626eb6 List Tables: When a user has hidden all columns, do not override that with the default_hidden_columns filter.
Props Compute, jorbin, voldemortensen.
Fixes #35057


git-svn-id: https://develop.svn.wordpress.org/trunk@36154 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-02 04:43:07 +00:00
Sergey Biryukov
c7e1a2ee6d Docs: Correct get_page_uri() description.
Props ericlewis.
Fixes #35165.

git-svn-id: https://develop.svn.wordpress.org/trunk@36143 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-01 18:28:17 +00:00
Andrea Fercia
fa39accb99 Accessibility: Don't mark up "URL" as an abbreviation.
"URL" has essentially entered language as a self-contained concept, there's
no more need to expand it with an `<abbr>` element and a title attribute.

Fixes #35174.

git-svn-id: https://develop.svn.wordpress.org/trunk@36142 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-01 12:10:00 +00:00
Gary Pendergast
cebe17e35b Bump the license.txt year to 2016.
Happy New Year, all y'all!


git-svn-id: https://develop.svn.wordpress.org/trunk@36141 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-01 09:59:14 +00:00
Sergey Biryukov
85120aa0a1 Export: Add a missing Oxford comma.
Props juhise.
Fixes #35275.

git-svn-id: https://develop.svn.wordpress.org/trunk@36140 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 19:32:06 +00:00
Rachel Baker
ea9451bd1c Docs: Add null to post_id param type, fix syntax, and descriptions in the DocBlock for wp_update_comment_count().
See #32246.



git-svn-id: https://develop.svn.wordpress.org/trunk@36139 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 19:20:21 +00:00
Rachel Baker
21a4585cd1 Feeds: Comments on attachments display in the site-wide comments RSS feed.
Individual attachment pages already have their own RSS comment feed, and would be expected to be included in the site-wide comments RSS feed.

Props jbrinley. 
Fixes #15610



git-svn-id: https://develop.svn.wordpress.org/trunk@36138 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 17:15:23 +00:00
Andrea Fercia
93e3093a0a Admin: Restore the "Show advanced menu properties" checkboxes IDs.
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.

Fixes #35112 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36137 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 11:51:09 +00:00
Pascal Birchler
7ce16f660e Twenty Thirteen: Add missing loop in the image attachment template.
Props vtieu.
Fixes #35110.

git-svn-id: https://develop.svn.wordpress.org/trunk@36136 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 11:38:43 +00:00
Pascal Birchler
b62421681e Docs: Improve readability of the default arguments of wp_list_categories().
Adds missing documentation for the `separator` argument introduced in [35140].

Props birgire for initial patch.
Fixes #34751.

git-svn-id: https://develop.svn.wordpress.org/trunk@36135 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 11:29:19 +00:00
Andrea Fercia
b2b14848d6 Admin: fix repositioning of notices when the first header is not an immediate children of .wrap.
Props DvanKooten for the initial patch.
Fixes #35047 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36134 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 11:04:38 +00:00
Dion Hulse
a1b31b59c4 XMLRPC: Revert [35509] which caused a change of behviour in at least one XMLRPC client.
XMLRPC has many quirks in it's operation, #16980 being just one of the many, #35185 just became yet another quirk.

See #16980.
Fixes #35185.


git-svn-id: https://develop.svn.wordpress.org/trunk@36132 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 04:05:22 +00:00
Sergey Biryukov
c04ae32ff9 Widgets: Revert [34465], as it introduced a regression, making the $index argument of dynamic_sidebar() case-sensitive.
Fixes #34995 for trunk. See #23423.

git-svn-id: https://develop.svn.wordpress.org/trunk@36130 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 03:12:36 +00:00
Gary Pendergast
a9dcce7060 Redirects: Prevent redirects if a queried object exists.
After [34659], it became possible to cause an incorrect redirect, by changing the slug of a post, then creating a new post with the old slug. The correct behaviour is to prevent redirecting to the old post.

Props dd32, pento.

Fixes #35031 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36128 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 03:00:33 +00:00
Sergey Biryukov
cf82d2ef2b Query: Remove a stray debug line from WP_Query::get_posts().
Props dlh.
Fixes #35271.

git-svn-id: https://develop.svn.wordpress.org/trunk@36127 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 02:22:26 +00:00
Gary Pendergast
873326b7eb Emoji: Update emoji support to Unicode 8.0, including the Diversity set.
Fixes #33592.



git-svn-id: https://develop.svn.wordpress.org/trunk@36126 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 01:29:12 +00:00
Pascal Birchler
aae9afe5aa Comments: Don't nofollow links within the site.
Fixes #11360.

git-svn-id: https://develop.svn.wordpress.org/trunk@36125 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 23:19:11 +00:00
Pascal Birchler
4f6d5aa034 Plugins: Add a new pre_uninstall_plugin action that runs right before uninstalling a plugin.
Fixes #34569.

git-svn-id: https://develop.svn.wordpress.org/trunk@36124 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 22:37:49 +00:00
Pascal Birchler
bb07293f8c Embeds: Change attachment metadata condition to prevent a warning in the embeds template.
Fixes #35237.

git-svn-id: https://develop.svn.wordpress.org/trunk@36123 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 22:24:31 +00:00
Andrea Fercia
a03aa810c5 Media: Fix icons for HiDPI displays on the media modal after [32952].
Props vtieu.
Fixes #35200.

git-svn-id: https://develop.svn.wordpress.org/trunk@36122 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 18:31:41 +00:00
Andrew Ozz
8686ab4a7a Responsive images: fix the check whether the attachment meta matches the image src to work with http/https and CDNs.
Props webaware, joemcgill, azaozz.
Fixes #35045 and #35102 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36121 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 01:03:11 +00:00
Andrew Ozz
f39a799718 Responsive images: add compatibility for versions < 2.7 when the full image path was stored in the metadata. Introduces _wp_get_attachment_relative_path() and uses it in wp_get_attachment_url().
Props dd32, SergeyBiryukov.
Fixes #35106 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36120 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 00:05:07 +00:00
Aaron Jorbin
d65a4e6498 Ensure only approved comments trigger post author notifications
Posts that are trashed shouldn't trigger post author notifications.  Adds unit tests to enforce this.

Props scottbrownconsulting, peterwilsoncc, swissspidy
Fixes #35006



git-svn-id: https://develop.svn.wordpress.org/trunk@36119 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-29 17:53:23 +00:00
Dion Hulse
18a6a047bd Tests: After [36100] use an object style which is compatible with PHP5 get_object_vars().
See #35058.


git-svn-id: https://develop.svn.wordpress.org/trunk@36117 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-29 05:43:05 +00:00
Gary Pendergast
f46c0a637b Tests: When testing the utf8mb4 charset, ensure that the current MySQL server has utf8mb4 support.
See #35249.



git-svn-id: https://develop.svn.wordpress.org/trunk@36116 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-29 04:39:02 +00:00