Commit Graph

4064 Commits

Author SHA1 Message Date
Andrew Nacin
9d5bd5f7eb Use wp_safe_remote_request() and friends instead of reject_unsafe_urls = true.
fixes #24646.



git-svn-id: https://develop.svn.wordpress.org/trunk@24917 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-31 06:52:13 +00:00
Andrew Nacin
cafccbea91 Add missing gettext. This is not a new string; it already exists a few lines up. props alex-ye, fixes #24880.
git-svn-id: https://develop.svn.wordpress.org/trunk@24885 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 19:48:41 +00:00
Andrew Nacin
b725127d21 Rename post_lock_text hook to post_locked_dialog, and lock_taken_over_dialog to post_lock_lost_dialog. fixes #24830 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@24884 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 19:40:13 +00:00
Aaron D. Campbell
cf89623e16 Make the show_post_locked_dialog filter hide both the post locked and post taken over dialogs
props azaozz, DH-Shredder. Fixes #24830 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@24883 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 19:25:26 +00:00
Mark Jaquith
1891cf880f Delete old autosave if new autosave has same content as the post.
Props nacin. Fixes #7392 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@24878 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 19:06:08 +00:00
Jon Cave
707bd3ae4a Fix potential SQLi through improper use of API functions.
git-svn-id: https://develop.svn.wordpress.org/trunk@24875 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 18:16:47 +00:00
Andrew Nacin
19bc573d35 Fix pass by reference issue. see #24873.
git-svn-id: https://develop.svn.wordpress.org/trunk@24866 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 17:53:24 +00:00
Mark Jaquith
7c99f40451 Revisions: Fix PHP loading of comparison to first revision, and premature rendering of tooltip.
Props aaroncampbell, markjaquith. Fixes #24873 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@24864 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 17:26:03 +00:00
Andrew Nacin
5a7fb9b5b0 Remove unnecessary cap checks from [24854]. You need these capabilities (or equivalent) to access the screens for these feature pointers. see #24832.
git-svn-id: https://develop.svn.wordpress.org/trunk@24855 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 06:43:30 +00:00
Mark Jaquith
b92460a7c1 Tooltips for 3.6 features: Revisions, Post Locking.
Props siobhan. See #24832 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@24853 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 06:17:01 +00:00
Mark Jaquith
47eca52e74 Fix wrong use of esc_html_e().
Props ocean90. Fixes #24854 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@24840 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-29 01:00:59 +00:00
Mark Jaquith
68c9199819 Rename the new 'left'/'right' flags on the _wp_post_revision_field_$field filter to 'from'/'to'.
Fixes #24848 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@24835 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-28 23:28:21 +00:00
Andrew Nacin
438002864f Terms list table: Only show 'View' links for public taxonomies. props SergeyBiryukov. fixes #24692.
git-svn-id: https://develop.svn.wordpress.org/trunk@24824 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-28 21:06:19 +00:00
Mark Jaquith
2c63d1b494 Remove our revisions easter egg, as it doesn't have a place in our new UI.
There will be opportunities for other easter eggs. This one has had its decade.

Fixes #24852 for trunk. Props noahsilverstein.

git-svn-id: https://develop.svn.wordpress.org/trunk@24820 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-28 20:56:14 +00:00
Andrew Ozz
50b8437d59 Add "experimental" to heartbeat phpdoc, fixes #24855 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@24818 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-28 20:54:48 +00:00
Jon Cave
05cbd5ec91 Remove unnecessary secret_salt_warning().
If salts/keys are not defined in wp-config.php then they will be generated
automatically and stored in the database. [19771] also deals with values
that are duplicated or set to default.

Fixes #14803.


git-svn-id: https://develop.svn.wordpress.org/trunk@24813 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-28 19:45:57 +00:00
Mark Jaquith
405b7726ae Add some missing PHPDoc @since lines.
Fixes #24742. Props DrewAPicture.

git-svn-id: https://develop.svn.wordpress.org/trunk@24804 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-27 23:11:03 +00:00
Andrew Nacin
1fd6c87716 Don't show "Preview" for locked, non-public post types. props aaroncampbell. fixed #24139.
git-svn-id: https://develop.svn.wordpress.org/trunk@24799 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-27 06:57:42 +00:00
Mark Jaquith
30a17c9ab9 Reinstate 'label' property of nav menu items. Fixes a regression from [22234].
Fixes #24840. Props johnbillion.

git-svn-id: https://develop.svn.wordpress.org/trunk@24798 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-27 06:50:59 +00:00
Andrew Nacin
5ca8aa7447 Revisions changes.
* Eliminates the bloated Revisions meta box in favor of 'Revisions: #' in the publish box.
 * Adds ability to compare autosave to current post, when revisions are disabled.
 * Makes autosaves stand out visually, including "Restore This Autosave".

Also:
 * Adds missing capability check for restoring a revision.
 * When no revision matches the post's current modified time, avoid marking an autosave as 'current'.
 * Fixes wp_get_post_autosave() to return an autosave even when revisions are disabled.
 * Add 'check_enabled' arg to wp_get_post_revisions(); false avoids the wp_revisions_enabled() check.
 * Adds a responsive slider that is narrower for fewer versions. props markjaquith.

see #24804.



git-svn-id: https://develop.svn.wordpress.org/trunk@24790 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-24 06:08:14 +00:00
Andrew Nacin
abb0f1d882 Remove curly quotes from auto content generation for audio tracks on upload. Texturize should be doing this on display.
props tollmanz.
fixes 24810.



git-svn-id: https://develop.svn.wordpress.org/trunk@24788 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-24 05:47:00 +00:00
Andrew Nacin
0f052ef6af Do set_url_scheme() for Preview action link in the posts list table. props reidburke, fixes #23886.
git-svn-id: https://develop.svn.wordpress.org/trunk@24780 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-23 15:04:55 +00:00
Andrew Nacin
65cc9c5d2a Media: Add awareness to Attachment Display Settings that audio and video can be embedded.
Also:
 * Add file length metadata to Attachment Details.
 * Round the kb/s bitrate on post.php.

fixes #24449.



git-svn-id: https://develop.svn.wordpress.org/trunk@24777 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-23 05:39:08 +00:00
Andrew Nacin
841d93ed30 Move _local_storage_notice() to admin/includes/template.php. props azaozz, see #24756.
git-svn-id: https://develop.svn.wordpress.org/trunk@24762 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-22 05:09:49 +00:00
Mark Jaquith
56f1a3fa32 Revisions: Pinned controls, layout tweaks, copy tweaks, misc.
* When you scroll down the diff view, the controls will pin to the top.
* The revisions meta view was cleaned up. Copy changes.
* Loading indicator in the center of the screen (so it follows as you scroll).
* Tooltips "flip" when you cross the center line, so that they don't hit the container edge and wrap for later revisions.
* The "Restore" button's inactive state is handled on render, instead of after.
* Make sure we always have a current revision, even if the timestamp doesn't work out on the most recent one.

See #24804. Props markjaquith, nacin, ocean90, aaroncampbell.

git-svn-id: https://develop.svn.wordpress.org/trunk@24761 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-22 05:05:45 +00:00
Mark Jaquith
8415e7f1fe Fixes and tweaks for the metabox accordion.
* Fixed hover issues in Customizer.
* Toned down the default active/hover style (as it is normally not the top level menu, and should not be so prominent).
* Allow the active section to be closed.
* Other misc fixes.

Props ocean90, helen. Fixes #23449.

git-svn-id: https://develop.svn.wordpress.org/trunk@24734 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-18 17:42:53 +00:00
Andrew Nacin
387d9cb94c If two revisions were created at the same time, mark the one with the greater ID as current. Also avoid flagging autosaves as current. fixes #24782.
git-svn-id: https://develop.svn.wordpress.org/trunk@24730 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-18 14:10:33 +00:00
Andrew Nacin
1b52b238ea Remove stray character.
git-svn-id: https://develop.svn.wordpress.org/trunk@24726 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-17 21:09:14 +00:00
Peter Westwood
507b203597 Fix a strict standards error in the plugin search when search for an already installed plugin.
Fixes #24747 props SergeyBiryukov.


git-svn-id: https://develop.svn.wordpress.org/trunk@24725 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-17 21:08:05 +00:00
Andrew Nacin
abe5b62fb0 Inline docs for admin/includes/revision.php. props DrewAPicture, fixes #24742.
git-svn-id: https://develop.svn.wordpress.org/trunk@24722 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-17 20:39:35 +00:00
Andrew Nacin
25708e95f1 Use wp_slash() in places where we improperly used the DB API instead. see #21767.
git-svn-id: https://develop.svn.wordpress.org/trunk@24713 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-16 14:19:03 +00:00
Mark Jaquith
674de51926 Improvements to output of revisions author data.
* Do not output "false" if avatars are disabled. props ocean90.
* Cache the author data separately to cut down on calls to `get_the_author_meta()` and `get_avatar()`. props nacin.

Fixes #24743.

git-svn-id: https://develop.svn.wordpress.org/trunk@24708 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-15 23:01:27 +00:00
Mark Jaquith
a41e9055b1 No PHP time limit when generating diffs.
Fixes #24757. Props nacin.

git-svn-id: https://develop.svn.wordpress.org/trunk@24707 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-15 22:53:48 +00:00
Dominik Schilling (ocean90)
78f4ece66c Nav Menus: Hide the rearrange section in no-js. see #14045.
git-svn-id: https://develop.svn.wordpress.org/trunk@24702 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-13 16:38:14 +00:00
Andrew Nacin
4f458cb0d8 ID3 1.9.7.
props wonderboymusic.
fixes #24737.



git-svn-id: https://develop.svn.wordpress.org/trunk@24696 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-13 00:37:36 +00:00
Helen Hou-Sandi
f04053fdd8 Tweaks to the accordion:
* Enqueues JS in `do_accordion_sections()`.
* Top and bottom rounded corners for the nav menu accordion.
* Better RTL and no-JS.

props lessbloat, DrewAPicture, aaroncampbell, helen. fixes #23449.


git-svn-id: https://develop.svn.wordpress.org/trunk@24680 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 18:16:29 +00:00
Andrew Nacin
48b64ab3e2 Remove 'sorted' from do_accordion_sections(). fixes #23450.
git-svn-id: https://develop.svn.wordpress.org/trunk@24674 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 15:43:00 +00:00
Mark Jaquith
3584dd58a9 Revisions: Cleanup, bug fixes, refactoring, polish.
* Hide the tooltip initially.
* Fix a bug with routing.
* Further separate the Slider model and view, refactoring its code.
* More reliance on events than direct calls between areas.
* Smarter background diff loading (single mode). Loads the diffs closest to your position first.
* Removed a bunch of manual templating and `render()` methods. Now relies more on the WP Backbone Views functionality.
* include the requested `id` in `ensure:load`.
* new trigger: `ensure`, for `ensure()` attempts, regardless of whether they are already loaded.
* pass along a promise in both `ensure` and `ensure:load`.
* in `ensure`, remove requests for diffs we aready have

See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24671 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 14:01:39 +00:00
Mark Jaquith
b7e1e25e36 Fix a PHP 5.4-ism that slipped in.
git-svn-id: https://develop.svn.wordpress.org/trunk@24670 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 07:26:11 +00:00
Mark Jaquith
2e2ed518e9 Revisions: sort by date, not modified, to match revisions meta box.
See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24668 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 05:41:39 +00:00
Mark Jaquith
d88021e236 Revisions: Loading indicator, cleanup, bug fixes.
* Loading indicator when the user is waiting for a trip to the server.
* Bug fixes for diff priming.
* Fix the date display.
* Forget about local comparator, instead order by `modified` on the server.
* Initialize the frame model before the view (this was the source of a LOT of heartache).

git-svn-id: https://develop.svn.wordpress.org/trunk@24667 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 05:11:56 +00:00
Mark Jaquith
1fb9b2cfa1 Revisions: real URLs and preloading of the requested diff.
* Real URLs are being used now, using pushState. `?revision={id}` or `?from={from}&to={to}`.
* Drop the redundant `action=edit` from the URLs (this is the default).
* The initial comparison is preloaded, whether a single revision or a compare-two situation.

See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24664 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-11 22:56:48 +00:00
Andrew Nacin
05006a0da4 Compare GMT to GMT. see #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24663 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-11 20:57:47 +00:00
Andrew Nacin
b970bdd914 Modify todo in wp_ajax_autosave(). fixes #23665.
git-svn-id: https://develop.svn.wordpress.org/trunk@24651 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-11 00:06:52 +00:00
Andrew Nacin
e01a1a94bb Proper translation of '<time> ago' in revisions. props johnbillion, fixes #24721.
git-svn-id: https://develop.svn.wordpress.org/trunk@24643 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-10 16:15:18 +00:00
Andrew Nacin
381110d9f2 Fix the chown and chgrp methods for the filesystem API's SSH2 transport. fixes #24277.
git-svn-id: https://develop.svn.wordpress.org/trunk@24626 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-10 04:15:13 +00:00
Andrew Nacin
0fc3503f69 Use maybe_unserialize() in upgrade.php's private get_option() function. This actually predates maybe_unserialize() ([2487], [3234]). props leewillis77. fixes #24365.
git-svn-id: https://develop.svn.wordpress.org/trunk@24625 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-10 04:01:20 +00:00
Mark Jaquith
8dfbe56e79 Pass back dateUnix (a unix timestamp) for better sorting of revisions in Backbone.
Props duck_. See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24615 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 19:21:25 +00:00
Andrew Nacin
7d0019d495 In populate_options(), only query the option names we are checking against. No need to load the entire table into memory. props leewillis77. fixes #24620.
git-svn-id: https://develop.svn.wordpress.org/trunk@24614 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 19:14:33 +00:00
Daryl Koopersmith
286a44fcf6 Revisions: Debounce fetching Diffs when revisions are updated.
Fixes navigation and casting bugs.

See #24425.


git-svn-id: https://develop.svn.wordpress.org/trunk@24611 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 09:57:58 +00:00