Commit Graph

27248 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
080f52ceb9 Revert [28894] as it's currently unused in core.
see #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29309 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:15:22 +00:00
Dominik Schilling (ocean90)
0e42ce2dc0 Add missing screen-reader-text CSS class in [29294].
see #28867.

git-svn-id: https://develop.svn.wordpress.org/trunk@29308 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 13:42:49 +00:00
Dominik Schilling (ocean90)
db77bc8bff Media Grid: Align "Apply" button on small screens.
fixes #28903.

git-svn-id: https://develop.svn.wordpress.org/trunk@29307 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 12:14:58 +00:00
Dominik Schilling (ocean90)
3003895858 Fix jshint errors introduced in [29284] and [29299].
git-svn-id: https://develop.svn.wordpress.org/trunk@29306 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 11:48:26 +00:00
Dominik Schilling (ocean90)
812ecd9b8d Media Grid: Ignore user setting for content.
fixes #29034.

git-svn-id: https://develop.svn.wordpress.org/trunk@29305 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 11:43:08 +00:00
Dominik Schilling (ocean90)
cb5838a937 Media Grid: Improve dropzone margins when viewport height is <400px.
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29304 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 15:29:39 +00:00
Dominik Schilling (ocean90)
0480144f86 Media Grid: Add context for "or" in [29296].
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29303 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 14:36:56 +00:00
Andrew Ozz
42ac48d52a TinyMCE:
- Fix complex character input in Japanese, Chinese, etc. Was broken in getCursorOffset() in editor-expand.js.
- Disable auto-scrolling in some edge cases when editor expanding is enabled.
See #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29302 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 00:07:55 +00:00
Helen Hou-Sandi
357d96c367 Don't interfere with browser-based autocomplete in the link modal. props SergeyBiryukov. fixes #28685.
git-svn-id: https://develop.svn.wordpress.org/trunk@29301 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 15:56:57 +00:00
Helen Hou-Sandi
59cec2e2ff When adding a post of a post type whose menu item is in a submenu, highlight the correct menu item. props mordauk, markjaquith. fixes #24137.
git-svn-id: https://develop.svn.wordpress.org/trunk@29300 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 15:25:20 +00:00
Scott Taylor
0b3802eb12 Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique.
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857.


git-svn-id: https://develop.svn.wordpress.org/trunk@29299 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:59:29 +00:00
Andrew Ozz
67032cf170 TinyMCE wpView:
- Fix opening the media modal on clicking Edit in Firefox.
- Fix range errors when restoring the selection bookmark in IE11 after editing a view.
See #28595.

git-svn-id: https://develop.svn.wordpress.org/trunk@29298 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:55:33 +00:00
Scott Taylor
e11d72f889 Media Grid: make check box-shadow more subtle.
See #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29297 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:46:14 +00:00
Scott Taylor
3fef7648f6 Media Grid: improve uploader styles.
Props michalzuber, ericlewis.
See #28851.


git-svn-id: https://develop.svn.wordpress.org/trunk@29296 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:30:28 +00:00
Scott Taylor
276496aa29 Media Grid: change text to "Close Media Panel" to provide context for screen readers.
Props joedolson.
Fixes #28976.


git-svn-id: https://develop.svn.wordpress.org/trunk@29295 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:25:16 +00:00
Scott Taylor
ced3f94927 Adds <label>s to current page selector and bulk actions <select> field so that screen readers have an explicit label.
Props joedolson.
Fixes #28867.


git-svn-id: https://develop.svn.wordpress.org/trunk@29294 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:19:21 +00:00
Scott Taylor
f0318988c4 Correct a few @param docs for $walker.
Props dnaber-de.
Fixes #29011.


git-svn-id: https://develop.svn.wordpress.org/trunk@29293 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:24:07 +00:00
Scott Taylor
6e74d46d94 Whitelist input types that are styled in the scope of .form-field.
Props mauteri.
Fixes #28647.


git-svn-id: https://develop.svn.wordpress.org/trunk@29292 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:21:00 +00:00
Scott Taylor
66c8ad501f Add exif orientation to data extracted in wp_read_image_metadata().
Props shanebp.
Fixes 28916.


git-svn-id: https://develop.svn.wordpress.org/trunk@29291 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:13:19 +00:00
Scott Taylor
1cbe1cec12 In sanitize_file_name(), replace %20 and + with dashes. Remove unnecessary code from _wp_handle_upload().
Adds unit tests.

Props ericmann.
Fixes #16330.


git-svn-id: https://develop.svn.wordpress.org/trunk@29290 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:08:09 +00:00
Scott Taylor
cdf2c8132c Media Grid: UI improvements to Attachment modal.
Props ryelle.
See #28844.


git-svn-id: https://develop.svn.wordpress.org/trunk@29289 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:54:22 +00:00
Scott Taylor
dd76aeea5b Media Grid: remove pencil icon from attachment hover and a bunch of unused CSS.
Fixes #28945.


git-svn-id: https://develop.svn.wordpress.org/trunk@29288 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:17:32 +00:00
Scott Taylor
1b01b92dc6 Media Grid CSS: Media modal close icon should be consistent with other modals.
Props celloexpressions.
Fixes #29012.


git-svn-id: https://develop.svn.wordpress.org/trunk@29287 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:06:42 +00:00
Scott Taylor
052e5c5062 Remove white box-shadow divider from uploading status area for consistency.
Props paulwilde.
Fixes #28751.


git-svn-id: https://develop.svn.wordpress.org/trunk@29286 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:03:25 +00:00
Scott Taylor
b1053cca13 Don't render Attachment Display Settings when display is set to false. Currently, the value for display in the media.view.AttachmentsBrowser instance in the media.view.MediaFrame.Select frame is set to the value for displaySettings.
These values do different things, so check for the existence of `display` on the state before arbitrarily setting it to the `displaySettings` value.

Real world: this hides display settings when you select an image while editing a Gallery.

Fixes #28653.


git-svn-id: https://develop.svn.wordpress.org/trunk@29285 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 20:57:05 +00:00
Scott Taylor
c2491f31ae When gallery settings are overridden, the JS-generated shortcodes need to check the new defaults before deleting attributes that it suspects are the same as the original default values.
`wp.media.collection` has a new method to do this: `setDefaults()`.	Also flips the use of `_.extend` to allow this method to be overriden on instance creation.

See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@29284 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 19:59:18 +00:00
Scott Taylor
530328ef59 The Underscore templates for Gallery settings should respect defaults when marking an <option> as selected.
See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@29283 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 19:34:53 +00:00
Scott Taylor
abc6b8c1d7 Media Grid: Manage focus when toggling between the grid and an edit attachment modal
Props adamsilverstein for the initial patch.
Fixes #28857.


git-svn-id: https://develop.svn.wordpress.org/trunk@29282 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 19:04:48 +00:00
Helen Hou-Sandi
2fd45b514b Set default values for attachment meta and ID3 data when preparing for JS to avoid errors in rendering templates. props ericmann for the initial patch. fixes #29013.
git-svn-id: https://develop.svn.wordpress.org/trunk@29281 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 18:03:58 +00:00
Helen Hou-Sandi
5698a9dc7e Media Grid: Remove fields from showing in the grid itself.
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29280 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 05:25:28 +00:00
Andrew Ozz
0a73faec46 Editor scrolling:
- Improve TinyMCE resizing when a floated block is at the end of the content.
- Improve setting the padding/margin under the toolbar on loading.
- Add custom event on TinyMCE resizing and use it to adjust the pinning (if needed).
Part props avryl, see #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29279 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 01:32:29 +00:00
Helen Hou-Sandi
3d3b141b30 Add support for attachment_fields_to_edit in the attachment details modal. props ericlewis. fixes #28991, see #24716.
git-svn-id: https://develop.svn.wordpress.org/trunk@29278 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 22:08:17 +00:00
Scott Taylor
15aaf0691a After [29179], remove the last instance of this.isCompatibleSrc().
Props kovshenin.
See #28905.



git-svn-id: https://develop.svn.wordpress.org/trunk@29277 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 17:53:07 +00:00
Drew Jaynes (DrewAPicture)
d9564736b8 Fix a typo in the PHPDoc for wp_register_sidebar_widget().
Props Jonnyauk.
Fixes #29007.


git-svn-id: https://develop.svn.wordpress.org/trunk@29276 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 17:20:10 +00:00
Drew Jaynes (DrewAPicture)
1e2fa2ddd3 Fix a typo in the PHPDoc for get_stylesheet().
Props lgedeon.
Fixes #28985.


git-svn-id: https://develop.svn.wordpress.org/trunk@29275 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 05:10:44 +00:00
Helen Hou-Sandi
c72d29e63e Revert [29267], as it causes unit test breakage and appears unnecessary. see #28986.
git-svn-id: https://develop.svn.wordpress.org/trunk@29274 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-23 02:22:57 +00:00
azaozz
2d466f4c86 wpView: make sure the editor is focused before selecting/deselecting a view, or IE may throw an invalid range error, see #28595.
git-svn-id: https://develop.svn.wordpress.org/trunk@29273 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 21:52:02 +00:00
Andrew Ozz
c2bd765b32 wpView: consolidate pausePlayers() and unsetPlayers(), they are almost the same. Prevent errors when instead of a player ME.js shows only a "Download File" placeholder (in IE). See #28905.
git-svn-id: https://develop.svn.wordpress.org/trunk@29272 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 21:48:41 +00:00
Dominik Schilling (ocean90)
cce3bdf920 Media Grid: Add a date filter.
props ericlewis.
fixes #28895.

git-svn-id: https://develop.svn.wordpress.org/trunk@29271 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 20:46:22 +00:00
Dominik Schilling (ocean90)
60732933f3 Update the versions of several devDependencies in package.json.
Run `npm update` in the project root to receive updates.

props mjbanks, jorbin, netweb.
see #27340.

git-svn-id: https://develop.svn.wordpress.org/trunk@29270 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 20:40:08 +00:00
Dominik Schilling (ocean90)
f5c0cf95e0 Fix jshint errors introduced in [29259]. see #11325.
git-svn-id: https://develop.svn.wordpress.org/trunk@29269 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 20:02:34 +00:00
Dominik Schilling (ocean90)
5bba352ae0 Media CSS: Fix typo in box-shadow property for WebKit and update indentation to match the other ones.
git-svn-id: https://develop.svn.wordpress.org/trunk@29268 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 19:57:21 +00:00
Scott Taylor
7f9edd3e69 After [29251], set the array keys in WP_UnitTestCase::$hooks_saved to prevent notices in 3rd party use cases.
Props danielbachhuber.
Fixes #28986.



git-svn-id: https://develop.svn.wordpress.org/trunk@29267 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 17:21:40 +00:00
Scott Taylor
80c4d6a96c Media Grid: general JS cleanup.
Props ericlewis.
See #28965.



git-svn-id: https://develop.svn.wordpress.org/trunk@29266 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 16:20:59 +00:00
Sergey Biryukov
d51539d8b3 Media Grid: Fix missing padding in RTL in Attachment Details modal.
see #28980.

git-svn-id: https://develop.svn.wordpress.org/trunk@29265 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 03:17:59 +00:00
Sergey Biryukov
708af1c467 Media Grid: Swap arrow direction in RTL in Attachment Details modal.
props adamsilverstein.
fixes #28980.

git-svn-id: https://develop.svn.wordpress.org/trunk@29264 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 03:07:21 +00:00
Helen Hou-Sandi
25b733cea2 Move the "view" link for attachment details to the sidebar and use more specific language. Removes an unnecessary JS handler. fixes #28977.
git-svn-id: https://develop.svn.wordpress.org/trunk@29263 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 02:19:21 +00:00
Sergey Biryukov
f171b362a9 Media Grid: Add a View button to Attachment Details modal.
props adamsilverstein.
fixes #28977.

git-svn-id: https://develop.svn.wordpress.org/trunk@29262 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 01:29:17 +00:00
Andrew Ozz
9106987a3f TinyMCE: include 85e22b58e9that and quote one more use of "float". This is "reserved as future keyword by older ECMAScript specifications" according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar and can throw a syntax error. See #28576.
git-svn-id: https://develop.svn.wordpress.org/trunk@29261 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 23:04:29 +00:00
John Blackbourn
dfa33f92ff Add a lang attribute to each language listed on the language selector screen during installation. See #28858, #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@29260 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 21:50:12 +00:00