Commit Graph

102 Commits

Author SHA1 Message Date
Helen Hou-Sandi
435c2b5686 Add file size to attachment publish meta box. props desrosj. fixes #25170.
git-svn-id: https://develop.svn.wordpress.org/trunk@25403 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 15:09:35 +00:00
Dion Hulse
cccac649d5 Fix wp_guess_url() to work in every scenario I could find, allows us to use it to determine the correct path to the WordPress Site URL before installation for install.php and setup-config.php redirects. Fixes #24480 Fixes #16884
git-svn-id: https://develop.svn.wordpress.org/trunk@25396 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 06:56:20 +00:00
Sergey Biryukov
1b012770eb Inline documentation for hooks in wp-admin/options.php.
props siobhyb.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25372 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 03:43:48 +00:00
Sergey Biryukov
a56e83373d Consistently call skin methods in WP_Upgrader. fixes #25254.
git-svn-id: https://develop.svn.wordpress.org/trunk@25370 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 02:42:10 +00:00
Sergey Biryukov
c05412b16c Fix invalid markup when searching for installed themes. fixes #25288.
git-svn-id: https://develop.svn.wordpress.org/trunk@25369 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-12 00:03:01 +00:00
Dion Hulse
ea6da7d5dc Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237
git-svn-id: https://develop.svn.wordpress.org/trunk@25349 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:26:57 +00:00
Dion Hulse
47c25b41af Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259
git-svn-id: https://develop.svn.wordpress.org/trunk@25347 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-11 08:08:35 +00:00
Scott Taylor
270cc9702d Check $profileuser->rich_editing for empty before using it in Edit User admin code.
Props sorich87, c3mdigital.
Fixes #17328.



git-svn-id: https://develop.svn.wordpress.org/trunk@25330 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 22:48:27 +00:00
Andrew Nacin
2c0b23557a Ignore user ID post data.
git-svn-id: https://develop.svn.wordpress.org/trunk@25316 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 17:57:14 +00:00
Scott Taylor
d141191598 Consistently wrap author and excerpt nodes with CDATA in feeds.
Fixes #18056.



git-svn-id: https://develop.svn.wordpress.org/trunk@25315 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 16:54:16 +00:00
Helen Hou-Sandi
37e5277651 Show the IP address, if available, in the comment edit screen submit meta box. props leewillis77. fixes #24638.
git-svn-id: https://develop.svn.wordpress.org/trunk@25314 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 14:40:15 +00:00
Dion Hulse
4a56e07c75 Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577
git-svn-id: https://develop.svn.wordpress.org/trunk@25308 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 07:53:15 +00:00
Dion Hulse
30827b47c1 Upgrader: Deprecate a few mostly unused functions, wp_update_plugin(), wp_update_theme(), and, wp_update_core().
wp_update_core() was still used, as it was never updated to make use of the newer Skins. Fixes #21874


git-svn-id: https://develop.svn.wordpress.org/trunk@25307 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 06:44:25 +00:00
Dion Hulse
fb20ed8b5b WP_Filesyste: SSH2 PHP Extension support: Fix a case where defining a custom FS_CHMOD_FILE / FS_CHMOD_DIR constant wouldn't take effect due to chmod() failing with a invalid path. Fixes #23589
git-svn-id: https://develop.svn.wordpress.org/trunk@25306 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 03:05:01 +00:00
Dion Hulse
beaf91c019 WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments.
git-svn-id: https://develop.svn.wordpress.org/trunk@25305 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 02:54:50 +00:00
Dion Hulse
2f40784d97 WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237
git-svn-id: https://develop.svn.wordpress.org/trunk@25304 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-09 02:42:52 +00:00
Helen Hou-Sandi
bde3435a63 Alignment standards for [25296]. props DrewAPicture. see #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25300 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 22:06:21 +00:00
Sergey Biryukov
8e4a6b31cd Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250.
git-svn-id: https://develop.svn.wordpress.org/trunk@25298 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 18:16:09 +00:00
Helen Hou-Sandi
ed6316d44b Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25297 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 16:19:39 +00:00
Helen Hou-Sandi
e9173ef83b Add media_submitbox_misc_sections and audio_submitbox_misc_sections filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171.
git-svn-id: https://develop.svn.wordpress.org/trunk@25296 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 16:18:26 +00:00
Sergey Biryukov
f9bb59cb30 Clarify a string in discussion settings. props Ipstenu, DrewAPicture. fixes #16705.
git-svn-id: https://develop.svn.wordpress.org/trunk@25295 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-07 15:35:26 +00:00
Andrew Nacin
6bad3b660a Correct @since in admin-footer. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25288 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:37:15 +00:00
Scott Taylor
2661cd53fc Use get_the_title() when dealing with post_type-like items in the admin.
Props nacin, DrewAPicture.
Fixes #14975.



git-svn-id: https://develop.svn.wordpress.org/trunk@25285 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:08:00 +00:00
Andrew Nacin
595284f699 Mark the hooks in custom-background.php as duplicates.
* image_size_names_choose should be documented in wp-includes/media.php
 * wp_create_file_in_uploads should be documented in custom-header.php

see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25283 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:04:36 +00:00
Andrew Nacin
a342806b55 Document comment_edit_redirect.
props dustyf.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25282 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 17:00:30 +00:00
Andrew Nacin
69a949d160 Add new ajax_query_attachments_args filter.
props alex-ye.
fixes #24285.


git-svn-id: https://develop.svn.wordpress.org/trunk@25279 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 15:17:35 +00:00
Sergey Biryukov
e8daea7de7 Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross.
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.

git-svn-id: https://develop.svn.wordpress.org/trunk@25277 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 14:09:07 +00:00
Dion Hulse
d9c5265303 WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049
git-svn-id: https://develop.svn.wordpress.org/trunk@25274 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 08:28:59 +00:00
Andrew Nacin
37d92f4851 Short descriptions for inline docs should end with a period, per the vast majority of core. see #25229.
git-svn-id: https://develop.svn.wordpress.org/trunk@25273 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:37:59 +00:00
Dion Hulse
9095e4b866 Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25272 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:32:09 +00:00
Andrew Nacin
ad1feed450 Stop using get_blogaddress_by_domain() when updating the siteurl/homeurl from the network admin.
props jeremyfelt, SergeyBiryukov.
fixes #18242. see #25235.


git-svn-id: https://develop.svn.wordpress.org/trunk@25261 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 18:48:26 +00:00
Scott Taylor
4286692d7d Remove redundant checks in some update functions. Adds some readability/coding standards cleanup.
Props miqrogroove, azaozz.
Fixes #22828.


git-svn-id: https://develop.svn.wordpress.org/trunk@25256 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 17:04:03 +00:00
Scott Taylor
16ef2c2e36 Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this.
Props jdgrimes.
See #25160.



git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:33:50 +00:00
Andrew Nacin
90605e02e7 Hook docs for admin-footer.php.
props natejacobs.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25252 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:20:05 +00:00
Andrew Nacin
2f0d581810 Inline documentation for the welcome_panel hook.
props natejacobs.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25250 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:06:16 +00:00
Scott Taylor
d10b9d32a0 Remove unnecessary checks before setting $wp_settings_* arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional array.
Props scribu.
Fixes #17884.



git-svn-id: https://develop.svn.wordpress.org/trunk@25240 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 19:06:13 +00:00
Andrew Nacin
14da301031 Clarify a database upgrade string, for 3.7.
props SergeyBiryukov.
fixes #24845.


git-svn-id: https://develop.svn.wordpress.org/trunk@25237 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 17:49:16 +00:00
Dion Hulse
7c8107734f Core Auto Updates: Add a initial skin to allow capturing the output from the upgrader without displaying it (such as we need during cron calls).
This has been copied almost verbatim from the automatic-updater plugin with a few style tweaks and additional upgrade-possible check. See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25228 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 07:16:16 +00:00
Dion Hulse
ea02f466c9 Upgrader: Split the UI "skins" out from the main Upgrader file into a seperate file to reduce the length of the files. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25227 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 06:34:38 +00:00
Sergey Biryukov
f913741b58 Avoid 'Only variables should be passed by reference' notice on Widgets screen. props jdgrimes. fixes #25225.
git-svn-id: https://develop.svn.wordpress.org/trunk@25226 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 05:10:43 +00:00
Dion Hulse
2da41fa7f0 Core Updates: Switch to using a new 1.7 version check API which will return extra auto-update packages when requested over SSL. The new API has switched to returning JSON. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25219 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-03 03:21:59 +00:00
Sergey Biryukov
6d23209dca Consolidate similar menu locations strings. props DrewAPicture. fixes #24945.
git-svn-id: https://develop.svn.wordpress.org/trunk@25218 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-03 01:41:49 +00:00
Sergey Biryukov
f695ee97e1 Set min-height for menu item title. props garyc40. fixes #16787.
git-svn-id: https://develop.svn.wordpress.org/trunk@25211 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-02 17:34:49 +00:00
Sergey Biryukov
56731f831d Avoid 'Only variables should be passed by reference' notice on plugin search. props daankortenbach. fixes #25217.
git-svn-id: https://develop.svn.wordpress.org/trunk@25210 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-02 13:53:57 +00:00
Sergey Biryukov
8b16c9bba8 Deprecate wp_nav_menu_locations_meta_box(), unused since [23441]. props DrewAPicture. fixes #24942.
git-svn-id: https://develop.svn.wordpress.org/trunk@25209 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-02 11:25:16 +00:00
Sergey Biryukov
a82593e4e4 Move get_real_file_to_edit() upper in the file for consistency with the existing order of functions. Some phpdoc fixes and additions. see #23680.
git-svn-id: https://develop.svn.wordpress.org/trunk@25208 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-02 11:18:35 +00:00
Sergey Biryukov
f64a9d63d8 Fix a grammar error on Permalink Settings screen. props celloexpressions. fixes #25210.
git-svn-id: https://develop.svn.wordpress.org/trunk@25206 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-02 10:03:58 +00:00
Sergey Biryukov
6bef163456 Update phpdoc for get_user_to_edit(), get_userdata(), and get_user_by(). props tivnet. fixes #24992.
git-svn-id: https://develop.svn.wordpress.org/trunk@25204 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-02 03:24:33 +00:00
Sergey Biryukov
4e75fe1bf1 Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680.
git-svn-id: https://develop.svn.wordpress.org/trunk@25201 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-01 12:36:45 +00:00
Andrew Nacin
a86a9f671d Nav menus: Allow assigning a new menu to an existing location when no theme setting is currently saved.
props ocean90.
see #25064, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25195 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-31 01:36:49 +00:00