Commit Graph

62 Commits

Author SHA1 Message Date
Ryan Boren bb4ab7e842 set_url_scheme() for header and background image srcs. see #20702
git-svn-id: https://develop.svn.wordpress.org/trunk@20830 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-18 20:22:57 +00:00
Ryan Boren fe7d612b97 Use correct translation function. Props kobenland, SergeyBiryukov. fixes #20646
git-svn-id: https://develop.svn.wordpress.org/trunk@20757 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-09 21:13:22 +00:00
Ryan Boren 485e7bc261 Allow selecting custom header and background images from the media library. Props aaroncampbell, sabreuse, greuben. fixes #19840
git-svn-id: https://develop.svn.wordpress.org/trunk@20358 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-05 00:20:28 +00:00
Andrew Nacin 070a9e5c59 Introduce new registration methods for custom headers and custom backgrounds. Backwards compatible, but old methods will be deprecated. see #20249. see #17242.
Custom header: Use add_theme_support('custom-header', $args) instead of add_custom_image_header(). Deprecates all use of constants.
 * HEADER_TEXTCOLOR is now (string) 'default-text-color'.
 * NO_HEADER_TEXT is nowi ! (bool) 'header-text'.
 * HEADER_IMAGE_WIDTH (and _HEIGHT) are now (int) 'width' and 'height'.
 * HEADER_IMAGE is now (string) 'default-image'.
 * The 3.4 arguments 'suggested-width' and 'suggested-height' are now just 'width' and 'height' (they are "suggested" when flex-width and flex-height are set).
 * Callback arguments for add_custom_image_header() can now be passed to add_theme_support().

Custom background: Use add_theme_support('custom-background, $args) instead of add_custom_background(). Deprecates all use of constants.
 * BACKGROUND_COLOR is now (string) 'default-color'.
 * BACKGROUND_IMAGE is now (string) 'default-image'.
 * Callback arguments for add_custom_background() can now be passed to add_theme_support().

Inheritance: add_theme_support() arguments for custom headers and custom backgrounds is a first-one-wins situation. This is not an unusual paradigm for theming as a child theme (which is included first) overrides a parent theme.
 * Once an argument is explicitly set, it cannot be overridden. You must hook in earlier and set it first.
 * Any argument that is not explicitly set before WP is loaded will inherit the default value for that argument.
 * It is therefore possible for a child theme to pass minimal arguments as long as the parent theme specifies others that may be necessary.
 * Allows for a child theme to alter callbacks for <head> and preview (previously, calling add_custom_image_header more than once broke things).
 * The just-in-time bits ensure that arguments fall back to default values, that the values of all constants are considered (such as one defined after an old add_custom_image_header call), and that all constants are defined (so as to be backwards compatible).

get_theme_support(): Introduce new second argument, which headers and backgrounds leverage to return an argument. current_theme_supports() already supported checking the truthiness of the argument.
 * For example, get_theme_support( 'custom-header', 'width' ) will return the width specified during registration.
 * If you had wanted the default image, use get_theme_support( 'custom-header', 'default-image' ) instead of HEADER_IMAGE. 

Deprecate remove_custom_image_header(), remove_custom_background(). Use remove_theme_support('custom-header'), 'custom-background'.

Deprecate short-lived custom-header-uploads internal support; this is now (bool) 'uploads' for add_theme_support().

New 3.4 functions renamed or removed: Rename get_current_header_data() to get_custom_header(). Remove get_header_image_width() and _height() in favor of get_custom_header()->width and height.



git-svn-id: https://develop.svn.wordpress.org/trunk@20212 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-19 17:12:44 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Andrew Nacin 030e0764b5 Standardize some final help strings. We're done, aside from typos. props zeo, jane, duck_, fixes #19020.
git-svn-id: https://develop.svn.wordpress.org/trunk@19538 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-02 04:31:01 +00:00
Ryan Boren 0cd6ddb43d Fix indent. see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19515 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 02:28:47 +00:00
Ryan Boren 9f8cbd8efc Use WP_Screen::add_help_tab(). see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19514 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 02:22:07 +00:00
Andrew Nacin 29bacb72f0 Help tweaks for themes, plugins screens. props jane, see #19020.
git-svn-id: https://develop.svn.wordpress.org/trunk@19510 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 01:24:39 +00:00
Andrew Nacin 33ee9a7d04 s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@19119 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 20:14:10 +00:00
Ryan Boren db63861af8 Use add_help_sidebar(). see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19111 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 03:12:37 +00:00
Andrew Nacin 182fa5fc58 Fix attribute spacing. props mfields, fixes #18570.
git-svn-id: https://develop.svn.wordpress.org/trunk@18648 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-07 13:53:02 +00:00
Ryan Boren ccba8dfbf3 Validation fixes. Props ocean90, peaceablewhale. see #17364
git-svn-id: https://develop.svn.wordpress.org/trunk@18010 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-23 23:33:30 +00:00
Ryan Boren da02537bb0 Mark import attachments as private. Schedule job to delete old import attachments. Introduce attachment context.
git-svn-id: https://develop.svn.wordpress.org/trunk@17999 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-22 23:25:28 +00:00
Andrew Nacin 368cb001de Add clear to custom background color field. props lancewillett for initial patch. fixes #15755.
git-svn-id: https://develop.svn.wordpress.org/trunk@17886 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-12 03:31:01 +00:00
Ryan Boren a5572fa5ef Denote images that are headers or backgrounds in the media ui. Props ocean90. fixes #17291
git-svn-id: https://develop.svn.wordpress.org/trunk@17793 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-04 18:28:31 +00:00
Ryan Boren 9730cb8d15 Constructor cleanup. Props ocean90. fixes #16768
git-svn-id: https://develop.svn.wordpress.org/trunk@17771 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-29 20:05:12 +00:00
Andrew Nacin f504e221e1 Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: https://develop.svn.wordpress.org/trunk@17748 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 15:24:49 +00:00
Ryan Boren 36a4508140 Update since phpdoc. Props demetris. fixes #15445
git-svn-id: https://develop.svn.wordpress.org/trunk@16660 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-01 19:24:38 +00:00
Mark Jaquith d65cdf4ba8 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@16061 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-28 21:56:43 +00:00
scribu 0911aa3e1a Use submit_button() in more places. See #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@15830 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-17 18:24:34 +00:00
Andrew Nacin af29b5d5cf phpdoc, @since, whitespace. Also require an argument in wp_insert_post(). props duck_, see #14783.
git-svn-id: https://develop.svn.wordpress.org/trunk@15564 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-05 02:45:39 +00:00
Andrew Nacin 616e2e1185 Missing links for custom background, header, and GUU. props zeo.
git-svn-id: https://develop.svn.wordpress.org/trunk@15231 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-11 18:00:29 +00:00
Andrew Nacin 2621ba04fe Improve the custom background front-end callback. Also, background-attachment should default to scroll, not fixed. fixes #13751.
git-svn-id: https://develop.svn.wordpress.org/trunk@15196 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-10 18:28:25 +00:00
Andrew Nacin e89212637d Help whitespace/punctuation cleanup. props zeo, see #13467.
git-svn-id: https://develop.svn.wordpress.org/trunk@15054 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-29 16:16:40 +00:00
Andrew Nacin 17a9a2bcdc The 'Help' tab on the custom background page should have, you know, custom background help. Oops. see #13467
git-svn-id: https://develop.svn.wordpress.org/trunk@15020 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-28 00:31:16 +00:00
Andrew Nacin e9f6f2d13b Custom header and background help. props jane, see #13467.
git-svn-id: https://develop.svn.wordpress.org/trunk@15019 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-28 00:27:53 +00:00
Andrew Nacin 28c54a5e20 Custom background UI tweaks. Make 'Select Color' a link instead of a button, move color below the background image options, standardize screen reader text.
git-svn-id: https://develop.svn.wordpress.org/trunk@15016 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-28 00:01:59 +00:00
Andrew Nacin f9de14b1a7 Custom background UI updates. Add padding to radio buttons, also convert repeat/title to radio buttons. props JohnONolan, see #12186.
git-svn-id: https://develop.svn.wordpress.org/trunk@14775 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-21 03:31:35 +00:00
Andrew Nacin d7e1bbb65b Show updated message after resetting or removing the background image. see #12186.
git-svn-id: https://develop.svn.wordpress.org/trunk@14685 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-16 05:38:14 +00:00
Andrew Nacin ae5af53f10 Custom background UI updates. props ocean90 for initial patch, see #12186.
git-svn-id: https://develop.svn.wordpress.org/trunk@14684 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-16 05:17:57 +00:00
Andrew Nacin 24ad763cfc Validation and nonce improvements to custom background UI. props ocean90, see #12186.
git-svn-id: https://develop.svn.wordpress.org/trunk@14670 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-15 19:47:03 +00:00
Andrew Nacin 9af98709d8 Ensure validation. props Utkarsh, see #13383.
git-svn-id: https://develop.svn.wordpress.org/trunk@14628 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-14 08:20:06 +00:00
Andrew Nacin 6924c645b7 Use inline styles in custom background admin, and prepopulate background options. props jshreve, see #12186.
git-svn-id: https://develop.svn.wordpress.org/trunk@14624 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-14 06:48:47 +00:00
Andrew Nacin 0d472228a2 Add closing tr tag to custom-background.php. Close paragraph tags in the recent comments and posts widget controls. props jshreve, see #13383.
git-svn-id: https://develop.svn.wordpress.org/trunk@14617 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-14 01:50:46 +00:00
Andrew Nacin 49e4cad78c Use the edit_theme_options capability. fixes #13290.
git-svn-id: https://develop.svn.wordpress.org/trunk@14581 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-12 19:19:57 +00:00
Ryan Boren 6ecfb58997 Remove only the background image, not all theme mods, when resetting the background to the default. Props ocean90. see #12186
git-svn-id: https://develop.svn.wordpress.org/trunk@14578 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-12 16:18:25 +00:00
Ryan Boren d43d37baa9 Remove redundant CSS, lighten up border on background preview, change labels for background preview. Props johnonolan. see #12186
git-svn-id: https://develop.svn.wordpress.org/trunk@14577 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-12 16:03:49 +00:00
Andrew Nacin 84578d128b Add trailing slash to some home_url() calls. props zeo, fixes #13245.
git-svn-id: https://develop.svn.wordpress.org/trunk@14443 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-04 17:13:11 +00:00
Ryan Boren d783952469 Strip trailing whites.
git-svn-id: https://develop.svn.wordpress.org/trunk@14404 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-03 20:26:11 +00:00
Dion Hulse fc796b8105 Add reset background image to theme default. Props lancewillett. See #12186
git-svn-id: https://develop.svn.wordpress.org/trunk@14379 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-03 18:52:38 +00:00
Andrew Nacin 4168a748dc Custom background UI tweaks. Props TECannon. see #12186, fixes #12699
git-svn-id: https://develop.svn.wordpress.org/trunk@14209 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-23 22:10:21 +00:00
Dion Hulse 491063c698 Tweak new strings for better typography. Props demetris. Fixes #12962
git-svn-id: https://develop.svn.wordpress.org/trunk@14070 602fd350-edb4-49c9-b593-d223f7449a82
2010-04-11 10:41:54 +00:00
Dion Hulse d3eec153be Add Repeat-x/repeat-y support to Custom Backgrounds, Add Live preview of Repeat option, Use Thumbnail of background for Background Preview. Props jshreve. See #12186
git-svn-id: https://develop.svn.wordpress.org/trunk@13856 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-28 02:53:04 +00:00
Andrew Nacin 4f5a2095a8 Remove trailing whites and double semicolons.
git-svn-id: https://develop.svn.wordpress.org/trunk@13830 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-26 19:36:49 +00:00
Andrew Nacin e34ca97ae0 Change @since 3.0 to @since 3.0.0.
git-svn-id: https://develop.svn.wordpress.org/trunk@13827 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-26 19:13:36 +00:00
Dion Hulse 3ca4e60665 Cleanup of Custom Background. Move JS to external file, Add @since, Remove redundant steps functionality, Preview of Image alignment. See #12186
git-svn-id: https://develop.svn.wordpress.org/trunk@13788 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-21 06:06:18 +00:00
Dion Hulse 2a77254f33 Show Background preview and options when no Image is uploaded. Display "Updated" div upon updates. Fix Colour Picker not loading after uploading a background image. See #12186
git-svn-id: https://develop.svn.wordpress.org/trunk@13765 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-19 09:33:29 +00:00
Dion Hulse 06c835eba5 Add instant background-color feedback to Custom Backgrounds. Add input validation to user-entered colour data. See #12186
git-svn-id: https://develop.svn.wordpress.org/trunk@13764 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-19 09:10:37 +00:00
Andrew Nacin 8aac1fc447 Use h3 (not h2) to break up sections on custom header/bg screens. Move div.updated message to right after the h2, as JS will move it there anyway.
git-svn-id: https://develop.svn.wordpress.org/trunk@13751 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-18 19:06:57 +00:00