Sergey Biryukov
1a748ed226
Media: Introduce a custom error handler for MediaElement.js to display a download link if a FLV file cannot be rendered for any reason.
...
Props Clorith.
Fixes #42643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42582 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 01:50:07 +00:00
Aaron Jorbin
818a0f1ccf
Query: Fix warning on counting non countable
...
Adds tests to continue the behavior for both null and strings.
See https://wiki.php.net/rfc/counting_non_countables for information on the PHP change.
Fixes #42860 .
Props janak007 and ayeshrajans for initial patches.
git-svn-id: https://develop.svn.wordpress.org/trunk@42581 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-24 01:20:24 +00:00
Peter Wilson
f3243498c7
Emoji: Update emoji regex for Twemoji to 2.4.0.
...
Build `src/wp-includes/formatting.php` following [42566].
Fixes #42862 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42579 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 21:11:54 +00:00
Andrew Ozz
cc5fdf702a
TinyMCE: backport bug fixes to `NotificationManager` and `WindowManager` from d1877933fa (diff-2e5c98d81ce2481aa1042b2320728b65)
and to `MultiRange` from 250675bb7b
.
...
Props peterwilsoncc, azaozz.
Fixes #42722 for trunk, see #43012 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42576 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 19:34:17 +00:00
Andrew Ozz
d6cc2b6f02
Editor: when keeping the scroll position treat all shortcodes as preview-able. Otherwise in some cases the marker span can get stuck inside the shortcode and break the markup.
...
Props azaozz, lizkarkoski and othellobloke for testing.
Fixes #42908 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@42574 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 17:33:26 +00:00
Sergey Biryukov
974d3afb9c
Media: Restore white background of the content area in media modal.
...
Props afercia, chetan200891.
Fixes #43088 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42572 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 14:00:39 +00:00
Sergey Biryukov
65f08f49da
Email: Don't send notifications for site or network admin email address change to the default 'admin_email' value.
...
Props tigertech, MattyRob, seanchayes.
Fixes #42693 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42570 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 13:44:25 +00:00
Sergey Biryukov
98a7f16608
Customize: Correct "Add Items" button reference in help text shown after creating a new menu.
...
Props dlh, munyagu, rishishah.
Fixes #42565 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42568 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 12:02:40 +00:00
Sergey Biryukov
a8105ec3f2
Emoji: Update Twemoji to 2.4.0.
...
WordPress was already on 2.5.0, but Twemoji decided to break their versioning, so 2.4.0 is actually the latest release.
Fixes #42862 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42566 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 11:48:59 +00:00
SergeyBiryukov
10ad912128
Taxonomy: Don't display an empty edit link in taxonomy list table if the user doesn't have permissions to edit the term.
...
Props grapplerulrich.
Fixes #43146 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42565 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 11:33:26 +00:00
Dion Hulse
5110f349a9
WPDB: Use a PCRE syntax which supports PCRE compiled between 2003 and 2006.
...
This fixes a PHP Warning in `wpdb::parse_db_host()` when WordPress is used with (sometimes a modern) PHP that's compiled against an ancient PCRE version.
Fixes #43109 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@42549 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 03:38:42 +00:00
Aaron Jorbin
5bb7fc10c5
Remove JSHint due to license compatibility
...
JSHint inherits a license from JSLint that includes the clause "The Software shall be used for Good, not Evil." WordPress's license specifically allows grants the freedom to run the program, for any purpose. Please note, this is not an encouragement of evil. Rather than doing something evil, how about learning to love those around you. Instead of tweeting lies and saying people are "Not Good!", help your neighbor. In the words of Lin Manual Miranda, "Love is love is love is love is love is love is love is love, cannot be killed or swept aside."
This replaces JSHint with esprima, a part of the larger jQuery project, and a custom wrapper for some basic error checking within codemirror.
The existing JSHint configuration is kept in place in case someone wants to use that, but they can only do so for Good.
Fixes #42850
Props netweb for a spelling fix on a comment.
git-svn-id: https://develop.svn.wordpress.org/trunk@42547 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-23 01:28:26 +00:00
Weston Ruter
4fb6c02b99
Widgets: Ensure media is explicitly enqueued from Text widget in case Media widgets are unregistered.
...
Amends [41344].
See #40854 .
Fixes #43125 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42545 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 19:24:02 +00:00
Weston Ruter
e2b25e6159
Customize: Let default status for Customizer be `draft` if user does not have capability to `publish`.
...
Amends [41626].
Props sayedwp, westonruter.
See #30937 .
Fixes #42686 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42543 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 19:09:16 +00:00
Weston Ruter
026cd70e25
Customize: Prevent frontend previewing from causing a customization lock on the changeset.
...
Props dlh.
Amends [41839].
See #42024 .
Fixes #42975 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42541 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 06:48:51 +00:00
Peter Wilson
ec8734bc2e
REST API: Update the fixture data for `wp-api.js` tests following [42359].
...
Props danielbachhuber.
See #41014 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42540 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 06:33:02 +00:00
Weston Ruter
b5b05c51c6
Customize: Use changeset-specific "locked" messages when branching is enabled.
...
Props dlh.
See #39896 .
Fixes #42655 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42538 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 06:27:41 +00:00
Weston Ruter
f65c46cc50
Customize: Prevent showing SFTP theme installation notification in multisite when user cannot install themes.
...
Props flixos90.
See #37661 , #42184 .
Fixes #42674 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42536 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 06:14:10 +00:00
Weston Ruter
8ae0bc51be
Widgets: Allow relative/partial URLs in Image Widget's link field.
...
Props audrasjb.
Amends [41252].
See #41274 .
Fixes #42740 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42533 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-22 04:51:16 +00:00
Weston Ruter
10b459f8e8
Code Editor: Disable `attr-value-double-quotes` HTMLHint rule since too strict for user input.
...
Using single-quoted attribute values is not in any way invalid HTML.
Amends [41376].
Props sasiddiqui.
See #12423 .
Fixes #42802 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42531 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-21 08:00:42 +00:00
Pascal Birchler
4fdd686e7b
Formatting: Fix typo in inline documentation of `_deep_replace()`.
...
Props ixkaito.
Fixes #43134 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42530 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-20 13:31:46 +00:00
Andrew Ozz
29bc3920be
Editor: change the test in `user_can_richedit()` to also detect when IE11 is in compatibility mode.
...
Props ndavison, azaozz.
Fixes #42503 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@42529 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-18 14:42:34 +00:00
Anton Timmermans
33cd11ecb6
Docs: Improve JSDoc for `password-strength-meter.js`.
...
Props herregroen, carolinegeven, ireneyoast, jjcomack.
Fixes #43066 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42528 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-18 13:38:26 +00:00
Dion Hulse
2cb36cab72
General: Allow `wp_list_pluck()` to operate on arrays of references without overwriting the referenced items.
...
Fixes #16895 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42527 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-18 05:17:23 +00:00
Dion Hulse
ade2dd5dfe
Tests: Remove redundant `assertEquals()` calls in listFilter tests.
...
As these tests are already validating that two arrays match, checking that the counts also match before is redundant and makes it harder to debug when the test fails.
See #16895
git-svn-id: https://develop.svn.wordpress.org/trunk@42526 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-18 05:14:28 +00:00
Sergey Biryukov
0baa8ae85c
Media: In `_wp_handle_upload()`, check if the file was properly uploaded before checking its size.
...
Props achbed, dglingren.
Fixes #39522 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42525 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-17 07:15:57 +00:00
Sergey Biryukov
6c081d396a
Editor: Use explicit context instead of a trailing space for `Edit` string in TinyMCE plugins.
...
Props scottlee, ayubadiputra, NathanAtmoz.
Fixes #42543 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42523 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-17 06:27:21 +00:00
Weston Ruter
505a939720
Widgets: Prevent `checkValidity` from running on a form when widget is first adding to sidebar.
...
Amends [41352].
See #23120 .
Fixes #43003 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@42521 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-17 01:23:39 +00:00
Aaron Jorbin
16f9dea4ab
BUILD/TEST TOOLS: Report Travis test results to make/hosting PHPUnit test results
...
Send the core test results to make/hosting in order to improve the alerting. See: https://github.com/WordPress/phpunit-test-reporter/issues/45
Fixes #43099
Props danielbachhuber
git-svn-id: https://develop.svn.wordpress.org/trunk@42492 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 20:28:42 +00:00
Andrea Fercia
9dd8b5a210
Plugins: Fix the plugin details modal "Close" button after [42443].
...
Props rinkuyadav999.
Fixes #43082 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42491 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 17:15:00 +00:00
Pascal Birchler
95ec25564b
Posts, Post Types: Add tests for `get_post_type_labels()`.
...
These were accidentally omitted in [38157].
See #38157 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42490 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 08:32:55 +00:00
Dion Hulse
b938517860
Build: Bump the version of node used on Travis to match WordPress.org.
...
Props netweb, dd32.
See #35105
git-svn-id: https://develop.svn.wordpress.org/trunk@42464 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 06:35:22 +00:00
Dion Hulse
e157ce1ebf
Build: Bump grunt-sass to v2.0.0 from v1.2.1 for Node 8.x support.
...
Changes: https://github.com/sindresorhus/grunt-sass/compare/v1.2.1...v2.0.0
Props netweb.
See #35105 .
Fixes #43097 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42463 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 06:32:54 +00:00
Dion Hulse
4dbc0b3987
External Libraries: Remove unnecessary / obsoleted MediaElement.js files.
...
Props joemcgill.
Fixes #42720 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@42462 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 06:27:48 +00:00
Dion Hulse
2eba5a98d9
Build: Use Node 8.x for trunk.
...
Props netweb.
See #35105 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42461 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 03:56:01 +00:00
Dion Hulse
01d5469e73
Build: Switch `package.json` to using tabs for indents.
...
Props netweb.
Fixes #43075 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42460 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 03:54:10 +00:00
Sergey Biryukov
842b3a2378
Plugins: Update review filter links in Details modal.
...
Props darko-a7, afercia.
Fixes #43016 . See #meta3379.
git-svn-id: https://develop.svn.wordpress.org/trunk@42459 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-16 00:14:48 +00:00
Sergey Biryukov
31ce230c58
Widgets: When checking for errors in Custom HTML widget, pass correct value to `toggleClass()` for Save button.
...
`toggleClass()` expects a boolean as a second argument, not an integer.
Props iCaleb.
Fixes #42867 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42457 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-15 23:46:02 +00:00
Sergey Biryukov
70dc1d9256
Media: Add `small-audio.flac` for a unit test added in [42451].
...
See #42225 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42453 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-15 22:32:47 +00:00
Sergey Biryukov
02ccaeed2c
Media: Add `flac` to the list of allowed file types.
...
Props blobfolio.
Fixes #42225 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42451 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-15 22:16:33 +00:00
Sergey Biryukov
fb5b617056
Media: Bring consistency to `getimagesize()` error suppression.
...
Props chasewg, joemcgill, jeremyfelt.
Fixes #42480 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42449 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-15 19:43:30 +00:00
Sergey Biryukov
0fdbb50a0e
Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer.
...
Props chetan200891 for initial patch.
Fixes #42871 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42447 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-15 19:26:47 +00:00
Andrew Ozz
40e6a33f2a
TinyMCE: on the toolbar drop-downs apply overflow style on the actual element with text.
...
Props abdullahramzan, azaozz.
Fixes #43090 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@42446 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-15 09:50:15 +00:00
Andrea Fercia
ae0995660c
Accessibility: Media: Improve the usage of a few label elements in the media templates.
...
Label elements should only be used for labelable elements.
- `Uploaded By` and `Uploaded To` aren't form controls and shouldn't be associated with labels
- changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)
Props Presskopp, afercia.
Fixes #38759 , #40468 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42444 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-14 16:38:47 +00:00
Andrea Fercia
9fb5b3bf10
Plugins: Fix the plugin details modal in the install plugin search tab after [41356].
...
Fixes #43082
git-svn-id: https://develop.svn.wordpress.org/trunk@42443 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-13 18:52:42 +00:00
Peter Wilson
2b56623d89
Formatting: Do not run formatting and texturization on author bios.
...
Removes the formatting and texturization added to author bios in #40040 due to back-compatibility concerns.
Reverts [41172], [41173].
Props 0x6f0, rabmalin for review.
Fixes #42578 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42441 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-13 01:10:56 +00:00
Andrea Fercia
1258d1d9d2
Accessibility: use `aria-current` for the paginated post links output by `wp_link_pages()`.
...
Continues the introduction in core of the aria-current attribute after [41683], [41359], and [41371].
- changes the `wp_link_pages()` (see the `nextpage` quicktag) output to use an `aria-current` attribute on the current item
- adds `post-nav-links` and `post-page-numbers` CSS classes to help themes style these links
- updates the related tests
Props antonioeatgoat, alexstine.
Fixes #41859 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42440 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-12 20:16:56 +00:00
Sergey Biryukov
a8d74c4f4e
Twenty Seventeen: Remove unnecessary comment in `front-page.php`.
...
Props hardik-amipara, poena.
Fixes #42820 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42437 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-12 20:00:14 +00:00
Anton Timmermans
b9b2f2a79d
Docs: Improve JS Docs for `controllers/customize-image-cropper.js`.
...
Props manuelaugustin, bramheijmink, andizer, ireneyoast.
Fixes #43020 .
git-svn-id: https://develop.svn.wordpress.org/trunk@42435 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-11 14:31:14 +00:00
Dion Hulse
91b3164ee5
Upgrade: When deleting old files, if deletion fails attempt to empty the file instead.
...
Props joemcgill, dd32.
Fixes #42963 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@42433 602fd350-edb4-49c9-b593-d223f7449a82
2018-01-10 06:09:51 +00:00