Commit Graph

57 Commits

Author SHA1 Message Date
Sergey Biryukov
ef8ed3e279 Avoid a PHP notice in WP_Press_This::get_suggested_content() after [32828].
props kraftbj.
fixes #32751.

git-svn-id: https://develop.svn.wordpress.org/trunk@32901 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-22 15:19:53 +00:00
Andrew Ozz
80a511015b Press This: Check the embeds list against all of the oembed providers.
Props stephdau. Fixes #32069.

git-svn-id: https://develop.svn.wordpress.org/trunk@32828 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-18 00:11:30 +00:00
Andrew Ozz
675de40f11 Press This: show error message when the user is attempting to add a category that already exists.
Fixes #32339.

git-svn-id: https://develop.svn.wordpress.org/trunk@32827 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-17 23:12:08 +00:00
Scott Taylor
296c559baf if is a statment, not a function.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32800 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-16 20:00:15 +00:00
Konstantin Obenland
e66948cf50 More semantic markup for the post formats metabox.
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.



git-svn-id: https://develop.svn.wordpress.org/trunk@32720 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 09:08:10 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Dominik Schilling (ocean90)
ff4f261101 Merge similar error strings.
props pavelevap.
fixes #32327.

git-svn-id: https://develop.svn.wordpress.org/trunk@32471 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 18:26:37 +00:00
Sergey Biryukov
3c28d7b1f6 Press This: Update documentation for press_this_save_redirect filter after [31992].
props kraftbj.
fixes #31996.

git-svn-id: https://develop.svn.wordpress.org/trunk@32143 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-19 01:34:01 +00:00
Andrew Ozz
f3033a9f5a Press This: do not show the bookmarklet upgrade notice when accessing directly press-this.php.
Props kraftbj. Fixes #31968.

git-svn-id: https://develop.svn.wordpress.org/trunk@32122 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-14 05:44:08 +00:00
Andrew Ozz
301bb0b9da Press This: check the bookmarklet version and add the update notice from PHP.
Fixes #31942.

git-svn-id: https://develop.svn.wordpress.org/trunk@32106 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-10 21:07:42 +00:00
Andrew Ozz
6cf43dfc06 Press This: add ARIA attributes to the alerts container.
Props afercia. Fixes #31942.

git-svn-id: https://develop.svn.wordpress.org/trunk@32102 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-09 23:44:50 +00:00
Andrew Ozz
47754dfc55 Press This: change the link text to Standard Editor.
Props Michael-Arestad. See #31923.

git-svn-id: https://develop.svn.wordpress.org/trunk@32093 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 23:27:04 +00:00
Andrew Ozz
bd8cb111ed Press This:
- When saving a draft change the text of the Save Draft button to Saving...
- On success, hide the button and show Edit Post link in its place. If the user focuses the title or the editor, hide the link and show the button again.
Fixes #31923.

git-svn-id: https://develop.svn.wordpress.org/trunk@32092 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-08 23:13:35 +00:00
Drew Jaynes
3e36e59646 Add missing @since versions from a variety of methods in WP_Press_This.
See [31693]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32014 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 19:45:48 +00:00
Drew Jaynes
4d751d4e98 Add missing DocBlocks for the _limit_array(), _limit_string(), _limit_url(), _limit_img(), _limit_embed(), and _process_meta_entry() utility methods in WP_Press_This.
See [31609]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32013 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-04 18:22:30 +00:00
Andrew Ozz
eacf52a68a Press This:
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875.

git-svn-id: https://develop.svn.wordpress.org/trunk@31992 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-03 01:33:30 +00:00
Sergey Biryukov
3e9c664a9b Press This: Use the error message returned by wp_update_post() instead of a generic one.
props stephdau.
fixes #31808.

git-svn-id: https://develop.svn.wordpress.org/trunk@31930 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 14:38:35 +00:00
Andrew Ozz
9369d03bc5 Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
Part props afercis, joedolson. Fixes #31575.

git-svn-id: https://develop.svn.wordpress.org/trunk@31925 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-30 03:08:30 +00:00
Andrew Ozz
2c2951d2c0 Press This: remove role="application" from the Categories list wrapper. This doesn't make it work better in screen readers.
See #31443.

git-svn-id: https://develop.svn.wordpress.org/trunk@31907 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-26 21:48:42 +00:00
Dominik Schilling (ocean90)
9e59690d03 Improve newly added strings for i18n:
* Add context to "Format" string.
* Use "Format" with context for "Post format".

see #31776.

git-svn-id: https://develop.svn.wordpress.org/trunk@31906 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-26 21:18:25 +00:00
Andrew Ozz
fed67453a1 Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed.
Props stephdau. Fixes #31763.

git-svn-id: https://develop.svn.wordpress.org/trunk@31894 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-26 01:16:58 +00:00
Andrew Ozz
defa8b0f96 Press This:
- Fix the links on inserted images to point to the source site.
- Fix inserting of images above the blockquote when the editor has not been focused.
Fixes #31745.

git-svn-id: https://develop.svn.wordpress.org/trunk@31868 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-24 01:32:17 +00:00
Sergey Biryukov
71aa4b15f6 Make a comment clearer (without implying inversed logic) and fix a typo.
see #31645.

git-svn-id: https://develop.svn.wordpress.org/trunk@31837 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 00:44:21 +00:00
Andrew Ozz
f2aa089166 Press This: small clean-up when generating the suggested content. Ensure all keys are always set in the array that is passed through the filter.
See #31637.

git-svn-id: https://develop.svn.wordpress.org/trunk@31836 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-20 00:18:00 +00:00
Andrew Ozz
8d392d4568 Press This: check if the URL is to embeddable content on a site that supports oEmbed. Then insert only the URL in the editor. It will trigger a wpView with the embedded content.
Fixes #31637.

git-svn-id: https://develop.svn.wordpress.org/trunk@31827 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 00:51:43 +00:00
Andrew Ozz
1a067a5e4c Press This: prepend the site domain to root-relative URLs. Reject other relative URLs.
Part props stephdau, kraftbj. Fixes #31645.

git-svn-id: https://develop.svn.wordpress.org/trunk@31818 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 20:42:38 +00:00
Andrew Ozz
533aefdf13 Press This: ignore site descriptions that end with an ellipsis. These are most likely auto-generated.
Props kraftbj. Fixes #31639.

git-svn-id: https://develop.svn.wordpress.org/trunk@31810 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 02:50:17 +00:00
Andrew Ozz
e875feafbb Press This: add aria-describedby to the new tag field.
Props afercia. Fixes #31546.

git-svn-id: https://develop.svn.wordpress.org/trunk@31808 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 02:18:00 +00:00
Andrew Ozz
34ff5cd2d2 Press This: fix the header styling and add a logo.
Props Michael-Arestad. Fixes #31472.

git-svn-id: https://develop.svn.wordpress.org/trunk@31807 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-18 02:09:00 +00:00
Andrew Ozz
21da2ccd85 Press This: bump bookmarklet's version. See #31657.
git-svn-id: https://develop.svn.wordpress.org/trunk@31800 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-17 01:18:01 +00:00
Andrew Ozz
820fe85082 Press This:
- Strip slashes while running side_load_images(), add slashes after.
- Simplify and clean up side_load_images().
- Add another arg to media_sideload_image() to return the uploaded image src only, and fix it to always return WP_Error on errors.
Fixes #31660.

git-svn-id: https://develop.svn.wordpress.org/trunk@31799 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-17 00:46:01 +00:00
Andrew Ozz
b91de55ede Press This: change the Publish button text to Submit for Review for contributors (like on the Edit Post screen).
Props stephdau, DrewAPicture. Fixes #31658.

git-svn-id: https://develop.svn.wordpress.org/trunk@31798 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 21:06:01 +00:00
Andrew Ozz
eb9cf72a1b Press This:
- Test image sizes from JS after Press This loads, before adding them to  "Suggested media".
- Clean up and simplify the HTML and JS a bit.
Fixes #31561.

git-svn-id: https://develop.svn.wordpress.org/trunk@31797 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-16 20:50:39 +00:00
Andrew Ozz
a6b11c0411 PressThis: add a wrapped with role = application to the categories section.
Props: afercia. See #31443.

git-svn-id: https://develop.svn.wordpress.org/trunk@31775 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-13 23:40:53 +00:00
Andrew Ozz
2650be6c74 PressThis: simplify and restyle the categories drop-down, remove the checkboxes and use JS to get the selected categories on submitting the form.
Part prop: Michael-Arestad. Fixes #31443.

git-svn-id: https://develop.svn.wordpress.org/trunk@31765 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-13 16:56:45 +00:00
Andrew Ozz
2707b39c63 PressThis: add inline comments and some cleanup for the images and embeds regex.
Props stephdau. Fixes #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31739 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-11 23:36:23 +00:00
Andrew Ozz
962ba7c52e PressThis: update _limit_url(), use esc_url_raw(). Fixes checking of urlencoded strings.
See #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31737 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-11 23:22:21 +00:00
Andrew Ozz
e0f843cd81 PressThis:
- Filter and select the content on the PHP side. Then pass only the needed data to JS.
- Add the suggested post title and contend directly to the HTML.
- Standardise the data type names.
- Some cleanup/reduction of the code in the bookmarklet.
See #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31693 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-09 21:48:38 +00:00
Andrew Ozz
e651a8bef1 PressThis: make the Preview button "subtle".
See #31458.

git-svn-id: https://develop.svn.wordpress.org/trunk@31655 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-07 01:49:57 +00:00
Andrew Ozz
fba4d3e296 PressThis: add preview functionality. Opens the preview in a new window or a tab next to the source tab.
Fixes #31458.

git-svn-id: https://develop.svn.wordpress.org/trunk@31654 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-07 01:16:05 +00:00
Andrew Ozz
900468728a PressThis:
- Close the sidebar on moving the focus outside of it (by clicking or by "tabbing").
- Fix a (weird) structural CSS problem where clicks go through the sidebar when it is open.
- Clean up the JS a bit.
Fixes #31457.

git-svn-id: https://develop.svn.wordpress.org/trunk@31651 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-06 22:56:17 +00:00
Andrew Ozz
1080a903fc PressThis: when server-side parsing, filter small images by the width and height attributes if set.
See #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31637 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-06 02:02:03 +00:00
Andrew Ozz
24461024ca PressThis:
- Fix error when checking for empty array keys.
- Add better DailyMotion embed support.
Props stephdau, see #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31635 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-06 01:16:53 +00:00
Andrew Ozz
f9a6a7aa56 PressThis:
- Improve handling of the data, both from the bookmarklet and from server-side parsing.
- Standardize on processing the data in PHP and remove duplicate code from JS.
- Improve the bookmarklet code and remove pre-filtering of the data.
Part props stephdau, see #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31609 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-04 19:28:53 +00:00
Helen Hou-Sandi
1c9b51a3e6 Remove the once-placeholder-esque "tag hint", which has not worked in quite some time.
It's not particularly useful, and adds visual noise when in place.

props welcher.
fixes #31485.


git-svn-id: https://develop.svn.wordpress.org/trunk@31607 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-03 21:52:35 +00:00
Andrew Ozz
0b962e2238 Press This:
- Remove classes from suggested HTML for the editor.
- Improve the filter, pass an associative array as param.
- Use <em> instead of <cite>.
Props Michael-Arestad, kraftbj. Fixes #31493.

git-svn-id: https://develop.svn.wordpress.org/trunk@31601 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-02 23:40:13 +00:00
Andrew Ozz
701d97b6d5 PressThis: make sure buttons.css is loaded before press-this.css. Use (int) $post_ID instead of $post->ID.
See #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31597 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-02 00:57:34 +00:00
Andrew Ozz
2d19a3b446 PressThis:
- Replace all `%1$s` and `%2$s` in suggestedHTML in case plugins repeat them.
- Fix docs typo, props kraftbj.
See #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31596 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-01 23:28:00 +00:00
Andrew Ozz
aee04ab9a3 PressThis:
- Simplify `getSuggestedContent()` and helpers. No need to override the global `data`.
- Replace the `press_this_source_string` and `press_this_source_link` filters with `press_this_suggested_html` that allows filtering of the link and the wrapper HTML tags.
See #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31595 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-01 22:43:36 +00:00
Andrew Ozz
cc3b0374ae PressThis:
- Remove unneeded passing of post formats strings to JS.
- Set the currently selected post format name with jQuery.
See #31373.

git-svn-id: https://develop.svn.wordpress.org/trunk@31589 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-28 20:07:45 +00:00