63 Commits

Author SHA1 Message Date
Helen Hou-Sandi
35df5592f1 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.


git-svn-id: https://develop.svn.wordpress.org/trunk@31973 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 22:05:17 +00:00
Dion Hulse
9eb9342a54 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121


git-svn-id: https://develop.svn.wordpress.org/trunk@31862 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:13:50 +00:00
Scott Taylor
3c810c5872 There are a few functions that have the ability to return false instead of a string, so the return value should be checked before being passed to functions that expect string.
These are trivial, but they clear out some Scrutinizer issues.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31681 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-09 02:10:36 +00:00
Scott Taylor
42bcec5061 Introduce a function, wp_attachment_is( $type, $post = 0 ), to collapse the logic for determining whether an attachment is an image, audio, or video.
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.


git-svn-id: https://develop.svn.wordpress.org/trunk@31645 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-06 20:25:09 +00:00
Helen Hou-Sandi
f11e86fb83 Hide irrelevant UI and display a message when editing the page for posts.
Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.

Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.

props alexkingorg for the initial, long-suffering patch.
fixes #17470.


git-svn-id: https://develop.svn.wordpress.org/trunk@31550 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 02:46:40 +00:00
Scott Taylor
358b309da9 In edit-form-advanced.php:
* `get_permalink( $post_ID )` can return `false`, set it to a variable and check it
* Using the variable allows us to replace 11 separate calls to `get_permalink( $post_ID )` in the file
* These notices were triggered by the potential for `false` to be passed to `esc_url()`

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31131 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-10 21:20:01 +00:00
Scott Taylor
77cffd8edf Admin globals:
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and  `$post` as globals where applicable

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31121 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-10 05:28:46 +00:00
Andrew Nacin
daf16cdb63 Call it 'Distraction-free writing mode' and update the help string. fixes #30657.
git-svn-id: https://develop.svn.wordpress.org/trunk@30890 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 10:06:17 +00:00
Andrew Ozz
2fc1155920 Do not autofocus text fields on page load on mobile devices. This is currently broken in many mobile browsers:
- iOS Safari opens the keyboard and auto-scrolls on the first tap anywhere on the screen triggering the click at an unexpected place. That makes it impossible to follow links or press buttons.
- Chrome on iOS opens the keyboard on load and may scroll the focused field off screen.
- The Android 4.4 browser only highlights the field, the user has to tap it to open the keyboard and type.
See #30703.

git-svn-id: https://develop.svn.wordpress.org/trunk@30842 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-13 22:07:58 +00:00
John Blackbourn
7082b703b2 Improve various hook and filter docs so they are correctly parsed for the code reference.
Fixes #30558
Props DrewAPicture


git-svn-id: https://develop.svn.wordpress.org/trunk@30754 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-06 21:31:41 +00:00
John Blackbourn
3f2827c5be Admin help text changes for the General Settings screen, post editing screen, network settings screen, and user editing screen.
Fixes #30547
Props kpdesign


git-svn-id: https://develop.svn.wordpress.org/trunk@30705 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-02 05:14:38 +00:00
Drew Jaynes (DrewAPicture)
b90807cccd Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/*.
Also includes some changes to move hook docs to directly precede hook lines. This is necessary to prevent DocBlock-matching confusion when core is parsed.

Affects DocBlocks for the following hooks:
* `wp_ajax_ . $_REQUEST['action']`
* `wp_ajax_nopriv_ . $_REQUEST['action']`
* `admin_footer- . $GLOBALS['hook_suffix']`
* `admin_head-$hook_suffix`
* `admin_post_nopriv_{$action}`
* `admin_post_{$action}`
* `load-  . $page_hook`
* `load- . $plugin_page`
* `load-importer- . $importer`
* `load- . $pagenow`
* `admin_action_ . $_REQUEST['action']`
* `async_upload_{$type}`
* `add_meta_boxes_ . $post_type`
* `{$taxonomy}_pre_edit_form`
* `{$taxonomy}_term_edit_form_tag`
* `{$taxonomy}_edit_form_fields`
* `{$taxonomy}_edit_form`
* `after-{$taxonomy}-table`
* `{$taxonomy}_pre_add_form`
* `{$taxonomy}_term_new_form_tag`
* `{$taxonomy}_add_form_fields`
* `{$taxonomy}_add_form`
* `media_upload_$type`
* `media_upload_$tab`
* `install_plugins_pre_$tab`
* `install_plugins_$tab`
* `install_themes_pre_{$tab}`
* `install_themes_{$tab}`
* `update-core-custom_{$action}`
* `update-custom_{$action}`
* `user_{$name}_label`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30649 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 11:42:00 +00:00
Drew Jaynes (DrewAPicture)
c52dc42879 Add an entry to the changelog for the wp_editor_expand hook denoting that the $post_type parameter was added in 4.1.0.
See #30458.


git-svn-id: https://develop.svn.wordpress.org/trunk@30643 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 09:50:46 +00:00
Andrew Ozz
8dabfb3b85 Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass $post_type in the wp_editor_expand filter. See #30458.
git-svn-id: https://develop.svn.wordpress.org/trunk@30641 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-30 06:36:59 +00:00
Drew Jaynes (DrewAPicture)
e7fee524b6 4.1 Docs Audit: Clarify the DocBlock summary for the edit_form_before_permalink hook.
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30599 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 08:51:59 +00:00
Andrew Ozz
d4946a7904 Editor:
- Add CSS reset for the TinyMCE fullscreen mode when used on the Edit Post screen.
- Fix loading of the old and new DFW buttons, use another arg. passed to WP_Editors.
- Reset editor-expand when exiting TinyMCE fullscreen mode.
Fixes #30453.

git-svn-id: https://develop.svn.wordpress.org/trunk@30573 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-26 02:49:41 +00:00
Drew Jaynes (DrewAPicture)
2d064e1b86 Ensure the DocBlock directly precedes the hook line for the post_edit_form_tag action in wp-admin/edit-form-advanced.php.
This fixes the parser getting confused about which DocBlock belongs to which hook or function in this file.

See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30539 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-24 05:21:56 +00:00
Helen Hou-Sandi
a8821f6b57 Admin notices: Add more variety and make more generically usable.
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.


git-svn-id: https://develop.svn.wordpress.org/trunk@30505 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-21 16:40:29 +00:00
Andrew Ozz
47a4d58d2b Editor: enable spellchecking of the post title field on the Edit Post screen. Props marsjaninzmarsa, fixes #30338.
git-svn-id: https://develop.svn.wordpress.org/trunk@30350 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-15 01:42:17 +00:00
Mark Jaquith
78f0186866 Introduce Distraction-Free Writing v2, a re-think of DFW that uses the main editor instance
* the "DFW" button is now an auto/off toggle
* defaulting to auto during beta, decide later for release
* "auto" means that DFW gets enabled as you start typing in editor
* tabbing and mousing out will bring the full interface back
* there is a slight grace period during which your mouse can quickly return

Feature plugin work happened here: https://github.com/avryl/focus

props avryl, azaozz, Michael Arestad
fixes #29806

git-svn-id: https://develop.svn.wordpress.org/trunk@30338 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 22:30:55 +00:00
John Blackbourn
5567318f63 Introduce an edit_form_before_permalink action which gets fired after the title field but before the permalink fields. Fixes #29691. Props captaintheme
git-svn-id: https://develop.svn.wordpress.org/trunk@30028 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 21:48:38 +00:00
Andrew Ozz
1880bf988c Editor: use <button> instead of <a> for the Visual/Text buttons, make them focusable. Props afercia, fixes #27553
git-svn-id: https://develop.svn.wordpress.org/trunk@30002 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-24 01:20:42 +00:00
Sergey Biryukov
bd07f41256 Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances.
props nacin.
fixes #28090.

git-svn-id: https://develop.svn.wordpress.org/trunk@29671 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-02 09:07:08 +00:00
Andrew Ozz
1f2ff1d3f3 Editor expand: add docs for the wp_editor_expand filter, props DrewAPicture, fixes #29423
git-svn-id: https://develop.svn.wordpress.org/trunk@29654 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-29 02:37:59 +00:00
Andrew Ozz
fcc188193f Editor expand: add a filter to turn it off from PHP, fixes #29423
git-svn-id: https://develop.svn.wordpress.org/trunk@29653 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-29 02:27:06 +00:00
Helen Hou-Sandi
1121aad86e Editor scrolling: reduce the amount of height jumping on load.
props avryl.
fixes #29307.


git-svn-id: https://develop.svn.wordpress.org/trunk@29628 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 18:38:26 +00:00
Helen Hou-Sandi
ee43238413 Restore spacing on the edit screen when a post type supports title but not editor.
props avryl.
fixes #28893.


git-svn-id: https://develop.svn.wordpress.org/trunk@29618 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-26 05:24:55 +00:00
Scott Taylor
99a0a62442 Don't show the Featured Image metabox for users with the contributor role. Do enqueue media so that TinyMCE previews work for YouTube embeds, etc.
Props SergeyBiryukov.
Fixes #28327.


git-svn-id: https://develop.svn.wordpress.org/trunk@29402 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-06 17:16:45 +00:00
Andrew Ozz
c94edd08bd Editor scrolling:
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29336 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 02:42:30 +00:00
azaozz
12ebd89657 Editor scrolling: also disable in IE < 9. See #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29180 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-15 22:36:02 +00:00
Andrew Ozz
dbb367bee8 Editor scrolling: disable on mobile devices and hide the resize handle. See #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29117 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 00:53:08 +00:00
Helen Hou-Sandi
e4f0744b8e Editor scrolling:
* Make sure the background color for tools is only applied to the main editor.
* Fix toolbar width for smaller screens.
* Ensure toolbar doesn't end up in a weird place when scrolling down too fast.
* Avoid JS errors for post types that don't support the editor.

props avryl. see #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29075 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 19:35:32 +00:00
Andrew Ozz
14d1e57e99 Enhance the editor on the Add/Edit Post screens, first run. Props avril, see #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29049 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 22:05:06 +00:00
Scott Taylor
95f3506532 In media_buttons(), add a static var $instance to increment the id attribute of insert-media-button-%d on each call.
Props ericlewis.
Fixes #28090.


git-svn-id: https://develop.svn.wordpress.org/trunk@28837 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-26 01:04:32 +00:00
Andrew Nacin
402bb6208b Don't show featured images for image attachments. Remove abstractions for now.
fixes #27673.


git-svn-id: https://develop.svn.wordpress.org/trunk@28051 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 17:39:58 +00:00
Andrew Nacin
1fa68e490b Expose toolbar keyboard shortcut in Help documentation for TinyMCE.
props joedolson, jorbin.
fixes #27024.


git-svn-id: https://develop.svn.wordpress.org/trunk@28029 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 01:38:42 +00:00
Andrew Ozz
7b272d3a26 Drag and drop files on the editor to upload: add new argument to wp_editor() to enable, fixes #27465
git-svn-id: https://develop.svn.wordpress.org/trunk@27901 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 02:41:24 +00:00
Andrew Nacin
877ffc087f Cleanups for audio/video metadata, see [27862].
see #27574.


git-svn-id: https://develop.svn.wordpress.org/trunk@27864 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 21:07:04 +00:00
Scott Taylor
149f36ed35 Metadata for audio and video files:
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27862 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 19:27:31 +00:00
Scott Taylor
0697544056 Turn on thumbnail support for attachment:audio and attachment:video. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin.
Fixes #27460.



git-svn-id: https://develop.svn.wordpress.org/trunk@27657 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 02:34:39 +00:00
Andrew Nacin
4cf6fc1a99 Use SSL when linking to WordPress.org. see #27115.
git-svn-id: https://develop.svn.wordpress.org/trunk@27469 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 04:13:28 +00:00
Sergey Biryukov
ecbe4f0909 Use a consistent format for translator comments.
props GaryJ.
fixes #27228.

git-svn-id: https://develop.svn.wordpress.org/trunk@27325 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-28 08:08:50 +00:00
Scott Taylor
52cbf23fe2 Correct a missing conditional in edit-form-advanced.php.
See #26631, [27209]. 
Props nacin for noticing.



git-svn-id: https://develop.svn.wordpress.org/trunk@27216 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-20 21:37:57 +00:00
Scott Taylor
ae603ef26d Allow pseudo post types attachment:audio and attachment:video to get the media modal on Edit Media when they support featured images.
Introduces `post_supports_thumbnails( $post )` and `theme_supports_thumbnails( $post )` to cut down on duplicated code everytime this needs to be checked. There will be more cases forthcoming.

See #26631.



git-svn-id: https://develop.svn.wordpress.org/trunk@27209 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-20 17:49:30 +00:00
Andrew Ozz
88fecbeff9 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086.
git-svn-id: https://develop.svn.wordpress.org/trunk@27036 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 20:27:21 +00:00
Andrew Ozz
9aba880b53 Autosave: refactor autosave.js, use heartbeat for transport and move all "Add/Edit Post" related functionality to post.js. See #25272.
git-svn-id: https://develop.svn.wordpress.org/trunk@26995 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 04:55:37 +00:00
Andrew Ozz
89a63c8f43 TinyMCE: set the 'add_unload_trigger' option to false for the main editor. Prevents DOM problems in Firefox when reloading the page, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@26979 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 20:34:12 +00:00
Andrew Ozz
14ace125ee TinyMCE 4.0.12, first run.
- Removes wp-tinymce-schema.js and mark-loaded.js, no longer needed.
- Removes the inlinepopups and most of the wpdialogs plugins; wpdialog.js is moved to wp-includes/js.
- Adds charmap, compat3x, image, link and textcolor plugins, previously contained in /themes/advanced.
- Updates the wordpress, wpeditimage, wpfullscreen, wpgallery and wplink plugins.
- Updates DFW, wp-admin/js/wp-fullscreen.js.
See #24067.

git-svn-id: https://develop.svn.wordpress.org/trunk@26876 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-28 23:52:04 +00:00
Andrew Ozz
b33d0da84c Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
git-svn-id: https://develop.svn.wordpress.org/trunk@26518 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 03:52:23 +00:00
Sergey Biryukov
bc6c0c9b0f Correct @since values for various hooks. fixes #25766.
git-svn-id: https://develop.svn.wordpress.org/trunk@25991 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 03:19:16 +00:00