Commit Graph

24976 Commits

Author SHA1 Message Date
Sergey Biryukov
47510a2092 Correct @since value. see #26869.
git-svn-id: https://develop.svn.wordpress.org/trunk@27192 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-18 21:44:14 +00:00
Sergey Biryukov
013a4e3381 Correct return values for update_metadata() and related functions.
fixes #21864.

git-svn-id: https://develop.svn.wordpress.org/trunk@27191 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-18 21:35:07 +00:00
Andrew Ozz
0d52823908 TinyMCE: style the modals to match WordPress admin (first-run). Fix couple of IE problems in tiny_mce_popup.js. Props avryl, see #26952, see #24067
git-svn-id: https://develop.svn.wordpress.org/trunk@27190 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-18 06:31:30 +00:00
Scott Taylor
6d00fb3fe8 Remove code from a previous patch. See [27188].
git-svn-id: https://develop.svn.wordpress.org/trunk@27189 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-17 22:45:52 +00:00
Scott Taylor
1b8da3d0d6 Use selected() where appropriate in touch_time(), page_template_dropdown(), and parent_dropdown(). Also, add proper docs.
Props meloniq, DrewAPicture.
Fixes #25889.



git-svn-id: https://develop.svn.wordpress.org/trunk@27188 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-17 22:26:14 +00:00
Scott Taylor
c2efafbddb Add some more assertions to Tests_Query_Conditionals, specifically for is_single(), is_page(), and is_attachment().
See [27016].
Fixes #24257.



git-svn-id: https://develop.svn.wordpress.org/trunk@27187 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-17 22:10:57 +00:00
Scott Taylor
664bf1fea2 Remove extraneous type-casting in wp_get_object_terms().
Props OriginalEXE.
Fixes #27133.



git-svn-id: https://develop.svn.wordpress.org/trunk@27186 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-17 21:55:41 +00:00
Scott Taylor
7bdca44b97 Make WP_User_Query::prepare_query() public by allowing it to be passed an array of args. Previously, if the WP_User_Query constructor was not passed args, the object was basically unusable. Adds unit tests, all other tests pass.
Props scribu, for the initial patch.
Fixes #21119.



git-svn-id: https://develop.svn.wordpress.org/trunk@27185 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-17 21:40:04 +00:00
Scott Taylor
db1c44bc42 wp_get_post_revisions() should have a default orderby of date ID to tie-break rapidly added revisions - namely, when unit tests are run. There is a test that occasionally fails when running all tests, and always fails when running phpunit tests/phpunit/tests/post/revisions.php . This fixes that.
Fixes #26042.



git-svn-id: https://develop.svn.wordpress.org/trunk@27184 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-17 21:22:25 +00:00
Scott Taylor
a31a167359 Reset $wp_query and $post during WP_UnitTestCase::tearDown() to avoid spillage of globals between tests.
See #26321.



git-svn-id: https://develop.svn.wordpress.org/trunk@27183 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-17 21:03:43 +00:00
Andrew Ozz
4283c76461 TinyMCE: wrap the toolbars buttons on narrow screens, props mikemanger, fixes #26882
git-svn-id: https://develop.svn.wordpress.org/trunk@27182 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-17 02:12:07 +00:00
Andrew Nacin
6351b0b3a4 Rename the old media.css file, used for the pre-3.5 media library. Clean up script-loader CSS registrations.
see #26669.


git-svn-id: https://develop.svn.wordpress.org/trunk@27181 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-16 00:35:12 +00:00
Andrew Ozz
920a9799cf TinyMCE tests: remove 'coverage' for now, has unsatisfied dependencies. Tweak the test runner so it auto-starts. See #27014.
git-svn-id: https://develop.svn.wordpress.org/trunk@27180 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-15 21:25:15 +00:00
Andrew Ozz
5a9624b834 TinyMCE: when clicking on a character in the Charmap modal, don't close it if the Crtl key is pressed. Makes it possible to insert several special chars in a row. See #27107.
git-svn-id: https://develop.svn.wordpress.org/trunk@27179 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-14 19:19:28 +00:00
Andrew Nacin
31d3af406c Multisite: Add get_network_by_path() and wp_get_network() to begin cleanup of multisite load.
Tries to get network detection under control by simplifying wpmu_current_site(). It now also pops off each subdomain to find a more general match. Adds unit tests for get_network_by_path() and a new network factory for unit tests.

Much of this is likely to change in 3.9 as more of ms-load.php and ms-settings.php gets hacked to bits.

props jeremyfelt.
see #27003.


git-svn-id: https://develop.svn.wordpress.org/trunk@27178 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 23:06:12 +00:00
Andrew Ozz
f6af16cd76 TinyMCE: add support for audio and video shortcodes without closing, fix jshint warning, see #27016.
git-svn-id: https://develop.svn.wordpress.org/trunk@27177 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 20:12:46 +00:00
Andrew Nacin
f1e7635a2d Add grunt precommit for running front-end dev and test tasks before commit.
This includes autoprefixer, imagemin, jshint, and qunit.

props jorbin.
fixes #27121. see #25169 and #27078.


git-svn-id: https://develop.svn.wordpress.org/trunk@27176 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 17:56:29 +00:00
Andrew Nacin
562046753d Dev/build tools: Skip new backbone.js and underscore.js files during jshint.
git-svn-id: https://develop.svn.wordpress.org/trunk@27175 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 08:58:17 +00:00
Andrew Nacin
01b809bf2b Dev/build tools: Use grunt-autoprefixer for CSS vendor prefixes.
We'll be using it for two distinct tasks:
 * Core CSS files will keep prefixes. `grunt autoprefixer:core` will update files directly in src/ as a pre-commit step, rather than doing it on build.
 * Color CSS files will receive prefixes when they are built.

This commit:
 * Adds prefixes we were missing to core CSS.
 * Removes prefixes that we no longer need from core CSS.
 * Removes all prefixes from colors CSS.

props ocean90.
fixes #27078.


git-svn-id: https://develop.svn.wordpress.org/trunk@27174 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 08:29:16 +00:00
Andrew Nacin
12b13fe7cf Optimize 69 images (of 127) using the new Grunt task. (See [27172].)
fixes #25169.


git-svn-id: https://develop.svn.wordpress.org/trunk@27173 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 08:02:48 +00:00
Andrew Nacin
877982732a Dev tools: Add grunt imagemin:core task for optimizing images pre-commit.
Adds grunt-contrib-imagemin, so an `npm install` will be required.

props jorbin, wonderboymusic for initial patches.
see #25169.


git-svn-id: https://develop.svn.wordpress.org/trunk@27172 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 08:00:47 +00:00
Andrew Nacin
110978e2d3 Update media-views and wp.Backbone.View for Backbone 1.1.
* Collection set/add/remove/reset methods now return models, not `this`, so they can no longer be chained.
 * Options passed to Backbone.View's constructor are no longer attached automatically. wp.Backbone.View now does this automatically.

See [27170] for Backbone 1.1 itself.

props gcorne.
fixes #26799.


git-svn-id: https://develop.svn.wordpress.org/trunk@27171 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 07:36:01 +00:00
Andrew Nacin
4e36f55df7 Update Backbone from 1.0 to 1.1.
Also update Underscore to 1.6. Includes the development versions of both, which are not included in the build.

Here is Backbone's changelog:
 * Made the return values of Collection’s `set`, `add`, `remove`, and `reset` more useful. Instead of returning `this`, they now return the changed (added, removed or updated) model or list of 
models. (This means they can no longer be chained.)
 * Backbone Views no longer automatically attach options passed to the constructor as `this.options` and Backbone Models no longer attach `url` and `urlRoot` options, but you can do it yourself if you prefer. (But if you extend `wp.Backbone.View`, options will be attached for you.)
 * All `"invalid"` events now pass consistent arguments. First the model in question, then the error object, then options.
 * You are no longer permitted to change the id of your model during `parse`. Use `idAttribute` instead.
 * On the other hand, `parse` is now an excellent place to extract and vivify incoming nested JSON into associated submodels.

See [27171] (next commit) for changes made to WordPress to be compatible with Backbone 1.1.

props gcorne, georgestephanis.
see #26799.


git-svn-id: https://develop.svn.wordpress.org/trunk@27170 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 07:33:29 +00:00
Andrew Ozz
fcea323396 TinyMCE: add image based placeholders for audio and video shortcodes. Props wonderboymusic, see #27016.
git-svn-id: https://develop.svn.wordpress.org/trunk@27169 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-13 05:09:04 +00:00
Andrew Nacin
36fe6c1c27 Don't use HTTPS in unit tests if OpenSSL isn't loaded.
props bpetty.
fixes #27114.


git-svn-id: https://develop.svn.wordpress.org/trunk@27168 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-12 20:39:21 +00:00
Sergey Biryukov
4db1f2cb20 Merge two similar strings. props pavelevap. fixes #27096.
git-svn-id: https://develop.svn.wordpress.org/trunk@27167 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-12 10:14:12 +00:00
Scott Taylor
fd8d6cddcd Don't iterate over $wp_query->posts in update_post_thumbnail_cache() if it is empty. Adds unit tests.
Props SergeyBiryukov, for the original patch.
Fixes #26321.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@27166 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-12 04:48:14 +00:00
Andrew Ozz
94a1bb0485 TinyMCE: fix styling in the Charmap modal so the click targets are as large as the table cells. Remove the "Close" button and close the modal after inserting the special char. Fixes #27107.
git-svn-id: https://develop.svn.wordpress.org/trunk@27165 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 23:32:11 +00:00
Dominik Schilling (ocean90)
a03b5033ce Use jQuery.prop('checked') instead of jQuery.attr('checked'), which is deprecated.
git-svn-id: https://develop.svn.wordpress.org/trunk@27164 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 21:12:04 +00:00
Scott Taylor
2e9d155703 Partially revert [27101], [27102], [27141], and [27142]. Those commits introduced new functions to sync up cache invalidation events. The current commit alters existing internals.
"The cache invalidation with static was introduced in r9102 with version 2.7. Multisite wasn't in core back then, so something like switch_to_blog() wasn't a concern, but now it breaks if you switch the blog in between calls to clean_term_cache."

This solution is simpler. All unit tests pass. Removes unnecessary tests linked to removed functions.

Props kovshenin.
Fixes #14485, #22526.



git-svn-id: https://develop.svn.wordpress.org/trunk@27163 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 16:49:11 +00:00
Scott Taylor
05b87717c8 Rather than removing the 3rd argument in WP_Object_Cache::delete(), mark it as $deprecated.
See [27064].
Props SergeyBiryukov.
Fixes #22478.



git-svn-id: https://develop.svn.wordpress.org/trunk@27162 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 16:40:30 +00:00
Scott Taylor
4f8d51257c In remove_user_from_blog(), avoid a potentially expensive IN query before invalidating the reassigned post and link caches.
Props kovshenin.
Fixes #25545. (Again.)



git-svn-id: https://develop.svn.wordpress.org/trunk@27161 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 16:27:05 +00:00
Andrew Ozz
fb3f9ff8f7 Bump the TinyMCE version, see #24409.
git-svn-id: https://develop.svn.wordpress.org/trunk@27160 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-11 01:07:22 +00:00
Andrew Ozz
fd19c371d1 Edit image in TinyMCE:
- Add a "toolbar" at the top of the image with two buttons: Edit and Delete.
- Don't open the edit modal on second click on the image. Makes the "edit" button somewhat pointless and can sometimes trigger after resizing the image.
- When the image has caption: attempt to prevent IE11 from making the caption element resizable and wrapping it in thick border.
- When the caret is inside a caption next to the image, pressing Enter will create a new <p> tag above the caption.
- Hide the image toolbar on drag, cut, align.
Props gcorne, see #24409.

git-svn-id: https://develop.svn.wordpress.org/trunk@27159 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 23:47:34 +00:00
Andrew Nacin
b7be4e98fe Detect and handle symlinking of plugins in plugin_basename().
props rmccue, MikeSchinkel, jdgrimes.
see #16953.


git-svn-id: https://develop.svn.wordpress.org/trunk@27158 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 22:59:40 +00:00
Drew Jaynes
ef099f8082 Fix a typo in the PHPDoc for comment_author_email_link().
See #27083.


git-svn-id: https://develop.svn.wordpress.org/trunk@27157 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 04:06:36 +00:00
Drew Jaynes
3d67904bc7 Inline documentation cleanup in wp-includes/comment-template.php.
This cleanup follows [25567] and brings the docs in-line with standards that at the time had not yet been finalized.

These changes include
* Moving in-line `@see` tags to their own lines
* Using docs-specific variables in hook docs
* Fixing line-wrapping throughout
* Typos and punctuation
* Converting hash notation values to variables per the standard

Fixes #27083. See #20495.


git-svn-id: https://develop.svn.wordpress.org/trunk@27156 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 03:19:13 +00:00
Andrew Ozz
ce2dcccf86 Incorporate the TinyMCE tests into our JS tests:
- Modified the original tests so TinyMCE can be loaded from /src/wp-includes/js/tinymce.
- Added "WP" option to the UI to select only tests relevant to our integration (excludes most of the default plugins tests).
- Added tests for obsolete HTML elements and attributes (html4 back-compat).
See #27014.

git-svn-id: https://develop.svn.wordpress.org/trunk@27155 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-10 01:11:25 +00:00
Andrew Ozz
4951bdc964 Remove unused arg from wp_auth_check(), see #27081.
git-svn-id: https://develop.svn.wordpress.org/trunk@27154 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 22:33:56 +00:00
Andrew Nacin
e1f6ab1ea9 Run wp_auth_check on every heartbeat tick.
wp_heartbeat_received only runs when data is sent. We want to always pass this data back, though.

fixes #27081.


git-svn-id: https://develop.svn.wordpress.org/trunk@27153 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 22:27:57 +00:00
Scott Taylor
3fce77b44d Collect the post and link ids that will be reassigned before running the update in remove_user_from_blog(). Use array_walk() instead of array_map() when invalidating the caches for the collected ids.
Props kovshenin.
Fixes #25545.



git-svn-id: https://develop.svn.wordpress.org/trunk@27152 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:46:43 +00:00
Sergey Biryukov
13571cf6b2 Update comment about structure of items in $menu global.
props kitchin.
fixes #26635.

git-svn-id: https://develop.svn.wordpress.org/trunk@27151 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:42:28 +00:00
Dominik Schilling (ocean90)
586cb2b140 Nav Menu: Remove post/page items from the Nav Menu when the post/page is deleted.
This was broken through a change in [25163]. `_menu_item_object` in wp_get_associated_nav_menu_items() is not relevant for post types.
Adds unit tests.

props UmeshSingla for initial patch.
fixes #26795.

git-svn-id: https://develop.svn.wordpress.org/trunk@27150 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:36:15 +00:00
Drew Jaynes
d670819b03 Improve inline documentation for wp_new_user_notification().
Props antorome for the initial patch.
Fixes #26703.


git-svn-id: https://develop.svn.wordpress.org/trunk@27149 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:07:01 +00:00
Drew Jaynes
eaff87706b Improve inline documenation for get_the_time() and `get_post_time().
Props ruud@joyo for the initial patch.
Fixes #26682.


git-svn-id: https://develop.svn.wordpress.org/trunk@27148 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:02:36 +00:00
Drew Jaynes
b013aaf4c9 Fixes for hooks documentation in wp-includes/wp-db.php.
See #26869, #25229 and [25284].


git-svn-id: https://develop.svn.wordpress.org/trunk@27147 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:50:42 +00:00
Drew Jaynes
6229ba0bb3 Fixes for hooks documentation on xmlrpc.php.
Adds spacing, changes an `@see` to `@link`, adds a docs-specific variable for a parameter.

See #26869, #25229 and [25281].


git-svn-id: https://develop.svn.wordpress.org/trunk@27146 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:38:39 +00:00
Drew Jaynes
e4adb8dcfe Fixes for hooks documentation in wp-admin/admin-footer.php.
Adds some new lines, some hook-line spacing, docs-specific variables, and other language tweaks.

See #26869, #25229, [25252].


git-svn-id: https://develop.svn.wordpress.org/trunk@27145 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:28:01 +00:00
Drew Jaynes
1fcb6036ca Fixes for inline documentation for hooks in wp-comments-post.php.
Adds missing `@since` versions, spacing, and language tweaks.

See #26869, #25229, [25249].


git-svn-id: https://develop.svn.wordpress.org/trunk@27144 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 20:11:34 +00:00
Andrew Ozz
0ae2aa696a Remove a stray </div> from the Edit Image template, was breaking it in IE < 9. Props gcorne, see #24409
git-svn-id: https://develop.svn.wordpress.org/trunk@27143 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 18:44:40 +00:00