55 Commits

Author SHA1 Message Date
Scott Taylor
18adbb6439 In paginate_links(), ensure that query string args are propagated to the resulting paginated links.
Adds unit tests that use `DOMDocument` since `assertTag` is being deprecated - see #29545, [29746].

Props obenland, wonderboymusic.
Fixes #29636.


git-svn-id: https://develop.svn.wordpress.org/trunk@29780 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-29 04:02:23 +00:00
Scott Taylor
91517ce620 Clarify that get_the_date(), get_the_time(), get_post_time() and get_post_modified_time() should return false when get_post() is null.
Adds unit tests.

Props GaryJ, SergeyBiryukov, tollmanz.
Fixes #28310.


git-svn-id: https://develop.svn.wordpress.org/trunk@29344 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:39:22 +00:00
Sergey Biryukov
50090763ba Remove redundant title attributes from get_calendar().
props joedolson.
fixes #26561.

git-svn-id: https://develop.svn.wordpress.org/trunk@29244 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 04:40:32 +00:00
Scott Taylor
0b1a0b39fd Use includes_url() in wlwmanifest_link().
Props nacin.
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28908 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:26:59 +00:00
Scott Taylor
acd2a45cc2 wlwmanifest_link() should use the WPINC constant
Props wojtek.szkutnik
See #14157.


git-svn-id: https://develop.svn.wordpress.org/trunk@28905 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 22:16:52 +00:00
Scott Taylor
33275a0826 Cleanup after [28671]:
* Set better defaults in `paginate_links()`, so that themes don't have to calculate them on their own, like Twenty Fourteen does now.
* Don't set page 1 to `?page=1` or `/page/1/` - that will force a canonical redirect.
* Add and cleanup unit tests

Props obenland, SergeyBiryukov, wonderboymusic.
Fixes #24606.


git-svn-id: https://develop.svn.wordpress.org/trunk@28785 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:11:14 +00:00
Sergey Biryukov
4fde71e75d Avoid an empty href attribute in paginate_links(). Add unit tests.
props obenland, Nessworthy.
fixes #24606.

git-svn-id: https://develop.svn.wordpress.org/trunk@28671 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 02:09:12 +00:00
Sergey Biryukov
f54a73f637 Add 'wp_title_parts' filter to wp_title().
props aaroncampbell, obenland.
fixes #17877.

git-svn-id: https://develop.svn.wordpress.org/trunk@28669 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 00:27:37 +00:00
Scott Taylor
aa34ede226 Truly check for ! empty() instead of falsey '' when determining whether to add LIMIT clause to SQL in wp_get_archives().
Props jjeaton for the initial patch.
Fixes #27834.


git-svn-id: https://develop.svn.wordpress.org/trunk@28560 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-23 18:27:10 +00:00
Sergey Biryukov
b0b85cc484 Use correct variable. see [28534], [28538].
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28540 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 17:39:22 +00:00
Scott Taylor
312ef7b264 These functions import $wpdb but do not use it.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28539 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 17:36:42 +00:00
Sergey Biryukov
ce653e1925 Remove redundant assignment. see [28379], [28534].
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28538 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 17:34:34 +00:00
Scott Taylor
a0c78339fc Fix some bad UI recursion in wp_get_archives() caused by [28379]. It appears that $afterafter was appropriately named.
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28534 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-20 23:08:23 +00:00
Drew Jaynes (DrewAPicture)
b5fdb2dc06 Improve inline documentation for default arguments in wp_get_archives().
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28476 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 17:19:56 +00:00
Scott Taylor
9e07b1037e Eliminate use of extract() in paginate_links(). Adds unit tests. Moves tests/general/template.php (which only had one method) to tests/general/paginateLinks.php.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28397 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-14 22:28:08 +00:00
Scott Taylor
77731c03fc Eliminate use of extract() in wp_get_archives().
Adds unit tests: `tests/functions/getArchives.php`. 
All other unit tests pass.

Props MikeHansenMe, wonderboymusic.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28379 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:28:56 +00:00
Scott Taylor
5cf2a50dba In paginate_links(), break is unreachable after return.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28326 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:24:22 +00:00
Scott Taylor
a1c6a10489 In general-template.php - remove dead code:
* In `get_calendar()`, `$cache` is set twice. The first is useless. 
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary. 
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28274 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:57:22 +00:00
Scott Taylor
61765b8efd Set the proper value for wp_title() when is_author() and is_post_type_archive() are both true. post_type should always win due to the precedence indicated in get_queried_object().
Props mordauk.
Fixes #25398.



git-svn-id: https://develop.svn.wordpress.org/trunk@28251 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-04 22:20:47 +00:00
Drew Jaynes (DrewAPicture)
9da8915408 Ensure the register filter hook is only documented once.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28208 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 06:23:31 +00:00
Drew Jaynes (DrewAPicture)
ecbe6226fa Inline documentation for three remaining hooks in wp-includes/general-template.php.
Documents the `login_form_top`, `login_form_middle`, and `login_form_bottom` and filters.

That's 184/184 hook docs files complete. Boom!

Props kpdesign, DrewAPicture.
Fixes #27719.


git-svn-id: https://develop.svn.wordpress.org/trunk@28131 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 04:41:37 +00:00
Drew Jaynes (DrewAPicture)
c91efaa74c Inline documentation for hooks in wp-includes/general-template.php.
Props jesin, kpdesign.
See #27719.


git-svn-id: https://develop.svn.wordpress.org/trunk@28130 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 04:00:48 +00:00
John Blackbourn
a27f712fbb Introduce before_page_number and after_page_number arguments for paginate_links(). Fixes #24709. Props grahamarmfield.
git-svn-id: https://develop.svn.wordpress.org/trunk@27600 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-18 23:30:55 +00:00
John Blackbourn
22eb8b34ef Improve paginate_links() performance by not calling number_format_i18n() unnecessarily. Fixes #25735 with tests. Props johnpbloch.
git-svn-id: https://develop.svn.wordpress.org/trunk@27523 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-13 17:38:51 +00:00
Andrew Nacin
260b7f08ca Let get_the_date() accept a post object.
props tanner-m, adamsilverstein, bigdawggi.
fixes #13771.


git-svn-id: https://develop.svn.wordpress.org/trunk@27380 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-03 17:59:11 +00:00
Andrew Nacin
6a35efe1e5 Revert [27115] and let cache backends handle the stripping of spaces in cache keys as necessary.
microtime() returns greater precision than microtime(true).

see #27000, #23448, #26903, #14485.


git-svn-id: https://develop.svn.wordpress.org/trunk@27300 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-26 22:04:52 +00:00
Drew Jaynes
647f80595d Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core.
See #27200.


git-svn-id: https://develop.svn.wordpress.org/trunk@27262 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-25 17:13:08 +00:00
Sergey Biryukov
ed6ec6de61 Correct @return value for get_the_date().
props TobiasBg.
fixes #27181.

git-svn-id: https://develop.svn.wordpress.org/trunk@27231 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-21 22:48:38 +00:00
Sergey Biryukov
fdb9451326 Remove unnecessary assignment and concatenation from the_date() and get_the_date().
props juliobox.
fixes #27181.

git-svn-id: https://develop.svn.wordpress.org/trunk@27230 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-21 22:38:00 +00:00
Drew Jaynes
eaff87706b Improve inline documenation for get_the_time() and `get_post_time().
Props ruud@joyo for the initial patch.
Fixes #26682.


git-svn-id: https://develop.svn.wordpress.org/trunk@27148 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:02:36 +00:00
Andrew Nacin
4f5608f653 Use a float for last_changed microtime cache values.
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.

props _jameslee, drozdz.
fixes #27000. see #23448.


git-svn-id: https://develop.svn.wordpress.org/trunk@27115 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 08:13:37 +00:00
Andrew Nacin
1304fb3463 Fix the conditional enqueueing/printing of colors stylesheets, without breaking dependencies.
fixes #18380.
see #20729 which should properly fix this.


git-svn-id: https://develop.svn.wordpress.org/trunk@27111 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-06 22:15:25 +00:00
Andrew Nacin
5d8627f6c9 Use the_title_attribute() in feed_links_extra(), rather than get_the_title().
props c3mdigital.
fixes #15046.


git-svn-id: https://develop.svn.wordpress.org/trunk@26975 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 09:52:05 +00:00
Andrew Ozz
a6742e996a Deprecate rich_edit_exists(). It doesn't make sense to support deleting the TinyMCE directory when we have auto-updates. Fixes #26786.
git-svn-id: https://develop.svn.wordpress.org/trunk@26933 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-13 00:00:00 +00:00
Drew Jaynes
4056d33bca Avoid a notice by checking that SCRIPT_DEBUG is defined before evaluating it in register_admin_color_schemes().
See #26316.


git-svn-id: https://develop.svn.wordpress.org/trunk@26786 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 19:22:57 +00:00
Andrew Nacin
6e1d73c39d Admin color schemes: Manually handle RTL and minified versions of the CSS files on registration.
This bypasses WP_Styles entirely, which is much simpler for the moment, given that color schemes bypass WP_Styles for plenty already. The script loader is told to stop thinking of colors.css as an RTL-ified file. The colors-fresh handle, used directly on the login screen, needed to be (even before this commit).

fixes #26316.


git-svn-id: https://develop.svn.wordpress.org/trunk@26780 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 09:04:02 +00:00
Andrew Nacin
91d6f455c6 Add four more color schemes to round out our collection at eight.
The new schemes are Ectoplasm, Coffee, Ocean, Sunrise. For those following along, the first three were at one point named Ghostbusters, Pixel, and Cape Cod.

See [26137] for the original color schemes.

props ryelle, melchoyce, drw158, littlethingsstudio.
fixes #26468. see #25858, #22862.


git-svn-id: https://develop.svn.wordpress.org/trunk@26773 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 07:25:08 +00:00
Andrew Ozz
93a5bff7a7 Svg-painter:
- Clean up the JS, better names, etc.
- Convert the base64 encode/decode code from jQuery plugin to local use.
- Add missing icon colors for the default theme.
- Make it more error-proof.
Fixes #26333.

git-svn-id: https://develop.svn.wordpress.org/trunk@26601 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-04 04:12:41 +00:00
Andrew Nacin
2cb2a1b86e Rename colors-fresh.css to colors.css. fixes #26137.
git-svn-id: https://develop.svn.wordpress.org/trunk@26570 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-03 18:15:52 +00:00
Helen Hou-Sandi
62479c7420 Pass the post type to the post_type_archive_title filter for better context. Adds lovely docs. props DrewAPicture. fixes #25605.
git-svn-id: https://develop.svn.wordpress.org/trunk@26457 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-28 05:23:50 +00:00
Andrew Nacin
e7986b035c Remove SCRIPT_DEBUG reference from register_admin_color_schemes().
Instead, script-loader.php handles converting .min.css to .css when SCRIPT_DEBUG is on, and has since r21592. (This was done for compatibility with plugin color schemes that used .css and .dev.css.)

see #25858.


git-svn-id: https://develop.svn.wordpress.org/trunk@26147 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-14 00:02:36 +00:00
Helen Hou-Sandi
37b14a653a Avoid a notice when SCRIPT_DEBUG is not defined. props MikeHansenMe. see #25824, #25858.
git-svn-id: https://develop.svn.wordpress.org/trunk@26146 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 23:58:32 +00:00
Helen Hou-Sandi
e84e1e8791 Merge the color schemes component from MP6. Introduces Light, Blue, and Midnight.
Color scheme selection on your own profile page gives you a preview and autosaves the selection.

Also introduces the usage of a preprocessor for core files, namely Sass. For 3.8, we will not expand its implementation past the color schemes. This does require Ruby as well as Sass 3.3.0+ due to the usage of the sourcemap option.

Note that only the default color scheme is available when running out of src. Use build to test the rest as well as the color picker.

props ryelle, melchoyce, tillkruess, drw158, littlethingsstudio, helen. see #25858, #22862.


git-svn-id: https://develop.svn.wordpress.org/trunk@26137 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 19:37:10 +00:00
Scott Taylor
5f1180ca0f Change nofollow to follow in wp_robots_noindex(). "The noindex is fine, the nofollow stops any link equity from that URL, so that's actually a bad idea."
Props joostdevalk.
Fixes #22876.



git-svn-id: https://develop.svn.wordpress.org/trunk@26096 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-11 22:26:33 +00:00
Helen Hou-Sandi
17287af965 Say hello to a fresh new look for the WordPress admin.
Still to come: more color schemes, a responsive component, and more.

see #25858.
props iammattthomas, tillkruess, EmpireOfLight, melchoyce, ryelle, joen, mitchoyoshitaka, sirbrillig, andypeatling, isaackeyet, Otto42, dd32, matt, helen.


git-svn-id: https://develop.svn.wordpress.org/trunk@26072 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-10 00:26:50 +00:00
Andrew Nacin
c87ad6023d Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 17:21:32 +00:00
Sergey Biryukov
55ee5c4894 Escape title in HTML5 search form. props obenland, joostdevalk, scottsweb. fixes #25322.
git-svn-id: https://develop.svn.wordpress.org/trunk@25710 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 14:13:14 +00:00
Andrew Nacin
f6138dc287 Remove redundant title attributes.
props sabreuse.
see #24766.


git-svn-id: https://develop.svn.wordpress.org/trunk@25675 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 22:50:50 +00:00
Andrew Nacin
a05eefbd64 Ensure that get_bloginfo( 'pingback_url' ) uses site_url(), for SSL awareness.
props technosailor.
fixes #25418.


git-svn-id: https://develop.svn.wordpress.org/trunk@25671 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:14:05 +00:00
Scott Taylor
e72ffa5d96 Move checks for post_type being an array inline. See [25291], [25292], #18614.
git-svn-id: https://develop.svn.wordpress.org/trunk@25312 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:01:10 +00:00