Commit Graph

32679 Commits

Author SHA1 Message Date
Boone Gorges
7f79d26ca5 Don't allow term meta to be added to shared taxonomy terms.
`add_term_meta()` and `update_term_meta()` identify terms by `$term_id`. In
cases where a term is shared between taxonomies, `$term_id` is insufficient to
distinguish where the metadata belongs.

When attempting to add/update termmeta on a shared term, a `WP_Error` object
is returned. This gives developers enough information to decide whether they'd
like to force the term to be split and retry the save, or show an error in the
UI, or whatever.

Props boonebgorges, mboynes, DH-Shredder, jorbin, aaroncampbell.
Fixes #34544.

git-svn-id: https://develop.svn.wordpress.org/trunk@35515 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:23:28 +00:00
Scott Taylor
dc3f5a0cf5 REST API: in WP_REST_Server::dispatch(), move preg_match() out of it's current loop, which doesn't affect the context passed to it.
Props TobiasBg.
Fixes #34488.


git-svn-id: https://develop.svn.wordpress.org/trunk@35514 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:22:21 +00:00
Aaron Jorbin
eef98a3495 Bump matchdep from 0.3.0 to 1.0.0
This drops support for node 0.8.0 so if you still using that, it's time to upgrade your node.

See #34177



git-svn-id: https://develop.svn.wordpress.org/trunk@35513 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:21:00 +00:00
Boone Gorges
c8dd2d480d WP_Comment_Query: Fill comment objects from database when cache is unavailable.
This fixes a bug where widgets loaded in a preview or the Customizer are
rendered inside of a `wp_suspend_cache_addition()` block and thus could not
find comment objects in the cache.

Props rommelxcastro, stevehenty.
Fixes #34138.

git-svn-id: https://develop.svn.wordpress.org/trunk@35512 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 21:09:01 +00:00
Drew Jaynes
74b68afa3f Customizer: Adjust styles on panel titles to prevent descenders – such as with the letters g, j, p, q, or y – from getting cut off in some browsers.
Props umeshnevase.
Fixes #33575.


git-svn-id: https://develop.svn.wordpress.org/trunk@35511 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 18:52:13 +00:00
Drew Jaynes
d09f6ef81c Pages: Introduce the get_page_uri filter, which makes it possible to manipulate a given page's URI before it's returned from the like-named get_page_uri().
Props tanner-m for the initial patch.
Fixes #15963.


git-svn-id: https://develop.svn.wordpress.org/trunk@35510 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 18:28:31 +00:00
Scott Taylor
75673887d1 XMLRPC: ensure that empty strings are not passed as null, which will then fail isset()
Props solarissmoke.
Fixes #16980.


git-svn-id: https://develop.svn.wordpress.org/trunk@35509 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 18:07:45 +00:00
Aaron Jorbin
395bc6e8d8 Adjust heading structure for pages using wp-admin/css/install.css
The readme, installation, upgrade, and repair pages use a common css file. The heading structure for these pages was inconstant with h2s where there should be h1s, h1s where there is no relevant info and sometimes, no h1s at all.

Fixes #34519
Props rianrietveld



git-svn-id: https://develop.svn.wordpress.org/trunk@35508 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 17:59:35 +00:00
Scott Taylor
48501d6658 Roles: map add_users cap to promote_users and remove it.
"Never used, will be removed." - The Ghost of 3.5 Nacin

Props Craig Ralston, renoirb.
Fixes #16719.


git-svn-id: https://develop.svn.wordpress.org/trunk@35507 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 17:53:40 +00:00
Scott Taylor
ee98fd84bb Feeds: <comments> is optional in RSS2, so don't include it when comments aren't present or open. Same for <wfw:commentRss> and <slash:comments>
Adds unit test.

Props swissspidy, realloc, hakre, sivel.
Fixes #9134.


git-svn-id: https://develop.svn.wordpress.org/trunk@35506 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 17:46:41 +00:00
Sergey Biryukov
00ee9a62d1 Add missing @group to Tests_Rel_No_Follow.
See #9959.

git-svn-id: https://develop.svn.wordpress.org/trunk@35505 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 16:35:02 +00:00
Drew Jaynes
14cd5cf3ed Taxonomy: Introduce the dynamic taxonomy_labels_{$taxonomy} filter, which can be used to manipulate the labels for a given taxonomy.
The addition of this hook brings parity with the earlier-introduced `post_type_labels_{$post_type}` filter, which allows for similarly manipulating labels for a given post type.

Note: It isn't possible to unset or remove default labels via either of these hooks, only to overwrite. This is because WordPress relies on defaults being set for use in various UIs and admin experiences.

Props flixos90.
Fixes #34554.


git-svn-id: https://develop.svn.wordpress.org/trunk@35504 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 16:02:12 +00:00
Drew Jaynes
ebfc39e754 Docs: Add a missing return description for _get_custom_object_labels(), a private core helper function.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35503 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 15:46:49 +00:00
SergeyBiryukov
059eb46ddd Menus: After [35450], use correct IDs in $initial_meta_boxes.
Props swissspidy.
Fixes #33925.

git-svn-id: https://develop.svn.wordpress.org/trunk@35502 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 10:55:01 +00:00
Weston Ruter
46778fe2b0 Customize: Simplify condition for returning nav_menus_invalid_post_type error.
Props swissspidy.
See #16075.


git-svn-id: https://develop.svn.wordpress.org/trunk@35501 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 07:28:36 +00:00
Weston Ruter
5084a0b28a Customize: Add support for post_type_archive nav menu items.
Props celloexpressions, westonruter.
Fixes #16075.


git-svn-id: https://develop.svn.wordpress.org/trunk@35500 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 04:29:39 +00:00
Gary Pendergast
ff6e398b6f Media Library: Allow longer labels in the filter dropdowns.
Props aaronrutley, AlbertoCT.

Fixes #32005.




git-svn-id: https://develop.svn.wordpress.org/trunk@35499 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 00:40:31 +00:00
Andrew Ozz
01e9de382e Responsive images:
- Fix `_wp_upload_dir_baseurl()` to cache by blog_id.
- Replace `path_join()` with `trailingslashit()`, it's much faster.
- Rename $image_url to $image_src for consistency (used at about 50 other places).
- Couple of tests fixes.

See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35498 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-04 00:21:23 +00:00
Sergey Biryukov
88c274fad8 Formatting: wp_make_link_relative() should return an empty string if no path is present in the link.
Props bcworkz, MikeHansenMe, chriscct7, SergeyBiryukov.
Fixes #26819.

git-svn-id: https://develop.svn.wordpress.org/trunk@35497 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 21:35:17 +00:00
Sergey Biryukov
b077aecd6a Accessibility: After [35130], adjust the h2.nav-tab-wrapper selector to only override .wrap > h2:first-child.
This improves compatibility with plugins that use navigation tabs as a first H2 heading on their screens.

Props afercia.
Fixes #33559.

git-svn-id: https://develop.svn.wordpress.org/trunk@35496 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 20:48:21 +00:00
DrewAPicture
d49c379d18 Docs: Fix two notations for the $_wp_real_parent_file global, which is an array.
Props NExt-Season.
Fixes #34443.


git-svn-id: https://develop.svn.wordpress.org/trunk@35495 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 20:12:02 +00:00
Andrea Fercia
f25e642086 Accessibility: Improve buttons focus and links style in the install screens.
Fixes #34530.

git-svn-id: https://develop.svn.wordpress.org/trunk@35494 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 17:58:15 +00:00
Andrea Fercia
29f271da44 Media: Improve form fields labels association in the Edit Media screen.
Fixes #34548.

git-svn-id: https://develop.svn.wordpress.org/trunk@35493 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 16:01:11 +00:00
Andrea Fercia
3b587473b5 WP oEmbed: Improve the Sharing dialog accessibility.
Improves ARIA attributes, focus handling, and constrains tabbing within the modal dialog.

Fixes #34484.

git-svn-id: https://develop.svn.wordpress.org/trunk@35492 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 15:48:37 +00:00
Andrew Ozz
d037ebdb31 Responsive images:
- More fixes to inline docs.
- Replace the last `wp_get_attachment_metadata()` with `get_post_meta()`.
- For consistency only accept array or named size in `wp_get_attachment_image_sizes()`.

Props jaspermdegroot.
See #34430.

git-svn-id: https://develop.svn.wordpress.org/trunk@35491 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-03 00:18:07 +00:00
Drew Jaynes
d464e70d9c Docs: Document use of the $comment_status global in the DocBlock for WP_Comments_List_Table::handle_row_actions().
Props shimakyohsuke.
Fixes #34425.


git-svn-id: https://develop.svn.wordpress.org/trunk@35490 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-02 21:32:14 +00:00
Sergey Biryukov
ae68fbfcee Docs: After [32654], remove duplicate @param tag in WP_List_Table::set_pagination_args() DocBlock.
Add `@since` tag.

Props bobbingwide.
See #32444.

git-svn-id: https://develop.svn.wordpress.org/trunk@35489 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-02 21:02:29 +00:00
Sergey Biryukov
88d63f743e Build Tools: Add Microsoft Edge to Autoprefixer options.
Props christophherr.
Fixes #34550.

git-svn-id: https://develop.svn.wordpress.org/trunk@35488 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-02 20:43:55 +00:00
Gary Pendergast
c9f7e05f7b Upgrades: Add support for FULLTEXT indexes to dbDelta().
Props edirect24, mdawaffe, pento.

Fixes #14445.



git-svn-id: https://develop.svn.wordpress.org/trunk@35487 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 23:09:49 +00:00
Weston Ruter
3ef1e8194b Customize: Fix auto-expand (and focus) on newly added widgets.
Add widget controls with an initially-true `active` state so that calling `expand()` will not be short-circuited. Previously the `active` state would be set once the preview refreshes, but this happens too late for the `addWidget` call. Fixes regression introduced in [35231].

Fixes #34514.


git-svn-id: https://develop.svn.wordpress.org/trunk@35486 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 22:26:47 +00:00
Drew Jaynes
d74794fdde Docs: Correctly notate that the default $width and $height embed dimensions are passed to the embed_defaults filter as a compacted array, and not two distinct parameters.
Props swissspidy.
Fixes #34522.


git-svn-id: https://develop.svn.wordpress.org/trunk@35485 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 15:41:28 +00:00
Sergey Biryukov
bce985a5d7 Docs: Correct $post parameter description for display_post_states filter.
Props grapplerulrich.
Fixes #34541.

git-svn-id: https://develop.svn.wordpress.org/trunk@35484 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 14:05:42 +00:00
Weston Ruter
204bad4685 Customize: Return user to referring URL when leaving Customizer in absence of return query param.
When referring URL is not available, default returning user to frontend URL instead of admin URL. Themes page is updated to include the `return` path in Customizer links.

Props McGuive7, westonruter.
Fixes #32637.


git-svn-id: https://develop.svn.wordpress.org/trunk@35483 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 06:39:50 +00:00
Sergey Biryukov
ca898ccbdb Post List Table: Hierarchical post types should not default to sorting by date.
Regression introduced in [34728].

Props ellie.roepken.
Fixes #34473. See #25493.

git-svn-id: https://develop.svn.wordpress.org/trunk@35482 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-01 00:48:36 +00:00
Andrew Ozz
f64bc40f69 Responsive images: add $image_url parameter to wp_get_attachment_image_sizes() and use it in the filter. This allows themes and plugins to identify the image.
Props joemcgill.
Fixes #34477.

git-svn-id: https://develop.svn.wordpress.org/trunk@35481 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 22:48:08 +00:00
Scott Taylor
d74ab4b6df Canonical: when /%post_id%/ is the permalink structure, don't redirect IDs that match Auto Drafts.
Props SergeyBiryukov.
Fixes #29431.


git-svn-id: https://develop.svn.wordpress.org/trunk@35480 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:53:41 +00:00
Scott Taylor
bd7bf83886 Media: add a new image size, medium_large. Bumps db version to add new options.
Adds unit tests.

Props DH-Shredder, joemcgill, azaozz.
Fixes #34196.


git-svn-id: https://develop.svn.wordpress.org/trunk@35479 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:49:26 +00:00
Scott Taylor
d944108b13 WP oEmbed: Improve height attribute sanitization
Props afercia, swissspidy.
Fixes #34527.


git-svn-id: https://develop.svn.wordpress.org/trunk@35478 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:38:07 +00:00
Scott Taylor
aa616b1b45 Admin Menu: allow more than one menu item to be added at the same priority/position.
Props chriscct7.
Fixes #23316.


git-svn-id: https://develop.svn.wordpress.org/trunk@35477 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:30:06 +00:00
Scott Taylor
df134d1763 Filesystem: in WP_Filesystem_FTPext::parselisting(), check for the existence of $b['islink'] before using it.
Props jesin.
Fixes #27975.


git-svn-id: https://develop.svn.wordpress.org/trunk@35476 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:16:32 +00:00
Scott Taylor
957a800bd3 Comments: don't auto-close comments on draft posts.
Adds unit tests.

Props solarissmoke, MikeHansenMe, nacin, rachelbaker.
Fixes #20262.


git-svn-id: https://develop.svn.wordpress.org/trunk@35475 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:12:16 +00:00
Scott Taylor
14253d11b3 REST API: remove the @internal annotation from rest_api_default_filters().
Props swissspidy, rachelbaker.
Fixes #34219.


git-svn-id: https://develop.svn.wordpress.org/trunk@35474 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:07:21 +00:00
Scott Taylor
96eda396a6 Nav Menus: add responsive styles for viewport between 768 and 1000px.
Props datta.parad, chriscct7.
Fixes #28912.


git-svn-id: https://develop.svn.wordpress.org/trunk@35473 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 20:04:04 +00:00
Sergey Biryukov
fbd0b570fc Embeds: In get_post_embed_html(), move the optional $post argument after the required $width and $height.
Props swissspidy.
Fixes #34523.

git-svn-id: https://develop.svn.wordpress.org/trunk@35472 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 15:50:23 +00:00
Sergey Biryukov
29f940c5b2 Embeds: In get_oembed_response_data(), make the $post argument required.
`get_oembed_response_data()` is called by the API endpoint controller and never in a context where it makes sense to use the global post object.

Props swissspidy.
See #34523.

git-svn-id: https://develop.svn.wordpress.org/trunk@35471 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 15:42:01 +00:00
Sergey Biryukov
b0c7058037 Embeds: Fix typo in oembed_request_post_id filter DocBlock.
Props swissspidy.
See #34523.

git-svn-id: https://develop.svn.wordpress.org/trunk@35470 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 15:37:10 +00:00
Andrea Fercia
c01ce19d70 Dashboard: Activity widget CSS cleanup after [35420].
Props tyxla.
Fixes #34524. See #33558.

git-svn-id: https://develop.svn.wordpress.org/trunk@35469 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 13:48:14 +00:00
Drew Jaynes
37145d5b88 Docs: Use 3-digit, x.x.x-style semantic versioning in the DocBlocks for post_form_autocomplete_off() and WP_Filesystem_SSH2::sftp_path().
Props aaronrutley.
Fixes #34518.


git-svn-id: https://develop.svn.wordpress.org/trunk@35468 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 13:15:01 +00:00
Gary Pendergast
2edd6a894b Embeds: Revert [35083], as the PNG files ended up not being used in [35466].
See #34204.



git-svn-id: https://develop.svn.wordpress.org/trunk@35467 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 04:41:07 +00:00
Gary Pendergast
47e6c78d88 Embeds: Add fallbacks for IE7-9.
Older IE versions need just that little bit of extra tender care to keep them going.

Props peterwilsoncc, swissspidy, pento.

Fixes #34204.



git-svn-id: https://develop.svn.wordpress.org/trunk@35466 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-31 04:37:41 +00:00