Commit Graph

13 Commits

Author SHA1 Message Date
Mark Jaquith 3584dd58a9 Revisions: Cleanup, bug fixes, refactoring, polish.
* Hide the tooltip initially.
* Fix a bug with routing.
* Further separate the Slider model and view, refactoring its code.
* More reliance on events than direct calls between areas.
* Smarter background diff loading (single mode). Loads the diffs closest to your position first.
* Removed a bunch of manual templating and `render()` methods. Now relies more on the WP Backbone Views functionality.
* include the requested `id` in `ensure:load`.
* new trigger: `ensure`, for `ensure()` attempts, regardless of whether they are already loaded.
* pass along a promise in both `ensure` and `ensure:load`.
* in `ensure`, remove requests for diffs we aready have

See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24671 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 14:01:39 +00:00
Mark Jaquith b7e1e25e36 Fix a PHP 5.4-ism that slipped in.
git-svn-id: https://develop.svn.wordpress.org/trunk@24670 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 07:26:11 +00:00
Mark Jaquith 2e2ed518e9 Revisions: sort by date, not modified, to match revisions meta box.
See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24668 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 05:41:39 +00:00
Mark Jaquith d88021e236 Revisions: Loading indicator, cleanup, bug fixes.
* Loading indicator when the user is waiting for a trip to the server.
* Bug fixes for diff priming.
* Fix the date display.
* Forget about local comparator, instead order by `modified` on the server.
* Initialize the frame model before the view (this was the source of a LOT of heartache).

git-svn-id: https://develop.svn.wordpress.org/trunk@24667 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-12 05:11:56 +00:00
Mark Jaquith 1fb9b2cfa1 Revisions: real URLs and preloading of the requested diff.
* Real URLs are being used now, using pushState. `?revision={id}` or `?from={from}&to={to}`.
* Drop the redundant `action=edit` from the URLs (this is the default).
* The initial comparison is preloaded, whether a single revision or a compare-two situation.

See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24664 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-11 22:56:48 +00:00
Andrew Nacin 05006a0da4 Compare GMT to GMT. see #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24663 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-11 20:57:47 +00:00
Andrew Nacin e01a1a94bb Proper translation of '<time> ago' in revisions. props johnbillion, fixes #24721.
git-svn-id: https://develop.svn.wordpress.org/trunk@24643 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-10 16:15:18 +00:00
Mark Jaquith 8dfbe56e79 Pass back dateUnix (a unix timestamp) for better sorting of revisions in Backbone.
Props duck_. See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24615 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 19:21:25 +00:00
Daryl Koopersmith 286a44fcf6 Revisions: Debounce fetching Diffs when revisions are updated.
Fixes navigation and casting bugs.

See #24425.


git-svn-id: https://develop.svn.wordpress.org/trunk@24611 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 09:57:58 +00:00
Daryl Koopersmith 15df489ecd Revisions: Reduce points where IDs are cast in JS. See #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24605 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 07:55:50 +00:00
Dominik Schilling (ocean90) 814c36baea Revisions improvements
* Corrected routing behavior
* Simplified CSS for tooltips
* Compare two mode for RTL
* Support for posts without titles 

props adamsilverstein, ocean90. see #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24578 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-06 10:48:14 +00:00
Dominik Schilling (ocean90) b7591bb34e Revisions UI: Fix table colgroup (Say what?) for post titles when they haven't been changed. see #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24529 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-29 17:45:02 +00:00
Mark Jaquith ac0d0d1dee Cleanup of the revisions screen, both on the PHP API side, and the JS.
* Much simpler PHP API
* Cleaner and more Backbone-y JS API
* Consequently, does batch queries; this now scales up to hundreds of revisions

Currently missing, but much easier considering the cleaned up base:

* Compare two mode
* RTL

props koopersmith, nacin, adamsilverstein, ocean90. see #24425

git-svn-id: https://develop.svn.wordpress.org/trunk@24520 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-26 21:06:50 +00:00