Commit Graph

24915 Commits

Author SHA1 Message Date
Scott Taylor a386be33d5 Add some JSDoc annotations to `media-models.js` to disambiguate instance properties and static class properties/methods in the base media Models.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27031 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-25 07:38:12 +00:00
Andrew Ozz be31ef4b65 TinyMCE: fix the compat3x plugin appending 'en.' to button titles. Set charset to UTF-8 in html_entity_decode() for translated strings. See #24067, see #26875.
git-svn-id: https://develop.svn.wordpress.org/trunk@27030 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-25 01:20:04 +00:00
Andrew Ozz 48d24f6bf5 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.
git-svn-id: https://develop.svn.wordpress.org/trunk@27029 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 19:05:15 +00:00
Dominik Schilling (ocean90) 07bbb5cd1f Update to jQuery UI 1.10.4. fixes #26884.
git-svn-id: https://develop.svn.wordpress.org/trunk@27028 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 17:43:40 +00:00
Dominik Schilling (ocean90) cad7870533 Update to jQuery 1.11.0. fixes #26926.
git-svn-id: https://develop.svn.wordpress.org/trunk@27027 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 17:39:35 +00:00
Andrew Nacin 7bb628ec3b Docs fix: edit_comment_link() doesn't actually return anything.
props Corphi.
fixes #26436.


git-svn-id: https://develop.svn.wordpress.org/trunk@27026 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 07:16:37 +00:00
Andrew Nacin f70f020c54 Properly detect line height of Quick Draft textarea.
props batmoo.
fixes #26915 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@27021 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-23 18:02:06 +00:00
Sergey Biryukov 18da726943 Fix typo in CSS. props ciantic, MikeHansenMe. fixes #26898.
git-svn-id: https://develop.svn.wordpress.org/trunk@27020 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-23 12:21:11 +00:00
Sergey Biryukov 344bcddbf7 Remove byte order mark (BOM) from GetUrlInContent.php. see #26171.
git-svn-id: https://develop.svn.wordpress.org/trunk@27019 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-23 09:49:27 +00:00
Scott Taylor 956aa1c8ab Fix imperceptible whitespace cruff from [27017].
git-svn-id: https://develop.svn.wordpress.org/trunk@27018 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 22:34:49 +00:00
Scott Taylor 4725e85857 Fix a bit of whitespace from [27016].
git-svn-id: https://develop.svn.wordpress.org/trunk@27017 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 22:33:28 +00:00
Scott Taylor 300cb7451e Let `is_attachment()` accept an $attachment parameter, similar to `is_page()` and `is_single()`. Adds Unit Tests for all 3.
Props alex-ye for the initial patch.
Fixes #24257.



git-svn-id: https://develop.svn.wordpress.org/trunk@27016 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 22:30:36 +00:00
Andrew Ozz b29b5b21e4 Autosave: don't set "submit" buttons to disabled right before submitting the form. They are not sent with the form data, see #25272.
git-svn-id: https://develop.svn.wordpress.org/trunk@27015 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 21:25:05 +00:00
Andrew Nacin b663efb313 Themes screen: Add aria-describedby attributes to provide better information to screen readers.
props joedolson for initial patch.
fixes #26602 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@27012 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 20:59:29 +00:00
Andrew Ozz 92d2f34d4f Improve keyboard accessibility for the admin menu when in responsive mode, props SergeyBiryukov, fixes #26639 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@27011 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 20:07:16 +00:00
Andrew Nacin 0b5a18c519 Themes screen: Various IE8 adjustments and fixes.
props morganestes, matveb.
fixes #26541.


git-svn-id: https://develop.svn.wordpress.org/trunk@27007 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:53:34 +00:00
Matt Thomas eac3ccc29a Responsive improvements to submenus in the adminbar:
- Remove .ab-sub-wrapper rules in the 782px media query, as they're duplicates of the rules set on line 161.
- Reposition the arrows for submenus at responsive sizes where the menus are taller.
- Set the submenu position to static at smartphone sizes, so it's not positioned outside of its parent (and thus offscreen).

Fixes #26720, props undergroundnetwork, iammattthomas.




git-svn-id: https://develop.svn.wordpress.org/trunk@27006 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:37:42 +00:00
Scott Taylor 36346f9c51 Add inline docs to each method of the namespaced objects in `media-editor.js`, explaining what each does. Add inline docs to params as well.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27005 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:37:08 +00:00
Andrew Ozz 5aa4902c7d TinyMCE: fix initializing TinyMCE when the default editor in getUserSetting() is overridden from PHP by using the 'wp_default_editor' filter. See #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@27004 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 18:16:39 +00:00
azaozz db64b3d951 Autosave: don't disable the buttons on previewing a post, see #25272.
git-svn-id: https://develop.svn.wordpress.org/trunk@27003 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 17:57:13 +00:00
wonderboymusic ba1c9e0c22 Add the `@namespace` annotation where appropriate in `media-editor.js`. Also indicate the default value of a few params via the [options={}] syntax.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27000 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 17:16:56 +00:00
nacin ce00f36ab7 Dashboard widgets: Don't link to Pages or Posts for Authors or Contributors respectively.
props mattheu.
see #26574 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@26999 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 16:51:07 +00:00
Nikolay Bachiyski 46bdc2c312 Excplitcly globalized call to $wp later in wp-settings.php
Props xknown, fixes #26867.


git-svn-id: https://develop.svn.wordpress.org/trunk@26997 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 14:47:58 +00:00
Nikolay Bachiyski 5eba2a13d8 Explicitly globalize some missing query globals in wp-settings.php
When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be.

Fixes #26867


git-svn-id: https://develop.svn.wordpress.org/trunk@26996 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 08:24:50 +00:00
Andrew Ozz 9aba880b53 Autosave: refactor autosave.js, use heartbeat for transport and move all "Add/Edit Post" related functionality to post.js. See #25272.
git-svn-id: https://develop.svn.wordpress.org/trunk@26995 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 04:55:37 +00:00
Andrew Ozz df613abbec TinyMCE: fix error trying to translate non-existent button "title" in the compat3x plugin. See #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@26994 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-22 02:28:13 +00:00
Matt Thomas 275d589503 Eliminate the 1px padding adjustment on active buttons because it creates an un-clickable dead zone 1px high and spanning the entire width of the button. Modify the background color of active buttons for better contrast to make the active state more obvious.
See #26700, props johnbillion.



git-svn-id: https://develop.svn.wordpress.org/trunk@26993 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-21 21:26:31 +00:00
Scott Taylor 2f60bcab82 Make some `@param` types more specific in `media-models.js`.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@26991 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-21 17:36:24 +00:00
Scott Taylor 5a1a2e872e Remove debug cruft.
Props nacin.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@26990 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-21 16:30:57 +00:00
Scott Taylor de01111ae7 Disambiguate `this` and use the `@this` annotation in `media-editor.js`. This will become way more necessary in other places, but a few examples here show how confusing it can be.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@26989 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-21 16:29:30 +00:00
Scott Taylor 5c0a09ce40 Correct a type.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@26988 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-21 15:56:49 +00:00
Scott Taylor 9ad06a2956 Elaborate on JSDoc blocks for `media-editor.js`.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@26987 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-21 15:54:27 +00:00
Scott Taylor 1d3061effc Add initial JSDoc blocks to `media-views.js`. The initial blocks are a baseline to work from and invite future iterations. Initial commit is to avoid commits this large in the future.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@26986 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-20 23:41:42 +00:00
Scott Taylor 896e71271e Add initial JSDoc blocks to `media-models.js`. The initial blocks are a baseline to work from and invite future iterations. Initial commit is to avoid commits this large in the future.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@26985 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-20 23:39:44 +00:00
Scott Taylor 673c615d87 Add initial JSDoc blocks to `media-editor.js`. The initial blocks are a baseline to work from and invite future iterations. Initial commit is to avoid commits this large in the future.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@26984 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-20 23:34:57 +00:00
Andrew Ozz 1bc97d1fe4 TinyMCE: add a custom jQuery event 'tinymce-editor-init' triggered on initialization of every editor instance. This makes it a lot more convenient to hook into the instance compared to the init.setup callback. See #24067, see #26872.
git-svn-id: https://develop.svn.wordpress.org/trunk@26983 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-19 23:21:07 +00:00
Andrew Ozz ae49162491 TinyMCE: fix 3.x callbacks added with init.setup as they run before the compat3x plugin is loaded. Ideally this will be fixed internally in TinyMCE, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@26982 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-18 22:19:07 +00:00
Drew Jaynes f2d4a6aa36 Hook docs spacing and standards fixes for wp-admin/includes/ajax-actions.php.
See #25374.


git-svn-id: https://develop.svn.wordpress.org/trunk@26981 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-18 17:05:38 +00:00
Drew Jaynes f1bfee89f9 Use a docs-specific variable for the `link_category` hook docs in wp-admin/bookmarks-template.php.
See #25364.


git-svn-id: https://develop.svn.wordpress.org/trunk@26980 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-18 16:58:01 +00:00
Andrew Ozz 89a63c8f43 TinyMCE: set the 'add_unload_trigger' option to false for the main editor. Prevents DOM problems in Firefox when reloading the page, see #24067.
git-svn-id: https://develop.svn.wordpress.org/trunk@26979 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 20:34:12 +00:00
Andrew Nacin d0bb9e8f86 Ensure that SSL YouTube URLs receive SSL embeds.
props adamsilverstein, Otto42, JayCC.
fixes #23149.


git-svn-id: https://develop.svn.wordpress.org/trunk@26978 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 19:45:51 +00:00
Scott Taylor 9b9de4ee1f Add `jsvalidate` as a dependency to the build. To get the new module, run `npm install` in the root of the project.
Fixes #26615.
Props jorbin.



git-svn-id: https://develop.svn.wordpress.org/trunk@26977 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 18:14:15 +00:00
Scott Taylor 1a4a017923 Add (Q)Unit Tests for the `wp.shortcode` JS class.
Fixes #26514.
Props jorbin.



git-svn-id: https://develop.svn.wordpress.org/trunk@26976 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 18:01:34 +00:00
Andrew Nacin 5d8627f6c9 Use the_title_attribute() in feed_links_extra(), rather than get_the_title().
props c3mdigital.
fixes #15046.


git-svn-id: https://develop.svn.wordpress.org/trunk@26975 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 09:52:05 +00:00
Andrew Nacin 5cb20092ce make_clickable: When cleaning up accidental links within links, account for the tag being split by newlines.
props dd32.
fixes #19028.


git-svn-id: https://develop.svn.wordpress.org/trunk@26974 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 09:31:59 +00:00
Andrew Nacin 67d1c9fd6d Add dfn, mark, and samp to kses.
props kraftbj.
fixes #24950.


git-svn-id: https://develop.svn.wordpress.org/trunk@26973 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 08:37:53 +00:00
Andrew Nacin 9f5c78b676 Unit tests for get_url_in_content(). Return false when no content is passed, to match the return value of no links being found.
props mdbitz.
#26171.


git-svn-id: https://develop.svn.wordpress.org/trunk@26972 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 07:46:33 +00:00
Andrew Nacin 238f9d2b0a Add a contrasting border to admin feature pointers.
props iammattthomas.
see #26689.


git-svn-id: https://develop.svn.wordpress.org/trunk@26970 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 03:48:50 +00:00
Andrew Nacin e1aeeacc43 Realign the oEmbed providers. see #26844.
git-svn-id: https://develop.svn.wordpress.org/trunk@26968 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 03:28:30 +00:00
Andrew Nacin 015b1398ca Switch Twitter oEmbed to SSL due to a Twitter API change. Ah, the open web.
props yurivictor, cojennin.
see #26844.


git-svn-id: https://develop.svn.wordpress.org/trunk@26967 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-17 03:25:29 +00:00