sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
30,014 Commits 2 Branches 473 Tags 137 MiB
52cfab850f
Commit Graph

64 Commits

Author SHA1 Message Date
Scott Taylor
52cfab850f After [32740], in WP_Posts_List_Table::single_row() - $lock_holder is checked but unused, so the call to get_userdata() is unnecessary. 
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32742 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-12 20:47:46 +00:00
Scott Taylor
7fbeffec20 After [32740], correct doc block typo. 
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32741 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-12 20:28:22 +00:00
Scott Taylor
1de436b466 Override ->single_row_columns() in WP_Posts_List_Table. 
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.

This list table class is now easier to subclass.

Props joehoyle, wonderboymusic.
See #29881.


git-svn-id: https://develop.svn.wordpress.org/trunk@32740 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-12 20:17:59 +00:00
Scott Taylor
8463ad6f29 In WP_Posts_List_Table::single_row(): 
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32738 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-12 18:49:18 +00:00
Konstantin Obenland
995753d1d0 Improve non-visual feedback for list table items without terms. 
Props karpstrucking, afercia.
Fixes #32150.



git-svn-id: https://develop.svn.wordpress.org/trunk@32725 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-11 09:27:13 +00:00
Helen Hou-Sandi
c2ed5b170d List tables: Use a class instead of inline styles for hidden columns. 
fixes #32608.


git-svn-id: https://develop.svn.wordpress.org/trunk@32724 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-10 19:46:39 +00:00
Helen Hou-Sandi
615ab22fea List tables: Consolidate <td> output for posts. 
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32721 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-10 14:00:55 +00:00
Drew Jaynes
cb1ea6f5c8 Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Posts_List_Table. 
See #25408. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32668 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 01:41:28 +00:00
Scott Taylor
c49c139a22 Add @access annotations to methods that have no doc block in wp-admin/includes/*. 
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32656 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-29 21:31:56 +00:00
Scott Taylor
ec5758225c Add missing doc blocks to wp-admin/includes/*. 
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32654 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-29 20:16:22 +00:00
Helen Hou-Sandi
86c907d2a5 List tables: introduce the concept of a "primary" column. 
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@32644 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-29 02:40:52 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-28 21:40:27 +00:00
Sergey Biryukov
2848b8a911 Replace echo __() with _e(). 
props marsjaninzmarsa.
fixes #32239.

git-svn-id: https://develop.svn.wordpress.org/trunk@32333 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-03 16:17:06 +00:00
Sergey Biryukov
345d34cad9 Bulk Edit: Properly associate the Format select with its label. 
props afercia.
fixes #32210.

git-svn-id: https://develop.svn.wordpress.org/trunk@32329 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-30 16:03:06 +00:00
Drew Jaynes
58ee5beced Fix filter doc vernacular for the quick_edit_show_taxonomy filter. 
See [31308]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32011 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-04 16:07:48 +00:00
Drew Jaynes
d0d60543ae Fix syntax for the $to_display parameter description in the DocBlock for WP_Posts_List_Table->_page_rows(). 
See [31730]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32010 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-04 16:03:20 +00:00
Drew Jaynes
472b335948 Add a return description to the DocBlock for WP_Posts_List_Table->is_base_request(). 
See [31828]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32009 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-04 16:00:08 +00:00
Scott Taylor
8f8c526a56 In WP_Posts_List_Table::get_views(), don't add the current class to the all status link if ->user_posts_count has a value, which triggers the additional mine status. 
See [31828].
Fixes #24869.


git-svn-id: https://develop.svn.wordpress.org/trunk@31959 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-01 16:17:01 +00:00
Dominik Schilling (ocean90)
501aeeaaa6 Improve alignment of labels and inputs in Quick Edit. 
props mattheu, valendesigns.
fixes #31408.

git-svn-id: https://develop.svn.wordpress.org/trunk@31890 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-25 22:24:37 +00:00
Dion Hulse
9eb9342a54 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified. 
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121


git-svn-id: https://develop.svn.wordpress.org/trunk@31862 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-23 02:13:50 +00:00
Sergey Biryukov
850e6b2278 After [31730], replace one more instance of array_shift() with reset() for better performance. 
see #31259, #15459.

git-svn-id: https://develop.svn.wordpress.org/trunk@31841 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-20 01:56:10 +00:00
Scott Taylor
c74d9e6d1c Add WP_Posts_List_Table::is_base_request() to determine if the current "view" is the "All" (default) view. 
Fixes #24869.


git-svn-id: https://develop.svn.wordpress.org/trunk@31828 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-19 02:25:05 +00:00
John Blackbourn
82ac76c0a7 Introduce a new algorithm for displaying a hierarchical list of post objects in the WP_Posts_List_Table. This reduces processing time, reduces database queries, and substantially reduces memory use on sites with a high number of Pages. 
Props nofearinc, rodrigosprimo, nacin, johnbillion.
Fixes #15459


git-svn-id: https://develop.svn.wordpress.org/trunk@31730 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-11 20:45:17 +00:00
Andrew Ozz
825fa21a22 Improve table footer tab sequence by moving <tfoot> after <tbody>. Props afercia, rianrietveld, DrewAPicture. Fixes #30914. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31513 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-22 21:47:30 +00:00
Helen Hou-Sandi
8d0b774e65 Accessibility: remove remaining instances of accesskey. 
It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve.

props afercia.
fixes #29715.


git-svn-id: https://develop.svn.wordpress.org/trunk@31331 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-04 03:45:24 +00:00
Boone Gorges
c7320c5a86 Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases. 
See #26948.

git-svn-id: https://develop.svn.wordpress.org/trunk@31308 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-30 19:28:27 +00:00
Boone Gorges
057c428346 Introduce 'show_in_quick_edit' parameter for register_taxonomy(). 
Setting 'show_in_quick_edit' to false when registering a custom taxonomy will
hide the taxonomy when editing posts using Quick Edit.

The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered
on a finer scale, as when you want a given taxonomy to be hidden for one post
type but not for others.

Props hlashbrooke.
Fixes #26948.

git-svn-id: https://develop.svn.wordpress.org/trunk@31307 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-30 19:17:51 +00:00
Scott Taylor
357fa4131a Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions: 
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`. 
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31220 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 22:50:20 +00:00
Scott Taylor
83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.


git-svn-id: https://develop.svn.wordpress.org/trunk@31200 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 04:15:52 +00:00
Helen Hou-Sandi
8ab449ae35 List tables: Use CSS :nth-child() selectors for zebra striping. 
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.


git-svn-id: https://develop.svn.wordpress.org/trunk@31181 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-14 22:13:03 +00:00
Scott Taylor
b3f726efc4 Add a private field to WP_Posts_List_Table, $is_trash. 
See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31165 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 16:21:08 +00:00
Scott Taylor
04ed6499cd Improve some wp-admin/includes/class-wp-filesystem-*.php docs for @param. 
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30978 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 20:39:41 +00:00
Scott Taylor
c0045bda84 Improve various @param docs for List Tables. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30679 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-01 00:32:19 +00:00
Drew Jaynes (DrewAPicture)
f45fd382b3 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*. 
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30648 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 11:27:19 +00:00
John Blackbourn
c33b85fd39 Add a filter to the displayed title of the default page template. 
Fixes #27178
Props johnstonphilip


git-svn-id: https://develop.svn.wordpress.org/trunk@30360 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-16 19:32:00 +00:00
Sergey Biryukov
ac90567ef1 Use proper functions for escaped translations. 
pros jcastaneda.
fixes #30012.

git-svn-id: https://develop.svn.wordpress.org/trunk@29961 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-18 20:10:47 +00:00
Sergey Biryukov
c50be6a735 Remove "View" prefix from category filter dropdowns, for consistency with [27626]. 
props afercia.
see #29921.

git-svn-id: https://develop.svn.wordpress.org/trunk@29871 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-11 02:22:08 +00:00
Sergey Biryukov
8d2f5d0cc5 Add missing labels to category filter dropdowns. 
props afercia.
fixes #29921.

git-svn-id: https://develop.svn.wordpress.org/trunk@29870 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-11 02:20:05 +00:00
Scott Taylor
e97e5048c3 If the current user does not have the delete_posts cap on the current post type, don't list delete or trash as bulk actions for the relevant context of Post list table. 
Props mvd7793.
Fixes #20175.


git-svn-id: https://develop.svn.wordpress.org/trunk@29757 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-23 02:57:43 +00:00
Andrew Nacin
ca32a2d410 Pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29707 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 15:22:58 +00:00
Drew Jaynes (DrewAPicture)
39ba840e04 Add @access tags to constructor docblocks in list table classes. 
See #28679. See [29459].


git-svn-id: https://develop.svn.wordpress.org/trunk@29460 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-10 02:21:56 +00:00
Drew Jaynes (DrewAPicture)
126147a877 Document default arguments for the WP_List_Table class. Also add referenced docblocks to extending class constructors. 
Props mikejolley for the initial patch.
Fixes #28679. See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29459 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-10 02:17:14 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files. 
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-17 09:13:53 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses. 
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-13 22:08:22 +00:00
Scott Taylor
63cb20cc5a Repent for our original OOP sins and doc blocks as pertains to access modifiers in List Table + subclasses. 
Props SergeyBiryukov.
See #28843 and [28583].


git-svn-id: https://develop.svn.wordpress.org/trunk@29118 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-12 03:26:40 +00:00
Sergey Biryukov
8bf7ed77f3 Pass $post object to 'preview_post_link' filter. 
props danielbachhuber.
fixes #28729.

git-svn-id: https://develop.svn.wordpress.org/trunk@28969 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-03 14:41:06 +00:00
Sergey Biryukov
29aabd08a9 Prevent bulk actions from being performed when Filter button is clicked. 
props jesin.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28916 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-30 01:09:25 +00:00
Helen Hou-Sandi
9becde117d Make the posts list table mode a sticky user setting. props garyc40, azaozz, ericmann. fixes #16774, #20335. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28876 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-28 02:16:59 +00:00
Scott Taylor
7ab6b096e6 Remove some dead variable assignments. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 16:58:36 +00:00
Scott Taylor
d6a3c2a0de Add access modifiers to methods and members of list table classes: 
* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:16:16 +00:00