Sergey Biryukov
7e521e68dc
Docs: Fix typos in `wp-admin/includes/class-pclzip.php`.
...
With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes.
Props passoniate, ottok.
Fixes #49163 . See #38464 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47123 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:54:21 +00:00
Sergey Biryukov
cfc3b57488
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47122 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:43:23 +00:00
Sergey Biryukov
bd2cd572aa
Docs: Improve DocBlocks in `phpunit/includes/object-cache.php` per the documentation standards.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47121 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:36:17 +00:00
Sergey Biryukov
c9663d78cf
Docs: Improve comments in `js/_enqueues/wp/revisions.js` per the documentation standards.
...
Props passoniate.
Fixes #49177 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47120 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:35:39 +00:00
Sergey Biryukov
6bdc961d5f
Docs: Improve comments in some `wp-admin` files per the documentation standards.
...
Follow-up to [47084].
Props passoniate, apedog.
Fixes #49223 , #49227 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47119 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:33:45 +00:00
Sergey Biryukov
48110faf25
Coding Standards: Disable WPCS warnings for `date_default_timezone_set()` and `current_time( 'timestamp' )` calls in Date/Time tests.
...
These calls are intentional and required for the tests.
See #49222 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47118 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-28 00:51:42 +00:00
Sergey Biryukov
c1abc8203a
Docs: Fix typo in a comment in `js/media/models/attachment.js`.
...
Props wptoolsdev.
Fixes #49303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47117 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-27 14:42:37 +00:00
Sergey Biryukov
1160c97303
Customize: Fix typo in `CustomHeader.prototype.initialize()` DocBlock in `src/js/_enqueues/wp/custom-header.js`.
...
Props ankitmaru.
Fixes #49301 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47116 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-27 14:32:00 +00:00
Sergey Biryukov
50aa7f980c
Coding Standards: Use strict comparison in `wp-admin/user/admin.php`.
...
Apply the case-insensitive network-site comparisons added in [27725] for `wp-admin/network/admin.php` to `wp-admin/user/admin.php` too, for consistency.
Props rimadoshi.
Fixes #49300 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47115 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-27 14:28:12 +00:00
Sergey Biryukov
d5e20d8ab5
Comments: Add `In reply to: %s` parent comment link to new comment email notifications.
...
This information was previously available on the Moderate Comment screen in the admin, but was missing from moderation emails.
Props imath, danieltj, andraganescu, galbaras, SergeyBiryukov.
Fixes #43805 . See #43429 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47114 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-27 04:31:48 +00:00
Sergey Biryukov
191f798201
Docs: Remove extra trailing spaces from `wp_add_privacy_policy_content()` DocBlock to fix WPCS issues, apply minor formatting changes for consistency.
...
Follow-up to [47112].
See #49282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47113 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-27 01:04:08 +00:00
Andrew Ozz
9224e14e67
Privacy: Cleanup `.wp-policy-help` CSS remnants and add back-compat when hiding the tutorial content before copying.
...
Props garrett-eclipse.
Fixes #49282 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47112 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-26 23:00:54 +00:00
Sergey Biryukov
ffb9ef6d52
Comments: Add `In reply to %s.` prefix to child comments in comments feed.
...
The prefix includes a link to the parent comment and the name of its author.
Props zodiac1978, imath, SergeyBiryukov.
Fixes #43429 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47111 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-26 22:27:08 +00:00
Sergey Biryukov
3e3b98aad7
Twenty Twenty: Remove unnecessary escaping of `get_the_title()` in `comments.php`.
...
For users with the `unfiltered_html` capability, titles can contain legitimate markup.
The title is filtered on saving, so the content in the database is considered safe.
Props kjellr, joyously, peterwilsoncc.
Fixes #49190 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47110 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-25 22:04:08 +00:00
Sergey Biryukov
8e6c884e87
Docs: Improve documentation for `add_user_to_blog()`, `add_existing_user_to_blog()`, and `add_new_user_to_blog()`.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47109 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-24 17:18:37 +00:00
Andrea Fercia
67f246b9b0
Toolbar: Remove leftover `@since` notations after [46678].
...
See #19647 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47108 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-23 12:57:41 +00:00
Sergey Biryukov
e7303345ae
Cache API: Remove `WP_Object_Cache::__destruct()` and `wpdb::__destruct()`.
...
Originally added in [4686], these constructor/destructor pairings were designed to prevent the objects from being destroyed before shutdown, when output buffers are flushed.
A deeper investigation reveals that this approach didn't quite work as expected and was later made redundant by introducing `wp_ob_end_flush_all()` in [5462].
Props wonderboymusic, nacin, Mte90, SergeyBiryukov.
Fixes #21402 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47107 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-23 00:25:38 +00:00
Jorge Costa
1c006d724b
Block Editor: Update WordPress Packages.
...
The following package versions were changed:
@wordpress/a11y: 2.5.1 -> 2.6.0
@wordpress/annotations: 1.9.0 -> 1.10.0
@wordpress/api-fetch: 3.8.0 -> 3.9.0
@wordpress/blob: 2.5.1 -> 2.6.0
@wordpress/block-directory: 1.2.0 -> 1.3.0
@wordpress/block-editor: 3.4.0 -> 3.5.0
@wordpress/block-library: 2.11.0 -> 2.12.0
@wordpress/blocks: 6.9.0 -> 6.10.0
@wordpress/components: 8.5.0 -> 9.0.0
@wordpress/compose: 3.9.0 -> 3.10.0
@wordpress/core-data: 2.9.0 -> 2.10.0
@wordpress/data: 4.11.0 -> 4.12.0
@wordpress/data-controls: 1.5.0 -> 1.6.0
@wordpress/dom: 2.6.0 -> 2.7.0
@wordpress/dom-ready: 2.5.1 -> 2.6.0
@wordpress/e2e-test-utils: 4.0.0 -> 4.1.0
@wordpress/edit-post: 3.10.0 -> 3.11.0
@wordpress/editor: 9.9.0 -> 9.10.0
@wordpress/format-library: 1.11.0 -> 1.12.0
@wordpress/i18n: 3.7.0 -> 3.8.0
@wordpress/is-shallow-equal: 1.6.1 -> 1.7.0
@wordpress/keycodes: 2.7.0 -> 2.8.0
@wordpress/list-reusable-blocks: 1.10.0 -> 1.11.0
@wordpress/media-utils: 1.4.0 -> 1.5.0
@wordpress/notices: 1.10.0 -> 1.11.0
@wordpress/nux: 3.9.0 -> 3.10.0
@wordpress/plugins: 2.9.0 -> 2.10.0
@wordpress/priority-queue: 1.3.1 -> 1.4.0
@wordpress/rich-text: 3.9.0 -> 3.10.0
@wordpress/scripts: 6.1.1 -> 6.2.0
@wordpress/server-side-render: 1.5.0 -> 1.6.0
@wordpress/viewport: 2.10.0 -> 2.11.0
The following package was added:
@wordpress/keyboard-shortcuts
Props gziolo.
Fixes #49204 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47106 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 22:04:35 +00:00
Ian Dunn
05a2cd6f71
Multisite: Add `$context` parameter to `switch_blog` action.
...
The action is fired by both `switch_to_blog()` and `restore_current_blog()`, and previously it was difficult for callback functions to determine which function had fired it.
Props SergeyBiryukov, johnbillion, jeremyfelt.
Fixes #49265 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47105 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 20:51:26 +00:00
Sergey Biryukov
e1348046ac
Docs: Expand `@return` value description for `wp_loginout()`, `wp_register()`, `get_calendar()`.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47104 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:55:13 +00:00
Sergey Biryukov
dbe67c4586
Docs: Expand `@return` description for `the_terms()`.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47103 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:39:32 +00:00
Sergey Biryukov
8295b56d9c
Docs: Correct `@return` value for `parent_dropdown()`.
...
Follow-up to [47100].
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47102 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:31:17 +00:00
Sergey Biryukov
5db9ef75c9
Docs: Adjust documentation for some `pre_*` filters for consistency.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47101 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:23:09 +00:00
Sergey Biryukov
8133a247bd
Docs: Adjust `@return` value of `parent_dropdown()` for consistency with other dropdown functions.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47100 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:20:21 +00:00
Sergey Biryukov
80e4ef45f1
Docs: Correct `@return` value for `update_core()` and `Core_Upgrader::upgrade()`.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47099 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-22 00:17:24 +00:00
Sergey Biryukov
af39b30e28
Date/Time: In `wp_maybe_decline_date()`, add support for a range of days, e.g. `February 21–23`.
...
A potential use case is displaying multi-day events in the WordPress Events and News dashboard widget.
See #47798 , #48934 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47098 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-21 23:46:36 +00:00
Sergey Biryukov
1bf8b94129
Docs: Expand `@return` value description for `wp_nav_menu()`.
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47097 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-21 20:11:11 +00:00
Sergey Biryukov
79391187c9
Docs: Correct DocBlock formatting for filters accepting the `$parsed_args` parameter.
...
Follow-up to [45667].
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47096 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-21 15:39:17 +00:00
Sergey Biryukov
8753725a3d
I18N: Merge duplicate "you must be logged in to comment" strings.
...
Props ramiy.
Fixes #49251 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47095 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-21 14:51:00 +00:00
Sergey Biryukov
ad2261bfdd
I18N: Synchronize MediaElement.js translation strings with the currently bundled version.
...
Some strings were previously removed in [43345] and accidentally reintroduced in [44163].
Props ramiy.
Fixes #49249 . See #42139 , #37453 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47094 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-21 02:19:04 +00:00
Sergey Biryukov
9b5ac0f6b6
I18N: Add missing placeholders to some translators comments in `wp-admin`.
...
Props ramiy.
Fixes #49248 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47093 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 15:41:50 +00:00
Sergey Biryukov
49402824a1
I18N: Correct translator comment in `wp-admin/options-permalink.php`.
...
Props ramiy.
Fixes #49247 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47092 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 15:08:45 +00:00
Sergey Biryukov
26f27a24d8
I18N: Merge duplicate `%1$s is not of type %2$s` strings in `rest_validate_value_from_schema()`.
...
Props ramiy.
Fixes #49244 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47091 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 14:42:12 +00:00
Sergey Biryukov
8738b08b2e
I18N: Remove unnecessary HTML from "Active:" strings in `wp-admin/themes.php`.
...
Follow-up to [45435].
Props ramiy.
Fixes #49243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47090 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 14:25:13 +00:00
Sergey Biryukov
5f937b4c70
I18N: Correct translator comments in `WP_Users_List_Table::get_views()` to provide information about each placeholder.
...
Props ramiy.
Fixes #49242 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47089 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 14:06:57 +00:00
Sergey Biryukov
a8f4ed69de
Docs: Update links to https://secure.php.net/ , they now redirect to https://www.php.net/ .
...
See #48303 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47088 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 03:12:12 +00:00
Sergey Biryukov
88836de35c
Docs: Correct description for `shortcode_atts_{$shortcode}` filter.
...
Props glebkema.
Fixes #49225 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47087 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-19 13:39:21 +00:00
Sergey Biryukov
480b5c88c3
Mail: Remove angle brackets from password reset URL in emails sent by `retrieve_password()` and `wp_new_user_notification()`.
...
The brackets were originally added in [16285] per W3C recommendation in https://www.w3.org/Addressing/URL/5.1_Wrappers.html to avoid wrapping the URL across multiple lines in plain text in older email clients.
This doesn't seem like a common issue in modern email clients, and the current implementation causes more issues than it solves. Since the URL is on a line by itself, it should not require any delimiters.
The URL in recovery mode email introduced in [44973] doesn't have angle brackets, so it's time to retire them in password reset email too if they're not used consistently.
Props donmhico, Otto42, sproutchris, iandunn, dd32, DaveWP196, sebastian.pisula, tommix, sablednah, julian.kimmig, Rahe, clayisland, arenddeboer, nicole2292, nagoke, squarecandy, eatingrules, SergeyBiryukov.
Fixes #21095 , #23578 , #44589 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47086 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 02:30:24 +00:00
Sergey Biryukov
5d8f784daa
Networks and Sites: Clarify the recommendation to remove the `www` prefix from the site domain before creating a network.
...
The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL.
Props kharisblank, tobifjellner, ramiy.
Fixes #49214 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47085 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 01:13:12 +00:00
Sergey Biryukov
89dc54ee0c
Docs: Improve comments in some `wp-admin` files per the documentation standards.
...
Props passoniate.
Fixes #49215 , #49216 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47084 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 00:52:28 +00:00
Sergey Biryukov
bd59d22a81
Coding Standards: Remove unnecessary `// phpcs:ignore` instances in `WP_Debug_Data`.
...
`WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too.
Additionally, remove one short ternary instance, not allowed per the coding standards.
See #49222 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47083 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-18 00:24:57 +00:00
Sergey Biryukov
b02161c98e
Widgets: Remove extra padding from number inputs in Recent Posts and Recent Comments widgets.
...
Props marcio-zebedeu, audrasjb, SergeyBiryukov.
Fixes #49195 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47082 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 13:55:22 +00:00
Sergey Biryukov
8660569e82
Date/Time: Add some basic tests for `current_time()`.
...
Props pbearne, talldanwp, SergeyBiryukov.
Fixes #34378 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47081 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 02:50:39 +00:00
Sergey Biryukov
0ead760ec6
Tests: Replace `date()` with `gmdate()` in `WP_Test_REST_Posts_Controller` tests.
...
Follow-up to [45424], [46252].
See #46438 , #44491 , #39953 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47080 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 02:02:41 +00:00
Sergey Biryukov
a2978bac70
Tests: Update the `wp_maybe_decline_date()` tests for [47078].
...
See #48934 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47079 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 01:14:24 +00:00
Sergey Biryukov
5bef137806
Date/Time: Pass the date format to `wp_maybe_decline_date()`.
...
This ensures that the function has enough context to determine the necessity of replacing the month name with the correct form in locales that require it.
Props SergeyBiryukov, Rarst.
Fixes #48934 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47078 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 01:10:57 +00:00
Sergey Biryukov
93b2d5ecc0
Tests: Revert [47076], this should have been committed with the related changes to the function.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@47077 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 01:08:28 +00:00
SergeyBiryukov
abfca60342
Tests: Move `wp_maybe_decline_date()` tests to the `date` directory.
...
See #48934 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47076 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-17 00:54:02 +00:00
Sergey Biryukov
900b3fd6a8
Accessibility: Login and Registration: Add a `role="main"` landmark to the container div in `wp-signup.php`.
...
Props SteelWagstaff, audrasjb.
Fixes #48657 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47075 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-16 03:42:38 +00:00
Sergey Biryukov
6baa60ac68
Login and Registration: Remove duplicate `<label>` tag from `show_blog_form()` in `wp-signup.php`.
...
Props vaishalipanchal, audrasjb.
Fixes #49174 .
git-svn-id: https://develop.svn.wordpress.org/trunk@47074 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-16 00:32:56 +00:00