Commit Graph

27183 Commits

Author SHA1 Message Date
Scott Taylor 91517ce620 Clarify that `get_the_date()`, `get_the_time()`, `get_post_time()` and `get_post_modified_time()` should return `false` when `get_post()` is `null`.
Adds unit tests.

Props GaryJ, SergeyBiryukov, tollmanz.
Fixes #28310.


git-svn-id: https://develop.svn.wordpress.org/trunk@29344 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:39:22 +00:00
Helen Hou-Sandi 8b45f96cba Use the word "Count" instead of the post type label in taxonomy list tables to prevent layout issues. It is also more accurate, as it represents a count of all post types, not just one.
props philipjohn, GaVrA, seanchayes. fixes #17209.


git-svn-id: https://develop.svn.wordpress.org/trunk@29343 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:31:52 +00:00
Scott Taylor 0ee7c9c678 Update unit tests for `sanitize_file_name()` after [29290].
git-svn-id: https://develop.svn.wordpress.org/trunk@29342 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:29:46 +00:00
Scott Taylor 7677eb2f8e Account for `WP_IMPORTING` being defined in the unit tests added in [29339] when all tests are run.
Glory, glory hallelujah.

Fixes #28315.


git-svn-id: https://develop.svn.wordpress.org/trunk@29341 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:27:16 +00:00
Mark Jaquith a46a981daa Match background color in DFW and adapt the dashed outline color.
fixes #28330. props avryl, ipstenu.

git-svn-id: https://develop.svn.wordpress.org/trunk@29340 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:09:47 +00:00
Scott Taylor 5686f4511a Bail on `update_user_meta()` when `$object_id` is non-numeric.
Adds unit test.

Props jacklenox, wonderboymusic.
Fixes #28315.


git-svn-id: https://develop.svn.wordpress.org/trunk@29339 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 17:09:53 +00:00
Helen Hou-Sandi 758b290d02 Remove remaining title attributes from default-widgets.php, with the exception of the one on the link to WordPress.org. fixes #26552.
git-svn-id: https://develop.svn.wordpress.org/trunk@29338 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 17:04:30 +00:00
Scott Taylor d83ac79c38 Unbreak `Media Trash` after [28788].
Props SergeyBiryukov.
Fixes #29080.


git-svn-id: https://develop.svn.wordpress.org/trunk@29337 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 15:14:56 +00:00
Andrew Ozz c94edd08bd Editor scrolling:
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29336 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 02:42:30 +00:00
Andrew Ozz a8a936ebc5 wpLink: add custom open and close events, props bradyvercher, fixes #28095.
git-svn-id: https://develop.svn.wordpress.org/trunk@29335 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 02:03:13 +00:00
Andrew Ozz c3f712ac63 PressThis: when the Text editor is the default, run the initial textarea content through pre_wpautop() to convert the paragraph tags. Fixes #29081.
git-svn-id: https://develop.svn.wordpress.org/trunk@29334 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 00:54:51 +00:00
Andrew Ozz 0ef495da6a wpLink:
- Fix adding a link on pressing Enter.
- Don't auto-focus the URL field after selecting a local link.
- Don't auto-focus the URL field when opening on touch devices. Toggle focus/blur on it to close the onscreen keyboard so the modal is positioned properly.
See #28897.

git-svn-id: https://develop.svn.wordpress.org/trunk@29333 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-31 23:27:14 +00:00
Andrew Ozz cba848581b Use node.nodeName instead of tagName for better consistency/compatibility, see #28704.
git-svn-id: https://develop.svn.wordpress.org/trunk@29332 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:48:21 +00:00
Helen Hou-Sandi 8790d81cb4 Prevent key event handlers from firing when in input areas in the media modal, as people understandably want to type inside said inputs. props kovshenin. fixes #28704.
git-svn-id: https://develop.svn.wordpress.org/trunk@29331 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:38:18 +00:00
Sergey Biryukov 6be5fc19b3 Make sure phpinfo() is not disabled before calling it in apache_mod_loaded().
props rohan013, harmr.
fixes #26772.

git-svn-id: https://develop.svn.wordpress.org/trunk@29330 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:27:54 +00:00
Sergey Biryukov 09877657d4 Customizer: Don't hide controls the preview frame has no information about.
props kovshenin.
see #27993.

git-svn-id: https://develop.svn.wordpress.org/trunk@29329 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 16:23:47 +00:00
Andrew Ozz 23d876d86a Tests Autop: remove <option> from the list of inline tags. It is valid only in specific context (<select>, <optgroup> or <datalist>) and should not be wrapped in <p>. Props kovshenin, fixes #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29328 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 19:02:36 +00:00
Andrew Nacin 94c53962b1 Don't pass around the password reset key.
props mdawaffe.
fixes #29060.


git-svn-id: https://develop.svn.wordpress.org/trunk@29327 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 18:18:58 +00:00
Sergey Biryukov 502e9b675a In add_submenu_page(), avoid inadvertently copying classes of a menu item to the first submenu item.
fixes #28936.

git-svn-id: https://develop.svn.wordpress.org/trunk@29326 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:07:59 +00:00
Helen Hou-Sandi 3c71a49abc Labels for the installation form should get the pointer cursor. props Ankit K Gupta. fixes #28818.
git-svn-id: https://develop.svn.wordpress.org/trunk@29325 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:04:44 +00:00
Sergey Biryukov 40d1133c6f Fix duplicate Customize button in theme details modal.
props afercia.
fixes #28987.

git-svn-id: https://develop.svn.wordpress.org/trunk@29324 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:01:13 +00:00
Sergey Biryukov e4c8f3a843 QuickPress: Disable autocomplete for content, enable "Save Draft" button on load.
props morganestes, michalzuber.
fixes #27760.

git-svn-id: https://develop.svn.wordpress.org/trunk@29323 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 15:33:07 +00:00
Sergey Biryukov fd1652d6bb Media Grid: Close the modal if the attachment is deleted.
props ericlewis.
fixes #28819.

git-svn-id: https://develop.svn.wordpress.org/trunk@29322 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 14:57:21 +00:00
Andrew Ozz 93aff47ac5 wpLink: add keyboard navigation, improve accessibility. Props afercia, fixes #28897.
git-svn-id: https://develop.svn.wordpress.org/trunk@29321 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 03:15:34 +00:00
Sergey Biryukov e2d9939e57 Avoid PHP notices in Media Library if an attachment parent post type no longer exists.
Synchronize the 'edit_post' capability check between the list table and the media grid.

fixes #27446.

git-svn-id: https://develop.svn.wordpress.org/trunk@29320 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 01:40:24 +00:00
Sergey Biryukov a475124608 Use 3-digit x.x.x style for two 4.0.0 @since versions.
see #28885.

git-svn-id: https://develop.svn.wordpress.org/trunk@29319 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 00:58:22 +00:00
Sergey Biryukov 7ac0669493 Avoid PHP notices in _count_posts_cache_key(), _update_blog_date_on_post_publish(), and _update_blog_date_on_post_delete() if post type is not registered.
props jesin.
fixes #28135.

git-svn-id: https://develop.svn.wordpress.org/trunk@29318 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 00:50:53 +00:00
Andrew Ozz fbfd88cecb TinyMCE:
- Use `data-wp-*` for processing and styling of the `more` and `nextpage` placeholders, keep the class names for back-compat. Makes them "immune" to "Clear formatting".
- Translate the titles of the placeholders.
Fixes #28772.

git-svn-id: https://develop.svn.wordpress.org/trunk@29317 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 23:44:28 +00:00
Andrew Ozz 01051b4e2f Formatting: make the removal of white space around <option> greedy, see #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29316 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 19:54:50 +00:00
Andrew Ozz 5fa36977a0 Formatting: no <p> or <br> around <option> tags in both flavours of wpautop, make "selects" easier to read in the Text editor. Fixes #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29315 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 19:43:06 +00:00
Dominik Schilling (ocean90) 70a6b6390c IE8 doesn't support `::before` and `::after` pseudo-elements. Replace them with `:before` and `:after`.
props andrezrv, DrewAPicture, ocean90.
fixes #28082.

git-svn-id: https://develop.svn.wordpress.org/trunk@29314 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 15:51:02 +00:00
Dominik Schilling (ocean90) 41360a0086 Remove `parent::footer()` in `Language_Pack_Upgrader_Skin::bulk_footer()` as it prints a closing div which is not needed.
props michalzuber.
fixes #28947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29313 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 09:05:33 +00:00
Dominik Schilling (ocean90) 9f105673fb Media Grid: Improve lazy loading.
props kovshenin.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@29312 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:57:25 +00:00
Dominik Schilling (ocean90) ea34a0bdf7 Replace `is_https_url()` with `'https' === parse_url( $url, PHP_URL_SCHEME )`.
see #28427, #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29311 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:45:34 +00:00
Dominik Schilling (ocean90) 0f93a72879 Remove unit test for `is_https_url()`, see [29309].
see #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29310 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:18:19 +00:00
Dominik Schilling (ocean90) 080f52ceb9 Revert [28894] as it's currently unused in core.
see #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29309 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:15:22 +00:00
Dominik Schilling (ocean90) 0e42ce2dc0 Add missing `screen-reader-text` CSS class in [29294].
see #28867.

git-svn-id: https://develop.svn.wordpress.org/trunk@29308 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 13:42:49 +00:00
Dominik Schilling (ocean90) db77bc8bff Media Grid: Align "Apply" button on small screens.
fixes #28903.

git-svn-id: https://develop.svn.wordpress.org/trunk@29307 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 12:14:58 +00:00
Dominik Schilling (ocean90) 3003895858 Fix jshint errors introduced in [29284] and [29299].
git-svn-id: https://develop.svn.wordpress.org/trunk@29306 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 11:48:26 +00:00
Dominik Schilling (ocean90) 812ecd9b8d Media Grid: Ignore user setting for `content`.
fixes #29034.

git-svn-id: https://develop.svn.wordpress.org/trunk@29305 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 11:43:08 +00:00
Dominik Schilling (ocean90) cb5838a937 Media Grid: Improve dropzone margins when viewport height is <400px.
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29304 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 15:29:39 +00:00
Dominik Schilling (ocean90) 0480144f86 Media Grid: Add context for "or" in [29296].
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29303 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 14:36:56 +00:00
Andrew Ozz 42ac48d52a TinyMCE:
- Fix complex character input in Japanese, Chinese, etc. Was broken in getCursorOffset() in editor-expand.js.
- Disable auto-scrolling in some edge cases when editor expanding is enabled.
See #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29302 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 00:07:55 +00:00
Helen Hou-Sandi 357d96c367 Don't interfere with browser-based autocomplete in the link modal. props SergeyBiryukov. fixes #28685.
git-svn-id: https://develop.svn.wordpress.org/trunk@29301 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 15:56:57 +00:00
Helen Hou-Sandi 59cec2e2ff When adding a post of a post type whose menu item is in a submenu, highlight the correct menu item. props mordauk, markjaquith. fixes #24137.
git-svn-id: https://develop.svn.wordpress.org/trunk@29300 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 15:25:20 +00:00
Scott Taylor 0b3802eb12 Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique.
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857.


git-svn-id: https://develop.svn.wordpress.org/trunk@29299 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:59:29 +00:00
Andrew Ozz 67032cf170 TinyMCE wpView:
- Fix opening the media modal on clicking Edit in Firefox.
- Fix range errors when restoring the selection bookmark in IE11 after editing a view.
See #28595.

git-svn-id: https://develop.svn.wordpress.org/trunk@29298 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:55:33 +00:00
Scott Taylor e11d72f889 Media Grid: make check `box-shadow` more subtle.
See #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29297 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:46:14 +00:00
Scott Taylor 3fef7648f6 Media Grid: improve uploader styles.
Props michalzuber, ericlewis.
See #28851.


git-svn-id: https://develop.svn.wordpress.org/trunk@29296 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:30:28 +00:00
Scott Taylor 276496aa29 Media Grid: change text to "Close Media Panel" to provide context for screen readers.
Props joedolson.
Fixes #28976.


git-svn-id: https://develop.svn.wordpress.org/trunk@29295 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:25:16 +00:00