Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.
Props oakesjosh, jeroenrotty, desrosj, Clorith.
Fixes#50945.
git-svn-id: https://develop.svn.wordpress.org/trunk@48800 602fd350-edb4-49c9-b593-d223f7449a82
In PHP 8, the GD extension uses `GdImage` objects instead of resources for its underlying data structures.
This updates the existing `is_resource()` calls for image resources in core to accomodate for `GdImage` instances as well.
Props ayeshrajans, jrf.
Fixes#50833.
git-svn-id: https://develop.svn.wordpress.org/trunk@48798 602fd350-edb4-49c9-b593-d223f7449a82
Support for the `uniqueItems` keyword was added in [48357], but wasn't included in the list of permitted keywords for `WP_REST_Controller::get_endpoint_args_for_item_schema()`. This prevented the keyword from being automatically supported if specified in a controller's item schema.
Fixes#51021.
git-svn-id: https://develop.svn.wordpress.org/trunk@48796 602fd350-edb4-49c9-b593-d223f7449a82
The function is private (only intended for core usage) and is hooked to the `delete_post` action, which always passes a non-zero post ID.
Follow-up to [14295], [48794].
See #50343.
git-svn-id: https://develop.svn.wordpress.org/trunk@48795 602fd350-edb4-49c9-b593-d223f7449a82
As it already was not possible to pass the required parameters without also passing the optional one anyway, removing the default value for the (not so) optional parameters should not affect backward compatibility.
This change affects three functions in core:
* `get_comment_delimited_block_content()`
* `do_enclose()`
* `_wp_delete_tax_menu_item()`
Props jrf, ayeshrajans, desrosj.
Fixes#50343.
git-svn-id: https://develop.svn.wordpress.org/trunk@48794 602fd350-edb4-49c9-b593-d223f7449a82
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.
With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.
Follow-up to [47841].
Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Fixes#50912.
git-svn-id: https://develop.svn.wordpress.org/trunk@48792 602fd350-edb4-49c9-b593-d223f7449a82
This function has been deprecated in PHP 8.0 because in libxml 2.9.0, external entity loading is disabled by default, so this function is no longer needed to protect against XXE attacks.
Props jrf.
Fixes#50898.
git-svn-id: https://develop.svn.wordpress.org/trunk@48789 602fd350-edb4-49c9-b593-d223f7449a82
Declaring a `private` method as `final` is an oxymoron, as `private` methods cannot be overloaded anyway.
Using `final private function...` will generate a warning in PHP 8.
Props jrf.
Fixes#50897.
git-svn-id: https://develop.svn.wordpress.org/trunk@48788 602fd350-edb4-49c9-b593-d223f7449a82
This is intended as an easy way for plugins and themes to still be able to load jQuery with jQuery Migrate in WordPress 5.5.
Once jQuery is updated to 3.x, this temporary script handle will be removed. This means plugins and themes still using it at that point will fail to load their scripts (as a dependency will be missing), but will not cause "fatal errors" breaking the rest of JS.
Follow-up to [48323], [48324].
Props azaozz, desrosj, apedog, Clorith, jorbin.
Fixes#37110.
git-svn-id: https://develop.svn.wordpress.org/trunk@48753 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.
Props johnbillion.
Fixes#50868.
git-svn-id: https://develop.svn.wordpress.org/trunk@48750 602fd350-edb4-49c9-b593-d223f7449a82
To accommodate for the change, the `custom-logo` theme feature now accepts the `unlink-homepage-logo` parameter.
If and when the logo is linked on the home page, the link has the `aria-current` attribute for better accessibility.
Follow-up to [48039], [48283].
Props sabernhardt, audrasjb, johnstonphilip, demetris.
Fixes#37011.
git-svn-id: https://develop.svn.wordpress.org/trunk@48749 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that comment object cache is cleared after changing the comment type to `comment` instead of an empty string.
Add a unit test for `_wp_batch_update_comment_type()`.
Follow-up to [47597], [47626], [48225], [48227].
Props imath, westonruter.
Fixes#49236.
git-svn-id: https://develop.svn.wordpress.org/trunk@48748 602fd350-edb4-49c9-b593-d223f7449a82
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.
Props bpayton, pbiron.
Fixes#50852.
git-svn-id: https://develop.svn.wordpress.org/trunk@48745 602fd350-edb4-49c9-b593-d223f7449a82
Core translations are considered safe, and these labels are not escaped in any other instances.
Follow-up to [48521], [48722], [48724].
See #40188, #50815.
git-svn-id: https://develop.svn.wordpress.org/trunk@48741 602fd350-edb4-49c9-b593-d223f7449a82
The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.
Props sswebster, nateinaction, SergeyBiryukov.
Fixes#50837.
git-svn-id: https://develop.svn.wordpress.org/trunk@48734 602fd350-edb4-49c9-b593-d223f7449a82
The musician name is traditionally not included on the About page due to i18n concerns regarding last minute changes.
Props audrasjb, SergeyBiryukov.
See #50416.
git-svn-id: https://develop.svn.wordpress.org/trunk@48730 602fd350-edb4-49c9-b593-d223f7449a82
Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance.
Props whyisjake, SergeyBiryukov.
Fixes#40188.
git-svn-id: https://develop.svn.wordpress.org/trunk@48722 602fd350-edb4-49c9-b593-d223f7449a82
This can be helpful for plugin developers to get credits information for older versions or different locales.
Props ramiy.
Fixes#35910.
git-svn-id: https://develop.svn.wordpress.org/trunk@48715 602fd350-edb4-49c9-b593-d223f7449a82
Multisite routing is taken care of by WordPress, not by the web server.
Follow-up to [13706], [37747], [38066].
Props boonebgorges.
Fixes#39547.
git-svn-id: https://develop.svn.wordpress.org/trunk@48713 602fd350-edb4-49c9-b593-d223f7449a82
This makes it easier for a user to know how significant of an update the change might be, and helps them make an informed decision about how to proceed.
Props tmdesigned, dd32, circlecube, dkarfa, hakre, scribu, MadtownLems, markshep, nbachiyski, dmchale, miqrogroove, ovann86, danieltj, sterndata, seanpaulrasmussen, mrgrt, Commeuneimage, dpacks, puneetsahalot, jonoaldersonwp, SergeyBiryukov.
Fixes#15101. See #35554, #47848.
git-svn-id: https://develop.svn.wordpress.org/trunk@48709 602fd350-edb4-49c9-b593-d223f7449a82
Keep 1024-bit legacy root certificates re-added in [35919], except for those already expired, for compatibility with older OpenSSL versions.
Props barry, ayeshrajans, desrosj, whyisjake.
See #50828.
git-svn-id: https://develop.svn.wordpress.org/trunk@48707 602fd350-edb4-49c9-b593-d223f7449a82
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.
Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.
git-svn-id: https://develop.svn.wordpress.org/trunk@48703 602fd350-edb4-49c9-b593-d223f7449a82
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.
Fixes#50824.
Props dd32, whyisjake, SergeyBiryukov.
git-svn-id: https://develop.svn.wordpress.org/trunk@48701 602fd350-edb4-49c9-b593-d223f7449a82
To create a copy of the object, instead of a reference to the same object, the `clone` keyword should be used.
Props scarolan.
Fixes#50775.
git-svn-id: https://develop.svn.wordpress.org/trunk@48700 602fd350-edb4-49c9-b593-d223f7449a82
Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot.
Fixes#50821.
Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/trunk@48696 602fd350-edb4-49c9-b593-d223f7449a82
This brings some consistency with the `manage_users_extra_tablenav` and `manage_users_extra_tablenav` actions.
Props Tkama, wpgurudev.
Fixes#50736.
git-svn-id: https://develop.svn.wordpress.org/trunk@48693 602fd350-edb4-49c9-b593-d223f7449a82
Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme.
See #50280.
Props dd32.
git-svn-id: https://develop.svn.wordpress.org/trunk@48688 602fd350-edb4-49c9-b593-d223f7449a82
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.
See #50798.
Fixes#50280.
Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.
git-svn-id: https://develop.svn.wordpress.org/trunk@48669 602fd350-edb4-49c9-b593-d223f7449a82
Since `wp_get_environment_type()` runs too early for plugins to hook these filters, and the result is then cached in a static variable and cannot be changed later, the filters are not that useful.
The `WP_ENVIRONMENT_TYPES` and `WP_ENVIRONMENT_TYPE` constants and environment variables should be enough for now.
Follow-up to [47919], [48188], [48372].
Props Clorith, SergeyBiryukov.
Fixes#33161.
git-svn-id: https://develop.svn.wordpress.org/trunk@48662 602fd350-edb4-49c9-b593-d223f7449a82
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.
Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes#50784.
git-svn-id: https://develop.svn.wordpress.org/trunk@48657 602fd350-edb4-49c9-b593-d223f7449a82
Gutenberg no longer uses the assets field to fetch the assets for the installed block so this field can be dropped from the endpoint. This allows us to reintroduce it at a later point without needing to worry about backward compatibility.
See #50732.
git-svn-id: https://develop.svn.wordpress.org/trunk@48656 602fd350-edb4-49c9-b593-d223f7449a82
Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates.
Fixes#50793.
Props dd32.
git-svn-id: https://develop.svn.wordpress.org/trunk@48655 602fd350-edb4-49c9-b593-d223f7449a82
This applies to the Themes screen and the Customizer theme browser.
Props afragen, SergeyBiryukov.
See #48491.
git-svn-id: https://develop.svn.wordpress.org/trunk@48652 602fd350-edb4-49c9-b593-d223f7449a82
As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/) this add some tooling to lint Javascript docblocks. Two new commands:
* `npm run lint:jsdoc`
* `npm run lint:jsdoc:fix`
The latter will run the linter and try to fix an possible issues automatically.
Fixes#43828.
Props netweb, atimmer, kamataryo, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/trunk@48650 602fd350-edb4-49c9-b593-d223f7449a82
DocBlocks should start with a brief, one sentence explanation of the purpose of the function spanning a maximum of two lines.
Follow-up to [48648].
See #44427.
git-svn-id: https://develop.svn.wordpress.org/trunk@48649 602fd350-edb4-49c9-b593-d223f7449a82
Prior to the PHPMailer update in 5.5, old version of the PHPMailer was setting the validator to 'auto' resulting in a sophisticated logic for determining what email address validation should be used. But the new version defaults to 'php', possibly leading to rejection of email addresses which were fine prior to the upgrade. Let's use the WordPress core function `is_email()` so that it can be fully pluggable.
Fixes#50720.
Props david.binda, ayeshrajans, Synchro, SergeyBiryukov, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/trunk@48645 602fd350-edb4-49c9-b593-d223f7449a82
The custom link colors for admin scheme colors were overriding the danger color.
Props kebbet, dlh.
Fixes#50547.
git-svn-id: https://develop.svn.wordpress.org/trunk@48643 602fd350-edb4-49c9-b593-d223f7449a82
In [47559] the `WP_REST_Request::set_param()` method was adjusted to try and overwrite an existing parameter definition before forcing the value in the first parameter slot. If `set_param()` was called on a request with an `application/json` content type and an empty body, a PHP warning would be issued. This was due to the JSON parameter type not being set to an array when the body is empty.
This commit avoids the warning by adding an `is_array()` check before calling `array_key_exists`. Ideally, `WP_REST_Reuest::parse_json_params()` would set the JSON parameter type to an empty array in this case, but that is too large of a change at this point in the cycle.
Props manooweb.
Fixes#50786.
git-svn-id: https://develop.svn.wordpress.org/trunk@48642 602fd350-edb4-49c9-b593-d223f7449a82
Support for retrieving the langauge pack alongside the install API request was added in https://meta.trac.wordpress.org/changeset/10091 to avoid having to make a plugin update check during the REST API check.
Fixes#50732.
Props dd32, ocean90, ryelle, swissspidy, tellyworth, whyisjake, TimothyBlynJacobs.
git-svn-id: https://develop.svn.wordpress.org/trunk@48641 602fd350-edb4-49c9-b593-d223f7449a82
This applies to the Themes screen fallback used when JS is turned off.
Props afragen, desrosj, SergeyBiryukov.
See #48491.
git-svn-id: https://develop.svn.wordpress.org/trunk@48640 602fd350-edb4-49c9-b593-d223f7449a82
Backport the latest block patterns from the Gutenberg plugin.
The new patterns adapt properly to Core themes.
Props nrqsnchz.
Fixes#50550, #50594.
git-svn-id: https://develop.svn.wordpress.org/trunk@48639 602fd350-edb4-49c9-b593-d223f7449a82
This applies to the Themes screen, Add Themes screen, and the Customizer theme browser.
Props afragen, desrosj, SergeyBiryukov.
See #48491.
git-svn-id: https://develop.svn.wordpress.org/trunk@48638 602fd350-edb4-49c9-b593-d223f7449a82
Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs.
See #36455.
git-svn-id: https://develop.svn.wordpress.org/trunk@48632 602fd350-edb4-49c9-b593-d223f7449a82
This ensures that the correct values are being compared when retrieving the result for custom post types.
Additionally, pass the `$post_type` parameter to `get_lastpostdate` and `get_lastpostmodified` filters.
Props mikaumoto, munyagu, donmhico, johnbillion, SergeyBiryukov.
Fixes#47777.
git-svn-id: https://develop.svn.wordpress.org/trunk@48631 602fd350-edb4-49c9-b593-d223f7449a82
Because `wp_insert_post()` and `wp_transition_post_status()` are called during the process, plugins can unexpectedly modify `$post`.
Props markparnell, tofandel, archon810, SergeyBiryukov.
Fixes#46671.
git-svn-id: https://develop.svn.wordpress.org/trunk@48625 602fd350-edb4-49c9-b593-d223f7449a82
This provides a minor performance improvement by only running the function in contexts where it's needed.
Follow-up to [47211], [47213], [47763], [48619].
See #46829, #49374.
git-svn-id: https://develop.svn.wordpress.org/trunk@48620 602fd350-edb4-49c9-b593-d223f7449a82
This allows special pages to be denoted as such when editing a menu in the Customizer.
This applies to the Front Page, Posts Page, and Privacy Policy Page.
Follow-up to [47211], [47213], [47763].
Props dlh, whyisjake, SergeyBiryukov.
Fixes#46829. See #49374.
git-svn-id: https://develop.svn.wordpress.org/trunk@48619 602fd350-edb4-49c9-b593-d223f7449a82
Synchronize the documentation between two places, use `WP_Customize_Partial::__construct()` as the canonical source.
Props marekdedic.
See #49572.
git-svn-id: https://develop.svn.wordpress.org/trunk@48617 602fd350-edb4-49c9-b593-d223f7449a82
* `wp_privacy_personal_data_export_page`
* `wp_privacy_personal_data_erasure_page`
Hooks should be single-quoted when referenced.
Props pbiron, coffee2code.
See #49572, #meta5318.
git-svn-id: https://develop.svn.wordpress.org/trunk@48616 602fd350-edb4-49c9-b593-d223f7449a82
As of WordPress 4.7, developers can register their own bulk actions on list table screens.
Follow-up to [17297], [38647].
Props joyously, pbiron.
See #49572.
git-svn-id: https://develop.svn.wordpress.org/trunk@48614 602fd350-edb4-49c9-b593-d223f7449a82
Previously, the passed value was only used as a fallback if `get_language_attributes()` is not yet available.
Props apedog.
Fixes#49060.
git-svn-id: https://develop.svn.wordpress.org/trunk@48607 602fd350-edb4-49c9-b593-d223f7449a82
This adds the changes from [48073] to the `style-rtl.css` file.
Previously committed in [48514], accidentally reverted in [48602].
See #45912, #49843.
git-svn-id: https://develop.svn.wordpress.org/trunk@48605 602fd350-edb4-49c9-b593-d223f7449a82
Alignments and blocks were not always appearing as they should in the admin.
- Wide alignments sometimes appear only as wide as the text column.
- Full and wide appear centered on the text column
- Full-width blocks sometimes do not take up the full width of the page, and other times they cause a horizontal scroll.
- Wide and full group block children take up the full width of the block by default.
Fixes#49843.
Props kjellr, Joen, poena.
git-svn-id: https://develop.svn.wordpress.org/trunk@48602 602fd350-edb4-49c9-b593-d223f7449a82
Due to the varying server setups, `$_SERVER['SERVER_NAME'];` can't reliably ensure that there will be a relevant host that could be used as the hostname in an email. Since the `network_home_url()` is set at this point, and is filterable, this should better enable emails to be sent from the server.
Fixes#25239.
Props layotte, SergeyBiryukov, nacin, sreedoap, szepe.viktor, jesin, kitchin, mensmaximus, mt8.biz, Grzegorz.Janoszka, cbutlerjr, dd32, BjornW, neodjandre, BjornW, Ipstenu, ocean90, danielbachhuber, desmith, joemcgill, jdgrimes, riasat, derekakelly, swissspidy, lilmike, tsimmons, robert.peake, DavidAnderson, cloudstek, pigdog234, BjornW, rawrly, pessoft, RedSand, seayou, dvershinin, bastho, chesio, Starbuck, afragen, ocean90, whyisjake.
git-svn-id: https://develop.svn.wordpress.org/trunk@48601 602fd350-edb4-49c9-b593-d223f7449a82
The function is used for adding a new term, not updating an existing one.
Props audrasjb, bmartinent.
Fixes#50753.
git-svn-id: https://develop.svn.wordpress.org/trunk@48600 602fd350-edb4-49c9-b593-d223f7449a82
Note that passing `div` to the `style` parameter will result in no additional list markup.
Props liuhaibin, jeremyfelt, functionalrhyme.
Fixes#49181.
git-svn-id: https://develop.svn.wordpress.org/trunk@48597 602fd350-edb4-49c9-b593-d223f7449a82
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.
Follow-up to [47233], [48352].
See #45317, #40244.
git-svn-id: https://develop.svn.wordpress.org/trunk@48594 602fd350-edb4-49c9-b593-d223f7449a82
This prevents fatal errors when other hooked functions are expecting both parameters.
Props dd32, desrosj, audrasjb, pbiron.
Fixes#50662.
git-svn-id: https://develop.svn.wordpress.org/trunk@48584 602fd350-edb4-49c9-b593-d223f7449a82
These strings already have a context in `create_initial_post_types()`, and should use the same context in `_wp_privacy_statuses()`.
Props ramiy, audrasjb.
Fixes#50740.
git-svn-id: https://develop.svn.wordpress.org/trunk@48578 602fd350-edb4-49c9-b593-d223f7449a82
There are two pieces in here:
1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks.
2) This improves backwards compatibility for code that was accessing the now deprecated code.
Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566]
Props: desrosj, SergeyBiryukov, johnjamesjacoby
Fixes: #50413
git-svn-id: https://develop.svn.wordpress.org/trunk@48575 602fd350-edb4-49c9-b593-d223f7449a82
With loading="lazy" being added to all images in [47554], let's ensure that it passes kses attributes too.
Fixes#50731.
Props TimothyBlynJacobs, peterwilsoncc, azaozz.
git-svn-id: https://develop.svn.wordpress.org/trunk@48572 602fd350-edb4-49c9-b593-d223f7449a82
This was missed in [48142] which renamed `add_option_allowed_list()` to `add_allowed_options()` for better readability. The two functions should have consistent names.
See #50413.
git-svn-id: https://develop.svn.wordpress.org/trunk@48566 602fd350-edb4-49c9-b593-d223f7449a82
In [47758] a new function `rest_filter_response_by_context` was introduced to expand the JSON schema features supported by the context filtering mechanism.
This commit improves the performance of that function by eliminating repetitive comparisons and loops. Additionally, it improves multi-type support for object + array types.
Fixes#50700.
Props dlh.
git-svn-id: https://develop.svn.wordpress.org/trunk@48555 602fd350-edb4-49c9-b593-d223f7449a82
