Commit Graph

258 Commits

Author SHA1 Message Date
Andrew Nacin 55d176020b In show_message(), only print error data if it is a string.
see #25576, [25775].


git-svn-id: https://develop.svn.wordpress.org/trunk@25796 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 19:50:48 +00:00
Andrew Nacin 204ca72a66 Core Updates: Verify that all files we're about to copy are actually writable, when using the direct transport.
Once we begin to copy core files, all bets are off. This allows us to fail early when we'll otherwise need to stop midway through due to permissions issues, which is a particularly bad problem when only some files have permissions issues.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25794 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 19:17:56 +00:00
Andrew Nacin c72ba036cf Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir().
This occurs when we can't copy a file. We chmod it and try again.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25793 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 19:13:33 +00:00
Dion Hulse fa79184a7d Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/.
My bad. See #22704, [25781].


git-svn-id: https://develop.svn.wordpress.org/trunk@25787 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 14:54:29 +00:00
Andrew Nacin 772316ecc7 Hide language-specific warnings/labels on update-core.php when we are dealing with a point release partial build.
see #22704, #18200.


git-svn-id: https://develop.svn.wordpress.org/trunk@25784 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 05:07:55 +00:00
Andrew Nacin 2eebc47254 Hide auto updates from update-core.php directly in get_core_updates(). see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25783 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 05:06:35 +00:00
Andrew Nacin 85d32ce873 Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback.
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25782 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-15 02:58:07 +00:00
Andrew Nacin 1918e828da Automatic updates: Include error data in the follow-up API request.
props dd32.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25781 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 23:32:47 +00:00
Andrew Nacin 3eac3d0380 Parse absolute paths out of error data. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25780 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 22:24:28 +00:00
Dion Hulse b492ae85f8 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25779 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 21:54:33 +00:00
Andrew Nacin 67c80dae13 Account for the possible failure of disk_free_space() in update_core().
see #22704, #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25778 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 21:14:39 +00:00
Andrew Nacin d6a1b681d3 Auto updates: Only attempt a roll back when we've hit a critical error code.
Specifically, this means when we've failed in copying files.

see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25777 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 21:02:46 +00:00
Andrew Nacin b8efab15d8 Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files.
see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25776 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 20:57:28 +00:00
Andrew Nacin 47e85a9b54 In the upgrader, only print additional error data if it is a string.
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25775 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 20:19:52 +00:00
Andrew Nacin 5db3863d12 In unzip_file(), confirm we have enough available disk space before extracting.
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.


git-svn-id: https://develop.svn.wordpress.org/trunk@25774 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 20:14:13 +00:00
Andrew Nacin bd26f54af2 More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25772 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 19:37:53 +00:00
Dominik Schilling (ocean90) dde2cb32fa Fix typo in wp-admin.css. props wycks. fixes #25589.
git-svn-id: https://develop.svn.wordpress.org/trunk@25771 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-14 16:13:08 +00:00
Andrew Nacin 7bf44580a9 Add explicit link to the installation being updated in debugging emails. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25770 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-12 20:17:20 +00:00
Andrew Nacin 9eff9eaebe Silence possible warnings from is_dir(). fixes #25572.
git-svn-id: https://develop.svn.wordpress.org/trunk@25764 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-11 17:10:18 +00:00
Andrew Nacin 2e605e76c6 Refine error codes throughout the upgrader so we can better detect at what stage updates fail.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25763 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-11 16:05:13 +00:00
Andrew Ozz ee5d2021e0 Upgrade TinyMCE to 3.5.9. Fix the css for the original 'fullscreen' plugin (not enabled by default).
Fixes #25561, fixes #25281.


git-svn-id: https://develop.svn.wordpress.org/trunk@25761 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-10 21:49:23 +00:00
Andrew Nacin 627b25bf50 Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704.
git-svn-id: https://develop.svn.wordpress.org/trunk@25755 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-10 14:45:55 +00:00
Dion Hulse f0571c02b7 After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704
git-svn-id: https://develop.svn.wordpress.org/trunk@25752 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-10 01:56:44 +00:00
Dion Hulse e03279e8b0 In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful.
See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25750 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-10 01:31:22 +00:00
Andrew Nacin 74f02a6751 Hook documentation for wp-admin/admin.php.
props DrewAPicture for initial patch.
fixes #25442.


git-svn-id: https://develop.svn.wordpress.org/trunk@25747 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 21:00:41 +00:00
Andrew Nacin 12cb3a353e Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height.
props plocha.
fixes #25038.


git-svn-id: https://develop.svn.wordpress.org/trunk@25744 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 19:06:56 +00:00
Helen Hou-Sandi 99df61b666 Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410.
git-svn-id: https://develop.svn.wordpress.org/trunk@25741 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 18:46:34 +00:00
Dion Hulse 28736216f3 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069
git-svn-id: https://develop.svn.wordpress.org/trunk@25739 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-09 16:46:31 +00:00
Drew Jaynes e46830eb0b Inline documentation for hooks in wp-admin/widgets.php.
Props r3df, kpdesign.
Fixes #25501.


git-svn-id: https://develop.svn.wordpress.org/trunk@25734 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-08 20:26:25 +00:00
Scott Taylor 4aa0066736 Use parens to ensure that RegEx OR matches the front when determining that mime-type matches `audio|video` in `attachment_submitbox_metadata()`.
Props kovshenin.
See #23926.



git-svn-id: https://develop.svn.wordpress.org/trunk@25727 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-08 15:31:32 +00:00
Drew Jaynes f13f18de24 Inline documentation for hooks in wp-admin/maint/repair.php.
Props ben.moody, kpdesign.
Fixes #25500.


git-svn-id: https://develop.svn.wordpress.org/trunk@25725 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-08 00:29:37 +00:00
Drew Jaynes 887af83f53 Inline documentation for hooks in wp-admin/network.php.
Props johnafish.
Fixes #25502.


git-svn-id: https://develop.svn.wordpress.org/trunk@25722 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 23:42:43 +00:00
Andrew Nacin 04f053ce0c Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping.
props SergeyBiryukov.
see #25023.
for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25719 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 18:34:35 +00:00
Drew Jaynes 4a86f70280 Inline documentation for wp-admin/options-reading.php.
Props siobhyb for the initial patch.
Fixes #25430.


git-svn-id: https://develop.svn.wordpress.org/trunk@25717 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 17:18:00 +00:00
Andrew Nacin f4227afa2b Optimize the accessibility JS on the Menus screen to avoid browser crashes with very large menus.
props atimmer.
fixes #25112.


git-svn-id: https://develop.svn.wordpress.org/trunk@25708 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 13:37:00 +00:00
Drew Jaynes 2a2587c6dc Inline documentation for hooks in wp-admin/includes/bookmark.php.
Props johnafish, kpdesign.
Fixes #25494.


git-svn-id: https://develop.svn.wordpress.org/trunk@25706 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-07 02:18:20 +00:00
Andrew Nacin 40ea01d759 Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates.
see #22704.


git-svn-id: https://develop.svn.wordpress.org/trunk@25700 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 15:45:09 +00:00
Andrew Nacin 0286d7030d Don't modify post_author during a quick edit when the post type doesn't support authors.
props ocean90.
fixes #16645.


git-svn-id: https://develop.svn.wordpress.org/trunk@25698 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 13:14:06 +00:00
Andrew Nacin 9f23f85ae2 Run _fix_attachment_links() when post_status is future or private in addition to publish.
Fixes regression caused by [20308].

props jond3r.
fixes #25268.


git-svn-id: https://develop.svn.wordpress.org/trunk@25697 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 12:55:38 +00:00
Andrew Nacin 352ff49768 Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid.
props garyc40, wonderboymusic.
fixes #14578.


git-svn-id: https://develop.svn.wordpress.org/trunk@25695 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 10:55:42 +00:00
Andrew Nacin c0fb231f92 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override.
props azaozz.
fixes #24930.


git-svn-id: https://develop.svn.wordpress.org/trunk@25694 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-06 10:45:25 +00:00
Andrew Nacin 1b37564f35 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009.
git-svn-id: https://develop.svn.wordpress.org/trunk@25691 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-05 10:58:20 +00:00
Dominik Schilling (ocean90) d529239d24 Post UI: Increase the trigger width for switching from two columns to one.
props melchoyce, vinod dalvi.
fixes #23904.

git-svn-id: https://develop.svn.wordpress.org/trunk@25688 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 09:36:36 +00:00
Dominik Schilling (ocean90) 4f7760db6f Revert [25622]. fixes #25445. see #25122.
git-svn-id: https://develop.svn.wordpress.org/trunk@25687 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 09:11:45 +00:00
Andrew Nacin 2068a3e6da When determining a frontend, local URL in the theme customizer, match the home URL without a trailing slash.
props SergeyBiryukov.
fixes #25315.


git-svn-id: https://develop.svn.wordpress.org/trunk@25681 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:49:59 +00:00
Andrew Nacin a59daf91cf Ensure we globally replace [ and ] in customizer control IDs, to match the PHP.
props westonruter.
fixes #25238.


git-svn-id: https://develop.svn.wordpress.org/trunk@25680 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:45:39 +00:00
Andrew Nacin 8cd52fe580 Don't let the query string pile up on successive themes.php searches.
props SergeyBiryukov.
fixes #25270.


git-svn-id: https://develop.svn.wordpress.org/trunk@25679 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:25:24 +00:00
Andrew Nacin a2c2641419 Avoid counting auto-drafts in sticky.
props nofearinc.
fixes #25127.


git-svn-id: https://develop.svn.wordpress.org/trunk@25678 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:15:30 +00:00
Andrew Nacin 7a9a26fb84 List tables: When executing a search, reset the Bulk Actions dropdown to avoid the search from failing.
props c3mdigital, vinod-dalvi.
fixes #25034.


git-svn-id: https://develop.svn.wordpress.org/trunk@25677 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 01:08:13 +00:00
Andrew Nacin 635a1249f5 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses.
props creativeinfusion.
fixes #24818.


git-svn-id: https://develop.svn.wordpress.org/trunk@25676 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 00:59:12 +00:00