Commit Graph

61 Commits

Author SHA1 Message Date
John Blackbourn
021401424b Docs: @param fixes for a variety of docblocks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36232 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-09 01:44:31 +00:00
Andrea Fercia
9c8c6955a9 Accessibility: Remove the revisions limit title attribute from the Publish box.
The revisions limit warning is now always displayed in plain text even when the
limit is not reached yet. Removes the plus "+" from the revisions count number.

Fixes #35029.

git-svn-id: https://develop.svn.wordpress.org/trunk@36053 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-21 14:38:32 +00:00
Andrea Fercia
62abc10870 Accessibility: Improvements for the "Send Trackbacks" postbox.
Adds an `aria-describedby` attribute targeting the input field description and styles the description as a... description.

Fixes #35123.

git-svn-id: https://develop.svn.wordpress.org/trunk@35983 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-16 23:36:28 +00:00
Sergey Biryukov
3068a5b333 I18N: Add missing context for 'Trash' strings.
Fixes #35054.

git-svn-id: https://develop.svn.wordpress.org/trunk@35901 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-13 19:02:30 +00:00
Boone Gorges
ded2547b57 Show user_login in Dashboard user dropdowns.
User dropdowns in wp-admin have traditionally shown the users' display names.
However, this causes ambiguity when users share display names. To correct this,
we now show the unique user_login in parentheses after the display name.

The new `display_name_with_login` value for the `show` parameter of
`wp_dropdown_users()` enables this functionality. The default value of `show`
has not been changed, for backward compatibility, but all instances of
`wp_dropdown_users()` in core wp-admin have been switched.

This changeset also reduces some duplicated logic when assembling a user list
when `include_selected` is true.

Props krogsgard, boonebgorges.
Fixes #31251.

git-svn-id: https://develop.svn.wordpress.org/trunk@35790 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-06 20:56:11 +00:00
Andrea Fercia
5310c447b8 Accessibility: Improve form labels and descriptions for the Tags meta box in the Edit Post screen.
Fixes #34627.

git-svn-id: https://develop.svn.wordpress.org/trunk@35609 602fd350-edb4-49c9-b593-d223f7449a82
2015-11-11 15:23:10 +00:00
Scott Taylor
d929461fd8 Taxonomy: get_terms_to_edit() can also return false or WP_Error. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations.
Props valendesigns.
Fixes #30472.


git-svn-id: https://develop.svn.wordpress.org/trunk@35139 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 16:39:47 +00:00
Sergey Biryukov
4240fe532c Acessibility: "Add New Category" links on Edit Post screen should not be a header.
Props afercia.
Fixes #33557.

git-svn-id: https://develop.svn.wordpress.org/trunk@35129 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-13 06:59:34 +00:00
Drew Jaynes
9a704fa0b8 Docs: Improve documentation for post_submit_meta_box(), which serves as the display callback for the 'Publish' meta box.
* `$post` is now correctly defined as being of the `WP_Post` type
* Adds a hash notation for the `$args` array
* Other minor fixes.

Props drebbitsweb.
Fixes #34171.


git-svn-id: https://develop.svn.wordpress.org/trunk@34911 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 16:33:52 +00:00
Scott Taylor
7665377058 Meta Boxes: add an action, post_submitbox_minor_actions. post_submitbox_misc_actions already exists. Pass $post to both for context - avoids having to check for a global post.
Props jonathanbardo, chriscct7, DrewAPicture.
Fixes #26267.


git-svn-id: https://develop.svn.wordpress.org/trunk@34895 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-07 02:44:59 +00:00
John Blackbourn
1bb2876fe6 callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead.
Fixes #34032


git-svn-id: https://develop.svn.wordpress.org/trunk@34566 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-25 23:57:46 +00:00
Scott Taylor
2b3347332e Meta Boxes: In post_categories_meta_box(), convert some spaces to tabs.
Props miyauchi.
Fixes #33945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34364 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-21 15:17:29 +00:00
Sergey Biryukov
857be1862b Pass the current post object to 'page_attributes_meta_box_template' action added in [34340].
Props DrewAPicture.
Fixes #33625.

git-svn-id: https://develop.svn.wordpress.org/trunk@34350 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 08:14:40 +00:00
Drew Jaynes
44c256e8d1 Docs: Use standardized vernacular in the hook doc summary for the page_attributes_meta_box_template filter, introduced in [34340].
See #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34349 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 06:37:18 +00:00
Scott Taylor
2812cc9595 In page_attributes_meta_box(), add an action, 'page_attributes_meta_box_template' to allow callbacks to be performed and HTML to be inserted after the title of the Template section.
Props sgrant.	
Fixes #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34340 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-20 02:39:31 +00:00
Scott Taylor
1c5f85e1a4 When applying the 'editable_slug' filter, add a second param that provides more context.
Props MikeSchinkel, jesin.
Fixes #31568.


git-svn-id: https://develop.svn.wordpress.org/trunk@34319 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-19 05:48:30 +00:00
Scott Taylor
c0d850878a Create a function, get_preview_post_link(), to DRY the logic for applying the 'preview_post_link' filter to a URL.
Props TomHarrigan, wonderboymusic.
Fixes #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34170 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-15 04:14:23 +00:00
Scott Taylor
0f2078bc9e When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on commentsBox, ->load(), that resets st (cool name) to the number of visible <tr>s before calling ->get(). This will account for spam'd and trash'd comments when returning comments at the proper offset.
Props utkarshpatel.
Fixes #33829.


git-svn-id: https://develop.svn.wordpress.org/trunk@34069 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-12 02:27:50 +00:00
Drew Jaynes
e803952278 Docs: Fix some minor inline documentation syntax issues in the hook docs for the post_edit_category_parent_dropdown_args filter, introduced in [33682].
See #32246. See #33026.


git-svn-id: https://develop.svn.wordpress.org/trunk@33686 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 04:54:00 +00:00
Boone Gorges
57592ef976 Filter the arguments passed to wp_dropdown_categories() in the Categories post edit metabox.
The new 'post_edit_category_parent_dropdown_args' provides parity with other
places in wp-admin where `wp_dropdown_categories()` args are filtered, such as
'taxonomy_parent_dropdown_args'.

Props theMikeD.
Fixes #33026.

git-svn-id: https://develop.svn.wordpress.org/trunk@33682 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-21 01:27:15 +00:00
Scott Taylor
98de66207f Custom Post Types:
* Introduce `is_post_type_viewable( $post_type_object )`
* Separate the HTML bits from the translatable bits in the `post` messages array in `edit-form-advanced.php`
* Don't show certain UI pieces when a post is not viewable on the front end

When a custom post type item is not viewable on the front end, we don't want to show links to View it (on the front end) all over the admin. We also want to hide the Preview link, et al. We also want our admin messages to not contain said links.

Custom post types with `public_queryable` set to `false` are not viewable on the front end. 
`'page'` is viewable on the front end, but `'page'` is a `_builtin` type, and `public_queryable` is set to `false` when it is registered - see `WP::parse_request()` for when `public_queryable` gets used.

This is confusing, but also somewhat straightforward: to determine if a post type is viewable on the front end, we can check one way for `_builtin => true` and another way for `_builtin => false`:

`$post_type->publicly_queryable || ( $post_type->_builtin && $post_type->public )`

If a post type is `publicly_queryable`, it's viewable. If that value is `false`, it is viewable if it's a `_builtin` type that is also `public`.

I am in search of edge cases, so this shall land.

Props wonderboymusic, DrewAPicture.
See #17609.


git-svn-id: https://develop.svn.wordpress.org/trunk@33666 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-20 19:39:57 +00:00
Sergey Biryukov
8e7c0148dc Merge two duplicate strings.
props pavelevap.
fixes #31730.

git-svn-id: https://develop.svn.wordpress.org/trunk@33433 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-26 23:03:52 +00:00
Scott Taylor
53bc964fc1 After [32796], improve the accessibility and markup for instances of touch_time().
Props rianrietveld, afercia.
Fixes #31714.


git-svn-id: https://develop.svn.wordpress.org/trunk@32945 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:30:00 +00:00
Konstantin Obenland
e66948cf50 More semantic markup for the post formats metabox.
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.



git-svn-id: https://develop.svn.wordpress.org/trunk@32720 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-10 09:08:10 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Dominik Schilling (ocean90)
b0d6757918 Use HTTPS URLs for codex.wordpress.org.
see #27115.

git-svn-id: https://develop.svn.wordpress.org/trunk@32116 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-12 21:28:58 +00:00
Dion Hulse
9eb9342a54 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121


git-svn-id: https://develop.svn.wordpress.org/trunk@31862 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-23 02:13:50 +00:00
Scott Taylor
1392d272c2 In the "Send Trackbacks" meta box, the description of how pingbacks work was missing a comma after the introductory clause.
Props cfinke.
Fixes #31668.


git-svn-id: https://develop.svn.wordpress.org/trunk@31830 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-19 04:05:33 +00:00
Helen Hou-Sandi
1c9b51a3e6 Remove the once-placeholder-esque "tag hint", which has not worked in quite some time.
It's not particularly useful, and adds visual noise when in place.

props welcher.
fixes #31485.


git-svn-id: https://develop.svn.wordpress.org/trunk@31607 602fd350-edb4-49c9-b593-d223f7449a82
2015-03-03 21:52:35 +00:00
Helen Hou-Sandi
f11e86fb83 Hide irrelevant UI and display a message when editing the page for posts.
Users are frequently confused as to why the content they've entered or the page template they've selected doesn't apply for this one page. Showing and saving items that don't do anything hurts trust.

Developers can elect to turn on the editor should they be using it for something. If the content isn't empty, the editor will show so that users still have access to their content.

props alexkingorg for the initial, long-suffering patch.
fixes #17470.


git-svn-id: https://develop.svn.wordpress.org/trunk@31550 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-26 02:46:40 +00:00
Helen Hou-Sandi
8d0b774e65 Accessibility: remove remaining instances of accesskey.
It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve.

props afercia.
fixes #29715.


git-svn-id: https://develop.svn.wordpress.org/trunk@31331 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-04 03:45:24 +00:00
Sergey Biryukov
e725b36d1e Don't display the Help tab reference in Page Attributes meta box if Help tab was removed.
props bananastalktome.
fixes #31164.

git-svn-id: https://develop.svn.wordpress.org/trunk@31303 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-30 15:33:33 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Scott Taylor
469164785f Pinking Shears.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31077 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 05:02:05 +00:00
Drew Jaynes (DrewAPicture)
ea4da9e13c 4.1 Docs Audit: Fix a variety of issues with the DocBlock for the default_page_template_title filter.
Includes hyphenating 'drop-down', ensuring the DocBlock itself is correctly indented, and wraps lines at an appropriate length.

See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30601 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-28 08:59:45 +00:00
John Blackbourn
c33b85fd39 Add a filter to the displayed title of the default page template.
Fixes #27178
Props johnstonphilip


git-svn-id: https://develop.svn.wordpress.org/trunk@30360 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 19:32:00 +00:00
Drew Jaynes (DrewAPicture)
a84d50dfa3 Fix some words that aren't words.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29454 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:29:37 +00:00
Sergey Biryukov
8a45aefe56 Escape taxonomy name when used in attributes in post_categories_meta_box().
props pbearne.
fixes #28836.

git-svn-id: https://develop.svn.wordpress.org/trunk@29099 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 18:55:48 +00:00
Drew Jaynes (DrewAPicture)
79dd39c19c Note in the hook docs for preview_post_link that the $post parameter was added.
See #28729.


git-svn-id: https://develop.svn.wordpress.org/trunk@28979 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 20:04:56 +00:00
Sergey Biryukov
8bf7ed77f3 Pass $post object to 'preview_post_link' filter.
props danielbachhuber.
fixes #28729.

git-svn-id: https://develop.svn.wordpress.org/trunk@28969 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-03 14:41:06 +00:00
Scott Taylor
312ef7b264 These functions import $wpdb but do not use it.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28539 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 17:36:42 +00:00
Drew Jaynes (DrewAPicture)
7b2c87df9a Improve inline documentation of default arguments for post_format_meta_box(), post_tags_meta_box(), and post_categories_meta_box().
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28499 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 03:22:21 +00:00
Scott Taylor
bc17731c23 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box().
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:47:03 +00:00
Scott Taylor
ee13be0315 In attachment_submit_meta_box(), remove dead code:
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28298 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 16:44:38 +00:00
Scott Taylor
d8d26a4f79 Cleanup up the display, escaping, and handling of ID3 data for media. Rename wp_get_relevant_id3_keys() to wp_get_attachment_id3_keys().
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27869 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 05:15:39 +00:00
Andrew Nacin
877ffc087f Cleanups for audio/video metadata, see [27862].
see #27574.


git-svn-id: https://develop.svn.wordpress.org/trunk@27864 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 21:07:04 +00:00
Scott Taylor
149f36ed35 Metadata for audio and video files:
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27862 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 19:27:31 +00:00
Andrew Nacin
78b05bc236 Avoid JS errors before the commentReply script loads. Let's make this unobtrusive soon.
props aubreypwd.
fixes #24741.


git-svn-id: https://develop.svn.wordpress.org/trunk@27747 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-26 18:52:31 +00:00
Andrew Nacin
928a972fb5 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context.
see #13265.


git-svn-id: https://develop.svn.wordpress.org/trunk@27470 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 04:18:30 +00:00
Sergey Biryukov
ecbe4f0909 Use a consistent format for translator comments.
props GaryJ.
fixes #27228.

git-svn-id: https://develop.svn.wordpress.org/trunk@27325 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-28 08:08:50 +00:00